Re: [Mesa-dev] [PATCH 2/2] i965: Fix typo in nir_op_pack_double_2x32_split handling

2016-10-17 Thread Iago Toral
On Fri, 2016-10-14 at 10:23 -0700, Ian Romanick wrote: > On 10/08/2016 09:33 AM, Eduardo Lima Mitev wrote: > > > > On 10/08/2016 02:12 AM, Ian Romanick wrote: > > > > > > From: Ian Romanick > > > > > > This was found partially by inspection and partially by hitting a

[Mesa-dev] [Bug 98275] Segmentation fault when using VAAPI acceleration in VLC after installing oibaf's optimized drivers

2016-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98275 --- Comment #1 from Nicolai Hähnle --- Could you please provide a backtrace of the crash? (Make sure that debug symbol packages are installed.) -- You are receiving this mail because: You are the assignee for the bug. You

Re: [Mesa-dev] [PATCH 4/6] util: move min/max/clamp macros to util macros.h

2016-10-17 Thread Nicolai Hähnle
Apart from the comment I sent on the first patch, patch 1&4 are Reviewed-by: Nicolai Hähnle On 14.10.2016 05:16, Dave Airlie wrote: From: Dave Airlie Although the vulkan drivers include mesa macros.h, for radv I'd like to move away from that.

[Mesa-dev] [PATCH] i965/fs/nir: fix double pack from previous unpack optimization

2016-10-17 Thread Iago Toral Quiroga
It seems I initially wrote this as: if (cond_for_opt) { } and then I modified the style at some point to be like: if (!cond_for_opt) continue; But I did not re-write all the conditions accordingly. --- I tested this quickly on a haswell with our fp64 branch and it did not show any

Re: [Mesa-dev] [PATCH] radeonsi: clear DB_RENDER_OVERRIDE

2016-10-17 Thread Nicolai Hähnle
On 13.10.2016 18:54, Marek Olšák wrote: From: Marek Olšák Vulkan doesn't set these fields even though it doesn't use HiS. HiS is disabled by programming DB_SRESULTS_COMPARE_STATEn to 0. This probably has no effect, but it makes sense to handle state more similar to

Re: [Mesa-dev] [PATCH 1/6] util: add vector util code.

2016-10-17 Thread Nicolai Hähnle
On 14.10.2016 05:16, Dave Airlie wrote: From: Dave Airlie This is ported from anv, both anv and radv can share this. Signed-off-by: Dave Airlie --- src/util/Makefile.sources | 4 +- src/util/u_vector.c | 98

Re: [Mesa-dev] [PATCH] egl: remove docs directory from EXTRA_DIST

2016-10-17 Thread Eric Engestrom
On Sunday, 2016-10-16 21:06:25 +1100, Jonathan Gray wrote: > The egl docs directory no longer exists as of > 88b5c36fe1a1546bf633ee161a6715efc593acbd. > > Remove it from EXTRA_DIST to unbreak 'make dist' > > Signed-off-by: Jonathan Gray Reviewed-by: Eric Engestrom

Re: [Mesa-dev] [PATCH v3 25/25] configure.ac: Add required LLVM versions to the top

2016-10-17 Thread Michel Dänzer
On 14/10/16 07:02 PM, Emil Velikov wrote: > On 14 October 2016 at 09:45, Michel Dänzer wrote: >> On 14/10/16 05:14 PM, Emil Velikov wrote: >>> On 14 October 2016 at 01:45, Michel Dänzer wrote: On 13/10/16 07:14 PM, Emil Velikov wrote: > On 13

[Mesa-dev] [Bug 98172] Concurrent call to glClientWaitSync results in segfault in one of the waiters.

2016-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98172 --- Comment #19 from Michel Dänzer --- (In reply to shinji.suzuki from comment #16) > Created attachment 127317 [details] [review] > Arbitration on so->fence through per sync-object mutex. One minor comment below, otherwise

Re: [Mesa-dev] [PATCH 09/10] st/vdpau: implement the new DMA-buf based interop

2016-10-17 Thread Marek Olšák
Reverting the whole commit is too much. You can just remove the PIPE BIND SHARED usage if you need to. Marek On Oct 17, 2016 6:43 AM, "Ilia Mirkin" wrote: > On Thu, Sep 15, 2016 at 4:54 PM, Marek Olšák wrote: > > On Thu, Sep 15, 2016 at 5:14 AM, Dave

Re: [Mesa-dev] anv/radv: WSI sharing code

2016-10-17 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan On 10/17/2016 03:24 PM, Dave Airlie wrote: > This series builds on top of the previous sharing patches I sent. > > The aim here is to share the X11 and wayland WSI code between > the two vulkan drivers so we have a consistent

Re: [Mesa-dev] [PATCH] gallium/hud: Sensor extension is segfaulting.

2016-10-17 Thread Nicolai Hähnle
On 13.10.2016 19:29, Steven Toth wrote: Round two of the patchset, incorporating feedback from nhaeh...@gmail.com The fixes in this set address bugfix #68169, HUD crashing when testing with unigine (heaven). The bug also manifested itself as a lack of data in HUD charts when multiple instanced

Re: [Mesa-dev] [PATCH] radeonsi: shorten "shader->selector" to "sel" in si_shader_create

2016-10-17 Thread Nicolai Hähnle
Reviewed-by: Nicolai Hähnle On 13.10.2016 19:16, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] egl/dri2: add a libname to dlopen for OpenBSD

2016-10-17 Thread Eric Engestrom
On Sunday, 2016-10-16 16:38:35 +1100, Jonathan Gray wrote: > On OpenBSD try to dlopen 'libglapi.so', ld.so will find > the highest major/minor version and open it in this case. > > Avoids '#error Unknown glapi provider for this platform' at build time. > > Signed-off-by: Jonathan Gray

Re: [Mesa-dev] [PATCH] egl/dri2: add a libname to dlopen for OpenBSD

2016-10-17 Thread Jonathan Gray
On Mon, Oct 17, 2016 at 05:34:02PM +0100, Emil Velikov wrote: > On 17 October 2016 at 16:39, Eric Engestrom wrote: > > On Monday, 2016-10-17 22:53:20 +1100, Jonathan Gray wrote: > >> On Mon, Oct 17, 2016 at 12:39:11PM +0100, Emil Velikov wrote: > >> > On 17 October 2016

[Mesa-dev] [Bug 98275] Segmentation fault when using VAAPI acceleration in VLC after installing oibaf's optimized drivers

2016-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98275 --- Comment #3 from Michel Dänzer --- (In reply to lesserbrute from comment #2) > #0 0x7fffc0f9d034 in llvm::cl::AddLiteralOption(llvm::cl::Option&, char > const*) () from /usr/lib/x86_64-linux-gnu/libLLVM-3.9.so.1 > #1

[Mesa-dev] [PATCH] st/va: disable cabac for h264 baseline profile

2016-10-17 Thread boyuan.zhang
From: Boyuan Zhang cabac is only supported in the h264 main and higher profiles Signed-off-by: Boyuan Zhang --- src/gallium/state_trackers/va/picture.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/state_trackers/va/picture.c

Re: [Mesa-dev] [PATCH 05/14] glsl_to_tgsi: reduce the size of glsl_to_tgsi_instruction using bitfields

2016-10-17 Thread Marek Olšák
On Mon, Oct 17, 2016 at 11:54 PM, Dave Airlie wrote: > On 18 October 2016 at 05:23, Marek Olšák wrote: >> On Mon, Oct 17, 2016 at 4:44 PM, Roland Scheidegger >> wrote: >>> Am 17.10.2016 um 15:39 schrieb Marek Olšák: From: Marek

Re: [Mesa-dev] [PATCH 1/6] radeonsi: move LLVM ALU codegen into radeonsi

2016-10-17 Thread Edward O'Callaghan
This series is, Acked-by: Edward O'Callaghan On 10/18/2016 12:44 AM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/drivers/radeon/radeon_llvm.h |9 - > .../drivers/radeon/radeon_setup_tgsi_llvm.c| 979

Re: [Mesa-dev] [PATCH] glsl: optimize list handling in opt_dead_code

2016-10-17 Thread
On Tue, Oct 18, 2016 at 12:45 AM, Thomas Helland wrote: > I can't quite tell, as Gmail tends to mangle whitespace stuff, > but it looks like there might be some style issues with > not everything following the three-space indent, no tabs > policy that mesa tries to

[Mesa-dev] [Bug 98271] [radeonsi]Playing videos with vdpau or vaapi hardware acceleration crashes my pc

2016-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98271 --- Comment #10 from John --- Correct, I have an mpv config with: hwdec=vdpau hwdec-codecs=all vo=opengl-hq The rest shouldn't matter I believe. -- You are receiving this mail because: You are the assignee for the

[Mesa-dev] [Bug 98271] [radeonsi]Playing videos with vdpau or vaapi hardware acceleration crashes my pc

2016-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98271 --- Comment #11 from John --- I tried going back to the commit of 11.0 (so with llvm 3.7) but I still got the issue. I'd guess the bug is in the kernel not mesa, because I don't think I've had the issue for so long, I

Re: [Mesa-dev] [PATCH] glsl: optimize list handling in opt_dead_code

2016-10-17 Thread Dave Airlie
On 18 October 2016 at 08:45, Thomas Helland wrote: > > 18. okt. 2016 00.07 skrev "Jan Ziak" <0xe2.0x9a.0...@gmail.com>: >> >> This patch replaces the ir_variable_refcount_entry's linked-list >> with an array-list. >> >> The array-list has local storage which does not

[Mesa-dev] [PATCH] gallivm: Use native packs and unpacks for the lerps

2016-10-17 Thread sroland
From: Roland Scheidegger For the texturing packs, things looked pretty terrible. For every lerp, we were repacking the values, and while those look sort of cheap with 128bit, with 256bit we end up with 2 of them instead of just 1 but worse, plus 2 extracts too (the unpack,

[Mesa-dev] [Bug 98172] Concurrent call to glClientWaitSync results in segfault in one of the waiters.

2016-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98172 --- Comment #23 from Suzuki, Shinji --- (In reply to Marek Olšák from comment #22) > It would be better to call fence_finish while not holding the mutex. For >mtx_unlock(>mtx); > >if

[Mesa-dev] [PATCH] gm107/ir: fix texturing with indirect samplers

2016-10-17 Thread Ilia Mirkin
The indirect handle has to come right after the coordinates, so if there was a sample/bias/depth compare/offset, everything would end up being shifted by one argument position. Signed-off-by: Ilia Mirkin Cc: mesa-sta...@lists.freedesktop.org ---

[Mesa-dev] [PATCH] gm107/ir: fix bit offset of tex lod setting for indirect texturing

2016-10-17 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin Cc: mesa-sta...@lists.freedesktop.org --- src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp

[Mesa-dev] [PATCH] nv50/ir: use levelZero for texgather and non-frag tex/txp ops

2016-10-17 Thread Ilia Mirkin
radeonsi also does the same thing. I suspect that this is likely to be a no-op in reality, but it brings nouveau code closer to what the blob produces. Plus it makes sense to not try to do auto-derivatives on this. Signed-off-by: Ilia Mirkin ---

Re: [Mesa-dev] [PATCH] nv50/ir: use levelZero for texgather and non-frag tex/txp ops

2016-10-17 Thread Ilia Mirkin
On Tue, Oct 18, 2016 at 12:29 AM, Ilia Mirkin wrote: > radeonsi also does the same thing. I suspect that this is likely to be a > no-op in reality, but it brings nouveau code closer to what the blob > produces. Plus it makes sense to not try to do auto-derivatives on this. >

[Mesa-dev] [Bug 98242] dEQP mandates preprocessor tests for #line expressions and define defined

2016-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98242 --- Comment #5 from Tapani Pälli --- (In reply to Tapani Pälli from comment #4) > It seems Mesa already supports such expressions for #define's, I wonder if > same functionality could be hooked up to parse #line .. just a

Re: [Mesa-dev] [PATCH 12/14] mesa: remove gl_shader_compiler_options::EmitNoFunctions

2016-10-17 Thread Ian Romanick
The only problem is we're going to need this or something similar if we're ever going to fix glsl-vs-inline-explosion.shader_test. On 10/17/2016 06:39 AM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/mesa/main/mtypes.h | 1 - >

[Mesa-dev] [PATCH 2/6] anv/cmd_buffer: Move Begin/End/Execute to genX_cmd_buffer.c

2016-10-17 Thread Jason Ekstrand
vkBeginCommandBuffer and vkCmdExecuteCommands both call into the gen-specific emit_state_base_address function and vkEndCommandBuffer belongs with begin. Signed-off-by: Jason Ekstrand --- src/intel/vulkan/anv_cmd_buffer.c | 94 +

Re: [Mesa-dev] [PATCH 10/14] glsl_to_tgsi: remove subroutine support

2016-10-17 Thread Brian Paul
The series looks OK to me. Acked-by: Brian Paul I guess I have a general question though. Over the years of debugging GL apps I've seen a few that generate pretty huge shaders (in terms of TGSI instructions). I recall one (can't remember the app) in which a moderate

Re: [Mesa-dev] [PATCH 14/14] mesa: remove gl_shader_compiler_options::EmitNoNoise

2016-10-17 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick If we ever want to support the noise built-in functions, we'll have to implement them as functions... that will get inlined. :) On 10/17/2016 06:39 AM, Marek Olšák wrote: > From: Marek Olšák > > it's

[Mesa-dev] [PATCH 6/6] anv: Get rid of anv_cmd_buffer_emit_state_base_address

2016-10-17 Thread Jason Ekstrand
All code that would have once called this can now call the gen-specific version. The switching version is no longer needed. Signed-off-by: Jason Ekstrand --- src/intel/vulkan/anv_cmd_buffer.c | 18 -- src/intel/vulkan/anv_private.h | 2 --

[Mesa-dev] [PATCH 5/6] anv/cmd_buffer: Move descriptor flushing into genX_cmd_buffer.c

2016-10-17 Thread Jason Ekstrand
It really should have gone here all along. We were trying a bit too hard to make it gen-agnostic just because it didn't have any #if's. Signed-off-by: Jason Ekstrand --- src/intel/vulkan/anv_cmd_buffer.c | 314 --- src/intel/vulkan/anv_genX.h

[Mesa-dev] [PATCH 4/6] anv/cmd_buffer: Expose ensure_push_constant_*

2016-10-17 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand --- src/intel/vulkan/anv_cmd_buffer.c | 7 +-- src/intel/vulkan/anv_private.h| 8 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/src/intel/vulkan/anv_cmd_buffer.c b/src/intel/vulkan/anv_cmd_buffer.c index

[Mesa-dev] [PATCH 3/6] anv/cmd_buffer: Unify flush_compute_state across gens

2016-10-17 Thread Jason Ekstrand
With one small genxml change, the two versions were basically identical. The only differences were one #define for HSW+ and a field that is missing on Haswell but exists everywhere else. Signed-off-by: Jason Ekstrand --- src/intel/genxml/gen8.xml | 2 +-

[Mesa-dev] [PATCH 1/6] anv/cmd_buffer: Move state base address re-emit into ExecuteCommands

2016-10-17 Thread Jason Ekstrand
This has two primary advantages. First, it means that the batch_chain code knows less about the actual command buffer contents which is good because improves separation. Second, it means that it only gets re-emitted once after all of the secondaries instead of once after each secondary which is

[Mesa-dev] [PATCH 06/15] ralloc: add a linear allocator as a child node of ralloc

2016-10-17 Thread Marek Olšák
From: Marek Olšák v2: remove goto, cosmetic changes Tested-by: Edmondo Tommasina (v1) --- src/util/ralloc.c | 353 ++ src/util/ralloc.h | 84 - 2 files changed, 433

Re: [Mesa-dev] [PATCH 1/5] intel: genxml: add SAMPLER_BORDER_COLOR_STATE structures

2016-10-17 Thread Jason Ekstrand
On Mon, Oct 17, 2016 at 8:46 AM, Lionel Landwerlin wrote: > Signed-off-by: Lionel Landwerlin > --- > src/intel/genxml/gen6.xml | 32 > src/intel/genxml/gen7.xml | 12 >

Re: [Mesa-dev] [PATCH 5/5] anv: setup appropriate border color structures on gen7/gen75

2016-10-17 Thread Jason Ekstrand
On Mon, Oct 17, 2016 at 8:46 AM, Lionel Landwerlin wrote: > Up to this point we were using the gen8+ structures. Altough this commit > doesn't fixes the border color CTS tests, this is a step in the right > direction to fix the following tests : > It's not entirely clear

Re: [Mesa-dev] [PATCH] st/va: set default rt formats when calling vaCreateConfig

2016-10-17 Thread Mark Thompson
On 17/10/16 17:33, Julien Isorce wrote: > As specified in va.h, default value should be set on attributes > not present in the input list. > > Signed-off-by: Julien Isorce > --- > src/gallium/state_trackers/va/config.c | 9 + >

Re: [Mesa-dev] [PATCH 1/5] intel: genxml: add SAMPLER_BORDER_COLOR_STATE structures

2016-10-17 Thread Lionel Landwerlin
On Mon, 2016-10-17 at 10:56 -0700, Jason Ekstrand wrote: > > > On Mon, Oct 17, 2016 at 8:46 AM, Lionel Landwerlin .com> wrote: > > Signed-off-by: Lionel Landwerlin > > --- > >  src/intel/genxml/gen6.xml  | 32 >

Re: [Mesa-dev] [PATCH 08/14] mesa_to_tgsi: drop support for instructions that can't occur here

2016-10-17 Thread Ian Romanick
I am in favor of these. One of these days I'm planning to remove these instructions from Mesa IR altogether... unless someone beats me to it. Patches 8 and 9 are Reviewed-by: Ian Romanick On 10/17/2016 06:39 AM, Marek Olšák wrote: > From: Marek Olšák

Re: [Mesa-dev] [PATCH] configure.ac: don't require DRM and GBM for surfaceless egl platform

2016-10-17 Thread Marek Olšák
On Mon, Oct 17, 2016 at 7:10 PM, Emil Velikov wrote: > On 17 October 2016 at 17:47, Marek Olšák wrote: >> From: Deepak Sharma >> >> This allows building radeonsi driver for surfaceless platform. >> >> Signed-off-by: Deepak

Re: [Mesa-dev] [PATCH 2/2] st/glsl_to_tgsi: fix block copies of arrays of structs

2016-10-17 Thread Nicolai Hähnle
On 17.10.2016 23:08, Timothy Arceri wrote: On Mon, 2016-10-17 at 19:25 +0200, Nicolai Hähnle wrote: From: Nicolai Hähnle Use a full writemask in this case. This is relevant e.g. when a function has an inout argument which is an array of structs. ---

Re: [Mesa-dev] [PATCH 05/14] glsl_to_tgsi: reduce the size of glsl_to_tgsi_instruction using bitfields

2016-10-17 Thread Dave Airlie
On 18 October 2016 at 05:23, Marek Olšák wrote: > On Mon, Oct 17, 2016 at 4:44 PM, Roland Scheidegger > wrote: >> Am 17.10.2016 um 15:39 schrieb Marek Olšák: >>> From: Marek Olšák >>> >>> sizeof(glsl_to_tgsi_instruction): 464 -> 416

Re: [Mesa-dev] [PATCH] gallium/tgsi: add missing #include

2016-10-17 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan On 10/18/2016 12:40 AM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/auxiliary/tgsi/tgsi_util.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/gallium/auxiliary/tgsi/tgsi_util.h

[Mesa-dev] [PATCH] glsl: optimize list handling in opt_dead_code

2016-10-17 Thread Jan Ziak
This patch replaces the ir_variable_refcount_entry's linked-list with an array-list. The array-list has local storage which does not require ANY additional allocations if the list has small number of elements. The size of this storage is configurable for each variable. Benchmark results for

Re: [Mesa-dev] [PATCH 1/6] anv/cmd_buffer: Move state base address re-emit into ExecuteCommands

2016-10-17 Thread Anuj Phogat
On Mon, Oct 17, 2016 at 10:35 AM, Jason Ekstrand wrote: > This has two primary advantages. First, it means that the batch_chain code > knows less about the actual command buffer contents which is good because > improves separation. Second, it means that it only gets

Re: [Mesa-dev] [PATCH 05/14] glsl_to_tgsi: reduce the size of glsl_to_tgsi_instruction using bitfields

2016-10-17 Thread Dave Airlie
> The motivation for the series was the high malloc call count for > glsl_to_tgsi_instruction, which I observed when I was working on the > GLSL stuff. Decreasing the size of that structure should help with > malloc overhead as well as cache utilization in theory. > > Results with shader-db are

Re: [Mesa-dev] [PATCH] glsl: optimize list handling in opt_dead_code

2016-10-17 Thread Thomas Helland
18. okt. 2016 00.07 skrev "Jan Ziak" <0xe2.0x9a.0...@gmail.com>: > > This patch replaces the ir_variable_refcount_entry's linked-list > with an array-list. > > The array-list has local storage which does not require ANY additional > allocations if the list has small number of elements. The size of

[Mesa-dev] [PATCH] egl/android: fix error in droid_add_configs_for_visuals()

2016-10-17 Thread Tapani Pälli
This was some kind of leftover in commit acd35c8 and format_count array variable (declared in outer scope) should be used instead. Signed-off-by: Tapani Pälli --- src/egl/drivers/dri2/platform_android.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[Mesa-dev] [PATCH mesa] gbm: add a couple missing includes

2016-10-17 Thread Eric Engestrom
Needed for memset() and drmIoctl(). Signed-off-by: Eric Engestrom --- src/gbm/backends/dri/gbm_driint.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gbm/backends/dri/gbm_driint.h b/src/gbm/backends/dri/gbm_driint.h index 1644fac..26376ef 100644 ---

[Mesa-dev] [Bug 98279] [vulkan/radeon] dota2 -vulkan hangs the GPU on R9-390

2016-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98279 Emil Velikov changed: What|Removed |Added CC|emil.l.veli...@gmail.com| --- Comment

Re: [Mesa-dev] [PATCH] egl/android: fix error in droid_add_configs_for_visuals()

2016-10-17 Thread Emil Velikov
On 17 October 2016 at 07:04, Tapani Pälli wrote: > This was some kind of leftover in commit acd35c8 and format_count > array variable (declared in outer scope) should be used instead. > Which brings the question - do we want to enable -Wshadow for the C sources. The C++

Re: [Mesa-dev] [PATCH] egl/dri2: add a libname to dlopen for OpenBSD

2016-10-17 Thread Emil Velikov
On 17 October 2016 at 10:53, Eric Engestrom wrote: > On Sunday, 2016-10-16 16:38:35 +1100, Jonathan Gray wrote: >> On OpenBSD try to dlopen 'libglapi.so', ld.so will find >> the highest major/minor version and open it in this case. >> >> Avoids '#error Unknown glapi

[Mesa-dev] [Bug 98281] 'message's in ctx->Debug.LogMessages[] seem to leak.

2016-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98281 --- Comment #3 from Emil Velikov --- Of the top of my head, it sounds like one is using PushDebugGroup without a corresponding Pop. Can you attach a simple program which reproduces this ? Ideally one which does not

[Mesa-dev] [Bug 98279] [vulkan/radeon] dota2 -vulkan hangs the GPU on R9-390

2016-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98279 --- Comment #2 from Jan Ziak <0xe2.0x9a.0...@gmail.com> --- (In reply to Emil Velikov from comment #1) > Jan, I'm not working on radv, so not sure how I can help here. Dropping > myself from the CC list. Ok. I found your name in

Re: [Mesa-dev] [PATCH] st/nine: Fix multisample limit check

2016-10-17 Thread Emil Velikov
On 16 October 2016 at 23:06, Axel Davy wrote: > I've pushed this just now to be sure it makes it for mesa 13. > Which reminds me that I should beat up our existing get-extra-pick-list.sh to track the offending SHA through the branch and "nominate" the fix. Currently if only

Re: [Mesa-dev] [PATCH v2 05/16] loader: reimplement loader_get_user_preferred_fd via libdrm

2016-10-17 Thread Emil Velikov
On 15 October 2016 at 08:59, Axel Davy wrote: > On 14/10/2016 22:33, Emil Velikov wrote: >> >> On 14 October 2016 at 20:21, Axel Davy wrote: >> >>> The code looks good. With the minor nitpick fixed, this patch is: >>> Reviewed-by: Axel Davy

Re: [Mesa-dev] [PACH v2] glsl: SSBO unsized array declarations, if present, must be declared last

2016-10-17 Thread Iago Toral
On Sun, 2016-10-16 at 17:00 +1100, Timothy Arceri wrote: > On Fri, 2016-10-14 at 14:30 +0200, Iago Toral Quiroga wrote: > > > > From the ARB_shader_storage_buffer_object spec: > > > > "In a shader storage block, the last member may be declared without > > an explicit > >  size.  In this case,

Re: [Mesa-dev] [PATCH] egl/android: fix error in droid_add_configs_for_visuals()

2016-10-17 Thread Eric Engestrom
On Monday, 2016-10-17 09:04:56 +0300, Tapani Pälli wrote: > This was some kind of leftover in commit acd35c8 and format_count > array variable (declared in outer scope) should be used instead. > > Signed-off-by: Tapani Pälli Fixes: acd35c8758dc73240903 ("egl/android:

[Mesa-dev] [Bug 98281] 'message's in ctx->Debug.LogMessages[] seem to leak.

2016-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98281 --- Comment #2 from shinji.suz...@gmail.com --- The amount of memory being in use may be bounded. But I believe there are blocks that don't get released until process termination. Having unreleased memory brings bad user experience to users of

Re: [Mesa-dev] [PATCH mesa] gbm: add a couple missing includes

2016-10-17 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan On 10/17/2016 09:39 PM, Eric Engestrom wrote: > Needed for memset() and drmIoctl(). > > Signed-off-by: Eric Engestrom > --- > src/gbm/backends/dri/gbm_driint.h | 2 ++ > 1 file changed, 2 insertions(+) >

Re: [Mesa-dev] [PATCH 10/14] glsl_to_tgsi: remove subroutine support

2016-10-17 Thread Marek Olšák
On Mon, Oct 17, 2016 at 4:23 PM, Ilia Mirkin wrote: > On Mon, Oct 17, 2016 at 10:20 AM, Marek Olšák wrote: >> I'm adding back this: >> >>options->EmitNoMainReturn = >> !screen->get_shader_param(screen, sh, PIPE_SHADER_CAP_SUBROUTINES); >>

Re: [Mesa-dev] [PATCH] st/va: Default to YUV420 RT format when creating a config

2016-10-17 Thread Mark Thompson
On 17/10/16 15:42, Mark Thompson wrote: > The default will only be used if the VAConfigRTFormat attribute is not > provided by the user. > --- > On 17/10/16 15:21, Julien Isorce wrote: >> Hi Mark, >> >> Thx for the patch. I can see it has already landed. >> >> I just tried it with gstreamer-vaapi

Re: [Mesa-dev] [PATCH 13/14] mesa: remove gl_shader_compiler_options::EmitNoMainReturn

2016-10-17 Thread Marek Olšák
Please ignore this patch. Nouveau wants to support "return" in "main". Marek On Mon, Oct 17, 2016 at 3:39 PM, Marek Olšák wrote: > From: Marek Olšák > > it's always true > --- > src/mesa/drivers/dri/i915/i915_context.c | 1 - >

[Mesa-dev] [PATCH] st/va: Default to YUV420 RT format when creating a config

2016-10-17 Thread Mark Thompson
The default will only be used if the VAConfigRTFormat attribute is not provided by the user. --- On 17/10/16 15:21, Julien Isorce wrote: > Hi Mark, > > Thx for the patch. I can see it has already landed. > > I just tried it with gstreamer-vaapi and it causes problem since they create > the >

[Mesa-dev] [Bug 98271] [radeonsi]Playing videos with vdpau or vaapi hardware acceleration crashes my pc

2016-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98271 --- Comment #5 from John --- Created attachment 127358 --> https://bugs.freedesktop.org/attachment.cgi?id=127358=edit dmesg written by the script before I restart the machine Since there are quite some lines in dmesg

[Mesa-dev] [Bug 98271] [radeonsi]Playing videos with vdpau or vaapi hardware acceleration crashes my pc

2016-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98271 --- Comment #8 from John --- I'll try today to go a bit further than 11.2, if anything in the logs give you an idea of a good starting point please do share. -- You are receiving this mail because: You are the assignee

Re: [Mesa-dev] [PATCH] st/va: Default to YUV420 RT format when creating a config

2016-10-17 Thread Julien Isorce
Hi Mark, Yes I actually saw that too in the intel driver though I think it does not add VA_RT_FORMAT_RGB32 ? Or I missed something ? Maybe this is a bug. In any case yes as said before " the intel va driver always return the full list for vpp." from vaQuerySurfaceAttributes no matter the format

[Mesa-dev] [Bug 98281] 'message's in ctx->Debug.LogMessages[] seem to leak.

2016-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98281 --- Comment #4 from Eero Tamminen --- (In reply to Suzuki, Shinji from comment #2) > The amount of memory being in use may be bounded. But I believe there are > blocks that don't get released until process termination.

Re: [Mesa-dev] [PATCH 05/14] glsl_to_tgsi: reduce the size of glsl_to_tgsi_instruction using bitfields

2016-10-17 Thread Roland Scheidegger
Am 17.10.2016 um 15:39 schrieb Marek Olšák: > From: Marek Olšák > > sizeof(glsl_to_tgsi_instruction): 464 -> 416 > --- > src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 33 > +++--- > 1 file changed, 16 insertions(+), 17 deletions(-) > > diff --git

[Mesa-dev] [Bug 98271] [radeonsi]Playing videos with vdpau or vaapi hardware acceleration crashes my pc

2016-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98271 --- Comment #3 from John --- Well I tried bisecting it today assuming 11.2.2 and got nowhere so I tried at commit3a9f6283f435f90ca1a2901be39ec9d629c95bb6 and it still froze. Because of that I am not sure if that is

[Mesa-dev] [Bug 98271] [radeonsi]Playing videos with vdpau or vaapi hardware acceleration crashes my pc

2016-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98271 --- Comment #4 from John --- Created attachment 127357 --> https://bugs.freedesktop.org/attachment.cgi?id=127357=edit A quick script I wrote to trigger the issue. It takes a video file as an input (I used an X264 mkv

[Mesa-dev] [Bug 98271] [radeonsi]Playing videos with vdpau or vaapi hardware acceleration crashes my pc

2016-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98271 John changed: What|Removed |Added CC||john.etted...@gmail.com

[Mesa-dev] [PATCH 05/14] glsl_to_tgsi: reduce the size of glsl_to_tgsi_instruction using bitfields

2016-10-17 Thread Marek Olšák
From: Marek Olšák sizeof(glsl_to_tgsi_instruction): 464 -> 416 --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 33 +++--- 1 file changed, 16 insertions(+), 17 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp

[Mesa-dev] [PATCH 6/6] radeonsi: rename prefixes from radeon to si

2016-10-17 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_pipe.c | 2 +- src/gallium/drivers/radeonsi/si_shader.c | 96 ++--- src/gallium/drivers/radeonsi/si_shader_internal.h | 70 +- .../drivers/radeonsi/si_shader_tgsi_setup.c

Re: [Mesa-dev] [PATCH] gallium/hud: Sensor extension is segfaulting.

2016-10-17 Thread Brian Paul
For the subject line we usually say what we're fixing. I'd suggest something like "gallium/hud: fix segfault in sensor extension code". -Brian On 10/13/2016 11:29 AM, Steven Toth wrote: Round two of the patchset, incorporating feedback from nhaeh...@gmail.com The fixes in this set address

Re: [Mesa-dev] [PATCH 10/14] glsl_to_tgsi: remove subroutine support

2016-10-17 Thread Marek Olšák
I'm adding back this: options->EmitNoMainReturn = !screen->get_shader_param(screen, sh, PIPE_SHADER_CAP_SUBROUTINES); And: diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index 293654c..5f28d07 100644 ---

Re: [Mesa-dev] [PATCH 3/5] st/va: Return surface formats depending on config chroma format

2016-10-17 Thread Julien Isorce
Hi Mark, Thx for the patch. I can see it has already landed. I just tried it with gstreamer-vaapi and it causes problem since they create the config like this for VPP: va_status = vaCreateConfig (filter->va_display, VAProfileNone, VAEntrypointVideoProc, NULL, 0, >va_config); As you can

[Mesa-dev] [PATCH 2/6] gallium/radeon: remove unused radeon_llvm_reg_index_soa

2016-10-17 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/radeon_llvm.h| 2 -- src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 5 - 2 files changed, 7 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_llvm.h

[Mesa-dev] [PATCH 1/6] radeonsi: move LLVM ALU codegen into radeonsi

2016-10-17 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/radeon_llvm.h |9 - .../drivers/radeon/radeon_setup_tgsi_llvm.c| 979 +-- src/gallium/drivers/radeonsi/Makefile.sources |2 + src/gallium/drivers/radeonsi/si_shader.c

[Mesa-dev] [PATCH 4/6] radeonsi: import all TGSI->LLVM code from gallium/radeon

2016-10-17 Thread Marek Olšák
From: Marek Olšák --- .../drivers/r600/evergreen_compute_internal.h |1 - src/gallium/drivers/radeon/Makefile.sources|6 +- src/gallium/drivers/radeon/radeon_llvm.h | 151 --- src/gallium/drivers/radeon/radeon_llvm_emit.c | 241

Re: [Mesa-dev] [PATCH 10/14] glsl_to_tgsi: remove subroutine support

2016-10-17 Thread Ilia Mirkin
On Mon, Oct 17, 2016 at 9:46 AM, Marek Olšák wrote: > On Mon, Oct 17, 2016 at 3:44 PM, Ilia Mirkin wrote: >> nouveau supports PIPE_SHADER_CAP_SUBROUTINES and properly details with >> RET opcodes. The alternative is that the st lowers the whole thing >>

Re: [Mesa-dev] [PATCH 09/14] mesa_to_tgsi: remove remnants of flow control and subroutine support

2016-10-17 Thread Ilia Mirkin
Patches 1-9 are Reviewed-by: Ilia Mirkin On Mon, Oct 17, 2016 at 9:39 AM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/mesa/state_tracker/st_mesa_to_tgsi.c | 93 > +--- > 1 file changed, 1

Re: [Mesa-dev] [PATCH 10/14] glsl_to_tgsi: remove subroutine support

2016-10-17 Thread Ilia Mirkin
On Mon, Oct 17, 2016 at 10:20 AM, Marek Olšák wrote: > I'm adding back this: > >options->EmitNoMainReturn = > !screen->get_shader_param(screen, sh, PIPE_SHADER_CAP_SUBROUTINES); > > And: > > diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp >

Re: [Mesa-dev] [PATCH] egl/dri2: add a libname to dlopen for OpenBSD

2016-10-17 Thread Jonathan Gray
On Mon, Oct 17, 2016 at 12:39:11PM +0100, Emil Velikov wrote: > On 17 October 2016 at 10:53, Eric Engestrom wrote: > > On Sunday, 2016-10-16 16:38:35 +1100, Jonathan Gray wrote: > >> On OpenBSD try to dlopen 'libglapi.so', ld.so will find > >> the highest major/minor

[Mesa-dev] [Bug 98271] [radeonsi]Playing videos with vdpau or vaapi hardware acceleration crashes my pc

2016-10-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98271 --- Comment #2 from Christian König --- (In reply to John from comment #1) > I may have the same problem, and I know how to trigger it *easily*: Thanks, that is a very valuable information. Going to try to reproduce

[Mesa-dev] [PATCH 07/14] glsl_to_tgsi: allocate glsl_to_tgsi_instruction::tex_offsets on demand

2016-10-17 Thread Marek Olšák
From: Marek Olšák sizeof(glsl_to_tgsi_instruction): 384 -> 264 --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp

[Mesa-dev] [PATCH 02/14] glsl_to_tgsi: remove unused parameters from calc_deref_offsets

2016-10-17 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index 5bc2661..b857a5b 100644 ---

[Mesa-dev] [PATCH 03/14] glsl_to_tgsi: remove unused st_translate::tex_offsets

2016-10-17 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index b857a5b..93673fa 100644 ---

[Mesa-dev] [PATCH 08/14] mesa_to_tgsi: drop support for instructions that can't occur here

2016-10-17 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_mesa_to_tgsi.c | 72 1 file changed, 72 deletions(-) diff --git a/src/mesa/state_tracker/st_mesa_to_tgsi.c b/src/mesa/state_tracker/st_mesa_to_tgsi.c index b989257..c8ed26c 100644 ---

[Mesa-dev] [PATCH 04/14] glsl_to_tgsi: reduce the size of st_dst_reg and st_src_reg

2016-10-17 Thread Marek Olšák
From: Marek Olšák I noticed that glsl_to_tgsi_instruction is too huge. sizeof(glsl_to_tgsi_instruction): 752 -> 464 (-38%) --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 71 +- 1 file changed, 40 insertions(+), 31 deletions(-) diff --git

[Mesa-dev] [PATCH 12/14] mesa: remove gl_shader_compiler_options::EmitNoFunctions

2016-10-17 Thread Marek Olšák
From: Marek Olšák --- src/mesa/main/mtypes.h | 1 - src/mesa/state_tracker/st_extensions.c | 1 - 2 files changed, 2 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index ff20226..5368440 100644 --- a/src/mesa/main/mtypes.h +++

[Mesa-dev] [PATCH 10/14] glsl_to_tgsi: remove subroutine support

2016-10-17 Thread Marek Olšák
From: Marek Olšák Never used. The GLSL compiler doesn't even look at EmitNoFunctions. --- src/mesa/state_tracker/st_extensions.c | 6 +- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 212 + 2 files changed, 7 insertions(+), 211 deletions(-)

Re: [Mesa-dev] [PATCH 10/14] glsl_to_tgsi: remove subroutine support

2016-10-17 Thread Ilia Mirkin
nouveau supports PIPE_SHADER_CAP_SUBROUTINES and properly details with RET opcodes. The alternative is that the st lowers the whole thing into a loop which adds IMHO unnecessary complexity to the resulting code. Any reason not to leave that in place? -ilia On Mon, Oct 17, 2016 at 9:39 AM,

Re: [Mesa-dev] [PATCH 10/14] glsl_to_tgsi: remove subroutine support

2016-10-17 Thread Marek Olšák
On Mon, Oct 17, 2016 at 3:48 PM, Ilia Mirkin wrote: > On Mon, Oct 17, 2016 at 9:46 AM, Marek Olšák wrote: >> On Mon, Oct 17, 2016 at 3:44 PM, Ilia Mirkin wrote: >>> nouveau supports PIPE_SHADER_CAP_SUBROUTINES and properly details

  1   2   >