Re: [Mesa-dev] [PATCH] egl: Emit correct error when robust context creation fails

2016-12-26 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 12/23/2016 03:29 AM, Chad Versace wrote: Fixes dEQP-EGL.functional.create_context_ext.robust_* on Intel with GBM. If the user sets the EGL_CONTEXT_OPENGL_ROBUST_ACCESS_BIT_KHR in EGL_CONTEXT_FLAGS_KHR when creating an OpenGL ES context,

[Mesa-dev] [PATCH 1/8] nir: Make nir_copy_deref follow the "clone" pattern

2016-12-26 Thread Jason Ekstrand
We rename it to nir_deref_clone, re-order the sources to match the other clone functions, and expose nir_deref_var_clone. This past part, in particular, lets us get rid of quite a few lines since we no longer have to call nir_copy_deref and wrap it in deref_to_var. ---

[Mesa-dev] [PATCH 0/8] nir: A few allocation cleanups

2016-12-26 Thread Jason Ekstrand
The first patch in this series is a change I've been meaning to make for some time. I've been running into name collisions with nir_copy_deref and the nir_builder nir_copy_deref_var helper. Also, now that we have lots of other "clone" stuff, it makes sense to make things make them all match.

[Mesa-dev] [PATCH 2/8] nir/from_ssa: Use nir_builder for emit_copy

2016-12-26 Thread Jason Ekstrand
This lets us get rid of the void *mem_ctx parameter and make things a bit more type safe. --- src/compiler/nir/nir_from_ssa.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/src/compiler/nir/nir_from_ssa.c b/src/compiler/nir/nir_from_ssa.c index

[Mesa-dev] [PATCH 7/8] nir/split_var_copies: Use a nir_shader rather than a void *mem_ctx

2016-12-26 Thread Jason Ekstrand
--- src/compiler/nir/nir_split_var_copies.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/compiler/nir/nir_split_var_copies.c b/src/compiler/nir/nir_split_var_copies.c index cfebb0b..94a45ee 100644 --- a/src/compiler/nir/nir_split_var_copies.c +++

[Mesa-dev] [PATCH 5/8] nir/conditional_if: Properly use the builder

2016-12-26 Thread Jason Ekstrand
We were passing around a void *mem_ctx and using that to initialize the builder which was wrong since that pointed to ralloc_parent(impl) which is the shader but the builder is supposed to be initialized with the nir_function_impl. --- src/compiler/nir/nir_opt_conditional_discard.c | 21

[Mesa-dev] [PATCH 8/8] i965/peephole_ffma: Use nir_builder

2016-12-26 Thread Jason Ekstrand
--- .../drivers/dri/i965/brw_nir_opt_peephole_ffma.c | 43 +++--- 1 file changed, 14 insertions(+), 29 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_nir_opt_peephole_ffma.c b/src/mesa/drivers/dri/i965/brw_nir_opt_peephole_ffma.c index 14a9a0f..cc225e1 100644 ---

[Mesa-dev] [PATCH 6/8] nir/opt_peephole_select: Pass around the actual nir_shader

2016-12-26 Thread Jason Ekstrand
--- src/compiler/nir/nir_opt_peephole_select.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/compiler/nir/nir_opt_peephole_select.c b/src/compiler/nir/nir_opt_peephole_select.c index 9c85c17..87a8ee0 100644 --- a/src/compiler/nir/nir_opt_peephole_select.c +++

[Mesa-dev] [PATCH 3/8] nir/lower_io: Use the builder instead of carrying a mem_ctx

2016-12-26 Thread Jason Ekstrand
--- src/compiler/nir/nir_lower_io.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/compiler/nir/nir_lower_io.c b/src/compiler/nir/nir_lower_io.c index 6628947..7dff26b 100644 --- a/src/compiler/nir/nir_lower_io.c +++ b/src/compiler/nir/nir_lower_io.c @@

Re: [Mesa-dev] [PATCH 11/27] gbm: Get modifiers from DRI

2016-12-26 Thread Ben Widawsky
On 16-12-02 09:43:07, Daniel Stone wrote: Hi Ben, On 1 December 2016 at 22:09, Ben Widawsky wrote: @@ -678,6 +679,28 @@ gbm_dri_bo_get_offset(struct gbm_bo *_bo, int plane) return (uint32_t)offset; } +static uint64_t +gbm_dri_bo_get_modifier(struct gbm_bo

Re: [Mesa-dev] [PATCH 1/8] nir: Make nir_copy_deref follow the "clone" pattern

2016-12-26 Thread Jordan Justen
On 2016-12-26 09:13:28, Jason Ekstrand wrote: > We rename it to nir_deref_clone, re-order the sources to match the other > clone functions, and expose nir_deref_var_clone. This past part, in > particular, lets us get rid of quite a few lines since we no longer have > to call nir_copy_deref and