Re: [Mesa-dev] [PATCH] radeonsi: don't forget to add HTILE to the buffer list for texturing

2017-01-19 Thread Edward O'Callaghan
Ah nice catch, Reviewed-by: Edward O'Callaghan On 01/19/2017 08:21 AM, Marek Olšák wrote: > From: Marek Olšák > > This fixes VM faults. Discovered by Samuel Pitoiset. > > Cc: 17.0 13.0 > --- >

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

2017-01-19 Thread Nayan Deshmukh
On Thu, Jan 19, 2017 at 2:07 PM, Christian König wrote: > Am 19.01.2017 um 00:20 schrieb Andy Furniss: >> >> Nayan Deshmukh wrote: >>> >>> On Tue, Jan 17, 2017 at 9:12 PM, Emil Velikov >>> wrote: On 17 January 2017 at 14:55, Nayan

Re: [Mesa-dev] [PATCH] radeonsi: don't forget to add HTILE to the buffer list for texturing

2017-01-19 Thread Nicolai Hähnle
This is good news! Reviewed-by: Nicolai Hähnle On 18.01.2017 22:21, Marek Olšák wrote: From: Marek Olšák This fixes VM faults. Discovered by Samuel Pitoiset. Cc: 17.0 13.0 ---

Re: [Mesa-dev] [PATCH] radeonsi: reject invalid vertex element formats

2017-01-19 Thread Nicolai Hähnle
Reviewed-by: Nicolai Hähnle On 18.01.2017 22:35, Marek Olšák wrote: From: Marek Olšák This should fix a coverity defect. --- src/gallium/drivers/radeonsi/si_state.c | 5 + 1 file changed, 5 insertions(+) diff --git

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

2017-01-19 Thread Christian König
Am 19.01.2017 um 00:20 schrieb Andy Furniss: Nayan Deshmukh wrote: On Tue, Jan 17, 2017 at 9:12 PM, Emil Velikov wrote: On 17 January 2017 at 14:55, Nayan Deshmukh wrote: On Tue, Jan 17, 2017 at 6:25 PM, Christian König

[Mesa-dev] [PATCH v3] st/vdpau: only send buffers with B8G8R8A8 format to X

2017-01-19 Thread Nayan Deshmukh
PresentPixmap only works if the pixmap depth matches with the window depth, otherwise it returns a BadMatch protocol error. Even if the depths match, the result won't look correctly if the VDPAU RGB component order doesn't match the X11 one so we only allow the X11 format. For other buffers we

Re: [Mesa-dev] [RFC] st/mesa: Add both front and back buffers for double-buffer visuals

2017-01-19 Thread Boyan Ding
2017-01-18 18:23 GMT+08:00 Józef Kucia : > On Wed, Jan 18, 2017 at 2:25 AM, Boyan Ding wrote: >> I don't think I find that. The only place in state tracker where >> _mesa_add_renderbuffer is called is st_framebuffer_create and only one >> of the

Re: [Mesa-dev] [PATCH 2/2] android: add vulkan build for intel

2017-01-19 Thread Tapani Pälli
On 01/19/2017 09:10 AM, Tapani Pälli wrote: fixes to issues spotted by Emil Velikov: - set ANV_TIMESTAMP corretly - fix typo with VULKAN_GEM_FILES v2: update to use Makefile.sources under vulkan instead of having own v3: update to changes to generate from vk.xml (commit

Re: [Mesa-dev] [PATCH] radeonsi: don't forget to add HTILE to the buffer list for texturing

2017-01-19 Thread Samuel Pitoiset
On 01/19/2017 10:51 AM, Samuel Pitoiset wrote: On 01/18/2017 10:21 PM, Marek Olšák wrote: From: Marek Olšák This fixes VM faults. Discovered by Samuel Pitoiset. Cc: 17.0 13.0 Bugzilla:

Re: [Mesa-dev] [PATCH] radeonsi: don't forget to add HTILE to the buffer list for texturing

2017-01-19 Thread Samuel Pitoiset
On 01/19/2017 11:29 AM, Samuel Pitoiset wrote: On 01/19/2017 10:51 AM, Samuel Pitoiset wrote: On 01/18/2017 10:21 PM, Marek Olšák wrote: From: Marek Olšák This fixes VM faults. Discovered by Samuel Pitoiset. Cc: 17.0 13.0

[Mesa-dev] [PATCH v4] st/vdpau: only send buffers with B8G8R8A8 format to X

2017-01-19 Thread Nayan Deshmukh
PresentPixmap only works if the pixmap depth matches with the window depth, otherwise it returns a BadMatch protocol error. Even if the depths match, the result won't look correctly if the VDPAU RGB component order doesn't match the X11 one so we only allow the X11 format. For other buffers we

Re: [Mesa-dev] [PATCH v3] st/vdpau: only send buffers with B8G8R8A8 format to X

2017-01-19 Thread Christian König
Am 19.01.2017 um 10:07 schrieb Nayan Deshmukh: PresentPixmap only works if the pixmap depth matches with the window depth, otherwise it returns a BadMatch protocol error. Even if the depths match, the result won't look correctly if the VDPAU RGB component order doesn't match the X11 one so we

Re: [Mesa-dev] [PATCH v2] st/vdpau: only send buffers with B8G8R8A8 format to X

2017-01-19 Thread Christian König
Am 19.01.2017 um 07:45 schrieb Michel Dänzer: On 19/01/17 02:10 PM, Nayan Deshmukh wrote: PresentPixmap only works if the pixmap depth and format matches with the window, otherwise it returns a BadMatch protocol error. Nitpick: PresentPixmap only returns BadMatch if the depths don't match. It

Re: [Mesa-dev] [PATCH v2] mesa/main: Fix FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE for NONE attachment type

2017-01-19 Thread Alejandro Piñeiro
On 19/01/17 05:33, Iago Toral wrote: > On Wed, 2017-01-18 at 16:48 -0200, Alejandro Piñeiro wrote: >> When the attachment type is NONE (att->Type), >> FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE should be NONE too. >> >> Note that technically, the current behaviour follows the spec. From >> OpenGL 4.5

Re: [Mesa-dev] [PATCH] radeonsi: don't forget to add HTILE to the buffer list for texturing

2017-01-19 Thread Samuel Pitoiset
On 01/19/2017 11:41 AM, Samuel Pitoiset wrote: On 01/19/2017 11:29 AM, Samuel Pitoiset wrote: On 01/19/2017 10:51 AM, Samuel Pitoiset wrote: On 01/18/2017 10:21 PM, Marek Olšák wrote: From: Marek Olšák This fixes VM faults. Discovered by Samuel Pitoiset. Cc:

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

2017-01-19 Thread Andy Furniss
Christian König wrote: Am 19.01.2017 um 00:20 schrieb Andy Furniss: Nayan Deshmukh wrote: On Tue, Jan 17, 2017 at 9:12 PM, Emil Velikov wrote: On 17 January 2017 at 14:55, Nayan Deshmukh wrote: On Tue, Jan 17, 2017 at 6:25 PM, Christian

[Mesa-dev] [Bug 97879] [amdgpu] Rocket League: long hangs (several seconds) when loading assets (models/textures/shaders?)

2017-01-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97879 himl...@gmx.de changed: What|Removed |Added CC||himl...@gmx.de -- You are receiving

Re: [Mesa-dev] [PATCH] radeonsi: don't forget to add HTILE to the buffer list for texturing

2017-01-19 Thread Samuel Pitoiset
On 01/18/2017 10:21 PM, Marek Olšák wrote: From: Marek Olšák This fixes VM faults. Discovered by Samuel Pitoiset. Cc: 17.0 13.0 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98975 ---

[Mesa-dev] [PATCH 1/2] nir: Fix searching for 32-bit signed integers.

2017-01-19 Thread Eric Anholt
The python code stores the integer match values to the 64-bit unsigned field, so 32-bit values like 0xff00 don't get sign extended. However, ~0 gets printed as -0x1, so it does get stored as ~0ull. To be able to match both ways that the python code generates integers, cast the 64-bit int

Re: [Mesa-dev] [PATCH v2 06/20] i965/fs: fix dst stride in IVB/BYT type conversions

2017-01-19 Thread Samuel Iglesias Gonsálvez
On Wed, 2017-01-18 at 12:44 -0800, Francisco Jerez wrote: > Samuel Iglesias Gonsálvez writes: > > > On Tue, 2017-01-17 at 13:26 -0800, Francisco Jerez wrote: > > > Samuel Iglesias Gonsálvez writes: > > > > > > > From: "Juan A. Suarez Romero"

[Mesa-dev] [PATCH 2/2] nir: Add an optimization for a common path in vc4 blending.

2017-01-19 Thread Eric Anholt
This cuts 1 or 2 instructions in 3 different glmark2 tests. --- src/compiler/nir/nir_opt_algebraic.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/compiler/nir/nir_opt_algebraic.py b/src/compiler/nir/nir_opt_algebraic.py index d7ad1f2fbf3f..1136bfe826b0 100644 ---

Re: [Mesa-dev] [PATCH] radeonsi: reject invalid vertex element formats

2017-01-19 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan On 01/19/2017 08:35 AM, Marek Olšák wrote: > From: Marek Olšák > > This should fix a coverity defect. > --- > src/gallium/drivers/radeonsi/si_state.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

2017-01-19 Thread Christian König
Hi Andy, Am 19.01.2017 um 11:46 schrieb Andy Furniss: I think you are right about the slices, the failing vids are blu-ray/tv. https://drive.google.com/file/d/0BxP5-S1t9VEEZlozcjVUZ1lDbWM/view?usp=sharing Thanks for the link, if you have time please give the attached patch a try. It

Re: [Mesa-dev] [PATCH] radeonsi: fix texture gather on stencil textures

2017-01-19 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Jan 18, 2017 at 9:32 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > At least on VI, texture gather doesn't work with a 24_8 data format, so > use 8_8_8_8 and a modified swizzle

Re: [Mesa-dev] [PATCH] radeonsi: fix texture gather on stencil textures

2017-01-19 Thread Edward O'Callaghan
Acked-by: Edward O'Callaghan On 01/18/2017 07:32 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > At least on VI, texture gather doesn't work with a 24_8 data format, so > use 8_8_8_8 and a modified swizzle instead. > > A bit of

Re: [Mesa-dev] [PATCH] radeonsi: don't forget to add HTILE to the buffer list for texturing

2017-01-19 Thread Marek Olšák
On Thu, Jan 19, 2017 at 12:03 PM, Samuel Pitoiset wrote: > > > On 01/19/2017 11:41 AM, Samuel Pitoiset wrote: >> >> >> >> On 01/19/2017 11:29 AM, Samuel Pitoiset wrote: >>> >>> >>> >>> On 01/19/2017 10:51 AM, Samuel Pitoiset wrote: On 01/18/2017

[Mesa-dev] [Bug 99446] [anv] (and radv) Regression enabling Vulkan loader interface version 3

2017-01-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99446 --- Comment #2 from Emil Velikov --- Issue sounds like a old libvulkan. We might be able to workaround that in the drivers, but the version used and a back trace (as mentioned by Bas) is needed. -- You are receiving

[Mesa-dev] [PATCH] i965/blorp: Add also depth buffer to render cache

2017-01-19 Thread Topi Pohjolainen
CC: Francisco Jerez CC: Kenneth Graunke CC: Jason Ekstrand Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/genX_blorp_exec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[Mesa-dev] [PATCH v3] mesa/main: Fix FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE for NONE attachment type

2017-01-19 Thread Alejandro Piñeiro
When the attachment type is NONE (att->Type), FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE should be NONE always. Note that technically, the current behaviour follows the spec. From OpenGL 4.5 spec, Section 9.2.3 "Framebuffer Object Queries": "If the value of FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE is NONE,

Re: [Mesa-dev] [PATCH v3] mesa/main: Fix FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE for NONE attachment type

2017-01-19 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Thu, 2017-01-19 at 11:36 -0200, Alejandro Piñeiro wrote: > When the attachment type is NONE (att->Type), > FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE should be NONE always. > > Note that technically, the current behaviour follows the spec. From >

[Mesa-dev] [PATCH v5 0/7] etnaviv: update derived texture resources of (re)imported buffers

2017-01-19 Thread Philipp Zabel
Hi, this is a resend of the earlier series to get weston / wayland_egl working on etnaviv, now using SCR_INIT to wrap resource_changed only if it is implemented by the wrapped pipe_screen. regards Philipp Changes since v4: - Added Christian's Reviewed-by tags - Use SCR_INIT to initialize the

[Mesa-dev] [PATCH v5 1/7] gallium: add pipe_screen::resource_changed

2017-01-19 Thread Philipp Zabel
Add a hook to tell drivers that an imported resource may have changed and they need to update their internal derived resources. Signed-off-by: Philipp Zabel Reviewed-by: Roland Scheidegger --- src/gallium/docs/source/screen.rst | 14 ++

[Mesa-dev] [PATCH v5 4/7] etnaviv: implement resource_changed to invalidate internal resources derived from imported buffers

2017-01-19 Thread Philipp Zabel
Implement the resource_changed pipe callback to invalidate internal resources derived from imported buffers. This is needed to update the texture for re-imported renderables. Signed-off-by: Philipp Zabel Reviewed-by: Reviewed-by: Christian Gmeiner

[Mesa-dev] [PATCH v5 7/7] gallium: add pipe_screen::resource_changed callback wrappers

2017-01-19 Thread Philipp Zabel
Add resource_changed to the ddebug, rbug, and trace wrappers. Since it is optional, there is no need to add it to noop. Signed-off-by: Philipp Zabel Suggested-by: Nicolai Hähnle --- Changes since v4: - Use SCR_INIT to initialize the resource_changed

[Mesa-dev] [PATCH v5 2/7] st/dri: ask the driver to update its internal copies on reimport

2017-01-19 Thread Philipp Zabel
For imported buffers that can't be used directly as a source to the texture samplers, the pipe driver might need to create an internal copy, for example in a different tiling layout. When buffers are reimported they may contain new image data, so the driver internal copies need to be recreated.

[Mesa-dev] [PATCH v5 3/7] etnaviv: initialize seqno of imported resources

2017-01-19 Thread Philipp Zabel
Imported resources already have contents that we want to be copied to texture resources derived from them. Set initial seqno of imported resources to 1, just as if it had already been rendered to. Signed-off-by: Philipp Zabel Reviewed-by: Christian Gmeiner

[Mesa-dev] [Bug 97967] glsl/tests/cache-test regression

2017-01-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97967 Emil Velikov changed: What|Removed |Added Resolution|--- |FIXED

[Mesa-dev] [Bug 98471] [TRACKER] Mesa 13.0 release tracker

2017-01-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98471 Bug 98471 depends on bug 97967, which changed state. Bug 97967 Summary: glsl/tests/cache-test regression https://bugs.freedesktop.org/show_bug.cgi?id=97967 What|Removed |Added

Re: [Mesa-dev] [PATCH] radeonsi: don't forget to add HTILE to the buffer list for texturing

2017-01-19 Thread Samuel Pitoiset
On 01/19/2017 02:11 PM, Marek Olšák wrote: On Thu, Jan 19, 2017 at 12:03 PM, Samuel Pitoiset wrote: On 01/19/2017 11:41 AM, Samuel Pitoiset wrote: On 01/19/2017 11:29 AM, Samuel Pitoiset wrote: On 01/19/2017 10:51 AM, Samuel Pitoiset wrote: On

[Mesa-dev] [PATCH v2 1/5] r600: double multiply can handle only one multiply at a time

2017-01-19 Thread Nicolai Hähnle
From: Nicolai Hähnle It seems clear that trying to multiply two pairs of doubles would result in the temporary register getting overwritten by the second pair. So make the code more explicit. --- src/gallium/drivers/r600/r600_shader.c | 36

[Mesa-dev] [PATCH v2 2/5] r600: factor out cayman_emit_unary_double_raw

2017-01-19 Thread Nicolai Hähnle
From: Nicolai Hähnle We will use it for DDIV. --- src/gallium/drivers/r600/r600_shader.c | 62 +++--- 1 file changed, 42 insertions(+), 20 deletions(-) diff --git a/src/gallium/drivers/r600/r600_shader.c

[Mesa-dev] [PATCH v2 5/5] st/glsl_to_tgsi: use DDIV instead of DRCP + DMUL

2017-01-19 Thread Nicolai Hähnle
From: Nicolai Hähnle Fixes GL45-CTS.gpu_shader_fp64.built_in_functions. v2: use DDIV unconditionally Reviewed-by: Roland Scheidegger (v1) Reviewed-by: Marek Olšák (v1) --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 9

[Mesa-dev] [PATCH v2 0/5] r600/radeonsi/st/mesa: use DDIV instead of DRCP + DMUL

2017-01-19 Thread Nicolai Hähnle
Hi all, here's a v2 without the pipe cap. Reminder: this requires DDIV support in nvc0, r600, and radeonsi. Ilia took care of nvc0, and I already did radeonsi. The thing is, it turns out I don't have an R600 that does double-precision. So testing would be very much appreciated, e.g. using

[Mesa-dev] [PATCH v2 4/5] glsl: split DIV_TO_MUL_RCP into single- and double-precision flags

2017-01-19 Thread Nicolai Hähnle
From: Nicolai Hähnle Reviewed-by: Marek Olšák Reviewed-by: Iago Toral Quiroga --- src/compiler/glsl/ir_optimization.h | 4 +++- src/compiler/glsl/lower_instructions.cpp | 19 +++ 2 files changed, 14

[Mesa-dev] [PATCH v2 3/5] r600: implement DDIV

2017-01-19 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/drivers/r600/r600_shader.c | 59 ++ 1 file changed, 59 insertions(+) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/r600/r600_shader.c index 5c4bc91..eaabb04 100644 ---

[Mesa-dev] [PATCH v5 5/7] mesa: update external textures when (re-)binding

2017-01-19 Thread Philipp Zabel
To comply with the requirement from the GL_OES_EGL_image_external extension that a call to glBindTexture guarantees that all further sampling will return values that correspond to the values in the external texture at or after the time that glBindTexture was called, do not bail out early from

[Mesa-dev] [PATCH v5 6/7] st/mesa: ask pipe driver to recreate derived internal resources when (re-)binding external textures

2017-01-19 Thread Philipp Zabel
Use the resource_changed callback to invalidate internal resources derived from external textures when they are (re-)bound. This is needed to comply with the requirement from the GL_OES_EGL_image_external extension that a call to glBindTexture guarantees that all further sampling will return

[Mesa-dev] [ANNOUNCE] mesa 17.0.0-rc1

2017-01-19 Thread Emil Velikov
The first release candidate for Mesa 17.0.0 is now available. The plan is to have one release candidate every Friday, until the final release on 3rd February 2016. As a reminder, with the 17.0 branch now created, patches nominated with: CC: will now

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

2017-01-19 Thread Andy Furniss
Andy Furniss wrote: Christian König wrote: Hi Andy, Am 19.01.2017 um 11:46 schrieb Andy Furniss: I think you are right about the slices, the failing vids are blu-ray/tv. https://drive.google.com/file/d/0BxP5-S1t9VEEZlozcjVUZ1lDbWM/view?usp=sharing Thanks for the link, if you have time

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

2017-01-19 Thread Andy Furniss
Christian König wrote: Hi Andy, Am 19.01.2017 um 11:46 schrieb Andy Furniss: I think you are right about the slices, the failing vids are blu-ray/tv. https://drive.google.com/file/d/0BxP5-S1t9VEEZlozcjVUZ1lDbWM/view?usp=sharing Thanks for the link, if you have time please give the attached

Re: [Mesa-dev] [PATCH 4/5] configure: explicitly require shared glapi for enable-dri

2017-01-19 Thread Emil Velikov
On 19 January 2017 at 00:18, Steven Newbury wrote: > On Wed, 2016-12-07 at 13:25 +, Emil Velikov wrote: >> From: Emil Velikov >> >> We've been using and depending on it for at least a couple of years. >> Make it obvious and error out, should

[Mesa-dev] [PATCH] configure.ac: move require_dri_shared_libs_and_glapi() before its users

2017-01-19 Thread Emil Velikov
From: Emil Velikov Otherwise we'll get a lovely message as below: "require_dri_shared_libs_and_glapi: command not found" Cc: Steven Newbury Reported-by: Steven Newbury Fixes: da410e6afad "configure: explicitly require

Re: [Mesa-dev] [PATCH] radeonsi: don't forget to add HTILE to the buffer list for texturing

2017-01-19 Thread Marek Olšák
On Thu, Jan 19, 2017 at 2:51 PM, Samuel Pitoiset wrote: > > > On 01/19/2017 02:11 PM, Marek Olšák wrote: >> >> On Thu, Jan 19, 2017 at 12:03 PM, Samuel Pitoiset >> wrote: >>> >>> >>> >>> On 01/19/2017 11:41 AM, Samuel Pitoiset wrote:

Re: [Mesa-dev] [PATCH] i965: Delete pending CCS and HiZ ops in intel_miptree_make_shareable()

2017-01-19 Thread Chad Versace
On Thu 19 Jan 2017, Jason Ekstrand wrote: > Reviewed-by: Jason Ekstrand And pushed. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] swr: Prune empty nodes in CalculateProcessorTopology.

2017-01-19 Thread Kyriazis, George
Bruce, I think you have to add the cc: line in the message body, and not cc mesa-stable explicitly, as described in http://www.mesa3d.org/devinfo.html. I could be wrong, though. Otherwise, Reviewed-By: George Kyriazis Thanks, George > -Original Message-

[Mesa-dev] [PATCH] swr: Prune empty nodes in CalculateProcessorTopology.

2017-01-19 Thread Bruce Cherniak
CalculateProcessorTopology tries to figure out system topology by parsing /proc/cpuinfo to determine the number of threads, cores, and NUMA nodes. There are some architectures where the "physical id" begins with 1 rather than 0, which was creating and empty "0" node and causing a crash in

[Mesa-dev] Time to update GSoC/EVoC ideas page

2017-01-19 Thread Rob Clark
Just a friendly reminder that now would be a good time to update the wiki page for GSoC/EVoC ideas: https://www.x.org/wiki/SummerOfCodeIdeas/ There are currently still some stale ideas there (and probably plenty of missing good ideas). Also, I've added a "Potential Mentors" section. Please

Re: [Mesa-dev] [PATCH v2 06/20] i965/fs: fix dst stride in IVB/BYT type conversions

2017-01-19 Thread Francisco Jerez
Samuel Iglesias Gonsálvez writes: > On Wed, 2017-01-18 at 12:44 -0800, Francisco Jerez wrote: >> Samuel Iglesias Gonsálvez writes: >> >> > On Tue, 2017-01-17 at 13:26 -0800, Francisco Jerez wrote: >> > > Samuel Iglesias Gonsálvez

Re: [Mesa-dev] [PATCH 4/6] configure.ac: Set and use HAVE_GALLIUM_LLVM define

2017-01-19 Thread Tobias Droste
Am Mittwoch, 18. Januar 2017, 18:45:04 CET schrieb Emil Velikov: > On 18 January 2017 at 18:12, Jose Fonseca wrote: > >>> In order to untangle things we want to have a distinction between the > >>> gallium (gallivm afaict) and other users - RADV presently. > >>> So how about

Re: [Mesa-dev] [PATCH] i965: Delete pending CCS and HiZ ops in intel_miptree_make_shareable()

2017-01-19 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Wed, Jan 4, 2017 at 12:33 PM, Chad Versace wrote: > Fixes crash in piglit > `egl_khr_gl_renderbuffer_image-clear-shared-image GL_DEPTH_COMPONENT24` > on Skylake. > > The crash happened because blorp attempted to

Re: [Mesa-dev] [PATCH v2 3/5] r600: implement DDIV

2017-01-19 Thread Nicolai Hähnle
On 19.01.2017 19:42, Roland Scheidegger wrote: Am 19.01.2017 um 18:45 schrieb Ilia Mirkin: On Thu, Jan 19, 2017 at 12:40 PM, Nicolai Hähnle wrote: On 19.01.2017 17:50, Ilia Mirkin wrote: NVIDIA can't do division either (double or otherwise - but double is even worse

Re: [Mesa-dev] [PATCH] glsl/standalone: add missing do_mat_op_to_vec() pass

2017-01-19 Thread Kenneth Graunke
On Thursday, January 19, 2017 1:16:18 PM PST Rob Clark wrote: > glsl_to_nir expects matrix ops to be lowered away to vector by the time > it runs, but standalone wasn't bothering to call this pass. > > Signed-off-by: Rob Clark > --- > src/compiler/glsl/standalone.cpp | 1 +

Re: [Mesa-dev] [PATCH v2 06/20] i965/fs: fix dst stride in IVB/BYT type conversions

2017-01-19 Thread Matt Turner
On Thu, Jan 19, 2017 at 4:50 AM, Samuel Iglesias Gonsálvez wrote: > As we are blocking the release and there more patches for review, > another possibility is to land this patch [2] (replacing this patch) > and then fix it later to not block Mesa 17.0 release more than

Re: [Mesa-dev] [PATCH 4/4] i965/blorp: Make post draw flush more explicit

2017-01-19 Thread Jason Ekstrand
On Wed, Jan 18, 2017 at 11:25 PM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Wed, Jan 18, 2017 at 01:54:43PM -0800, Jason Ekstrand wrote: > >On Jan 18, 2017 1:47 PM, "Francisco Jerez" <[1]curroje...@riseup.net> > >wrote: > > > >Topi Pohjolainen

[Mesa-dev] [Bug 99388] RHEL 7.3, Matlab 2016a Segmentation fault - glEnable

2017-01-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99388 Asya Dvorkin changed: What|Removed |Added CC|

[Mesa-dev] [PATCH] glsl/standalone: add missing do_mat_op_to_vec() pass

2017-01-19 Thread Rob Clark
glsl_to_nir expects matrix ops to be lowered away to vector by the time it runs, but standalone wasn't bothering to call this pass. Signed-off-by: Rob Clark --- src/compiler/glsl/standalone.cpp | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [Mesa-dev] [PATCH] i965: Delete pending CCS and HiZ ops in intel_miptree_make_shareable()

2017-01-19 Thread Chad Versace
+jason, juan Juan, here is the patch I mentioned earlier. It seems I had already sent it to the list. It fixes the bug not by inserting additional checks before trying to execute hiz ops, because that's just a workaround for the real issue. The real issue is that intel_miptree_make_shareable()

Re: [Mesa-dev] [PATCH v2 3/5] r600: implement DDIV

2017-01-19 Thread Roland Scheidegger
Am 19.01.2017 um 18:45 schrieb Ilia Mirkin: > On Thu, Jan 19, 2017 at 12:40 PM, Nicolai Hähnle > wrote: >> On 19.01.2017 17:50, Ilia Mirkin wrote: >>> >>> NVIDIA can't do division either (double or otherwise - but double is >>> even worse since the rcp is only half

Re: [Mesa-dev] [PATCH] i965/blorp: Add also depth buffer to render cache

2017-01-19 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand Reviewed-by: Kenneth Graunke On Thu, Jan 19, 2017 at 5:29 AM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > CC: Francisco Jerez > CC: Kenneth Graunke > CC: Jason

Re: [Mesa-dev] [PATCH] i965/blorp: Add also depth buffer to render cache

2017-01-19 Thread Jason Ekstrand
On Thu, Jan 19, 2017 at 12:40 PM, Francisco Jerez wrote: > "Pohjolainen, Topi" writes: > > > On Thu, Jan 19, 2017 at 12:10:02PM -0800, Francisco Jerez wrote: > >> Topi Pohjolainen writes: > >> > >> > CC: Francisco

Re: [Mesa-dev] [PATCH] i965/blorp: Add also depth buffer to render cache

2017-01-19 Thread Francisco Jerez
Topi Pohjolainen writes: > CC: Francisco Jerez > CC: Kenneth Graunke > CC: Jason Ekstrand > Signed-off-by: Topi Pohjolainen > --- >

Re: [Mesa-dev] [PATCH] i965/blorp: Add also depth buffer to render cache

2017-01-19 Thread Pohjolainen, Topi
On Thu, Jan 19, 2017 at 12:10:02PM -0800, Francisco Jerez wrote: > Topi Pohjolainen writes: > > > CC: Francisco Jerez > > CC: Kenneth Graunke > > CC: Jason Ekstrand > > Signed-off-by: Topi

Re: [Mesa-dev] [PATCH] i965/blorp: Add also depth buffer to render cache

2017-01-19 Thread Francisco Jerez
"Pohjolainen, Topi" writes: > On Thu, Jan 19, 2017 at 12:10:02PM -0800, Francisco Jerez wrote: >> Topi Pohjolainen writes: >> >> > CC: Francisco Jerez >> > CC: Kenneth Graunke >> > CC: Jason

Re: [Mesa-dev] [PATCH v2] i965: check if HiZ buffer is available

2017-01-19 Thread Chad Versace
On Wed 18 Jan 2017, Juan A. Suarez Romero wrote: > Commit 42011be1e disabled HiZ when sharing depth buffer externally, > which free HiZ buffer. > > But in emit_depth_packets() we use that buffer, which generates a crash > in >

[Mesa-dev] [PATCH] gallium/hud: add missing break in hud_cpufreq_graph_install()

2017-01-19 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/gallium/auxiliary/hud/hud_cpufreq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/auxiliary/hud/hud_cpufreq.c b/src/gallium/auxiliary/hud/hud_cpufreq.c index 19a6f08c4f..78754b28a9 100644 ---

[Mesa-dev] [Bug 99465] vtn_vector_construct writing out of bounds when given multiple non-zero length sources

2017-01-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99465 Bug ID: 99465 Summary: vtn_vector_construct writing out of bounds when given multiple non-zero length sources Product: Mesa Version: 13.0 Hardware: Other

Re: [Mesa-dev] [PATCH 01/12] glcpp: Print preprocessor output to string_buffer

2017-01-19 Thread Vladislav Egorov
19.01.2017 01:46, Ian Romanick пишет: On 01/07/2017 11:02 AM, Vladislav Egorov wrote: glcpp's printing is an obvious low hanging fruit: 1. It unnecessarily uses formatted printing to print output of preprocessing. To print just one character '+' it first uses vsnprintf("%s", "+") to

Re: [Mesa-dev] [PATCH 4/6] configure.ac: Set and use HAVE_GALLIUM_LLVM define

2017-01-19 Thread Emil Velikov
On 19 January 2017 at 19:26, Tobias Droste wrote: > Am Mittwoch, 18. Januar 2017, 18:45:04 CET schrieb Emil Velikov: >> On 18 January 2017 at 18:12, Jose Fonseca wrote: >> >>> In order to untangle things we want to have a distinction between the >> >>>

Re: [Mesa-dev] [PATCH] gallium/hud: add missing break in hud_cpufreq_graph_install()

2017-01-19 Thread Emil Velikov
On 20 January 2017 at 00:19, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset Fixes: e99b9395bef "gallium/hud: Add support for CPU frequency monitoring" Cc: mesa-sta...@lists.freedesktop.org Reviewed-by: Emil Velikov

[Mesa-dev] [PATCH 10/31] radv: extend shader stage code to cover geometry shaders.

2017-01-19 Thread Dave Airlie
From: Dave Airlie This enables the paths for setting up user ptrs to vs/es and gs. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_cmd_buffer.c | 30 ++ 1 file changed, 22 insertions(+), 8 deletions(-) diff --git

[Mesa-dev] [PATCH 01/31] radv: program a default point size.

2017-01-19 Thread Dave Airlie
From: Dave Airlie Along the lines of what 3b804819 anv: Default PointSize to 1.0 if not written by the shader does for anv, program a default point size in the hw of 1.0. This preempt fixes a bunch of geom shader tests. Signed-off-by: Dave Airlie ---

[Mesa-dev] [PATCH 12/31] radv/ac: propogate as_es flag into shader info from key.

2017-01-19 Thread Dave Airlie
From: Dave Airlie This just places the flag into the shader info so we can use it from the driver after we create the shader. Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 3 +++ src/amd/common/ac_nir_to_llvm.h | 1 + 2 files changed,

[Mesa-dev] [PATCH 21/31] radv/ac: handle gs inputs

2017-01-19 Thread Dave Airlie
From: Dave Airlie This handles geometry shader inputs written by the vertex (es) shader to the esgs ring. Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 56 + 1 file changed, 56 insertions(+)

[Mesa-dev] [PATCH 19/31] radv/ac: handle invocation and primitive id intrinsics

2017-01-19 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 3336a3d..21eeff0 100644 ---

[Mesa-dev] [PATCH 03/31] radv: add code to set gs_table_depth.

2017-01-19 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_device.c | 32 src/amd/vulkan/radv_private.h | 2 ++ 2 files changed, 34 insertions(+) diff --git a/src/amd/vulkan/radv_device.c

[Mesa-dev] [PATCH 07/31] radv/ac: add geom shader sendmsg defines.

2017-01-19 Thread Dave Airlie
From: Dave Airlie This just adds some defines needed for geom shaders. Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 8 1 file changed, 8 insertions(+) diff --git a/src/amd/common/ac_nir_to_llvm.c

[Mesa-dev] [PATCH 04/31] radv: fixup ia multi vgt param code to handle geom shaders.

2017-01-19 Thread Dave Airlie
From: Dave Airlie This fixes up afew of the commented out blocks. Signed-off-by: Dave Airlie --- src/amd/vulkan/si_cmd_buffer.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/src/amd/vulkan/si_cmd_buffer.c

[Mesa-dev] [PATCH 06/31] radv/ac: add some geom shader info from nir->ac shader.

2017-01-19 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 6 ++ src/amd/common/ac_nir_to_llvm.h | 6 ++ 2 files changed, 12 insertions(+) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c

[Mesa-dev] [PATCH 02/31] radv: add small helper to denote when a geom shader is in the pipeline.

2017-01-19 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_private.h | 5 + 1 file changed, 5 insertions(+) diff --git a/src/amd/vulkan/radv_private.h b/src/amd/vulkan/radv_private.h index 0b8f50a..7e8c5fc 100644 ---

[Mesa-dev] [PATCH 08/31] radv/ac: handle geom shader sgpr/vgpr inputs

2017-01-19 Thread Dave Airlie
From: Dave Airlie This just sets up the gpr inputs. Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 39 +++ src/amd/common/ac_nir_to_llvm.h | 2 ++ 2 files changed, 41 insertions(+) diff --git

[Mesa-dev] [PATCH 14/31] radv: pass some necessary gs info back to state handling.

2017-01-19 Thread Dave Airlie
From: Dave Airlie We need this info to program some registers. Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 5 + src/amd/common/ac_nir_to_llvm.h | 2 ++ 2 files changed, 7 insertions(+) diff --git

[Mesa-dev] [PATCH 18/31] radv/ac: handle geometry emit vertex and end prim intrinsics.

2017-01-19 Thread Dave Airlie
From: Dave Airlie This handles emitting things to the gsvs ring, and sending the correct GS msgs. Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 126 1 file changed, 126 insertions(+) diff

[Mesa-dev] [PATCH 13/31] radv: emit vertex shader to correct hw block.

2017-01-19 Thread Dave Airlie
From: Dave Airlie This emits the shader to the ES block in the correct case. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_cmd_buffer.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 05/31] radv: move hw vertex shader emit to separate function

2017-01-19 Thread Dave Airlie
From: Dave Airlie This is to later allow ES shaders to be emitted. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_cmd_buffer.c | 69 +++- 1 file changed, 40 insertions(+), 29 deletions(-) diff --git

[Mesa-dev] [PATCH 15/31] radv/ac: setup function parameters for vs as es and copy shader.

2017-01-19 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 49 +++-- 1 file changed, 32 insertions(+), 17 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c

[Mesa-dev] [PATCH 16/31] radv/ac: add copy shader creation

2017-01-19 Thread Dave Airlie
From: Dave Airlie This create the gs copy shader and compiles it. Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 81 + src/amd/common/ac_nir_to_llvm.h | 7 2 files changed, 88 insertions(+)

[Mesa-dev] [PATCH 11/31] radv: fix max slice calculations for color/depth setup

2017-01-19 Thread Dave Airlie
From: Dave Airlie For layered bindings we need to use an alternate value. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_device.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_device.c

[Mesa-dev] [rfc] radv geometry shader support

2017-01-19 Thread Dave Airlie
This is a first pass at geometry shader support on radv, all the code should be here in reviewable pieces, it seems to mostly pass CTS tests but triggers some llvm 3.9 bugs around kill, and there might still be a GPU hang in here, but this should still be a good place to start reviewing. Dave.

[Mesa-dev] [Bug 99465] vtn_vector_construct writing out of bounds when given multiple non-zero length sources

2017-01-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99465 Michel Dänzer changed: What|Removed |Added CC||ja...@jlekstrand.net

Re: [Mesa-dev] [Mesa-stable] [PATCH] swr: Prune empty nodes in CalculateProcessorTopology.

2017-01-19 Thread Emil Velikov
On 19 January 2017 at 22:47, Kyriazis, George wrote: > Bruce, > > I think you have to add the cc: line in the message body, and not cc > mesa-stable explicitly, as described in http://www.mesa3d.org/devinfo.html. > I could be wrong, though. > Yes that's correct.

  1   2   >