Re: [Mesa-dev] Time to update GSoC/EVoC ideas page

2017-01-23 Thread Daniel Vetter
On Fri, Jan 20, 2017 at 08:44:19AM -0800, Jason Ekstrand wrote: > On Fri, Jan 20, 2017 at 2:15 AM, Nicolai Hähnle wrote: > > > Hi Rob, > > > > On 19.01.2017 23:32, Rob Clark wrote: > > > >> Just a friendly reminder that now would be a good time to update the > >> wiki page

[Mesa-dev] [Bug 99496] Dolphin emulator: Launching Mario Kart Wii results in a blank window/black screen and freeze.

2017-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99496 Christian Lanig changed: What|Removed |Added Summary|Dolphin emulator displays |Dolphin

Re: [Mesa-dev] [PATCH v2] nir/spirv/glsl450: rewrite atan2 to deal with infinities

2017-01-23 Thread Juan A. Suarez Romero
On Sun, 2017-01-22 at 00:20 -0800, Francisco Jerez wrote: > "Juan A. Suarez Romero" writes: > > > Rewrite atan2(y,x) to cover (+/-)INF values. > > > > This fixes several test cases in Vulkan CTS > > (dEQP-VK.glsl.builtin.precision.atan2.*) > > > > v2: do not flush denorms

Re: [Mesa-dev] [PATCH 2/4] i965: Use a better guardband calculation.

2017-01-23 Thread Ilia Mirkin
On Mon, Jan 23, 2017 at 1:42 AM, Kenneth Graunke wrote: > + *ymin = MIN2(ndc_gb_ymin, ndc_gb_ymax); Should this be limited on the negative end of the range? > + *ymax = MIN2(MAX2(ndc_gb_ymin, ndc_gb_ymax), 16383); And should this be a different value for gen6?

Re: [Mesa-dev] [PATCH 3/3] i965: Use correct VertStride on align16 instructions.

2017-01-23 Thread Samuel Iglesias Gonsálvez
On Fri, 2017-01-20 at 14:25 -0800, Francisco Jerez wrote: > Matt Turner writes: > > > In commit c35fa7a, we changed the "width" of DF source registers to > > 2, > > which is conceptually fine. Unfortunately a VertStride of 2 is not > > allowed by align16 instructions on

Re: [Mesa-dev] [PATCH] gbm-dri: Duplicate image after checking its format.

2017-01-23 Thread Eric Engestrom
On Wednesday, 2016-12-21 10:55:28 +0100, mateuszx.potr...@intel.com wrote: > From: Mateusz Polrola > > If image will be duplicated before checking if its format is supported > it may leak memory, as duplicated image for non supported formats is > not being destroyed.

[Mesa-dev] [Bug 98833] [REGRESSION, bisected] Wayland revert commit breaks non-Vsync fullscreen frame updates

2017-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98833 Eero Tamminen changed: What|Removed |Added Summary|[REGRESSION, bisected] |[REGRESSION,

[Mesa-dev] [Bug 98471] [TRACKER] Mesa 13.0 release tracker

2017-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98471 Eero Tamminen changed: What|Removed |Added Depends on||98833

[Mesa-dev] [PATCH mesa] gbm/dri: fix memory leaks in error path

2017-01-23 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/gbm/backends/dri/gbm_dri.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c index 45cb42a862..ef96185848 100644 ---

[Mesa-dev] [Bug 99496] Dolphin emulator: Launching Mario Kart Wii results in a blank window/black screen and freeze.

2017-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99496 --- Comment #3 from Grazvydas Ignotas --- Same issue here on RX 470, seems to not depend on the game (or happens on most). There was some basic debugging done which showed that the command stream doesn't even start to be

Re: [Mesa-dev] [PATCH 0/3] i965: IVB/BYT fp64 fixes

2017-01-23 Thread Samuel Iglesias Gonsálvez
On Fri, 2017-01-20 at 13:35 -0800, Matt Turner wrote: > I committed my EU validator earlier today. It's caught three bugs in > the IVB > fp64 series. Patches 2 and 3 fix two of them. I'll respond directly > to the > patch in Igalia's series that introduces the other bug. > OK, while waiting for

Re: [Mesa-dev] [PATCH 4/6] configure.ac: Set and use HAVE_GALLIUM_LLVM define

2017-01-23 Thread Jose Fonseca
On 20/01/17 02:48, Emil Velikov wrote: On 19 January 2017 at 19:26, Tobias Droste wrote: Am Mittwoch, 18. Januar 2017, 18:45:04 CET schrieb Emil Velikov: On 18 January 2017 at 18:12, Jose Fonseca wrote: In order to untangle things we want to have a

Re: [Mesa-dev] [PATCH 1/4] i965: Combine the Gen6 SF and Clip viewport atoms.

2017-01-23 Thread Pohjolainen, Topi
On Sun, Jan 22, 2017 at 10:42:16PM -0800, Kenneth Graunke wrote: > The next patch will make the guardband calculation dependent on the > transformation matrix. Instead of computing it in both atoms, just > combine them into a single atom. > > Signed-off-by: Kenneth Graunke

Re: [Mesa-dev] [PATCH] mesa: Enable EXT_compressed_ETC1_RGB8_sub_texture

2017-01-23 Thread Manolova, Plamena
Thank you for reviewing guys! AFAIK this extension is a driver-side feature and can be enabled for all drivers that support ETC1. I'll go ahead and update my patch. On Fri, Jan 20, 2017 at 6:25 PM, Jason Ekstrand wrote: > On Fri, Jan 20, 2017 at 10:16 AM, Ilia Mirkin

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

2017-01-23 Thread Nayan Deshmukh
The patch is Reviewed-by: Nayan Deshmukh On Mon, Jan 23, 2017 at 7:01 PM, Christian König wrote: > Ah, yes of course. If we delay creating the decoder we need to call > begin_frame() again as well. > > Please review and/or test the attached

Re: [Mesa-dev] [PATCH mesa] drirc: remove spurious tabs

2017-01-23 Thread Eric Engestrom
On Friday, 2017-01-06 19:08:39 +1100, Edward O'Callaghan wrote: > Reviewed-by: Edward O'Callaghan Thanks; can you push this for me please? Cheers, Eric > > On 01/06/2017 08:06 AM, Eric Engestrom wrote: > > Signed-off-by: Eric Engestrom > >

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

2017-01-23 Thread Christian König
Ah, yes of course. If we delay creating the decoder we need to call begin_frame() again as well. Please review and/or test the attached patch. Andy I did understand you right that this is already a Tested-by from your side, isn't it? I am wondering if calling decode_bitstream one at a time

[Mesa-dev] [Bug 97967] glsl/tests/cache-test regression

2017-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97967 --- Comment #8 from Tapani Pälli --- (In reply to Timothy Arceri from comment #7) > The real issue is these MAX_SIZE limits are far too small. Arguably we > should handle it anyway or maybe apply a minimum size. hmm let me

Re: [Mesa-dev] [PATCH] i965/blorp: Add also depth buffer to render cache

2017-01-23 Thread Pohjolainen, Topi
On Fri, Jan 20, 2017 at 08:40:50AM -0800, Jason Ekstrand wrote: >On Thu, Jan 19, 2017 at 11:48 PM, Pohjolainen, Topi ><[1]topi.pohjolai...@gmail.com> wrote: > > On Thu, Jan 19, 2017 at 01:39:49PM -0800, Jason Ekstrand wrote: > >On Thu, Jan 19, 2017 at 12:40 PM, Francisco

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

2017-01-23 Thread Andy Furniss
Christian König wrote: Ah, yes of course. If we delay creating the decoder we need to call begin_frame() again as well. Please review and/or test the attached patch. Andy I did understand you right that this is already a Tested-by from your side, isn't it? Yes, this patch seems OK.

Re: [Mesa-dev] [PATCH] st/mesa: destroy pipe_context before destroying st_context

2017-01-23 Thread Nicolai Hähnle
Looks like there's a problem with the error path at the end of st_create_context_priv (line ~506): it calls st_destroy_context_priv which will now destroy the pipe, which then leads to a double-destroy by the caller. Just setting st->pipe = NULL; would be enough. Nicolai On 20.01.2017

Re: [Mesa-dev] [PATCH 7/7] radeonsi: handle first_non_void correctly in si_create_vertex_elements

2017-01-23 Thread Nicolai Hähnle
When does it happen that first_non_void < 0? Doesn't this require PIPE_FORMAT_NONE, and why would that occur? Nicolai On 20.01.2017 20:07, Marek Olšák wrote: From: Marek Olšák Cc: 17.0 --- src/gallium/drivers/radeonsi/si_state.c | 6

Re: [Mesa-dev] [PATCH] mesa: Enable EXT_compressed_ETC1_RGB8_sub_texture

2017-01-23 Thread Ilia Mirkin
Yeah, sounds like you can reuse the OES_compressed_ETC1_RGB8_texture enable bit. On Mon, Jan 23, 2017 at 9:31 AM, Manolova, Plamena wrote: > Thank you for reviewing guys! AFAIK this extension is a driver-side feature > and can be enabled for all drivers that support

Re: [Mesa-dev] [PATCH v2 09/20] i965/fs: indirect addressing with doubles is not supported in IVB/BYT

2017-01-23 Thread Samuel Iglesias Gonsálvez
On Fri, 2017-01-20 at 13:41 -0800, Matt Turner wrote: > On Tue, Jan 17, 2017 at 1:49 AM, Samuel Iglesias Gonsálvez > wrote: > > It is tested empirically that IVB/BYT don't support indirect > > addressing > > with doubles but it is not documented in the PRM. > > > > This

Re: [Mesa-dev] [PATCH 6/7] radeonsi: always set the TCL1_ACTION_ENA when invalidating L2

2017-01-23 Thread Nicolai Hähnle
On 20.01.2017 20:07, Marek Olšák wrote: From: Marek Olšák Some CIK-VI docs say this is the default behavior on SI. That doesn't answer whether it's also the default behavior on CIK-VI. Have you actually seen this fix anything? Seems reasonable to me anyway, so patches

Re: [Mesa-dev] [PATCH mesa] drirc: remove spurious tabs

2017-01-23 Thread Nicolai Hähnle
Pushed, thanks. On 23.01.2017 14:29, Eric Engestrom wrote: On Friday, 2017-01-06 19:08:39 +1100, Edward O'Callaghan wrote: Reviewed-by: Edward O'Callaghan Thanks; can you push this for me please? Cheers, Eric On 01/06/2017 08:06 AM, Eric Engestrom wrote:

Re: [Mesa-dev] [PATCH v2] nir/spirv/glsl450: rewrite atan2 to deal with infinities

2017-01-23 Thread Francisco Jerez
"Juan A. Suarez Romero" writes: > On Sun, 2017-01-22 at 00:20 -0800, Francisco Jerez wrote: >> "Juan A. Suarez Romero" writes: >> >> > Rewrite atan2(y,x) to cover (+/-)INF values. >> > >> > This fixes several test cases in Vulkan CTS >> >

[Mesa-dev] [PATCH 1/2] vulkan: import latest registry for 1.0.39 extensions.

2017-01-23 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- src/vulkan/registry/vk.xml | 450 - 1 file changed, 408 insertions(+), 42 deletions(-) diff --git a/src/vulkan/registry/vk.xml b/src/vulkan/registry/vk.xml

[Mesa-dev] [PATCH 2/2] radv: implement VK_KHR_GET_PHYSICAL_DEVICE_PROPERTIES_2

2017-01-23 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_device.c | 38 +- src/amd/vulkan/radv_formats.c | 36 2 files changed, 73 insertions(+), 1 deletion(-) diff

[Mesa-dev] [PATCH 5/6] anv: Return better errors from AllocateDescriptorSets

2017-01-23 Thread Jason Ekstrand
v2: I need to learn to compile-test my patches --- src/intel/vulkan/anv_descriptor_set.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_descriptor_set.c b/src/intel/vulkan/anv_descriptor_set.c index a5e65af..a4b7638 100644 ---

[Mesa-dev] [Bug 97102] [dri][swr] stack overflow / infinite loop with GALLIUM_DRIVER=swr

2017-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97102 Jan Ziak <0xe2.0x9a.0...@gmail.com> changed: What|Removed |Added Resolution|--- |FIXED

[Mesa-dev] [PATCH] vulkan: bump vulkan.h to 1.0.39 version

2017-01-23 Thread Dave Airlie
From: Dave Airlie This introduces a bunch of new extension defines. Signed-off-by: Dave Airlie --- include/vulkan/vulkan.h | 367 +++- 1 file changed, 365 insertions(+), 2 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] i965/blorp: Use the correct ISL format for combined depth/stencil

2017-01-23 Thread Jason Ekstrand
On Mon, Jan 23, 2017 at 11:48 AM, Ilia Mirkin wrote: > On Mon, Jan 23, 2017 at 2:42 PM, Jason Ekstrand > wrote: > > In brw_blorp_copyteximage, we use the format from the render buffer. > > This could be a combined depth/stencil format. In this case,

Re: [Mesa-dev] [PATCH] i965/blorp: Use the correct ISL format for combined depth/stencil

2017-01-23 Thread Ilia Mirkin
On Mon, Jan 23, 2017 at 2:58 PM, Jason Ekstrand wrote: > On Mon, Jan 23, 2017 at 11:48 AM, Ilia Mirkin wrote: >> >> On Mon, Jan 23, 2017 at 2:42 PM, Jason Ekstrand >> wrote: >> > In brw_blorp_copyteximage, we use the format from

[Mesa-dev] [PATCH] anv: Implement VK_KHR_get_physical_device_properties2

2017-01-23 Thread Chad Versace
Implement each vkFoo2KHR() by trivially passing it through to the original vkFoo(). --- I tested this patch with a little demo app, but I haven't ran any CTS tests with it. If CTS tests do exit (I'm searching for them now), I'll run them against this patch before pushing.

Re: [Mesa-dev] [PATCH 5/6] anv: Return better errors from AllocateDescriptorSets

2017-01-23 Thread Ilia Mirkin
On Mon, Jan 23, 2017 at 5:12 PM, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_descriptor_set.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/src/intel/vulkan/anv_descriptor_set.c > b/src/intel/vulkan/anv_descriptor_set.c > index

Re: [Mesa-dev] [PATCH] anv: Implement VK_KHR_get_physical_device_properties2

2017-01-23 Thread Jason Ekstrand
On Mon, Jan 23, 2017 at 2:28 PM, Chad Versace wrote: > Implement each vkFoo2KHR() by trivially passing it through to the > original vkFoo(). > As I mentioned to Lionel when he wrote basically this exact same patch, I think that may be backwards. I can see two ways of

[Mesa-dev] [PATCH] i965/blorp: Use the correct ISL format for combined depth/stencil

2017-01-23 Thread Jason Ekstrand
In brw_blorp_copyteximage, we use the format from the render buffer. This could be a combined depth/stencil format. In this case, we handle stencil properly but we give blorp the wrong ISL format. Specifically, we would give blorp ISL_FORMAT_R32G32B32A32_FLOAT which is the wrong size was causing

[Mesa-dev] [PATCH] gallium/radeon: add a new HUD query for the number of mapped buffers

2017-01-23 Thread Samuel Pitoiset
Useful when debugging applications which map too much VRAM. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeon/r600_query.c | 4 src/gallium/drivers/radeon/r600_query.h | 1 + src/gallium/drivers/radeon/radeon_winsys.h| 1 +

Re: [Mesa-dev] [PATCH] radv: don't resubmit the same cs over and over while tracing

2017-01-23 Thread Bas Nieuwenhuizen
Pushed, thanks. On Mon, Jan 23, 2017 at 10:16 PM, Grazvydas Ignotas wrote: > Fixes: 97dfff54 ("radv: Dump command buffer on hang.") > Signed-off-by: Grazvydas Ignotas > --- > no commit access > > src/amd/vulkan/radv_device.c | 3 +-- > 1 file changed, 1

Re: [Mesa-dev] [PATCH 4/6] configure.ac: Set and use HAVE_GALLIUM_LLVM define

2017-01-23 Thread Tobias Droste
Am Montag, 23. Januar 2017, 11:53:18 CET schrieb Jose Fonseca: > On 20/01/17 02:48, Emil Velikov wrote: > > On 19 January 2017 at 19:26, Tobias Droste wrote: > >> Am Mittwoch, 18. Januar 2017, 18:45:04 CET schrieb Emil Velikov: > >>> On 18 January 2017 at 18:12, Jose Fonseca

Re: [Mesa-dev] [PATCH] i965/blorp: Use the correct ISL format for combined depth/stencil

2017-01-23 Thread Ilia Mirkin
On Mon, Jan 23, 2017 at 2:42 PM, Jason Ekstrand wrote: > In brw_blorp_copyteximage, we use the format from the render buffer. > This could be a combined depth/stencil format. In this case, we handle > stencil properly but we give blorp the wrong ISL format. Specifically, >

[Mesa-dev] [PATCH] radv: don't resubmit the same cs over and over while tracing

2017-01-23 Thread Grazvydas Ignotas
Fixes: 97dfff54 ("radv: Dump command buffer on hang.") Signed-off-by: Grazvydas Ignotas --- no commit access src/amd/vulkan/radv_device.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index

[Mesa-dev] [PATCH 4/6] anv: Allow selecting the slice of a 3D image

2017-01-23 Thread Jason Ekstrand
As per VK_KHR_maintenance1, clients can render to a slice of a 3D image by creating a VK_IMAGE_VIEW_TYPE_2D view of it. --- src/intel/vulkan/anv_image.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index

[Mesa-dev] [PATCH 2/6] anv: Add trivial support for TrimCommandPoolKHR

2017-01-23 Thread Jason Ekstrand
Our command buffers already efficiently use a global pool so trimming doesn't really need to do anything. --- src/intel/vulkan/anv_cmd_buffer.c | 8 1 file changed, 8 insertions(+) diff --git a/src/intel/vulkan/anv_cmd_buffer.c b/src/intel/vulkan/anv_cmd_buffer.c index d882c18..3a23048

[Mesa-dev] [PATCH 5/6] anv: Return better errors from AllocateDescriptorSets

2017-01-23 Thread Jason Ekstrand
--- src/intel/vulkan/anv_descriptor_set.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_descriptor_set.c b/src/intel/vulkan/anv_descriptor_set.c index a5e65af..2d9734d 100644 --- a/src/intel/vulkan/anv_descriptor_set.c +++

Re: [Mesa-dev] [PATCH] anv: Implement VK_KHR_get_physical_device_properties2

2017-01-23 Thread Chad Versace
On Mon 23 Jan 2017, Jason Ekstrand wrote: > On Mon, Jan 23, 2017 at 2:28 PM, Chad Versace > wrote: > > Implement each vkFoo2KHR() by trivially passing it through to the > original vkFoo(). > > > As I mentioned to Lionel when he wrote basically this exact same

[Mesa-dev] [PATCH] radv: add back ability to gen some entrypoints from optional headers (v2)

2017-01-23 Thread Dave Airlie
From: Dave Airlie bf8e1f9e7 radv: generate entrypoints from vk.xml ripped out the ability to add extra header files (and writing extra xml files is a bit messier). For some non-public development or even developing future EXT/MESA extensions, it would be nice to allow this

[Mesa-dev] [PATCH 13/37] glsl: add basic support for resource list to shader cache

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri This initially adds support for simple uniforms and varyings. --- src/compiler/glsl/shader_cache.cpp | 121 + 1 file changed, 121 insertions(+) diff --git a/src/compiler/glsl/shader_cache.cpp

[Mesa-dev] [PATCH 05/37] mesa: add new MESA_GLSL flag for printing shader cache debug info

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri --- docs/shading.html | 1 + src/mesa/main/mtypes.h| 1 + src/mesa/main/shaderapi.c | 2 ++ 3 files changed, 4 insertions(+) diff --git a/docs/shading.html b/docs/shading.html index b0ed249..e44035a 100644 --- a/docs/shading.html

[Mesa-dev] [PATCH 19/37] glsl: add shader cache support for buffer blocks

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri --- src/compiler/glsl/shader_cache.cpp | 163 + 1 file changed, 163 insertions(+) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index 9ed1c4e..29fc70a 100644 ---

[Mesa-dev] [PATCH 17/37] glsl: add support for caching subroutines

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri --- src/compiler/glsl/shader_cache.cpp | 107 + 1 file changed, 107 insertions(+) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index 9bbbf1f..b5468a9 100644 ---

[Mesa-dev] [PATCH 18/37] glsl: store subroutine remap table in shader cache

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri --- src/compiler/glsl/shader_cache.cpp | 57 ++ 1 file changed, 51 insertions(+), 6 deletions(-) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index b5468a9..9ed1c4e

[Mesa-dev] [PATCH 15/37] glsl: skip linking when current program has been retrieved from cache

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri The scenario is a program has been linked for the first time and we cache the program metadata, then glLinkProgram() is called for a second time. Since we will now retrieve the program metadata from cache we need to skip linking. ---

[Mesa-dev] [PATCH 20/37] glsl: add support for caching atomic buffers

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri --- src/compiler/glsl/shader_cache.cpp | 89 ++ 1 file changed, 89 insertions(+) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index 29fc70a..9db4f25 100644 ---

[Mesa-dev] [PATCH 21/37] glsl: cache some more image metadata

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri --- src/compiler/glsl/shader_cache.cpp | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index 9db4f25..358eb4f 100644 ---

[Mesa-dev] [PATCH 09/37] glsl: add helper to convert pointers to uint64_t

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri This will be used to store all pointers in the cache as 64bit ints allowing us to avoid issues when a 32bit program reads a cached shader that was created by a 64bit application. --- src/compiler/glsl/shader_cache.h | 10 ++ 1 file

[Mesa-dev] [PATCH 11/37] glsl: Serialize three additional hash tables with program metadata

2017-01-23 Thread Timothy Arceri
From: Carl Worth The three additional tables are AttributeBindings, FragDataBindings, and FragDataIndexBindings. The first table (AttributeBindings) was identified as missing by trying to test the shader cache with a program that called glGetAttribLocation. Many thanks to

[Mesa-dev] [PATCH 12/37] glsl: fix uniform remap table cache when explicit locations used

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri --- src/compiler/glsl/shader_cache.cpp | 32 +--- 1 file changed, 25 insertions(+), 7 deletions(-) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index a6f8238..ff35f69 100644

[Mesa-dev] [PATCH 10/37] glsl: make use of on disk shader cache

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri The hash key for glsl metadata is a hash of the hashes of each GLSL source string. This commit uses the put_key/get_key support in the cache put the SHA-1 hash of the source string for each successfully compiled shader into the cache. This

[Mesa-dev] [PATCH 16/37] glsl: add support for caching shaders with xfb qualifiers

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri For now this disables the shader cache when transform feedback is enabled via the GL API as we don't currently allow for it when generating the sha for the shader. --- src/compiler/glsl/linker.cpp | 14 -

[Mesa-dev] [PATCH 14/37] glsl: add shader cache support for samplers

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri --- src/compiler/glsl/shader_cache.cpp | 18 ++ 1 file changed, 18 insertions(+) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index 4a144ea..1093726 100644 ---

[Mesa-dev] [PATCH 07/37] glsl: add param to force shader recompile

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri This will be used to skip checking the cache and force a recompile. --- src/compiler/glsl/glsl_parser_extras.cpp | 2 +- src/compiler/glsl/program.h | 2 +- src/compiler/glsl/standalone.cpp | 3 ++-

Re: [Mesa-dev] [PATCH] anv: Implement VK_KHR_get_physical_device_properties2

2017-01-23 Thread Jason Ekstrand
On Mon, Jan 23, 2017 at 3:31 PM, Chad Versace wrote: > On Mon 23 Jan 2017, Jason Ekstrand wrote: > > On Mon, Jan 23, 2017 at 2:28 PM, Chad Versace > wrote: > > > > Implement each vkFoo2KHR() by trivially passing it through to the > >

Re: [Mesa-dev] [PATCH 06/37] util: add a disk_cache_remove() function

2017-01-23 Thread Timothy Arceri
Apologies if you are wondering where this is used. This patch really should be before patch 24. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 0/2] Reduce CCS_E-related Resolves

2017-01-23 Thread Nanley Chery
This series increases Dota 2 frame rates by about 2.61% on a SKL GT4 at 1080p. The first patch contributes to most of the gain. In the long-term, I think we'll want to rework our CCS implementation to perform resolves upon layout transitions. This will reduce the bandwidth consumed by resolves.

Re: [Mesa-dev] [PATCH] i965/blorp: Use the correct ISL format for combined depth/stencil

2017-01-23 Thread Jason Ekstrand
On Mon, Jan 23, 2017 at 4:53 PM, Chad Versace wrote: > On Mon 23 Jan 2017, Jason Ekstrand wrote: > > In brw_blorp_copyteximage, we use the format from the render buffer. > > This could be a combined depth/stencil format. In this case, we handle > > stencil properly but

[Mesa-dev] [PATCH 1/2] anv/cmd_buffer: Don't temporarily enable CCS_E within a render pass

2017-01-23 Thread Nanley Chery
Compressing a render target and decompressing it in the same single-subpass render pass may waste bandwidth. While this may be beneficial in some circumstances, it does not help in all. Cc: "13.0 17.0" Signed-off-by: Nanley Chery ---

[Mesa-dev] [PATCH 2/2] anv/blorp: Disable partial resolves for transparent black clears

2017-01-23 Thread Nanley Chery
Cc: "13.0 17.0" Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_blorp.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c index

Re: [Mesa-dev] [PATCH 1/2] anv/cmd_buffer: Don't temporarily enable CCS_E within a render pass

2017-01-23 Thread Jason Ekstrand
On Mon, Jan 23, 2017 at 5:40 PM, Nanley Chery wrote: > On Mon, Jan 23, 2017 at 05:30:22PM -0800, Jason Ekstrand wrote: > > On Mon, Jan 23, 2017 at 4:55 PM, Nanley Chery > wrote: > > > > > Compressing a render target and decompressing it in the same

[Mesa-dev] [Bug 97102] [dri][swr] stack overflow / infinite loop with GALLIUM_DRIVER=swr

2017-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97102 --- Comment #13 from Bruce Cherniak --- I pushed the change that corrects the crash you were seeing. This is the same as Tim's suggestion to prune empty nodes. I don't know all the other topologies well enough to

[Mesa-dev] [PATCH 2/2] r600g: add support for optionally using non-IEEE mul ops

2017-01-23 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- Untested. Can be verified with Xnine. It should pass before 1/2 of this series, start failing with it, and pass again with 2/2 in place. src/gallium/drivers/r600/r600_pipe.c | 2 +- src/gallium/drivers/r600/r600_shader.c | 20

Re: [Mesa-dev] [PATCH 3/3] i965: Use correct VertStride on align16 instructions.

2017-01-23 Thread Matt Turner
On Mon, Jan 23, 2017 at 2:59 AM, Samuel Iglesias Gonsálvez wrote: > On Fri, 2017-01-20 at 14:25 -0800, Francisco Jerez wrote: >> Matt Turner writes: >> >> > In commit c35fa7a, we changed the "width" of DF source registers to >> > 2, >> > which is

Re: [Mesa-dev] [PATCH 1/2] anv/cmd_buffer: Don't temporarily enable CCS_E within a render pass

2017-01-23 Thread Jason Ekstrand
On Mon, Jan 23, 2017 at 4:55 PM, Nanley Chery wrote: > Compressing a render target and decompressing it in the same > single-subpass render pass may waste bandwidth. While this may be > beneficial in some circumstances, it does not help in all. > > Cc: "13.0 17.0"

Re: [Mesa-dev] [PATCH 1/2] anv/cmd_buffer: Don't temporarily enable CCS_E within a render pass

2017-01-23 Thread Nanley Chery
On Mon, Jan 23, 2017 at 05:30:22PM -0800, Jason Ekstrand wrote: > On Mon, Jan 23, 2017 at 4:55 PM, Nanley Chery wrote: > > > Compressing a render target and decompressing it in the same > > single-subpass render pass may waste bandwidth. While this may be > > beneficial in

Re: [Mesa-dev] [PATCH 1/2] anv/cmd_buffer: Don't temporarily enable CCS_E within a render pass

2017-01-23 Thread Nanley Chery
On Mon, Jan 23, 2017 at 05:42:44PM -0800, Jason Ekstrand wrote: > On Mon, Jan 23, 2017 at 5:40 PM, Nanley Chery wrote: > > > On Mon, Jan 23, 2017 at 05:30:22PM -0800, Jason Ekstrand wrote: > > > On Mon, Jan 23, 2017 at 4:55 PM, Nanley Chery > >

[Mesa-dev] [PATCH 1/2] r600g: use ieee variants of multiplication instructions

2017-01-23 Thread Ilia Mirkin
This matches the behavior of most other drivers, including nouveau. Signed-off-by: Ilia Mirkin --- Untested. This also leaves RCP and RSQ with the clamped variants. I suspect this is wrong, but seems unrelated to multiplication per se.

[Mesa-dev] [PATCH 08/37] glsl: add initial implementation of shader cache

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri This uses disk_cache.c to write out a serialization of various state that's required in order to successfully load and use a binary written out by a drivers backend, this state is referred to as "metadata" throughout the implementation. This

[Mesa-dev] [PATCH 01/37] docs: add shader cache environment variables

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri Reviewed-by: Eric Anholt --- docs/envvars.html | 11 +++ 1 file changed, 11 insertions(+) diff --git a/docs/envvars.html b/docs/envvars.html index 276cea3..2269f18 100644 --- a/docs/envvars.html +++

[Mesa-dev] [PATCH 02/37] glsl: Switch to disable-by-default for the GLSL shader cache

2017-01-23 Thread Timothy Arceri
From: Carl Worth The shader cache is expected to be developed incrementally over a fairly long series of commits. For that period of instability, we require users to opt into the shader cache by setting: MESA_GLSL_CACHE_ENABLE=1 In the future, when the shader cache

[Mesa-dev] [PATCH 04/37] glsl: add cache to ctx and add sha1 string fields

2017-01-23 Thread Timothy Arceri
From: Carl Worth We also add a flag for detecting shaders written to shader cache. V2: dont leak cache Signed-off-by: Timothy Arceri --- src/mesa/main/context.c | 6 ++ src/mesa/main/mtypes.h | 9 + 2 files changed, 15

[Mesa-dev] [PATCH 03/37] glsl: add new uniform fields to be used to restore state from cache

2017-01-23 Thread Timothy Arceri
From: Carl Worth Signed-off-by: Timothy Arceri --- src/compiler/glsl/link_uniforms.cpp | 4 src/mesa/main/mtypes.h | 4 2 files changed, 8 insertions(+) diff --git a/src/compiler/glsl/link_uniforms.cpp

[Mesa-dev] Hardware agnostic on-disk shader cache patches

2017-01-23 Thread Timothy Arceri
The refactoring series is now pushed so here is the hardware agnostic shader cache patches. In future I want to change the way we track Mesa versions in patch 24 by creating a new cache directory for each Mesa version. This will help avoid unnecessary fallback recompiles and also allow 3rd

[Mesa-dev] [PATCH 06/37] util: add a disk_cache_remove() function

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri This will be used to remove cache items created with old versions of Mesa or other invalid cache items from the cache. --- src/util/disk_cache.c | 22 ++ src/util/disk_cache.h | 12 2 files changed, 34

[Mesa-dev] [PATCH 29/37] glsl: skip more uniform initialisation when doing fallback linking

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri We already pull these values from the metadata cache so no need to recreate them. --- src/compiler/glsl/linker.cpp | 20 src/mesa/main/shaderobj.c| 8 +--- 2 files changed, 17 insertions(+), 11 deletions(-) diff

[Mesa-dev] [PATCH 30/37] glsl: don't reprocess or clear UBOs on cache fallback

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri --- src/compiler/glsl/linker.cpp | 62 +++- src/mesa/main/shaderobj.c| 16 +++- 2 files changed, 42 insertions(+), 36 deletions(-) diff --git a/src/compiler/glsl/linker.cpp

[Mesa-dev] [PATCH 22/37] glsl: make uniform values helper available for use elsewhere

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri --- src/compiler/glsl/link_uniforms.cpp | 2 +- src/compiler/glsl/linker.h | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/link_uniforms.cpp b/src/compiler/glsl/link_uniforms.cpp index

[Mesa-dev] [PATCH 27/37] glsl: don't reference shader prog data during cache fallback

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri We already have a reference. --- src/compiler/glsl/linker.cpp | 3 ++- src/mesa/main/shaderobj.c| 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/linker.cpp b/src/compiler/glsl/linker.cpp index

[Mesa-dev] [PATCH 23/37] glsl: cache uniform values

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri These may be lowered constant arrays or uniform values that we set before linking so we need to cache the actual uniform values. --- src/compiler/glsl/shader_cache.cpp | 33 + 1 file changed, 33 insertions(+)

[Mesa-dev] [PATCH 25/37] mesa/glsl: add cache_fallback flag to gl_shader_program_data

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri This will allow us to skip certain things when falling back to a full recompile on a cache miss such as avoiding reinitialising uniforms. In this chage we use it to avoid reading the program metadata from the cache and skipping linking during a

[Mesa-dev] [PATCH 26/37] glsl: make a copy of the shader source for use with cache fallback

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri A number of things can happen that change the shader source after it is compiled or linked. For example: - Source changed after it is first compiled - Source changed after linking - Shader detached after linking In order to be able to fallback

[Mesa-dev] [PATCH 28/37] glsl: don't lose uniform values when falling back to full compile

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri Here we skip the recreation of uniform storage if we are relinking after a cache miss. This is improtant because uniform values may have already been set by the application and we don't want to reset them. ---

[Mesa-dev] [PATCH 24/37] glsl: track mesa version shader cache items were created with

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri Also remove cache item and fallback to full recompile if current Mesa version differs. V2: don't leak buffer --- src/compiler/glsl/shader_cache.cpp | 13 + 1 file changed, 13 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 0/7] i965: Implement EGL_ANDROID_native_fence_sync

2017-01-23 Thread Chad Versace
Bump. Requesting more review please. On Fri 13 Jan 2017, Chad Versace wrote: > This series depends on fence fd support in I915_GEM_EXECBUFFER2, which > isn't upstream in libdrm nor the kernel yet. I tested this with kmscube > on Skylake, and everything looked good to me. > > I pushed tags for

Re: [Mesa-dev] [PATCH 0/7] i965: Implement EGL_ANDROID_native_fence_sync

2017-01-23 Thread Chad Versace
On Fri 20 Jan 2017, Rafael Antognolli wrote: > I have tested this series with the branches that you mentioned, and with > piglit with the patches from my own branch: > > https://github.com/rantogno/piglit/tree/review/fences-v02 > > Everything seems to work fine. You can add: > > Tested-by:

Re: [Mesa-dev] [PATCH] i965/blorp: Use the correct ISL format for combined depth/stencil

2017-01-23 Thread Chad Versace
On Mon 23 Jan 2017, Jason Ekstrand wrote: > In brw_blorp_copyteximage, we use the format from the render buffer. > This could be a combined depth/stencil format. In this case, we handle > stencil properly but we give blorp the wrong ISL format. Specifically, > we would give blorp

[Mesa-dev] [PATCH] anv: add KHR_get_physical_device_properties2 support

2017-01-23 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/anv_device.c | 593 + src/intel/vulkan/anv_formats.c | 42 +++ 2 files changed, 398 insertions(+), 237 deletions(-) diff --git a/src/intel/vulkan/anv_device.c

[Mesa-dev] [PATCH] gallium/tgsi: fix memory leak in tgsi sanity check

2017-01-23 Thread Li Qiang
Fix the leak of some ctx fields in error path. Signed-off-by: Li Qiang --- src/gallium/auxiliary/tgsi/tgsi_sanity.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_sanity.c b/src/gallium/auxiliary/tgsi/tgsi_sanity.c

[Mesa-dev] [PATCH] gallium/tgsi: fix oob access in parse instruction

2017-01-23 Thread Li Qiang
When parsing texture instruction, it doesn't stop if the 'cur' is ',', the loop variable 'i' will also be increased and be used to index the 'inst.TexOffsets' array. This can lead an oob access issue. This patch avoid this. Signed-off-by: Li Qiang ---

Re: [Mesa-dev] [PATCH] gallium/tgsi: fix oob access in parse instruction

2017-01-23 Thread Marc-André Lureau
Hi - Original Message - > When parsing texture instruction, it doesn't stop if the > 'cur' is ',', the loop variable 'i' will also be increased > and be used to index the 'inst.TexOffsets' array. This can lead > an oob access issue. This patch avoid this. > > Signed-off-by: Li Qiang

  1   2   >