Re: [Mesa-dev] [EGL android: accquire fence implementation] i965: Queue the buffer with a sync fence for Android OS (v4)

Hi Zhongmin, Thanks for the new patch. Personally I think it looks much better now. Still, there are some remaining comments. Also, I'd advise waiting few days before posting new version, so that peo On Thu, Jul 20, 2017 at 4:10 PM, Zhongmin Wu wrote: > Before we queued

Re: [Mesa-dev] [PATCH 07/32] i965/miptree: Make layer_range_length return locical layers

This still leaves create_aux_state_map() using physical number of layers for the actual allocation. I toyed a little with this hoping to put it in front my i965-to-isl work. In the end it looks to me that moving away from physical is easier/cleaner once the conversion to isl is done. This

Re: [Mesa-dev] [PATCH 2/2] egl: add linux-dmabuf-unstable-v1-protocol.c to "nodist"

On 19 July 2017 at 23:44, Andres Gomez wrote: > This fixes `make distcheck` > >> make[3]: *** No rule to make target >> 'drivers/dri2/linux-dmabuf-unstable-v1-protocol.c', needed by 'distdir'. >> Stop. >> make[3]: Entering directory '/home/local/mesa/src/egl' >> make[3]:

[Mesa-dev] [Bug 101843] Latest mesa git fails to compile in mesa/main/marshal.c

https://bugs.freedesktop.org/show_bug.cgi?id=101843 --- Comment #3 from Grigori Goronzy --- Are you sure this isn't an issue with the build infrastructure going out of sync with changes in the source code? Please try to delete the build directory and reconfigure and rebuild

Re: [Mesa-dev] [PATCH] Revert "i965: Call intel_prepare_render() from intel_update_state()"

Works for Android-IA: Tested-by: Tapani Pälli On 07/20/2017 09:00 AM, Kenneth Graunke wrote: This reverts commit b7153c3e9f9d2d430b0338313587a00e531e4800. The point of that commit was to ensure intel_prepare_render() occurred before color resolves on the current

[Mesa-dev] [PATCH] Revert "i965: Call intel_prepare_render() from intel_update_state()"

This reverts commit b7153c3e9f9d2d430b0338313587a00e531e4800. The point of that commit was to ensure intel_prepare_render() occurred before color resolves on the current framebuffer. In 0673bbfd9ba16be8 (i965: Move surface resolves back to draw/dispatch time), Jason moved

Re: [Mesa-dev] [PATCH 2/2] android: fix spirv_info generation

2017-07-19 15:12 GMT+08:00 Tapani Pälli : > Depending on build order, LOCAL_PATH maybe set or not (and can't > be trusted to have assumed path), change modifies all occurences > of LOCAL_PATH as locally defined COMPILER_PATH instead. > > Signed-off-by: Tapani Pälli

[Mesa-dev] [PATCH] Android: fix spirv_info.c generation

It's incorrect to use $(LOCAL_PATH) in makefile recipes since it's changing. The typical way to handle it is to use private variable. Fortunately in this case we can just simplify them to $^. See further: https://patchwork.freedesktop.org/patch/167718/ Also simplify LOCAL_GENERATED_SOURCES.

Re: [Mesa-dev] [RFC PATCH] radeonsi: set a per-buffer flag that disables inter-process sharing (v2)

On 07/20/2017 04:20 AM, zhoucm1 wrote: On 2017年07月19日 23:34, Marek Olšák wrote: On Jul 19, 2017 3:36 AM, "zhoucm1" > wrote: On 2017年07月19日 04:08, Marek Olšák wrote: From: Marek Olšák

[Mesa-dev] [PATCH] mesa: include texture size in error messages

--- src/mesa/main/teximage.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 5e13025..c30f8ac 100644 --- a/src/mesa/main/teximage.c +++ b/src/mesa/main/teximage.c @@ -3007,8 +3007,8 @@ teximage(struct

Re: [Mesa-dev] [PATCH 02/13] i965: Allow passing target_bo=NULL to brw_emit_reloc()

Quoting Kenneth Graunke (2017-07-19 21:08:23) > On Wednesday, July 19, 2017 3:09:10 AM PDT Chris Wilson wrote: > > Sometimes we want to emit a relocation to a NULL surface when the > > constructing the batch. If we push the NULL handling into the common > > brw_emit_reloc() we can make the batch

[Mesa-dev] [Bug 101467] swr driver leaks memory (texture management)

https://bugs.freedesktop.org/show_bug.cgi?id=101467 --- Comment #7 from Bruce Cherniak --- Available in 17.1.5 with commit 5c91fcfa. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

Re: [Mesa-dev] [PATCH 2/2] egl: add linux-dmabuf-unstable-v1-protocol.c to "nodist"

On 20 July 2017 at 13:54, Daniel Stone wrote: > Hi Emil, > > On 20 July 2017 at 13:51, Emil Velikov wrote: >> On 19 July 2017 at 23:44, Andres Gomez wrote: >>> -dri2_backend_FILES += drivers/dri2/platform_wayland.c \ >>> -

Re: [Mesa-dev] [PATCH 02/13] i965: Allow passing target_bo=NULL to brw_emit_reloc()

Quoting Chris Wilson (2017-07-20 15:15:02) > Quoting Kenneth Graunke (2017-07-19 21:08:23) > > On Wednesday, July 19, 2017 3:09:10 AM PDT Chris Wilson wrote: > > > Sometimes we want to emit a relocation to a NULL surface when the > > > constructing the batch. If we push the NULL handling into the

Re: [Mesa-dev] [PATCH 2/2] egl: add linux-dmabuf-unstable-v1-protocol.c to "nodist"

On 19 July 2017 at 23:44, Andres Gomez wrote: > This fixes `make distcheck` > >> make[3]: *** No rule to make target >> 'drivers/dri2/linux-dmabuf-unstable-v1-protocol.c', needed by 'distdir'. >> Stop. >> make[3]: Entering directory '/home/local/mesa/src/egl' >> make[3]:

Re: [Mesa-dev] [PATCH 2/2] android: fix spirv_info generation

On 07/19/2017 05:01 PM, Rob Herring wrote: On Wed, Jul 19, 2017 at 8:56 AM, Emil Velikov wrote: On 19 July 2017 at 14:14, Tapani Pälli wrote: On 07/19/2017 03:29 PM, Emil Velikov wrote: On 19 July 2017 at 08:12, Tapani Pälli

[Mesa-dev] [EGL android: accquire fence implementation] i965: Queue the buffer with a sync fence for Android OS (v4)

Before we queued the buffer with a invalid fence (-1), it will make some benchmarks failed to test such as flatland. Now we get the out fence during the flushing buffer and then pass it to SurfaceFlinger in eglSwapbuffer function. v2: a) Also implement the fence in cancelBuffer. b) The last

Re: [Mesa-dev] [PATCH 01/32] i965/surface_state: Use the minified depth for number of image layers

I already pushed an equivalent fix (which you actually reviewed). On Wed, Jul 19, 2017 at 02:01:27PM -0700, Jason Ekstrand wrote: > Otherwise, if the image is 3D, then we may end up with a number of > layers that is too high for LOD > 0. > --- > src/mesa/drivers/dri/i965/brw_wm_surface_state.c

Re: [Mesa-dev] [PATCH 2/2] egl: add linux-dmabuf-unstable-v1-protocol.c to "nodist"

Hi Emil, On 20 July 2017 at 13:51, Emil Velikov wrote: > On 19 July 2017 at 23:44, Andres Gomez wrote: >> -dri2_backend_FILES += drivers/dri2/platform_wayland.c \ >> - drivers/dri2/linux-dmabuf-unstable-v1-protocol.c >> +dri2_backend_FILES +=

Re: [Mesa-dev] [PATCH 1/2] broadcom: correct header file in BROADCOM_FILES

On 19 July 2017 at 23:44, Andres Gomez wrote: > This fixes `make distcheck` > >> make[3]: *** No rule to make target 'common/v3d_devinfo.h', needed by >> 'distdir'. Stop. >> make[3]: Leaving directory '/home/local/mesa/src/broadcom' >> Makefile:945: recipe for target

Re: [Mesa-dev] [PATCH 2/2] egl: add linux-dmabuf-unstable-v1-protocol.c to "nodist"

On Thursday, 2017-07-20 09:09:37 +0100, Daniel Stone wrote: > On 19 July 2017 at 23:44, Andres Gomez wrote: > > This fixes `make distcheck` > > > >> make[3]: *** No rule to make target > >> 'drivers/dri2/linux-dmabuf-unstable-v1-protocol.c', needed by 'distdir'. > >> Stop. >

[Mesa-dev] [Bug 101467] swr driver leaks memory (texture management)

https://bugs.freedesktop.org/show_bug.cgi?id=101467 Andrés Gómez García changed: What|Removed |Added Resolution|--- |FIXED

Re: [Mesa-dev] [PATCH] mesa: include texture size in error messages

Reviewed-by: Samuel Pitoiset On 07/20/2017 03:56 PM, Brian Paul wrote: --- src/mesa/main/teximage.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 5e13025..c30f8ac 100644 ---

Re: [Mesa-dev] [PATCH] mesa: include texture size in error messages

Reviewed-by: Alejandro Piñeiro On 20/07/17 15:56, Brian Paul wrote: > --- > src/mesa/main/teximage.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c > index 5e13025..c30f8ac 100644 > ---

[Mesa-dev] [PATCH V2] i965 : Optimize atom state flag checks

From: Aravindan Muthukumar This patch improves CPI Rate(Cycles per Instruction) and branch mispredict for i965. The function check_state() was showing CPI retired rate. Performance stats with android: CPI retired lowered by 28% (lower is better) Branch

Re: [Mesa-dev] [PATCH 03/32] i965/blorp: Do flushes around depth resolves

On Wed, Jul 19, 2017 at 02:01:29PM -0700, Jason Ekstrand wrote: > It turns out that if you have rendering in-flight with CCS_E enabled and > you go to do a depth resolve without flushing, the CCS data may never > hit the memory. > --- > src/mesa/drivers/dri/i965/brw_blorp.c | 150 >

Re: [Mesa-dev] [PATCH 09/32] i965/miptree: Add support for partially resolving MCS

On Wed, Jul 19, 2017 at 02:01:35PM -0700, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_blorp.c | 24 > src/mesa/drivers/dri/i965/brw_blorp.h | 5 > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 40 > +-- > 3 files

Re: [Mesa-dev] [PATCH 2/2] android: fix spirv_info generation

2017-07-20 18:02 GMT+08:00 Chih-Wei Huang : > > OK. I see the real problem. > The rules to build spirv_info.c are incorrectly > to use $(LOCAL_PATH). > Basically speaking, $(LOCAL_PATH) can't be used > in the recipes[1] since it is always changing. > When the recipe rules

Re: [Mesa-dev] [PATCH 10/10] mesa: remove useless assert in _mesa_TextureView()

Series: Reviewed-by: Timothy Arceri On 20/07/17 19:53, Samuel Pitoiset wrote: Already checked in _mesa_choose_texture_format(). Signed-off-by: Samuel Pitoiset --- src/mesa/main/textureview.c | 1 - 1 file changed, 1 deletion(-) diff

Re: [Mesa-dev] [PATCH 11/32] i965/miptree: Add a helper for getting the aux usage for texturing

On Wed, Jul 19, 2017 at 02:01:37PM -0700, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 59 > ++- > src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 4 ++ > 2 files changed, 43 insertions(+), 20 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH] Android: fix spirv_info.c generation

Nice, I think it was done like this in some other occurence too; Reviewed-by: Tapani Pälli On 07/20/2017 01:30 PM, Chih-Wei Huang wrote: It's incorrect to use $(LOCAL_PATH) in makefile recipes since it's changing. The typical way to handle it is to use private

[Mesa-dev] [PATCH 02/10] mesa: pass the 'caller' function to texstorage()

To be consistent with texturestorage(). Signed-off-by: Samuel Pitoiset --- src/mesa/main/texstorage.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/texstorage.c b/src/mesa/main/texstorage.c index

[Mesa-dev] [PATCH 04/10] mesa: tidy up _mesa_DeleteVertexArrays()

Signed-off-by: Samuel Pitoiset --- src/mesa/main/arrayobj.c | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/src/mesa/main/arrayobj.c b/src/mesa/main/arrayobj.c index 17a789f4da..ce0050ace3 100644 ---

[Mesa-dev] [PATCH 08/10] mesa: remove one extra check in _mesa_DeleteTextures()

Already checked above. Signed-off-by: Samuel Pitoiset --- src/mesa/main/texobj.c | 5 - 1 file changed, 5 deletions(-) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c index 156a122ac0..e52ad22645 100644 --- a/src/mesa/main/texobj.c +++

[Mesa-dev] [PATCH 09/10] mesa: remove duplicated code around framebuffer_renderbuffer()

Signed-off-by: Samuel Pitoiset --- src/mesa/main/fbobject.c | 70 1 file changed, 23 insertions(+), 47 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index 7c92df5608..46bc129eff 100644

[Mesa-dev] [PATCH 10/10] mesa: remove useless assert in _mesa_TextureView()

Already checked in _mesa_choose_texture_format(). Signed-off-by: Samuel Pitoiset --- src/mesa/main/textureview.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/main/textureview.c b/src/mesa/main/textureview.c index ed66c17958..cef9caff41 100644 ---

[Mesa-dev] [PATCH 05/10] mesa: inline remove_array_object()

No need to check if ID is not 0 because _mesa_lookup_vao() already prevents this to happen. Signed-off-by: Samuel Pitoiset --- src/mesa/main/arrayobj.c | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/src/mesa/main/arrayobj.c

[Mesa-dev] [PATCH 03/10] mesa: remove useless assert in texture_storage()

Already checked in _mesa_choose_texture_format(). Signed-off-by: Samuel Pitoiset --- src/mesa/main/texstorage.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/main/texstorage.c b/src/mesa/main/texstorage.c index 99a169e5ff..ef4fe58f5e 100644 ---

[Mesa-dev] [PATCH 01/10] mesa: make _mesa_texture_storage() static

Signed-off-by: Samuel Pitoiset --- src/mesa/main/texstorage.c | 24 src/mesa/main/texstorage.h | 7 --- 2 files changed, 12 insertions(+), 19 deletions(-) diff --git a/src/mesa/main/texstorage.c b/src/mesa/main/texstorage.c index

[Mesa-dev] [PATCH 07/10] mesa: make _mesa_generate_texture_mipmap() static

Signed-off-by: Samuel Pitoiset --- src/mesa/main/genmipmap.c | 12 ++-- src/mesa/main/genmipmap.h | 4 2 files changed, 6 insertions(+), 10 deletions(-) diff --git a/src/mesa/main/genmipmap.c b/src/mesa/main/genmipmap.c index 6021c026f5..be49136aa8

[Mesa-dev] [PATCH 06/10] mesa: inline save_array_object()

No need to check if ID is not 0 because _mesa_HashFindFreeKeyBlock() can't generate this value. Signed-off-by: Samuel Pitoiset --- src/mesa/main/arrayobj.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/src/mesa/main/arrayobj.c

[Mesa-dev] [PATCH 1/2] mesa: remove pointless assignments in init_teximage_fields_ms()

The NumSamples and FixedSampleLocation fields are set again later at the end of the function so these earlier assignments aren't needed. --- src/mesa/main/teximage.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index c30f8ac..d55d9b0

[Mesa-dev] [PATCH 2/2] st/mesa: use proper resource target type in st_AllocTextureStorage()

When we validate the texture sample count, pass the correct pipe_texture_target for the texture, rather than PIPE_TEXTURE_2D. Also add more comments about MSAA. --- src/mesa/state_tracker/st_cb_texture.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH] svga: add more checking of sample_count in svga_is_format_supported()

We're not supporting 2x MSAA, for example. --- src/gallium/drivers/svga/svga_screen.c | 8 1 file changed, 8 insertions(+) diff --git a/src/gallium/drivers/svga/svga_screen.c b/src/gallium/drivers/svga/svga_screen.c index 1ec91e5..0d8e59d 100644 ---

Re: [Mesa-dev] [PATCH 09/32] i965/miptree: Add support for partially resolving MCS

On Thu, Jul 20, 2017 at 3:00 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Wed, Jul 19, 2017 at 02:01:35PM -0700, Jason Ekstrand wrote: > > --- > > src/mesa/drivers/dri/i965/brw_blorp.c | 24 > > src/mesa/drivers/dri/i965/brw_blorp.h | 5 >

[Mesa-dev] [Bug 101843] Latest mesa git fails to compile in mesa/main/marshal.c

https://bugs.freedesktop.org/show_bug.cgi?id=101843 --- Comment #4 from Fabian Maurer --- Well, now that I set it up again, it suddenly works. Maybe a configuration problem, but I really can't see what I changed. Thank you for testing, is there an option to resolve this as

Re: [Mesa-dev] [RFC PATCH] radeonsi: set a per-buffer flag that disables inter-process sharing (v2)

Am 20.07.2017 um 16:59 schrieb Marek Olšák: On Jul 19, 2017 10:21 PM, "zhoucm1" > wrote: On 2017年07月19日 23:34, Marek Olšák wrote: On Jul 19, 2017 3:36 AM, "zhoucm1" > wrote:

Re: [Mesa-dev] [PATCH 08/13] i965: Convert reloc.target_handle into an index for I915_EXEC_HANDLE_LUT

On Thursday, July 20, 2017 8:05:19 AM PDT Chris Wilson wrote: > Quoting Kenneth Graunke (2017-07-19 23:36:58) > > On Wednesday, July 19, 2017 3:09:16 AM PDT Chris Wilson wrote: > > > #define READ_ONCE(x) (*(volatile __typeof__(x) *)&(x)) > > > @@ -117,21 +125,12 @@ add_exec_bo(struct

Re: [Mesa-dev] [PATCH] dri: Make classic drivers allow __DRI_CTX_FLAG_NO_ERROR.

On 2017-07-18 20:25, Ian Romanick wrote: On 07/14/2017 04:10 PM, Kenneth Graunke wrote: Grigori recently added EGL_KHR_create_context_no_error support, which causes EGL to pass a new __DRI_CTX_FLAG_NO_ERROR flag to drivers when requesting an appropriate context mode. driContextSetFlags() will

Re: [Mesa-dev] [PATCH 03/32] i965/blorp: Do flushes around depth resolves

On Thu, Jul 20, 2017 at 2:38 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Wed, Jul 19, 2017 at 02:01:29PM -0700, Jason Ekstrand wrote: > > It turns out that if you have rendering in-flight with CCS_E enabled and > > you go to do a depth resolve without flushing, the CCS data

Re: [Mesa-dev] [PATCH] configure.ac: rework wayland-protocols handling

On 20 July 2017 at 18:27, Emil Velikov wrote: > From: Emil Velikov > > At dist/distcheck time we need to ensure that all the files and their > respective dependencies are handled. > > At the moment we'll bail out as the linux-dmabuf rules are

Re: [Mesa-dev] [PATCH 09/13] i965: Always create the batch with the batch object in the first execobject slot

Quoting Kenneth Graunke (2017-07-19 23:43:04) > On Wednesday, July 19, 2017 3:09:17 AM PDT Chris Wilson wrote: > > Even if we are using older kernels that do not accept the batch in the > > first slot, we can simplify our code by creating the batch with itself > > in the first slot and moving it

Re: [Mesa-dev] [PATCH 2/2] egl: add linux-dmabuf-unstable-v1-protocol.c to "nodist"

On 20 July 2017 at 15:42, Andres Gomez wrote: > On Thu, 2017-07-20 at 14:37 +0100, Emil Velikov wrote: >> On 20 July 2017 at 13:54, Daniel Stone wrote: >> > Hi Emil, >> > >> > On 20 July 2017 at 13:51, Emil Velikov wrote: >> > >

Re: [Mesa-dev] [PATCH 02/13] i965: Allow passing target_bo=NULL to brw_emit_reloc()

On Thursday, July 20, 2017 7:29:52 AM PDT Chris Wilson wrote: > Quoting Chris Wilson (2017-07-20 15:15:02) > > Quoting Kenneth Graunke (2017-07-19 21:08:23) > > > On Wednesday, July 19, 2017 3:09:10 AM PDT Chris Wilson wrote: > > > > Sometimes we want to emit a relocation to a NULL surface when

Re: [Mesa-dev] [PATCH] i965: Rename batch->exec_objects to validation_list

On Thursday, July 20, 2017 9:29:19 AM PDT Chris Wilson wrote: > Within i965, we have many different objects and confusingly when > submitting an execbuf we have lists of both our internal objects and a > list of the kernel's drm_i915_gem_exec_object with very similar names. > Rename the kernel's

[Mesa-dev] [PATCH] configure.ac: rework wayland-protocols handling

From: Emil Velikov At dist/distcheck time we need to ensure that all the files and their respective dependencies are handled. At the moment we'll bail out as the linux-dmabuf rules are guarded in a conditional. Move them outside of it and drop the sources from

Re: [Mesa-dev] [PATCH V2] i965 : Optimize atom state flag checks

aravindan.muthuku...@intel.com writes: > From: Aravindan Muthukumar > > This patch improves CPI Rate(Cycles per Instruction) > and branch mispredict for i965. The function check_state() > was showing CPI retired rate. > > Performance stats with android: > CPI

Re: [Mesa-dev] [PATCH 2/2] android: fix spirv_info generation

On 20 July 2017 at 11:02, Chih-Wei Huang wrote: > 2017-07-19 15:12 GMT+08:00 Tapani Pälli : >> Depending on build order, LOCAL_PATH maybe set or not (and can't >> be trusted to have assumed path), change modifies all occurences >> of LOCAL_PATH as

Re: [Mesa-dev] [RFC PATCH] radeonsi: set a per-buffer flag that disables inter-process sharing (v2)

On Jul 19, 2017 10:21 PM, "zhoucm1" wrote: On 2017年07月19日 23:34, Marek Olšák wrote: On Jul 19, 2017 3:36 AM, "zhoucm1" wrote: On 2017年07月19日 04:08, Marek Olšák wrote: > From: Marek Olšák > > For lower overhead in the CS

[Mesa-dev] [PATCH] svga: fix default case in svga_get_sample_position()

If called for an unsupported number of samples, always return (.5, .5). Fixes the Piglit arb_texture_multisample-fb-completeness test for unsupported sample counts, such as 2. Ideally, this function should not get called for unsupported sample counts, but that'll be additional work... ---

Re: [Mesa-dev] [PATCH 07/32] i965/miptree: Make layer_range_length return locical layers

On Thu, Jul 20, 2017 at 8:08 AM, Jason Ekstrand wrote: > On July 20, 2017 2:27:50 AM "Pohjolainen, Topi" < > topi.pohjolai...@gmail.com> wrote: > > >> This still leaves create_aux_state_map() using physical number of layers >> for >> the actual allocation. I toyed a little

[Mesa-dev] [PATCH] i965: Rename batch->exec_objects to validation_list

Within i965, we have many different objects and confusingly when submitting an execbuf we have lists of both our internal objects and a list of the kernel's drm_i915_gem_exec_object with very similar names. Rename the kernel's validation list to avoid the collison as it is only used for

Re: [Mesa-dev] [PATCH 2/2] egl: add linux-dmabuf-unstable-v1-protocol.c to "nodist"

On Thu, 2017-07-20 at 14:37 +0100, Emil Velikov wrote: > On 20 July 2017 at 13:54, Daniel Stone wrote: > > Hi Emil, > > > > On 20 July 2017 at 13:51, Emil Velikov wrote: > > > On 19 July 2017 at 23:44, Andres Gomez wrote: > > >

Re: [Mesa-dev] [PATCH 08/13] i965: Convert reloc.target_handle into an index for I915_EXEC_HANDLE_LUT

Quoting Kenneth Graunke (2017-07-19 23:36:58) > On Wednesday, July 19, 2017 3:09:16 AM PDT Chris Wilson wrote: > > #define READ_ONCE(x) (*(volatile __typeof__(x) *)&(x)) > > @@ -117,21 +125,12 @@ add_exec_bo(struct intel_batchbuffer *batch, struct > > brw_bo *bo) > >

Re: [Mesa-dev] [PATCH] Android: fix spirv_info.c generation

On 20 July 2017 at 11:30, Chih-Wei Huang wrote: > It's incorrect to use $(LOCAL_PATH) in makefile recipes since it's > changing. The typical way to handle it is to use private variable. > Fortunately in this case we can just simplify them to $^. > > See further: >

Re: [Mesa-dev] [PATCH 07/32] i965/miptree: Make layer_range_length return locical layers

On July 20, 2017 2:27:50 AM "Pohjolainen, Topi" wrote: This still leaves create_aux_state_map() using physical number of layers for the actual allocation. I toyed a little with this hoping to put it in front my i965-to-isl work. In the end it looks to me that

[Mesa-dev] [Bug 101843] Latest mesa git fails to compile in mesa/main/marshal.c

https://bugs.freedesktop.org/show_bug.cgi?id=101843 Timothy Arceri changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH 03/20] nir: Support lowering vote intrinsics

On Tue, Jul 18, 2017 at 1:34 PM, Connor Abbott wrote: > On Mon, Jul 10, 2017 at 10:18 AM, Matt Turner wrote: >> On Thu, Jul 6, 2017 at 8:04 PM, Connor Abbott wrote: >>> On Thu, Jul 6, 2017 at 4:48 PM, Matt Turner

Re: [Mesa-dev] [PATCH] st/mesa: add destroy_drawable interface

Looks good to me, but you might want to wait a day to see if there's any additional review feedback. Reviewed-by: Brian Paul On 07/20/2017 12:26 PM, Charmaine Lee wrote: With this patch, the st manager will maintain a hash table for the active framebuffer interface

[Mesa-dev] [PATCH 1/2] glsl: remove placeholder comment

This was added in 2d03f48a65a666 and seems like it was intended as a TODO comment in a function stub rather than a useful code comment. --- src/compiler/glsl/ast_to_hir.cpp | 4 1 file changed, 4 deletions(-) diff --git a/src/compiler/glsl/ast_to_hir.cpp b/src/compiler/glsl/ast_to_hir.cpp

[Mesa-dev] [PATCH 2/2] glsl: rework misleading block layout code

From the ARB_uniform_buffer_object spec: ""shared" uniform blocks, the default layout, ..." This doesn't fix anything as the default layout is already applied at this point but fixes the misleading code/comment. --- src/compiler/glsl/ast_to_hir.cpp | 8 1 file changed, 4

[Mesa-dev] [PATCH] compiler: move glsl_interface_packing enum to shader_enums.h

This allows us to drop the duplicate gl_uniform_block_packing enum. --- src/compiler/glsl/link_uniform_blocks.cpp | 11 +-- src/compiler/glsl_types.h | 9 ++--- src/compiler/shader_enums.h | 7 +++ src/mesa/main/mtypes.h| 11

[Mesa-dev] [PATCH 1/3] swr/rast: simdlib changes for clang/gcc

Tested with clang-4.0 and gcc-6.3. --- .../swr/rasterizer/common/simdlib_512_avx512.inl | 43 +- .../swr/rasterizer/common/simdlib_types.hpp| 2 +- 2 files changed, 35 insertions(+), 10 deletions(-) diff --git

Re: [Mesa-dev] [PATCH v2] radv: Fix descriptors for cube images with VK_IMAGE_USAGE_STORAGE_BIT

For whatever reason this patch is breaking DOOM. Gražvydas On Wed, Jul 12, 2017 at 12:29 PM, Alex Smith wrote: > If a cube image has VK_IMAGE_USAGE_STORAGE_BIT set, the type in an image > view's descriptor was set to a 2D array (and a few other fields adjusted >

[Mesa-dev] radv shared semaphores (v2)

This is a rework of the code to support the temporary import semantics and also doesn't always use syncobjs to avoid the problem with having to signal the WSI semaphores for now. Dave. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [PATCH 2/3] radv/winsys: add syncobj hooks

From: Dave Airlie This just adds syncobj create/destroy/export/import paths into the winsys interface. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_radeon_winsys.h | 8 ++ src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 36

[Mesa-dev] [PATCH 3/3] radv: initial support for shared semaphores

From: Dave Airlie This adds support for sharing semaphores using kernel syncobjects. Syncobj backed semaphores are used for any semaphore which is created with external flags, and when a semaphore is imported, otherwise we use the current non-kernel semaphores. Temporary

[Mesa-dev] [PATCH 1/3] ac/gpu: add code to detect if kernel supports sync objects.

From: Dave Airlie Signed-off-by: Dave Airlie --- src/amd/common/ac_gpu_info.c | 9 + src/amd/common/ac_gpu_info.h | 1 + 2 files changed, 10 insertions(+) diff --git a/src/amd/common/ac_gpu_info.c b/src/amd/common/ac_gpu_info.c index

Re: [Mesa-dev] [EGL android: accquire fence implementation 2/2] i965: Queue the buffer with a sync fence for Android OS v4.1

Hi Zhongmin, Thanks for the update. Please see my comments inline. On Fri, Jul 21, 2017 at 12:08 PM, Zhongmin Wu wrote: > Before we queued the buffer with a invalid fence (-1), it will > make some benchmarks failed to test such as flatland. > > Now we get the out fence

Re: [Mesa-dev] [Intel-gfx] [PATCH 3/3] intel: Make driver aware of MOCS table version

On 17-07-07 09:28:08, Jason Ekstrand wrote: On Thu, Jul 6, 2017 at 4:27 PM, Ben Widawsky wrote: We don't yet have optimal MOCS settings, but we have enough to know how to at least determine when we might have non-optimal settings within our driver. Signed-off-by: Ben

Re: [Mesa-dev] [RFC PATCH] radeonsi: set a per-buffer flag that disables inter-process sharing (v2)

On 2017年07月20日 22:59, Marek Olšák wrote: On Jul 19, 2017 10:21 PM, "zhoucm1" > wrote: On 2017年07月19日 23:34, Marek Olšák wrote: On Jul 19, 2017 3:36 AM, "zhoucm1" > wrote:

[Mesa-dev] [PATCH] travis: add build configuration for SWR AVX512

--- .travis.yml | 32 1 file changed, 32 insertions(+) diff --git a/.travis.yml b/.travis.yml index 246ad30eff..da491e0396 100644 --- a/.travis.yml +++ b/.travis.yml @@ -82,6 +82,38 @@ matrix: - libx11-xcb-dev - libelf-dev - env: +

Re: [Mesa-dev] [PATCH 1/2] mesa: remove pointless assignments in init_teximage_fields_ms()

This patch is Reviewed-by: Ian Romanick On 07/20/2017 10:07 AM, Brian Paul wrote: > The NumSamples and FixedSampleLocation fields are set again later at > the end of the function so these earlier assignments aren't needed. > --- > src/mesa/main/teximage.c | 3 --- > 1

Re: [Mesa-dev] [PATCH V2] i965 : Optimize atom state flag checks

> Just some style comments, feel free to ignore them. > Both comments are relevant, will address them in V3. Thanks Lionel. > On 20/07/17 12:35, aravindan.muthuku...@intel.com wrote: > > From: Aravindan Muthukumar > > > > This patch improves CPI Rate(Cycles per

[Mesa-dev] [PATCH 2/3] swr/rast: cache line align hottile buffers

Prevents unalignment crashes with avx512 code on gcc/clang. --- src/gallium/drivers/swr/rasterizer/core/tilemgr.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/tilemgr.cpp b/src/gallium/drivers/swr/rasterizer/core/tilemgr.cpp

[Mesa-dev] [PATCH 3/3] swr/rast: fix memory paths for avx512 optimized avx/sse

Source/destination will not be AVX512 aligned, use the unaligned load/store intrinsics. --- .../drivers/swr/rasterizer/common/simdlib_128_avx512.inl | 10 +- .../drivers/swr/rasterizer/common/simdlib_256_avx512.inl | 10 +- 2 files changed, 10 insertions(+), 10

[Mesa-dev] [EGL android: accquire fence implementation 2/2] i965: Queue the buffer with a sync fence for Android OS v4.1

Before we queued the buffer with a invalid fence (-1), it will make some benchmarks failed to test such as flatland. Now we get the out fence during the flushing buffer and then pass it to SurfaceFlinger in eglSwapbuffer function. v2: a) Also implement the fence in cancelBuffer. b) The last

[Mesa-dev] [EGL android: accquire fence implementation 1/2] i965: Return the last fence if the batch buffer is empty and nothing to be flushed when _intel_batchbuffer_flush_fence.

Always save the last fence in the brw context when flushing buffer. If the buffer is nothing to be flushed, then return the last fence when asked for. Change-Id: Ic47035bcd1a27e402609afd9e2d1e3972548b97d Signed-off-by: Zhongmin Wu ---

[Mesa-dev] [EGL android: accquire fence implementation 1/2] i965: Return the last fence if the batch buffer is empty and nothing to be flushed when _intel_batchbuffer_flush_fence.

Always save the last fence in the brw context when flushing buffer. If the buffer is nothing to be flushed, then return the last fence when asked for. Change-Id: Ic47035bcd1a27e402609afd9e2d1e3972548b97d Signed-off-by: Zhongmin Wu ---

Re: [Mesa-dev] [PATCH V2] i965 : Optimize atom state flag checks

> -Original Message- > From: Ian Romanick [mailto:i...@freedesktop.org] > Sent: Friday, July 21, 2017 2:24 AM > To: Marathe, Yogesh ; Muthukumar, Aravindan > ; mesa-dev@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH V2] i965

[Mesa-dev] [PATCH] st/mesa: add destroy_drawable interface

With this patch, the st manager will maintain a hash table for the active framebuffer interface objects. A destroy_drawable interface is added to allow the state tracker to notify the st manager to remove the associated framebuffer interface object from the hash table, so the associated

[Mesa-dev] [PATCH] i965: Push no_hw down to the execbuf call

For the common path where we want to execute the batch, if we push the no_hw detection down to the execbuf we can eliminate one loop over all the execobjects. For the less common path where we don't want to execute the batch, no_hw was leaving out_fence uninitialised. To simplify later changes,

Re: [Mesa-dev] [PATCH 08/13] i965: Convert reloc.target_handle into an index for I915_EXEC_HANDLE_LUT

Quoting Kenneth Graunke (2017-07-20 17:57:22) > On Thursday, July 20, 2017 8:05:19 AM PDT Chris Wilson wrote: > > Quoting Kenneth Graunke (2017-07-19 23:36:58) > > > On Wednesday, July 19, 2017 3:09:16 AM PDT Chris Wilson wrote: > > > > #define READ_ONCE(x) (*(volatile __typeof__(x) *)&(x)) > > >

[Mesa-dev] [Bug 101844] Artifacts in form of wrong pixels appearing on some surfaces

https://bugs.freedesktop.org/show_bug.cgi?id=101844 --- Comment #7 from Fabian Maurer --- Sorry, look like I was wrong. There seem to always have been artifacts, but since a newer Minecraft version they're colorful instead of black, making them way more noticeable.

Re: [Mesa-dev] [PATCH mesa 4/5] wayland-egl: Make wl_egl_window a versioned struct

On 20 July 2017 at 01:38, Miguel Angel Vico wrote: > > > On Wed, 19 Jul 2017 12:06:06 +0100 > Emil Velikov wrote: > >> On 18 July 2017 at 21:49, Miguel A. Vico wrote: >> > We need wl_egl_window to be a versioned struct in

Re: [Mesa-dev] [PATCH V2] i965 : Optimize atom state flag checks

On 07/20/2017 04:35 AM, aravindan.muthuku...@intel.com wrote: > From: Aravindan Muthukumar > > This patch improves CPI Rate(Cycles per Instruction) > and branch mispredict for i965. The function check_state() > was showing CPI retired rate. > > Performance stats

Re: [Mesa-dev] [PATCH V2] i965 : Optimize atom state flag checks

"Marathe, Yogesh" writes: > Francisco, > >> -Original Message- >> From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf >> Of Francisco Jerez >> Sent: Thursday, July 20, 2017 10:51 PM >> To: Muthukumar, Aravindan

Re: [Mesa-dev] [PATCH V2] i965 : Optimize atom state flag checks

On 07/20/2017 11:30 AM, Marathe, Yogesh wrote: > Francisco, > >> -Original Message- >> From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf >> Of Francisco Jerez >> Sent: Thursday, July 20, 2017 10:51 PM >> To: Muthukumar, Aravindan ;

Re: [Mesa-dev] [PATCH V2] i965 : Optimize atom state flag checks

Ian, > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf > Of Ian Romanick > Sent: Friday, July 21, 2017 12:33 AM > To: Muthukumar, Aravindan ; mesa- > d...@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH

[Mesa-dev] [PATCH] egl/wayland: Fix linking libEGL_common.la

Because libmesautil.la includes string_to_uint_map.o, -lstdc++ is required for linking to succeed Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101851 Signed-off-by: Mike Lothian --- src/egl/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

  1   2   >