[Mesa-dev] [PATCH 2/3] anv: only expose up to 28 vertex attributes

2017-07-21 Thread Iago Toral Quiroga
We were exposing 31 because the hardware allows for 33 and we need to reserve one vertex buffer to upload VertexIndex/InstanceIndex and another to upload DrawID when needed, however, there is another restriction in the hardware regarding the size of the VUE entries that limits this down to 30 (28

[Mesa-dev] [PATCH 3/3] intel/compiler: properly size attribute wa_flags array for Vulkan

2017-07-21 Thread Iago Toral Quiroga
Mesa will map user defined vertex input attributes to slots starting at VERT_ATTRIB_GENERIC0 which gives us room for only 16 slots (up to GL_VERT_ATTRIB_MAX). This sufficient for GL, where we expose exactly 16 vertex attributes for user defined inputs, but in Vulkan we can expose up to 28 (which

[Mesa-dev] [PATCH 1/3] anv/cmd_buffer: fix off by one error in assertion

2017-07-21 Thread Iago Toral Quiroga
--- src/intel/vulkan/anv_cmd_buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_cmd_buffer.c b/src/intel/vulkan/anv_cmd_buffer.c index 7317674843..3b59af8f6f 100644 --- a/src/intel/vulkan/anv_cmd_buffer.c +++ b/src/intel/vulkan/anv_cmd_buffer.c @@

Re: [Mesa-dev] [PATCH 1/2] glsl: remove placeholder comment

2017-07-21 Thread Samuel Pitoiset
Series is: Reviewed-by: Samuel Pitoiset On 07/21/2017 06:30 AM, Timothy Arceri wrote: This was added in 2d03f48a65a666 and seems like it was intended as a TODO comment in a function stub rather than a useful code comment. --- src/compiler/glsl/ast_to_hir.cpp | 4

Re: [Mesa-dev] [PATCH] mesa: add compressed_tex_sub_image_{error, no_error} helpers

2017-07-21 Thread Timothy Arceri
I wasn't too worried about this because more than just no_error gets in-lined away, for example the dsa conditions and also the dim == 3. The resulting output shouldn't be overly large. What do you think? On 21/07/17 18:43, Samuel Pitoiset wrote: To avoid inlining compressed_tex_sub_image() a

[Mesa-dev] [Bug 101867] Launch options window renders black in Feral Games in current Mesa trunk

2017-07-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101867 Bug ID: 101867 Summary: Launch options window renders black in Feral Games in current Mesa trunk Product: Mesa Version: git Hardware: Other OS: Linux

[Mesa-dev] [Bug 101867] Launch options window renders black in Feral Games in current Mesa trunk

2017-07-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101867 Marc Di Luzio changed: What|Removed |Added CC|

[Mesa-dev] [PATCH] mesa: add compressed_tex_sub_image_{error, no_error} helpers

2017-07-21 Thread Samuel Pitoiset
To avoid inlining compressed_tex_sub_image() a bunch of times. Signed-off-by: Samuel Pitoiset --- src/mesa/main/teximage.c | 101 ++- 1 file changed, 65 insertions(+), 36 deletions(-) diff --git a/src/mesa/main/teximage.c

[Mesa-dev] [PATCH V3] i965 : Optimize atom state flag checks

2017-07-21 Thread aravindan . muthukumar
From: Aravindan Muthukumar This patch improves CPI Rate(Cycles per Instruction) and branch miss predict for i965. The function check_state() was showing CPI retired rate. Performance stats with android: - CPI retired lowered by 28% (lower is better) - Branch

Re: [Mesa-dev] [PATCH v2] radv: Fix descriptors for cube images with VK_IMAGE_USAGE_STORAGE_BIT

2017-07-21 Thread Alex Smith
Hi Gražvydas, I don't have Doom available to test. How's it broken? Could you see if removing the usage flags condition on the second call to radv_image_view_make_descriptor makes any difference? Otherwise I'm not sure what's wrong - as far as I could tell this should be making RADV do basically

[Mesa-dev] [PATCH] radv: initial support for shared semaphores (v2)

2017-07-21 Thread Dave Airlie
From: Dave Airlie This adds support for sharing semaphores using kernel syncobjects. Syncobj backed semaphores are used for any semaphore which is created with external flags, and when a semaphore is imported, otherwise we use the current non-kernel semaphores. Temporary

Re: [Mesa-dev] [PATCH 1/2] mesa: remove pointless assignments in init_teximage_fields_ms()

2017-07-21 Thread Samuel Pitoiset
Series is: Reviewed-by: Samuel Pitoiset On 07/20/2017 07:07 PM, Brian Paul wrote: The NumSamples and FixedSampleLocation fields are set again later at the end of the function so these earlier assignments aren't needed. --- src/mesa/main/teximage.c | 3 --- 1 file

Re: [Mesa-dev] [PATCH] mesa: add compressed_tex_sub_image_{error, no_error} helpers

2017-07-21 Thread Samuel Pitoiset
On 07/21/2017 11:19 AM, Timothy Arceri wrote: I wasn't too worried about this because more than just no_error gets in-lined away, for example the dsa conditions and also the dim == 3. The resulting output shouldn't be overly large. What do you think? Usually, when a helper function marked

[Mesa-dev] [Bug 99591] Segmentation fault when running vulkaninfo with RADV Radeon Vulkan driver

2017-07-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99591 --- Comment #10 from Mike Lothian --- I saw something similar when LLVM was compiled with LTO, the SaschaWillems demos would run, but often on closing I'd see messages about a missing symbol -- You are receiving this mail

[Mesa-dev] [PATCH 051/101] mesa: rename bind_texture() to bind_texture_object()

2017-07-21 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mesa/main/texobj.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c index 95f2b34337..2eb8eae4b1 100644 --- a/src/mesa/main/texobj.c +++

[Mesa-dev] [PATCH 050/101] mesa: add KHR_no_error support to glMemoryBarrierByRegion()

2017-07-21 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/GL4x.xml | 2 +- src/mesa/main/barrier.c | 7 +++ src/mesa/main/barrier.h | 3 +++ 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/GL4x.xml b/src/mapi/glapi/gen/GL4x.xml

[Mesa-dev] [PATCH 059/101] mesa: add delete_textures() helper

2017-07-21 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mesa/main/texobj.c | 34 -- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c index b698569509..494ea25f80 100644 ---

[Mesa-dev] [PATCH 061/101] mesa: add framebuffer_renderbuffer_error() helper

2017-07-21 Thread Samuel Pitoiset
And make framebuffer_renderbuffer() always inline. Signed-off-by: Samuel Pitoiset --- src/mesa/main/fbobject.c | 109 +++ 1 file changed, 63 insertions(+), 46 deletions(-) diff --git a/src/mesa/main/fbobject.c

[Mesa-dev] [PATCH 049/101] mesa: add memory_barrier_by_region() helper

2017-07-21 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mesa/main/barrier.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/src/mesa/main/barrier.c b/src/mesa/main/barrier.c index e55d13cb6b..0798d6efad 100644 --- a/src/mesa/main/barrier.c +++

[Mesa-dev] [PATCH 045/101] mesa: add KHR_no_error support to glBlendEquationSeparate()

2017-07-21 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/blend.c | 8 src/mesa/main/blend.h | 3 +++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/gl_API.xml

[Mesa-dev] [PATCH 058/101] mesa: add KHR_no_error support to glNamedFramebufferDrawBuffer()

2017-07-21 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 2 +- src/mesa/main/buffers.c| 16 src/mesa/main/buffers.h| 3 +++ 3 files changed, 20 insertions(+), 1 deletion(-)

[Mesa-dev] [PATCH 063/101] mesa: add KHR_no_error support to glNamedFramebufferRenderbuffer()

2017-07-21 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 2 +- src/mesa/main/fbobject.c | 13 + src/mesa/main/fbobject.h | 6 ++ 3 files changed, 20 insertions(+), 1 deletion(-)

[Mesa-dev] [PATCH 054/101] mesa: add bind_textures() helper

2017-07-21 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mesa/main/texobj.c | 47 --- 1 file changed, 28 insertions(+), 19 deletions(-) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c index bf48d7595d..aa3e4190f5 100644 ---

[Mesa-dev] [PATCH 052/101] mesa: add bind_texture() helper

2017-07-21 Thread Samuel Pitoiset
For KHR_no_error support. Signed-off-by: Samuel Pitoiset --- src/mesa/main/texobj.c | 36 +++- 1 file changed, 23 insertions(+), 13 deletions(-) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c index 2eb8eae4b1..04f320cbcd

[Mesa-dev] [PATCH 057/101] mesa: add KHR_no_error support to glDrawBuffer()

2017-07-21 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/buffers.c | 16 src/mesa/main/buffers.h | 3 +++ 3 files changed, 20 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/gl_API.xml

[Mesa-dev] [PATCH] intel/isl: Add support for blitter restrictions

2017-07-21 Thread Jason Ekstrand
--- src/intel/isl/isl.c | 42 +++--- src/intel/isl/isl.h | 1 + src/intel/isl/isl_gen4.c | 5 + 3 files changed, 45 insertions(+), 3 deletions(-) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index 7d1356f..26310bf 100644 ---

[Mesa-dev] [Bug 101867] Launch options window renders black in Feral Games in current Mesa trunk

2017-07-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101867 --- Comment #1 from James Legg --- In loader_dri3_swap_buffers_msc, dri3_find_back increments the index used for selecting the back buffer (draw->cur_back) to the second (index 1) out of two buffer slots because the

[Mesa-dev] [PATCH 008/101] mesa: add texture_view() helper

2017-07-21 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mesa/main/textureview.c | 336 +++- 1 file changed, 175 insertions(+), 161 deletions(-) diff --git a/src/mesa/main/textureview.c b/src/mesa/main/textureview.c index cef9caff41..165af3c746

[Mesa-dev] [PATCH 002/101] mesa: add KHR_no_error support to glDepthRangeArrayv

2017-07-21 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_viewport_array.xml | 2 +- src/mesa/main/viewport.c | 10 ++ src/mesa/main/viewport.h | 4 3 files changed, 15 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 013/101] mesa: add KHR_no_error support to glDeleteSync()

2017-07-21 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_sync.xml | 2 +- src/mesa/main/syncobj.c | 8 src/mesa/main/syncobj.h | 3 +++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/ARB_sync.xml

[Mesa-dev] [PATCH 007/101] mesa: add KHR_no_error support to glPatchParameteri()

2017-07-21 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_tessellation_shader.xml | 2 +- src/mesa/main/shaderapi.c | 8 src/mesa/main/shaderapi.h | 3 +++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 014/101] mesa: add program_parameteri() helper

2017-07-21 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mesa/main/shaderapi.c | 38 -- 1 file changed, 24 insertions(+), 14 deletions(-) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index 924423ee69..63aec08d0c 100644 ---

[Mesa-dev] [PATCH 005/101] mesa: add blend_equationi() helper

2017-07-21 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mesa/main/blend.c | 29 ++--- 1 file changed, 18 insertions(+), 11 deletions(-) diff --git a/src/mesa/main/blend.c b/src/mesa/main/blend.c index 3265628311..84029ac6be 100644 --- a/src/mesa/main/blend.c

[Mesa-dev] [PATCH 011/101] mesa: add KHR_no_error support to glWaitSync()

2017-07-21 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_sync.xml | 2 +- src/mesa/main/syncobj.c | 10 ++ src/mesa/main/syncobj.h | 3 +++ 3 files changed, 14 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/ARB_sync.xml

[Mesa-dev] [PATCH 010/101] mesa: add wait_sync() helper

2017-07-21 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mesa/main/syncobj.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/syncobj.c b/src/mesa/main/syncobj.c index 9c165314bf..361ead6dce 100644 --- a/src/mesa/main/syncobj.c +++

[Mesa-dev] [PATCH 009/101] mesa: add KHR_no_error support to glTextureView()

2017-07-21 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_texture_view.xml | 2 +- src/mesa/main/textureview.c | 18 ++ src/mesa/main/textureview.h | 6 ++ 3 files changed, 25 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 05/17] intel/isl: Aling non-tiled horizontally by cache line

2017-07-21 Thread Pohjolainen, Topi
On Fri, Jul 21, 2017 at 11:09:47AM -0700, Jason Ekstrand wrote: > s/Aling/Align/ > > On Fri, Jul 21, 2017 at 8:00 AM, Topi Pohjolainen < > topi.pohjolai...@gmail.com> wrote: > > > in order to support blit engine. > > > > Signed-off-by: Topi Pohjolainen > > --- > >

Re: [Mesa-dev] [PATCH 17/17] i965/miptree: Clean-up unused

2017-07-21 Thread Pohjolainen, Topi
On Fri, Jul 21, 2017 at 11:43:16AM -0700, Jason Ekstrand wrote: > On Fri, Jul 21, 2017 at 8:01 AM, Topi Pohjolainen < > topi.pohjolai...@gmail.com> wrote: > > > Signed-off-by: Topi Pohjolainen > > --- > > src/mesa/drivers/dri/i965/Makefile.sources | 1 - > >

Re: [Mesa-dev] [PATCH 03/17] i965/miptree: Prepare non-tiled fallback for isl based

2017-07-21 Thread Pohjolainen, Topi
On Fri, Jul 21, 2017 at 12:22:48PM -0700, Jason Ekstrand wrote: > On Fri, Jul 21, 2017 at 11:23 AM, Pohjolainen, Topi < > topi.pohjolai...@gmail.com> wrote: > > > On Fri, Jul 21, 2017 at 10:54:34AM -0700, Jason Ekstrand wrote: > > > On Fri, Jul 21, 2017 at 8:00 AM, Topi Pohjolainen < > > >

[Mesa-dev] [Bug 101867] Launch options window renders black in Feral Games in current Mesa trunk

2017-07-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101867 --- Comment #2 from Tim Writer ---  I'm hosting meetings this week. E-mail responses will be delayed. Regards, Tim -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

Re: [Mesa-dev] [PATCH dri3proto v2] Add modifier/multi-plane requests, bump to v1.1

2017-07-21 Thread Michel Dänzer
On 20/07/17 01:08 PM, Daniel Stone wrote: DRI3 version 1.1 adds support for explicit format modifiers, including multi-planar buffers. Adding mesa-dev, Nicolai and Marek. We just ran into an issue which might mean that there's still something missing in this v2 proposal: The context is

[Mesa-dev] [PATCH 030/101] mesa: add KHR_no_error support to glMultiDraw*Indirect*()

2017-07-21 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mesa/vbo/vbo_exec_array.c | 56 --- 1 file changed, 42 insertions(+), 14 deletions(-) diff --git a/src/mesa/vbo/vbo_exec_array.c b/src/mesa/vbo/vbo_exec_array.c index dfb8402014..98abf47bd3

[Mesa-dev] [PATCH 024/101] mesa: add KHR_no_error support to glTextureStorage*D()

2017-07-21 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 6 ++-- src/mesa/main/texstorage.c | 40 ++ src/mesa/main/texstorage.h | 12 3 files changed, 55 insertions(+),

[Mesa-dev] [PATCH 034/101] mesa: add bind_vertex_array() helper

2017-07-21 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mesa/main/arrayobj.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/arrayobj.c b/src/mesa/main/arrayobj.c index af6a17daec..fcc7990ef0 100644 --- a/src/mesa/main/arrayobj.c

[Mesa-dev] [PATCH 031/101] mesa: add read_pixels() helper

2017-07-21 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mesa/main/readpix.c | 169 ++-- 1 file changed, 90 insertions(+), 79 deletions(-) diff --git a/src/mesa/main/readpix.c b/src/mesa/main/readpix.c index 606d1e58e5..72aa6a3f31 100644 ---

[Mesa-dev] [PATCH 040/101] mesa: add generate_texture_mipmap_error() helper

2017-07-21 Thread Samuel Pitoiset
And make generate_texture_mipmap() always inline. Signed-off-by: Samuel Pitoiset --- src/mesa/main/genmipmap.c | 46 -- 1 file changed, 28 insertions(+), 18 deletions(-) diff --git a/src/mesa/main/genmipmap.c

[Mesa-dev] [PATCH 041/101] mesa: add KHR_no_error support to glGenerate*Mipmap()

2017-07-21 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 2 +- src/mapi/glapi/gen/ARB_framebuffer_object.xml | 2 +- src/mesa/main/genmipmap.c | 26 ++ src/mesa/main/genmipmap.h

[Mesa-dev] [PATCH 028/101] mesa: add KHR_no_error support to glVertexArrayBindingDivisor()

2017-07-21 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 2 +- src/mesa/main/varray.c | 11 +++ src/mesa/main/varray.h | 4 3 files changed, 16 insertions(+), 1 deletion(-) diff

[Mesa-dev] [PATCH 037/101] mesa: add KHR_no_error to glDeleteVertexArrays()

2017-07-21 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_vertex_array_object.xml | 2 +- src/mesa/main/arrayobj.c | 8 src/mesa/main/arrayobj.h | 3 +++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 032/101] mesa: add KHR_no_error support to glRead*Pixels*()

2017-07-21 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_robustness.xml | 2 +- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/readpix.c | 16 src/mesa/main/readpix.h | 9 + 4 files changed, 27

[Mesa-dev] [PATCH 033/101] mesa: add KHR_no_error support to glInvalidate*()

2017-07-21 Thread Samuel Pitoiset
These are just no-op because we don't actually do anything useful in the errors path. Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_invalidate_subdata.xml | 8 src/mesa/main/fbobject.c | 17 +

Re: [Mesa-dev] Mesa 17.2.0 release plan

2017-07-21 Thread Emil Velikov
On 20 July 2017 at 06:09, Jason Ekstrand wrote: > On Mon, Jul 17, 2017 at 7:54 AM, Emil Velikov > wrote: >> >> On 16 July 2017 at 06:35, Jason Ekstrand wrote: >> > n Fri, Jul 7, 2017 at 11:07 AM, Emil Velikov

Re: [Mesa-dev] [PATCH 10/17] main/teximage: Even on failure use valid format for init()

2017-07-21 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand Cc stable? On Fri, Jul 21, 2017 at 8:01 AM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > Otherwise init_teximage_fields_ms() (called by > _mesa_init_teximage_fields()) will always assert as it can't > find valid base format. > >

Re: [Mesa-dev] [PATCH 15/17] i965/miptree: Switch remaining surfaces to isl

2017-07-21 Thread Jason Ekstrand
11-15 are Reviewed-by: Jason Ekstrand On Fri, Jul 21, 2017 at 8:01 AM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 10 +- >

[Mesa-dev] [PATCH v2] swr/rast: quit using linux-specific gettid()

2017-07-21 Thread Tim Rowley
Linux-specific gettid() syscall shouldn't be used in portable code. Fix does assume a 1:1 thread:LWP architecture, but works for our current target platforms and can be revisited later if needed. Fixes unresolved symbol in linux scons builds. v2: add comment in code about the 1:1 assumption.

Re: [Mesa-dev] [PATCH 03/17] i965/miptree: Prepare non-tiled fallback for isl based

2017-07-21 Thread Jason Ekstrand
On Fri, Jul 21, 2017 at 11:23 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Fri, Jul 21, 2017 at 10:54:34AM -0700, Jason Ekstrand wrote: > > On Fri, Jul 21, 2017 at 8:00 AM, Topi Pohjolainen < > > topi.pohjolai...@gmail.com> wrote: > > > > > See brw_miptree_choose_tiling(). > >

Re: [Mesa-dev] [PATCH] intel/isl: Add support for blitter restrictions

2017-07-21 Thread Jason Ekstrand
On Fri, Jul 21, 2017 at 12:27 PM, Chris Wilson wrote: > Quoting Jason Ekstrand (2017-07-21 20:11:27) > > + if (surf_info->usage & ISL_SURF_USAGE_BLIT_BIT) { > > + /* According to the Ivy Bridge PRM, Vol1 Part4, section 1.2.1.2 > > + * (Graphics Data Size

Re: [Mesa-dev] [PATCH] gallivm: handle call attributes for llvm < 4.0 in lp_add_function_attr

2017-07-21 Thread Brian Paul
On 07/21/2017 12:31 PM, srol...@vmware.com wrote: From: Roland Scheidegger We had some caller using LLVMAddInstrAttributes, which couldn't be converted to lp_add_function_attr, because attributes were only handled for functions in this case, so fix this. For llvm >= 4.0,

[Mesa-dev] [PATCH 084/101] mesa: add end_conditional_render() render

2017-07-21 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mesa/main/condrender.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/src/mesa/main/condrender.c b/src/mesa/main/condrender.c index 24a7f4b694..051cd8f962 100644 ---

[Mesa-dev] [PATCH 082/101] mesa: add begin_conditional_render() helper

2017-07-21 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mesa/main/condrender.c | 121 - 1 file changed, 66 insertions(+), 55 deletions(-) diff --git a/src/mesa/main/condrender.c b/src/mesa/main/condrender.c index 2ea2c8821d..95d6d6ad5f

[Mesa-dev] [PATCH 067/101] mesa: add KHR_no_error support to glDrawBuffers()

2017-07-21 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/buffers.c | 16 src/mesa/main/buffers.h | 3 +++ 3 files changed, 20 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/gl_API.xml

[Mesa-dev] [PATCH 080/101] mesa: add buffer_data() and buffer_data_error() helpers

2017-07-21 Thread Samuel Pitoiset
And call buffer_data_error() from _mesa_buffer_data(). Signed-off-by: Samuel Pitoiset --- src/mesa/main/bufferobj.c | 112 ++ 1 file changed, 64 insertions(+), 48 deletions(-) diff --git a/src/mesa/main/bufferobj.c

[Mesa-dev] [PATCH 087/101] mesa: add shader_source() helper

2017-07-21 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mesa/main/shaderapi.c | 34 +++--- 1 file changed, 23 insertions(+), 11 deletions(-) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index ae5647b4c0..941419b6f1 100644 ---

Re: [Mesa-dev] [PATCH 01/17] intel/isl: Add missing stencil pitch validation

2017-07-21 Thread Jason Ekstrand
On Fri, Jul 21, 2017 at 8:00 AM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > Signed-off-by: Topi Pohjolainen > --- > src/intel/isl/isl.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/src/intel/isl/isl.c

[Mesa-dev] [PATCH 073/101] mesa: add KHR_no_error support to glTextureSubImage*D()

2017-07-21 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 6 +-- src/mesa/main/teximage.c | 52 ++ src/mesa/main/teximage.h | 16 3 files changed, 71 insertions(+),

[Mesa-dev] [PATCH 086/101] mesa: rename shader_source() to set_shader_source()

2017-07-21 Thread Samuel Pitoiset
There is already get_shader_source(), and shader_source() will be used for adding KHR_no_error support. Signed-off-by: Samuel Pitoiset --- src/mesa/main/shaderapi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/shaderapi.c

[Mesa-dev] [PATCH 088/101] mesa: add KHR_no_error support to glShaderSource()

2017-07-21 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/shaderapi.c | 9 + src/mesa/main/shaderapi.h | 4 3 files changed, 14 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/gl_API.xml

[Mesa-dev] [PATCH 038/101] mesa: add delete_samplers() helper

2017-07-21 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mesa/main/samplerobj.c | 28 +--- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/src/mesa/main/samplerobj.c b/src/mesa/main/samplerobj.c index d182ee03c0..aae2a6bbbf 100644 ---

[Mesa-dev] [PATCH 090/101] mesa: add KHR_no_error support to glLinkProgram()

2017-07-21 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/shaderapi.c | 18 ++ src/mesa/main/shaderapi.h | 3 +++ 3 files changed, 22 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/gl_API.xml

Re: [Mesa-dev] [PATCH 03/17] i965/miptree: Prepare non-tiled fallback for isl based

2017-07-21 Thread Jason Ekstrand
On Fri, Jul 21, 2017 at 8:00 AM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > See brw_miptree_choose_tiling(). > > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 36 > +++ > 1 file changed,

[Mesa-dev] [PATCH 1/3] swr: don't forget to link AVX/AVX2 against pthreads

2017-07-21 Thread Emil Velikov
From: Emil Velikov Seems like the backends have been using pthreads since day one, yet we've been missing the link. With later commit we'll fix a typo, hence the libraries will be build with -Wl,no-undefined, aka failing the build on unresolved symbols. v2: Split

[Mesa-dev] [PATCH 2/3] swr: don't forget to link KNL/SKX against pthreads

2017-07-21 Thread Emil Velikov
From: Emil Velikov Analogous to previous commit but for the KNL/SKX backends. Cc: Bruce Cherniak Cc: Tim Rowley Cc: Laurent Carlier Fixes: 1cb5a6061ce ("configure/swr: add KNL and SKX

[Mesa-dev] [PATCH 3/3] swr: use the correct variable for no undefined symbols

2017-07-21 Thread Emil Velikov
From: Emil Velikov The variable name was missing a leading LD_, which resulted in the backend binaries having unresolved symbols. With the link addressed with earlier patches, we can correct the typo. Thanks to Laurent for the help spotting this. v2: Split from a

Re: [Mesa-dev] [PATCH 03/17] i965/miptree: Prepare non-tiled fallback for isl based

2017-07-21 Thread Pohjolainen, Topi
On Fri, Jul 21, 2017 at 10:54:34AM -0700, Jason Ekstrand wrote: > On Fri, Jul 21, 2017 at 8:00 AM, Topi Pohjolainen < > topi.pohjolai...@gmail.com> wrote: > > > See brw_miptree_choose_tiling(). > > > > Signed-off-by: Topi Pohjolainen > > --- > >

[Mesa-dev] [PATCH] gallivm: handle call attributes for llvm < 4.0 in lp_add_function_attr

2017-07-21 Thread sroland
From: Roland Scheidegger We had some caller using LLVMAddInstrAttributes, which couldn't be converted to lp_add_function_attr, because attributes were only handled for functions in this case, so fix this. For llvm >= 4.0, this already works correctly. (radeonsi seems to avoid

Re: [Mesa-dev] [PATCH] intel/isl: Add support for blitter restrictions

2017-07-21 Thread Chris Wilson
Quoting Jason Ekstrand (2017-07-21 20:11:27) > + if (surf_info->usage & ISL_SURF_USAGE_BLIT_BIT) { > + /* According to the Ivy Bridge PRM, Vol1 Part4, section 1.2.1.2 > + * (Graphics Data Size Limitations): > + * > + *The BLT engine is capable of transferring very

Re: [Mesa-dev] [PATCH 2/3] swr: don't forget to link KNL/SKX against pthreads

2017-07-21 Thread Rowley, Timothy O
Reviewed-by: Tim Rowley > On Jul 21, 2017, at 1:05 PM, Emil Velikov wrote: > > From: Emil Velikov > > Analogous to previous commit but for the KNL/SKX backends. > > Cc: Bruce Cherniak

Re: [Mesa-dev] [PATCH 1/3] swr: don't forget to link AVX/AVX2 against pthreads

2017-07-21 Thread Rowley, Timothy O
Reviewed-by: Tim Rowley > On Jul 21, 2017, at 1:05 PM, Emil Velikov wrote: > > From: Emil Velikov > > Seems like the backends have been using pthreads since day one, yet > we've been missing the link. > > With

Re: [Mesa-dev] [PATCH 20/32] intel/isl: Add an aux state for "partial clear"

2017-07-21 Thread Pohjolainen, Topi
On Wed, Jul 19, 2017 at 02:01:46PM -0700, Jason Ekstrand wrote: > --- > src/intel/isl/isl.h | 88 > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 11 > 2 files changed, 64 insertions(+), 35 deletions(-) > > diff --git

Re: [Mesa-dev] [Mesa-stable] [PATCH 3/3] swr: use the correct variable for no undefined symbols

2017-07-21 Thread Rowley, Timothy O
Reviewed-by: Tim Rowley > On Jul 21, 2017, at 1:05 PM, Emil Velikov wrote: > > From: Emil Velikov > > The variable name was missing a leading LD_, which resulted in the > backend binaries having unresolved

Re: [Mesa-dev] [PATCH] radv: initial support for shared semaphores (v2)

2017-07-21 Thread Bas Nieuwenhuizen
On Fri, Jul 21, 2017 at 9:33 AM, Dave Airlie wrote: > From: Dave Airlie > > This adds support for sharing semaphores using kernel syncobjects. > > Syncobj backed semaphores are used for any semaphore which is > created with external flags, and when a

[Mesa-dev] [PATCH 043/101] mesa: add KHR_no_error support to glPrimitiveRestartIndex()

2017-07-21 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/GL3x.xml | 2 +- src/mesa/main/varray.c | 8 src/mesa/main/varray.h | 3 +++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/GL3x.xml

[Mesa-dev] [PATCH 042/101] mesa: add primitive_restart_index() helper

2017-07-21 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mesa/main/varray.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/varray.c b/src/mesa/main/varray.c index db9261f105..6aa4c72bdd 100644 --- a/src/mesa/main/varray.c +++

[Mesa-dev] [PATCH 036/101] mesa: add delete_vertex_arrays() helper

2017-07-21 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mesa/main/arrayobj.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/src/mesa/main/arrayobj.c b/src/mesa/main/arrayobj.c index 77c0206ecf..60a24663f7 100644 ---

[Mesa-dev] [PATCH 018/101] mesa: add bind_sampler() helper

2017-07-21 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mesa/main/samplerobj.c | 28 +--- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/src/mesa/main/samplerobj.c b/src/mesa/main/samplerobj.c index e84c0277f1..5e29ada334 100644 ---

[Mesa-dev] [PATCH 055/101] mesa: add KHR_no_error support to glBindTextures()

2017-07-21 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_multi_bind.xml | 2 +- src/mesa/main/texobj.c| 8 src/mesa/main/texobj.h| 4 3 files changed, 13 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 029/101] mesa: add KHR_no_error support to glMultiDrawElementsBaseVertex()

2017-07-21 Thread Samuel Pitoiset
Just skip validation when no_error is enabled. Signed-off-by: Samuel Pitoiset --- src/mesa/vbo/vbo_exec_array.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/mesa/vbo/vbo_exec_array.c b/src/mesa/vbo/vbo_exec_array.c index

[Mesa-dev] [PATCH 044/101] mesa: add blend_equation_separate() helper

2017-07-21 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mesa/main/blend.c | 67 ++- 1 file changed, 39 insertions(+), 28 deletions(-) diff --git a/src/mesa/main/blend.c b/src/mesa/main/blend.c index 8fb2d692a3..2c13f19004 100644 ---

[Mesa-dev] [PATCH 047/101] mesa: add KHR_no_error support to glMinSampleShading()

2017-07-21 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/GL4x.xml | 2 +- src/mesa/main/multisample.c | 7 +++ src/mesa/main/multisample.h | 3 +++ 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/GL4x.xml b/src/mapi/glapi/gen/GL4x.xml

[Mesa-dev] [PATCH 035/101] mesa: add KHR_no_error to glBindVertexArray()

2017-07-21 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_vertex_array_object.xml | 2 +- src/mesa/main/arrayobj.c | 8 src/mesa/main/arrayobj.h | 3 +++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 039/101] mesa: add KHR_no_error support to glDeleteSamplers()

2017-07-21 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_sampler_objects.xml | 2 +- src/mesa/main/samplerobj.c | 8 src/mesa/main/samplerobj.h | 5 + 3 files changed, 14 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 02/17] i965/miptree: Prepare has_color_unresolved() for isl based

2017-07-21 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Fri, Jul 21, 2017 at 8:00 AM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 6 +- > 1 file changed, 5

Re: [Mesa-dev] [PATCH 09/17] intel/isl/gen7: Don't allow multisampled surfaces with valign2

2017-07-21 Thread Jason Ekstrand
6-9 are Reviewed-by: Jason Ekstrand On Fri, Jul 21, 2017 at 8:01 AM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > There is the same constraintg later on as assert in > isl_gen7_choose_image_alignment_el() so catch it earlier in order > to return error instead

Re: [Mesa-dev] [PATCH V3] i965 : Optimize atom state flag checks

2017-07-21 Thread Matt Turner
On 07/21, aravindan.muthuku...@intel.com wrote: From: Aravindan Muthukumar This patch improves CPI Rate(Cycles per Instruction) and branch miss predict for i965. The function check_state() was showing CPI retired rate. Performance stats with android: - CPI

[Mesa-dev] [PATCH 001/101] mesa: add depth_range_arrayv() helper

2017-07-21 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mesa/main/viewport.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/viewport.c b/src/mesa/main/viewport.c index 0a5caf04c6..d010c8e6db 100644 --- a/src/mesa/main/viewport.c

[Mesa-dev] [PATCH 004/101] mesa: add KHR_no_error support to glSampleMaski()

2017-07-21 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_texture_multisample.xml | 2 +- src/mesa/main/multisample.c| 7 +++ src/mesa/main/multisample.h| 3 +++ 3 files changed, 11 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 003/101] mesa: add sample_maski() helper

2017-07-21 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mesa/main/multisample.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/multisample.c b/src/mesa/main/multisample.c index 38d91f7204..121023ac82 100644 ---

[Mesa-dev] [PATCH 000/101] Some more various KHR_no_error patches

2017-07-21 Thread Samuel Pitoiset
Hi there, After grepping into src/mapi and looking at some apitrace traces, KHR_no_error support can be added to more various GL calls. It seems like this series improves Dirt Rally in low by ~3%, this is not much but I think it's worth trying. I didn't do any other benchmarks but it should help

[Mesa-dev] [PATCH 006/101] mesa: add KHR_no_error support to glBlendEquationiARB()

2017-07-21 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_draw_buffers_blend.xml | 2 +- src/mesa/main/blend.c | 11 +++ src/mesa/main/blend.h | 3 +++ 3 files changed, 15 insertions(+), 1 deletion(-) diff

[Mesa-dev] [PATCH 071/101] mesa: add KHR_no_error support to glDetachShader() and glDetachObjectARB()

2017-07-21 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/gl_API.xml | 4 ++-- src/mesa/main/shaderapi.c | 23 +++ src/mesa/main/shaderapi.h | 6 ++ 3 files changed, 31 insertions(+), 2 deletions(-) diff --git

  1   2   3   >