[Mesa-dev] [Bug 102122] [softpipe] piglit fdo10370 regression

2017-08-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102122 Bug ID: 102122 Summary: [softpipe] piglit fdo10370 regression Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Keywords:

Re: [Mesa-dev] [PATCH 00/10] anv: Implement VK_KHR_external_fence*

2017-08-08 Thread Jordan Justen
On 2017-08-08 15:45:25, Jason Ekstrand wrote: > This little series adds support for the VK_KHR_external_fence family of > extensions. Most of the real work in implementing these extensions is > actually in the kernel. Once we have a DRM_SYNCOBJ_IOCTL_WAIT that does > what we need, the userspace

Re: [Mesa-dev] [PATCH 09/25] i965: Reorder brw_reg_type enum values

2017-08-08 Thread Scott D Phillips
Matt Turner writes: > These vaguely corresponded to the hardware encodings, but that is purely > historical at this point. Reorder them so we stop making things "almost > work" when mixing enums. > > The ordering has been closen so that no enum value is the same as a >

Re: [Mesa-dev] [PATCH 00/25] i965: Switch to always using logical register types

2017-08-08 Thread Scott D Phillips
Matt Turner writes: > The mixture of hardware encodings and logical types has caused lots of > confusion. It's time to fix that. fwiw, apart from the one comment about sizeof V/UV, series is Reviewed-by: Scott D Phillips >

Re: [Mesa-dev] [PATCH v2 0/2] glsl: interpolateAt*() fixes

2017-08-08 Thread Timothy Arceri
Hi Nicolai, I put this series through Intels CI system and it hit a couple of issues. I haven't yet checked if these CTS test regress on radeonsi as well or if its just an i965 thing. Project: deqp-test Test: dEQP-

Re: [Mesa-dev] AMD RXxxx/Vega: amd-staging-4.12 or amd-staging-drm-next

2017-08-08 Thread Alex Deucher
On Tue, Aug 8, 2017 at 5:48 PM, Dieter Nützel wrote: > Hello Alex, > > which is the 'right' way to switch to (from amd-staging-4.11)? > 4.13-rx UP (like Phoronix 'found';-)) show nice improvements. amd-staging-4.12 is our current internal development branch.

Re: [Mesa-dev] [PATCH 10/25] i965: Use separate enums for register vs immediate types

2017-08-08 Thread Scott D Phillips
Matt Turner writes: > The hardware encodings often mean different things depending on whether > the source is an immediate. > --- > src/intel/compiler/brw_disasm.c | 46 --- > src/intel/compiler/brw_eu_compact.c | 8 +-- >

[Mesa-dev] [PATCH 09/10] anv: Implement VK_KHR_external_fence

2017-08-08 Thread Jason Ekstrand
--- src/intel/vulkan/anv_batch_chain.c | 19 - src/intel/vulkan/anv_extensions.py | 5 ++ src/intel/vulkan/anv_queue.c | 142 - 3 files changed, 161 insertions(+), 5 deletions(-) diff --git a/src/intel/vulkan/anv_batch_chain.c

[Mesa-dev] [PATCH 08/10] anv: Use DRM sync objects to back fences whenever possible

2017-08-08 Thread Jason Ekstrand
In order to implement VK_KHR_external_fence, we need to back our fences with something that's shareable. Since the kernel wait interface for sync objects already supports waiting for multiple fences in one go, it makes anv_WaitForFences much simpler if we only have one type of fence. ---

[Mesa-dev] [PATCH 01/10] anv: Rework fences to work more like BO semaphores

2017-08-08 Thread Jason Ekstrand
This commit changes fences to work a bit more like BO semaphores. Instead of the fence being a batch, it's simply a BO that gets added to the validation list for the last execbuf call in the QueueSubmit operation. It's a bit annoying finding the last submit in the execbuf but this allows us to

[Mesa-dev] [PATCH 02/10] anv/wsi: Use QueueSubmit to trigger the fence in AcquireNextImage

2017-08-08 Thread Jason Ekstrand
--- src/intel/vulkan/anv_wsi.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/intel/vulkan/anv_wsi.c b/src/intel/vulkan/anv_wsi.c index 9369f26..00edb22 100644 --- a/src/intel/vulkan/anv_wsi.c +++ b/src/intel/vulkan/anv_wsi.c @@ -364,22 +364,25 @@ VkResult

[Mesa-dev] [PATCH 07/10] anv/gem: Add support for syncobj wait and reset

2017-08-08 Thread Jason Ekstrand
--- src/intel/vulkan/anv_gem.c | 61 src/intel/vulkan/anv_gem_stubs.c | 20 + src/intel/vulkan/anv_private.h | 5 3 files changed, 86 insertions(+) diff --git a/src/intel/vulkan/anv_gem.c b/src/intel/vulkan/anv_gem.c index

[Mesa-dev] [PATCH 03/10] anv: Pull the guts of anv_fence into anv_fence_impl

2017-08-08 Thread Jason Ekstrand
This is just a refactor, similar to what we did for semaphores, in preparation for handling VK_KHR_external_fence. --- src/intel/vulkan/anv_batch_chain.c | 22 -- src/intel/vulkan/anv_private.h | 42 ++- src/intel/vulkan/anv_queue.c | 144

[Mesa-dev] [PATCH 04/10] anv: Rename anv_fence_state to anv_bo_fence_state

2017-08-08 Thread Jason Ekstrand
It only applies to legacy BO fences. --- src/intel/vulkan/anv_batch_chain.c | 2 +- src/intel/vulkan/anv_private.h | 10 +- src/intel/vulkan/anv_queue.c | 24 3 files changed, 18 insertions(+), 18 deletions(-) diff --git

[Mesa-dev] [PATCH 00/10] anv: Implement VK_KHR_external_fence*

2017-08-08 Thread Jason Ekstrand
This little series adds support for the VK_KHR_external_fence family of extensions. Most of the real work in implementing these extensions is actually in the kernel. Once we have a DRM_SYNCOBJ_IOCTL_WAIT that does what we need, the userspace bits are fairly straightforward. This series can be

[Mesa-dev] [PATCH 06/10] drm-uapi/drm: Add DRM_IOCTL_SYNCOBJ_WAIT and RESET

2017-08-08 Thread Jason Ekstrand
--- include/drm-uapi/drm.h | 19 +++ 1 file changed, 19 insertions(+) diff --git a/include/drm-uapi/drm.h b/include/drm-uapi/drm.h index bf3674a..06d1d0f 100644 --- a/include/drm-uapi/drm.h +++ b/include/drm-uapi/drm.h @@ -712,6 +712,23 @@ struct drm_syncobj_handle {

[Mesa-dev] [PATCH 05/10] vulkan/util: Add a vk_zalloc helper

2017-08-08 Thread Jason Ekstrand
--- src/vulkan/util/vk_alloc.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/vulkan/util/vk_alloc.h b/src/vulkan/util/vk_alloc.h index 2915021..f58a806 100644 --- a/src/vulkan/util/vk_alloc.h +++ b/src/vulkan/util/vk_alloc.h @@ -37,6 +37,20 @@ vk_alloc(const

[Mesa-dev] AMD RXxxx/Vega: amd-staging-4.12 or amd-staging-drm-next

2017-08-08 Thread Dieter Nützel
Hello Alex, which is the 'right' way to switch to (from amd-staging-4.11)? 4.13-rx UP (like Phoronix 'found';-)) show nice improvements. Sadly I'm hit by the BAD 'e1000e' nic regression. NetworkManager switch it on and off over and over again, since 4.11 UP. --- Daniel/Intel??? 06:00.0

[Mesa-dev] [PATCH 10/10] anv: Add support for the SYNC_FD handle type for fences

2017-08-08 Thread Jason Ekstrand
--- src/intel/vulkan/anv_gem.c | 28 + src/intel/vulkan/anv_gem_stubs.c | 13 ++ src/intel/vulkan/anv_private.h | 4 +++ src/intel/vulkan/anv_queue.c | 53 +++- 4 files changed, 87 insertions(+), 11 deletions(-) diff

[Mesa-dev] [Bug 102123] [llvmpipe] piglit gl-3.2-layered-rendering-framebuffertexture regression

2017-08-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102123 Bug ID: 102123 Summary: [llvmpipe] piglit gl-3.2-layered-rendering-framebuffertexture regression Product: Mesa Version: git Hardware: x86-64 (AMD64) OS:

[Mesa-dev] [PATCH] i965: Drop uniform buffer alignment back to 16 on Gen6.

2017-08-08 Thread Kenneth Graunke
We don't push UBOs on Gen6 currently, so there's no need for the larger alignment value. Cc: "17.2" --- src/mesa/drivers/dri/i965/brw_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_context.c

Re: [Mesa-dev] [PATCH 3/3] i965: Don't use ggtt_bo for Gen8+ streamout offset buffer.

2017-08-08 Thread Chris Wilson
Quoting Kenneth Graunke (2017-08-07 22:50:42) > RELOC_NEEDS_GGTT is only meaningful on Sandybridge - it's skipped on > other generations - so this has no purpose. Just use rw_bo(). Furthermore the w/a is for a pipecontrol, so we should be able to trim it down further. Though it shouldn't make

Re: [Mesa-dev] [PATCH] egl/dri2: refactor dri2_query_surface, swrastGetDrawableInfo

2017-08-08 Thread Eric Engestrom
On Tuesday, 2017-08-08 11:31:36 +0300, Tapani Pälli wrote: > Currently swrastGetDrawableInfo always initializes w and h, patch > refactors function as x11_get_drawable_info that returns success and > sets the values only if no error happened. Add swrastGetDrawableInfo > wrapper function as

Re: [Mesa-dev] [PATCH 4/8] egl: rework input validation order in _eglCreateWindowSurfaceCommon

2017-08-08 Thread Tapani Pälli
On 08/05/2017 02:25 AM, Emil Velikov wrote: From: Emil Velikov As mentioned in previous commit the negative tests in dEQP expect the arguments to be evaluated in particular order. Namely - first the dpy, then the config, followed by the surface/window. Move the

[Mesa-dev] [PATCH 1/2] glx/dri: Attempt to fix GLX_OML_swap_method

2017-08-08 Thread Thomas Hellstrom
The current implementation was suffering from the following problems: 1) The driGetConfigAttribIndex function was not returning any value for the driconfig swapMethod. 2) The X server GLX code is using the value obtained from the AIGLX dri driver driGetConfigAttribIndex to populate its GLX

Re: [Mesa-dev] [PATCH] egl/dri2: Allow modifiers to add FDs to imports

2017-08-08 Thread Philipp Zabel
On Tue, 2017-08-08 at 07:29 +0300, Tapani Pälli wrote: > > On 08/07/2017 03:05 PM, Philipp Zabel wrote: > > On Mon, 2017-07-31 at 18:35 +0100, Daniel Stone wrote: > >> When using dmabuf import, make sure that the modifier is actually > >> allowed to add planes to the base format, as implied by

[Mesa-dev] [PATCH] egl/dri2: refactor dri2_query_surface, swrastGetDrawableInfo

2017-08-08 Thread Tapani Pälli
Currently swrastGetDrawableInfo always initializes w and h, patch refactors function as x11_get_drawable_info that returns success and sets the values only if no error happened. Add swrastGetDrawableInfo wrapper function as expected by DRI extension. Signed-off-by: Tapani Pälli

Re: [Mesa-dev] [PATCH] egl: do not initialize w, h in dri2_query_surface

2017-08-08 Thread Tapani Pälli
On 08/07/2017 04:33 PM, Emil Velikov wrote: On 7 August 2017 at 12:59, Tapani Pälli wrote: They always get initialized to zero by swrastGetDrawableInfo. Valid X11 Drawable minimum size is 1x1, so we can detect success/change by checking against 0. Signed-off-by:

Re: [Mesa-dev] [PATCH] egl/dri2: Allow modifiers to add FDs to imports

2017-08-08 Thread Tapani Pälli
On 08/08/2017 10:37 AM, Philipp Zabel wrote: On Tue, 2017-08-08 at 07:29 +0300, Tapani Pälli wrote: On 08/07/2017 03:05 PM, Philipp Zabel wrote: On Mon, 2017-07-31 at 18:35 +0100, Daniel Stone wrote: When using dmabuf import, make sure that the modifier is actually allowed to add planes to

Re: [Mesa-dev] [PATCH 2/2] st/mesa: fix CTS regression caused by fcbb93e86024

2017-08-08 Thread Samuel Pitoiset
On 08/08/2017 07:34 AM, Timothy Arceri wrote: On 01/08/17 19:37, Timothy Arceri wrote: On 01/08/17 18:07, Samuel Pitoiset wrote: Don't you think it's just safer to revert the bad commit for 17.2 and fix it later on? I'm not overly worried. If you really want to go that way we can, but I

Re: [Mesa-dev] Mesa support GLES 3.1 status with compute shaders

2017-08-08 Thread Yuan, Feng
> On 08/08/2017 08:23 AM, Yuan, Feng wrote: > > Hi, > > > >> On Mon, Aug 7, 2017 at 9:45 AM, Emil Velikov > >> wrote: > >>> On 7 August 2017 at 12:56, Tapani Pälli wrote: > Hi; > > On 08/07/2017 02:15 PM, Yuan, Feng wrote: >

Re: [Mesa-dev] [PATCH 15/15] ac/nir: fix saturate emission

2017-08-08 Thread Bas Nieuwenhuizen
This patch is Reviewed-by: Bas Nieuwenhuizen On Tue, Aug 8, 2017 at 3:45 AM, Connor Abbott wrote: > From: Connor Abbott > > The .f32 was already getting added by emit_intrin_2f_param(). Noticed > when enabling LLVM

[Mesa-dev] [PATCH] configure: Trust LLVM >= 4.0 llvm-config --libs for shared libraries

2017-08-08 Thread Michel Dänzer
From: Michel Dänzer No need to manually look for the library files anymore with current LLVM. This sidesteps the manual method failing when LLVM was built with -DLLVM_APPEND_VC_REV=ON. (This might already work with older versions of LLVM) Signed-off-by: Michel Dänzer

[Mesa-dev] [PATCH 2/2] dri3: Swapbuffer update

2017-08-08 Thread Thomas Hellstrom
Implement back-to-fake-front flips, Fix EGL_BUFFER_PRESERVED path. Implement dri3 support for GLX_SWAP_EXCHANGE_OML and GLX_SWAP_COPY_OML. The back-to-fake-front flips will save a full buffer copy in the case of a fake front being enabled and GLX_SWAP_UNDEFINED_OML. Support for

Re: [Mesa-dev] Mesa support GLES 3.1 status with compute shaders

2017-08-08 Thread Tapani Pälli
On 08/08/2017 08:23 AM, Yuan, Feng wrote: Hi, On Mon, Aug 7, 2017 at 9:45 AM, Emil Velikov wrote: On 7 August 2017 at 12:56, Tapani Pälli wrote: Hi; On 08/07/2017 02:15 PM, Yuan, Feng wrote: Hi, What’s the status of GLES 3.1

Re: [Mesa-dev] [PATCH] configure: Trust LLVM >= 4.0 llvm-config --libs for shared libraries

2017-08-08 Thread Michel Dänzer
On 09/08/17 03:24 AM, Emil Velikov wrote: > On 8 August 2017 at 08:23, Michel Dänzer wrote: >> From: Michel Dänzer >> >> No need to manually look for the library files anymore with current >> LLVM. This sidesteps the manual method failing when LLVM was

Re: [Mesa-dev] [PATCH 1/8] glsl: calculate number of operands in an expression once

2017-08-08 Thread Timothy Arceri
On 09/08/17 05:59, Thomas Helland wrote: I'm not quite sure if the increase in size of the base ir class versus the reduced overhead and added code is worth it? There is more code yes, but most of that is asserts and validation code. This should actually make the code more robust than it is

Re: [Mesa-dev] [PATCH 4/8] egl: rework input validation order in _eglCreateWindowSurfaceCommon

2017-08-08 Thread Tapani Pälli
On 08/08/2017 08:07 PM, Emil Velikov wrote: On 8 August 2017 at 16:10, Eric Engestrom wrote: On Saturday, 2017-08-05 00:25:49 +0100, Emil Velikov wrote: From: Emil Velikov As mentioned in previous commit the negative tests in dEQP

[Mesa-dev] [PATCH 1/8] glsl: calculate number of operands in an expression once

2017-08-08 Thread Timothy Arceri
Extra validation is added to ir_validate to make sure this is always updated to the correct numer of operands, as passes like lower_instructions modify the instructions directly rather then generating a new one. The reduction in time is so small that it is not really measurable. However callgrind

[Mesa-dev] [PATCH 6/8] glsl: stop cloning builtin fuctions _mesa_glsl_find_builtin_function()

2017-08-08 Thread Timothy Arceri
The cloning was introduced in f81ede469910d to fixed a problem with shaders including IR that was owned by builtins. However the approach of cloning the whole function each time we reference a builtin lead to a significant reduction in the GLSL IR compilers performance. The previous patch fixes

[Mesa-dev] [PATCH 2/8] glsl: tidy up get_num_operands()

2017-08-08 Thread Timothy Arceri
Also add a comment that this should only be used by the ir_reader interface for testing purposes. v2: - fix grammar in comment - use unreachable rather than assert Reviewed-by: Thomas Helland --- src/compiler/glsl/ir.cpp | 9 ++--- src/compiler/glsl/ir.h |

[Mesa-dev] v2 GLSL compile time improvements

2017-08-08 Thread Timothy Arceri
v2: Address various comments from Thomas. All minor but enough to warrant a resend. I've sent all but the last 2 already but they haven't received much feedback yet. This series reduces compile times of the Deus Ex shaders on my Ryzen 1800X from 2m27s -> 2m8s with a cold cache on radeonsi.

[Mesa-dev] [PATCH 3/8] glsl: stop copying struct and interface member names

2017-08-08 Thread Timothy Arceri
We are currently copying the name for each member dereference but we can just share a single instance of the string provided by the type. This change also stops us recalculating the field index repeatedly. --- src/compiler/glsl/ast_array_index.cpp | 14 -

[Mesa-dev] [PATCH 5/8] glsl: clone builtin function constants

2017-08-08 Thread Timothy Arceri
f81ede469910d fixed a problem with shaders including IR that was owned by builtins. However the approach of cloning the whole function each time we referenced it lead to a significant reduction in the GLSL IR compiler performance. Everything was already cloned when inlining the function, as far

[Mesa-dev] [PATCH 8/8] glsl: use ralloc_str_append() rather than ralloc_asprintf_rewrite_tail()

2017-08-08 Thread Timothy Arceri
The Deus Ex: Mankind Divided shaders go from spending ~20 seconds in the GLSL IR compilers front-end down to ~18.5 seconds on a Ryzen 1800X. Tested by compiling once with shader-db then deleting the index file from the shader cache and compiling again. v2: - fix rebasing issue in v1 ---

[Mesa-dev] [PATCH 7/8] util/ralloc: add ralloc_str_append() helper

2017-08-08 Thread Timothy Arceri
This function differs from ralloc_strcat() and ralloc_strncat() in that it does not do any strlen() calls which can become costly on large strings. --- src/util/ralloc.c | 19 +++ src/util/ralloc.h | 18 ++ 2 files changed, 37 insertions(+) diff --git

[Mesa-dev] [PATCH 4/8] glsl: remove unused field from ir_call

2017-08-08 Thread Timothy Arceri
Reviewed-by: Thomas Helland Tested-by: Dieter Nützel --- src/compiler/glsl/ir.h | 5 - 1 file changed, 5 deletions(-) diff --git a/src/compiler/glsl/ir.h b/src/compiler/glsl/ir.h index ce4ade9e80..170759abeb 100644 ---

[Mesa-dev] [Bug 102125] [softpipe] piglit arb_texture_view-targets regression

2017-08-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102125 Bug ID: 102125 Summary: [softpipe] piglit arb_texture_view-targets regression Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW

Re: [Mesa-dev] [PATCH 4/8] egl: rework input validation order in _eglCreateWindowSurfaceCommon

2017-08-08 Thread Tapani Pälli
On 08/08/2017 05:20 PM, Emil Velikov wrote: On 8 August 2017 at 08:21, Tapani Pälli wrote: On 08/05/2017 02:25 AM, Emil Velikov wrote: From: Emil Velikov As mentioned in previous commit the negative tests in dEQP expect the arguments to

[Mesa-dev] [PATCH v6] egl: Allow creation of per surface out fence

2017-08-08 Thread yogesh . marathe
From: Zhongmin Wu Add plumbing to allow creation of per display surface out fence. Currently enabled only on android, since the system expects a valid fd in ANativeWindow::{queue,cancel}Buffer. We pass a fd of -1 with which native applications such as flatland fail. The

Re: [Mesa-dev] [PATCH] i965: Drop uniform buffer alignment back to 16 on Gen6.

2017-08-08 Thread Kenneth Graunke
On Tuesday, August 8, 2017 12:26:41 AM PDT Kenneth Graunke wrote: > We don't push UBOs on Gen6 currently, so there's no need for the > larger alignment value. > > Cc: "17.2" > --- > src/mesa/drivers/dri/i965/brw_context.c | 2 +- > 1 file changed, 1

Re: [Mesa-dev] [PATCH 2/3] specs: Add EGL_MESA_device_software

2017-08-08 Thread Adam Jackson
On Tue, 2017-08-08 at 19:11 +0100, Emil Velikov wrote: > On 2 August 2017 at 21:24, Adam Jackson wrote: > > The device extension string is expected to contain the name of the > > extension defining what kind of device it is, so the caller can know > > what kinds of operations it

Re: [Mesa-dev] [PATCH 2/3] specs: Add EGL_MESA_device_software

2017-08-08 Thread Emil Velikov
On 2 August 2017 at 21:24, Adam Jackson wrote: > The device extension string is expected to contain the name of the > extension defining what kind of device it is, so the caller can know > what kinds of operations it can perform with it. So that string had > better be non-empty,

Re: [Mesa-dev] [PATCH] configure: Trust LLVM >= 4.0 llvm-config --libs for shared libraries

2017-08-08 Thread Emil Velikov
On 8 August 2017 at 08:23, Michel Dänzer wrote: > From: Michel Dänzer > > No need to manually look for the library files anymore with current > LLVM. This sidesteps the manual method failing when LLVM was built with > -DLLVM_APPEND_VC_REV=ON. > IIRC

Re: [Mesa-dev] [PATCH 8/8] egl/drm: rename dri2_drm_create_surface()

2017-08-08 Thread Eric Engestrom
On Saturday, 2017-08-05 02:30:51 +0100, Emil Velikov wrote: > On 5 August 2017 at 00:25, Emil Velikov wrote: > > From: Emil Velikov > > > > The function can handle only window surfaces, so let's rename it > > accordingly, killing the wrapper

[Mesa-dev] [PATCH v3 6/6] radeonsi: try to re-use previously deleted bindless descriptor slots

2017-08-08 Thread Samuel Pitoiset
Currently, when the array is full it is resized but it can grow over and over because we don't try to re-use descriptor slots. v3: - use new idalloc gallium module Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_descriptors.c | 57

Re: [Mesa-dev] [PATCH 3/3] specs: Add EGL_MESA_platform_device

2017-08-08 Thread Adam Jackson
On Mon, 2017-08-07 at 09:24 +0100, Daniel Stone wrote: > On 2 August 2017 at 21:24, Adam Jackson wrote: > > +Overview > > + > > +A system may support multiple devices and multiple window systems. For > > +example, a Wayland environment may drive multiple GPUs and support

Re: [Mesa-dev] [PATCH] configure: Trust LLVM >= 4.0 llvm-config --libs for shared libraries

2017-08-08 Thread Marek Olšák
Acked-by: Marek Olšák Marek On Tue, Aug 8, 2017 at 9:23 AM, Michel Dänzer wrote: > From: Michel Dänzer > > No need to manually look for the library files anymore with current > LLVM. This sidesteps the manual method failing when

Re: [Mesa-dev] [PATCH] egl/dri2: refactor dri2_query_surface, swrastGetDrawableInfo

2017-08-08 Thread Emil Velikov
On 8 August 2017 at 10:00, Eric Engestrom wrote: > On Tuesday, 2017-08-08 11:31:36 +0300, Tapani Pälli wrote: >> Currently swrastGetDrawableInfo always initializes w and h, patch >> refactors function as x11_get_drawable_info that returns success and >> sets the values

[Mesa-dev] [Bug 102030] private memory overflow in openCL

2017-08-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102030 --- Comment #3 from Janpieter Sollie --- confirmed on -RC3 (initial report on RC2) -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

Re: [Mesa-dev] [PATCH 2/2] st/mesa: fix CTS regression caused by fcbb93e86024

2017-08-08 Thread Emil Velikov
On 8 August 2017 at 10:21, Samuel Pitoiset wrote: > > > On 08/08/2017 07:34 AM, Timothy Arceri wrote: >> >> On 01/08/17 19:37, Timothy Arceri wrote: >>> >>> On 01/08/17 18:07, Samuel Pitoiset wrote: Don't you think it's just safer to revert the bad commit for

Re: [Mesa-dev] [PATCH] configure.ac: Check for expat21 if expat is not found.

2017-08-08 Thread Emil Velikov
On 7 August 2017 at 19:13, Vinson Lee wrote: > On Mon, Aug 7, 2017 at 8:18 AM, Emil Velikov wrote: >> On 5 August 2017 at 21:53, Vinson Lee wrote: >>> Fixes build error on CentOS 6.9. >>> >>> Bugzilla:

Re: [Mesa-dev] [PATCH] Revert "mesa: stop assigning unused storage for non-bindless opaque types"

2017-08-08 Thread Samuel Pitoiset
On 07/31/2017 10:59 PM, Samuel Pitoiset wrote: This reverts commit fcbb93e860246375d03f280f927f79d3645a8988 and also commit 7c5b204e38d8cae70f5bf26e7223da5bc448bb5c to avoid compilation errors. Basically, the parameter indexes look wrong when a non-bindless sampler is declared inside a

Re: [Mesa-dev] [PATCH v5 06/12] etnaviv: use common pipe_screen ref counting

2017-08-08 Thread Wladimir
On Tue, Aug 8, 2017 at 12:58 AM, Rob Herring wrote: > Use the common pipe_screen ref counting and fd hashing functions. > The mutex can be dropped as the pipe loader serializes the > create_screen() and destroy() calls. > > Signed-off-by: Rob Herring > Cc:

Re: [Mesa-dev] [PATCH] egl/dri2: refactor dri2_query_surface, swrastGetDrawableInfo

2017-08-08 Thread Tapani Pälli
On 08/08/2017 12:00 PM, Eric Engestrom wrote: On Tuesday, 2017-08-08 11:31:36 +0300, Tapani Pälli wrote: Currently swrastGetDrawableInfo always initializes w and h, patch refactors function as x11_get_drawable_info that returns success and sets the values only if no error happened. Add

[Mesa-dev] [Bug 102077] multilib mesa fail to build with "egl/drivers/dri2/platform_drm.c:542: undefined reference to `gbm_bo_get_bpp'"

2017-08-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102077 Laurent carlier changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH 4/8] egl: rework input validation order in _eglCreateWindowSurfaceCommon

2017-08-08 Thread Emil Velikov
On 8 August 2017 at 08:21, Tapani Pälli wrote: > > > On 08/05/2017 02:25 AM, Emil Velikov wrote: >> >> From: Emil Velikov >> >> As mentioned in previous commit the negative tests in dEQP expect the >> arguments to be evaluated in particular

[Mesa-dev] [PATCH] st/dri2: fix kms_swrast driconf option handling

2017-08-08 Thread Rob Herring
Commit e794f8bf8bdb ("gallium: move loading of drirc to pipe-loader") moved the option cache to the pipe_loader_device. However, the screen->dev pointer is not set when dri_init_options() is called. Move the call to after the pipe_loader_sw_probe_kms() call so screen->dev is set. This mirrors the

Re: [Mesa-dev] [PATCH] st/dri2: fix kms_swrast driconf option handling

2017-08-08 Thread Ilia Mirkin
On Tue, Aug 8, 2017 at 12:50 PM, Rob Herring wrote: > Commit e794f8bf8bdb ("gallium: move loading of drirc to pipe-loader") > moved the option cache to the pipe_loader_device. However, the > screen->dev pointer is not set when dri_init_options() is called. Move > the call to

Re: [Mesa-dev] [PATCH 2/3] mesa: Implement GL_ARB_texture_filter_anisotropic

2017-08-08 Thread Marek Olšák
On Tue, Aug 8, 2017 at 6:01 PM, Ilia Mirkin wrote: > On Tue, Aug 8, 2017 at 11:52 AM, Adam Jackson wrote: >> The only difference from the EXT version is bumping the minmax to 16, so >> just hit all the drivers at once. >> >> Signed-off-by: Adam Jackson

[Mesa-dev] [PATCH v3 3/6] radeonsi: only initialize dirty_mask when CE is used

2017-08-08 Thread Samuel Pitoiset
Looks like it's useless to initialize that field when CE is unused. This will also allow to declare more than 64 elements for the array of bindless descriptors. Signed-off-by: Samuel Pitoiset Reviewed-by: Marek Olšák ---

[Mesa-dev] [PATCH v3 2/6] radeonsi: make some si_descriptors fields 32-bit

2017-08-08 Thread Samuel Pitoiset
The number of bindless descriptors is dynamic and we definitely have to support more than 256 slots. Signed-off-by: Samuel Pitoiset Reviewed-by: Marek Olšák --- src/gallium/drivers/radeonsi/si_state.h | 10 +- 1 file changed, 5

[Mesa-dev] [PATCH v3 5/6] radeonsi: use slot indexes for bindless handles

2017-08-08 Thread Samuel Pitoiset
Using VRAM address as bindless handles is not a good idea because we have to use LLVMIntToPTr and the LLVM CSE pass can't optimize because it has no information about the pointer. Instead, use slots indexes like the existing descriptors. Note that we use fixed 16-dword slots for both samplers and

[Mesa-dev] [PATCH v3 4/6] radeonsi: add si_emit_global_shader_pointers() helper

2017-08-08 Thread Samuel Pitoiset
To share common code between rw buffers and bindless descriptors. v3: - rename to si_emit_global_shader_pointers() Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_descriptors.c | 57 +++ 1 file changed, 31 insertions(+), 26

[Mesa-dev] [PATCH] gallium/util: add new module that allocate "numbers"

2017-08-08 Thread Samuel Pitoiset
Will be used for allocating bindless descriptor slots for RadeonSI. Signed-off-by: Samuel Pitoiset --- src/gallium/auxiliary/Makefile.sources | 1 + src/gallium/auxiliary/util/u_idalloc.h | 103 + 2 files changed, 104 insertions(+)

[Mesa-dev] [PATCH v3 1/6] radeonsi: declare new user SGPR indices for bindless samplers/images

2017-08-08 Thread Samuel Pitoiset
A new pair of user SGPR is needed for loading the bindless descriptors from shaders. Because the descriptors are global for all stages, there is no need to add separate indices for GFX9. v3: - fix merged shaders on GFX9 v2: - fix declaring new bindless parameter Signed-off-by: Samuel Pitoiset

Re: [Mesa-dev] [PATCH 7/8] egl/drm: remove unreachable code in dri2_drm_create_surface()

2017-08-08 Thread Emil Velikov
On 8 August 2017 at 17:34, Eric Engestrom wrote: > On Saturday, 2017-08-05 00:25:52 +0100, Emil Velikov wrote: >> From: Emil Velikov >> >> The function can be called only when the type is EGL_WINDOW_BIT. >> Remove the unneeded switch

Re: [Mesa-dev] [PATCH 4/8] egl: rework input validation order in _eglCreateWindowSurfaceCommon

2017-08-08 Thread Emil Velikov
On 8 August 2017 at 16:10, Eric Engestrom wrote: > On Saturday, 2017-08-05 00:25:49 +0100, Emil Velikov wrote: >> From: Emil Velikov >> >> As mentioned in previous commit the negative tests in dEQP expect the >> arguments to be evaluated in

Re: [Mesa-dev] [PATCH] st/dri2: fix kms_swrast driconf option handling

2017-08-08 Thread Rob Herring
On Tue, Aug 8, 2017 at 11:56 AM, Ilia Mirkin wrote: > On Tue, Aug 8, 2017 at 12:50 PM, Rob Herring wrote: >> Commit e794f8bf8bdb ("gallium: move loading of drirc to pipe-loader") >> moved the option cache to the pipe_loader_device. However, the >>

Re: [Mesa-dev] [PATCH] radeonsi: drop two unused variables in create_function()

2017-08-08 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Aug 7, 2017 at 12:41 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/radeonsi/si_shader.c | 2 -- > 1 file changed, 2 deletions(-) > >

Re: [Mesa-dev] [PATCH 7/8] egl/drm: remove unreachable code in dri2_drm_create_surface()

2017-08-08 Thread Eric Engestrom
On Saturday, 2017-08-05 00:25:52 +0100, Emil Velikov wrote: > From: Emil Velikov > > The function can be called only when the type is EGL_WINDOW_BIT. > Remove the unneeded switch statement. > > Signed-off-by: Emil Velikov > --- >

Re: [Mesa-dev] [PATCH 00/15] radv: Support for VK_AMD_shader_ballot

2017-08-08 Thread Connor Abbott
On Mon, Aug 7, 2017 at 6:32 PM, Connor Abbott wrote: > From: Connor Abbott > > This series implements VK_AMD_shader_ballot for radv. This extension > builds on VK_EXT_shader_subgroup_ballot and VK_EXT_shader_subgroup_vote > by adding a number of

Re: [Mesa-dev] [PATCH 2/8] glsl: tidy up get_num_operands()

2017-08-08 Thread Thomas Helland
2017-08-07 2:18 GMT+00:00 Timothy Arceri : > Also add a comment that this should only be used by the ir_reader > interface for testing purposes. > --- > src/compiler/glsl/ir.cpp | 8 ++-- > src/compiler/glsl/ir.h | 14 +++--- > 2 files changed, 9

Re: [Mesa-dev] [PATCH 1/2] Update TextureParameter* error for incompatible texture targets

2017-08-08 Thread Jordan Justen
On 2017-08-06 21:18:23, Iago Toral Quiroga wrote: > The OpenGL 4.6 specs have been updated so that GetTextureParameter* > with a texture object with an incompatible TEXTURE_TARGET should now > report INVALID_OPERATION instead of INVALID_ENUM. > > Fixes: >

Re: [Mesa-dev] [PATCH 1/8] glsl: calculate number of operands in an expression once

2017-08-08 Thread Thomas Helland
I'm not quite sure if the increase in size of the base ir class versus the reduced overhead and added code is worth it? Some numbers would be nice. A comment below 2017-08-07 2:18 GMT+00:00 Timothy Arceri : > Extra validation is added to ir_validate to make sure this is >

Re: [Mesa-dev] [PATCH v2 0/2] glsl: interpolateAt*() fixes

2017-08-08 Thread Nicolai Hähnle
Ping On 01.08.2017 12:49, Nicolai Hähnle wrote: Hi all, I sent a v1 of this around ~6 weeks ago. Since then, I brought some related issues up with the OpenGL WG, and we now have a rule clarification in GLSL 4.60 (which is intended to apply to earlier versions as well). This updated series

Re: [Mesa-dev] [PATCH 8/8] glsl: use ralloc_str_append() rather than ralloc_asprintf_rewrite_tail()

2017-08-08 Thread Thomas Helland
2017-08-07 2:18 GMT+00:00 Timothy Arceri : > The Deus Ex: Mankind Divided shaders go from spending ~20 seconds > in the GLSL IR compilers front-end down to ~18.5 seconds on a > Ryzen 1800X. > > Tested by compiling once with shader-db then deleting the index file > from the

Re: [Mesa-dev] [PATCH] mesa/main: Advertise ARB_texture_filter_anisotropic

2017-08-08 Thread Ilia Mirkin
On Tue, Aug 8, 2017 at 11:34 AM, Roland Scheidegger wrote: > Am 08.08.2017 um 17:21 schrieb Ilia Mirkin: >> On Tue, Aug 8, 2017 at 11:16 AM, Adam Jackson wrote: >>> On Wed, 2017-06-28 at 16:50 +0300, Plamena Manolova wrote: ARB_texture_filter_anisotropic

Re: [Mesa-dev] [PATCH] mesa/main: Advertise ARB_texture_filter_anisotropic

2017-08-08 Thread Roland Scheidegger
Am 08.08.2017 um 17:21 schrieb Ilia Mirkin: > On Tue, Aug 8, 2017 at 11:16 AM, Adam Jackson wrote: >> On Wed, 2017-06-28 at 16:50 +0300, Plamena Manolova wrote: >>> ARB_texture_filter_anisotropic is the ARB variation of >>> EXT_texture_fitter_anisotropic and it operates in the

Re: [Mesa-dev] [PATCH] mesa/main: Advertise ARB_texture_filter_anisotropic

2017-08-08 Thread Roland Scheidegger
Am 08.08.2017 um 17:45 schrieb Ilia Mirkin: > On Tue, Aug 8, 2017 at 11:34 AM, Roland Scheidegger > wrote: >> Am 08.08.2017 um 17:21 schrieb Ilia Mirkin: >>> On Tue, Aug 8, 2017 at 11:16 AM, Adam Jackson wrote: On Wed, 2017-06-28 at 16:50 +0300, Plamena

[Mesa-dev] [PATCH 0/3] Implement more 4.6 extensions

2017-08-08 Thread Adam Jackson
I hadn't seen Plamena's patches for these before writing them, and I think I got right most of the issues that were caught in review (namely: 16x minmax for aniso, updated headers and xml for new dispatch for polygon offset clamp), so in the interest of saving time... - ajax

[Mesa-dev] [PATCH 1/3] include: Sync Khronos headers for OpenGL 4.6

2017-08-08 Thread Adam Jackson
Taken from c21e602b9fda1d3bbaecb08194592f67e6a0649b from OpenGL-Registry. Signed-off-by: Adam Jackson --- include/GL/glcorearb.h | 66 ++- include/GL/glext.h | 82 +++-- include/GL/glxext.h| 2 +- include/GL/wglext.h

[Mesa-dev] [PATCH 3/3] mesa: Implement GL_ARB_polygon_offset_clamp

2017-08-08 Thread Adam Jackson
Identical to the EXT version. Signed-off-by: Adam Jackson --- docs/features.txt| 2 +- src/mapi/glapi/gen/GL4x.xml | 9 + src/mesa/drivers/dri/i965/intel_extensions.c | 1 + src/mesa/main/dlist.c|

[Mesa-dev] [PATCH 2/3] mesa: Implement GL_ARB_texture_filter_anisotropic

2017-08-08 Thread Adam Jackson
The only difference from the EXT version is bumping the minmax to 16, so just hit all the drivers at once. Signed-off-by: Adam Jackson --- docs/features.txt| 4 +++- src/glx/glxextensions.c | 1 + src/glx/glxextensions.h

Re: [Mesa-dev] [PATCH 3/8] egl: handle BAD_NATIVE_PIXMAP further up the stack

2017-08-08 Thread Eric Engestrom
On Saturday, 2017-08-05 00:25:48 +0100, Emil Velikov wrote: > From: Emil Velikov > > The basic (null) check is identical across all backends. > Just move it to the top. > > v2: > - Split the WINDOW vs PIXMAP into separate patches > - Move check after the dpy and

[Mesa-dev] [PATCH] egl: avoid eglCreatePlatform*Surface{EXT, } crash with invalid dpy

2017-08-08 Thread Emil Velikov
From: Emil Velikov If we have an invalid display fed into the functions, the display lookup will return NULL. Thus as we attempt to get the platform type, we'll deref. it leading to a crash. Keep in mind that this will not happen if Mesa is built without X11 or when

[Mesa-dev] [Bug 102067] Is it possible select a driver/implementation in an application? (like in OpenCL)

2017-08-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102067 Emil Velikov changed: What|Removed |Added Resolution|--- |FIXED

Re: [Mesa-dev] [PATCH 4/8] egl: rework input validation order in _eglCreateWindowSurfaceCommon

2017-08-08 Thread Eric Engestrom
On Saturday, 2017-08-05 00:25:49 +0100, Emil Velikov wrote: > From: Emil Velikov > > As mentioned in previous commit the negative tests in dEQP expect the > arguments to be evaluated in particular order. The spec doesn't say that, so the test is wrong. Changing it in

Re: [Mesa-dev] [PATCH 2/8] egl: drop unreachable BAD_NATIVE_WINDOW conditions

2017-08-08 Thread Eric Engestrom
On Tuesday, 2017-08-08 08:02:27 +0300, Tapani Pälli wrote: > > > On 08/05/2017 02:25 AM, Emil Velikov wrote: > > From: Emil Velikov > > > > The code in _eglCreatePixmapSurfaceCommon() already has a NULL check > > _eglCreateWindowSurfaceCommon() > > > which handles

Re: [Mesa-dev] [PATCH] mesa/main: Advertise ARB_texture_filter_anisotropic

2017-08-08 Thread Adam Jackson
On Wed, 2017-06-28 at 16:50 +0300, Plamena Manolova wrote: > ARB_texture_filter_anisotropic is the ARB variation of > EXT_texture_fitter_anisotropic and it operates in the > same way, so there's no reason not to advertise it. Nak. The ARB version bups the minmax anisotropy to 16x, see issue 2 in

  1   2   >