Re: [Mesa-dev] [PATCH] radeonsi/gfx9: add a temporary workaround for a tessellation driver bug

2017-08-18 Thread Marek Olšák
Ping. On Wed, Aug 16, 2017 at 12:57 AM, Marek Olšák wrote: > From: Marek Olšák > > The workaround will do for now. The root cause is still unknown. > > This fixes new piglit: 16in-1out > > Cc: 17.1 17.2 > --- >

[Mesa-dev] [Bug 102038] assertion failure in update_framebuffer_size

2017-08-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102038 --- Comment #6 from Roland Scheidegger --- (In reply to Bruce Cherniak from comment #5) > Looks like a problem in llvmpipe_is_format_supported. If should be > returning false for all "sample_count > 0", not 1. No, not

[Mesa-dev] [Bug 102038] assertion failure in update_framebuffer_size

2017-08-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102038 --- Comment #7 from Bruce Cherniak --- I understand that this isn't a solution, but it points to where things go wrong. I'll keep digging for the correct fix. -- You are receiving this mail because: You are the QA

[Mesa-dev] [Bug 102038] assertion failure in update_framebuffer_size

2017-08-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102038 --- Comment #5 from Bruce Cherniak --- Looks like a problem in llvmpipe_is_format_supported. If should be returning false for all "sample_count > 0", not 1. That works for me, at least. I'm running all VTK tests

Re: [Mesa-dev] [PATCH 2/9] loader_dri3/glx/egl: Optionally use a blit context for blitting operations

2017-08-18 Thread Thomas Hellstrom
On 08/18/2017 07:02 PM, Emil Velikov wrote: Hi Thomas, On 15 August 2017 at 19:31, Thomas Hellstrom wrote: +/** + * A cached blit context. + */ +struct loader_dri3_blit_context { + mtx_t mtx; + __DRIcontext *ctx; + __DRIscreen *cur_screen; + const

Re: [Mesa-dev] [PATCH 17/20] radeon/uvd: add YUYV format support for target buffer

2017-08-18 Thread Christian König
Am 18.08.2017 um 18:31 schrieb Leo Liu: YUYV is a packed YUV format, and there is no chorma plane At better description would be something like: "Make chroma plane optional for YUYV support." Signed-off-by: Leo Liu Anyway patch is Reviewed-by: Christian König

Re: [Mesa-dev] [PATCH] radeon/uvd: get the target buffer pitch correct for different format

2017-08-18 Thread Christian König
Am 18.08.2017 um 18:31 schrieb Leo Liu: Signed-off-by: Leo Liu Reviewed-by: Christian König --- src/gallium/drivers/radeon/radeon_uvd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 06/45] nir: Handle fp16 rounding modes at nir_type_conversion_op

2017-08-18 Thread Jason Ekstrand
On Fri, Aug 18, 2017 at 4:31 AM, Eduardo Lima Mitev wrote: > On 08/17/2017 09:08 PM, Jason Ekstrand wrote: > > On Thu, Jul 13, 2017 at 7:35 AM, Alejandro Piñeiro > > wrote: > > > > From: Jose Maria Casanova Crespo

[Mesa-dev] [PATCH] Android: Fix LLVM duplicated symbols linking for N and M

2017-08-18 Thread Rob Herring
Both statically linking libLLVMCore and dynamically linking libLLVM causes duplicated symbols in gallium_dri.so and it fails to dlopen. We don't really need to link libLLVMCore, but just need generated headers to be built first. Dynamically linking to libLLVM instead is enough to do that. Thanks

Re: [Mesa-dev] [PATCH 2/9] loader_dri3/glx/egl: Optionally use a blit context for blitting operations

2017-08-18 Thread Emil Velikov
On 18 August 2017 at 18:14, Thomas Hellstrom wrote: > On 08/18/2017 07:02 PM, Emil Velikov wrote: >> >> Hi Thomas, >> >> On 15 August 2017 at 19:31, Thomas Hellstrom >> wrote: >> >>> +/** >>> + * A cached blit context. >>> + */ >>> +struct

Re: [Mesa-dev] [PATCH 01/12] egl/x11/dri3: adding missing __DRI_BACKGROUND_CALLABLE extension

2017-08-18 Thread Emil Velikov
On 3 August 2017 at 19:29, Emil Velikov wrote: > From: Emil Velikov > > Fixes: 3b7b6adf3ac ("egl: Implement __DRI_BACKGROUND_CALLABLE") > Cc: Timothy Arceri > Signed-off-by: Emil Velikov >

Re: [Mesa-dev] [PATCH 2/9] loader_dri3/glx/egl: Optionally use a blit context for blitting operations

2017-08-18 Thread Emil Velikov
Hi Thomas, On 15 August 2017 at 19:31, Thomas Hellstrom wrote: > +/** > + * A cached blit context. > + */ > +struct loader_dri3_blit_context { > + mtx_t mtx; > + __DRIcontext *ctx; > + __DRIscreen *cur_screen; > + const __DRIcoreExtension *core; > +}; > + > +/*

[Mesa-dev] [PATCH 1/2] anv: Add error handling to setup_empty_execbuf().

2017-08-18 Thread Francisco Jerez
The anv_execbuf_add_bo() call can actually fail in practice, which should cause the QueueSubmit operation to fail. Reported by Coverity. CID: 1416606: Unchecked return value (CHECKED_RETURN) --- src/intel/vulkan/anv_batch_chain.c | 22 +- 1 file changed, 13 insertions(+), 9

[Mesa-dev] [PATCH 2/2] anv: Check that in_fence fd is valid before closing it.

2017-08-18 Thread Francisco Jerez
Probably harmless, but will overwrite errno with a failure status code. Reported by coverity. CID 1416600: Argument cannot be negative (NEGATIVE_RETURNS) --- src/intel/vulkan/anv_batch_chain.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 07/45] nir: Populate conversion opcodes to/from 16-bit types

2017-08-18 Thread Jason Ekstrand
On Fri, Aug 18, 2017 at 4:28 AM, Eduardo Lima Mitev wrote: > On 08/17/2017 08:48 PM, Jason Ekstrand wrote: > > On Thu, Jul 13, 2017 at 7:35 AM, Alejandro Piñeiro > > wrote: > > > > From: Eduardo Lima Mitev

[Mesa-dev] [PATCH] gallium: Weaken assertion about u_mm's align2 field.

2017-08-18 Thread Eric Anholt
vc5 MMU mappings are access-controlled at a 128kb boundary, so the 4kb here was too small for that purpose. Allowing any valid align2 value that u_mm's 32-bit addressing can represent will still catch most cases of people passing in a byte alignment. --- src/gallium/auxiliary/util/u_mm.c | 5

Re: [Mesa-dev] [PATCH 2/2] egl: Add dma_buf_import_modifiers for glvnd

2017-08-18 Thread Eric Anholt
Daniel Stone writes: > On 31 July 2017 at 15:15, Daniel Stone wrote: >> Make sure we advertise the new entrypoints to libglvnd's EGL dispatch. > > Anyone? Reviewed-by: Eric Anholt signature.asc Description: PGP signature

[Mesa-dev] [Bug 101941] Getting different output depending on attribute declaration order

2017-08-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101941 --- Comment #1 from Brian Paul --- Just for reference, I think this is related to bug 44217. -- You are receiving this mail because: You are the assignee for the bug.___ mesa-dev

[Mesa-dev] [PATCH v3 1/1] clover: Wait for requested operation if blocking flag is set

2017-08-18 Thread Jan Vesely
v2: wait in map_buffer and map_image as well v3: use event::wait instead of wait (skips fence wait for hard_event) Signed-off-by: Jan Vesely --- src/gallium/state_trackers/clover/api/transfer.cpp | 30 -- 1 file changed, 28 insertions(+), 2

Re: [Mesa-dev] [PATCH] i965: Mark all EGLimages as non-coherent.

2017-08-18 Thread Chris Wilson
Quoting Kenneth Graunke (2017-08-16 20:30:21) > EGLimages are shared with external users, and we don't know what they're > going to do with them. They might scan them out. They might access > them in a way that doesn't work with our explicit clflushing. > > It's safest to simply mark them

Re: [Mesa-dev] [PATCH v3 1/1] clover: Wait for requested operation if blocking flag is set

2017-08-18 Thread Jan Vesely
On Fri, 2017-08-18 at 14:19 -0700, Francisco Jerez wrote: > Jan Vesely writes: > > > v2: wait in map_buffer and map_image as well > > v3: use event::wait instead of wait (skips fence wait for hard_event) > > > > Unfortunately this won't wait for the event action to be

[Mesa-dev] [PATCH] i965: Stop looking at NewDriverState when emitting 3DSTATE_URB

2017-08-18 Thread Jason Ekstrand
Looking at NewDriverState is not safe in general. The state atom system is set up to ensure that new bits that get added to NewDriverState get accumulated into the set of bits used when emitting atoms but it doesn't go the other way. If we read NewDriverState, we may not get the full picture

Re: [Mesa-dev] [PATCH 2/2] egl: Add dma_buf_import_modifiers for glvnd

2017-08-18 Thread Emil Velikov
On 11 August 2017 at 11:18, Daniel Stone wrote: > On 31 July 2017 at 15:15, Daniel Stone wrote: >> Make sure we advertise the new entrypoints to libglvnd's EGL dispatch. > > Anyone? > I might be too tired but I think things should work fine even

Re: [Mesa-dev] [Mesa-stable] [PATCH] radeonsi: update non-resident bindless descriptors if needed

2017-08-18 Thread Marek Olšák
On Sat, Aug 19, 2017 at 1:49 AM, Emil Velikov wrote: > Hi Samuel, > > On 9 August 2017 at 14:47, Samuel Pitoiset wrote: >> Only resident bindless descriptors are currently updated and >> re-uploaded, this makes sure that the non-resident ones

Re: [Mesa-dev] [PATCH v3 1/1] clover: Wait for requested operation if blocking flag is set

2017-08-18 Thread Francisco Jerez
Jan Vesely writes: > On Fri, 2017-08-18 at 14:19 -0700, Francisco Jerez wrote: >> Jan Vesely writes: >> >> > v2: wait in map_buffer and map_image as well >> > v3: use event::wait instead of wait (skips fence wait for hard_event) >> > >> >>

[Mesa-dev] [PATCH 0/6] vc5 driver to merge

2017-08-18 Thread Eric Anholt
I'm feeling good enough about the core of the vc5 driver that I'd like to merge it at this point. I'm passing about 2/3 of tests in simulation with GLES3.0 exposed. The current top piglit problems: * polygonmode is still not a thing the hardware can do. * MSAA isn't done. * stencil blits aren't

[Mesa-dev] [PATCH 3/6] broadcom: Add V3D 3.3 QPU instruction pack, unpack, and disasm.

2017-08-18 Thread Eric Anholt
Unlike VC4, I've defined an unpacked instruction format with pack/unpack functions to convert to 64-bit encoded instructions. This will let us incrementally put together our instructions and validate them in a more natural way than the QPU_GET_FIELD/QPU_SET_FIELD used to. The pack/unpack

[Mesa-dev] [PATCH 1/6] nir: Move vc4's alpha test lowering to core NIR.

2017-08-18 Thread Eric Anholt
I've been doing this inside of vc4, but vc5 wants it as well and it may be useful for other drivers (Intel has a related path for pre-gen6 with MRT, and freedreno had a TGSI path for it at one point). This required defining a common enum for the standard comparison functions, but other lowering

[Mesa-dev] [PATCH 4/6] broadcom: Add vc5 CLIF dumping

2017-08-18 Thread Eric Anholt
This will be usable with "VC5_DEBUG=cl" on the vc5 driver to stream a CLIF file (the Broadcom equivalent of i965's AUB) to stderr. I haven't tested that this is actually usable with the internal CLIF-consuming tools, but is close enough as a baseline and is useful for visually inspecting the

[Mesa-dev] [PATCH 5/6] broadcom: Add VC5 NIR compiler.

2017-08-18 Thread Eric Anholt
This is a pretty straightforward fork of VC4's NIR compiler to VC5. The condition codes, registers, and I/O have all changed, making the backend hard to share, though their heritage is still recognizable. --- Contents trimmed due to patch size. Full series at:

[Mesa-dev] [PATCH 6/6] broadcom: Add V3D 3.3 gallium driver called "vc5", for BCM7268.

2017-08-18 Thread Eric Anholt
V3D 3.3 is a continuation of the 3D implementation in VC4 (v2.1 and v2.6). V3D 3.3 introduces an MMU (no more CMA allocations) and support for GLES3.1. This driver is not currently conformant, though that will be a target as soon as possible. V3D 3.x parts use a new texture tiling layout common

[Mesa-dev] [PATCH 2/6] configure: Add the new "vc5" driver to the list, requiring a simulator.

2017-08-18 Thread Eric Anholt
My intent is to develop the vc5 driver in-tree for some time to build the CL generation and shader compiler code, and keep out-of-tree patches for talking to an actual kernel driver until the kernel driver can be stabilized on the hardware. --- configure.ac | 12 +++- 1 file changed, 11

Re: [Mesa-dev] [Mesa-stable] [PATCH] radeonsi: update non-resident bindless descriptors if needed

2017-08-18 Thread Emil Velikov
Hi Samuel, On 9 August 2017 at 14:47, Samuel Pitoiset wrote: > Only resident bindless descriptors are currently updated and > re-uploaded, this makes sure that the non-resident ones are > also updated. > > Signed-off-by: Samuel Pitoiset >

Re: [Mesa-dev] mistake in "mesa/vbo: move some Draw checks out of validation"?

2017-08-18 Thread Timothy Arceri
On 19/08/17 08:02, Brian Paul wrote: Hi Timothy, I happened to be looking at the VBO vertex array code and I think I spotted a mistake in this commit: commit 4df2931a87fe082f90871564a89a09c826641f5b Author: Timothy Arceri Date: Mon Apr 3 16:38:18 2017 +1000

Re: [Mesa-dev] [PATCH] i965: Stop looking at NewDriverState when emitting 3DSTATE_URB

2017-08-18 Thread Kenneth Graunke
On Friday, August 18, 2017 4:21:39 PM PDT Jason Ekstrand wrote: > Looking at NewDriverState is not safe in general. The state atom system > is set up to ensure that new bits that get added to NewDriverState get > accumulated into the set of bits used when emitting atoms but it doesn't > go the

Re: [Mesa-dev] [PATCH] i965/miptree: Set supports_fast_clear = false in make_shareable

2017-08-18 Thread Emil Velikov
On 14 August 2017 at 19:42, Jason Ekstrand wrote: > I missed the stable CC when I pushed this one. It needs to be in 17.2 > Ack, queued up. Thanks Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH] Android: Fix LLVM duplicated symbols linking for N and M

2017-08-18 Thread Yu, Qiang
> gallium_dri_la_LDFLAGS += \ > -Wl,--version-script=$(top_srcdir)/src/gallium/targets/dri/dri.sym A nice trick to know about. Regards, Qiang ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 3/3] gallium/radeon: pass LLVM processor to the disk shader cache

2017-08-18 Thread Timothy Arceri
On 18/08/17 20:49, Nicolai Hähnle wrote: On 11.08.2017 20:37, Marek Olšák wrote: On Fri, Aug 11, 2017 at 6:00 PM, Nicolai Hähnle wrote: On 10.08.2017 21:57, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.c |

Re: [Mesa-dev] [PATCH v3 1/1] clover: Wait for requested operation if blocking flag is set

2017-08-18 Thread Francisco Jerez
Jan Vesely writes: > v2: wait in map_buffer and map_image as well > v3: use event::wait instead of wait (skips fence wait for hard_event) > Unfortunately this won't wait for the event action to be executed, only for all dependencies of the event to become signalled, so

[Mesa-dev] mistake in "mesa/vbo: move some Draw checks out of validation"?

2017-08-18 Thread Brian Paul
Hi Timothy, I happened to be looking at the VBO vertex array code and I think I spotted a mistake in this commit: commit 4df2931a87fe082f90871564a89a09c826641f5b Author: Timothy Arceri Date: Mon Apr 3 16:38:18 2017 +1000 mesa/vbo: move some Draw checks out of

Re: [Mesa-dev] [PATCH] Android: Fix LLVM duplicated symbols linking for N and M

2017-08-18 Thread Emil Velikov
On 18 August 2017 at 20:46, Rob Herring wrote: > Both statically linking libLLVMCore and dynamically linking libLLVM causes > duplicated symbols in gallium_dri.so and it fails to dlopen. We don't > really need to link libLLVMCore, but just need generated headers to be > built

Re: [Mesa-dev] XDC 2017 : Call for paper

2017-08-18 Thread Stéphane Marchesin
On Tue, Jun 6, 2017 at 4:19 PM, Martin Peres wrote: > Hello, > > I have the pleasure to announce that the X.org Developer Conference 2017 > will be held in Mountain View, California from September 20th to > September 22nd. The venue is located at the Googleplex. > > The

Re: [Mesa-dev] [PATCH] Android: Fix LLVM duplicated symbols linking for N and M

2017-08-18 Thread Chih-Wei Huang
2017-08-19 8:27 GMT+08:00 Emil Velikov : > On 18 August 2017 at 20:46, Rob Herring wrote: >> Both statically linking libLLVMCore and dynamically linking libLLVM causes >> duplicated symbols in gallium_dri.so and it fails to dlopen. We don't >> really

Re: [Mesa-dev] [PATCH 1/3] isl: Add a null surface fill function.

2017-08-18 Thread Kenneth Graunke
On Thursday, August 17, 2017 10:26:44 PM PDT Jason Ekstrand wrote: > On August 17, 2017 4:36:42 PM Kenneth Graunke wrote: > > > ISL already offers functions to fill out most kinds of SURFACE_STATE, > > so why not handle null surfaces too? > > > > Null surfaces are simple,

Re: [Mesa-dev] [PATCH 2/3] i965: Use ISL for emitting null surface states.

2017-08-18 Thread Jason Ekstrand
On Thu, Aug 17, 2017 at 4:36 PM, Kenneth Graunke wrote: > We handle the Sandybridge multisampled 2D surface hack here, rather > than in ISL, because it requires allocating a BO, and is kind of messy. > --- > src/mesa/drivers/dri/i965/Makefile.sources| 2 - >

Re: [Mesa-dev] [PATCH 1/3] isl: Add a null surface fill function.

2017-08-18 Thread Jason Ekstrand
On Fri, Aug 18, 2017 at 9:46 PM, Kenneth Graunke wrote: > On Thursday, August 17, 2017 10:26:44 PM PDT Jason Ekstrand wrote: > > On August 17, 2017 4:36:42 PM Kenneth Graunke > wrote: > > > > > ISL already offers functions to fill out most kinds of

[Mesa-dev] [PATCH V2 2/2] mesa: Modify drirc option types

2017-08-18 Thread QuRyu
From: Quentin Liu The type and default values of certain drirc options are changed, namely, those semantically boolean options such as pp_celshade. --- src/gallium/auxiliary/pipe-loader/driinfo_gallium.h | 8 src/util/xmlpool/t_options.h

[Mesa-dev] [PATCH V2 1/2] mesa: Fix backward compatibility for XML parser

2017-08-18 Thread QuRyu
From: Quentin Liu If the type of drirc options are changed, the parser will not be able to recognize xml files that had been present before the change. To achieve backward compatibility, the parser is relaxed to recognize boolean type options with enum values. ---

[Mesa-dev] [PATCH V2 0/2] mesa: Modify drirc options

2017-08-18 Thread QuRyu
From: Quentin Liu This serie of patches changes drirc's semanticaclly boolean options, options that are enum type options but which in essence are boolean options e.g. pp_shalde, into actual boolean optioinns. Backwawrd compatbility is maintained by relaxinig

Re: [Mesa-dev] [PATCH] radeonsi/gfx9: use the VI codepath for clamping Z

2017-08-18 Thread Andres Gomez
Hi Marek, This patch landed tagged for 17.2 stable and has been collected for 17.2.0-rc4. However, it seems like it could be also interesting for 17.1.x (?) WDYT? Br. On Thu, 2017-08-10 at 22:33 +0200, Marek Olšák wrote: > From: Marek Olšák > > This fixes corrupted

Re: [Mesa-dev] [PATCH 2/2] gallium/os: fix os_time_get_nano() to roll over less

2017-08-18 Thread Frank Richter
Hi, On 17.08.2017 02:34, Brian Paul wrote: BTW, I wonder if we would win by using lldiv(). Because this is often use for performance measurements, so these extra division might add some impact. Frank, do you want to look into that? In the mean time, I'll push the patches as-is. AFAICS,

Re: [Mesa-dev] [PATCH 04/45] nir: Add support for 16-bit types (half float, int16 and uint16)

2017-08-18 Thread Eduardo Lima Mitev
On 08/17/2017 08:23 PM, Jason Ekstrand wrote: > On Thu, Jul 13, 2017 at 7:35 AM, Alejandro Piñeiro > wrote: > > From: Eduardo Lima Mitev > > > Signed-off-by: Jose Maria Casanova Crespo

[Mesa-dev] [PATCH] gles2: Support for GL_EXT_occlusion_query_boolean

2017-08-18 Thread Harish Krupo
It passes dEQP-GLES2.capability.extensions.other.GL_EXT_occlusion_query_boolean test. I think the test is just a check for the existence of the extension. On gles3 and above, occlusion queries are part of the spec. Signed-off-by: Harish Krupo --- There is a piglit

Re: [Mesa-dev] [PATCH 2/2] radv: Implement bc optimize.

2017-08-18 Thread Nicolai Hähnle
On 15.08.2017 18:32, Bas Nieuwenhuizen wrote: Seems like we actually enabled it already, but did not implement the shader part. With this patch we do. --- src/amd/common/ac_nir_to_llvm.c | 30 ++ src/amd/common/ac_nir_to_llvm.h | 1 +

Re: [Mesa-dev] [PATCH] radeonsi: don't use CLEAR_STATE on SI

2017-08-18 Thread Nicolai Hähnle
On 15.08.2017 18:21, Marek Olšák wrote: From: Marek Olšák This fixes random hangs with Unigine Valley. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102201 One comment below. With that addressed: Fixes: 064550238ef0 ("radeonsi: use CLEAR_STATE to initialize

Re: [Mesa-dev] [PATCH 07/45] nir: Populate conversion opcodes to/from 16-bit types

2017-08-18 Thread Eduardo Lima Mitev
On 08/17/2017 08:48 PM, Jason Ekstrand wrote: > On Thu, Jul 13, 2017 at 7:35 AM, Alejandro Piñeiro > wrote: > > From: Eduardo Lima Mitev > > > This will include the following NIR ALU opcodes:

[Mesa-dev] [PATCH v6.1] egl: Allow creation of per surface out fence

2017-08-18 Thread yogesh . marathe
From: Zhongmin Wu Add plumbing to allow creation of per display surface out fence. Currently enabled only on android, since the system expects a valid fd in ANativeWindow::{queue,cancel}Buffer. We pass a fd of -1 with which native applications such as flatland fail. The

Re: [Mesa-dev] [PATCH 2/2] gallium/os: fix os_time_get_nano() to roll over less

2017-08-18 Thread Jose Fonseca
On 18/08/17 08:23, Frank Richter wrote: Hi, On 17.08.2017 02:34, Brian Paul wrote: BTW, I wonder if we would win by using lldiv(). Because this is often use for performance measurements, so these extra division might add some impact. Frank, do you want to look into that? In the mean time,

Re: [Mesa-dev] [PATCH] radeonsi/gfx9: add shader binary overallocation back

2017-08-18 Thread Nicolai Hähnle
So... do we really need this? I thought the summary of the internal discussion was that gfx9 prefetch was not supposed to cross page boundaries? Cheers, Nicolai On 17.08.2017 00:49, Marek Olšák wrote: From: Marek Olšák Cc: 17.2 ---

Re: [Mesa-dev] [PATCH 2/2] gallium/radeon: remove old_fence parameter from r600_gfx_write_event_eop

2017-08-18 Thread Nicolai Hähnle
For both: Reviewed-by: Nicolai Hähnle On 17.08.2017 19:58, Marek Olšák wrote: From: Marek Olšák just use the new scratch buffer. --- src/gallium/drivers/radeon/r600_pipe_common.c | 15 +++

Re: [Mesa-dev] [PATCH 08/45] spirv/nir: Add support for SPV_KHR_16bit_storage

2017-08-18 Thread Eduardo Lima Mitev
On 08/17/2017 09:09 PM, Jason Ekstrand wrote: > This should come after 10 > Right, fixed locally for v2. > On Thu, Jul 13, 2017 at 7:35 AM, Alejandro Piñeiro > wrote: > > From: Eduardo Lima Mitev

Re: [Mesa-dev] [PATCH 3/3] gallium/radeon: pass LLVM processor to the disk shader cache

2017-08-18 Thread Nicolai Hähnle
On 11.08.2017 20:37, Marek Olšák wrote: On Fri, Aug 11, 2017 at 6:00 PM, Nicolai Hähnle wrote: On 10.08.2017 21:57, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [Mesa-dev] [PATCH 1/4] util/disk_cache: rename mesa cache dir and introduce cache versioning

2017-08-18 Thread Nicolai Hähnle
On 15.08.2017 01:26, Timothy Arceri wrote: Steam is already analysing cache items, unfortunatly we did not introduce a versioning mechanism for identifying structural changes to cache entries earlier so the only way to do so is to rename the cache directory. Since we are renaming it we take the

Re: [Mesa-dev] [PATCH 2/4] util/disk_cache: add struct cache_item_metadata

2017-08-18 Thread Nicolai Hähnle
On 15.08.2017 01:26, Timothy Arceri wrote: This will be used to store more information about the cache item in it's header. This information is intended for 3rd party and cache analysis use but can also be used for detecting the unlikely scenario of cache collisions. --- src/util/disk_cache.h

Re: [Mesa-dev] [PATCH 06/45] nir: Handle fp16 rounding modes at nir_type_conversion_op

2017-08-18 Thread Eduardo Lima Mitev
On 08/17/2017 09:08 PM, Jason Ekstrand wrote: > On Thu, Jul 13, 2017 at 7:35 AM, Alejandro Piñeiro > wrote: > > From: Jose Maria Casanova Crespo > > > nir_type_conversion

Re: [Mesa-dev] [PATCH 00/18] Gallium blitter optimizations

2017-08-18 Thread Nicolai Hähnle
On 17.08.2017 20:31, Marek Olšák wrote: Hi, Major u_blitter changes: - All draw calls except cubemap blits will now use the draw_rectangle callback. (cubemap blits are not used if the driver supports texture views) - The VS POSITION output always covers the whole 2D clip space,

Re: [Mesa-dev] [PATCH 1/4] util/disk_cache: rename mesa cache dir and introduce cache versioning

2017-08-18 Thread Timothy Arceri
On 18/08/17 23:05, Nicolai Hähnle wrote: On 18.08.2017 13:45, Timothy Arceri wrote: On 18/08/17 21:02, Nicolai Hähnle wrote: On 15.08.2017 01:26, Timothy Arceri wrote: Steam is already analysing cache items, unfortunatly we did not introduce a versioning mechanism for identifying

Re: [Mesa-dev] [PATCH] gles2: Support for GL_EXT_occlusion_query_boolean

2017-08-18 Thread Ilia Mirkin
Why the static data changes? Also, I haven't double checked the code, but I'm almost certain this is incomplete. You have to add code disallowing the other enums from being used on es2. On Aug 18, 2017 6:42 AM, "Harish Krupo" wrote: > It passes

Re: [Mesa-dev] [PATCH 02/45] glsl: Add 16-bit types

2017-08-18 Thread Alejandro Piñeiro
On 17/08/17 10:35, Eduardo Lima Mitev wrote: > On 08/15/2017 10:56 PM, Jason Ekstrand wrote: >> On Thu, Jul 13, 2017 at 7:35 AM, Alejandro Piñeiro > > wrote: >> >> From: Eduardo Lima Mitev > >> >>

Re: [Mesa-dev] [PATCH 08/18] gallium/u_blitter: add new union blitter_attrib to replace pipe_color_union

2017-08-18 Thread Nicolai Hähnle
On 17.08.2017 20:31, Marek Olšák wrote: From: Marek Olšák --- src/gallium/auxiliary/util/u_blitter.c| 93 +-- src/gallium/auxiliary/util/u_blitter.h| 12 +++- src/gallium/drivers/r300/r300_context.h | 2 +-

Re: [Mesa-dev] [PATCH] radeonsi/gfx9: use the VI codepath for clamping Z

2017-08-18 Thread Marek Olšák
On Fri, Aug 18, 2017 at 11:01 AM, Andres Gomez wrote: > Hi Marek, > > This patch landed tagged for 17.2 stable and has been collected for > 17.2.0-rc4. > > However, it seems like it could be also interesting for 17.1.x (?) > > WDYT? It was only nominated for 17.2. Let's keep

Re: [Mesa-dev] [PATCH 3/3] gallium/radeon: pass LLVM processor to the disk shader cache

2017-08-18 Thread Marek Olšák
On Fri, Aug 18, 2017 at 12:49 PM, Nicolai Hähnle wrote: > On 11.08.2017 20:37, Marek Olšák wrote: >> >> On Fri, Aug 11, 2017 at 6:00 PM, Nicolai Hähnle >> wrote: >>> >>> On 10.08.2017 21:57, Marek Olšák wrote: From: Marek Olšák

Re: [Mesa-dev] [PATCH] radeonsi/gfx9: add shader binary overallocation back

2017-08-18 Thread Marek Olšák
On Fri, Aug 18, 2017 at 1:17 PM, Nicolai Hähnle wrote: > So... do we really need this? I thought the summary of the internal > discussion was that gfx9 prefetch was not supposed to cross page boundaries? Yes, it looks like we don't need it. Marek

Re: [Mesa-dev] [PATCH 03/18] gallium/radeon: add a workaround when viewport state is used to force Z

2017-08-18 Thread Nicolai Hähnle
On 17.08.2017 20:31, Marek Olšák wrote: From: Marek Olšák This will be needed by u_blitter. --- src/gallium/drivers/radeon/r600_viewport.c | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 2/4] util/disk_cache: add struct cache_item_metadata

2017-08-18 Thread Timothy Arceri
On 18/08/17 21:02, Nicolai Hähnle wrote: On 15.08.2017 01:26, Timothy Arceri wrote: This will be used to store more information about the cache item in it's header. This information is intended for 3rd party and cache analysis use but can also be used for detecting the unlikely scenario of

Re: [Mesa-dev] [PATCH 13/16] st/dri: implement v2 of DRI_ConfigOptions

2017-08-18 Thread Jon Turney
On 30/06/2017 13:45, Nicolai Hähnle wrote: From: Nicolai Hähnle --- src/gallium/auxiliary/pipe-loader/pipe_loader.c| 13 src/gallium/auxiliary/pipe-loader/pipe_loader.h| 16 +++ .../auxiliary/pipe-loader/pipe_loader_drm.c|

Re: [Mesa-dev] [PATCH 1/4] util/disk_cache: rename mesa cache dir and introduce cache versioning

2017-08-18 Thread Nicolai Hähnle
On 18.08.2017 13:45, Timothy Arceri wrote: On 18/08/17 21:02, Nicolai Hähnle wrote: On 15.08.2017 01:26, Timothy Arceri wrote: Steam is already analysing cache items, unfortunatly we did not introduce a versioning mechanism for identifying structural changes to cache entries earlier so the

Re: [Mesa-dev] [PATCH 13/16] st/dri: implement v2 of DRI_ConfigOptions

2017-08-18 Thread Nicolai Hähnle
On 18.08.2017 14:48, Jon Turney wrote: On 30/06/2017 13:45, Nicolai Hähnle wrote: From: Nicolai Hähnle --- src/gallium/auxiliary/pipe-loader/pipe_loader.c| 13 src/gallium/auxiliary/pipe-loader/pipe_loader.h| 16 +++

Re: [Mesa-dev] [PATCH 1/4] util/disk_cache: rename mesa cache dir and introduce cache versioning

2017-08-18 Thread Timothy Arceri
On 18/08/17 21:02, Nicolai Hähnle wrote: On 15.08.2017 01:26, Timothy Arceri wrote: Steam is already analysing cache items, unfortunatly we did not introduce a versioning mechanism for identifying structural changes to cache entries earlier so the only way to do so is to rename the cache

Re: [Mesa-dev] [PATCH 1/4] util/disk_cache: rename mesa cache dir and introduce cache versioning

2017-08-18 Thread Emil Velikov
Hi Tim, A couple of small suggestions which should be applicable, regardless of the current discussion. On 15 August 2017 at 00:26, Timothy Arceri wrote: > Steam is already analysing cache items, unfortunatly we did not s/unfortunatly/unfortunately/ > -

Re: [Mesa-dev] [PATCH 00/18] Gallium blitter optimizations

2017-08-18 Thread Brian Paul
On 08/17/2017 12:31 PM, Marek Olšák wrote: Hi, Major u_blitter changes: - All draw calls except cubemap blits will now use the draw_rectangle callback. (cubemap blits are not used if the driver supports texture views) - The VS POSITION output always covers the whole 2D clip space,

Re: [Mesa-dev] [android-x86-devel] [PATCH] android: fix gallium_dri.so can't be loaded by drm_gralloc

2017-08-18 Thread Emil Velikov
Hi Qiang Yu, On 18 August 2017 at 01:30, Qiang Yu wrote: > The problem is in gallium/winsys/amdgpu/drm/Android.mk > which will have duplacated symbols when linking > gallium_dri.so for libLLVMCore and libLLVM. > Skimming through the commit message and the change inspires some

Re: [Mesa-dev] [PATCH 03/18] gallium/radeon: add a workaround when viewport state is used to force Z

2017-08-18 Thread Marek Olšák
On Fri, Aug 18, 2017 at 3:55 PM, Nicolai Hähnle wrote: > On 17.08.2017 20:31, Marek Olšák wrote: >> >> From: Marek Olšák >> >> This will be needed by u_blitter. >> --- >> src/gallium/drivers/radeon/r600_viewport.c | 23 +-- >> 1

Re: [Mesa-dev] [PATCH] configure: Check llvm-config --shared-mode

2017-08-18 Thread Emil Velikov
On 15 August 2017 at 15:04, Aaron Watry wrote: > glxinfo works fine afterwords, but I get the following error when I > try to run opencl programs: > CommandLine Error: Option 'help-list' registered more than once! > LLVM ERROR: inconsistency in registered CommandLine options >

Re: [Mesa-dev] [PATCH 00/18] Gallium blitter optimizations

2017-08-18 Thread Marek Olšák
On Fri, Aug 18, 2017 at 5:56 PM, Brian Paul wrote: > On 08/17/2017 12:31 PM, Marek Olšák wrote: >> >> Hi, >> >> Major u_blitter changes: >> >> - All draw calls except cubemap blits will now use the draw_rectangle >>callback. (cubemap blits are not used if the driver

Re: [Mesa-dev] [PATCH v2] configure: Check llvm-config --shared-mode

2017-08-18 Thread Emil Velikov
On 16 August 2017 at 07:40, Michel Dänzer wrote: > From: Michel Dänzer > > https://bugs.llvm.org/show_bug.cgi?id=6823 still affects current LLVM. > llvm-config --libs only reports the single shared library if LLVM was > built with

Re: [Mesa-dev] [android-x86-devel] [PATCH] android: fix gallium_dri.so can't be loaded by drm_gralloc

2017-08-18 Thread Rob Herring
On Fri, Aug 18, 2017 at 11:03 AM, Emil Velikov wrote: > Hi Qiang Yu, > > On 18 August 2017 at 01:30, Qiang Yu wrote: >> The problem is in gallium/winsys/amdgpu/drm/Android.mk >> which will have duplacated symbols when linking >> gallium_dri.so for

[Mesa-dev] [PATCH] radeon/uvd: get the target buffer pitch correct for different format

2017-08-18 Thread Leo Liu
Signed-off-by: Leo Liu --- src/gallium/drivers/radeon/radeon_uvd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_uvd.c b/src/gallium/drivers/radeon/radeon_uvd.c index d5352d9de6..dd8c0e0eb0 100644 ---

[Mesa-dev] [PATCH 17/20] radeon/uvd: add YUYV format support for target buffer

2017-08-18 Thread Leo Liu
YUYV is a packed YUV format, and there is no chorma plane Signed-off-by: Leo Liu --- src/gallium/drivers/radeon/radeon_uvd.c | 6 -- src/gallium/drivers/radeonsi/si_uvd.c | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] configure: Trust LLVM >= 4.0 llvm-config --libs for shared libraries

2017-08-18 Thread Jan Vesely
On Mon, 2017-08-14 at 17:11 +0900, Michel Dänzer wrote: > On 11/08/17 02:13 AM, Jan Vesely wrote: > > On Thu, 2017-08-10 at 17:45 +0100, Emil Velikov wrote: > > > > > > Topic for another thread: > > > There's been a handful of issues reported with BUILD_SHARED_LIBS=ON. > > > Should we consider