Re: [Mesa-dev] [PATCH mesa] anv: fix off by one in array check

Reviewed-by: Samuel Iglesias Gonsálvez On Sun, 2017-09-03 at 21:54 -0700, Jason Ekstrand wrote: > I sent the same patch a few hours later.  I don't care which one we > land.  You have a more descriptive commit message. > > Reviewed-by: Jason Ekstrand

Re: [Mesa-dev] [Mesa-stable] [PATCH] anv/formats: Fix an off-by-one in the format array range check

I have just see Eric's patch. Forget this R-b. Sam On Mon, 2017-09-04 at 06:59 +0200, Samuel Iglesias Gonsálvez wrote: > Reviewed-by: Samuel Iglesias Gonsálvez > > On Sun, 2017-09-03 at 17:10 -0700, Jason Ekstrand wrote: > > Found with static code analysis > > > > Cc:

[Mesa-dev] [PATCH] vbo: fix build errors on android

incompatible pointer to integer conversion assigning to 'GLintptr' (aka 'int') from 'const char *' [-Werror,-Wint-conversion] offset = indices; ^ ~~~ Signed-off-by: Tapani Pälli --- src/mesa/vbo/vbo_minmax_index.c | 2 +- 1 file changed, 1

Re: [Mesa-dev] [PATCH 22/23] HACK: anv: Fix query of ELF build-id on ARC++

On 09/02/2017 11:17 AM, Chad Versace wrote: NOT FOR UPSTREAM. To get the driver's build-id, anv_physical_device_init_uuids() searches the current process for an ELF phdr for filename "libvulkan_intel.so". However, Android requires that the library be named "vulkan.${board}.so". I don't

Re: [Mesa-dev] [PATCH 22/23] HACK: anv: Fix query of ELF build-id on ARC++

On 09/04/2017 08:37 AM, Tapani Pälli wrote: On 09/02/2017 11:17 AM, Chad Versace wrote: NOT FOR UPSTREAM. To get the driver's build-id, anv_physical_device_init_uuids() searches the current process for an ELF phdr for filename "libvulkan_intel.so". However, Android requires that the

[Mesa-dev] [Bug 102518] [apitrace, backtrace] Crash in _mesa_is_bufferobj during load of "XCOM 2: War of the Chosen"

https://bugs.freedesktop.org/show_bug.cgi?id=102518 Kai changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #3

[Mesa-dev] [PATCH] mesa/mtypes: repack gl_sampler_object.

From: Dave Airlie 160->152. Signed-off-by: Dave Airlie --- src/mesa/main/mtypes.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 3d68a6d..db9ea76 100644 ---

Re: [Mesa-dev] [PATCH] mesa/mtypes: reback gl_shader_program_data.

Typo in commit subject. s/reback/repack. With that fixed this has my RB. A nice side-effect is that this now fits in two cachelines =) 2017-09-03 13:12 GMT+02:00 Dave Airlie : > From: Dave Airlie > > This reduces the size from 144 bytes to 128 bytes. > >

[Mesa-dev] [PATCH 2/3] ac: reorg ac_shader_binary struct to take less space.

From: Dave Airlie This reduces the size from 96 to 80 bytes but putting all the 32-bit sizes at the start. Signed-off-by: Dave Airlie --- src/amd/common/ac_binary.h | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git

[Mesa-dev] [PATCH 3/3] mesa/bindless: reorder gl_bindless_image gl_bindless_sampler.

From: Dave Airlie This makes these use 16-bytes instead of 24-bytes. Signed-off-by: Dave Airlie --- src/mesa/main/mtypes.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h

[Mesa-dev] [PATCH 1/3] radv: drop emit2d_dst_type.

From: Dave Airlie This is completely unused now. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_meta_blit2d.c | 16 1 file changed, 16 deletions(-) diff --git a/src/amd/vulkan/radv_meta_blit2d.c b/src/amd/vulkan/radv_meta_blit2d.c

[Mesa-dev] [PATCH 2/3] mesa/mtypes: reduce size of gl_sync_object.

From: Dave Airlie Drops from 40->32 bytes. Signed-off-by: Dave Airlie --- src/mesa/main/mtypes.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 7f9c30f..a72a3b2 100644 ---

[Mesa-dev] [PATCH 1/3] mesa/mtypes: reorg vertex/fragment program state.

From: Dave Airlie reduces both of these by 8 bytes. Signed-off-by: Dave Airlie --- src/mesa/main/mtypes.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index

[Mesa-dev] [PATCH 3/3] mesa/mtypes: repack display list structs.

From: Dave Airlie This reduces each of these by 8 bytes. Signed-off-by: Dave Airlie --- src/mesa/main/mtypes.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index

Re: [Mesa-dev] [PATCH] mesa/mtypes: repack gl_texture_object.

2017-09-03 13:18 GMT+02:00 Dave Airlie : > From: Dave Airlie > > reduces size from 1144 to 1128. > > Signed-off-by: Dave Airlie > --- > src/mesa/main/mtypes.h | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff

Re: [Mesa-dev] [PATCH] mesa/mtypes: repack gl_texture_object.

On 3 September 2017 at 21:22, Thomas Helland wrote: > 2017-09-03 13:18 GMT+02:00 Dave Airlie : >> From: Dave Airlie >> >> reduces size from 1144 to 1128. >> >> Signed-off-by: Dave Airlie >> --- >>

Re: [Mesa-dev] [PATCH] mesa/mtypes: repack gl_texture_object.

2017-09-03 13:39 GMT+02:00 Dave Airlie : > On 3 September 2017 at 21:22, Thomas Helland > wrote: >> 2017-09-03 13:18 GMT+02:00 Dave Airlie : >>> From: Dave Airlie >>> >>> reduces size from 1144 to 1128. >>> >>>

Re: [Mesa-dev] [PATCH mesa] util: improve compiler guard

On Friday, 2017-09-01 20:04:33 +, Jose Fonseca wrote: > On 01/09/17 15:54, Eric Engestrom wrote: > > On Thursday, 2017-08-31 13:28:25 -0500, Rob Herring wrote: > > > On Thu, Aug 31, 2017 at 11:54 AM, Eric Engestrom > > > wrote: > > > > Glibc 2.26 has dropped

[Mesa-dev] [PATCH] mesa/mtypes: reorganise gl_shader

From: Dave Airlie This reduces this from 200->182 bytes. Signed-off-by: Dave Airlie --- src/mesa/main/mtypes.h | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index

Re: [Mesa-dev] [PATCH 3/3] mesa/mtypes: repack display list structs.

It's also possible to use "pragma pack" but I believe reordering should be preferred when possible due to overhead of unaligned access, if memory serves me right. All of the reordering patches in main/mtypes has my: Reviewed-by: Thomas Helland 2017-09-03 13:06

[Mesa-dev] [PATCH] mesa/mtypes: repack gl_texture_object.

From: Dave Airlie reduces size from 1144 to 1128. Signed-off-by: Dave Airlie --- src/mesa/main/mtypes.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index d44897b..3d68a6d

[Mesa-dev] [PATCH mesa] anv: fix off by one in array check

`anv_formats[ARRAY_SIZE(anv_formats)]` is already one too far. Spotted by Coverity. CovID: 1417259 Fixes: 242211933a0682696170 "anv/formats: Nicely handle unknown VkFormat enums" Cc: Jason Ekstrand Signed-off-by: Eric Engestrom ---

[Mesa-dev] [Bug 99591] Segmentation fault when running vulkaninfo with RADV Radeon Vulkan driver

https://bugs.freedesktop.org/show_bug.cgi?id=99591 Matias N. Goldberg changed: What|Removed |Added CC|

[Mesa-dev] [Bug 102530] [bisected] Kodi crashes when launching a stream - commit bd2662bf

https://bugs.freedesktop.org/show_bug.cgi?id=102530 Alexandre Demers changed: What|Removed |Added CC|

[Mesa-dev] [Bug 102530] [bisected] Kodi crashes when launching a stream - commit bd2662bf

https://bugs.freedesktop.org/show_bug.cgi?id=102530 Bug ID: 102530 Summary: [bisected] Kodi crashes when launching a stream - commit bd2662bf Product: Mesa Version: 17.2 Hardware: Other OS: All

[Mesa-dev] [Bug 99591] Segmentation fault when running vulkaninfo with RADV Radeon Vulkan driver

https://bugs.freedesktop.org/show_bug.cgi?id=99591 --- Comment #17 from Matias N. Goldberg --- I can confirm that toggling LLVM's BUILD_SHARED_LIBS from ON to OFF and LLVM_BUILD_LLVM_DYLIB from OFF to ON fixed the crash on launch. Vulkan now works without having to set

[Mesa-dev] [PATCH] radv: Actually set the cmd_buffer usage_flags.

Otherwise, the simultaneous uage bit doesn't get set from the begin info, which we need for batchchaining. Fixes: f4e499ec791 "radv: add initial non-conformant radv vulkan driver" --- src/amd/vulkan/radv_cmd_buffer.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [Mesa-dev] [PATCH 1/3] radv: drop emit2d_dst_type.

Patches 1-2 are Reviewed-by: Bas Nieuwenhuizen On Sun, Sep 3, 2017, at 12:06, Dave Airlie wrote: > From: Dave Airlie > > This is completely unused now. > > Signed-off-by: Dave Airlie > --- > src/amd/vulkan/radv_meta_blit2d.c

[Mesa-dev] What is the difference between ROCm and Clover?

Hello, I'm interested in knowing why there are two different OpenCL implementations of OpenCL drivers for AMD cards. Is it because they support different ASICs? One is older and going to be replaced? Thanks, David ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH v2] radv/meta: missing initialisations in create_pass().

Thanks, pushed. On Thu, Aug 31, 2017, at 10:12, Xavier Bouchoux wrote: > Otherwise radv_cmd_state_setup_attachments() will complain it has no > clearvalues, > when called via radv_process_depth_image_inplace(). > > v2: use LOAD/STORE instead of DONT_CARE, to preserve stencil values. > >

Re: [Mesa-dev] [PATCH] mesa/mtypes: reorganise gl_shader

Reviewed-by: Timothy Arceri On 03/09/17 21:09, Dave Airlie wrote: From: Dave Airlie This reduces this from 200->182 bytes. Signed-off-by: Dave Airlie --- src/mesa/main/mtypes.h | 9 + 1 file changed, 5 insertions(+),

[Mesa-dev] [PATCH] mesa/mtypes: reback gl_shader_program_data.

From: Dave Airlie This reduces the size from 144 bytes to 128 bytes. Signed-off-by: Dave Airlie --- src/mesa/main/mtypes.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index

Re: [Mesa-dev] [PATCH] mesa/mtypes: repack gl_sampler_object.

Reviewed-by: Thomas Helland 2017-09-03 13:21 GMT+02:00 Dave Airlie : > From: Dave Airlie > > 160->152. > > Signed-off-by: Dave Airlie > --- > src/mesa/main/mtypes.h | 2 +- > 1 file changed, 1 insertion(+), 1

[Mesa-dev] [PATCH] anv/formats: Fix an off-by-one in the format array range check

Found with static code analysis Cc: mesa-sta...@lists.freedesktop.org --- src/intel/vulkan/anv_formats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_formats.c b/src/intel/vulkan/anv_formats.c index c23b143..eead1aa 100644 ---

[Mesa-dev] [Bug 102530] [bisected] Kodi crashes when launching a stream - commit bd2662bf

https://bugs.freedesktop.org/show_bug.cgi?id=102530 --- Comment #1 from Timothy Arceri --- Are you able to provide a stack trace? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [PATCH] glsl: fix loop analysis of loop terminators

This code incorrectly assumed that loop terminators will always be at the start of the loop. Fortunately we *seem* to avoid any bugs because the unrolling code loops over and correctly handles the terminators. However the incorrect analysis can result in loops not being unrolled at all. For

[Mesa-dev] [Bug 102530] [bisected] Kodi crashes when launching a stream - commit bd2662bf

https://bugs.freedesktop.org/show_bug.cgi?id=102530 --- Comment #2 from Tapani Pälli --- Just a guess but at least it looks possible for "UniformRemapTable[location]" to access garbage, there should be a check for location value before using it. -- You are receiving this mail

Re: [Mesa-dev] [PATCH mesa] anv: fix off by one in array check

I sent the same patch a few hours later. I don't care which one we land. You have a more descriptive commit message. Reviewed-by: Jason Ekstrand On Sun, Sep 3, 2017 at 11:33 AM, Eric Engestrom wrote: > `anv_formats[ARRAY_SIZE(anv_formats)]` is already

Re: [Mesa-dev] [Mesa-stable] [PATCH] anv/formats: Fix an off-by-one in the format array range check

Reviewed-by: Samuel Iglesias Gonsálvez On Sun, 2017-09-03 at 17:10 -0700, Jason Ekstrand wrote: > Found with static code analysis > > Cc: mesa-sta...@lists.freedesktop.org > --- >  src/intel/vulkan/anv_formats.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > >