Re: [Mesa-dev] [PATCH 2/2] radeonsi: reallocate if a non-sharable textures is being shared

Both patches: Reviewed-by: Nicolai Hähnle On 14.09.2017 19:40, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeon/r600_texture.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH v2 0/6] Flag new aux state on aux state updates

Hi Jason, thanks for the quick review! I agree with all your points and will update the series accordingly before pushing. Iago On Fri, 2017-09-15 at 17:11 -0700, Jason Ekstrand wrote: > I don't think we need patches 2 or 6 and the commit message from 2 > should probably go on 5.  I left a comment

[Mesa-dev] [PATCH] swr/rast: Fix GetEnv() returned value

Return an empty string instead of a NULL pointer. Patch from Bernhard Rosenkraenzer. https://bugs.freedesktop.org/show_bug.cgi?id=101832 Fixes: a25093de718 ("swr/rast: Implement JIT shader caching to disk") --- src/gallium/drivers/swr/rasterizer/core/utils.h | 3 ++- 1 file changed, 2

[Mesa-dev] [PATCH v2] i965: expose SRGB visuals and turn on EGL_KHR_gl_colorspace

Patch exposes sRGB visuals and adds DRI integer query support for __DRI2_RENDERER_HAS_FRAMEBUFFER_SRGB. Further changes make sure that we mark if the app explicitly wanted sRGB and for these framebuffers we don't turn sRGB off in intel_gles3_srgb_workaround. This way we keep compatibility for

Re: [Mesa-dev] [PATCH] swr/rast: Fix GetEnv() returned value

On Monday, 2017-09-18 11:10:39 +0200, Laurent Carlier wrote: > Return an empty string instead of a NULL pointer. > Patch from Bernhard Rosenkraenzer. I guess attributing the patch to him in git would be nice too: From: Bernhard Rosenkraenzer > >

Re: [Mesa-dev] [PATCH] swr/rast: do not crash on NULL strings returned by getenv

On Monday, 2017-09-18 11:29:21 +0100, Emil Velikov wrote: > From: Bernhard Rosenkraenzer > > The current convinince function GetEnv feeds the results of getenv > directly into std::string(). That is a bad idea, since the variable > may be unset, thus we feed NULL into the C++

[Mesa-dev] [PATCH 1/3] gallium: add CANON opcode

From: Nicolai Hähnle --- src/gallium/auxiliary/gallivm/lp_bld_limits.h| 1 + src/gallium/auxiliary/tgsi/tgsi_exec.h | 1 + src/gallium/auxiliary/tgsi/tgsi_info_opcodes.h | 2 +- src/gallium/docs/source/screen.rst | 2 ++

[Mesa-dev] [PATCH 0/3] tgsi, radeonsi: add CANON opcode for float canonicalization

Hi all, This series fixes an issue we have on GCN due to the arguably inconsistent handling of denormal floating point values. We disable denormals for 32-bit floating point numbers, because enabling them would cost a lot of performance. By and large, GCN floating point instructions flush

[Mesa-dev] [PATCH 3/3] radeonsi: request and emit CANON opcodes

From: Nicolai Hähnle Fixes dEQP-GLES31.functional.shaders.builtin_functions.precision.{clamp,min,max}.* --- src/gallium/drivers/radeonsi/si_pipe.c| 2 +- src/gallium/drivers/radeonsi/si_shader_tgsi_alu.c | 2 ++ 2 files changed, 3 insertions(+), 1

[Mesa-dev] [PATCH 2/3] st/glsl_to_tgsi: emit CANON opcode when requested

From: Nicolai Hähnle We canonicalize floating point values before storing them anywhere where the application could potentially examine the underlying bit pattern. This includes GLSL bitcases, buffer stores (but not atomics, since they're all operating on integer types)

Re: [Mesa-dev] [PATCH 1/3] glsl: don't drop intructions from unreachable terminators continue branch

On 14.09.2017 06:47, Timothy Arceri wrote: These instruction will be executed on every iteration of the loop *instructions Als, the title of the patch is missing an s ;) Cheers, Nicolai we cannot drop them. --- src/compiler/glsl/loop_analysis.h | 7 +++

Re: [Mesa-dev] [PATCH 2/3] glsl: check if induction var incremented before use in terminator

On 14.09.2017 06:47, Timothy Arceri wrote: do-while loops can increment the starting value before the condition is checked. e.g. do { ndx++; } while (ndx < 3); This commit changes the code to detect this and reduces the iteration count by 1 if found. With Eric's remark fixes, this

Re: [Mesa-dev] [PATCH v2 3/7] travis: Add clover build using llvm-3.7

On Sunday, 2017-09-17 02:02:33 -0400, Jan Vesely wrote: > v2: Use direct llvm repo link instead of alias > Enable > > Signed-off-by: Jan Vesely > --- > .travis.yml | 40 > 1 file changed, 40 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH] radv: Check for GFX9 for 1D arrays in image_size intrinsic.

On 15.09.2017 21:46, Bas Nieuwenhuizen wrote: Only on GFX9 we implement them as 2D images. This fixes: dEQP-VK.image.image_size.1d_array.readonly_12x34 dEQP-VK.image.image_size.1d_array.readonly_1x1 dEQP-VK.image.image_size.1d_array.readonly_32x32 dEQP-VK.image.image_size.1d_array.readonly_7x1

Re: [Mesa-dev] [PATCH] glsl: buffer variables can be readonly and writeonly

On 09/15/2017 04:56 PM, Juan A. Suarez Romero wrote: On Fri, 2017-09-15 at 13:04 +0200, Juan A. Suarez Romero wrote: On Fri, 2017-09-15 at 12:47 +0200, Samuel Pitoiset wrote: I guess this will break some piglits. Right. I'll check them and provide fixes After running piglit with and

Re: [Mesa-dev] [PATCH 3/3] i965: Force outputs_written to contain varyings needed by stream-out.

For the series: Reviewed-by: Juan A. Suarez Romero On Fri, 2017-09-15 at 10:17 -0700, Kenneth Graunke wrote: > If transform feedback is recording a varying, it needs a slot in the > VUE map, regardless of whether or not the shader writes it. > > Together with the previous

Re: [Mesa-dev] [PATCH 1/3] glsl: don't drop intructions from unreachable terminators continue branch

On 18/09/17 20:09, Nicolai Hähnle wrote: On 14.09.2017 06:47, Timothy Arceri wrote: These instruction will be executed on every iteration of the loop we cannot drop them. ---   src/compiler/glsl/loop_analysis.h   |  7 +++   src/compiler/glsl/loop_controls.cpp | 15 +++  

Re: [Mesa-dev] [PATCH] swr/rast: do not crash on NULL strings returned by getenv

Le lundi 18 septembre 2017, 12:48:45 CEST Eric Engestrom a écrit : > On Monday, 2017-09-18 11:29:21 +0100, Emil Velikov wrote: > > From: Bernhard Rosenkraenzer > > > > The current convinince function GetEnv feeds the results of getenv > > directly into std::string(). That is a

[Mesa-dev] [PATCH] glsl/linker: fix output variable overlap check

From: Nicolai Hähnle Prevent an overflow caused by too many output variables. To limit the scope of the issue, write to the assigned array only for the non-ES fragment shader path, which is the only place where it's needed. Since the function will bail with an error

Re: [Mesa-dev] [PATCH 3/3] glsl: make loop unrolling more like the nir unrolling path

On 14.09.2017 06:47, Timothy Arceri wrote: The old code incorrectly assumed that loop terminators will always be at the start of the loop. It really seems to be just luck that we haven't triggered any bugs here, for example if there is a loop terminator at the start of the loop we might actually

Re: [Mesa-dev] [PATCH 3/3] glsl: make loop unrolling more like the nir unrolling path

On 18/09/17 20:50, Nicolai Hähnle wrote: On 14.09.2017 06:47, Timothy Arceri wrote: The old code incorrectly assumed that loop terminators will always be at the start of the loop. It really seems to be just luck that we haven't triggered any bugs here, for example if there is a loop

Re: [Mesa-dev] [PATCH] swr/rast: do not crash on NULL strings returned by getenv

On 18 September 2017 at 11:48, Eric Engestrom wrote: > On Monday, 2017-09-18 11:29:21 +0100, Emil Velikov wrote: >> From: Bernhard Rosenkraenzer >> >> The current convinince function GetEnv feeds the results of getenv >> directly into std::string().

[Mesa-dev] [PATCH 4/4] radv: do not update the number of scissors in vkCmdSetScissor()

The Vulkan spec (1.0.61) says: "The number of scissors used by a pipeline is still specified by the scissorCount member of VkPipelinescissorStateCreateInfo." So, the number of scissors is defined at pipeline creation time and shouldn't be updated when they are set dynamically.

[Mesa-dev] [PATCH 3/4] radv: do not update the number of viewports in vkCmdSetViewport()

The Vulkan spec (1.0.61) says: "The number of viewports used by a pipeline is still specified by the viewportCount member of VkPipelineViewportStateCreateInfo." So, the number of viewports is defined at pipeline creation time and shouldn't be updated when they are set dynamically.

Re: [Mesa-dev] [PATCH 2/3] radv: only copy the dynamic states that changed

On 09/15/2017 05:40 PM, Fredrik Höglund wrote: On Thursday 14 September 2017, Samuel Pitoiset wrote: On 09/13/2017 06:34 PM, Fredrik Höglund wrote: On Wednesday 13 September 2017, Samuel Pitoiset wrote: When binding a new pipeline, we applied all dynamic states without checking if they

[Mesa-dev] [PATCH 2/4] radv: add some assertions in vkCmdSetScissor()

To check some valid usage requirements. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index

[Mesa-dev] [PATCH 1/4] radv: add some assertions in vkCmdSetViewport()

To check some valid usage requirements. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index

Re: [Mesa-dev] [PATCH] i965: skip varyings without slot

On Wed, 2017-09-06 at 10:32 +1000, Timothy Arceri wrote: > > On 01/09/17 21:15, Juan A. Suarez Romero wrote: > > On Thu, 2017-06-29 at 14:43 +1000, Timothy Arceri wrote: > > > On 27/06/17 21:20, Juan A. Suarez Romero wrote: > > > > On Tue, 2017-06-27 at 09:29 +1000, Timothy Arceri wrote: > > > >

Re: [Mesa-dev] [PATCH 1/3] glsl: don't drop intructions from unreachable terminators continue branch

On 14.09.2017 06:47, Timothy Arceri wrote: These instruction will be executed on every iteration of the loop we cannot drop them. --- src/compiler/glsl/loop_analysis.h | 7 +++ src/compiler/glsl/loop_controls.cpp | 15 +++ src/compiler/glsl/loop_unroll.cpp | 7 ---

[Mesa-dev] [PATCH] swr/rast: do not crash on NULL strings returned by getenv

From: Bernhard Rosenkraenzer The current convinince function GetEnv feeds the results of getenv directly into std::string(). That is a bad idea, since the variable may be unset, thus we feed NULL into the C++ construct. The latter of which is not allowed and leads to a crash.

Re: [Mesa-dev] [PATCH 2/2] i965: Warn for GTT fallbacks when mapping the batch/state buffers.

Quoting Kenneth Graunke (2017-09-17 15:06:49) > On Sunday, September 17, 2017 1:58:16 AM PDT Chris Wilson wrote: > > Quoting Kenneth Graunke (2017-09-16 09:31:27) > > > This shouldn't really happen in practice, but I hit it a couple of times > > > when running a driver with a bad memory leak. We

Re: [Mesa-dev] [PATCH 0/3] tgsi, radeonsi: add CANON opcode for float canonicalization

On 18.09.2017 17:02, Roland Scheidegger wrote: This looks like a horrendous solution which will break the world - well for us :-). Because integers simply will cease to work, always flushed to zero (bye bye loop counter...). The reason is that when you translate from something with a untyped

Re: [Mesa-dev] [PATCH] llvmpipe, gallivm: implement lod queries (LODQ opcode)

On 18/09/17 03:53, srol...@vmware.com wrote: From: Roland Scheidegger This uses all the existing code to calculate lod values for mip linear filtering. Though we'll have to disable the simplifications (if we know some parts of the lod calculation won't actually matter for

Re: [Mesa-dev] [PATCH 3/4] i965/tex_image: Reference the renderbuffer miptree in setTexBuffer2

On Tue 12 Sep 2017, Jason Ekstrand wrote: > The old code made a new miptree that referenced the same BO as the > renderbuffer and just trusted in the memory aliasing to work. There are > only two ways in which the new miptree is liable to differ from the one > in the renderbuffer and neither of

Re: [Mesa-dev] [PATCH RFC 3/7] travis: Add clover build using llvm-3.7

Hi Jan, On 17 September 2017 at 03:05, Jan Vesely wrote: > Disable for now, travis does not allow llvm-3.7 trusty toolchain > I've just fired up a thread about bumping the Clover requirement to 3.9. The reason why I brought it up is that all modern platforms actually

Re: [Mesa-dev] [PATCH 2/4] i965: Reset miptree aux state on update_image_buffer

On Tue 12 Sep 2017, Jason Ekstrand wrote: > When we get a miptree in through glxBindImageEXT, we don't know the > current aux state so we have to assume the worst-case. If the image > gets recreated, everything is fine because miptreecreate_for_dri_image > sets it to the default. However, if our

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] radeonsi: fix array textures layer coordinate

On Mon, Sep 18, 2017 at 4:57 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Like for cube map (array) gather, we need to round to nearest on <= VI. > > Fixes tests in dEQP-GLES3.functional.shaders.texture_functions.texture.* > > Cc:

Re: [Mesa-dev] [PATCH v2 3/7] travis: Add clover build using llvm-3.7

On Mon, 2017-09-18 at 11:13 +0100, Eric Engestrom wrote: > On Sunday, 2017-09-17 02:02:33 -0400, Jan Vesely wrote: > > v2: Use direct llvm repo link instead of alias > > Enable > > > > Signed-off-by: Jan Vesely > > --- > > .travis.yml | 40

Re: [Mesa-dev] [PATCH] gallium: add PIPE_QUERY_OCCLUSION_PREDICATE_CONSERVATIVE

On Wed, 2017-09-13 at 18:53 +0200, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > To be able to properly distinguish between GL_ANY_SAMPLES_PASSED > and GL_ANY_SAMPLES_PASSED_CONSERVATIVE. > > This patch goes through all drivers, having them treat the two > query

[Mesa-dev] Building Mesa GIT with LLVM prior to 3.9

Hi all, As you may know, different components in Mesa use LLVM for various purposes. In particular: - 3.3.0 for the aux gallium module, gallivm - 3.6.0 for the opencl state-tracker, clover - 3.9.0 for multiple drivers r600, radeonsi, radv and swr AFAICT gallivm is build on Windows, and using

Re: [Mesa-dev] [PATCH] r600: fork and import gallium/radeon

On Thu, Sep 14, 2017 at 4:52 PM, Nicolai Hähnle wrote: > On 14.09.2017 16:19, Emil Velikov wrote: >> >> Hi Marek, >> >> On 14 September 2017 at 14:06, Marek Olšák wrote: >>> >>> From: Marek Olšák >>> >>> This marks the end of code

[Mesa-dev] [PATCH] Fixes: gallium: add PIPE_QUERY_OCCLUSION_PREDICATE_CONSERVATIVE

There is a small typo that prevents compilation. Please kindly review and push. Cheers, Benedikt Signed-off-by: Benedikt Schemmer --- diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_query_hw.c b/src/gallium/drivers/nouveau/nvc0/nvc0_query_hw.c ---

Re: [Mesa-dev] [PATCH v2] configure+mesa/st: check -std=c++11 support and enable tests accordingly

Hi Gert, On 17 September 2017 at 08:32, Gert Wollny wrote: > The tests in mesa/st/tests require C++11. Check whether the compiler > supports the -std=c++11 flag and if so, enable the tests. Otherwise > skip compiling and running the tests altogether. > > Fixes: 7be6d8fe12

[Mesa-dev] [PATCH v2] glsl: buffer variables can be readonly and writeonly

In GLSL ES 3.10 session 4.9 [Memory Access Qualifiers], it has the following description: "A variable could be qualified as both readonly and writeonly, disallowing both read and write, but still be passed to imageSize() to have the size queried.". This is for image variable, but not for

Re: [Mesa-dev] [PATCH] glsl: buffer variables can be readonly and writeonly

On Mon, 2017-09-18 at 10:50 +0200, Samuel Pitoiset wrote: > > On 09/15/2017 04:56 PM, Juan A. Suarez Romero wrote: > > On Fri, 2017-09-15 at 13:04 +0200, Juan A. Suarez Romero wrote: > > > On Fri, 2017-09-15 at 12:47 +0200, Samuel Pitoiset wrote: > > > > I guess this will break some piglits. > >

Re: [Mesa-dev] [PATCH] r600: fork and import gallium/radeon

On 18 September 2017 at 17:08, Marek Olšák wrote: > On Thu, Sep 14, 2017 at 4:52 PM, Nicolai Hähnle wrote: >> On 14.09.2017 16:19, Emil Velikov wrote: >>> >>> Hi Marek, >>> >>> On 14 September 2017 at 14:06, Marek Olšák wrote:

Re: [Mesa-dev] [PATCH] r600: fork and import gallium/radeon

Latest version with an updated commit message: https://cgit.freedesktop.org/~mareko/mesa/commit/?h=master=8671613ed19586ac1eceda48eb067a416f9c93be Marek On Mon, Sep 18, 2017 at 6:18 PM, Emil Velikov wrote: > On 18 September 2017 at 17:08, Marek Olšák

Re: [Mesa-dev] [PATCH 4/4] i965: Use prepare_external instead of make_shareable in setTexBuffer2

On Mon, Sep 18, 2017 at 9:20 AM, Chad Versace wrote: > On Thu 14 Sep 2017, Eric Anholt wrote: > > Jason Ekstrand writes: > > > > > The setTexBuffer2 hook from GLX is used to implement glxBindTexImageEXT > > > which has tighter restrictions than

Re: [Mesa-dev] [PATCH] ac/surface: handle S8 on gfx9

Reviewed-by: Marek Olšák Marek On Mon, Sep 18, 2017 at 5:21 AM, Dave Airlie wrote: > From: Dave Airlie > > If we don't have a depth piece, we don't get a correct > swizzle mode and we hit an assert in addrlib. > > In case of no depth

Re: [Mesa-dev] [PATCH] gallium: add PIPE_QUERY_OCCLUSION_PREDICATE_CONSERVATIVE

On 18.09.2017 17:22, Jan Vesely wrote: On Wed, 2017-09-13 at 18:53 +0200, Nicolai Hähnle wrote: From: Nicolai Hähnle To be able to properly distinguish between GL_ANY_SAMPLES_PASSED and GL_ANY_SAMPLES_PASSED_CONSERVATIVE. This patch goes through all drivers, having

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/2] radeonsi: set MIP_POINT_PRECLAMP to 0

I commented on patch 1. Other than that, the series is: Reviewed-by: Marek Olšák Marek On Mon, Sep 18, 2017 at 4:57 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > This fixes a bug with nearest ("point") mip selection

Re: [Mesa-dev] [PATCH 1/7] clover: add missing include to compat.h

On Saturday, 2017-09-16 22:05:39 -0400, Jan Vesely wrote: > Fixes build issues with llvm-3.6 > Fixes: 3115687f9b9830417c408228db2bc679e346bba6 (clover: Fix build after > LLVM r313390) > > Signed-off-by: Jan Vesely R-b and pushed this with Gert's t-b, without waiting any

Re: [Mesa-dev] [PATCH 1/4] intel/isl: Add a drm_modifier_get_default_aux_state helper

On Tue 12 Sep 2017, Jason Ekstrand wrote: > --- > src/intel/isl/isl.h | 20 > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 3 +-- > 2 files changed, 21 insertions(+), 2 deletions(-) > > diff --git a/src/intel/isl/isl.h b/src/intel/isl/isl.h >

Re: [Mesa-dev] [PATCH 1/7] clover: add missing include to compat.h

Jan Vesely writes: > Fixes build issues with llvm-3.6 > Fixes: 3115687f9b9830417c408228db2bc679e346bba6 (clover: Fix build after > LLVM r313390) > > Signed-off-by: Jan Vesely Reviewed-by: Francisco Jerez > --- >

Re: [Mesa-dev] [PATCH v2 3/7] travis: Add clover build using llvm-3.7

On Monday, 2017-09-18 11:10:37 -0400, Jan Vesely wrote: > On Mon, 2017-09-18 at 11:13 +0100, Eric Engestrom wrote: > > On Sunday, 2017-09-17 02:02:33 -0400, Jan Vesely wrote: > > > v2: Use direct llvm repo link instead of alias > > > Enable > > > > > > Signed-off-by: Jan Vesely

[Mesa-dev] [PATCH] gallium/radeon: consolidate PIPE_BIND_SHARED/SCANOUT handling

From: Marek Olšák --- src/gallium/drivers/radeon/r600_buffer_common.c | 13 - src/gallium/drivers/radeon/r600_texture.c | 4 2 files changed, 4 insertions(+), 13 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_buffer_common.c

Re: [Mesa-dev] [PATCH] Fixes: radeonsi: allow out-of-order rasterization in commutative blending cases

On 18.09.2017 15:27, Benedikt Schemmer wrote: There is a small typo that prevents compilation. Please kindly review and push. Cheers, Benedikt Signed-off-by: Benedikt Schemmer Ilia pointed this out to me, but I dropped it (I think because the mail didn't go to the mailing

Re: [Mesa-dev] [PATCH 4/4] i965: Use prepare_external instead of make_shareable in setTexBuffer2

On Thu 14 Sep 2017, Eric Anholt wrote: > Jason Ekstrand writes: > > > The setTexBuffer2 hook from GLX is used to implement glxBindTexImageEXT > > which has tighter restrictions than just "it's shared". In particular, > > it says that any rendering to the image while it is

Re: [Mesa-dev] [PATCH 05/15] vulkan: enum generator: generate extension number defines

Did you have a patch to the enum generator to actually generate the table of tables for the formats? I don't see that in ithe series. On Mon, Sep 18, 2017 at 7:46 AM, Jason Ekstrand wrote: > On Fri, Sep 15, 2017 at 7:10 AM, Lionel Landwerlin < >

Re: [Mesa-dev] [PATCH 05/15] vulkan: enum generator: generate extension number defines

On Fri, Sep 15, 2017 at 7:10 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > New extensions can introduce additional enums. Most of the new enums > will have disjoint numbers from the initial enums. For example new > formats introduced by VK_IMG_format_pvrtc : > >

[Mesa-dev] [PATCH 1/2] radeonsi: fix array textures layer coordinate

From: Nicolai Hähnle Like for cube map (array) gather, we need to round to nearest on <= VI. Fixes tests in dEQP-GLES3.functional.shaders.texture_functions.texture.* Cc: mesa-sta...@lists.freedesktop.org --- src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c | 12

Re: [Mesa-dev] [PATCH 05/15] vulkan: enum generator: generate extension number defines

No, this is all I had. Tables of tables formats are just in anv : https://github.com/djdeath/mesa/commit/b40dd5245cdaa5d686b8494f0e8c784b2eea4211#diff-8d7721e9d80d390ff503d2c3b4e1adc5L274 On 18/09/17 15:48, Jason Ekstrand wrote: Did you have a patch to the enum generator to actually generate

[Mesa-dev] [PATCH 2/2] radeonsi: set MIP_POINT_PRECLAMP to 0

From: Nicolai Hähnle This fixes a bug with nearest ("point") mip selection when the fractional part of max_lod is in (0.5,1). In this case, the spec mandates that we still select the mip level ceil(max_lod) in the clamping case. However, MIP_POINT_PRECLAMP will clamp

Re: [Mesa-dev] [PATCH 3/3] egl/android: Use per surface out fence

On 18 September 2017 at 15:42, Marathe, Yogesh wrote: > Hi Emil, as discussed, we are leaving this at 3/3 split you've created. > > I've marked my earlier series "Not Applicable" in patchwork. Thanks. > Right, thanks. I'll push the series in an hour or so... with a

[Mesa-dev] [PATCH] Fixes: radeonsi: allow out-of-order rasterization in commutative blending cases

There is a small typo that prevents compilation. Please kindly review and push. Cheers, Benedikt Signed-off-by: Benedikt Schemmer diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_query_hw.c b/src/gallium/drivers/nouveau/nvc0/nvc0_query_hw.c ---

Re: [Mesa-dev] [PATCH] Fixes: radeonsi: allow out-of-order rasterization in commutative blending cases

Wrong commit, correct one is: gallium: add PIPE_QUERY_OCCLUSION_PREDICATE_CONSERVATIVE Am 18.09.2017 um 15:27 schrieb Benedikt Schemmer: > There is a small typo that prevents compilation. > Please kindly review and push. > Cheers, > Benedikt > > Signed-off-by: Benedikt Schemmer >

Re: [Mesa-dev] [PATCH 3/3] egl/android: Use per surface out fence

Hi Emil, as discussed, we are leaving this at 3/3 split you've created. I've marked my earlier series "Not Applicable" in patchwork. Thanks. -Yogesh. >-Original Message- >From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of >Emil Velikov >Sent: Friday, September

Re: [Mesa-dev] [PATCH 0/3] tgsi, radeonsi: add CANON opcode for float canonicalization

This looks like a horrendous solution which will break the world - well for us :-). Because integers simply will cease to work, always flushed to zero (bye bye loop counter...). The reason is that when you translate from something with a untyped register file to something typed, the obvious

[Mesa-dev] [PATCH mesa 2/2] radv: replace conditional compilation with MAYBE_UNUSED

Signed-off-by: Eric Engestrom --- src/amd/vulkan/radv_wsi.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/amd/vulkan/radv_wsi.c b/src/amd/vulkan/radv_wsi.c index 8a551c48bb..c9d4bbce8b 100644 --- a/src/amd/vulkan/radv_wsi.c +++

[Mesa-dev] [PATCH 1/2] i965: Move MI_BATCHBUFFER_END handling into brw_finish_batch().

This is, by definition, finishing the batch. --- src/mesa/drivers/dri/i965/intel_batchbuffer.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_batchbuffer.c b/src/mesa/drivers/dri/i965/intel_batchbuffer.c index

Re: [Mesa-dev] [PATCH 10/15] anv: modify the internal concept of format to express multiple planes

On Fri, Sep 15, 2017 at 7:11 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > A given Vulkan format can now be decomposed into a set of planes. We > now use 'struct anv_format_plane' to represent the format of those > planes. > > Signed-off-by: Lionel Landwerlin

Re: [Mesa-dev] [PATCH 4/4] i965: Use prepare_external instead of make_shareable in setTexBuffer2

Jason Ekstrand writes: > On Mon, Sep 18, 2017 at 9:20 AM, Chad Versace > wrote: > >> On Thu 14 Sep 2017, Eric Anholt wrote: >> > Jason Ekstrand writes: >> > >> > > The setTexBuffer2 hook from GLX is used to implement

Re: [Mesa-dev] [PATCH 0/3] tgsi, radeonsi: add CANON opcode for float canonicalization

Am 18.09.2017 um 19:11 schrieb Roland Scheidegger: > Am 18.09.2017 um 17:36 schrieb Nicolai Hähnle: >> On 18.09.2017 17:02, Roland Scheidegger wrote: >>> This looks like a horrendous solution which will break the world - well >>> for us :-). Because integers simply will cease to work, always

Re: [Mesa-dev] [PATCH 11/15] anv: add new formats KHR_sampler_ycbcr_conversion

On Sun, Sep 17, 2017 at 3:31 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > On 15/09/17 23:36, Jason Ekstrand wrote: > > struct anv_format_plane { >> enum isl_format isl_format:16; >> struct isl_swizzle swizzle; >> + >> + /* Whether this plane contains chroma channels

Re: [Mesa-dev] [PATCH v2] configure+mesa/st: check -std=c++11 support and enable tests accordingly

Am Montag, den 18.09.2017, 16:07 +0100 schrieb Emil Velikov: > Hi Gert, > > On 17 September 2017 at 08:32, Gert Wollny > wrote: > > The tests in mesa/st/tests require C++11. Check whether the > > compiler > > supports the -std=c++11 flag and if so, enable the tests.

Re: [Mesa-dev] Building Mesa GIT with LLVM prior to 3.9

On Mon, 2017-09-18 at 17:00 +0100, Emil Velikov wrote: > Hi all, > > As you may know, different components in Mesa use LLVM for various purposes. > > In particular: > - 3.3.0 for the aux gallium module, gallivm > - 3.6.0 for the opencl state-tracker, clover > - 3.9.0 for multiple drivers

Re: [Mesa-dev] [PATCH 1/2] i965: Move MI_BATCHBUFFER_END handling into brw_finish_batch().

Quoting Kenneth Graunke (2017-09-18 18:56:56) > This is, by definition, finishing the batch. > --- > src/mesa/drivers/dri/i965/intel_batchbuffer.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/intel_batchbuffer.c >

[Mesa-dev] [PATCH mesa 1/2] glsl: replace conditional compilation with MAYBE_UNUSED

Suggested-by: Nicolai Hähnle Signed-off-by: Eric Engestrom --- src/compiler/glsl/ir_validate.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/compiler/glsl/ir_validate.cpp b/src/compiler/glsl/ir_validate.cpp index

Re: [Mesa-dev] [PATCH 2/2] i965: Fix brw_finish_batch to grow the batchbuffer.

Quoting Kenneth Graunke (2017-09-18 18:56:57) > brw_finish_batch emits commands needed at the end of every batch buffer, > including any workarounds. In the past, we freed up some "reserved" > batch space before calling it, so we would never have to flush during > it. This was error prone and

Re: [Mesa-dev] [PATCH v2 3/7] travis: Add clover build using llvm-3.7

On Mon, 2017-09-18 at 16:46 +0100, Eric Engestrom wrote: > On Monday, 2017-09-18 11:10:37 -0400, Jan Vesely wrote: > > On Mon, 2017-09-18 at 11:13 +0100, Eric Engestrom wrote: > > > On Sunday, 2017-09-17 02:02:33 -0400, Jan Vesely wrote: > > > > v2: Use direct llvm repo link instead of alias > > >

[Mesa-dev] [PATCH 1/2] configure: check if -latomic is needed for __atomic_*

On some platforms, gcc generates library calls when __atomic_* functions are used, but does not link the required library automatically. Detect this and add the library when needed. This change was tested on armel (library was added) and on x86_64 (was not, as expected). Fixes: 8915f0c0 "util:

[Mesa-dev] [PATCH 2/2] util/u_atomic: remove unnecessaty __atomic functions

They are now provided by -latomic, which should be linked as needed since previous commit. Signed-off-by: Grazvydas Ignotas --- src/util/u_atomic.c | 12 1 file changed, 12 deletions(-) diff --git a/src/util/u_atomic.c b/src/util/u_atomic.c index

Re: [Mesa-dev] [PATCH 0/3] tgsi, radeonsi: add CANON opcode for float canonicalization

Am 18.09.2017 um 17:36 schrieb Nicolai Hähnle: > On 18.09.2017 17:02, Roland Scheidegger wrote: >> This looks like a horrendous solution which will break the world - well >> for us :-). Because integers simply will cease to work, always flushed >> to zero (bye bye loop counter...). >> The reason

[Mesa-dev] [PATCH 2/2] i965: Fix brw_finish_batch to grow the batchbuffer.

brw_finish_batch emits commands needed at the end of every batch buffer, including any workarounds. In the past, we freed up some "reserved" batch space before calling it, so we would never have to flush during it. This was error prone and easy to screw up, so I deleted it a while back in favor

Re: [Mesa-dev] [PATCH mesa 2/2] radv: replace conditional compilation with MAYBE_UNUSED

Both patches are: Reviewed-by: Samuel Pitoiset On 09/18/2017 07:15 PM, Eric Engestrom wrote: Signed-off-by: Eric Engestrom --- src/amd/vulkan/radv_wsi.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 4/4] i965: Use prepare_external instead of make_shareable in setTexBuffer2

On Mon, Sep 18, 2017 at 10:12 AM, Eric Anholt wrote: > Jason Ekstrand writes: > > > On Mon, Sep 18, 2017 at 9:20 AM, Chad Versace > > wrote: > > > >> On Thu 14 Sep 2017, Eric Anholt wrote: > >> > Jason Ekstrand

Re: [Mesa-dev] [PATCH] st/dri: Add an option to always request a front buffer from the loader

Thomas Hellstrom writes: > When an application decides to read from the front buffer of a window, > typically a fake front is created and initialized with the real front window > contents. However, if there was a window manager reparenting operation between > the last

Re: [Mesa-dev] [PATCH 1/2] i965: Move MI_BATCHBUFFER_END handling into brw_finish_batch().

On Monday, September 18, 2017 11:03:37 AM PDT Chris Wilson wrote: > Quoting Kenneth Graunke (2017-09-18 18:56:56) > > This is, by definition, finishing the batch. > > --- > > src/mesa/drivers/dri/i965/intel_batchbuffer.c | 14 +++--- > > 1 file changed, 7 insertions(+), 7 deletions(-) > >

Re: [Mesa-dev] [PATCH 1/2] configure: check if -latomic is needed for __atomic_*

Oh, also, these should get a Cc: mesa-stable tag. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] st/dri: Add an option to always request a front buffer from the loader

On 09/18/2017 12:43 PM, Eric Anholt wrote: Thomas Hellstrom writes: When an application decides to read from the front buffer of a window, typically a fake front is created and initialized with the real front window contents. However, if there was a window manager

Re: [Mesa-dev] [PATCH] r600: fork and import gallium/radeon

Has anyone ran full piglit on these with r600? Copy-paste bugs are very easy to introduce. Gražvydas On Mon, Sep 18, 2017 at 7:32 PM, Marek Olšák wrote: > Latest version with an updated commit message: >

Re: [Mesa-dev] [PATCH] st/dri: Add an option to always request a front buffer from the loader

Thomas Hellstrom writes: > When an application decides to read from the front buffer of a window, > typically a fake front is created and initialized with the real front window > contents. However, if there was a window manager reparenting operation between > the last

Re: [Mesa-dev] [PATCH] r600: fork and import gallium/radeon

It wasn't copy-paste, it was "cp". Marek On Mon, Sep 18, 2017 at 9:42 PM, Grazvydas Ignotas wrote: > Has anyone ran full piglit on these with r600? Copy-paste bugs are > very easy to introduce. > > Gražvydas > > On Mon, Sep 18, 2017 at 7:32 PM, Marek Olšák

Re: [Mesa-dev] [PATCH 1/2] configure: check if -latomic is needed for __atomic_*

On Mon, Sep 18, 2017 at 12:28 PM, Grazvydas Ignotas wrote: > On some platforms, gcc generates library calls when __atomic_* functions > are used, but does not link the required library automatically. Detect > this and add the library when needed. > > This change was tested on

Re: [Mesa-dev] [PATCH 20/20] anv: Implement VK_ANDROID_native_buffer (v2)

On Fri 15 Sep 2017, zhoucm1 wrote: > > > On 2017年09月14日 07:03, Chad Versace wrote: > > From: Chad Versace > > > > This implementation is correct (afaict), but takes two shortcuts > > regarding the import/export of Android sync fds. > > > >Shortcut 1. When Android

Re: [Mesa-dev] [PATCH 20/20 v4]] anv: Implement VK_ANDROID_native_buffer (v4)

On Fri 15 Sep 2017, Tapani Pälli wrote: > > > On 09/15/2017 01:06 AM, Chad Versace wrote: > > v3: > >- Delete duplicate #include "anv_private.h". [per Tapani] > >- Try to fix the Android-IA build in Android.vulkan.mk by following > > Tapani's example in > > > >

[Mesa-dev] [PATCH] anv: Implement VK_ANDROID_native_buffer (v5)

This implementation is correct (afaict), but takes two shortcuts regarding the import/export of Android sync fds. Shortcut 1. When Android calls vkAcquireImageANDROID to import a sync fd into a VkSemaphore or VkFence, the driver instead simply blocks on the sync fd, then puts the

[Mesa-dev] [PATCH] i965: Don't reset aux_state on buffers without modifiers

On gen7-8 where we use CCS_D, we were setting AUX_STATE_AUX_INVALID because that's the obvious aux state when there is no modifier. However, this doesn't work because that aux state isn't compatible with CCS_D. Cc: Chad Versace --- src/intel/isl/isl.h

Re: [Mesa-dev] [PATCH 3/3] radv: Don't use a virtual function for getting the buffer virtual address.

With Dave's comment applied, series is: Reviewed-by: Samuel Pitoiset On 09/17/2017 12:59 PM, Bas Nieuwenhuizen wrote: We are really not going to use a winsys which does not need to store the va, so might as well store it in a standard field. Not sure this helps

[Mesa-dev] [PATCH 1/2] glsl: move loop analysis helper to loop_analysis.cpp

--- src/compiler/glsl/loop_analysis.cpp | 139 src/compiler/glsl/loop_analysis.h | 7 -- src/compiler/glsl/loop_controls.cpp | 139 3 files changed, 139 insertions(+), 146 deletions(-) diff --git

  1   2   >