[Mesa-dev] [Bug 103323] Possible unintended error message in file pixel.c line 286

2017-10-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103323 Petru Mihancea changed: What|Removed |Added Severity|normal |trivial

[Mesa-dev] [PATCH] anv: Fix instance typos.

2017-10-18 Thread Vinson Lee
Fix build error. CC vulkan/vulkan_libvulkan_common_la-anv_device.lo In file included from vulkan/anv_device.c:33:0: vulkan/anv_device.c: In function ‘anv_AllocateMemory’: vulkan/anv_device.c:1562:37: error: ‘struct anv_device’ has no member named ‘instace’; did you mean ‘instance’?

Re: [Mesa-dev] [PATCH v2] r600/sb: bail out if prepare_alu_group() doesn't find a proper scheduling

2017-10-18 Thread Vadim Girlin
On 10/16/2017 10:06 PM, Gert Wollny wrote: It is possible that the optimizer ends up in an infinite loop in post_scheduler::schedule_alu(), because post_scheduler::prepare_alu_group() does not find a proper scheduling. This can be deducted from pending.count() being larger than zero and not

Re: [Mesa-dev] [PATCH] i965: Do not log a perf warning when mapping an idle bo

2017-10-18 Thread Chris Wilson
Quoting Chris Wilson (2017-10-18 09:53:27) > We only want to scare the user away from causing a GPU stall for mapping > a busy bo. The time taken to instantiate the set of pages for a buffer > and their mmapping is unavoidable and flagging idle bo as being busy is > "crying wolf". > >

Re: [Mesa-dev] Upstream support for FreeSync / Adaptive Sync

2017-10-18 Thread Nicolai Hähnle
On 17.10.2017 21:53, Ville Syrjälä wrote: On Tue, Oct 17, 2017 at 09:00:56PM +0200, Nicolai Hähnle wrote: On 17.10.2017 16:09, Ville Syrjälä wrote: On Tue, Oct 17, 2017 at 03:46:24PM +0200, Michel Dänzer wrote: On 17/10/17 02:22 PM, Daniel Vetter wrote: On Tue, Oct 17, 2017 at 12:28:17PM

[Mesa-dev] [Bug 103323] Possible unintended error message in file pixel.c line 286

2017-10-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103323 Bug ID: 103323 Summary: Possible unintended error message in file pixel.c line 286 Product: Mesa Version: git Hardware: Other OS: All Status:

Re: [Mesa-dev] [PATCH v2 2/8] egl: refactor color_buffers structure for deduplicating

2017-10-18 Thread Emil Velikov
On 17 October 2017 at 21:49, Gurchetan Singh wrote: > Can you wrap color_buffers around: > > #if defined(HAVE_WAYLAND_PLATFORM) || defined(HAVE_DRM_PLATFORM) || > defined(HAVE_ANDROID_PLATFORM) > > flags? This is because platform_surfaceless has no native surfaces

Re: [Mesa-dev] [PATCH] egl/wayland: Support for KHR_partial_update

2017-10-18 Thread Eric Engestrom
On Wednesday, 2017-10-18 06:06:45 +, Harish Krupo wrote: > Hi Eric, > > Eric Engestrom writes: > > I might need to double check the spec, but I thought "no damage hint" > > meant "no way to reduce the update, redraw the whole screen"? > > > > If that's the case, then

[Mesa-dev] [PATCH 2/3] i965: Remove packing restrictions for tiled-memcpy

2017-10-18 Thread Chris Wilson
Use the core unpacking functions to convert the gl_pixelstore_attrib into the real pixel address required for copying; thereby removing the restrictions that the tiled-memcpy could only handle exactly matching image transfers. Cc: Matt Turner Cc: Kenneth Graunke

[Mesa-dev] [PATCH 1/3] i965: Support very simple expansion options for tiled memcpy

2017-10-18 Thread Chris Wilson
A big limitation of the current direct memcpy routine is that it only recognises a couple of (admittedly) common colour types, and cannot do any inline conversion. If we pass the mesa_format down to memcpy and tell it the direction of the transfer, we can start accepting a few mixed transfers and

[Mesa-dev] [PATCH 3/3] i965: Support direct upload into texture arrays

2017-10-18 Thread Chris Wilson
Iterate the tiled_memcpy for each face so that we can quickly do synchronous uploads into cube maps etc. Cc: Matt Turner Cc: Kenneth Graunke --- src/mesa/drivers/dri/i965/intel_tex_image.c | 60 + 1 file changed, 36

[Mesa-dev] i965: tiled-memcpy + subimages

2017-10-18 Thread Chris Wilson
I noticed when enabling "accelerated readback" with userptr enabling writes directly into client memory was that we often missed the tiled-memcpy fastpaths; in particular it did not handle subimages. Since I was relying on the tiled-memcpy fastpath to avoid using the GPU for readback where

[Mesa-dev] [PATCH v4] automake: intel: move expat handling where it's used

2017-10-18 Thread Hongxu Jia
Linking libvulkan_intel.so can fail, due to unresolved references to libexpat.so. EXPAT_CFLAGS should be moved as well. Signed-off-by: Hongxu Jia --- src/intel/Makefile.common.am | 3 ++- src/intel/Makefile.tools.am | 4 2 files changed, 2 insertions(+), 5

[Mesa-dev] [Bug 103332] glDrawArrays does not take the "first" argument into account

2017-10-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103332 --- Comment #1 from Laurent Renard --- I have tested with modified version of the tutorial found here : http://www.opengl-tutorial.org/beginners-tutorials/tutorial-5-a-textured-cube/ Modifying the command // Draw the

Re: [Mesa-dev] Upstream support for FreeSync / Adaptive Sync

2017-10-18 Thread Nicolai Hähnle
On 18.10.2017 10:10, Daniel Vetter wrote: On Tue, Oct 17, 2017 at 09:01:52PM +0200, Nicolai Hähnle wrote: On 17.10.2017 19:16, Daniel Vetter wrote: On Tue, Oct 17, 2017 at 5:40 PM, Michel Dänzer wrote: On 17/10/17 05:04 PM, Daniel Vetter wrote: On Tue, Oct 17, 2017 at

Re: [Mesa-dev] [PATCH] radv: don't create dummy fs when compiling compute stage

2017-10-18 Thread Bas Nieuwenhuizen
r-b On Wed, Oct 18, 2017 at 5:02 AM, Timothy Arceri wrote: > Fixes: d1c9f30d7ff7 "radv: add radv_create_shaders() helper" > --- > src/amd/vulkan/radv_pipeline.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/amd/vulkan/radv_pipeline.c

Re: [Mesa-dev] [PATCH v2 1/8] egl: add dri2_egl_surface_free_outdated_buffers_and_update_size() helper (v2)

2017-10-18 Thread Emil Velikov
On 17 October 2017 at 21:38, Gurchetan Singh wrote: > The naming is verbose and somewhat inconsistent. We have: > > dri2_init_surface > dri2_fini_surface > dri2_egl_surface_alloc_local_buffer > dri2_egl_surface_free_local_buffers > > I suggest you implement the

Re: [Mesa-dev] [PATCH] docs: add documentation for building with meson

2017-10-18 Thread Eric Engestrom
On Tuesday, 2017-10-17 19:21:10 +, Dylan Baker wrote: > Signed-off-by: Dylan Baker > --- > > I'm sending this out now so that others can look at it, review it, and > reference > it, but this should not end up in the 17.3 release, as the meson build for > mesa >

Re: [Mesa-dev] [PATCH] docs: add documentation for building with meson

2017-10-18 Thread Emil Velikov
On 17 October 2017 at 20:21, Dylan Baker wrote: > Signed-off-by: Dylan Baker > --- > > I'm sending this out now so that others can look at it, review it, and > reference > it, but this should not end up in the 17.3 release, as the meson build for

Re: [Mesa-dev] [PATCH v3 1/4] nir: set default lod to texture opcodes that needed it but don't provide it

2017-10-18 Thread Lionel Landwerlin
Thanks again! Reviewed-by: Lionel Landwerlin On 18/10/17 08:54, Samuel Iglesias Gonsálvez wrote: v2: - Use helper to add a new source to the texture instruction. Signed-off-by: Samuel Iglesias Gonsálvez ---

[Mesa-dev] [PATCH mesa] meson: move expat dependency where it's needed

2017-10-18 Thread Eric Engestrom
Suggested-by: Lionel Landwerlin Signed-off-by: Eric Engestrom --- src/intel/common/meson.build | 2 +- src/intel/tools/meson.build | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/common/meson.build

Re: [Mesa-dev] Upstream support for FreeSync / Adaptive Sync

2017-10-18 Thread Daniel Vetter
On Tue, Oct 17, 2017 at 09:01:52PM +0200, Nicolai Hähnle wrote: > On 17.10.2017 19:16, Daniel Vetter wrote: > > On Tue, Oct 17, 2017 at 5:40 PM, Michel Dänzer wrote: > > > On 17/10/17 05:04 PM, Daniel Vetter wrote: > > > > On Tue, Oct 17, 2017 at 03:46:24PM +0200, Michel

[Mesa-dev] [Bug 103332] glDrawArrays does not take the "first" argument into account

2017-10-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103332 Bug ID: 103332 Summary: glDrawArrays does not take the "first" argument into account Product: Mesa Version: 17.2 Hardware: Other OS: Linux (All)

[Mesa-dev] [Bug 103332] glDrawArrays does not take the "first" argument into account

2017-10-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103332 Laurent Renard changed: What|Removed |Added CC|

[Mesa-dev] [PATCH v3 3/4] i965/vec4: remove setting default LOD in the backend

2017-10-18 Thread Samuel Iglesias Gonsálvez
It is already done in NIR. Signed-off-by: Samuel Iglesias Gonsálvez Reviewed-by: Lionel Landwerlin --- src/intel/compiler/brw_vec4_nir.cpp | 9 - src/intel/compiler/brw_vec4_visitor.cpp | 12 2 files changed, 21

[Mesa-dev] [PATCH v3 2/4] i965/fs: remove setting default LOD in the backend

2017-10-18 Thread Samuel Iglesias Gonsálvez
It is already done in NIR. Signed-off-by: Samuel Iglesias Gonsálvez Reviewed-by: Lionel Landwerlin --- src/intel/compiler/brw_fs_nir.cpp | 9 - 1 file changed, 9 deletions(-) diff --git a/src/intel/compiler/brw_fs_nir.cpp

[Mesa-dev] [PATCH v3 1/4] nir: set default lod to texture opcodes that needed it but don't provide it

2017-10-18 Thread Samuel Iglesias Gonsálvez
v2: - Use helper to add a new source to the texture instruction. Signed-off-by: Samuel Iglesias Gonsálvez --- src/compiler/nir/nir_lower_tex.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/src/compiler/nir/nir_lower_tex.c

[Mesa-dev] [PATCH v3 4/4] spirv: add support for images and samplers as function arguments

2017-10-18 Thread Samuel Iglesias Gonsálvez
Fixes: dEQP-VK.spirv_assembly.instruction.*.image_sampler.* Signed-off-by: Samuel Iglesias Gonsálvez --- src/compiler/spirv/vtn_cfg.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/compiler/spirv/vtn_cfg.c b/src/compiler/spirv/vtn_cfg.c index

Re: [Mesa-dev] Upstream support for FreeSync / Adaptive Sync

2017-10-18 Thread Michel Dänzer
On 18/10/17 10:10 AM, Daniel Vetter wrote: > On Tue, Oct 17, 2017 at 09:01:52PM +0200, Nicolai Hähnle wrote: >> On 17.10.2017 19:16, Daniel Vetter wrote: >>> On Tue, Oct 17, 2017 at 5:40 PM, Michel Dänzer wrote: On 17/10/17 05:04 PM, Daniel Vetter wrote: > On Tue, Oct

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/2] auxiliary: use vl_drm_screen_create method for surfaceless

2017-10-18 Thread Guttula, Suresh
On 11 October 2017 at 07:13, Guttula, Suresh > wrote: > HI, > >>- why do we need "surfaceless" support >ChromeOS supports surfacelsess and we need this va enablement for > surfaceless in chromium. Ack, that should have been part of the

[Mesa-dev] [PATCH] i965: Do not log a perf warning when mapping an idle bo

2017-10-18 Thread Chris Wilson
We only want to scare the user away from causing a GPU stall for mapping a busy bo. The time taken to instantiate the set of pages for a buffer and their mmapping is unavoidable and flagging idle bo as being busy is "crying wolf". Reported-by: Tvrtko Ursulin Cc: Kenneth

Re: [Mesa-dev] [PATCH] egl/wayland: Support for KHR_partial_update

2017-10-18 Thread Harish Krupo
Hi Eric, Eric Engestrom writes: > On Wednesday, 2017-10-18 06:06:45 +, Harish Krupo wrote: >> Hi Eric, >> >> Eric Engestrom writes: >> > I might need to double check the spec, but I thought "no damage hint" >> > meant "no way to reduce the

Re: [Mesa-dev] [PATCH] anv: Fix instance typos.

2017-10-18 Thread Eric Engestrom
On Wednesday, 2017-10-18 08:12:27 +, Vinson Lee wrote: > Fix build error. > > CC vulkan/vulkan_libvulkan_common_la-anv_device.lo > In file included from vulkan/anv_device.c:33:0: > vulkan/anv_device.c: In function ‘anv_AllocateMemory’: > vulkan/anv_device.c:1562:37: error: ‘struct

Re: [Mesa-dev] [PATCH v4] automake: intel: move expat handling where it's used

2017-10-18 Thread Lionel Landwerlin
If you feel like it, you could also fix the meson build :) Otherwise, this is : Reviewed-by: Lionel Landwerlin On 18/10/17 02:47, Hongxu Jia wrote: Linking libvulkan_intel.so can fail, due to unresolved references to libexpat.so. EXPAT_CFLAGS should be moved as

[Mesa-dev] [PATCH 3/4] i965: Remove the intel_miptree_prepare_fb_fetch wrapper.

2017-10-18 Thread Kenneth Graunke
Now that intel_miptree_prepare_texture takes levels and layers, there's not much use in this anymore. --- src/mesa/drivers/dri/i965/brw_draw.c | 6 -- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 14 -- src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 5 + 3 files

[Mesa-dev] [PATCH 2/4] i965: Only resolve texture levels/layers that are accessed.

2017-10-18 Thread Kenneth Graunke
This should avoid unnecessary resolves when working with texture views. --- src/mesa/drivers/dri/i965/brw_draw.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_draw.c b/src/mesa/drivers/dri/i965/brw_draw.c index

[Mesa-dev] [PATCH 4/4] i965: Don't disable aux buffers for non-overlapping miplevels.

2017-10-18 Thread Kenneth Graunke
Meta's GenerateMipmap implementation binds the same image for both sampling and rendering - but it samples from one miplevel while rendering the next. This is a false self-dependency, and there's no need to disable auxiliary buffers in this case. In fact, we really want to leave it enabled so

[Mesa-dev] [PATCH 1/4] i965: Make intel_miptree_prepare_texture() take level/layer arguments.

2017-10-18 Thread Kenneth Graunke
This effectively exports intel_miptree_prepare_texture_slices() as intel_miptree_prepare_texture(). The hope is to avoid resolves for when using texture views that access a subset of the levels/layers. For now, we pass the same arguments to separate the mechanical change from the one that

Re: [Mesa-dev] [PATCH v2] docs: add documentation for building with meson

2017-10-18 Thread Dylan Baker
Quoting Eric Engestrom (2017-10-18 15:27:39) > On Wednesday, 2017-10-18 18:09:22 +, Dylan Baker wrote: > > v2: - Add information about CC, CXX, CFLAGS, and CXXFLAGS (Nicolai) > > - Add message at top that meson for mesa is still a work in progress > > - Add trailing "/" to directories

[Mesa-dev] [PATCH 4/4] meson: Add support for EGL glvnd

2017-10-18 Thread Dylan Baker
Signed-off-by: Dylan Baker --- src/egl/meson.build | 46 -- 1 file changed, 44 insertions(+), 2 deletions(-) diff --git a/src/egl/meson.build b/src/egl/meson.build index ade6810bf91..8ea8a5bbb69 100644 ---

[Mesa-dev] [PATCH 3/4] meson: build libEGL

2017-10-18 Thread Dylan Baker
This is based heavily on Daniel Stone's work for the same, rebased on master and with a number of TODO's fixed. This does not implement glvnd (which is coming in a later patch) Meson builds egl slightly differently than autotools, namely it doesn't build an intermediate shared library. It

[Mesa-dev] [PATCH 1/4] meson: Don't allow glx to be built without platform_x11

2017-10-18 Thread Dylan Baker
Previously this failed to change with_glx to disabled from auto if platform_x11 was unset or if no opengl apis were being built. Signed-off-by: Dylan Baker --- meson.build | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/meson.build

[Mesa-dev] [PATCH 0/4] meson egl support

2017-10-18 Thread Dylan Baker
This small series adds support to the meson build system for building EGL in both the glvnd and traditional configurations. I have tested it against the i965 using piglit and didn't see any regressions in the egl tests. This work is based on work that Daniel Stone started, although I rewrote the

[Mesa-dev] [PATCH 2/4] meson: move wayland_drm_protocol generation to wayland-drm

2017-10-18 Thread Dylan Baker
These files are needed by both vulkan wayland-wsi and by egl wayland-wsi, since the XML file is in src/egl/wayland/wayland-drm and we can include this directory in such a way that it will be loaded before egl and vulkan this allows us to avoid multiple calls to the same generator. Signed-off-by:

Re: [Mesa-dev] [PATCH 1/4] meson: Don't allow glx to be built without platform_x11

2017-10-18 Thread Eric Engestrom
On Wednesday, 2017-10-18 23:56:05 +, Dylan Baker wrote: > Previously this failed to change with_glx to disabled from auto if > platform_x11 was unset or if no opengl apis were being built. > > Signed-off-by: Dylan Baker > --- > meson.build | 8 ++-- > 1 file

Re: [Mesa-dev] [PATCH 2/2] i965: Use is_scheduling_barrier instead of schedule_node::is_barier.

2017-10-18 Thread Dylan Baker
typo in subject "is_barier" -> "is_barrier" Quoting Kenneth Graunke (2017-10-18 16:59:12) > Commit a73116ecc60414ade89802150b tried to make add_barrier_deps() > walk to the next barrier, and stop. To accomplish that, it added an > is_barrier flag. Unfortunately, this only works half of the

[Mesa-dev] [PATCH v2 05/32] glsl: Zero per_vertex_accumulator::fields for valgrind & nir_serialize

2017-10-18 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/compiler/glsl/builtin_variables.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compiler/glsl/builtin_variables.cpp b/src/compiler/glsl/builtin_variables.cpp index ea2d897cc8..d3cf12475b 100644 ---

[Mesa-dev] [PATCH v2 07/32] intel/nir: Zero local index const struct for valgrind & nir_serialize

2017-10-18 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/intel/compiler/brw_nir_lower_cs_intrinsics.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/intel/compiler/brw_nir_lower_cs_intrinsics.c b/src/intel/compiler/brw_nir_lower_cs_intrinsics.c index f9322654e7..d27727624c

[Mesa-dev] [PATCH v2 02/32] nir: Get rid of nir_shader::stage

2017-10-18 Thread Jordan Justen
From: Jason Ekstrand It's redundant with nir_shader::info::stage. --- src/amd/common/ac_nir_to_llvm.c| 30 ++--- src/amd/common/ac_shader_info.c| 2 +- src/amd/vulkan/radv_shader.c | 4 +-

[Mesa-dev] [PATCH v2 00/32] i965 disk shader cache

2017-10-18 Thread Jordan Justen
git://people.freedesktop.org/~jljusten/mesa i965-shader-cache-v2 The series adds support for a disk shader cache for i965, but it does not enable it by default. To enable the i965 shader cache you need to set the environment variable MESA_GLSL_CACHE_DISABLE=0. v2: * Fallback now uses Connor &

[Mesa-dev] [PATCH v2 19/32] i965: Add shader cache support for vertex and fragment stages

2017-10-18 Thread Jordan Justen
From: Timothy Arceri This enables the cache on vertex and fragment shaders only. v2: * Use MAYBE_UNUSED. (Matt) [jordan.l.jus...@intel.com: reword subject] [jordan.l.jus...@intel.com: *_cached_program => brw_disk_cache_*_program] Signed-off-by: Jordan Justen

[Mesa-dev] [PATCH v2 01/32] glsl: move shader_cache type handling to glsl_types

2017-10-18 Thread Jordan Justen
From: Connor Abbott Not sure if this is the best place to put it, but we're going to need this for NIR too. --- src/compiler/glsl/shader_cache.cpp | 171 - src/compiler/glsl_types.cpp| 171 +

[Mesa-dev] [PATCH 16/16] radv: Modify rsrc1/rsrc2 generation for merged tess.

2017-10-18 Thread Bas Nieuwenhuizen
No OC_LDS_EN for HS, and the included LS vgpr_comp_cnt is at a different offset. --- src/amd/vulkan/radv_shader.c | 23 --- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/src/amd/vulkan/radv_shader.c b/src/amd/vulkan/radv_shader.c index a7836543998..a86ba2a01c0

[Mesa-dev] [PATCH 09/16] ac/nir: Compile the bodies of multiple shaders.

2017-10-18 Thread Bas Nieuwenhuizen
--- src/amd/common/ac_nir_to_llvm.c | 133 +--- 1 file changed, 83 insertions(+), 50 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 67945a353e8..cb011bd88bb 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++

[Mesa-dev] [PATCH 12/16] radv: Update GFX9 user data regs for GS/tess.

2017-10-18 Thread Bas Nieuwenhuizen
--- src/amd/vulkan/radv_cmd_buffer.c | 14 +++--- src/amd/vulkan/radv_pipeline.c | 2 +- src/amd/vulkan/radv_shader.c | 19 +++ src/amd/vulkan/radv_shader.h | 4 ++-- 4 files changed, 25 insertions(+), 14 deletions(-) diff --git

[Mesa-dev] [PATCH 10/16] ac/nir: Add LS-HS input VGPR workaround.

2017-10-18 Thread Bas Nieuwenhuizen
--- src/amd/common/ac_nir_to_llvm.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index cb011bd88bb..242675654d2 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/amd/common/ac_nir_to_llvm.c @@

[Mesa-dev] [PATCH 14/16] radv: Add GFX9 HS emitting code.

2017-10-18 Thread Bas Nieuwenhuizen
--- src/amd/vulkan/radv_cmd_buffer.c | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index 3e31fbafd34..a746777ca40 100644 --- a/src/amd/vulkan/radv_cmd_buffer.c +++

[Mesa-dev] [PATCH 13/16] radv: Remove remaining hard coded references to VS.

2017-10-18 Thread Bas Nieuwenhuizen
--- src/amd/vulkan/radv_cmd_buffer.c | 19 ++- src/amd/vulkan/radv_pipeline.c | 14 -- src/amd/vulkan/radv_private.h| 2 ++ 3 files changed, 28 insertions(+), 7 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index

[Mesa-dev] [PATCH 15/16] radv: Set correct registers for merged shader rings.

2017-10-18 Thread Bas Nieuwenhuizen
We need different regs to end up in s0/s1. --- src/amd/vulkan/radv_device.c | 36 1 file changed, 24 insertions(+), 12 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index fd705fe726d..125498809ec 100644 ---

[Mesa-dev] [PATCH 02/16] ac/nir: Add HS calling convention.

2017-10-18 Thread Bas Nieuwenhuizen
Needed for GFX9 merged shaders. --- src/amd/common/ac_nir_to_llvm.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 3ba3ebf051e..1df97b59a2e 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++

[Mesa-dev] [PATCH v2 12/32] nir: Add hooks for testing serialization

2017-10-18 Thread Jordan Justen
From: Jason Ekstrand --- src/compiler/nir/nir.h | 17 + src/compiler/nir/nir_serialize.c | 19 +++ 2 files changed, 36 insertions(+) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index dd833cf183..87c725625d

[Mesa-dev] [PATCH v2 11/32] nir: add serialization and deserialization

2017-10-18 Thread Jordan Justen
From: Connor Abbott v2 (Jason Ekstrand): - Various whitespace cleanups - Add helpers for reading/writing objects - Rework derefs - [de]serialize nir_shader::num_* - Fix uses of blob_reserve_bytes - Use a bitfield struct for packing tex_instr data v3: - Zero

[Mesa-dev] [PATCH v2 25/32] i965: add cache fallback support using serialized nir

2017-10-18 Thread Jordan Justen
If the i965 gen program cannot be loaded from the cache, then we fallback to using a serialized nir program. This is based on "i965: add cache fallback support" by Timothy Arceri . Tim's version was written to fallback to compiling from source, and therefore had to

[Mesa-dev] [PATCH v2 17/32] intel/compiler: add new field for storing program size

2017-10-18 Thread Jordan Justen
From: Carl Worth This will be used by the on disk shader cache. v2: * Set in brw_compile_* rather than brw_codegen_*. (Jason) Signed-off-by: Timothy Arceri [jordan.l.jus...@intel.com: Only add to brw_stage_prog_data] Signed-off-by: Jordan

[Mesa-dev] [PATCH v2 08/32] nir: Zero nir_load_const_instr::value for valgrind & nir_serialize

2017-10-18 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/compiler/nir/nir.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compiler/nir/nir.c b/src/compiler/nir/nir.c index fe48451694..cbba9c8749 100644 --- a/src/compiler/nir/nir.c +++ b/src/compiler/nir/nir.c @@ -481,6 +481,7 @@

[Mesa-dev] [PATCH v2 27/32] i965: Initialize sha1 hash of dri config options

2017-10-18 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_context.c | 4 src/mesa/drivers/dri/i965/brw_context.h | 1 + 2 files changed, 5 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c index

[Mesa-dev] [PATCH v2 16/32] i965: Don't rely on nir for uses_texture_gather

2017-10-18 Thread Jordan Justen
When a program is restored from the shader cache, prog->nir will be NULL, but prog->info will be restored. Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_wm.c | 4 ++-- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 12 ++--

[Mesa-dev] [PATCH v2 14/32] glsl/shader_cache: Save and restore serialized nir in gl_program

2017-10-18 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/compiler/glsl/shader_cache.cpp | 16 1 file changed, 16 insertions(+) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index ca90cfde35..f43bd6b17e 100644 ---

[Mesa-dev] [PATCH v2 09/32] glsl_to_nir: Zero nir_variable struct for valgrind & nir_serialize

2017-10-18 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/compiler/glsl/glsl_to_nir.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/glsl_to_nir.cpp b/src/compiler/glsl/glsl_to_nir.cpp index 63694fd41f..1d1085ffbc 100644 ---

[Mesa-dev] [PATCH v2 18/32] i965: add initial implementation of on disk shader cache

2017-10-18 Thread Jordan Justen
From: Timothy Arceri This uses the recently-added disk_cache.c to write out the final linked binary for vertex and fragment shader programs. This is based off the initial implementation done by Carl Worth. v2: * Squash 'i965: add image param shader cache support'

[Mesa-dev] [PATCH v2 21/32] i965: add shader cache support for tess stages

2017-10-18 Thread Jordan Justen
From: Timothy Arceri v2: * Use MAYBE_UNUSED. (Matt) [jordan.l.jus...@intel.com: *_cached_program => brw_disk_cache_*_program] Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_disk_cache.c | 49

[Mesa-dev] [PATCH v2 30/32] dri drivers: Always add the sha1 build-id

2017-10-18 Thread Jordan Justen
Cc: Dylan Baker Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/Makefile.am | 1 + src/mesa/drivers/dri/meson.build | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/Makefile.am

[Mesa-dev] [PATCH v2 06/32] nir: Zero local_size const struct for valgrind & nir_serialize

2017-10-18 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/compiler/nir/nir_lower_system_values.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compiler/nir/nir_lower_system_values.c b/src/compiler/nir/nir_lower_system_values.c index ba20d3083f..39b1a260bd 100644 ---

[Mesa-dev] [PATCH v2 15/32] i965/link: Serialize program to nir after linking for shader cache

2017-10-18 Thread Jordan Justen
If the shader cache is enabled, after linking the program, we serialize the program to nir. This will be saved out by the glsl shader cache support. Later, if the same program is found in the cache, we can use the nir for a fallback in the unlikely case that the gen binary program is not found in

[Mesa-dev] [PATCH v2 10/32] glsl_to_nir: Zero nir_constant in constant_copy for valgrind & nir_serialize

2017-10-18 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/compiler/glsl/glsl_to_nir.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/glsl_to_nir.cpp b/src/compiler/glsl/glsl_to_nir.cpp index 1d1085ffbc..c659a25ca7 100644 ---

[Mesa-dev] [PATCH v2 13/32] main: Add nir serialization fields to gl_program

2017-10-18 Thread Jordan Justen
These fields can be used to optionally save off a nir serialized form of the program. Signed-off-by: Jordan Justen --- src/mesa/main/mtypes.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index

Re: [Mesa-dev] [PATCH 2/2] i965: Use is_scheduling_barrier instead of schedule_node::is_barier.

2017-10-18 Thread Matt Turner
On Wed, Oct 18, 2017 at 4:59 PM, Kenneth Graunke wrote: > Commit a73116ecc60414ade89802150b tried to make add_barrier_deps() > walk to the next barrier, and stop. To accomplish that, it added an > is_barrier flag. Unfortunately, this only works half of the time. > > The

[Mesa-dev] [PATCH 05/16] ac/nir: Make scan_shader_output_decl less dependent on the context.

2017-10-18 Thread Bas Nieuwenhuizen
--- src/amd/common/ac_nir_to_llvm.c | 31 +-- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 38f47b34e10..f01ca8799b9 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++

[Mesa-dev] [PATCH 08/16] ac/nir: Expand user SGPR descriptions a bit.

2017-10-18 Thread Bas Nieuwenhuizen
To prevent VS/TCS collisions in merged shaders. --- src/amd/common/ac_nir_to_llvm.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.h b/src/amd/common/ac_nir_to_llvm.h index 66d539dec47..360d613d58d 100644 ---

[Mesa-dev] [PATCH 03/16] ac/nir: Change interface to allow multiple source shaders.

2017-10-18 Thread Bas Nieuwenhuizen
--- src/amd/common/ac_nir_to_llvm.c | 82 ++--- src/amd/common/ac_nir_to_llvm.h | 3 +- src/amd/vulkan/radv_shader.c| 2 +- 3 files changed, 48 insertions(+), 39 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c

[Mesa-dev] [PATCH 01/16] ac: Parse the new HS RSRC1 register.

2017-10-18 Thread Bas Nieuwenhuizen
--- src/amd/common/ac_binary.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/amd/common/ac_binary.c b/src/amd/common/ac_binary.c index 1bf52c78328..cf0125c415f 100644 --- a/src/amd/common/ac_binary.c +++ b/src/amd/common/ac_binary.c @@ -252,6 +252,7 @@ void

[Mesa-dev] [PATCH 06/16] ac/nir: Add function creation for merged LS+HS.

2017-10-18 Thread Bas Nieuwenhuizen
--- src/amd/common/ac_nir_to_llvm.c | 254 1 file changed, 178 insertions(+), 76 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index f01ca8799b9..c6c56f30b81 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++

[Mesa-dev] [PATCH 07/16] ac/nir: Don't write to the dynamic HS word on GFX9.

2017-10-18 Thread Bas Nieuwenhuizen
--- src/amd/common/ac_nir_to_llvm.c | 27 --- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index c6c56f30b81..67945a353e8 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++

[Mesa-dev] [PATCH 04/16] ac/nir: Allow ac_shader_variant_info to contain info about multiple stages.

2017-10-18 Thread Bas Nieuwenhuizen
--- src/amd/common/ac_nir_to_llvm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/common/ac_nir_to_llvm.h b/src/amd/common/ac_nir_to_llvm.h index 8a1e64ce7e1..66d539dec47 100644 --- a/src/amd/common/ac_nir_to_llvm.h +++ b/src/amd/common/ac_nir_to_llvm.h @@ -154,7

[Mesa-dev] [PATCH 11/16] radv: Add code to compile merged shaders.

2017-10-18 Thread Bas Nieuwenhuizen
--- src/amd/common/ac_nir_to_llvm.h | 1 + src/amd/vulkan/radv_pipeline.c | 29 + src/amd/vulkan/radv_shader.c| 17 ++--- src/amd/vulkan/radv_shader.h| 5 +++-- 4 files changed, 39 insertions(+), 13 deletions(-) diff --git

[Mesa-dev] [PATCH] radv: fix CLEAR_STATE packet length.

2017-10-18 Thread Dave Airlie
From: Dave Airlie Looking at shader traces I noticed some registers were missing, one of them was being eaten by the wrong clear state length. Fixes: 4f42ea4dc (radv: use CLEAR_STATE for initializing some registers) Signed-off-by: Dave Airlie ---

Re: [Mesa-dev] [PATCH 04/21] intel: Rewrite the world of push/pull params

2017-10-18 Thread Matt Turner
On Fri, Sep 29, 2017 at 2:25 PM, Jason Ekstrand wrote: > diff --git a/src/mesa/drivers/dri/i965/gen6_constant_state.c > b/src/mesa/drivers/dri/i965/gen6_constant_state.c > index b2e357f..93a12c7 100644 > --- a/src/mesa/drivers/dri/i965/gen6_constant_state.c > +++

Re: [Mesa-dev] Upstream support for FreeSync / Adaptive Sync

2017-10-18 Thread Manasi Navare
On Wed, Oct 18, 2017 at 03:20:57PM -0400, Harry Wentland wrote: > On 2017-10-18 04:10 AM, Daniel Vetter wrote: > > On Tue, Oct 17, 2017 at 09:01:52PM +0200, Nicolai Hähnle wrote: > >> On 17.10.2017 19:16, Daniel Vetter wrote: > >>> On Tue, Oct 17, 2017 at 5:40 PM, Michel Dänzer

Re: [Mesa-dev] [PATCH 2/2] drirc: Group a few games in the glthread whitelist together.

2017-10-18 Thread Marek Olšák
I pushed the series, thanks! Marek On Mon, Oct 16, 2017 at 12:22 AM, Darren Salt wrote: > --- > src/util/drirc | 27 +-- > 1 file changed, 21 insertions(+), 6 deletions(-) > > diff --git a/src/util/drirc b/src/util/drirc > index

Re: [Mesa-dev] [PATCH 3/4] meson: build libEGL

2017-10-18 Thread Dylan Baker
Quoting Eric Engestrom (2017-10-18 17:25:05) > On Wednesday, 2017-10-18 23:56:00 +, Dylan Baker wrote: > > This is based heavily on Daniel Stone's work for the same, rebased on > > master and with a number of TODO's fixed. > > > > This does not implement glvnd (which is coming in a later

Re: [Mesa-dev] [PATCH 3/4] meson: build libEGL

2017-10-18 Thread Eric Engestrom
On Wednesday, 2017-10-18 23:56:00 +, Dylan Baker wrote: > This is based heavily on Daniel Stone's work for the same, rebased on > master and with a number of TODO's fixed. > > This does not implement glvnd (which is coming in a later patch) > > Meson builds egl slightly differently than

[Mesa-dev] [PATCH v2 04/32] compiler/types: Support [de]serializing void types

2017-10-18 Thread Jordan Justen
From: Jason Ekstrand --- src/compiler/glsl_types.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/compiler/glsl_types.cpp b/src/compiler/glsl_types.cpp index a7fc7ff7f6..704b63c5cf 100644 --- a/src/compiler/glsl_types.cpp +++ b/src/compiler/glsl_types.cpp

[Mesa-dev] [PATCH v2 23/32] mesa/glsl: add api_enabled flag to gl_transform_feedback_info

2017-10-18 Thread Jordan Justen
From: Timothy Arceri This will be used to disable the shader cache when xfb is enabled via the api as we don't currently allow for it when generating the sha for the shader. --- src/compiler/glsl/link_varyings.cpp | 5 - src/mesa/main/mtypes.h | 3

[Mesa-dev] [PATCH v2 31/32] i965: Initialize disk shader cache if MESA_GLSL_CACHE_DISABLE is false

2017-10-18 Thread Jordan Justen
Double negative FTW! For now, the shader cache is disabled by default on i965 to allow us to verify its stability. In other words, to enable the shader cache on i965, set MESA_GLSL_CACHE_DISABLE to false or 0. If the variable is unset, then the shader cache will be disabled. We use the build-id

[Mesa-dev] [PATCH v2 26/32] i965: Don't link when the program was found in the disk cache

2017-10-18 Thread Jordan Justen
Signed-off-by: Jordan Justen Cc: Timothy Arceri --- src/mesa/drivers/dri/i965/brw_link.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_link.cpp b/src/mesa/drivers/dri/i965/brw_link.cpp index

[Mesa-dev] [PATCH v2 29/32] disk_cache: Fix issue reading GLSL metadata

2017-10-18 Thread Jordan Justen
This would cause the read of the metadata content to fail, which would prevent the linking from being skipped. Seen on Rocket League with i965 shader cache. Cc: Timothy Arceri Signed-off-by: Jordan Justen --- src/util/disk_cache.c | 2 +- 1

[Mesa-dev] [PATCH v2 28/32] glsl/shader_cache: Save fs (BlendSupport) metadata

2017-10-18 Thread Jordan Justen
Fixes many GL 4.5 CTS blend tests, such as: * GL45-CTS.blend_equation_advanced.extension_directive_enable * GL45-CTS.blend_equation_advanced.extension_directive_warn * GL45-CTS.blend_equation_advanced.blend_all.GL_MULTIPLY_KHR_all_qualifier *

[Mesa-dev] [PATCH v2 24/32] i965: add support for cached shaders with xfb qualifiers

2017-10-18 Thread Jordan Justen
From: Timothy Arceri For now this disables the shader cache when transform feedback is enabled via the GL API as we don't currently allow for it when generating the sha for the shader. --- src/mesa/drivers/dri/i965/brw_disk_cache.c | 8 1 file changed, 8

[Mesa-dev] [PATCH v2 22/32] i965: Add shader cache support for compute

2017-10-18 Thread Jordan Justen
v2: * Use MAYBE_UNUSED. (Matt) Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_cs.c | 24 --- src/mesa/drivers/dri/i965/brw_cs.h | 3 +++ src/mesa/drivers/dri/i965/brw_disk_cache.c | 36

[Mesa-dev] [PATCH v2 03/32] nir/intrinsics: Set the correct num_indices for load_output

2017-10-18 Thread Jordan Justen
From: Jason Ekstrand Cc: mesa-sta...@lists.freedesktop.org --- src/compiler/nir/nir_intrinsics.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/nir/nir_intrinsics.h b/src/compiler/nir/nir_intrinsics.h index 0de7080bfa..cefd18be90

  1   2   3   >