Re: [Mesa-dev] [PATCH] egl/android: Provide an option for the backend to expose KHR_image

2017-12-08 Thread Daniel Stone
Hi Emil, On 7 December 2017 at 18:45, Emil Velikov wrote: > The KHR_image_pixmap extension lists the following as dependency: > > The EGL implementation must define an EGLNativePixmapType (although it > is not required either to export any EGLConfigs supporting

[Mesa-dev] [ANNOUNCE] mesa 17.3.0

2017-12-08 Thread Emil Velikov
Mesa 17.3.0 is now available. The release consists of approximately 2700 commits from over 120 developers. Feature wise, here are some of the highlights in this release: - The i965, nouveau (nvc0) and radeonsi are getting closer to OpenGL 4.6. - Multiple Vulkan extensions are supported by the

Re: [Mesa-dev] [PATCH] egl/android: Provide an option for the backend to expose KHR_image

2017-12-08 Thread Emil Velikov
On 8 December 2017 at 05:59, Tapani Pälli wrote: > > > On 12/07/2017 08:45 PM, Emil Velikov wrote: >> >> Hi Harish, >> >> On 7 December 2017 at 13:34, Harish Krupo >> wrote: >>> >>> From android cts 8.0_r4, a new test case checks if all the

Re: [Mesa-dev] [PATCH 17/29] anv/cmd_buffer: Move the color portion of clear_subpass into begin_subpass

2017-12-08 Thread Pohjolainen, Topi
On Mon, Nov 27, 2017 at 07:06:07PM -0800, Jason Ekstrand wrote: > This doesn't really change much now but it will give us more/better > control over clears in the future. The one interesting functional > change here is that we are now re-emitting 3DSTATE_DEPTH_BUFFERS and > friends for each

Re: [Mesa-dev] [PATCH 3/8] spirv: Add basic type validation for OpLoad, OpStore, and OpCopyMemory

2017-12-08 Thread Michael Schellenberger Costa
Hi Jason, Am 07.12.2017 um 17:12 schrieb Jason Ekstrand: --- src/compiler/spirv/vtn_variables.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/src/compiler/spirv/vtn_variables.c b/src/compiler/spirv/vtn_variables.c index cf44ed3..8ce19ff 100644 ---

Re: [Mesa-dev] [PATCH] egl/android: Provide an option for the backend to expose KHR_image

2017-12-08 Thread Harish Krupo
Hi Emil, Emil Velikov writes: > Hi Harish, > > On 7 December 2017 at 13:34, Harish Krupo wrote: >> From android cts 8.0_r4, a new test case checks if all the required egl >> extensions are exposed. In the current implementation we expose

[Mesa-dev] [PATCH 2/3] i965: add noise padding to buffer object and function to check if noise is correct

2017-12-08 Thread kevin . rogovin
From: Kevin Rogovin Signed-off-by: Kevin Rogovin --- src/mesa/drivers/dri/i965/brw_bufmgr.c | 68 +- src/mesa/drivers/dri/i965/brw_bufmgr.h | 12 ++ 2 files changed, 79 insertions(+), 1 deletion(-) diff

[Mesa-dev] [PATCH 0/3] GEM BO padding to find OOB buffer writes

2017-12-08 Thread kevin . rogovin
From: Kevin Rogovin This patch series adds a new debug option to pad each GEM BO allocated by the brw_bufmgr with random noise values which are then checked after each batchbuffer dispatch to the kernel. This can be quite valuable to find diffucult to track down

[Mesa-dev] [PATCH 1/3] intel/common:add debug flag for adding and checking padding on BO's

2017-12-08 Thread kevin . rogovin
From: Kevin Rogovin Signed-off-by: Kevin Rogovin --- src/intel/common/gen_debug.c | 1 + src/intel/common/gen_debug.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/intel/common/gen_debug.c b/src/intel/common/gen_debug.c index

[Mesa-dev] [PATCH 3/3] i965: if DEBUG_OUT_OF_BOUND_CHK is up, check that noise padding for each bo used in batchbuffer is correct

2017-12-08 Thread kevin . rogovin
From: Kevin Rogovin Signed-off-by: Kevin Rogovin --- src/mesa/drivers/dri/i965/intel_batchbuffer.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_batchbuffer.c

[Mesa-dev] [PATCH 2/5] st/glsl_to_tgsi: stop passing pipe_shader_state to st_store_tgsi_in_disk_cache()

2017-12-08 Thread Timothy Arceri
We can instead just get this from st_*_program. --- src/mesa/state_tracker/st_program.c | 6 +++--- src/mesa/state_tracker/st_shader_cache.c | 22 -- src/mesa/state_tracker/st_shader_cache.h | 3 +-- 3 files changed, 16 insertions(+), 15 deletions(-) diff --git

[Mesa-dev] [PATCH 5/5] st/glsl_to_tgsi: add ARB_get_program_binary support using TGSI

2017-12-08 Thread Timothy Arceri
This resolves a game bug in Deal Island. The game doesn't properly handle ARB_get_program_binary with 0 supported formats, and ends up crashing. This will enable ARB_get_program_binary binary support for any driver that currently enables the on-disk shader cache. Bugzilla:

[Mesa-dev] [PATCH 3/5] st/glsl_to_tgsi: add (de)serialise program helpers

2017-12-08 Thread Timothy Arceri
These will be shared between the on-disk shader cache and ARB_get_program_binary. --- src/mesa/state_tracker/st_shader_cache.c | 265 --- src/mesa/state_tracker/st_shader_cache.h | 8 + 2 files changed, 146 insertions(+), 127 deletions(-) diff --git

[Mesa-dev] [PATCH 1/5] st/glsl_to_tgsi: store num_tgsi_tokens in st_*_program

2017-12-08 Thread Timothy Arceri
We will need this for ARB_get_program_binary binary support. --- src/mesa/state_tracker/st_program.c | 21 - src/mesa/state_tracker/st_program.h | 12 src/mesa/state_tracker/st_shader_cache.c | 15 +-- src/mesa/state_tracker/st_shader_cache.h

[Mesa-dev] Gallium ARB_get_program_binary support

2017-12-08 Thread Timothy Arceri
Core support in now in master so this is just a resend of the gallium patches. Resolves crash in Dead Island: Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=85564 Branch available here: https://github.com/tarceri/Mesa.git gallium-program-binary

[Mesa-dev] [PATCH 4/5] st/glsl_to_tgsi: add st_get_program_binary_driver_sha1() helper

2017-12-08 Thread Timothy Arceri
This will be used by ARB_get_program_binary. --- src/mesa/state_tracker/st_shader_cache.c | 6 ++ src/mesa/state_tracker/st_shader_cache.h | 3 +++ 2 files changed, 9 insertions(+) diff --git a/src/mesa/state_tracker/st_shader_cache.c b/src/mesa/state_tracker/st_shader_cache.c index

Re: [Mesa-dev] [PATCH 1/9] i965/fs: Rewrite assign_constant_locations

2017-12-08 Thread Pohjolainen, Topi
On Thu, Dec 07, 2017 at 10:57:31AM -0800, Jason Ekstrand wrote: > On Thu, Dec 7, 2017 at 9:57 AM, Pohjolainen, Topi < > topi.pohjolai...@gmail.com> wrote: > > > On Thu, Dec 07, 2017 at 09:25:08AM -0800, Jason Ekstrand wrote: > > > On Thu, Dec 7, 2017 at 9:10 AM, Pohjolainen, Topi < > > >

Re: [Mesa-dev] [PATCH 1/9] i965/fs: Rewrite assign_constant_locations

2017-12-08 Thread Pohjolainen, Topi
On Wed, Dec 06, 2017 at 08:34:19PM -0800, Jason Ekstrand wrote: > This rewires the logic for assigning uniform locations to work in terms > of "complex alignments". The basic idea is that, as we walk the list of > instructions, we keep track of the alignment and continuity requirements > of each

[Mesa-dev] [PATCH] xlib: call _mesa_warning() instead of fprintf()

2017-12-08 Thread Brian Paul
We use _mesa_warning() everywhere else in this code. Change requested by Rick Irons of Mathworks. CC: --- src/mesa/drivers/x11/fakeglx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/x11/fakeglx.c

Re: [Mesa-dev] [PATCH] egl/android: Provide an option for the backend to expose KHR_image

2017-12-08 Thread Emil Velikov
On 8 December 2017 at 10:10, Harish Krupo wrote: > Hi Emil, > > Emil Velikov writes: > >> Hi Harish, >> >> On 7 December 2017 at 13:34, Harish Krupo wrote: >>> From android cts 8.0_r4, a new test case checks if

Re: [Mesa-dev] [PATCH 1/2] gallium/aux: include nr_samples in util_resource_size() computation

2017-12-08 Thread Emil Velikov
On 7 December 2017 at 22:25, Brian Paul wrote: > This function is only used in two places: > 1. VMware driver, but only for HUD reporting > 2. st/nine state tracker, used for texture memory accounting Brian, I'm not the person to review the code, i'm afraid :-\ Please add the

[Mesa-dev] [PATCH v2] egl/android: Provide an option for the backend to expose KHR_image

2017-12-08 Thread Harish Krupo
From android cts 8.0_r4, a new test case checks if all the required egl extensions are exposed. In the current implementation we expose KHR_image if KHR_image_base and KHR_image_pixmap are supported but KHR_image spec does not mandate the existence of both the extensions. This patch preserves the

Re: [Mesa-dev] [PATCH 1/9] i965/fs: Rewrite assign_constant_locations

2017-12-08 Thread Jason Ekstrand
On Fri, Dec 8, 2017 at 12:40 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Wed, Dec 06, 2017 at 08:34:19PM -0800, Jason Ekstrand wrote: > > This rewires the logic for assigning uniform locations to work in terms > > of "complex alignments". The basic idea is that, as we walk

Re: [Mesa-dev] [RFC PATCH] util/ralloc: make mem_ctx parameter const for all r*alloc functions

2017-12-08 Thread Gert Wollny
This one got lost ... Am Donnerstag, den 02.11.2017, 16:46 +0100 schrieb Nicolai Hähnle: > On 26.10.2017 13:02, Gert Wollny wrote: > > r(z)alloc_size and get_header both take a "const void *" for > > mem_ctx, > > but most of the other functions take a "void *" and also the "new" > > operator in

Re: [Mesa-dev] [PATCH] spirv: Fix loading an entire block at once.

2017-12-08 Thread Emil Velikov
On 3 December 2017 at 14:40, Bas Nieuwenhuizen wrote: > There is no chain, so checking the length ends with a SEGFAULT. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103579 > Cc: I'm not 100% sure if a missing chain does

Re: [Mesa-dev] [PATCH 1/9] i965/fs: Rewrite assign_constant_locations

2017-12-08 Thread Pohjolainen, Topi
On Fri, Dec 08, 2017 at 08:55:56AM -0800, Jason Ekstrand wrote: > On Fri, Dec 8, 2017 at 12:40 AM, Pohjolainen, Topi < > topi.pohjolai...@gmail.com> wrote: > > > On Wed, Dec 06, 2017 at 08:34:19PM -0800, Jason Ekstrand wrote: > > > This rewires the logic for assigning uniform locations to work in

[Mesa-dev] [Bug 100708] Trine 2 doesn't start on radeonsi on mesa 17

2017-12-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100708 --- Comment #10 from Nicholas Miell --- Trine 2 uses an SDL 1.3, which is an ancient predecessor to SDL 2. SDL 1.3 disables the screensaver by forking and running gnome-screensaver-command --inhibit. gnome-screensaver-command

[Mesa-dev] [Bug 100708] Trine 2 doesn't start on radeonsi on mesa 17

2017-12-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100708 Nicholas Miell changed: What|Removed |Added CC||nmi...@gmail.com

[Mesa-dev] [Bug 100708] Trine 2 doesn't start on radeonsi on mesa 17

2017-12-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100708 --- Comment #13 from Nicholas Miell --- You can work around this crash by either installing gnome-screensaver or putting #!/bin/sh exec /usr/bin/gnome-session-inhibit --inhibit-only "$@" in /usr/bin/gnome-screensaver-command

Re: [Mesa-dev] GBM and the Device Memory Allocator Proposals

2017-12-08 Thread Miguel Angel Vico
On Wed, 6 Dec 2017 16:57:45 -0800 James Jones wrote: > On 12/06/2017 03:25 AM, Nicolai Hähnle wrote: > > On 06.12.2017 08:07, James Jones wrote: > > [snip] > >> So lets say you have a setup where both display and GPU supported > >> FOO/tiled, but only GPU

[Mesa-dev] [Bug 100708] Trine 2 doesn't start on radeonsi on mesa 17

2017-12-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100708 Ray Strode [halfline] changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH] radeon/vcn: determine idr by pic type

2017-12-08 Thread Zhang, Boyuan
Am 04.12.2017 um 21:12 schrieb Zhang, Boyuan: >>> Am 30.11.2017 um 22:18 schrieb Leo Liu: On 11/30/2017 04:12 PM, boyuan.zh...@amd.com wrote: > From: Boyuan Zhang > > Vaapi encode interface provides idr frame flags, where omx > interface doesn't.

[Mesa-dev] [PATCH 4/4] meson: build clover

2017-12-08 Thread Dylan Baker
This has only been compile tested. cc: Curro Jerez Signed-off-by: Dylan Baker --- include/meson.build | 19 meson.build | 27 +- meson_options.txt

[Mesa-dev] [PATCH 2/4] meson: Turn on swr for relevant targets

2017-12-08 Thread Dylan Baker
Currently that's dri, libgl-xlib, and osmesa. CC: George Kyriazis Signed-off-by: Dylan Baker --- src/gallium/meson.build| 1 - src/gallium/targets/dri/meson.build| 4 ++--

Re: [Mesa-dev] [PATCH 1/9] i965/fs: Rewrite assign_constant_locations

2017-12-08 Thread Jason Ekstrand
On Fri, Dec 8, 2017 at 10:04 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Fri, Dec 08, 2017 at 08:55:56AM -0800, Jason Ekstrand wrote: > > On Fri, Dec 8, 2017 at 12:40 AM, Pohjolainen, Topi < > > topi.pohjolai...@gmail.com> wrote: > > > > > On Wed, Dec 06, 2017 at 08:34:19PM

Re: [Mesa-dev] [PATCH v4 00/44] anv: SPV_KHR_16bit_storage/VK_KHR_16bit_storage for gen8+

2017-12-08 Thread Jason Ekstrand
While reviewing some of the UBO pushing comments from Topi, I discovered a fairly disturbing assert in brw_fs_nir.cpp in our implementation of nir_intrinsic_load_uniform: /* Offsets are in bytes but they should always be multiples of 4 */ assert(const_offset->u32[0] % 4 == 0);

[Mesa-dev] [PATCH 1/4] meson: Build SWR driver

2017-12-08 Thread Dylan Baker
This enables the SWR driver, but doesn't actually hook it up to any of the targets yet. I felt like this patch was big and complicated enough without adding that. Signed-off-by: Dylan Baker --- meson.build| 12 +-

[Mesa-dev] [PATCH 0/4] meson for SWR (on Linux) and Clover

2017-12-08 Thread Dylan Baker
This series has been sitting in my tree for a while because it has a requirement on a new meson feature that I wrote and was added in 0.44.0, which is currently in feature freeze and should be released this coming Sunday, December 10th. This is a lot of code (especially for SWR which has a lot of

[Mesa-dev] [PATCH 3/4] meson: set opencl flags for r600

2017-12-08 Thread Dylan Baker
Signed-off-by: Dylan Baker --- src/gallium/drivers/r600/meson.build | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/r600/meson.build b/src/gallium/drivers/r600/meson.build index 2132dbb33ad..5899518a2e8 100644 ---

Re: [Mesa-dev] Gallium ARB_get_program_binary support --- 2nd try with *.dmp file removed (for the list)

2017-12-08 Thread Dieter Nützel
Hello Tim, first time ever, that I got a real regression with your GREAT work. ;-) DiRT Rally sig fault (SIGSEGV(11) with this series. (see attachment) Bad cache hit re-read? Removing .cache/mesa_shader_cache do not help. Searching for the rigth Feral (Steam?) cache dir. - Alex/James? Then

[Mesa-dev] [PATCH] radeon/vcn: determine idr by pic type

2017-12-08 Thread boyuan.zhang
From: Boyuan Zhang Vaapi encode interface provides idr frame flags, where omx interface doesn't. Therefore, change to use picture type to determine idr frame, which will work for both interfaces. Signed-off-by: Boyuan Zhang Reviewed-by: Leo Liu

[Mesa-dev] [PATCH 2/3] st/va: directly use idr pic flag

2017-12-08 Thread boyuan.zhang
From: Boyuan Zhang Remove is_idr flag, and use idr_pic_flag provided by vaapi directly Signed-off-by: Boyuan Zhang --- src/gallium/state_trackers/va/picture.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git

[Mesa-dev] [PATCH 3/3] vl: remove is idr flag

2017-12-08 Thread boyuan.zhang
From: Boyuan Zhang Remove is_idr flag since not being used anymore. Signed-off-by: Boyuan Zhang --- src/gallium/include/pipe/p_video_state.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/include/pipe/p_video_state.h

Re: [Mesa-dev] [PATCH] spirv: Fix loading an entire block at once.

2017-12-08 Thread Jason Ekstrand
On Fri, Dec 8, 2017 at 9:36 AM, Emil Velikov wrote: > On 3 December 2017 at 14:40, Bas Nieuwenhuizen > wrote: > > There is no chain, so checking the length ends with a SEGFAULT. > > > > Bugzilla: