Re: [Mesa-dev] [PATCH 2/2] radv: avoid PS partial flushes when viewports/scissors don't change

Reviewed-by: Bas Nieuwenhuizen for the series. On Fri, Jan 5, 2018 at 6:26 PM, Samuel Pitoiset wrote: > For Vega10 and Raven that need a special workaround for the > scissor bug. > > This seems to give a minor boost for Talos and Dota 2, at

Re: [Mesa-dev] [PATCH 2/2] radeonsi: use pknorm_i16/u16 and pk_i16/u16 LLVM intrinsics

Here: https://cgit.freedesktop.org/~mareko/mesa/log/?h=master LLVM: https://reviews.llvm.org/D41663 Marek On Fri, Jan 5, 2018 at 7:19 PM, Samuel Pitoiset wrote: > > > On 01/05/2018 02:45 AM, Marek Olšák wrote: >> >> On Thu, Jan 4, 2018 at 10:25 AM, Samuel Pitoiset >>

[Mesa-dev] [PATCH 1/2] i965/fs: Add/use functions to convert to 3src_align1 vstride/hstride

Some cases weren't handled, such as stride 4 which is needed for 64-bit operations. Presumably fixes the assertion failure mentioned in commit 2d0457203871 (Revert "i965/fs: Use align1 mode on ternary instructions on Gen10+") but who can really say since the commit neglected to list any of them!

[Mesa-dev] [PATCH 2/2] Revert "Revert "i965/fs: Use align1 mode on ternary instructions on Gen10+""

This reverts commit 2d0457203871c843ebfc90fb895b65a9b14cd9bb. --- src/intel/compiler/brw_fs_generator.cpp | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/intel/compiler/brw_fs_generator.cpp b/src/intel/compiler/brw_fs_generator.cpp index

[Mesa-dev] [PATCH resend 1/2] i965: Avoid problems from referencing orphaned BOs after growing.

Growing the batch/state buffer is a lot more dangerous than I thought. A number of places emit multiple state buffer sections, and then write data to the returned pointer, or save a pointer to brw->batch.state.bo and then use it in relocations. If each call can grow, this can result in stale map

[Mesa-dev] [PATCH resend 2/2] i965: Add some batchbuffer debugging code.

Uncommenting these blocks stress tests the batch/state growth code by trying to "grow" a buffer to the same size at least once per batch. When anything goes wrong with this code, dumping the validation list is a useful way to figure out what's happening. ---

[Mesa-dev] [PATCH v2 3/3] anv/blorp: do not clear with hiz if multiview is in use

When multiview is used we need to clear all the layers selected by the view mask. Currently blorp_gen8_hiz_clear_attachments doesn't support this. --- This is just something I noticed at the last moment so this is just a quick fix to avoid doing something wrong, ideally I guess we would make

[Mesa-dev] [PATCH v2 1/3] anv/blorp: only clear enabled views when multiview is used

--- src/intel/vulkan/anv_blorp.c | 55 1 file changed, 40 insertions(+), 15 deletions(-) diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c index e244468e03..18fa4a4ae5 100644 --- a/src/intel/vulkan/anv_blorp.c +++

[Mesa-dev] [PATCH v2 2/3] anv/blorp: consider multiview and view masks for tracking pending clear aspects

When multiview is active a subpass clear may only clear a subset of the attachment layers. Other subpasses in the same render pass may also clear too and we want to honor those clears as well, however, we need to ensure that we only clear a layer once, on the first subpass that uses a particular

[Mesa-dev] [PATCH 1/2] radv: add has_scissor_bug for Vega10 and Raven

Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 3 +-- src/amd/vulkan/radv_device.c | 4 src/amd/vulkan/radv_private.h| 1 + 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c

[Mesa-dev] [PATCH 2/2] radv: avoid PS partial flushes when viewports/scissors don't change

For Vega10 and Raven that need a special workaround for the scissor bug. This seems to give a minor boost for Talos and Dota 2, at least. To reduce the cost of memcmp, the driver checks if it's really useful to do the comparison. Signed-off-by: Samuel Pitoiset ---

Re: [Mesa-dev] [PATCH 2/2] radeonsi: use pknorm_i16/u16 and pk_i16/u16 LLVM intrinsics

On 01/05/2018 02:45 AM, Marek Olšák wrote: On Thu, Jan 4, 2018 at 10:25 AM, Samuel Pitoiset wrote: How about performance? Few weeks ago, I fixed a bug (5f81a43535e8512cef26ea3dcd1e3a489bd5a1bb) which affected F1 2017 and DOW3 on RADV, and it was also a nice

[Mesa-dev] [PATCH] .gitignore: Ignore new generated files

New generated files from: bb1e6ff161c ("spirv: Add a prepass to set types on vtn_values") 65fc16c9741 ("autotools: set XA versions in configure.ac and configure header file") --- src/compiler/spirv/.gitignore| 1 + src/gallium/state_trackers/xa/.gitignore | 1 + 2 files changed,

[Mesa-dev] [PATCH v2] anv: Allow PMA optimization to be enabled in secondary command buffers

This was never enabled in secondary buffers because hiz_enabled was never set to true for those. If the app provides a framebuffer in the inheritance info when beginning a secondary buffer, we can determine if HiZ is enabled and therefore allow the PMA optimization to be enabled within the

Re: [Mesa-dev] [RFC PATCH 0/6] r600: speed up tesselation shaders

Am Freitag, den 29.12.2017, 17:18 +1000 schrieb Dave Airlie: > On 29 December 2017 at 16:38, Dave Airlie wrote: > > > > I thought I'd done this already, I must dig a bit more. > > > > I've pushed mosre stuff to the branch, nop still doesn't work. > > > > I've included your

Re: [Mesa-dev] [PATCH v2] nvc0: ensure that pushbuf keeps ref to old text/tls bos

Makes sense to me. Reviewed-by: Samuel Pitoiset On 01/05/2018 07:17 AM, Ilia Mirkin wrote: If we free the bo, then the PTE may get deallocated immediately. We have to make sure that the submission includes a ref to the old bo so that it remains mapped for the

[Mesa-dev] [PATCH] radv: get InstanceID from VGPR1 (or VGPR2 for tess) instead of VGPR3

VGPR1 = InstanceID / StepRate0; // StepRate0 can be set to 1 Ported from RadeonSI. The patch needs a full CTS run to be sure it's correct, but I think it is. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 32 1

[Mesa-dev] [PATCH] radv/gfx9: do not load VGPR1 when GS uses points or lines

VGPR1 is only needed for topology that needs 3 offsets like triangles or quads. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_shader.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_shader.c

Re: [Mesa-dev] [PATCH v4 2/3] autotools: Include meson.build files in tarball

Quoting Eric Engestrom (2018-01-05 06:02:52) > On Thursday, 2018-01-04 10:28:41 -0800, Dylan Baker wrote: > > Signed-off-by: Dylan Baker > > Do we really want to use autotools' `dist` to package libdrm once meson > has landed? > I would've though we would switch to meson

Re: [Mesa-dev] [PATCH resend 1/2] i965: Avoid problems from referencing orphaned BOs after growing.

Quoting Kenneth Graunke (2018-01-05 18:56:32) > Growing the batch/state buffer is a lot more dangerous than I thought. > > A number of places emit multiple state buffer sections, and then write > data to the returned pointer, or save a pointer to brw->batch.state.bo > and then use it in

Re: [Mesa-dev] [PATCH] anv: Allow PMA optimization to enabled in secondary command buffers

Thanks, that change makes it look a bit tidier - I'll send a v2 and wait to see what Jason thinks. On 5 January 2018 at 16:06, Lionel Landwerlin wrote: > This makes sense to me, it would be good to have Jason's opinion. > I have a suggestion below. > >

[Mesa-dev] [PATCH] st/mesa: Factorize duplicate code in st_update_framebuffer_state()

Signed-off-by: Guillaume Charifi --- src/mesa/state_tracker/st_atom_framebuffer.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/src/mesa/state_tracker/st_atom_framebuffer.c b/src/mesa/state_tracker/st_atom_framebuffer.c index

Re: [Mesa-dev] [RFC PATCH 0/6] r600: speed up tesselation shaders

Am Freitag, den 05.01.2018, 18:18 +0100 schrieb Gert Wollny: > > Well, I have tested some piglits now and the behaviour is quite > wired:  > > When I run nop as the very first piglit after booting the machine it > works. After running other piglits (specifically  tcs-input-read- >

Re: [Mesa-dev] [PATCH] radeonsi: don't expose 8xMSAA on slowest APUs

Please ignore this patch. I'm dropping it. Marek On Thu, Jan 4, 2018 at 1:54 AM, Marek Olšák wrote: > From: Marek Olšák > > i.e. Kabini, Mullins, Stoney. > > This was requested internally. > --- > src/gallium/drivers/radeonsi/si_state.c | 5 + > 1

Re: [Mesa-dev] [PATCH v4 3/3] README: Add note about meson

Quoting Eric Engestrom (2018-01-05 05:49:25) > On Thursday, 2018-01-04 10:28:42 -0800, Dylan Baker wrote: > > Signed-off-by: Dylan Baker > > Couple nitpicks, but: > Reviewed-by: Eric Engestrom > > > --- > > README | 21 ++---

[Mesa-dev] [PATCH 1/3] Add meson build system

This patch adds a complete meson build system, including tests and install. It has the necessary hooks to allow it be used as a subproject for other meson based builds such as mesa. Signed-off-by: Dylan Baker Reviewed-and-tested-by: Igor Gnatenko

[Mesa-dev] [PATCH 2/3] autotools: Include meson.build files in tarball

Signed-off-by: Dylan Baker --- Makefile.am | 30 +- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 7b86214..66f70ca 100644 --- a/Makefile.am +++ b/Makefile.am @@ -135,7 +135,35 @@ if HAVE_VMWGFX

[Mesa-dev] [PATCH 3/3] README: Add note about meson

Signed-off-by: Dylan Baker --- README | 24 +--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git a/README b/README index 26cab9d..f3df9ac 100644 --- a/README +++ b/README @@ -15,9 +15,27 @@ with an older kernel. Compiling -

Re: [Mesa-dev] [PATCH 14/14] meson: glsl: add missing nir header dependency

Reviewed-by: Dylan Baker Quoting Greg V (2017-12-31 08:55:28) > --- > src/compiler/glsl/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/compiler/glsl/meson.build b/src/compiler/glsl/meson.build > index 6aaa9bab05..9e7589c325 100644

Re: [Mesa-dev] [PATCH 11/14] meson: fix missing dependencies

Quoting Greg V (2017-12-31 08:55:25) > --- > src/gallium/drivers/radeonsi/meson.build | 2 +- > src/mesa/meson.build | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/radeonsi/meson.build >

Re: [Mesa-dev] [PATCH 3/3] aubinator: add support for aubinating memtrace aubs

On 2017-11-28 15:52:10, Scott D Phillips wrote: > Memtrace aubs are similar to classic aubs, with the major > difference being how command submission is serialized (as register > writes instead of a high-level submit message). Some internal > tools generate or consume only memtrace aubs. > --- >

Re: [Mesa-dev] [PATCH v3 3/4] meson: build clover

Hi, sorry for the delay. I was mostly traveling during the holidays. On Fri, 2017-12-15 at 10:54 -0800, Dylan Baker wrote: > This has only been compile tested. > > v2: - Have a single option for opencl (Eric E) > - fix typo "tgis" -> "tgsi" (Curro) > - Don't add "lib" to pipe loader

Re: [Mesa-dev] [PATCH v3 3/4] meson: build clover

Quoting Jan Vesely (2018-01-05 14:16:41) > Hi, > > > sorry for the delay. I was mostly traveling during the holidays. No worries, I was also away over the holidays and didn't look at this until today. > > On Fri, 2017-12-15 at 10:54 -0800, Dylan Baker wrote: > > This has only been compile

[Mesa-dev] [PATCH 0/3] Meson build system

This is a fifth iteration of the meson build system for libdrm. This version is significantly cleaned up from the last version and uses a style more like the build system in mesa. It builds all of the drivers and tests, and the tests can be run via `ninja test`. It has support for being used as

Re: [Mesa-dev] [PATCH v2] anv: Allow PMA optimization to be enabled in secondary command buffers

On 5 January 2018 at 21:43, Jason Ekstrand wrote: > On Fri, Jan 5, 2018 at 9:06 AM, Alex Smith > wrote: > >> This was never enabled in secondary buffers because hiz_enabled was >> never set to true for those. >> >> If the app provides a

Re: [Mesa-dev] [PATCH 1/3] Add meson build system

Quoting Eric Engestrom (2018-01-05 05:34:53) > On Wednesday, 2018-01-03 13:31:28 -0800, Dylan Baker wrote: > > This patch adds a complete meson build system, including tests and > > install. It has the necessary hooks to allow it be used as a subproject > > for other meson based builds such as

Re: [Mesa-dev] [PATCH] anv: Take write mask into account in has_color_buffer_write_enabled

Seems reasonable. Only one comment which you can feel free to ignore. Reviewed-by: Jason Ekstrand On Fri, Jan 5, 2018 at 7:23 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > Looks good to me too. > > Reviewed-by: Lionel Landwerlin

Re: [Mesa-dev] [PATCH 08/14] meson: fix BSD build

Quoting Greg V (2017-12-31 08:55:22) > --- > meson.build | 43 ++- > 1 file changed, 22 insertions(+), 21 deletions(-) > > diff --git a/meson.build b/meson.build > index d9f7ea9b2c..af62baf437 100644 > --- a/meson.build > +++ b/meson.build > @@ -199,12

[Mesa-dev] [Bug 104214] Dota crashes when switching from game to desktop

https://bugs.freedesktop.org/show_bug.cgi?id=104214 --- Comment #21 from Sven --- Created attachment 136577 --> https://bugs.freedesktop.org/attachment.cgi?id=136577=edit gdb output from crash after alt+tab switching And here's the output after dota crashed when I

Re: [Mesa-dev] [PATCH 10/14] meson: handle LLVM 'x.x.xgit-revision' versions

Please add a comment that svn suffixes are stripped by meson as of 0.43, and git suffixes are strippped as of 0.44. With that, Reviewed-by: Dylan Baker Quoting Greg V (2017-12-31 08:55:24) > When LLVM is built inside of a git repo (even way below, e.g. /usr/ports/.git >

Re: [Mesa-dev] [PATCH 10/14] meson: handle LLVM 'x.x.xgit-revision' versions

Quoting Juan A. Suarez Romero (2018-01-05 04:42:05) > On Fri, 2018-01-05 at 10:35 +0100, Gert Wollny wrote: > > On Sun, 2017-12-31 at 19:55 +0300, Greg V wrote: > > > > When LLVM is built inside of a git repo (even way below, e.g. > > > > /usr/ports/.git > > > > exists, and LLVM is built in

Re: [Mesa-dev] [PATCH 00/14] BSD portability (Meson, ANV, RADV, VC4/5, SWR)

Thanks so much for working on this, especially the meson bits! Quoting Greg V (2017-12-31 08:55:14) > Hello everyone and happy new year! :) > > This set of patches makes the Meson build work on FreeBSD, including > RADV, ANV, wayland-egl, VAAPI, VDPAU. > > I also managed to get SWR working,

Re: [Mesa-dev] [PATCH] glsl: Respect std430 layout in lower_buffer_access

These changes seem reasonable. Are you able to create a piglit test that exercises the bug also? See the basic ssbo test as an example [1]. After building piglit you can run these shader runner tests from the piglit dir like so: ./bin/shader_runner

Re: [Mesa-dev] [PATCH] .gitignore: Ignore new generated files

Reviewed-by: Jordan Justen On 2018-01-05 10:52:27, Scott D Phillips wrote: > New generated files from: > > bb1e6ff161c ("spirv: Add a prepass to set types on vtn_values") > 65fc16c9741 ("autotools: set XA versions in configure.ac and configure > header file") >

Re: [Mesa-dev] [PATCH] mesa: remove dd_function_table::GetCompressedTexSubImage and clean it up

On 01/04/2018 05:42 PM, Marek Olšák wrote: > On Thu, Jan 4, 2018 at 8:36 PM, Ian Romanick wrote: >> If nobody uses this method, removing it seems fine. Does this imply >> that nobody implements an accelerated glGetCompressedTexSubImage, or is >> the acceleration just

[Mesa-dev] [PATCH 4/8] meson: don't use intermediate variables that are immediately discarded

For things like: loop x = func() list += x end just do: loop list += func() end Signed-off-by: Dylan Baker --- src/broadcom/cle/meson.build | 3 +-- src/intel/genxml/meson.build | 3 +-- src/intel/isl/meson.build | 6 ++

[Mesa-dev] [PATCH 8/8] meson: add variable for including include/GL/internal

Signed-off-by: --- include/meson.build | 1 + src/glx/meson.build | 10 ++ src/glx/tests/meson.build | 4 ++-- 3 files changed, 5 insertions(+), 10 deletions(-) diff --git a/include/meson.build b/include/meson.build index e4dae91..9b34490 100644

[Mesa-dev] [PATCH 6/8] meson: move libsensors dependency to libgallium

This simplifies the build by removing the need to link targets against libsensors. Suggested-by: Emil Velikov Signed-off-by: Dylan Baker --- src/gallium/auxiliary/meson.build | 2 +- src/gallium/drivers/etnaviv/meson.build | 2

[Mesa-dev] [PATCH 2/8] meson: Use include variables

These were added after adderlib was mesonified, but it still good to use them instead of open coding them. Signed-off-by: Dylan Baker --- src/amd/addrlib/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/addrlib/meson.build

Re: [Mesa-dev] [PATCH] spirv: Use correct type for sampled images

On Tue, Nov 7, 2017 at 3:08 AM, Alex Smith wrote: > Thanks Jason. Can someone push this? > Did you never get push access? --Jason > On 6 November 2017 at 16:21, Jason Ekstrand wrote: > >> On Mon, Nov 6, 2017 at 2:37 AM, Alex Smith

Re: [Mesa-dev] [PATCH 08/14] meson: fix BSD build

On January 5, 2018 5:12:15 PM PST, Greg V wrote: > >On 01/06/2018 01:06, Dylan Baker wrote: >> Quoting Greg V (2017-12-31 08:55:22) >>> +is_like_linux = host_machine.system() == 'linux' or >host_machine.system().contains('bsd') # FIXME: illumos? >> This won't cover

[Mesa-dev] [PATCH 3/8] meson: Use consistent style for tests

Don't use intermediate variables, use consistent whitespace. Signed-off-by: Dylan Baker --- src/broadcom/qpu/meson.build| 12 ++- src/compiler/glsl/tests/meson.build | 90 -- src/compiler/nir/meson.build| 19

[Mesa-dev] [PATCH 1/2] i965: Require space for MI_BATCHBUFFER_END.

intel_batchbuffer_emit_dword doesn't reserve space for the DWord it emits. In the past, we had some reserved batch space to ensure this worked. With the switch to growing batches, we need to actually request space so that we grow if necessary. Fixes: 2c46a67b4138631217141f (i965: Delete

[Mesa-dev] [PATCH 7/8] meson: define inc_gbm as empty if not otherwise assigned

Otherwise this could be undefined in the egl directory. Signed-off-by: Dylan Baker --- src/meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/meson.build b/src/meson.build index 5fc14ac..730b2ff 100644 --- a/src/meson.build +++ b/src/meson.build @@

[Mesa-dev] [PATCH 0/8] Meson cleanups, style fixes, and race hardening

This series is a collection of style cleanups, maintainability fixes, and suggestions from reviewers of previous patches. Other than the style changes (which are mostly about using consistent whitespace and removing temporary variables that are useless), this adds a new internal dependency for

[Mesa-dev] [PATCH 5/8] meson: Use dependencies for nir

This creates two new internal dependencies, idep_nir_headers and idep_nir. The former encapsulates the generation of nir_opcodes.h and nir_builder_opcodes.h and adding src/compiler/nir as an include path. This ensures that any target that needs nir headers will have the includes and that the

Re: [Mesa-dev] [PATCH] mesa: Tidy up the 4.6 section of GL4x.xml

Thanks! Reviewed-by: Ian Romanick On 01/05/2018 02:48 AM, Neil Roberts wrote: > The enums are moved to the top and indented like the rest of the file. > Comments are added to split up the function aliases by corresponding > extension. This should make no functional

[Mesa-dev] [PATCH 2/2] i965: Torch public intel_batchbuffer_emit_dword/float helpers.

intel_batchbuffer_emit_float is dead code, it should go. intel_batchbuffer_emit_dword only had one user, which had bungled using them by forgetting to call intel_batchbuffer_require_space first. So it seems wise to delete these unsafe helpers. Cc: mesa-sta...@lists.freedesktop.org ---

[Mesa-dev] [PATCH 3/5] glsl: Don't handle visit_stop in several ::accept methods

From: Ian Romanick All cases where the result could be non-visit_continue would have already returned. CID: 401351, 1224465, 1224466 Signed-off-by: Ian Romanick --- src/compiler/glsl/ir_hv_accept.cpp | 9 ++--- 1 file changed, 6

[Mesa-dev] [PATCH 2/5] glsl: Remove unnecessary assignments to type

From: Ian Romanick None of these are necessary because result->type is the only thing used outside the giant switch-statement. CID: 1230983, 1230984 Signed-off-by: Ian Romanick --- src/compiler/glsl/ast_to_hir.cpp | 4 1 file changed, 4

[Mesa-dev] [PATCH 5/5] glsl/linker: Safely generate mask of possible locations

From: Ian Romanick If MaxAttribs were ever raised to 32, undefined behavior would occur. We had already gone to the effort (albeit incorrectly) handle this in one case, so fix them all. CID: 1369628 Signed-off-by: Ian Romanick ---

[Mesa-dev] [PATCH 1/5] nir: Silence unused parameter warnings

From: Ian Romanick In file included from src/compiler/nir/nir_opt_algebraic.c:4:0: src/compiler/nir/nir_search_helpers.h: In function ‘is_not_const’: src/compiler/nir/nir_search_helpers.h:118:59: warning: unused parameter ‘num_components’ [-Wunused-parameter]

[Mesa-dev] [PATCH 1/8] meson: Use consistent style

Currently the meosn build has a mix of two styles: arg : [foo, ... bar], and arg :[ foo, ..., bar, ] For consistency let's pick one. I've picked the later style, which I think is more readable, and is more common in the mesa code base. Signed-off-by: Dylan Baker

Re: [Mesa-dev] [PATCH v2 00/31] Nir support for Nouveau

On Thursday, January 4, 2018 11:56:44 AM PST Jason Ekstrand wrote: > On January 4, 2018 12:51:15 Karol Herbst wrote: > > > On Thu, Jan 4, 2018 at 7:06 PM, Ilia Mirkin wrote: > >> On Thu, Jan 4, 2018 at 10:01 AM, Karol Herbst wrote:

Re: [Mesa-dev] [PATCH 13/29] anv/cmd_buffer: Rework aux tracking

On Mon, Nov 27, 2017 at 07:06:03PM -0800, Jason Ekstrand wrote: > This makes us start tracking two bits per level for aux to describe both > whether or not something is fast-cleared and whether or not it is > compressed as opposed to a single "needs resolve" bit. The previous > scheme only worked

Re: [Mesa-dev] [PATCH 11/14] meson: fix missing dependencies

On January 5, 2018 5:00:59 PM PST, Greg V wrote: >On 01/06/2018 01:36, Dylan Baker wrote: >> Quoting Greg V (2017-12-31 08:55:25) >>> --- >>> src/gallium/drivers/radeonsi/meson.build | 2 +- >>> src/mesa/meson.build | 1 + >>> 2 files

[Mesa-dev] [PATCH 4/5] glsl/linker: Mark no locations as invalid instead of marking all locations

From: Ian Romanick If max_index were ever 32, the linker would have marked all 32 locations as invalid instead of marking none of them as invalid. It's a good thing the maximum value actually set by any driver for MaxAttribs is 16. Found by inspection while

Re: [Mesa-dev] st/omx_bellagio: Update default intra matrix per MPEG2 spec

Am 05.01.2018 um 10:36 schrieb Das, Indrajit-kumar: From: Indrajit Das Signed-off-by: Indrajit Das Reviewed-by: Christian König Still wondering how we messed up that initially. Regards, Christian. ---

Re: [Mesa-dev] [PATCH] anv: Allow PMA optimization to enabled in secondary command buffers

This makes sense to me, it would be good to have Jason's opinion. I have a suggestion below. Reviewed-by: Lionel Landwerlin Thanks! On 05/01/18 11:20, Alex Smith wrote: This was never enabled in secondary buffers because hiz_enabled was never set to true for

[Mesa-dev] [PATCH] radv: remove unused radv_color_buffer_info::cb_clear_valueX

Found by inspection. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_private.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/amd/vulkan/radv_private.h b/src/amd/vulkan/radv_private.h index bae353c0e5..30ccbea176 100644 ---

Re: [Mesa-dev] [PATCH] radv: enable denorms for 64-bit and 16-bit floats

On 01/04/2018 07:54 PM, Bas Nieuwenhuizen wrote: Reviewed-by: Bas Nieuwenhuizen Yeah, I think it's easier to fix it that way for now. Thanks! On Thu, Dec 28, 2017 at 10:55 PM, Samuel Pitoiset wrote: Similar to RadeonSI. This fixes:

Re: [Mesa-dev] [PATCH 10/14] meson: handle LLVM 'x.x.xgit-revision' versions

Reviewed-by: Juan A. Suarez On Sun, 2017-12-31 at 19:55 +0300, Greg V wrote: > When LLVM is built inside of a git repo (even way below, e.g. /usr/ports/.git > exists, and LLVM is built in /usr/ports/devel/llvm50/work), its version > becomes something like

Re: [Mesa-dev] [PATCH] anv: Take write mask into account in has_color_buffer_write_enabled

Looks good to me, unless Jason or Lionel say otherwise: Reviewed-by: Iago Toral Quiroga Iago On Thu, 2018-01-04 at 18:13 +, Alex Smith wrote: > If we have a color attachment, but its writes are masked, this would > have still returned true. This is inconsistent with how

[Mesa-dev] [PATCH 2/2] anv/blorp: consider multiview and view masks for tracking pending clear aspects

When multiview is active a subpass clear may only clear a subset of the attachment layers. Other subpasses in the same render pass may also clear too and we want to honor those clears. This means that when multiview is active we cannot mark an attachment as already cleared after a subpass clear

[Mesa-dev] [PATCH 1/2] anv/blorp: only clear enabled views when multiview is used

--- src/intel/vulkan/anv_blorp.c | 55 1 file changed, 40 insertions(+), 15 deletions(-) diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c index e244468e03..18fa4a4ae5 100644 --- a/src/intel/vulkan/anv_blorp.c +++

[Mesa-dev] [Bug 104490] [radeonsi/290x] Dota2 fails to start (can't create opengl context)

https://bugs.freedesktop.org/show_bug.cgi?id=104490 Michel Dänzer changed: What|Removed |Added QA Contact|dri-devel@lists.freedesktop

Re: [Mesa-dev] [PATCH 10/14] meson: handle LLVM 'x.x.xgit-revision' versions

On Sun, 2017-12-31 at 19:55 +0300, Greg V wrote: >> When LLVM is built inside of a git repo (even way below, e.g. /usr/ports/.git >> exists, and LLVM is built in /usr/ports/devel/llvm50/work), its version >> becomes something like 5.0.0git-f8ab206b2176. >> >> Don't blow up on these versions. >>

[Mesa-dev] st/omx_bellagio: Update default intra matrix per MPEG2 spec

From: Indrajit Das Signed-off-by: Indrajit Das --- src/gallium/state_trackers/omx_bellagio/vid_dec_mpeg12.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 2/2] anv/blorp: consider multiview and view masks for tracking pending clear aspects

Ignore this patch, there is more to this than I thought. I'll see if I can find a proper solution and send a v2. Iago On Fri, 2018-01-05 at 10:28 +0100, Iago Toral Quiroga wrote: > When multiview is active a subpass clear may only clear a subset of > the > attachment layers. Other subpasses in

Re: [Mesa-dev] [PATCH] radv: remove unused radv_color_buffer_info::cb_clear_valueX

Reviewed-by: Bas nieuwenhuizen On Fri, Jan 5, 2018 at 10:03 AM, Samuel Pitoiset wrote: > Found by inspection. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_private.h | 2 -- > 1 file changed, 2

[Mesa-dev] [PATCH] mesa: Tidy up the 4.6 section of GL4x.xml

The enums are moved to the top and indented like the rest of the file. Comments are added to split up the function aliases by corresponding extension. This should make no functional difference. --- This was requested by Ian Romanick as part of the review of the patch to add the aliases for

[Mesa-dev] [PATCH] anv: Allow PMA optimization to enabled in secondary command buffers

This was never enabled in secondary buffers because hiz_enabled was never set to true for those. If the app provides a framebuffer in the inheritance info when beginning a secondary buffer, we can determine if HiZ is enabled and therefore allow the PMA optimization to be enabled within the

Re: [Mesa-dev] [PATCH v4 3/3] README: Add note about meson

On Thursday, 2018-01-04 10:28:42 -0800, Dylan Baker wrote: > Signed-off-by: Dylan Baker Couple nitpicks, but: Reviewed-by: Eric Engestrom > --- > README | 21 ++--- > 1 file changed, 18 insertions(+), 3 deletions(-) > > diff

Re: [Mesa-dev] [PATCH v4 2/3] autotools: Include meson.build files in tarball

On Thursday, 2018-01-04 10:28:41 -0800, Dylan Baker wrote: > Signed-off-by: Dylan Baker Do we really want to use autotools' `dist` to package libdrm once meson has landed? I would've though we would switch to meson and deprecate autotools right away. On that note, have

Re: [Mesa-dev] [PATCH 1/3] Add meson build system

Gah, I missed v4, the double-list thing made it land in the other folder than v3... If you tell me you had already fixed all those, I'll read v4 to actually r-b it, otherwise I'll wait for v5 :) On Friday, 2018-01-05 13:34:53 +, Eric Engestrom wrote: > On Wednesday, 2018-01-03 13:31:28

Re: [Mesa-dev] [PATCH 10/14] meson: handle LLVM 'x.x.xgit-revision' versions

On Fri, 2018-01-05 at 10:35 +0100, Gert Wollny wrote: > On Sun, 2017-12-31 at 19:55 +0300, Greg V wrote: > > > When LLVM is built inside of a git repo (even way below, e.g. > > > /usr/ports/.git > > > exists, and LLVM is built in /usr/ports/devel/llvm50/work), its version > > > becomes something

Re: [Mesa-dev] [PATCH 1/3] Add meson build system

On Wednesday, 2018-01-03 13:31:28 -0800, Dylan Baker wrote: > This patch adds a complete meson build system, including tests and > install. It has the necessary hooks to allow it be used as a subproject > for other meson based builds such as mesa. > > Signed-off-by: Dylan Baker

Re: [Mesa-dev] [PATCH] anv: Take write mask into account in has_color_buffer_write_enabled

Looks good to me too. Reviewed-by: Lionel Landwerlin Thanks a lot! - Lionel On 05/01/18 09:19, Iago Toral wrote: Looks good to me, unless Jason or Lionel say otherwise: Reviewed-by: Iago Toral Quiroga Iago On Thu, 2018-01-04 at 18:13

[Mesa-dev] [PATCH] glsl: Respect std430 layout in lower_buffer_access

Respect the std430 rules for determining offset and size of struct members when using a std430 buffer. std140 rules lead to wrong buffer offsets in that case. Fixes my test case attached in Bugzilla. No piglit changes. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104492 ---

Re: [Mesa-dev] [PATCH v2] anv: Allow PMA optimization to be enabled in secondary command buffers

On Fri, Jan 5, 2018 at 9:06 AM, Alex Smith wrote: > This was never enabled in secondary buffers because hiz_enabled was > never set to true for those. > > If the app provides a framebuffer in the inheritance info when beginning > a secondary buffer, we can determine

Re: [Mesa-dev] [PATCH 09/14] meson: do not redeclare pkg-config dependencies (yet)

We absolutely can't merge this as-is, it will break all of the these since they'll end up linking the backend and frontend, which we're not supposed to do. The bug you linked to has nothing to do with the problem you describe either, that issue is that `dependency("threads")` is special in meson,