Re: [Mesa-dev] [PATCH 4/8] mesa: Track position/generic0 aliasing in the VAO.

2018-02-04 Thread Mathias Fröhlich
Hi, > On 1 February 2018 at 07:32, wrote: > Feel free to use C99 designated initializers. All supported compilers > understand them. > Even MSVC 2013 Update 4 ;-) Next time :-) best Mathias ___ mesa-dev mailing list

[Mesa-dev] [Bug 104926] swrast: Mesa 17.3.3 produces: HW cursor for format 875713089 not supported

2018-02-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104926 pipep changed: What|Removed |Added CC||a...@gmx.ch -- You are receiving

Re: [Mesa-dev] [PATCH] r600: fix VERTEX_ATTRIB_STRIDE to be 2048

2018-02-04 Thread Dave Airlie
On 2 February 2018 at 18:02, Roland Scheidegger wrote: > Are you sure of that? You only get 11 stride bits to program, and they > are in bytes. Therefore I can't see how you could program 2048 (unless > the hw would interpet 0 as 2048 but I think stride 0 is valid there?). >

[Mesa-dev] [Bug 104928] libglvnd_1.0.0 disables amdgpu direct rendering

2018-02-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104928 Christian König changed: What|Removed |Added Status|REOPENED

Re: [Mesa-dev] [PATCH] i965/nir: do int64 lowering before optimization

2018-02-04 Thread Matt Turner
On Wed, Dec 13, 2017 at 11:21 PM, Iago Toral wrote: > On Tue, 2017-12-12 at 08:20 +0100, Iago Toral wrote: > > On Mon, 2017-12-11 at 08:01 -0800, Jason Ekstrand wrote: > > On Mon, Dec 11, 2017 at 12:55 AM, Iago Toral wrote: > > This didn't get any reviews

[Mesa-dev] [PATCH 3/3] nv50, nvc0: mark ABGR format as displayable instead of ARGB format

2018-02-04 Thread Ilia Mirkin
This matches the hardware's capabilities. Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/nv50/nv50_formats.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/nouveau/nv50/nv50_formats.c

[Mesa-dev] [PATCH 1/3] mesa: add xbgr support adjacent to xrgb

2018-02-04 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- One might have split this up into multiple patches, but it's just very repetitive and similar code. include/GL/internal/dri_interface.h | 2 ++ src/gallium/state_trackers/dri/dri2.c | 36 +++

[Mesa-dev] [PATCH 2/3] st/dri: only expose config formats that are display targets

2018-02-04 Thread Ilia Mirkin
In the case of NVIDIA hardware, ABGR is displayable but ARGB is not. Only advertise the one set in the visuals list. Signed-off-by: Ilia Mirkin --- Not sure if this is the right thing, esp for a PRIME-type setup. However for the common single-GPU case, it does seem right.

[Mesa-dev] [Bug 104928] libglvnd_1.0.0 disables amdgpu direct rendering

2018-02-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104928 fin4...@hotmail.com changed: What|Removed |Added Resolution|INVALID |--- Status|RESOLVED

Re: [Mesa-dev] [PATCH] i965/nir: do int64 lowering before optimization

2018-02-04 Thread Connor Abbott
On Mon, Dec 11, 2017 at 11:01 AM, Jason Ekstrand wrote: > On Mon, Dec 11, 2017 at 12:55 AM, Iago Toral wrote: >> >> This didn't get any reviews yet. Any takers? >> >> On Fri, 2017-12-01 at 13:46 +0100, Iago Toral Quiroga wrote: >> > Otherwise loop

[Mesa-dev] [PATCH] winsys/amdgpu: allow non page-aligned size bo creation from pointer

2018-02-04 Thread Michal Navratil
Fix INVALID_OPERATION caused by BufferData with target EXTERNAL_VIRTUAL_MEMORY_BUFFER_AMD when the buffer size is not page aligned. --- src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git

[Mesa-dev] [PATCH] i965: remove unused brw_nir_lower_cs_shared()

2018-02-04 Thread Timothy Arceri
This has been unused since 8761a04d0d93. --- src/intel/compiler/brw_nir.c | 8 src/intel/compiler/brw_nir.h | 1 - 2 files changed, 9 deletions(-) diff --git a/src/intel/compiler/brw_nir.c b/src/intel/compiler/brw_nir.c index dbddef0d04..405985f8b6 100644 ---

[Mesa-dev] [PATCH 2/4] mesa: (trivial) remove unused ignore_sample_qualifier_parameter

2018-02-04 Thread sroland
From: Roland Scheidegger This parameter for _mesa_get_min_incations_per_fragment() was once used by the intel driver, but it's long gone. --- src/mesa/program/program.c| 11 --- src/mesa/program/program.h| 3 +--

[Mesa-dev] [PATCH 3/4] r600: clean up fragment shader input scan code

2018-02-04 Thread sroland
From: Roland Scheidegger For some reason, we were iterating through the code twice (first just for instructions needing barycentrics, then for instructions and input dcls). Move things around slightly so this is no longer necessary. There also was a unnedeed enabling of the

[Mesa-dev] [PATCH 4/4] r600: partly fix sampleMaskIn value

2018-02-04 Thread sroland
From: Roland Scheidegger The hw gives us coverage for pixel, not for individual fragment shader invocations, in case execution isn't per pixel (note eg, unlike cm, actually cannot do "real" minSampleShading, it's either per-pixel or per-fragment, but it doesn't really make a

[Mesa-dev] [PATCH 1/4] r600/cm: (trivial) code cleanup for emitting msaa state

2018-02-04 Thread sroland
From: Roland Scheidegger No functional change (compile tested only). --- src/gallium/drivers/r600/cayman_msaa.c | 14 ++ src/gallium/drivers/r600/evergreen_state.c | 10 ++ src/gallium/drivers/r600/r600_pipe_common.h | 6 ++ 3 files changed, 14

[Mesa-dev] [PATCH 0/2] Fix and tweak to the VAO

2018-02-04 Thread Mathias . Froehlich
From: Mathias Fröhlich Hi, Those two patches fix a bug in tracking the VAO vertex buffer object state and reduce the amount of possible unneeded updates of the dependent gl_vertex_array array. Both changes are as well in preparation to more internal use of vertex

[Mesa-dev] android: fixes for anv build

2018-02-04 Thread Mauro Rossi
Hi, I'm sending a series of fixed for anv build [PATCH 1/3] android: anv/extensions: fix generated sources build [PATCH 2/3] android: anv: add dependency on libnativewindow for O and [PATCH 3/3] android: vulkan/util: add dependency on libnativewindow Since anv now implements vulkan HAL, the

[Mesa-dev] [PATCH 3/3] android: vulkan/util: add dependency on libnativewindow for O and later

2018-02-04 Thread Mauro Rossi
Similar to 90dd6e5 ("Android: egl: add dependency on libnativewindow") Fixes the following building error: In file included from out/target/product/x86_64/obj_x86/STATIC_LIBRARIES/libmesa_vulkan_util_intermediates/util/vk_enum_to_str.c:26:

[Mesa-dev] [PATCH 1/3] android: anv/extensions: fix generated sources build

2018-02-04 Thread Mauro Rossi
Building rules are aligned to automake ones The correct script to build anv_extensions.{c,h} is anv_extensions_gen.py Generation rules for anv_extensions.c requires --out-c option Generation rules for anv_extensions.h were missing Necessary include paths are added to avoid following build errors:

[Mesa-dev] [PATCH 2/3] android: anv: add dependency on libnativewindow for O and later

2018-02-04 Thread Mauro Rossi
Similar to 90dd6e5 ("Android: egl: add dependency on libnativewindow") Fixes the following building errors: In file included from external/mesa/src/intel/vulkan/gen7_cmd_buffer.c:30: In file included from external/mesa/src/intel/vulkan/anv_private.h:72:

[Mesa-dev] [PATCH 2/2] mesa: Only update enabled VAO gl_vertex_array entries.

2018-02-04 Thread Mathias . Froehlich
From: Mathias Fröhlich Instead of updating all modified gl_vertex_array_object::_VertexArray entried just update those ones that are modified and enabled. Also release buffer object from the _VertexArray that belong to disabled attributes. Signed-off-by: Mathias

[Mesa-dev] [PATCH 1/2] mesa: Fix VAO buffer object tracking.

2018-02-04 Thread Mathias . Froehlich
From: Mathias Fröhlich When changing the attribute binding in the VAO we also need to account for getting rid of non vbo bits from VertexAttribBufferMask. Signed-off-by: Mathias Fröhlich --- src/mesa/main/varray.c | 2 ++ 1 file changed, 2

Re: [Mesa-dev] [PATCH v2 1/3] st/glsl_to_tgsi: move nir detection earlier - bisected

2018-02-04 Thread Dieter Nützel
Am 02.02.2018 10:24, schrieb Timothy Arceri: On 02/02/18 19:26, Dieter Nützel wrote: Hello Tim, _this_ version brake UH, UV, mpv, blender 2.79 (some test files not all). Must be something with the cache file(s). The cache currently needs to be deleted when switching between nir and tgsi.

Re: [Mesa-dev] [PATCH] r600: fix VERTEX_ATTRIB_STRIDE to be 2048

2018-02-04 Thread Roland Scheidegger
Am 04.02.2018 um 20:13 schrieb Dave Airlie: > On 2 February 2018 at 18:02, Roland Scheidegger wrote: >> Are you sure of that? You only get 11 stride bits to program, and they >> are in bytes. Therefore I can't see how you could program 2048 (unless >> the hw would interpet 0

Re: [Mesa-dev] [PATCH] r600: fix VERTEX_ATTRIB_STRIDE to be 2048

2018-02-04 Thread Roland Scheidegger
Am 05.02.2018 um 03:04 schrieb Roland Scheidegger: > Am 04.02.2018 um 20:13 schrieb Dave Airlie: >> On 2 February 2018 at 18:02, Roland Scheidegger wrote: >>> Are you sure of that? You only get 11 stride bits to program, and they >>> are in bytes. Therefore I can't see how you

[Mesa-dev] [Bug 104928] libglvnd_1.0.0 disables amdgpu direct rendering

2018-02-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104928 Timo Aaltonen changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [PATCH] r600/atomic: fix ATOMCAS instruction.

2018-02-04 Thread Dave Airlie
From: Dave Airlie This has 3 srcs. This fixes: KHR-GL45.shader_atomic_counter_ops_tests.ShaderAtomicCounterOpsExchangeTestCase Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_shader.c | 32 +++- 1 file changed,

Re: [Mesa-dev] [PATCH 1/2] intel/compiler: fix first_component for 64-bit types on vertex inputs

2018-02-04 Thread Iago Toral
This series is still waiting for a review, any takers? On Fri, 2018-01-19 at 09:17 +0100, Iago Toral Quiroga wrote: > Divide it by two as we do for other stages. This is because the > component layout qualifier is always in 32-bit units. > > Fixes issues in a new CTS test (still WIP): >

[Mesa-dev] [PATCH v3] egl: add support for EGL_ANDROID_blob_cache

2018-02-04 Thread Tapani Pälli
v2: cleanup, move callbacks to _egl_display struct (Emil Velikov) adapt to earlier ctx->screen changes v3: remove useless checking, add _eglSetFuncName (Emil Velikov) Signed-off-by: Tapani Pälli Reviewed-by: Jordan Justen (v2) ---

[Mesa-dev] [PATCH v2] glsl/tests: changes to test_disk_cache_create test

2018-02-04 Thread Tapani Pälli
Next patch will allow disk_cache instance to be created without path set for it, modify some test cases that assume disk_cache creation to fail with invalid path. Creation should succeed but simple put/get test fail. v2: leave tests as is but check that both cache struct exists and try simple

Re: [Mesa-dev] [PATCH] spirv: split constant initializers on in/out structs

2018-02-04 Thread Iago Toral
This is still unreviewed. Jason, since you reviewed the other patch I sent related to output initializers, could you have a look at this one too? Iago On Tue, 2018-01-23 at 14:11 +0100, Iago Toral Quiroga wrote: > The SPIR-V parser splits in/out struct variables and creates > a separate

Re: [Mesa-dev] [PATCH] i965: Enable disk shader cache by default

2018-02-04 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 02/03/2018 11:58 PM, Jordan Justen wrote: Signed-off-by: Jordan Justen Reviewed-by: Timothy Arceri --- docs/relnotes/18.1.0.html | 1 +

Re: [Mesa-dev] [PATCH 1/3] android: anv/extensions: fix generated sources build

2018-02-04 Thread Tapani Pälli
On 02/04/2018 11:57 PM, Mauro Rossi wrote: Building rules are aligned to automake ones The correct script to build anv_extensions.{c,h} is anv_extensions_gen.py Generation rules for anv_extensions.c requires --out-c option Generation rules for anv_extensions.h were missing Necessary include

[Mesa-dev] [PATCH 8/9] r600: work out shader export mask at shader build time

2018-02-04 Thread Dave Airlie
From: Dave Airlie Since enhanced layouts allows setting specific MRT outputs, we can get sparse outputs, so we have to calculate the shader mask earlier. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/evergreen_state.c | 3 ++-

[Mesa-dev] [PATCH 5/9] r600/compute: add render cond support.

2018-02-04 Thread Dave Airlie
From: Dave Airlie Set render cond and emit atom. Fixes: KHR-GL45.compute_shader.conditional-dispatching Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/evergreen_compute.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH 4/9] r600: fix not-very indirect compute

2018-02-04 Thread Dave Airlie
From: Dave Airlie We need to get the grid sizes earlier to fill in to the const buffer. Fixes: KHR-GL45.compute_shader.built-in-variables and KHR-GL45.compute_shader.dispatch-indirect Signed-off-by: Dave Airlie ---

[Mesa-dev] [PATCH 2/9] r600/eg: fix buffer sizing.

2018-02-04 Thread Dave Airlie
From: Dave Airlie For buffers we want the size in bytes, For images we want it in elements. This fixes: KHR-GL45.shader_storage_buffer_object.advanced-unsizedArrayLength-cs-std430-vec-pad --- src/gallium/drivers/r600/evergreen_state.c | 4 +++- 1 file changed, 3

[Mesa-dev] [PATCH 3/9] r600: overhaul buffer resource query.

2018-02-04 Thread Dave Airlie
From: Dave Airlie This cleans up and fixes the previous fix even more. Buffers from textures start at max const, buffers from buffers/images come in from the 168 offset. This fixes a bunch of: KHR-GL45.shader_storage_buffer_object* Signed-off-by: Dave Airlie

[Mesa-dev] [PATCH 1/9] r600/images: set offset for compute shaders with number of declared samplers

2018-02-04 Thread Dave Airlie
From: Dave Airlie for frag shaders we get a value in the key, I expect I need to make compute work better --- src/gallium/drivers/r600/r600_shader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/r600_shader.c

[Mesa-dev] [PATCH 7/9] r600: fix xfb stream check.

2018-02-04 Thread Dave Airlie
From: Dave Airlie This fixes: KHR-GL45.enhanced_layouts.xfb_vertex_streams Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_shader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/r600_shader.c

[Mesa-dev] [PATCH 9/9] r600: work out target mask at framebuffer bind.

2018-02-04 Thread Dave Airlie
From: Dave Airlie If we only get 1,2,3,6 framebuffers we want a sparse target mask. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/evergreen_state.c | 10 +++--- src/gallium/drivers/r600/r600_pipe.h | 1 +

[Mesa-dev] [PATCH] r600: fixup sparse color exports.

2018-02-04 Thread Dave Airlie
From: Dave Airlie If we have gaps in the shader mask we have to have 0x1 in them according to a comment in radeonsi, and this is required to fix the test at least on cayman. We also need to record the highest one written to write to the ps exports reg. This fixes:

[Mesa-dev] [Bug 104928] libglvnd_1.0.0 disables amdgpu direct rendering

2018-02-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104928 fin4...@hotmail.com changed: What|Removed |Added Status|RESOLVED|VERIFIED

[Mesa-dev] [PATCH] nvc0: collapse output slots to have adjacent registers

2018-02-04 Thread Ilia Mirkin
The hardware skips over unallocated slots, so we have to make sure those registers are packed together. Fixes KHR-GL45.enhanced_layouts.fragment_data_location_api Signed-off-by: Ilia Mirkin --- Tested on GK208. Needs testing on Fermi, as I seem to recall it had slightly

[Mesa-dev] [PATCH] r600/sb/cayman: fix indirect ubo access on cayman

2018-02-04 Thread Dave Airlie
From: Dave Airlie With sb enabled on cayman, this was overwriting the proper cf index value with random ones if the dst gpr was 2 or 3, only save the value for a MOVA instruction. Fixes: KHR-GL45.gpu_shader5.uniform_blocks_array_indexing (on cayman with sb) Signed-off-by:

[Mesa-dev] [PATCH 6/9] r600/compute: only mark buffer/image state dirty for fragment shaders

2018-02-04 Thread Dave Airlie
From: Dave Airlie The compute emission path always emits this currently, and emitting it on the fragment path breaks the blitter. This fixes gpu hangs in KHR-GL45.compute_shader.resource-texture Signed-off-by: Dave Airlie ---