Re: [Mesa-dev] [PATCH v5 1/2] anv/cmd_buffer: consider multiview masks for tracking pending clear aspects

2018-03-28 Thread Iago Toral
On Tue, 2018-03-27 at 09:06 -0700, Jason Ekstrand wrote: > I'm sorry I've been so incredibly out-to-lunch on reviewing this. :-( > > On Tue, Mar 27, 2018 at 12:53 AM, Iago Toral Quiroga om> wrote: > > When multiview is active a subpass clear may only clear a subset of > > the >

Re: [Mesa-dev] [PATCH 4/4] radeonsi: simplify DCC format categories

2018-03-28 Thread Samuel Pitoiset
Patches 2-4 are: Reviewed-by: Samuel Pitoiset On 03/27/2018 02:39 AM, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeon/r600_texture.c | 29 + 1 file changed, 9 insertions(+), 20 deletions(-)

[Mesa-dev] [PATCH 1/2] compiler/nir: add a is_image_sample_dref flag to texture instructions

2018-03-28 Thread Iago Toral Quiroga
So we can recognize image sampling instructions that involve a depth comparison against a reference, such as SPIR-V's OpImageSample{Proj}Dref{Explicit,Implicit}Lod and we can acknowledge that they return a single scalar value instead of a vec4. --- src/compiler/nir/nir.h | 9 +

[Mesa-dev] [PATCH 2/2] compiler/spirv: set is_image_sample_dref when required

2018-03-28 Thread Iago Toral Quiroga
Fixes crashes in: dEQP-VK.spirv_assembly.instruction.graphics.image_sampler.depth_property.* --- src/compiler/spirv/spirv_to_nir.c | 4 1 file changed, 4 insertions(+) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index 7888e1b746..719e74c386 100644 ---

[Mesa-dev] [PATCH v3 2/4] gallium: add initial support for conservative rasterization

2018-03-28 Thread Rhys Perry
--- src/gallium/docs/source/cso/rasterizer.rst | 23 +++ src/gallium/docs/source/screen.rst | 18 ++ src/gallium/drivers/etnaviv/etnaviv_screen.c | 10 ++ src/gallium/drivers/freedreno/freedreno_screen.c | 10 ++

[Mesa-dev] [PATCH v3 3/4] st/mesa: add support for nvidia conservative rasterization extensions

2018-03-28 Thread Rhys Perry
--- src/mesa/state_tracker/st_atom_rasterizer.c | 15 + src/mesa/state_tracker/st_context.c | 2 ++ src/mesa/state_tracker/st_extensions.c | 34 + 3 files changed, 51 insertions(+) diff --git a/src/mesa/state_tracker/st_atom_rasterizer.c

[Mesa-dev] [PATCH v3 0/4] Implement Various Conservative Rasterization Extensions

2018-03-28 Thread Rhys Perry
This patch-set adds support for GL_NV_conservative_raster and GL_NV_conservative_raster_dilate on GM2xx and newer. It also adds support for GL_NV_conservative_raster_pre_snap_triangles on GP1xx. In doing so, it implements various functions in mesa core, extends the Gallium API, connects the new

[Mesa-dev] [Bug 105784] mesa-18.0.0/src/intel/vulkan/anv_nir_apply_pipeline_layout.c:150: bad assert ?

2018-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105784 --- Comment #1 from Lionel Landwerlin --- Thanks, this was fixed recently in commit : commit 0cc7370733e9d20999d13c4c8565f0c91846a45c Author: Grazvydas Ignotas Date: Tue Jan 23

[Mesa-dev] [PATCH] vbo: Use alloca for _vbo_draw_indirect.

2018-03-28 Thread Mathias . Froehlich
From: Mathias Fröhlich Marek, you mean with the below patch as the 9-th change in the series? I would like to keep that change seprarate from #3 since patch #3 just moves the already existing impelentation to the driver_functions level using the exactly identical

Re: [Mesa-dev] [PATCH] radv: only enable one channel when exporting prim id

2018-03-28 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Tue, Mar 20, 2018 at 10:07 AM, Samuel Pitoiset wrote: > It's a 32-bit integer like the layer. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_nir_to_llvm.c | 2 +- >

[Mesa-dev] [PATCH v3 1/4] mesa: add support for nvidia conservative rasterization extensions

2018-03-28 Thread Rhys Perry
Although the specs are written against compatibility GL 4.3 and allows core profile and GLES2+, it is exposed for GL 1.0+ and GLES1 and GLES2+. --- src/mapi/glapi/gen/gl_API.xml | 47 +++ src/mapi/glapi/gen/gl_genexec.py| 1 + src/mesa/Makefile.sources |

[Mesa-dev] [PATCH v3 4/4] nvc0: add conservative rasterization support

2018-03-28 Thread Rhys Perry
Subpixel precision bias, dilation and the post-snap mode are supported on GM200 and newer. The pre-snap mode is supported for triangle primitives on GP100. --- src/gallium/drivers/nouveau/nvc0/mme/com9097.mme | 32 ++ src/gallium/drivers/nouveau/nvc0/mme/com9097.mme.h | 22

Re: [Mesa-dev] GfxBench & CSDof failures

2018-03-28 Thread Eero Tamminen
Hi, On 28.03.2018 13:27, Eero Tamminen wrote: Mesa built from following (last evening) commit: commit 76dfed8ae2d5c6c509eb2661389be3c6a25077df Author: Rob Clark AuthorDate: Thu Mar 15 18:42:44 2018 -0400 Commit: Rob Clark

Re: [Mesa-dev] [PATCH] i965: annotate brw_oa.py's --header and --code as required

2018-03-28 Thread Eero Tamminen
Hi, On 20.03.2018 19:06, Dylan Baker wrote: Quoting Emil Velikov (2018-03-20 09:29:00) [snip] gens = [] for xml_file in args.xml_files: @@ -617,7 +610,7 @@ def main(): """)) -c("#include \"" + os.path.basename(args.header) + "\"") +c("#include \"" +

[Mesa-dev] [PATCH 1/3] spirv: Handle location decorations on block interface members

2018-03-28 Thread Neil Roberts
Previously the code was taking any location decoration on the block and using that to calculate the member locations for all of the members. I think this was assuming that there would only be one location decoration for the entire block. According to the Vulkan spec it is possible to add location

[Mesa-dev] [PATCH 3/3] spirv: Don’t use special semantics when counting vertex attribute size

2018-03-28 Thread Neil Roberts
Under Vulkan, the double vertex attributes take up the same size regardless of whether they are vertex inputs or any other stage interface. --- There is a test for this on the tests branch of VkRunner: https://github.com/Igalia/vkrunner/tree/tests ./src/vkrunner

[Mesa-dev] [PATCH 2/3] glsl_types: Rename parameter of glsl_count_attribute_slots

2018-03-28 Thread Neil Roberts
glsl_count_attribute_slots takes a parameter to specify whether the type is being used as a vertex input because on GL double attributes only take up one slot. Vulkan doesn’t make this distinction so this patch renames the argument to is_gl_vertex_input in order to make it more clear that it

[Mesa-dev] [Bug 105775] F1 2017 crashes on GCN 1.0 cards

2018-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105775 --- Comment #1 from Samuel Pitoiset --- Hi, Can you build mesa with debug symbols and attach a backtrace? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

Re: [Mesa-dev] [PATCH mesa] meson/configure: detect endian.h instead of trying to guess when it's available

2018-03-28 Thread Eric Engestrom
On Wednesday, 2018-03-28 14:05:00 +1100, Jonathan Gray wrote: > On Tue, Mar 27, 2018 at 07:36:17PM +0100, Emil Velikov wrote: > > On 25 March 2018 at 09:06, Jonathan Gray wrote: > > > On Wed, Mar 21, 2018 at 05:09:17PM +, Eric Engestrom wrote: > > >> Cc: Maxin B. John

Re: [Mesa-dev] [PATCH 1/4] ac/surface: set AddrSurfInfoIn.format = ADDR_FMT_8, add assertions

2018-03-28 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Tue, 27 Mar 2018, 10:08 Samuel Pitoiset, wrote: > Tested-by: Samuel Pitoiset > > On 03/27/2018 02:39 AM, Marek Olšák wrote: > > From: Marek Olšák > > > >

[Mesa-dev] [Bug 105783] mesa-18.0.0/src/gallium/drivers/vc5/vc5_draw.c:589: duplicate expression ?

2018-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105783 Bug ID: 105783 Summary: mesa-18.0.0/src/gallium/drivers/vc5/vc5_draw.c:589: duplicate expression ? Product: Mesa Version: 17.3 Hardware: Other OS: All

[Mesa-dev] [Bug 104626] broadcom/vc5: double compare

2018-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104626 Grazvydas Ignotas changed: What|Removed |Added CC|

[Mesa-dev] [Bug 105783] mesa-18.0.0/src/gallium/drivers/vc5/vc5_draw.c:589: duplicate expression ?

2018-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105783 Grazvydas Ignotas changed: What|Removed |Added Resolution|--- |DUPLICATE

Re: [Mesa-dev] [PATCH 1/2] radv: add support for VK_EXT_sampler_filter_minmax

2018-03-28 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen for the series. On Sun, Mar 25, 2018 at 8:15 PM, Samuel Pitoiset wrote: > The driver only supports the required formats for now. > > Signed-off-by: Samuel Pitoiset > --- >

Re: [Mesa-dev] [PATCH] radv: Unset ZRANGE_PRECISION when depth was zeroed

2018-03-28 Thread Bas Nieuwenhuizen
No final resolution yet. I was trying to fix my minor comment, but looks like I have a bunch of CTS regressions here with the original patch, so still working on it. On Tue, Mar 27, 2018 at 2:03 PM, Juan A. Suarez Romero wrote: > On Thu, 2018-03-22 at 12:31 +, James

Re: [Mesa-dev] [PATCH] android: Use new nir intrinsics python scripts

2018-03-28 Thread Tapani Pälli
Thanks, r-b and pushed! On 27.03.2018 22:40, Stefan Schake wrote: Fixes: 76dfed8ae2d5 ("nir: mako all the intrinsics") Signed-off-by: Stefan Schake Acked-by: Rob Clark --- src/compiler/Android.nir.gen.mk | 9 + 1 file changed, 9

[Mesa-dev] [Bug 105783] mesa-18.0.0/src/gallium/drivers/vc5/vc5_draw.c:589: duplicate expression ?

2018-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105783 Eric Engestrom changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |e...@anholt.net

[Mesa-dev] [PATCH] nir+drivers: add helpers to get # of src/dest components

2018-03-28 Thread Rob Clark
Add helpers to get the number of src/dest components for an intrinsic, and update spots that were open-coding this logic to use the helpers instead. Signed-off-by: Rob Clark --- src/compiler/nir/nir.h | 22 ++

[Mesa-dev] [Bug 105775] F1 2017 crashes on GCN 1.0 cards

2018-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105775 mirh changed: What|Removed |Added CC||m...@protonmail.ch -- You

[Mesa-dev] [PATCH mesa 1/5] symbols-check: add new meta-script

2018-03-28 Thread Eric Engestrom
The next few commits will convert existing tests to use this. Signed-off-by: Eric Engestrom --- scripts/symbols-check | 68 +++ 1 file changed, 68 insertions(+) create mode 100755 scripts/symbols-check diff --git

[Mesa-dev] [PATCH mesa 5/5] egl: add symbol checking script for the glvnd case

2018-03-28 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- Am I reading it right [1], that no other symbol should be exposed? If so, we're not doing that and should fix it (before landing this patch). [1]

[Mesa-dev] [PATCH mesa 4/5] gbm: use new symbols checking script

2018-03-28 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/gbm/Makefile.am | 1 + src/gbm/gbm-symbols-check | 20 ++-- 2 files changed, 7 insertions(+), 14 deletions(-) diff --git a/src/gbm/Makefile.am b/src/gbm/Makefile.am index

[Mesa-dev] [PATCH mesa 3/5] egl: use new symbols checking script

2018-03-28 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- This currently fails on my system (meson), haven't had time to investigate yet: New ABI detected - If intentional, update the test. wl_drm_interface zwp_linux_buffer_params_v1_interface zwp_linux_dmabuf_v1_interface A priori,

[Mesa-dev] [PATCH mesa 2/5] gles: use new symbols checking script

2018-03-28 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- This will fail unless [1] lands first. [1] https://patchwork.freedesktop.org/patch/213409/ --- meson.build | 1 + src/mapi/Makefile.am | 1 + src/mapi/es1api/ABI-check | 22 --

Re: [Mesa-dev] [PATCH v3 4/4] nvc0: add conservative rasterization support

2018-03-28 Thread Ilia Mirkin
On Wed, Mar 28, 2018 at 6:35 AM, Rhys Perry wrote: > Subpixel precision bias, dilation and the post-snap mode are supported on > GM200 and newer. The pre-snap mode is supported for triangle primitives on > GP100. > --- > src/gallium/drivers/nouveau/nvc0/mme/com9097.mme

[Mesa-dev] [Bug 105755] Mesa freezes when the GLSL shader contains a `for` loop with an uninitialized `i` index/counter variable

2018-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105755 --- Comment #16 from i...@yahoo.com --- (In reply to Ilia Mirkin from comment #11) > As an aside... there's no compilation bug here. Perhaps $other driver > happens to get you a value of 0, but nothing guarantees that. Could just be > luck in

[Mesa-dev] [Bug 105755] Mesa freezes when the GLSL shader contains a `for` loop with an uninitialized `i` index/counter variable

2018-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105755 --- Comment #17 from Ilia Mirkin --- (In reply to iive from comment #16) > With SSA and phi it is very easy to find when variable is used uninitialized > and handle the case in deterministic way. So initialize all those

Re: [Mesa-dev] [PATCH 2/2 v2] nir: mako all the intrinsics

2018-03-28 Thread Mark Janes
Rob Herring writes: > On Wed, Mar 28, 2018 at 10:18 AM, Rob Clark wrote: >> On Wed, Mar 28, 2018 at 10:43 AM, Rob Herring wrote: >>> On Sun, Mar 25, 2018 at 1:10 PM, Rob Clark wrote: I threatened to do this a

Re: [Mesa-dev] [PATCH v5 1/2] anv/cmd_buffer: consider multiview masks for tracking pending clear aspects

2018-03-28 Thread Jason Ekstrand
On March 27, 2018 23:14:09 Iago Toral wrote: On Tue, 2018-03-27 at 09:06 -0700, Jason Ekstrand wrote: I'm sorry I've been so incredibly out-to-lunch on reviewing this. :-( On Tue, Mar 27, 2018 at 12:53 AM, Iago Toral Quiroga wrote: When multiview is

[Mesa-dev] [PATCH v4 0/4] Implement Various Conservative Rasterization Extensions

2018-03-28 Thread Rhys Perry
This patch-set adds support for GL_NV_conservative_raster and GL_NV_conservative_raster_dilate on GM2xx and newer. It also adds support for GL_NV_conservative_raster_pre_snap_triangles on GP1xx. In doing so, it implements various functions in mesa core, extends the Gallium API, connects the new

[Mesa-dev] [Bug 105784] mesa-18.0.0/src/intel/vulkan/anv_nir_apply_pipeline_layout.c:150: bad assert ?

2018-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105784 Lionel Landwerlin changed: What|Removed |Added Resolution|---

[Mesa-dev] [PATCH v4 1/4] mesa: add support for nvidia conservative rasterization extensions

2018-03-28 Thread Rhys Perry
Although the specs are written against compatibility GL 4.3 and allows core profile and GLES2+, it is exposed for GL 1.0+ and GLES1 and GLES2+. --- src/mapi/glapi/gen/gl_API.xml | 47 src/mapi/glapi/gen/gl_genexec.py| 1 + src/mesa/Makefile.sources

[Mesa-dev] [PATCH v4 4/4] nvc0: add conservative rasterization support

2018-03-28 Thread Rhys Perry
Subpixel precision bias, dilation and the post-snap mode are supported on GM200 and newer. The pre-snap mode is supported for triangle primitives on GP100. --- src/gallium/drivers/nouveau/nvc0/mme/com9097.mme | 30 ++ src/gallium/drivers/nouveau/nvc0/mme/com9097.mme.h | 21

[Mesa-dev] [PATCH v4 2/4] gallium: add initial support for conservative rasterization

2018-03-28 Thread Rhys Perry
Reviewed-by: Brian Paul --- src/gallium/docs/source/cso/rasterizer.rst | 23 +++ src/gallium/docs/source/screen.rst | 18 ++ src/gallium/drivers/etnaviv/etnaviv_screen.c | 10 ++

[Mesa-dev] [PATCH v4 3/4] st/mesa: add support for nvidia conservative rasterization extensions

2018-03-28 Thread Rhys Perry
Reviewed-by: Brian Paul --- src/mesa/state_tracker/st_atom_rasterizer.c | 15 + src/mesa/state_tracker/st_context.c | 2 ++ src/mesa/state_tracker/st_extensions.c | 34 + 3 files changed, 51 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 42/61] nir: Add a concept of per-member structs and a lowering pass

2018-03-28 Thread Jason Ekstrand
On March 27, 2018 21:16:25 Timothy Arceri wrote: So I've been thinking about structs and I'm pretty sure we should be able to write some passes to completely lower them away. vertex shader inputs, buffer block and shader interface blocks cannot contain structs so it

[Mesa-dev] [Bug 105775] F1 2017 crashes on GCN 1.0 cards

2018-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105775 --- Comment #3 from Samuel Pitoiset --- Well, the main problem is that I don't have any GCN 1.0 cards and when I tried on Polaris it didn't crash... You will need to clone mesa from

[Mesa-dev] [PATCH] glsl: remove unreachable assert()

2018-03-28 Thread Emil Velikov
From: Emil Velikov Earlier commit enforced that we'll bail out if the number of terminators is different than 2. With that in mind, the assert() will never trigger. Fixes: 56b867395de ("glsl: fix infinite loop caused by bug in loop unrolling pass") Cc: Timothy Arceri

Re: [Mesa-dev] [PATCH 1/3] wayland-drm: Expose server-side xbgr2101010 and abgr2101010 formats.

2018-03-28 Thread Mario Kleiner
On Tue, Mar 27, 2018 at 7:45 PM, Daniel Stone wrote: > Hi Ilia, > > On 14 March 2018 at 19:02, Ilia Mirkin wrote: >> On Tue, Mar 13, 2018 at 5:30 AM, Daniel Stone wrote: >>> On 12 March 2018 at 20:45, Mario Kleiner

Re: [Mesa-dev] [PATCH 00/61] nir: Move to using instructions for derefs

2018-03-28 Thread Rob Clark
I had noticed the code to remove dead deref's in a few of the passes (at least on your wip branch), and had wondered a bit about not just requiring all the deref related lowering to happen in ssa and possibly require dce after, although admittedly hadn't thought about it *too* much yet.. I kinda

Re: [Mesa-dev] [PATCH] st: Don't try to finalize the texture in st_render_texture().

2018-03-28 Thread Eric Anholt
Brian Paul writes: > On 03/27/2018 10:14 PM, Eric Anholt wrote: >> We can't necessarily finalize the texture at this point if we're rendering >> to a texture image whose format is different from the baselevel's format. > > This is just a test suite scenario, right? It's not

Re: [Mesa-dev] [PATCH] vc4: Fix out-of-tree build

2018-03-28 Thread Eric Anholt
Aaron Watry writes: > Signed-off-by: Aaron Watry > Cc: Eric Anholt Some day we should probably just consistently prefix our includes so we don't need so many -I. For now I've reviewed and pushed your patch. signature.asc Description: PGP

[Mesa-dev] [Bug 105775] F1 2017 crashes on GCN 1.0 cards

2018-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105775 --- Comment #10 from Dave Airlie --- I did a championship lap, there were no other cars on the screen as I'm no good at the game, they were in the lap somewhere. -- You are receiving this mail because: You are the QA

Re: [Mesa-dev] [PATCH mesa] gles: remove entrypoint check that shouldn't be there

2018-03-28 Thread Dylan Baker
Adding Ian, he understands which symbols are and aren't supposed to be exposed better than anyone. Quoting Eric Engestrom (2018-03-28 07:43:01) > Signed-off-by: Eric Engestrom > --- > If I understand the comment correctly, these should *not* be exposed, right? > They

[Mesa-dev] [PATCH mesa] u_endian: use non-underscore-prefixed BYTE_ORDER names

2018-03-28 Thread Eric Engestrom
Cc: Jonathan Gray Signed-off-by: Eric Engestrom --- Note: scons was already defining _DEFAULT_SOURCE --- Android.common.mk | 2 +- configure.ac| 2 +- meson.build | 1 + src/util/u_endian.h | 8 ++-- 4 files changed, 9

[Mesa-dev] [Bug 105755] Mesa freezes when the GLSL shader contains a `for` loop with an uninitialized `i` index/counter variable

2018-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105755 --- Comment #18 from Swyter --- I bet that integers are the most common type by a wide margin. I also bet that most of these loops are meant to be unrolled and vectorized. Covering 100% of the cases is almost

Re: [Mesa-dev] [PATCH 00/61] nir: Move to using instructions for derefs

2018-03-28 Thread Jason Ekstrand
One interesting and unexpected side effect of this series has been that dead code elimination is now required to clean up unused deref instructions. This can be a problem for passes which alter and/or delete the variable because they may leave invalid deref instructions lying around. This is

Re: [Mesa-dev] [PATCH 2/2 v2] nir: mako all the intrinsics

2018-03-28 Thread Rob Herring
On Wed, Mar 28, 2018 at 12:24 PM, Mark Janes wrote: > Rob Herring writes: > >> On Wed, Mar 28, 2018 at 10:18 AM, Rob Clark wrote: >>> On Wed, Mar 28, 2018 at 10:43 AM, Rob Herring wrote: On Sun, Mar 25, 2018 at

[Mesa-dev] [Bug 105775] F1 2017 crashes on GCN 1.0 cards

2018-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105775 --- Comment #13 from Amarildo --- Usually I test all my games on max graphical settings, that includes X-Plane, Project Cars 2, GTA V, Far Cry 4, and so on, all on 1080p with no crashes and usually close to 60 FPS.

[Mesa-dev] [Bug 104665] r600: computer shaders break Bioshock on barts (bisected)

2018-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104665 --- Comment #3 from Dave Airlie --- okay reproduced it with cayman needed a 32-bit build, it dies in a compute shader invocation alright. -- You are receiving this mail because: You are the assignee for the bug. You

[Mesa-dev] [Bug 105775] F1 2017 crashes on GCN 1.0 cards

2018-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105775 --- Comment #11 from Amarildo --- Firejail isn't the issue. Ran Steam outside of it. Then I tried compiling mesa with the above suggestion, it says "configure: error: --enable-llvm is required when building

[Mesa-dev] [PATCH] nvc0: drop image binding from BGR10A2 format

2018-03-28 Thread Ilia Mirkin
Fixes a bunch of new CTS pbo tests that use that as an output format, which the state tracker converts into buffer image writes. No part of the driver is ready for BGR10A2. It could probably be enabled on Maxwell+, but seems unnecessary. Signed-off-by: Ilia Mirkin ---

Re: [Mesa-dev] [PATCH 1/2] compiler/nir: add a is_image_sample_dref flag to texture instructions

2018-03-28 Thread Jason Ekstrand
How is this different from is_shadow? On March 28, 2018 02:33:50 Iago Toral Quiroga wrote: So we can recognize image sampling instructions that involve a depth comparison against a reference, such as SPIR-V's OpImageSample{Proj}Dref{Explicit,Implicit}Lod and we can

[Mesa-dev] [Bug 105775] F1 2017 crashes on GCN 1.0 cards

2018-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105775 --- Comment #7 from Dave Airlie --- Just FYI, Tahiti GPU, no crash here, I did one lap of Melbourne and entered the pits and exited again. -- You are receiving this mail because: You are the QA Contact for the bug.

[Mesa-dev] [Bug 105775] F1 2017 crashes on GCN 1.0 cards

2018-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105775 --- Comment #8 from Amarildo --- Meanwhile, could you test with Firejail? On Arch Linux pacman -S firejail On Debian/Ubuntu/Family apt install firejail Then edit: /etc/firejail/steam.profile and comment the

[Mesa-dev] [Bug 105775] F1 2017 crashes on GCN 1.0 cards

2018-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105775 --- Comment #9 from Amarildo --- BTW, how did you do that lap? Because if you're alone, e.g. in a time-trial event, the game runs fine. It's when running a e.g. Race Weekend and coming out of the pits that the game

Re: [Mesa-dev] [PATCH v4 12/18] i965/blorp: Update the fast clear color address.

2018-03-28 Thread Jason Ekstrand
On March 27, 2018 13:23:46 Rafael Antognolli wrote: On Tue, Mar 27, 2018 at 11:16:37AM -0700, Jason Ekstrand wrote: On Thu, Mar 8, 2018 at 8:49 AM, Rafael Antognolli wrote: On Gen10, whenever we do a fast clear, blorp will update

[Mesa-dev] [Bug 104665] r600: computer shaders break Bioshock on barts (bisected)

2018-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104665 --- Comment #2 from Dave Airlie --- Do you have version overrides, and does it still happen as I got the game, and it doesn't seem to be killing my redwood. -- You are receiving this mail because: You are the assignee

[Mesa-dev] [Bug 105775] F1 2017 crashes on GCN 1.0 cards

2018-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105775 --- Comment #6 from Amarildo --- Thanks Bas. It seems "mesa-vulkan-drivers" has debug symbols enabled for that dbg package[1]. I'll download it then run the game and attach any log files here. If that's not enough

Re: [Mesa-dev] [PATCH 00/61] nir: Move to using instructions for derefs

2018-03-28 Thread Jason Ekstrand
On March 28, 2018 16:54:33 Rob Clark wrote: I had noticed the code to remove dead deref's in a few of the passes (at least on your wip branch), and had wondered a bit about not just requiring all the deref related lowering to happen in ssa and possibly require dce after,

Re: [Mesa-dev] [PATCH 00/61] nir: Move to using instructions for derefs

2018-03-28 Thread Rob Clark
On Wed, Mar 28, 2018 at 8:16 PM, Jason Ekstrand wrote: > On March 28, 2018 16:54:33 Rob Clark wrote: > > I had noticed the code to remove dead deref's in a few of the passes > (at least on your wip branch), and had wondered a bit about not just >

[Mesa-dev] [PATCH] st/mesa: add missing GLSL_TYPE_[U]INT8 cases in st_glsl_type_dword_size()

2018-03-28 Thread Brian Paul
Silences a compiler warning about unhandled enum switch cases. --- src/mesa/state_tracker/st_glsl_types.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/state_tracker/st_glsl_types.cpp b/src/mesa/state_tracker/st_glsl_types.cpp index ef7b7fa..9ad76c9 100644 ---

Re: [Mesa-dev] [PATCH 00/61] nir: Move to using instructions for derefs

2018-03-28 Thread Jason Ekstrand
On March 28, 2018 17:43:31 Rob Clark wrote: On Wed, Mar 28, 2018 at 8:16 PM, Jason Ekstrand wrote: On March 28, 2018 16:54:33 Rob Clark wrote: I had noticed the code to remove dead deref's in a few of the passes (at least on

[Mesa-dev] [PATCH] glapi: define GL_API to be GLAPI in glapi_dispatch.c

2018-03-28 Thread Brian Paul
This fixes a Windows build warning where the prototypes for the ES function in the header file don't match the prototypes in this file because the GL_API and GLAPI macros are defined differently. --- src/mapi/glapi/glapi_dispatch.c | 5 + 1 file changed, 5 insertions(+) diff --git

[Mesa-dev] [PATCH] intel/compiler: fix return statement warning in brw_regs_negative_equal()

2018-03-28 Thread Brian Paul
Silence a gcc warning about missing return value in non-void function. For some reason, gcc 5.4.0 (at least) can't deduce that all else/if cases return a value. --- src/intel/compiler/brw_reg.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/intel/compiler/brw_reg.h

[Mesa-dev] [PATCH] gl.h: remove stale comment, trailing whitespace

2018-03-28 Thread Brian Paul
--- include/GL/gl.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/GL/gl.h b/include/GL/gl.h index 5b28480..f5bac36 100644 --- a/include/GL/gl.h +++ b/include/GL/gl.h @@ -47,9 +47,9 @@ #define GLAPI __declspec(dllimport) # else /* for use with static link

[Mesa-dev] [Bug 105775] F1 2017 crashes on GCN 1.0 cards

2018-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105775 --- Comment #12 from Dave Airlie --- -2 looks like out of device memory, you might have the game settings up to high, or too high resolution. -- You are receiving this mail because: You are the QA Contact for the bug.

[Mesa-dev] [Bug 105371] r600_shader_from_tgsi - GPR limit exceeded - shader requires 360 registers

2018-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105371 --- Comment #1 from mirh --- Can confirm it fixes shader 2 and 5 of GraphicsFuzz demo http://www.graphicsfuzz.com/benchmark/android-v1.html Should I wait for this (or, I dunno, some day sw fp64) to land before reporting of

Re: [Mesa-dev] [PATCH 42/61] nir: Add a concept of per-member structs and a lowering pass

2018-03-28 Thread Timothy Arceri
On 29/03/18 08:23, Timothy Arceri wrote: On 29/03/18 05:34, Jason Ekstrand wrote: On March 27, 2018 21:16:25 Timothy Arceri wrote: So I've been thinking about structs and I'm pretty sure we should be able to write some passes to completely lower them away. vertex

[Mesa-dev] [Bug 105775] F1 2017 crashes on GCN 1.0 cards

2018-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105775 --- Comment #5 from Bas Nieuwenhuizen --- It might be easier to install packages with the debug symbols from your distro: https://wiki.debian.org/HowToGetABacktrace though I don't know offhand which debian package

[Mesa-dev] [Bug 105775] F1 2017 crashes on GCN 1.0 cards

2018-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105775 --- Comment #4 from Amarildo --- OK, thanks :) I've looked into this[1] short explanation, but I have no "Make-config" file after cloning mesa. [1] https://www.mesa3d.org/debugging.html Is there another file I

Re: [Mesa-dev] [PATCH] vbo: Use alloca for _vbo_draw_indirect.

2018-03-28 Thread Marek Olšák
Yes, it looks good. Marek On Wed, Mar 28, 2018 at 6:35 AM, wrote: > From: Mathias Fröhlich > > > Marek, > > you mean with the below patch as the 9-th change in the series? > I would like to keep that change seprarate from #3 since patch #3

Re: [Mesa-dev] [PATCH 42/61] nir: Add a concept of per-member structs and a lowering pass

2018-03-28 Thread Jason Ekstrand
On March 28, 2018 15:25:59 Timothy Arceri wrote: On 29/03/18 08:23, Timothy Arceri wrote: On 29/03/18 05:34, Jason Ekstrand wrote: On March 27, 2018 21:16:25 Timothy Arceri wrote: So I've been thinking about structs and I'm pretty sure we should

Re: [Mesa-dev] [PATCH 42/61] nir: Add a concept of per-member structs and a lowering pass

2018-03-28 Thread Timothy Arceri
On 29/03/18 05:34, Jason Ekstrand wrote: On March 27, 2018 21:16:25 Timothy Arceri wrote: So I've been thinking about structs and I'm pretty sure we should be able to write some passes to completely lower them away. vertex shader inputs, buffer block and shader

Re: [Mesa-dev] [PATCH] glsl: remove unreachable assert()

2018-03-28 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 29/03/18 04:25, Emil Velikov wrote: From: Emil Velikov Earlier commit enforced that we'll bail out if the number of terminators is different than 2. With that in mind, the assert() will never trigger. Fixes:

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/5] i965: Hard code scratch_ids_per_subslice for Cherryview

2018-03-28 Thread Jordan Justen
On 2018-03-26 08:23:13, Juan A. Suarez Romero wrote: > On Wed, 2018-03-07 at 00:16 -0800, Jordan Justen wrote: > > Ken suggested that we might be underallocating scratch space on HD > > 400. Allocating scratch space as though there was actually 8 EUs > > seems to help with a GPU hang seen on

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/5] i965: Hard code scratch_ids_per_subslice for Cherryview

2018-03-28 Thread Juan A. Suarez Romero
On Wed, 2018-03-28 at 14:55 -0700, Jordan Justen wrote: > On 2018-03-26 08:23:13, Juan A. Suarez Romero wrote: > > On Wed, 2018-03-07 at 00:16 -0800, Jordan Justen wrote: > > > Ken suggested that we might be underallocating scratch space on > > > HD > > > 400. Allocating scratch space as though

[Mesa-dev] [PATCH 0/2] Android backtrace support

2018-03-28 Thread Stefan Schake
This series adds Android backtrace support, which is a prerequisite for using the refcount debugging tool in gallium. It also comes in handy for impromptu debug outputs. Unfortunately, it wasn't possible to reuse the existing libunwind implementation. The only sanctioned way for obtaining

[Mesa-dev] [PATCH 2/2] gallium/util: Android backtrace support

2018-03-28 Thread Stefan Schake
We can't use any of the existing implementations in u_debug_stack. Android technically has libunwind, but it's been modified to the point where it no longer compiles with the Mesa usage. The library is also not meant to be referenced by vendor libraries. The officially sanctioned way of obtaining

[Mesa-dev] [PATCH 1/2] gallium/util: Don't stub u_debug_stack on Android

2018-03-28 Thread Stefan Schake
The fallback path for no libunwind ends up being stubs for Android. Don't compile them in so we can provide our own implementation. Signed-off-by: Stefan Schake --- src/gallium/auxiliary/util/u_debug_stack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH v4 05/18] intel/isl: Add support to emit clear value address.

2018-03-28 Thread Pohjolainen, Topi
On Tue, Mar 27, 2018 at 11:01:34AM -0700, Jason Ekstrand wrote: > On Tue, Mar 27, 2018 at 4:31 AM, Pohjolainen, Topi < > topi.pohjolai...@gmail.com> wrote: > > > On Thu, Mar 08, 2018 at 08:48:58AM -0800, Rafael Antognolli wrote: > > > gen10 can emit the clear color by setting it on a buffer

[Mesa-dev] [Bug 105775] F1 2017 crashes on GCN 1.0 cards

2018-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105775 Alex Smith changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH v3 1/4] mesa: add support for nvidia conservative rasterization extensions

2018-03-28 Thread Brian Paul
Looks good overall. Just some style nit-picks below. -Brian On 03/28/2018 04:35 AM, Rhys Perry wrote: Although the specs are written against compatibility GL 4.3 and allows core profile and GLES2+, it is exposed for GL 1.0+ and GLES1 and GLES2+. --- src/mapi/glapi/gen/gl_API.xml |

Re: [Mesa-dev] [PATCH v3 3/4] st/mesa: add support for nvidia conservative rasterization extensions

2018-03-28 Thread Brian Paul
On 03/28/2018 04:35 AM, Rhys Perry wrote: --- src/mesa/state_tracker/st_atom_rasterizer.c | 15 + src/mesa/state_tracker/st_context.c | 2 ++ src/mesa/state_tracker/st_extensions.c | 34 + 3 files changed, 51 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 2/2 v2] nir: mako all the intrinsics

2018-03-28 Thread Rob Herring
On Sun, Mar 25, 2018 at 1:10 PM, Rob Clark wrote: > I threatened to do this a long time ago.. I probably *should* have done > it a long time ago when there where many fewer intrinsics. But the > system of macro/#include magic for dealing with intrinsics is a bit > annoying,

[Mesa-dev] [PATCH mesa] gles: remove entrypoint check that shouldn't be there

2018-03-28 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- If I understand the comment correctly, these should *not* be exposed, right? They aren't in any build I checked, and will cause the updated tests to fail if the check is left here. --- src/mapi/es1api/ABI-check | 3 ---

Re: [Mesa-dev] [PATCH mesa] gbm: remove never-implemented function

2018-03-28 Thread Emil Velikov
On 26 March 2018 at 15:14, Eric Engestrom wrote: > I assume this was implemented in a previous version of that commit, but > was removed in the version that actually landed. > Actually it seems like a left over from prototyping stage. Even the first version send to the

[Mesa-dev] [Bug 105775] F1 2017 crashes on GCN 1.0 cards

2018-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105775 --- Comment #2 from Amarildo --- I'll try, although I'm just a regular user ;-) Which exact package do I need to rebuild? I'd think it's not necessary to re-build everything, perhaps just "mesa-vulkan-drivers"?

Re: [Mesa-dev] [PATCH 1/2] autotools: include meson_get_version

2018-03-28 Thread Eric Engestrom
On Monday, 2018-03-26 11:20:03 -0700, Dylan Baker wrote: > Otherwise meson won't read the VERSION file and won't set a version. > That means that pkg-config files will have version unset as well. > > Signed-off-by: Dylan Baker > fixes:

[Mesa-dev] [Bug 105464] Reading per-patch outputs in Tessellation Control Shader returns undefined values

2018-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105464 --- Comment #7 from Samuel Pitoiset --- A possible fix https://reviews.llvm.org/D44974 -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

  1   2   >