[Mesa-dev] [Bug 105859] mesa update gnome-terminal crashes on editing preferences

2018-04-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105859 jackssir changed: What|Removed |Added OS|All |Linux (All) ---

Re: [Mesa-dev] [PATCH 3/3] ac: make use of if/loop build helpers

2018-04-03 Thread Alex Smith
Hi Timothy, This patch fixes some rendering issues I see with RADV on SI. It doesn't sound like it was really intended to fix anything, so possibly it's masking some other issue, but would you object to nominating the series for stable? Applying it on the 18.0 branch fixes the issue there as

[Mesa-dev] [Bug 105105] Suffixless KHR_robustness functions aren't exposed in ES 3.2

2018-04-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105105 --- Comment #6 from Tapani Pälli --- OK .. after yet another gdb session I think now I got it. What is happening is that when the test suite generates functions from khronos xml, it first sets gl.readnPixels to

Re: [Mesa-dev] [ANNOUNCE] Mesa 17.3.8 release candidate

2018-04-03 Thread Juan A. Suarez Romero
On Mon, 2018-04-02 at 13:29 +0100, Daniel Stone wrote: > Hi Juan, > > On 29 March 2018 at 11:25, Juan A. Suarez Romero wrote: > > The plan is to have 17.3.8 this Monday (2nd April), around or shortly after > > 11:00 > > GMT. > > Does this mean we could expect 17.3.9 in a

Re: [Mesa-dev] [PATCH 1/4] radv: put more fields in radv_blend_state

2018-04-03 Thread Bas Nieuwenhuizen
Series is Reviewed-by: Bas Nieuwenhuizen On Thu, Mar 29, 2018 at 3:24 PM, Samuel Pitoiset wrote: > Some will be used for further optimizations (ie. out-of-order rast). > > Signed-off-by: Samuel Pitoiset > --- >

[Mesa-dev] [PATCH] gallium: add CAP for postprocess filters

2018-04-03 Thread Timothy Arceri
For radeonsi these seem to have been somewhat broken for over a year, and as of recently they cause the driver to crash. This patch adds a CAP for the filters and enables the CAP for all driver except radeonsi. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99549 Bugzilla:

[Mesa-dev] [Bug 105859] mesa update gnome-terminal crashes on editing preferences

2018-04-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105859 Bug ID: 105859 Summary: mesa update gnome-terminal crashes on editing preferences Product: Mesa Version: 17.0 Hardware: Other OS: All Status:

Re: [Mesa-dev] [PATCH 1/2] dri: Add __DRI_IMAGE_FORMAT_SABGR8

2018-04-03 Thread Tapani Pälli
ping .. (currently Android-IA sets EGL_KHR_gl_colorspace to false because these are missing) On 03/19/2018 01:41 PM, Tapani Pälli wrote: Add format definition and required plumbing to create images. Note that there is no match to drm_fourcc definition, just like with existing

[Mesa-dev] [Bug 105105] Suffixless KHR_robustness functions aren't exposed in ES 3.2

2018-04-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105105 --- Comment #5 from Tapani Pälli --- Updating status ... my fix to dEQP went in and now we pass 'getnuniform' test, but readnpixels still fails. I did a separate GLES 3.2 app that utilizes these entrypoints, they are being

Re: [Mesa-dev] [PATCH] radv: enable VK_EXT_shader_viewport_index_layer

2018-04-03 Thread Bas Nieuwenhuizen
Has someone grown tests for this since the time I sent patches for enabling this to the list? Reviewed-by: Bas Nieuwenhuizen On Mon, Apr 2, 2018 at 6:17 PM, Samuel Pitoiset wrote: > The driver already supports exporting the Layer and

[Mesa-dev] [Bug 105832] radeonsi NIR missing bindless textures support

2018-04-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105832 --- Comment #17 from b...@besd.de --- I tried manually enabling ARB_bindless_texture with TGSI for the remaining feral Games, but they dont seem to profit from it or crash: Deus Ex: Mankind Divided: - with bindless first run

[Mesa-dev] [PATCH v2] compiler/spirv: set is_shadow for depth comparitor sampling opcodes

2018-04-03 Thread Iago Toral Quiroga
From the SPIR-V spec, OpTypeImage: "Depth is whether or not this image is a depth image. (Note that whether or not depth comparisons are actually done is a property of the sampling opcode, not of this type declaration.)" The sampling opcodes that specify depth comparisons are

Re: [Mesa-dev] [PATCH 3/3] ac: make use of if/loop build helpers

2018-04-03 Thread Alex Smith
I don't know exactly what's causing it, no. I noticed the issue was fixed on master so just bisected to this. CC'ing stable to nominate: 42627dabb4db3011825a022325be7ae9b51103d6 - (1/3) ac: add if/loop build helpers 6e1a142863b368a032e333f09feb107241446053 - (2/3) radeonsi: make use of if/loop

[Mesa-dev] [PATCH] glsl_to_nir: fix ir_binop_vector_extract handling

2018-04-03 Thread Andriy Khulap
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105438 Signed-off-by: Andriy Khulap Signed-off-by: Vadym Shovkoplias --- src/compiler/glsl/glsl_to_nir.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 3/3] ac: make use of if/loop build helpers

2018-04-03 Thread Timothy Arceri
I have no issue with these going in stable if they fix bugs. Ideally we should create a piglit test to catch this also but presumably you guys don't actually know the exact shader combination thats tripping things up? On 03/04/18 19:36, Samuel Pitoiset wrote: This fixes a rendering issue with

Re: [Mesa-dev] [PATCH 3/3] ac: make use of if/loop build helpers

2018-04-03 Thread Samuel Pitoiset
This fixes a rendering issue with Wolfenstein 2 as well. A backport sounds reasonable to me. On 04/03/2018 11:33 AM, Alex Smith wrote: Hi Timothy, This patch fixes some rendering issues I see with RADV on SI. It doesn't sound like it was really intended to fix anything, so possibly it's

[Mesa-dev] [Bug 105105] Suffixless KHR_robustness functions aren't exposed in ES 3.2

2018-04-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105105 --- Comment #7 from Tapani Pälli --- OK, sent a fix to vk-gl-cts suite to reorder EXT and KHR resolving so that KHR is preferred over EXT. It might be this is not the only case where such reordering is required and maybe more

[Mesa-dev] Status of radeonsi NIR

2018-04-03 Thread Benedikt Schemmer
Hi Timothy, I put up another run for you with llvm 7 and mesa git of this morning. Also I pruned duplicate shaders (especially Metro Redux had significant amounts of those) so we're down to ~24k unique shaders. I'm going to use release builds for testing because there is no difference to the

Re: [Mesa-dev] [PATCH v3] mesa: readpixels add support for GL_HALF_FLOAT

2018-04-03 Thread Tapani Pälli
On 04/03/2018 08:59 AM, Lin, Johnson wrote: Guy, Then how can we deal with android.view.cts.PixelCopyTest #TestWindowProducerCopyToRGBA16F It is blocked by this error check.. It looks like that test is broken (behaving against GL ES conformance test) and needs to be fixed.

Re: [Mesa-dev] [PATCH v3] mesa: readpixels add support for GL_HALF_FLOAT

2018-04-03 Thread Lin, Johnson
Guy, Then how can we deal with android.view.cts.PixelCopyTest #TestWindowProducerCopyToRGBA16F It is blocked by this error check.. -Original Message- From: Palli, Tapani Sent: Tuesday, April 3, 2018 1:42 PM To: Eric Anholt ; Lin, Johnson ;

Re: [Mesa-dev] [PATCH] mesa: ensure that variable is initialized

2018-04-03 Thread Alejandro Piñeiro
Thanks for the patch! Reviewed-by: Alejandro Piñeiro On 03/04/18 00:36, Dylan Baker wrote: > Otherwise this variable will only be set if there are spirv shaders > present, but it's used regardless, resulting in undefined behavior. > > Bugzilla:

Re: [Mesa-dev] [PATCH] compiler/spirv: set is_shadow for depth comparitor sampling opcodes

2018-04-03 Thread Iago Toral
On Mon, 2018-04-02 at 09:31 -0700, Jason Ekstrand wrote: > > On April 2, 2018 04:04:49 Iago Toral Quiroga > wrote: > > From the SPIR-V spec, OpTypeImage: > > "Depth is whether or not this image is a depth image. (Note that > whether or not depth comparisons are actually done

[Mesa-dev] [Bug 105846] Assertion failure @ st_atom_array.c:675

2018-04-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105846 l...@protonmail.ch changed: What|Removed |Added CC||l...@protonmail.ch -- You are

[Mesa-dev] [Bug 105846] Assertion failure @ st_atom_array.c:675 when playing Natural Selection 2

2018-04-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105846 l...@protonmail.ch changed: What|Removed |Added Summary|Assertion failure @ |Assertion failure @

[Mesa-dev] [PATCH 0/4] nir: add support for bindless_texture

2018-04-03 Thread Karol Herbst
I think most of the changes are straigh forward. The changes needed for images should be discussed, because in its current form it would require changing all drivers using nir and supporting images. Karol Herbst (4): nir/split_var_copies: handle IMAGE and SAMPLER for bindless vars nir: add

[Mesa-dev] [PATCH 4/4] RFC nir: add support for bindless_texture images

2018-04-03 Thread Karol Herbst
I added another source for all image_var_* intrinsics. Drivers have to be adjusted with this change. There was some discussion to add new intrinsics to handle operations on bindless images. Maybe we can continue with this here? Signed-off-by: Karol Herbst ---

[Mesa-dev] [PATCH 3/4] glsl/nir: fix variable type for image intrinsics and ubos

2018-04-03 Thread Karol Herbst
If the bindless image is passed through a struct we ended up getting the glsl_type of the struct, not the image. variable_referenced points to the declaration of the struct, so it won't work for bindless images. So just drop it. Signed-off-by: Karol Herbst ---

[Mesa-dev] [PATCH 2/4] nir: add support for bindless_texture samplers

2018-04-03 Thread Karol Herbst
Signed-off-by: Karol Herbst --- src/compiler/glsl/glsl_to_nir.cpp | 17 +++-- src/compiler/nir/nir.h| 1 + src/compiler/nir/nir_print.c | 3 +++ 3 files changed, 19 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/glsl_to_nir.cpp

[Mesa-dev] [PATCH 1/4] nir/split_var_copies: handle IMAGE and SAMPLER for bindless vars

2018-04-03 Thread Karol Herbst
Signed-off-by: Karol Herbst --- src/compiler/nir/nir_split_var_copies.c | 4 1 file changed, 4 insertions(+) diff --git a/src/compiler/nir/nir_split_var_copies.c b/src/compiler/nir/nir_split_var_copies.c index bc3ceedbdb8..231a89add4d 100644 ---

Re: [Mesa-dev] [PATCH 2/4] nir: add support for bindless_texture samplers

2018-04-03 Thread Karol Herbst
On Tue, Apr 3, 2018 at 3:21 PM, Karol Herbst wrote: > Signed-off-by: Karol Herbst > --- > src/compiler/glsl/glsl_to_nir.cpp | 17 +++-- > src/compiler/nir/nir.h| 1 + > src/compiler/nir/nir_print.c | 3 +++ > 3 files

Re: [Mesa-dev] [PATCH] glapi: define GL_API to be KEYWORD1 in glapi_dispatch.c (v2)

2018-04-03 Thread Emil Velikov
On 30 March 2018 at 19:52, Brian Paul wrote: > This fixes a Windows build warning where the prototypes for the ES > function in the header file don't match the prototypes in this file > because the GL_API and GLAPI macros are defined differently. > > v2: defined GL_API to

Re: [Mesa-dev] [PATCH] i965: Extend the negative 32-bit deltas to 64-bits

2018-04-03 Thread Emil Velikov
On 27 March 2018 at 09:40, Sergii Romantsov wrote: > Hello Chris and Emil. > Could we make a final decision? Because I'm bit confused what you are > expecting exactly. > > I would prefer to left initial patch as is (if its possible). > Same inclination here. Changing

[Mesa-dev] [PATCH v2 2/5] i965: perf: snapshot RPSTAT register

2018-04-03 Thread Lionel Landwerlin
This register contains the current/previous frequency of the GT, it's one of the value GPA would like to have as part of their queries. v2: Don't use this register on baytrail/cherryview (Ken) Use GET_FIELD() macro (Ken) Signed-off-by: Lionel Landwerlin ---

[Mesa-dev] [PATCH v2 5/5] i965: perf: enable GPA query statistics

2018-04-03 Thread Lionel Landwerlin
The combinaison of GPA/MDAPI components expects a particular name & layout for their pipeline statistics query. v2: Limit the query GPA/MDAPI statistics to gen7->9 (Lionel) Signed-off-by: Lionel Landwerlin --- src/mesa/drivers/dri/i965/brw_performance_query.c |

[Mesa-dev] [PATCH v2 0/5] i965: enable GPA

2018-04-03 Thread Lionel Landwerlin
Hi all, Here is an update on the series to enable GPA [1] through the GL_INTEL_performance_query extension. A couple of issues were raised by Ken on patch 2 and I also extended the raw queries up to gen 11 in patch 4. Cheers, [1] : https://software.intel.com/en-us/gpa Lionel Landwerlin (5):

[Mesa-dev] [PATCH v2 3/5] i965: perf: read slice/unslice frequencies from OA reports

2018-04-03 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/mesa/drivers/dri/i965/brw_performance_query.c | 37 +++ src/mesa/drivers/dri/i965/brw_performance_query.h | 12 2 files changed, 49 insertions(+) diff --git

[Mesa-dev] [PATCH v2 1/5] i965: perf: extract utility functions

2018-04-03 Thread Lionel Landwerlin
We would like to reuse a number of the functions and structures in another file in a future commit. We also move the previous content of brw_performance_query.h into brw_performance_query_metrics.h to be included by generated metrics files. Signed-off-by: Lionel Landwerlin

[Mesa-dev] [PATCH v2 4/5] i965: perf: add support for raw queries

2018-04-03 Thread Lionel Landwerlin
The INTEL_performance_query extension provides a list of queries that a user can select to monitor a particular workload. Each query reports different sets of counters (roughly looking at different parts of the hardware, i.e. caches/fixed functions/etc...). Each query has an associated

Re: [Mesa-dev] [PATCH] radv: enable VK_EXT_shader_viewport_index_layer

2018-04-03 Thread Caio Marcelo de Oliveira Filho
Hi, On Tue, Apr 03, 2018 at 12:01:00PM +0200, Bas Nieuwenhuizen wrote: > Has someone grown tests for this since the time I sent patches for > enabling this to the list? I've written tests for Vulkan CTS. One already landed

Re: [Mesa-dev] [PATCH v5 06/19] intel/isl: Add support to emit clear value address.

2018-04-03 Thread Pohjolainen, Topi
On Tue, Apr 03, 2018 at 06:05:06PM +0300, Pohjolainen, Topi wrote: > On Thu, Mar 29, 2018 at 10:58:40AM -0700, Rafael Antognolli wrote: > > gen10 can emit the clear color by setting it on a buffer somewhere, and > > then adding only the address to the surface state. > > > > This commit add

Re: [Mesa-dev] [PATCH 08/11] i965: perf: snapshot RPSTAT1 register

2018-04-03 Thread Lionel Landwerlin
On 23/03/18 18:00, Kenneth Graunke wrote: On Thursday, March 8, 2018 7:42:53 AM PDT Lionel Landwerlin wrote: This register contains the frequency of the GT, it's one of the value GPA would like to have as part of their queries. Signed-off-by: Lionel Landwerlin

Re: [Mesa-dev] [PATCH v5 06/19] intel/isl: Add support to emit clear value address.

2018-04-03 Thread Pohjolainen, Topi
On Thu, Mar 29, 2018 at 10:58:40AM -0700, Rafael Antognolli wrote: > gen10 can emit the clear color by setting it on a buffer somewhere, and > then adding only the address to the surface state. > > This commit add support for that on isl_surf_fill_state, and if that is > requested, skip setting

[Mesa-dev] [PATCH 4/5] intel: genxml: decode variable length MI_LRI

2018-04-03 Thread Lionel Landwerlin
MI_LOAD_REGISTER_IMM can load multiple (register, value) tuples in one command. In our drivers we only use one tuple at a time, but the kernel might load more than one at a time. Instead of making all the tuple part of a group, we leave out the first tuple (the one we use in the generated packing

[Mesa-dev] [PATCH 5/5] intel: gen-decoder: print all dword a field belongs to

2018-04-03 Thread Lionel Landwerlin
Prior to printing a decoded field, print out all dwords that field belongs to. In particular with address fields spanning multiple dwords, we want to have all the dwords presented before the field is decoded to make it easier to read. Signed-off-by: Lionel Landwerlin

[Mesa-dev] [PATCH 0/5] intel: error_decode improvements

2018-04-03 Thread Lionel Landwerlin
Hi all, This is a small series improving some aspects of aubinator_error_decode (in particular WA batch buffers which are available in the error state). Cheers, Lionel Landwerlin (5): intel: genxml: add preemption control instructions intel: error_decode: add an option to decode all buffers

[Mesa-dev] [PATCH 3/5] intel: gen-decoder: don't decode fields beyond a dword length

2018-04-03 Thread Lionel Landwerlin
For example, a PIPE_CONTROL with DWordLength = 2 should look like this : 0xe374: 0x7a02: PIPE_CONTROL 0xe374: 0x7a02 : Dword 0 DWord Length: 2 0xe378: 0x0080 : Dword 1 Depth Cache Flush Enable: false Stall At Pixel Scoreboard: false State Cache

[Mesa-dev] [PATCH 2/5] intel: error_decode: add an option to decode all buffers

2018-04-03 Thread Lionel Landwerlin
The kernel reports workaround batch buffers, but we're not presenting them currently. Also they might not be useful for debugging purely userspace driver issues, when problems arise because of interactions between kernel & userspace drivers, it's nice to be able to decode them. Signed-off-by:

[Mesa-dev] [PATCH 1/5] intel: genxml: add preemption control instructions

2018-04-03 Thread Lionel Landwerlin
Helpful to debug kernel workaround batchbuffers. Signed-off-by: Lionel Landwerlin --- src/intel/genxml/gen10.xml | 7 +++ src/intel/genxml/gen11.xml | 7 +++ src/intel/genxml/gen8.xml | 6 ++ src/intel/genxml/gen9.xml | 6 ++ 4 files changed, 26

Re: [Mesa-dev] [PATCH] i965: Extend the negative 32-bit deltas to 64-bits

2018-04-03 Thread Chris Wilson
Quoting Sergii Romantsov (2018-04-02 07:59:06) > Gen8+ use 48-bit address relocations so need to extend the sign > to 64-bit return value. Without it we have higher bits zeroed > and missing the negavive values. > Haswell and older use 32-bit deltas so are unaffected by this issue. > > v2: >

[Mesa-dev] [PATCH 2/2] intel/blorp/icl: Enable clear color conversion when fast clearing

2018-04-03 Thread Topi Pohjolainen
CC: Rafael Antognolli CC: Jordan Justen CC: Jason Ekstrand Signed-off-by: Topi Pohjolainen --- src/intel/blorp/blorp_genX_exec.h | 2 ++ 1 file changed, 2 insertions(+) diff --git

[Mesa-dev] [PATCH 1/2] intel/isl: Add support for enabling clear color conversion

2018-04-03 Thread Topi Pohjolainen
CC: Rafael Antognolli CC: Jordan Justen CC: Jason Ekstrand Signed-off-by: Topi Pohjolainen --- src/intel/isl/isl.h | 6 ++ src/intel/isl/isl_surface_state.c | 11

Re: [Mesa-dev] [PATCH 05/55] radeonsi: use num_cs_dw_queries_suspend

2018-04-03 Thread Marek Olšák
On Tue, Apr 3, 2018 at 12:54 AM, Timothy Arceri wrote: > This is the only patch that seems to have a functional change. I have no > idea what this is doing from a glance, are you able to put a little comment > on why this is needed in the commit message? > Yes sure. > >

[Mesa-dev] [PATCH] st/mesa: Also use PIPE_FORMAT_R8G8B8A8_SRGB for framebuffer_sRGB.

2018-04-03 Thread Jakob Bornecrantz
When running virgl on a GLES host the only sRGB formats that support rendering is RGBA and RGBX. That pipe format is in the sRGB default lists that the state tracker uses when mapping mesa formats. Cheers, Jakob. Signed-off-by: Jakob Bornecrantz ---

[Mesa-dev] [PATCH] intel/blorp/hiz: Emit CC viewport

2018-04-03 Thread Topi Pohjolainen
Otherwise simulator for ICL complains that: B-spec CC_ViewPort Minimum Depth cannot be greater than Maximum Depth CC: Jason Ekstrand CC: Kenneth Graunke Signed-off-by: Topi Pohjolainen ---

[Mesa-dev] [PATCH] Revert "mesa: add GL_HALF_FLOAT as supported type to readpixels"

2018-04-03 Thread Eric Anholt
From GLES 3.0.2: Only two combinations of format and type are accepted in most cases. The first varies depending on the format of the currently bound rendering surface. For normalized fixed-point rendering surfaces, the combination format RGBA and type UNSIGNED_BYTE is

[Mesa-dev] [PATCH] intel: compiler: silence compiler warning

2018-04-03 Thread Lionel Landwerlin
../src/intel/compiler/brw_reg.h: In function ‘bool brw_regs_negative_equal(const brw_reg*, const brw_reg*)’: ../src/intel/compiler/brw_reg.h:305:1: warning: control reaches end of non-void function [-Wreturn-type] Introduced by 8f83eea71e233 ("i965: Add negative_equals methods").

Re: [Mesa-dev] [PATCH 0/5] intel: error_decode improvements

2018-04-03 Thread Scott D Phillips
Lionel Landwerlin writes: > Hi all, > > This is a small series improving some aspects of > aubinator_error_decode (in particular WA batch buffers which are > available in the error state). > > Cheers, > > Lionel Landwerlin (5): > intel: genxml: add preemption

Re: [Mesa-dev] [PATCH v5 06/19] intel/isl: Add support to emit clear value address.

2018-04-03 Thread Pohjolainen, Topi
On Tue, Apr 03, 2018 at 08:43:54AM -0700, Rafael Antognolli wrote: > On Tue, Apr 03, 2018 at 06:05:06PM +0300, Pohjolainen, Topi wrote: > > On Thu, Mar 29, 2018 at 10:58:40AM -0700, Rafael Antognolli wrote: > > > gen10 can emit the clear color by setting it on a buffer somewhere, and > > > then

Re: [Mesa-dev] [PATCH 1/5] intel: genxml: add preemption control instructions

2018-04-03 Thread Lionel Landwerlin
On 03/04/18 16:40, Chris Wilson wrote: Quoting Lionel Landwerlin (2018-04-03 14:27:53) Helpful to debug kernel workaround batchbuffers. And ringbuffers. Can you include MI_ARB_CHK here as well if not already? That will be useful for some cases. -Chris Already there as MI_ARB_CHECK.

Re: [Mesa-dev] [PATCH v5 06/19] intel/isl: Add support to emit clear value address.

2018-04-03 Thread Rafael Antognolli
On Tue, Apr 03, 2018 at 06:53:18PM +0300, Pohjolainen, Topi wrote: > On Tue, Apr 03, 2018 at 06:50:09PM +0300, Pohjolainen, Topi wrote: > > On Tue, Apr 03, 2018 at 08:43:54AM -0700, Rafael Antognolli wrote: > > > On Tue, Apr 03, 2018 at 06:05:06PM +0300, Pohjolainen, Topi wrote: > > > > On Thu,

[Mesa-dev] [PATCH] virgl: Update virgl_hw.h

2018-04-03 Thread Jakob Bornecrantz
Signed-off-by: Jakob Bornecrantz --- src/gallium/drivers/virgl/virgl_hw.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/virgl/virgl_hw.h b/src/gallium/drivers/virgl/virgl_hw.h index 93849c03dd..180dead80a 100644 ---

Re: [Mesa-dev] [PATCH 03/14] i965: Make the miptree clear color setter take a gl_color_union

2018-04-03 Thread Pohjolainen, Topi
On Fri, Mar 30, 2018 at 11:12:16AM -0700, Nanley Chery wrote: > We want to hide the internal details of how the miptree's clear color > is calculated. Patches 1-3: Reviewed-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/brw_blorp.c | 5 + >

Re: [Mesa-dev] [PATCH] Revert "mesa: add GL_HALF_FLOAT as supported type to readpixels"

2018-04-03 Thread Eric Anholt
Eric Anholt writes: > From GLES 3.0.2: > > Only two combinations of format and type are accepted in most > cases. The first varies depending on the format of the currently > bound rendering surface. For normalized fixed-point rendering > surfaces, the

Re: [Mesa-dev] [PATCH 1/5] intel: genxml: add preemption control instructions

2018-04-03 Thread Chris Wilson
Quoting Lionel Landwerlin (2018-04-03 14:27:53) > Helpful to debug kernel workaround batchbuffers. And ringbuffers. Can you include MI_ARB_CHK here as well if not already? That will be useful for some cases. -Chris ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH v5 06/19] intel/isl: Add support to emit clear value address.

2018-04-03 Thread Rafael Antognolli
On Tue, Apr 03, 2018 at 06:05:06PM +0300, Pohjolainen, Topi wrote: > On Thu, Mar 29, 2018 at 10:58:40AM -0700, Rafael Antognolli wrote: > > gen10 can emit the clear color by setting it on a buffer somewhere, and > > then adding only the address to the surface state. > > > > This commit add

Re: [Mesa-dev] [PATCH] vbo: Use alloca for _vbo_draw_indirect.

2018-04-03 Thread Jon Turney
On 28/03/2018 11:35, mathias.froehl...@gmx.net wrote: Avoid using malloc in the draw path of mesa. Since the draw_count is a user api input, fall back to malloc if the amount of consumed stack space may get too high. Signed-off-by: Mathias Fröhlich ---

[Mesa-dev] [PATCH] st/mesa: set stencil border color the same as intensity

2018-04-03 Thread Marek Olšák
From: Marek Olšák This fixes some stencil border color tests on Vega and Raven chips. --- src/mesa/state_tracker/st_format.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/state_tracker/st_format.c b/src/mesa/state_tracker/st_format.c index

Re: [Mesa-dev] [PATCH v5 06/19] intel/isl: Add support to emit clear value address.

2018-04-03 Thread Pohjolainen, Topi
On Tue, Apr 03, 2018 at 06:50:09PM +0300, Pohjolainen, Topi wrote: > On Tue, Apr 03, 2018 at 08:43:54AM -0700, Rafael Antognolli wrote: > > On Tue, Apr 03, 2018 at 06:05:06PM +0300, Pohjolainen, Topi wrote: > > > On Thu, Mar 29, 2018 at 10:58:40AM -0700, Rafael Antognolli wrote: > > > > gen10 can

Re: [Mesa-dev] [PATCH v2] compiler/spirv: set is_shadow for depth comparitor sampling opcodes

2018-04-03 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand Cc: mesa-sta...@lists.freedesktop.org On Tue, Apr 3, 2018 at 2:24 AM, Iago Toral Quiroga wrote: > From the SPIR-V spec, OpTypeImage: > > "Depth is whether or not this image is a depth image. (Note that > whether or not depth

Re: [Mesa-dev] [PATCH] st/mesa: Also use PIPE_FORMAT_R8G8B8A8_SRGB for framebuffer_sRGB.

2018-04-03 Thread Jakob Bornecrantz
Thanks for the review. Cheers, Jakob. On Tue, Apr 3, 2018 at 5:37 PM, Brian Paul wrote: > On 04/03/2018 10:06 AM, Jakob Bornecrantz wrote: >> >> When running virgl on a GLES host the only sRGB formats that support >> rendering is RGBA and RGBX. That pipe format is in the sRGB

[Mesa-dev] [PATCH v3 009/104] glsl/nir: Use deref instructions instead of dref chains

2018-04-03 Thread Jason Ekstrand
--- src/compiler/glsl/glsl_to_nir.cpp | 239 +++--- 1 file changed, 94 insertions(+), 145 deletions(-) diff --git a/src/compiler/glsl/glsl_to_nir.cpp b/src/compiler/glsl/glsl_to_nir.cpp index 49c478d..cdea354 100644 --- a/src/compiler/glsl/glsl_to_nir.cpp +++

[Mesa-dev] [PATCH v3 024/104] nir: Support deref instructions in lower_system_values

2018-04-03 Thread Jason Ekstrand
--- src/compiler/nir/nir_lower_system_values.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/compiler/nir/nir_lower_system_values.c b/src/compiler/nir/nir_lower_system_values.c index fb560ee..104df51 100644 --- a/src/compiler/nir/nir_lower_system_values.c

[Mesa-dev] [PATCH v3 027/104] nir: Support deref instructions in gather_info

2018-04-03 Thread Jason Ekstrand
--- src/compiler/nir/nir_gather_info.c | 29 ++--- 1 file changed, 22 insertions(+), 7 deletions(-) diff --git a/src/compiler/nir/nir_gather_info.c b/src/compiler/nir/nir_gather_info.c index 5530009..b030a15 100644 --- a/src/compiler/nir/nir_gather_info.c +++

[Mesa-dev] [PATCH v3 021/104] nir: Support deref instructions in lower_vars_to_ssa

2018-04-03 Thread Jason Ekstrand
--- src/compiler/nir/nir_lower_vars_to_ssa.c | 75 1 file changed, 58 insertions(+), 17 deletions(-) diff --git a/src/compiler/nir/nir_lower_vars_to_ssa.c b/src/compiler/nir/nir_lower_vars_to_ssa.c index 0cc6514..403ce26 100644 ---

[Mesa-dev] [PATCH v3 026/104] nir: Support deref instructions in propagate_invariant

2018-04-03 Thread Jason Ekstrand
--- src/compiler/nir/nir_propagate_invariant.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/src/compiler/nir/nir_propagate_invariant.c b/src/compiler/nir/nir_propagate_invariant.c index 7b5bd6c..b48b91c 100644 ---

[Mesa-dev] [PATCH v3 014/104] nir: Add a pass for fixing deref modes

2018-04-03 Thread Jason Ekstrand
This will be needed by anything which changes variable modes without rewriting derefs. --- src/compiler/nir/nir.h | 2 ++ src/compiler/nir/nir_deref.c | 30 ++ 2 files changed, 32 insertions(+) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index

[Mesa-dev] [PATCH v3 017/104] nir: Support deref instructions in lower_io_to_temporaries

2018-04-03 Thread Jason Ekstrand
--- src/compiler/nir/nir_lower_io_to_temporaries.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/compiler/nir/nir_lower_io_to_temporaries.c b/src/compiler/nir/nir_lower_io_to_temporaries.c index 9d3072b..5d26d9e 100644 --- a/src/compiler/nir/nir_lower_io_to_temporaries.c +++

[Mesa-dev] [PATCH v3 010/104] prog/nir: Simplify some load/store operations

2018-04-03 Thread Jason Ekstrand
--- src/compiler/nir/nir_builder.h | 6 + src/mesa/program/prog_to_nir.c | 53 +++--- 2 files changed, 19 insertions(+), 40 deletions(-) diff --git a/src/compiler/nir/nir_builder.h b/src/compiler/nir/nir_builder.h index 076c583..edae559 100644 ---

[Mesa-dev] [PATCH v3 016/104] nir: Use nir_builder in lower_io_to_temporaries

2018-04-03 Thread Jason Ekstrand
--- src/compiler/nir/nir_lower_io_to_temporaries.c | 37 -- 1 file changed, 17 insertions(+), 20 deletions(-) diff --git a/src/compiler/nir/nir_lower_io_to_temporaries.c b/src/compiler/nir/nir_lower_io_to_temporaries.c index 301ba65..9d3072b 100644 ---

[Mesa-dev] [PATCH v3 015/104] nir: Support deref instructions in lower_global_vars_to_local

2018-04-03 Thread Jason Ekstrand
--- src/compiler/nir/nir_lower_global_vars_to_local.c | 62 +++ 1 file changed, 42 insertions(+), 20 deletions(-) diff --git a/src/compiler/nir/nir_lower_global_vars_to_local.c b/src/compiler/nir/nir_lower_global_vars_to_local.c index c8fdfde..14aa366 100644 ---

[Mesa-dev] [PATCH v3 011/104] prog/nir: Use deref instructions for params

2018-04-03 Thread Jason Ekstrand
--- src/mesa/program/prog_to_nir.c | 41 ++--- 1 file changed, 6 insertions(+), 35 deletions(-) diff --git a/src/mesa/program/prog_to_nir.c b/src/mesa/program/prog_to_nir.c index 3ee44ce..8522541 100644 --- a/src/mesa/program/prog_to_nir.c +++

[Mesa-dev] [PATCH v3 008/104] glsl/nir: Only claim to handle intrinsic functions

2018-04-03 Thread Jason Ekstrand
Non-intrinsic function handling has never actually been tested and probably doesn't work. Just get rid of it for now. We can always add it back in later if it's useful. --- src/compiler/glsl/glsl_to_nir.cpp | 25 ++--- 1 file changed, 2 insertions(+), 23 deletions(-) diff

[Mesa-dev] [PATCH v3 087/104] nir: Remove deref chain support from lower_wpos_center

2018-04-03 Thread Jason Ekstrand
--- src/compiler/nir/nir_lower_wpos_center.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/src/compiler/nir/nir_lower_wpos_center.c b/src/compiler/nir/nir_lower_wpos_center.c index 5b68cac..b6f3529 100644 --- a/src/compiler/nir/nir_lower_wpos_center.c +++

[Mesa-dev] [PATCH v3 089/104] nir/lower_tex: Always copy deref and offset sources

2018-04-03 Thread Jason Ekstrand
This should make nir_lower_tex properly handle deref instructions as well as make it more correct when texture arrays are used and it's called after lowering samplers to binding table indices. --- src/compiler/nir/nir_lower_tex.c | 41 +++- 1 file changed, 32

[Mesa-dev] [PATCH v3 085/104] nir: Remove deref chain support from remove_unused_varyings

2018-04-03 Thread Jason Ekstrand
--- src/compiler/nir/nir_linking_helpers.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/compiler/nir/nir_linking_helpers.c b/src/compiler/nir/nir_linking_helpers.c index 1a0cb91..85712a7 100644 --- a/src/compiler/nir/nir_linking_helpers.c +++

[Mesa-dev] [PATCH v3 082/104] nir: Convert lower_io to deref instructions

2018-04-03 Thread Jason Ekstrand
This deletes support for _var intrinsics and legacy deref chains in favor of deref instructions. The internals are also reworked a bit to use deref instructions directly. --- src/compiler/nir/nir_lower_io.c | 106 ++-- 1 file changed, 37 insertions(+), 69

[Mesa-dev] [PATCH v3 088/104] nir: Remove deref chain support from lower_wpos_ytransform

2018-04-03 Thread Jason Ekstrand
--- src/compiler/nir/nir_lower_wpos_ytransform.c | 36 1 file changed, 36 deletions(-) diff --git a/src/compiler/nir/nir_lower_wpos_ytransform.c b/src/compiler/nir/nir_lower_wpos_ytransform.c index 6212702..f6f642c 100644 ---

[Mesa-dev] [PATCH v3 086/104] nir: Remove deref chain support from lower_system_values

2018-04-03 Thread Jason Ekstrand
--- src/compiler/nir/nir_lower_system_values.c | 26 +++--- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git a/src/compiler/nir/nir_lower_system_values.c b/src/compiler/nir/nir_lower_system_values.c index 5191fb3..d2c8456 100644 ---

[Mesa-dev] [PATCH v3 080/104] nir: Remove deref chain support from lower_global_vars_to_local

2018-04-03 Thread Jason Ekstrand
--- src/compiler/nir/nir_lower_global_vars_to_local.c | 19 +-- 1 file changed, 1 insertion(+), 18 deletions(-) diff --git a/src/compiler/nir/nir_lower_global_vars_to_local.c b/src/compiler/nir/nir_lower_global_vars_to_local.c index 14aa366..d441215 100644 ---

[Mesa-dev] [PATCH v3 083/104] nir: Remove deref chain support from lower_phis_to_scalar

2018-04-03 Thread Jason Ekstrand
--- src/compiler/nir/nir_lower_phis_to_scalar.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/src/compiler/nir/nir_lower_phis_to_scalar.c b/src/compiler/nir/nir_lower_phis_to_scalar.c index 6cb9420..904eff0 100644 --- a/src/compiler/nir/nir_lower_phis_to_scalar.c +++

[Mesa-dev] [PATCH v3 078/104] nir: Remove deref chain support from lower_alpha_test

2018-04-03 Thread Jason Ekstrand
--- src/compiler/nir/nir_lower_alpha_test.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/compiler/nir/nir_lower_alpha_test.c b/src/compiler/nir/nir_lower_alpha_test.c index 776655a..ddd8157 100644 --- a/src/compiler/nir/nir_lower_alpha_test.c +++

[Mesa-dev] [PATCH v3 081/104] nir/lower_io: Convert atomic lowering to deref instructions

2018-04-03 Thread Jason Ekstrand
No one is currently using so we can make this change irrespective of driver. We may use it again in i965 so it's best to pretend to keep it working. --- src/compiler/nir/nir_lower_io.c | 48 + 1 file changed, 25 insertions(+), 23 deletions(-) diff --git

[Mesa-dev] [PATCH v3 079/104] nir: Remove deref chain support from lower_clamp_color_outputs

2018-04-03 Thread Jason Ekstrand
--- src/compiler/nir/nir_lower_clamp_color_outputs.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/compiler/nir/nir_lower_clamp_color_outputs.c b/src/compiler/nir/nir_lower_clamp_color_outputs.c index ec39848..b76a4d5 100644 --- a/src/compiler/nir/nir_lower_clamp_color_outputs.c +++

[Mesa-dev] [PATCH v3 084/104] nir: Delete lower_io_types

2018-04-03 Thread Jason Ekstrand
It's only used by the ir3 stand-alone compiler and Rob said we could delete it. --- src/compiler/Makefile.sources | 1 - src/compiler/nir/meson.build| 1 - src/compiler/nir/nir.h | 1 - src/compiler/nir/nir_lower_io_types.c

Re: [Mesa-dev] [PATCH] st/mesa: set stencil border color the same as intensity

2018-04-03 Thread Ilia Mirkin
Seems reasonable, esp since the gallium format for stencil is (s,s,s,s). Reviewed-by: Ilia Mirkin On Tue, Apr 3, 2018 at 11:53 AM, Marek Olšák wrote: > From: Marek Olšák > > This fixes some stencil border color tests on Vega and

Re: [Mesa-dev] [PATCH] st/mesa: Also use PIPE_FORMAT_R8G8B8A8_SRGB for framebuffer_sRGB.

2018-04-03 Thread Brian Paul
On 04/03/2018 10:06 AM, Jakob Bornecrantz wrote: When running virgl on a GLES host the only sRGB formats that support rendering is RGBA and RGBX. That pipe format is in the sRGB default lists that the state tracker uses when mapping mesa formats. Cheers, Jakob. Signed-off-by: Jakob Bornecrantz

Re: [Mesa-dev] [PATCH 08/11] i965: perf: snapshot RPSTAT1 register

2018-04-03 Thread Kenneth Graunke
> >> diff --git a/src/mesa/drivers/dri/i965/brw_performance_query.c > >> b/src/mesa/drivers/dri/i965/brw_performance_query.c > >> index 98666759d75..7d5b44cf61d 100644 > >> --- a/src/mesa/drivers/dri/i965/brw_performance_query.c > >> +++ b/src/mesa/drivers/dri/i965/brw_performance_query.c > >> @@

[Mesa-dev] [PATCH v3 002/104] nir: Add a deref instruction type

2018-04-03 Thread Jason Ekstrand
This commit adds a new instruction type to NIR for handling derefs. Nothing uses it yet but this adds the data structure as well as all of the code to validate, print, clone, and [de]serialize them. --- src/compiler/nir/nir.c| 50 +++ src/compiler/nir/nir.h

[Mesa-dev] [PATCH v3 000/104] nir: Move to using instructions for derefs

2018-04-03 Thread Jason Ekstrand
This is something that Connor and I have been talking about for some time now. The basic idea is to replace the current singly linked nir_deref list with deref instructions. This is similar to what LLVM does and it offers quite a bit more freedom when we start getting more realistic pointers

[Mesa-dev] [PATCH v3 003/104] nir/builder: Add deref building helpers

2018-04-03 Thread Jason Ekstrand
--- src/compiler/nir/nir_builder.h | 106 + 1 file changed, 106 insertions(+) diff --git a/src/compiler/nir/nir_builder.h b/src/compiler/nir/nir_builder.h index 8f7ddf1..69c7261 100644 --- a/src/compiler/nir/nir_builder.h +++

  1   2   3   >