Re: [Mesa-dev] [PATCH 04/11] gallium: Use Array._DrawVAO in st_atom_array.c.

Hi all, On Wednesday, 11 April 2018 16:23:52 CEST Brian Paul wrote: > Hmm, in my experience, interleaved arrays are fairly common. > > I still haven't had much time to look at Mathias's latest patches. > > And I haven't looked this code in the state tracker recently, but I seem > to recall

Re: [Mesa-dev] [PATCH] st/dri: Fix dangling pointer to a destroyed dri_drawable

Pushed, thanks! Marek On Fri, Apr 20, 2018 at 6:29 AM, Johan Klokkhammer Helsing < johan.hels...@qt.io> wrote: > If an EGLSurface is created, made current and destroyed, and then a second > EGLSurface is created. Then the second malloc in driCreateNewDrawable may > return the same pointer

[Mesa-dev] [PATCH v4] mesa: GL_EXT_texture_norm16 extension plumbing

Patch enables use of short and unsigned short data for texture uploads, rendering and reading of framebuffers within the restrictions specified in GL_EXT_texture_norm16 spec. Patch also enables those 16bit format layout qualifiers listed in GL_NV_image_formats that depend on EXT_texture_norm16.

Re: [Mesa-dev] [PATCH 1/2] ac/radv/radeonsi: refactor raster_config default values getters.

Series is: Reviewed-by: Samuel Pitoiset On 04/23/2018 02:17 AM, Dave Airlie wrote: From: Dave Airlie This just makes this common code between the two drivers. --- src/amd/common/ac_gpu_info.c| 93 +

Re: [Mesa-dev] [PATCH] radv: advertise 8 bits of subpixel precision for viewports

On 04/23/2018 11:12 AM, Józef Kucia wrote: On Wed, Apr 11, 2018 at 10:38 AM, Samuel Pitoiset wrote: Agreed. Reviewed-by: Samuel Pitoiset Please push the patch for me. I don't have commit access. Pushed!

Re: [Mesa-dev] [PATCH 1/2] radv: only set raster_config_1 outside the index registers.

Series is: Reviewed-by: Samuel Pitoiset On 04/23/2018 02:43 AM, Dave Airlie wrote: From: Dave Airlie This follows what radeonsi does. Ported from radeonsi: radeonsi: emit PA_SC_RASTER_CONFIG_1 only once ---

[Mesa-dev] [Bug 106126] eglMakeCurrent does not always ensure dri_drawable->update_drawable_info has been called for a new EGLSurface if another has been created and destroyed first

https://bugs.freedesktop.org/show_bug.cgi?id=106126 Timothy Arceri changed: What|Removed |Added Status|ASSIGNED|RESOLVED

Re: [Mesa-dev] [PATCH] radv: advertise 8 bits of subpixel precision for viewports

On Wed, Apr 11, 2018 at 10:38 AM, Samuel Pitoiset wrote: > Agreed. > > Reviewed-by: Samuel Pitoiset Please push the patch for me. I don't have commit access. ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH 04/11] gallium: Use Array._DrawVAO in st_atom_array.c.

Hi Marek, On Tuesday, 10 April 2018 20:09:06 CEST Marek Olšák wrote: > Generally, if you have to loop over all arrays to find common vertex > buffers, it's better not to do it. The default separate path is going to > perform best, because it's straightforward and interleaved arrays are super >

Re: [Mesa-dev] [PATCH] radeonsi/gfx9: fix a hang with an empty first IB

On Sat, 2018-04-21 at 00:48 -0400, Marek Olšák wrote: > Hi Juan, > > Here is the patch backported to 18.0: > https://cgit.freedesktop.org/~mareko/mesa/commit/?h=amd-18.0=7ab59306613b08c7dd6e875c3276cac9a61889ae > Thanks for the patch. Enqueued for next release. J.A. > Marek > > On

Re: [Mesa-dev] [PATCH] anv/allocator: Don't srink either end of the block pool

Hi, On 21.04.2018 08:15, Jason Ekstrand wrote: Previously, we only tried to ensure that we didn't shrink either end below what was already handed out. However, due to the way we handle relocations with block pools, we can't shrink the back end at all. It's probably best to not shrink in

Re: [Mesa-dev] [PATCH 5/5] radeonsi: use common gs_table_depth code

Patches 2, 3, 5: Reviewed-by: Nicolai Hähnle On 23.04.2018 01:59, Dave Airlie wrote: From: Dave Airlie --- src/gallium/drivers/radeonsi/si_pipe.c | 33 ++--- 1 file changed, 2 insertions(+), 31 deletions(-) diff

Re: [Mesa-dev] [PATCH] intel/decoder: Use gen_group::dw_length when available

On 23/04/18 12:20, Topi Pohjolainen wrote: Otherwise gen_group_get_length() will try to use first fields of, for example, CC_VIEWPORT and SF_CLIP to determine the group size. These packets are not present in the state with full header but simply with their contents while equivalent state

[Mesa-dev] [Bug 105232] piglit regressions and crashes from gbm alpha masks

https://bugs.freedesktop.org/show_bug.cgi?id=105232 Mark Janes changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [Bug 106151] [amdgpu][vulkan] GPU hang (Vega 56) while running game (Rise of the Tomb Raider)

https://bugs.freedesktop.org/show_bug.cgi?id=106151 --- Comment #8 from Samuel Pitoiset --- Well, I have a vega 56 so I can reproduce the hang but I would need a bit more info. What preset are you using? Do you have something in dmesg when it hangs? -- You are

Re: [Mesa-dev] 16-bit comparisons in NIR

On Sun, Apr 22, 2018 at 11:31 AM, Iago Toral wrote: > On Fri, 2018-04-20 at 17:16 -0700, Jason Ekstrand wrote: > > On Fri, Apr 20, 2018 at 5:16 AM, Nicolai Hähnle > wrote: > > On 20.04.2018 10:21, Iago Toral wrote: > > Hi, > > while developing support for

Re: [Mesa-dev] [PATCH 4/4] intel/compiler: Add scheduler deps for instructions that implicitly read g0

I enabled these tests, and could not make them fail in CI. This bug may also be related: https://bugs.freedesktop.org/show_bug.cgi?id=95009 Ian Romanick writes: > From: Ian Romanick > > Otherwise the scheduler can move the writes after the

Re: [Mesa-dev] [PATCH] st/dri: Fix dangling pointer to a destroyed dri_drawable

Hi Johan, On 20 April 2018 at 11:29, Johan Klokkhammer Helsing wrote: > If an EGLSurface is created, made current and destroyed, and then a second > EGLSurface is created. Then the second malloc in driCreateNewDrawable may > return the same pointer address the first

[Mesa-dev] [Bug 84805] DEF files missing for GLES1/GLES2

https://bugs.freedesktop.org/show_bug.cgi?id=84805 Timothy Arceri changed: What|Removed |Added Resolution|--- |WONTFIX

Re: [Mesa-dev] unlock android graphic buffer spend too much time

Hi; On 23.04.2018 13:13, Zong, Wei wrote: Hi Dear Mesa experts, I'm reading android graphic buffer by calling “*GraphicBuffer::lock” *with parameter "GRALLOC_USAGE_SW_READ_OFTEN | GRALLOC_USAGE_SW_WRITE_NEVER", I copied the buffer into a CPU allocated memory only cost less than 1

[Mesa-dev] [PATCH] intel/decoder: Use gen_group::dw_length when available

Otherwise gen_group_get_length() will try to use first fields of, for example, CC_VIEWPORT and SF_CLIP to determine the group size. These packets are not present in the state with full header but simply with their contents while equivalent state pointers (3DSTATE_VIEWPORT_STATE_POINTERS_CC and

[Mesa-dev] [Bug 106187] Vulkan apps run on secondary GPU on multi-GPU system

https://bugs.freedesktop.org/show_bug.cgi?id=106187 Bug ID: 106187 Summary: Vulkan apps run on secondary GPU on multi-GPU system Product: Mesa Version: 17.3 Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW

Re: [Mesa-dev] [PATCH] ac/nir: fix image dimension for subpass attachments

On 20.04.2018 18:06, Samuel Pitoiset wrote: For subpass attachments we need one more coordinate with the sample index, so make them array types. Sorry about that. Shouldn't it be layer index instead of sample index though? If I understand this right, I think it would be cleaner to just

[Mesa-dev] [Bug 106187] Vulkan apps run on secondary GPU on multi-GPU system

https://bugs.freedesktop.org/show_bug.cgi?id=106187 Mike Lothian changed: What|Removed |Added CC||m...@fireburn.co.uk

[Mesa-dev] [Bug 106187] Vulkan apps run on secondary GPU on multi-GPU system

https://bugs.freedesktop.org/show_bug.cgi?id=106187 --- Comment #3 from Kristoffer --- I can't really tell which shows up first when running vulkaninfo because they look identical. -- You are receiving this mail because: You are the QA Contact for the bug. You are the

Re: [Mesa-dev] [PATCH 1/2] ac/radv/radeonsi: refactor raster_config default values getters.

For the series: Reviewed-by: Nicolai Hähnle On 23.04.2018 02:17, Dave Airlie wrote: From: Dave Airlie This just makes this common code between the two drivers. --- src/amd/common/ac_gpu_info.c| 93 +

[Mesa-dev] [PATCH] ac/nir: add missing round_slice for 1D arrays

This fixes a bunch of CTS fails with 1D arrays: dEQP-VK.glsl.texture_functions.texture*.sampler1darray_* Fixes: 625dcbbc456 ("amd/common: pass address components individually to ac_build_image_intrinsic") Cc: 18.1 Signed-off-by: Samuel Pitoiset

[Mesa-dev] unlock android graphic buffer spend too much time

Hi Dear Mesa experts, I'm reading android graphic buffer by calling “GraphicBuffer::lock” with parameter "GRALLOC_USAGE_SW_READ_OFTEN | GRALLOC_USAGE_SW_WRITE_NEVER", I copied the buffer into a CPU allocated memory only cost less than 1 millisecond. the resolution of this graphic buffer is

[Mesa-dev] [Bug 92265] Black windows in weston after update mesa to 11.0.2-1

https://bugs.freedesktop.org/show_bug.cgi?id=92265 Timothy Arceri changed: What|Removed |Added Resolution|--- |FIXED

Re: [Mesa-dev] [PATCH 2/2] ac/radv/radeonsi: refactor harvest config register getters.

Acked-by: Nicolai Hähnle On 23.04.2018 02:43, Dave Airlie wrote: From: Dave Airlie This refactors the code out to share it between radv and radeonsi. --- src/amd/common/ac_gpu_info.c| 113

[Mesa-dev] [Bug 106187] Vulkan apps run on secondary GPU on multi-GPU system

https://bugs.freedesktop.org/show_bug.cgi?id=106187 --- Comment #2 from Kristoffer --- Created attachment 138998 --> https://bugs.freedesktop.org/attachment.cgi?id=138998=edit vulkaninfo -- You are receiving this mail because: You are the assignee for the bug. You are the

Re: [Mesa-dev] [PATCH 4/4] gallivm: dump bitcode before optimization

On 23/04/18 05:24, srol...@vmware.com wrote: From: Roland Scheidegger If we dump the bitcode for off-line debug purposes, we really want the pre-optimized bitcode, otherwise it's useless in identifying problems with IR optimization (if you have a shader which takes an hour

[Mesa-dev] [Bug 106187] Vulkan apps run on secondary GPU on multi-GPU system

https://bugs.freedesktop.org/show_bug.cgi?id=106187 Alex Smith changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH] ac/nir: fix image dimension for subpass attachments

On 04/23/2018 01:24 PM, Nicolai Hähnle wrote: On 20.04.2018 18:06, Samuel Pitoiset wrote: For subpass attachments we need one more coordinate with the sample index, so make them array types. Sorry about that. Shouldn't it be layer index instead of sample index though? No worries! Yes,

[Mesa-dev] [Bug 106187] Vulkan apps run on secondary GPU on multi-GPU system

https://bugs.freedesktop.org/show_bug.cgi?id=106187 --- Comment #5 from Marc Di Luzio --- (In reply to Mike Lothian from comment #4) > As for selecting the first one automatically, I think the Launcher should be > remembering the card you last used, and that would

[Mesa-dev] [Bug 106187] Vulkan apps run on secondary GPU on multi-GPU system

https://bugs.freedesktop.org/show_bug.cgi?id=106187 --- Comment #6 from Kristoffer --- (In reply to Mike Lothian from comment #4) > I wonder if that's a bug in the PRIME code, I wouldn't have expected to see > a drop in FPS that much if the cards are identical. Out of

[Mesa-dev] [Bug 106187] Vulkan apps run on secondary GPU on multi-GPU system

https://bugs.freedesktop.org/show_bug.cgi?id=106187 --- Comment #8 from Alex Deucher --- There is extra overhead when using secondary GPUs in conjunction with prime when you want to see the results on the display. The display is only attached to one GPU so when you render

Re: [Mesa-dev] [PATCH 2/3] Autotools: Add passes.h to sources so it will be included in the tarball

I agree on the commit message wording. Sorry about missing passes.h in the original check-in. Reviewed-by: George Kyriazis > On Apr 20, 2018, at 10:00 PM, Kenneth Graunke > wrote:

[Mesa-dev] [PATCH] ac: teach get_ac_sampler_dim() about subpass attachments

Suggested by Nicolai. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 24 +++- 1 file changed, 7 insertions(+), 17 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index

[Mesa-dev] [Bug 106187] Vulkan apps run on secondary GPU on multi-GPU system

https://bugs.freedesktop.org/show_bug.cgi?id=106187 --- Comment #4 from Mike Lothian --- I wonder if that's a bug in the PRIME code, I wouldn't have expected to see a drop in FPS that much if the cards are identical. Out of interest, do you see differences at other

[Mesa-dev] [Bug 76694] Inconsistent behaviour of LIBGL_DEBUG

https://bugs.freedesktop.org/show_bug.cgi?id=76694 Stefan Brüns changed: What|Removed |Added Status|RESOLVED|REOPENED

[Mesa-dev] [Bug 106187] Vulkan apps run on secondary GPU on multi-GPU system

https://bugs.freedesktop.org/show_bug.cgi?id=106187 --- Comment #9 from Bas Nieuwenhuizen --- So I think there are several issues in this bug: 1) Running on a GPU that is not connected to the display is slower. Arguably we should be able to optimize this a bit,

[Mesa-dev] [Bug 106187] Vulkan apps run on secondary GPU on multi-GPU system

https://bugs.freedesktop.org/show_bug.cgi?id=106187 --- Comment #7 from Kristoffer --- This probably goes without saying, but OpenGL and OpenCL apps does not have this issue. They will run on the GPU or GPU's I expect them to. For example, 'ethminer --opencl-device 0' will

Re: [Mesa-dev] [PATCH] ac/nir: add missing round_slice for 1D arrays

Reviewed-by: Bas Nieuwenhuizen On Mon, Apr 23, 2018 at 2:46 PM, Samuel Pitoiset wrote: > This fixes a bunch of CTS fails with 1D arrays: > > dEQP-VK.glsl.texture_functions.texture*.sampler1darray_* > > Fixes: 625dcbbc456 ("amd/common: pass

Re: [Mesa-dev] [PATCH] anv/allocator: Don't srink either end of the block pool

Jason Ekstrand writes: > Previously, we only tried to ensure that we didn't shrink either end > below what was already handed out. However, due to the way we handle > relocations with block pools, we can't shrink the back end at all. It's > probably best to not shrink in

[Mesa-dev] [PATCH] ac: fix the number of coordinates for ac_image_get_lod and arrays

This fixes crashes for the following CTS: dEQP-VK.glsl.texture_functions.query.texturequerylod.* Fixes: 625dcbbc456 ("amd/common: pass address components individually to ac_build_image_intrinsic") Cc: 18.1 Signed-off-by: Samuel Pitoiset

Re: [Mesa-dev] [PATCH] anv/allocator: Don't srink either end of the block pool

On Mon, Apr 23, 2018 at 8:33 AM, Scott D Phillips < scott.d.phill...@intel.com> wrote: > Jason Ekstrand writes: > > > Previously, we only tried to ensure that we didn't shrink either end > > below what was already handed out. However, due to the way we handle > >

Re: [Mesa-dev] [PATCH v3 3/9] i965: Add and use a getter for the miptree aux buffer

On Fri, Apr 20, 2018 at 03:51:34PM -0700, Rafael Antognolli wrote: > On Fri, Apr 20, 2018 at 02:38:37PM -0700, Nanley Chery wrote: > > On Fri, Apr 20, 2018 at 09:58:38AM -0700, Rafael Antognolli wrote: > > > Nice, I was planning to do something like this later but didn't want to > > > include many

Re: [Mesa-dev] [PATCH] ac: teach get_ac_sampler_dim() about subpass attachments

works for me. Reviewed-by: Bas Nieuwenhuizen On Mon, Apr 23, 2018 at 7:55 AM, Samuel Pitoiset wrote: > Suggested by Nicolai. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/common/ac_nir_to_llvm.c | 24

Re: [Mesa-dev] [PATCH] glsl/glcpp: Handle hex constants with 0X prefix

2018-04-23 3:53 GMT+03:00 Timothy Arceri : > > > On 20/04/18 06:08, Vlad Golovkin wrote: >> >> GLSL 4.6 spec describes hex constant as: >> >> hexadecimal-constant: >> 0x hexadecimal-digit >> 0X hexadecimal-digit >> hexadecimal-constant hexadecimal-digit >> >>

Re: [Mesa-dev] [PATCH v3 3/9] i965: Add and use a getter for the miptree aux buffer

Why is this useful in light of patch 4? I don't mean to be overly critical but the main purpose of this helper seems to be to deal with the fact that we have two different fields. If it's just one field, why the helper? --Jason On Wed, Apr 11, 2018 at 1:42 PM, Nanley Chery

Re: [Mesa-dev] [PATCH v3 4/9] i965: Add and use a single miptree aux_buf field

On Wed, Apr 11, 2018 at 1:42 PM, Nanley Chery wrote: > We want to add and use a function that accesses the auxiliary buffer's > clear_color_bo and doesn't care if it has an MCS or HiZ buffer > specifically. > --- > src/mesa/drivers/dri/i965/brw_blorp.c | 4 +- >

Re: [Mesa-dev] [PATCH v3 3/9] i965: Add and use a getter for the miptree aux buffer

On Mon, Apr 23, 2018 at 11:01:12AM -0700, Jason Ekstrand wrote: > Why is this useful in light of patch 4? I don't mean to be overly critical > but the main purpose of this helper seems to be to deal with the fact that > we have two different fields. If it's just one field, why the helper? > >

Re: [Mesa-dev] [PATCH v3 5/9] i965/wm_surface_state: Use the clear address if it's non-zero

I think you want to say "clear_color_bo is non-NULL" in the commit message rather than talking about addresses. Otherwise, this looks like a very nice clean-up. Reviewed-by: Jason Ekstrand On Wed, Apr 11, 2018 at 1:42 PM, Nanley Chery wrote: > We

Re: [Mesa-dev] [PATCH] ac: teach get_ac_sampler_dim() about subpass attachments

Thanks! Reviewed-by: Nicolai Hähnle On 23.04.2018 16:55, Samuel Pitoiset wrote: Suggested by Nicolai. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 24 +++- 1 file changed, 7 insertions(+), 17

[Mesa-dev] [Bug 106133] make check "OSError: [Errno 24] Too many open files"

https://bugs.freedesktop.org/show_bug.cgi?id=106133 Dylan Baker changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH] ac: fix the number of coordinates for ac_image_get_lod and arrays

On 23.04.2018 17:52, Samuel Pitoiset wrote: This fixes crashes for the following CTS: dEQP-VK.glsl.texture_functions.query.texturequerylod.* Fixes: 625dcbbc456 ("amd/common: pass address components individually to ac_build_image_intrinsic") Cc: 18.1

Re: [Mesa-dev] [Mesa-stable] [PATCH] anv/allocator: Don't srink either end of the block pool

You have a typo in the commit message "srink" -> "shrink" Quoting Jason Ekstrand (2018-04-20 22:15:00) > Previously, we only tried to ensure that we didn't shrink either end > below what was already handed out. However, due to the way we handle > relocations with block pools, we can't shrink the

Re: [Mesa-dev] [PATCH] ac: fix the number of coordinates for ac_image_get_lod and arrays

On 04/23/2018 06:55 PM, Nicolai Hähnle wrote: On 23.04.2018 17:52, Samuel Pitoiset wrote: This fixes crashes for the following CTS: dEQP-VK.glsl.texture_functions.query.texturequerylod.* Fixes: 625dcbbc456 ("amd/common: pass address components individually to ac_build_image_intrinsic") Cc:

Re: [Mesa-dev] [PATCH 1/3] meson: don't build classic mesa tests without dri_drivers

Quoting Dylan Baker (2018-04-19 09:20:49) > Since mesa_classic is not build-on-demand the tests will create a demand > and add a bunch of extra compilation. > > Fixes: 43a6e84927e3b1290f6f211f5dfb184dfe5a719e >("meson: build mesa test.") > Signed-off-by: Dylan Baker

Re: [Mesa-dev] [Mesa-stable] [PATCH] anv/allocator: Don't srink either end of the block pool

On Mon, Apr 23, 2018 at 10:00 AM, Dylan Baker wrote: > You have a typo in the commit message "srink" -> "shrink" > Thanks! Fixed. > Quoting Jason Ekstrand (2018-04-20 22:15:00) > > Previously, we only tried to ensure that we didn't shrink either end > > below what was

Re: [Mesa-dev] [PATCH v3 7/9] i965: Add and use a getter for the clear color

On Fri, Apr 20, 2018 at 03:18:18PM -0700, Rafael Antognolli wrote: > On Fri, Apr 20, 2018 at 03:01:44PM -0700, Nanley Chery wrote: > > On Fri, Apr 20, 2018 at 01:35:39PM -0700, Rafael Antognolli wrote: > > > On Wed, Apr 11, 2018 at 01:42:24PM -0700, Nanley Chery wrote: > > > > This getter allows

[Mesa-dev] [PATCH] intel: devinfo: fix assertion on devices with odd number of EUs

I forgot to change the assert in the second helper function in a previous change. This hit the assert() on a Broadwell platform with quite a few EUs fused off : https://i.imgur.com/4Wx6tjz.png Fixes: c1900f5b0fb ("intel: devinfo: add helper functions to fill fusing masks values")

Re: [Mesa-dev] [PATCH 2/3] Autotools: Add passes.h to sources so it will be included in the tarball

Quoting Kyriazis, George (2018-04-23 07:52:23) > I agree on the commit message wording. > > Sorry about missing passes.h in the original check-in. > No worries, most (all?) of us forget about it. I guess it's just one more thing that meson will improve in our workflow :) Dylan signature.asc

Re: [Mesa-dev] [PATCH] ac/nir: add missing round_slice for 1D arrays

On 23.04.2018 14:46, Samuel Pitoiset wrote: This fixes a bunch of CTS fails with 1D arrays: dEQP-VK.glsl.texture_functions.texture*.sampler1darray_* Fixes: 625dcbbc456 ("amd/common: pass address components individually to ac_build_image_intrinsic") Cc: 18.1

Re: [Mesa-dev] [PATCH 1/2] i965: Add and use a helper to update the indirect miptree color

On Mon, Apr 23, 2018 at 11:27:16AM -0700, Jason Ekstrand wrote: > There are two refactors going on here that are being conflated. One is > what the commit message says where we add and use a helper. > > On Fri, Apr 20, 2018 at 3:12 PM, Rafael Antognolli < > rafael.antogno...@intel.com> wrote: >

[Mesa-dev] [Bug 76694] Inconsistent behaviour of LIBGL_DEBUG

https://bugs.freedesktop.org/show_bug.cgi?id=76694 Timothy Arceri changed: What|Removed |Added Resolution|--- |WONTFIX

[Mesa-dev] [Bug 65422] Rename api_validate.[ch] to draw_validate.[ch]

https://bugs.freedesktop.org/show_bug.cgi?id=65422 Timothy Arceri changed: What|Removed |Added Resolution|--- |FIXED

[Mesa-dev] [PATCH v2] i965: Add and use a single miptree aux_buf field

We want to add and use a function that accesses the auxiliary buffer's clear_color_bo and doesn't care if it has an MCS or HiZ buffer specifically. v2 (Jason Ekstrand): * Drop intel_miptree_get_aux_buffer(). * Mention CCS in the aux_buf field. --- src/mesa/drivers/dri/i965/brw_blorp.c

Re: [Mesa-dev] [PATCH v3 3/9] i965: Add and use a getter for the miptree aux buffer

On Mon, Apr 23, 2018 at 11:11 AM, Nanley Chery wrote: > On Mon, Apr 23, 2018 at 11:01:12AM -0700, Jason Ekstrand wrote: > > Why is this useful in light of patch 4? I don't mean to be overly > critical > > but the main purpose of this helper seems to be to deal with the

Re: [Mesa-dev] [PATCH 0/7] broadcom/vc4: Native fence fd support

Stefan Schake writes: > This series adds support for the native fence fd extension to vc4. > The implementation relies on a newly introduced kernel interface that > allows submitting syncobjs for in/out fences during job submission. > > Since syncobjs are relatively new,

Re: [Mesa-dev] [PATCH] i965/fs: Return mlen * 8 for size_written for INTERPOLATE_AT_*

Jason Ekstrand writes: > They are send messages and this makes size_written() and mlen agree. You mean size_read()? And commit message should probably read "Return mlen * 32 for size_read for INTERPOLATE_AT_*" to reflect what the commit is doing. > For both of these

Re: [Mesa-dev] [Mesa-stable] [PATCH] ac: fix the number of coordinates for ac_image_get_lod and arrays

On 04/23/2018 08:42 PM, Marek Olšák wrote: On Mon, Apr 23, 2018 at 1:12 PM, Samuel Pitoiset > wrote: On 04/23/2018 06:55 PM, Nicolai Hähnle wrote: On 23.04.2018 17:52, Samuel Pitoiset wrote: This fixes

Re: [Mesa-dev] [PATCH] i965/fs: Return mlen * 8 for size_written for INTERPOLATE_AT_*

On Mon, Apr 23, 2018 at 1:36 PM, Francisco Jerez wrote: > Jason Ekstrand writes: > > > They are send messages and this makes size_written() and mlen agree. > > You mean size_read()? And commit message should probably read "Return > mlen * 32 for

Re: [Mesa-dev] [PATCH v3 4/9] i965: Add and use a single miptree aux_buf field

On Mon, Apr 23, 2018 at 11:10:08AM -0700, Jason Ekstrand wrote: > On Wed, Apr 11, 2018 at 1:42 PM, Nanley Chery wrote: > > > We want to add and use a function that accesses the auxiliary buffer's > > clear_color_bo and doesn't care if it has an MCS or HiZ buffer > >

[Mesa-dev] [Bug 106197] plasma wayland cant create platform surface with mesa 18.1.0 rc1

https://bugs.freedesktop.org/show_bug.cgi?id=106197 Bug ID: 106197 Summary: plasma wayland cant create platform surface with mesa 18.1.0 rc1 Product: Mesa Version: unspecified Hardware: Other OS: All

Re: [Mesa-dev] [PATCH v3 5/9] i965/wm_surface_state: Use the clear address if it's non-zero

On Mon, Apr 23, 2018 at 11:18:54AM -0700, Jason Ekstrand wrote: > I think you want to say "clear_color_bo is non-NULL" in the commit message > rather than talking about addresses. Otherwise, this looks like a very > nice clean-up. > To make sure we're on the same page, I made an error in using

Re: [Mesa-dev] [PATCH v3 5/9] i965/wm_surface_state: Use the clear address if it's non-zero

Sounds good On April 23, 2018 18:07:19 Nanley Chery wrote: On Mon, Apr 23, 2018 at 11:18:54AM -0700, Jason Ekstrand wrote: > I think you want to say "clear_color_bo is non-NULL" in the commit message > rather than talking about addresses. Otherwise, this looks like a

Re: [Mesa-dev] [PATCH v3 7/9] i965: Add and use a getter for the clear color

I don't really like the helper because it seems like there should be a simpler way to do this. That said, I don't know of one. :-) Reviewed-by: Jason Ekstrand On Wed, Apr 11, 2018 at 1:42 PM, Nanley Chery wrote: > This getter allows CNL to sample

Re: [Mesa-dev] [PATCH 7/7] broadcom/vc4: Native fence fd support

Stefan Schake writes: > With the syncobj support in place, lets use it to implement the > native fence fd extension. This mostly follows previous implementations > in freedreno and etnaviv. Could we include the name of the actual extension being exposed, in the commit

Re: [Mesa-dev] [PATCH 6/7] broadcom/vc4: Expose syncobj import

Stefan Schake writes: > Our submit ioctl allows to optionally specify a syncobj that will be > waited on before job execution. Expose this in our job submission > interface. Since every uint32_t could be a valid syncobj handle, pass > the handle as a pointer so we can make it

[Mesa-dev] [Bug 106151] [amdgpu][vulkan] GPU hang (Vega 56) while running game (Rise of the Tomb Raider)

https://bugs.freedesktop.org/show_bug.cgi?id=106151 --- Comment #9 from Martin F --- The preset I'm using is 'Medium', in 1920x1080. The hang seem to happen very often (or maybe every time when the game was never launched before) at the very beginning of the game (when

[Mesa-dev] [PATCH] Intel: Add a Kaby Lake PCI ID

From: Matt Atwood Signed-off-by: Matt Atwood --- include/pci_ids/i965_pci_ids.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/pci_ids/i965_pci_ids.h b/include/pci_ids/i965_pci_ids.h index c740a50..6cbc32e 100644 ---

Re: [Mesa-dev] [PATCH 2/5] radeonsi: fix error paths of si_texture_transfer_map

On 20/04/18 17:19, Nicolai Hähnle wrote: On 12.04.2018 02:10, Timothy Arceri wrote: On 11/04/18 20:56, Nicolai Hähnle wrote: From: Nicolai Hähnle trans is zero-initialized, but trans->resource is setup immediately so needs to be dereferenced. ---  

Re: [Mesa-dev] [PATCH v2] i965: Add and use a single miptree aux_buf field

Rb On April 23, 2018 20:14:36 Nanley Chery wrote: We want to add and use a function that accesses the auxiliary buffer's clear_color_bo and doesn't care if it has an MCS or HiZ buffer specifically. v2 (Jason Ekstrand): * Drop intel_miptree_get_aux_buffer(). * Mention

[Mesa-dev] [Bug 91169] The Chronicles of Riddick: Assault on Dark Athena fails to start with nouveau

https://bugs.freedesktop.org/show_bug.cgi?id=91169 Timothy Arceri changed: What|Removed |Added Resolution|--- |NOTOURBUG

Re: [Mesa-dev] [PATCH] glsl/glcpp: Handle hex constants with 0X prefix

On 24/04/18 02:04, Vlad Golovkin wrote: 2018-04-23 3:53 GMT+03:00 Timothy Arceri : On 20/04/18 06:08, Vlad Golovkin wrote: GLSL 4.6 spec describes hex constant as: hexadecimal-constant: 0x hexadecimal-digit 0X hexadecimal-digit

[Mesa-dev] [Bug 106174] vulkan dota2 broken (segfaulting), found bug commit

https://bugs.freedesktop.org/show_bug.cgi?id=106174 Timothy Arceri changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [Bug 26904] undefined symbol: GLwCreateM2DrawingArea

https://bugs.freedesktop.org/show_bug.cgi?id=26904 Timothy Arceri changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH] mesa: rename api_validate.{c, h} -> draw_validate.{c, h}

On 23/04/18 15:30, Mathias Fröhlich wrote: Good Morning, I was thinking to also basically 'move' vbo/vbo_exec_array.c to main/draw.c as drawing arrays is today largely independent of the vbo module. Its more the other way round that the vbo module utilizes the draw code path one notch below the

Re: [Mesa-dev] [PATCH 1/3] mesa: merge the driver functions DrawBuffers and DrawBuffer

Hello Timo, what about 2 and 3, #1 landed. Dieter Am 15.04.2018 18:16, schrieb Brian Paul: The series looks OK to me. Reviewed-by: Brian Paul On 04/13/2018 10:45 PM, Timothy Arceri wrote: The extra params we unused by the drivers that used DrawBuffers. ---

[Mesa-dev] [Bug 64668] Clipping is performed incorrectly when using shaders with intel/nouveau/radeon drivers.

https://bugs.freedesktop.org/show_bug.cgi?id=64668 Timothy Arceri changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [Bug 23525] Software rendering on QEMU guests badly broken

https://bugs.freedesktop.org/show_bug.cgi?id=23525 Timothy Arceri changed: What|Removed |Added Status|REOPENED|RESOLVED

Re: [Mesa-dev] [PATCH 1/3] mesa: merge the driver functions DrawBuffers and DrawBuffer

On 24/04/18 10:13, Dieter Nützel wrote: Hello Timo, what about 2 and 3, #1 landed. It turns out the old radeon classic drivers do make use of the param dropped in patch 2 so I've decided to drop that patch, although the use of that param might be a bug as the intel drivers changed their

[Mesa-dev] [Bug 66346] shader_query.cpp:49: error: invalid conversion from 'void*' to 'GLuint'

https://bugs.freedesktop.org/show_bug.cgi?id=66346 Timothy Arceri changed: What|Removed |Added Resolution|--- |FIXED

[Mesa-dev] [Bug 24334] mesa git fails to build with xf86vidmodeproto 2.3

https://bugs.freedesktop.org/show_bug.cgi?id=24334 Timothy Arceri changed: What|Removed |Added Resolution|--- |FIXED

[Mesa-dev] [PATCH 3/3] mesa: call DrawBufferAllocate driver hook in update_framebuffer for windows-system FB

From: Boyan Ding When draw buffers are changed on a bound framebuffer, DrawBufferAllocate() hook should be called. However, it is missing in update_framebuffer with window-system framebuffer, in which FB's draw buffer state should match context state, potentially

[Mesa-dev] [Bug 99116] Wine DirectDraw programs showing only a blackscreen when using Mesa Gallium drivers

https://bugs.freedesktop.org/show_bug.cgi?id=99116 --- Comment #18 from Timothy Arceri --- Ok, new series sent: https://patchwork.freedesktop.org/series/42155/ -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

[Mesa-dev] [PATCH 1/3] mesa: some C99 tidy ups for framebuffer.c

--- src/mesa/main/framebuffer.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/src/mesa/main/framebuffer.c b/src/mesa/main/framebuffer.c index 249e775f8cb..211e97c33bd 100644 --- a/src/mesa/main/framebuffer.c +++ b/src/mesa/main/framebuffer.c @@ -210,14

[Mesa-dev] [PATCH 2/3] st/mesa: add new driver function DrawBufferAllocate

Unlike some of the classic drivers the st was only using DrawBuffer() to allocated some buffers on-demand. Creating a separate function will allow us to call it from update_framebuffer() in the following patch without regressing some of the older classic drivers. --- src/mesa/main/buffers.c

  1   2   >