Re: [Mesa-dev] [PATCH 1/2] loader_dri3: Wait for pending swaps to complete before drawable_fini.

2018-05-04 Thread Mike Lothian
Hi Yes I've not seen any freezes with Plasmashell, so a big improvement Had issues with patch 2 Cheers Mike On 4 May 2018 at 17:36, Mario Kleiner wrote: > On Fri, May 4, 2018 at 6:31 PM, Mike Lothian wrote: >> Hi >> >> I'm still seeing the

Re: [Mesa-dev] [PATCH 1/1] clover: Add explicit virtual destructors to argument and scalar_argument class

2018-05-04 Thread Francisco Jerez
Jan Vesely writes: > These are needed to destroy the v vector. > Fixes memory leaks on kernel launch. > Signed-off-by: Jan Vesely > --- > src/gallium/state_trackers/clover/core/kernel.hpp | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

Re: [Mesa-dev] [RFC PATCH] mesa/st/cb_clear: in st_Clear also validate the render state (needed by virgl)

2018-05-04 Thread Gert Wollny
Am Freitag, den 04.05.2018, 08:21 -0400 schrieb Ilia Mirkin: > On Fri, May 4, 2018 at 7:36 AM, Gert Wollny m> wrote: > > Am Donnerstag, den 03.05.2018, 19:52 +0200 schrieb Gert Wollny: > > > Am Donnerstag, den 03.05.2018, 13:24 -0400 schrieb Ilia Mirkin: > > > > > > >

Re: [Mesa-dev] [PATCH 1/2] loader_dri3: Wait for pending swaps to complete before drawable_fini.

2018-05-04 Thread Mike Lothian
Hi I'm still seeing the freeze in the Steam client with this patch Just about to test the other one Mike On 4 May 2018 at 17:17, Mike Lothian wrote: > Hi Mario > > Again thanks for looking into this issue :D > > Tested-by: Mike Lothian > > I'll give

Re: [Mesa-dev] [PATCH] mesa/main/readpix: Correct handling of packed floating point values

2018-05-04 Thread Ian Romanick
On 04/27/2018 09:04 AM, Gert Wollny wrote: > From: Gert Wollny > > Make sure that clamping in the pixel transfer operations is enabled/disabled > for packed floating point values just like it is done for single normal and > half precision floating point values. > >

Re: [Mesa-dev] [PATCH 1/5] mesa: add support for ARB_sample_locations

2018-05-04 Thread Ian Romanick
A bunch of comments below. This is probably the only patch in the series that I'm going to review. On 05/04/2018 05:09 AM, Rhys Perry wrote: > Signed-off-by: Rhys Perry > --- > src/mapi/glapi/gen/gl_API.xml | 52 +++ > src/mesa/main/config.h

Re: [Mesa-dev] [PATCH 2/2] loader_dri3: Variant 2: Wait for pending swaps to complete before drawable_fini.

2018-05-04 Thread Mike Lothian
Hi The first hunk doesn't apply, the other 3 gives this with GCC 8.1 ../mesa-/src/loader/loader_dri3_helper.c: In function ‘dri3_handle_present_event’: ../mesa-/src/loader/loader_dri3_helper.c:376:13: error: implicit declaration of function ‘printf’

Re: [Mesa-dev] [PATCH 2/2] loader_dri3: Variant 2: Wait for pending swaps to complete before drawable_fini.

2018-05-04 Thread Mario Kleiner
On Fri, May 4, 2018 at 6:45 PM, Mike Lothian wrote: > Hi > > The first hunk doesn't apply, the other 3 gives this with GCC 8.1 > Oops, the perils of applying debug patches on top of debug patches... Can you add a... #include at the top of the file, e.g, after '#include

Re: [Mesa-dev] [PATCH 03/17] i965/miptree: Move init_mcs into alloc_aux_buffer

2018-05-04 Thread Nanley Chery
On Fri, May 04, 2018 at 09:42:34AM -0700, Nanley Chery wrote: > On Thu, May 03, 2018 at 12:03:50PM -0700, Nanley Chery wrote: > > Add infrastructure for initializing the clear color BO. > > --- > > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 68 > > --- > > 1 file

Re: [Mesa-dev] [PATCH 10/10] i965: Require softpin support for Cannonlake and later.

2018-05-04 Thread Kenneth Graunke
On Friday, May 4, 2018 2:10:19 AM PDT Daniel Vetter wrote: > On Fri, May 04, 2018 at 11:07:45AM +0200, Daniel Vetter wrote: > > On Fri, May 04, 2018 at 01:28:02AM -0700, Kenneth Graunke wrote: > > > On Friday, May 4, 2018 1:16:29 AM PDT Kenneth Graunke wrote: > > > > On Friday, May 4, 2018

Re: [Mesa-dev] [PATCH 2/2] loader_dri3: Variant 2: Wait for pending swaps to complete before drawable_fini.

2018-05-04 Thread Mike Lothian
src/loader/loader_dri3_helper.c | 25 + 1 file changed, 25 insertions(+) diff --git a/src/loader/loader_dri3_helper.c b/src/loader/loader_dri3_helper.c index 23729f7ecb..2b2a8d21d8 100644 --- a/src/loader/loader_dri3_helper.c +++ b/src/loader/loader_dri3_helper.c @@ -26,6

Re: [Mesa-dev] [PATCH 03/17] i965/miptree: Move init_mcs into alloc_aux_buffer

2018-05-04 Thread Nanley Chery
On Thu, May 03, 2018 at 12:03:50PM -0700, Nanley Chery wrote: > Add infrastructure for initializing the clear color BO. > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 68 > --- > 1 file changed, 31 insertions(+), 37 deletions(-) > > diff --git

[Mesa-dev] [ANNOUNCE] mesa 18.1.0-rc3

2018-05-04 Thread Dylan Baker
Hello list, Release candidate 3 for the Mesa 18.1.0 is now available. Currently we have: - 16 queued - 0 nominated (outstanding) - 0 rejected patches Lots of fixes for radv; a few for the intel compiler; and spirv, omx, and utils each got a single fix. Take a look at section "Mesa stable

[Mesa-dev] [PATCH 1/2] ac: add subgroup scan functions for SI

2018-05-04 Thread Daniel Schürmann
This functionality is currently disabled due to a bug in LLVM. The idea of this implementation is taken from the ROCm Device Libs: https://github.com/RadeonOpenCompute/ROCm-Device-Libs/blob/master/ockl/src/wfredscan.cl --- src/amd/common/ac_llvm_build.c | 98 -- 1

[Mesa-dev] [PATCH 2/2] radv: enable subgroups arithmetic for VI+

2018-05-04 Thread Daniel Schürmann
--- src/amd/vulkan/radv_device.c | 4 +++- src/amd/vulkan/radv_shader.c | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 9fe415c4e0..ec60f9a9c5 100644 --- a/src/amd/vulkan/radv_device.c +++

Re: [Mesa-dev] [PATCH 01/17] i965/miptree: Fix handling of uninitialized MCS buffers

2018-05-04 Thread Nanley Chery
On Fri, May 04, 2018 at 09:03:32AM +0300, Tapani Pälli wrote: > Hi Nanley; > Hey Tapani, > On 05/03/2018 10:03 PM, Nanley Chery wrote: > > Before this patch, if we failed to initialize an MCS buffer, we'd > > end up in a state in which the miptree thinks it has an MCS buffer, > > but doesn't.

Re: [Mesa-dev] [PATCH 1/2] loader_dri3: Wait for pending swaps to complete before drawable_fini.

2018-05-04 Thread Mike Lothian
Hi Mario Again thanks for looking into this issue :D Tested-by: Mike Lothian I'll give the other patch a whirl now Cheers Mike On 4 May 2018 at 14:45, Mario Kleiner wrote: > Before destroying the loader_dri3_drawable, make sure all pending >

Re: [Mesa-dev] [PATCH 3/4] intel/compiler: Fix lower_conversions for 8-bit types.

2018-05-04 Thread Matt Turner
On Fri, May 4, 2018 at 4:10 AM, Iago Toral Quiroga wrote: > From: Jose Maria Casanova Crespo > > For 8-bit types the execution type is word. A byte raw MOV has 16-bit > execution type and 8-bit destination and it shouldn't be considered > a conversion

Re: [Mesa-dev] [PATCH 03/17] i965/miptree: Move init_mcs into alloc_aux_buffer

2018-05-04 Thread Nanley Chery
On Fri, May 04, 2018 at 10:00:32AM -0700, Nanley Chery wrote: > On Fri, May 04, 2018 at 09:42:34AM -0700, Nanley Chery wrote: > > On Thu, May 03, 2018 at 12:03:50PM -0700, Nanley Chery wrote: > > > Add infrastructure for initializing the clear color BO. > > > --- > > >

[Mesa-dev] [PATCH 2/7] swr/rast: Use binner topology to assemble backend attributes

2018-05-04 Thread George Kyriazis
Previously was using the draw topology, which may change if GS or Tess are active. Only affected attributes marked with constant interpolation, which limited the impact. --- src/gallium/drivers/swr/rasterizer/core/binner.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 1/7] swr/rast: Change formatting

2018-05-04 Thread George Kyriazis
--- src/gallium/drivers/swr/rasterizer/core/api.cpp | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/api.cpp b/src/gallium/drivers/swr/rasterizer/core/api.cpp index a2ee85d..3458793 100644 ---

[Mesa-dev] [PATCH 7/7] swr/rast: Thread locked tiles improvement

2018-05-04 Thread George Kyriazis
- Change tilemgr TILE_ID encoding to use Morton-order (Z-order). - Change locked tiles set to bitset. Makes clear, set, get much faster. --- src/gallium/drivers/swr/rasterizer/core/api.cpp| 11 ++- src/gallium/drivers/swr/rasterizer/core/context.h | 2 +-

[Mesa-dev] [PATCH 1/1] clover: Add explicit virtual destructors to argument and scalar_argument class

2018-05-04 Thread Jan Vesely
These are needed to destroy the v vector. Fixes memory leaks on kernel launch. Signed-off-by: Jan Vesely --- src/gallium/state_trackers/clover/core/kernel.hpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/state_trackers/clover/core/kernel.hpp

Re: [Mesa-dev] [PATCH 1/2] loader_dri3: Wait for pending swaps to complete before drawable_fini.

2018-05-04 Thread Mario Kleiner
On Fri, May 4, 2018 at 6:31 PM, Mike Lothian wrote: > Hi > > I'm still seeing the freeze in the Steam client with this patch > > Just about to test the other one > Thanks for testing. So the plasmashell hang is gone, right? Maybe the steam issue is a different bug. With

Re: [Mesa-dev] [PATCH] intel: devinfo: fix assertion on devices with odd number of EUs

2018-05-04 Thread Kenneth Graunke
On Monday, April 23, 2018 9:52:37 AM PDT Lionel Landwerlin wrote: > I forgot to change the assert in the second helper function in a > previous change. > > This hit the assert() on a Broadwell platform with quite a few EUs > fused off : >https://i.imgur.com/4Wx6tjz.png Not sure this link

[Mesa-dev] [PATCH 4/7] swr/rast: Add ConcatLists()

2018-05-04 Thread George Kyriazis
for concatenating lists --- src/gallium/drivers/swr/rasterizer/codegen/gen_common.py | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/gallium/drivers/swr/rasterizer/codegen/gen_common.py b/src/gallium/drivers/swr/rasterizer/codegen/gen_common.py index 44a0cc8..60b749d 100644 ---

[Mesa-dev] [PATCH 6/7] swr/rast: Add Builder::GetVectorType()

2018-05-04 Thread George Kyriazis
--- .../drivers/swr/rasterizer/jitter/builder.cpp | 44 ++ .../drivers/swr/rasterizer/jitter/builder.h| 1 + 2 files changed, 45 insertions(+) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/builder.cpp

[Mesa-dev] [PATCH 0/7] SWR changes

2018-05-04 Thread George Kyriazis
Misc OpenSWR changes George Kyriazis (7): swr/rast: Change formatting swr/rast: Use binner topology to assemble backend attributes swr/rast: Add constant initializer for uint64_t swr/rast: Add ConcatLists() swr/rast: Prepend the console output with a newline swr/rast: Add

[Mesa-dev] [PATCH 5/7] swr/rast: Prepend the console output with a newline

2018-05-04 Thread George Kyriazis
It can get jumbled with output from other threads. --- .../swr/rasterizer/codegen/templates/gen_ar_eventhandlerfile.hpp| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/codegen/templates/gen_ar_eventhandlerfile.hpp

[Mesa-dev] [PATCH 3/7] swr/rast: Add constant initializer for uint64_t

2018-05-04 Thread George Kyriazis
--- src/gallium/drivers/swr/rasterizer/jitter/builder_misc.cpp | 5 + src/gallium/drivers/swr/rasterizer/jitter/builder_misc.h | 1 + 2 files changed, 6 insertions(+) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/builder_misc.cpp

Re: [Mesa-dev] [PATCH v3] i965: Fix ETC2/EAC GetCompressed* functions on Gen7 GPUs

2018-05-04 Thread Eero Tamminen
Hi, On 04.05.2018 14:11, Eleni Maria Stea wrote: Thanks for your feedback, On Thu, 3 May 2018 13:30:38 +0300 Eero Tamminen wrote: On 02.05.2018 20:19, Matt Turner wrote: On Wed, May 2, 2018 at 9:13 AM, Eleni Maria Stea wrote: Gen 7 GPUs store

Re: [Mesa-dev] [PATCH 2/2] i965/fs: Register allocator shoudn't use grf127 for sends dest (v2)

2018-05-04 Thread Chema Casanova
This patch is still pending of review. Adding also Cc: to stable as if fixes some cts issues. Chema El 19/04/18 a las 02:38, Jose Maria Casanova Crespo escribió: > Since Gen8+ Intel PRM states that "r127 must not be used for return > address when there is a src and dest overlap in send

Re: [Mesa-dev] [PATCH 01/10] i965: perf: sklgt2: update a priority for register programming

2018-05-04 Thread Kenneth Graunke
On Friday, May 4, 2018 7:52:44 AM PDT Lionel Landwerlin wrote: > This makes no difference in term of programming, it's just a cleanup. > > Signed-off-by: Lionel Landwerlin > --- > src/mesa/drivers/dri/i965/brw_oa_sklgt2.xml | 4 ++-- > 1 file changed, 2

Re: [Mesa-dev] [PATCH 02/10] i965: perf: sklgt2: drop special programming for pre-production stepping

2018-05-04 Thread Kenneth Graunke
On Friday, May 4, 2018 7:52:45 AM PDT Lionel Landwerlin wrote: > Production steppings don't need this anymore. > > Signed-off-by: Lionel Landwerlin > --- > src/mesa/drivers/dri/i965/brw_oa_sklgt2.xml | 10 ++ > 1 file changed, 2 insertions(+), 8

[Mesa-dev] [PATCH 1½/9] util: Add a randomized test for the virtual memory allocator

2018-05-04 Thread Scott D Phillips
The test pseudo-randomly makes allocations and deallocations with the virtual memory allocator and checks that the results are consistent. Specifically, we test that: * no result from the allocator overlaps an already allocated range * allocated memory fulfills the stated alignment requirement

[Mesa-dev] [PATCH 4/4] i965/drm: Purge the bucket when its cached buffer is evicted

2018-05-04 Thread James Xiong
From: "Xiong, James" When one of cached buffers is found to be evicted by kernel, most likely the buffers freed earlier than this buffer are gone too, go through the cached list in the bucket and purge. Signed-off-by: Xiong, James ---

[Mesa-dev] [PATCH 2/4] i965/drm: Round down buffer size and calculate the bucket index

2018-05-04 Thread James Xiong
From: "Xiong, James" a buffer is now put in cached bucket #n when its size is between bucket[n].size and bucket[n+1].size - 1 Signed-off-by: Xiong, James --- src/mesa/drivers/dri/i965/brw_bufmgr.c | 11 +-- 1 file changed, 5 insertions(+),

[Mesa-dev] [PATCH 1/4] i965/drm: Reorganize code for the next patch

2018-05-04 Thread James Xiong
From: "Xiong, James" split bo_alloc_internal, and add a new function cached_bo_for_size searches for a suitable cached buffer for a given size. Signed-off-by: Xiong, James --- src/mesa/drivers/dri/i965/brw_bufmgr.c | 92

[Mesa-dev] [PATCH 3/4] i965/drm: Searching for a cached buffer for reuse

2018-05-04 Thread James Xiong
From: "Xiong, James" Now that a bucket contains cached buffers with different sizes, go through its list and search for a cached buffer with enough size. Signed-off-by: Xiong, James --- src/mesa/drivers/dri/i965/brw_bufmgr.c | 21

[Mesa-dev] [PATCH 0/4] improve buffer cache and reuse

2018-05-04 Thread James Xiong
From: "Xiong, James" With the current implementation, brw_bufmgr may round up a request size to the next bucket size, result in 25% more memory allocated in the worst senario. For example: Request sizeActual size 32KB+1Byte 40KB . 8MB+1Byte 10MB . 96MB+1Byte

Re: [Mesa-dev] [PATCH 2/2] i965: add {X, A}BGR2101010 to |intel_image_formats|

2018-05-04 Thread Chad Versace
On Wed 02 May 2018, Miguel Casas wrote: > This patch adds {X,A}BGR2101010 entries to the list of supported > |intel_image_formats|. > > BUG=https://crbug.com/776093 > TEST=Compile and deploy mesa this patch, then playback > a VP9 Profile 2 video with sw decoder using crrev.com/c/897894. > --- >

Re: [Mesa-dev] [PATCH 3/4] intel/compiler: Fix lower_conversions for 8-bit types.

2018-05-04 Thread Jason Ekstrand
Series is Reviewed-by: Jason Ekstrand On Fri, May 4, 2018 at 10:45 AM, Matt Turner wrote: > On Fri, May 4, 2018 at 4:10 AM, Iago Toral Quiroga > wrote: > > From: Jose Maria Casanova Crespo > > > > For

Re: [Mesa-dev] [PATCH 2/2] loader_dri3: Variant 2: Wait for pending swaps to complete before drawable_fini.

2018-05-04 Thread Mario Kleiner
On Sat, May 5, 2018 at 4:08 AM, Mike Lothian wrote: > I definately saw the steam bug with patch 1 but not with plasmashell, > I started seeing it with patch 2 but it seemed to fix itself > I had two hangs of kwin_x11 within the last 6 hours when alt-tabbing between windows,

Re: [Mesa-dev] [PATCH 1½/9] util: Add a randomized test for the virtual memory allocator

2018-05-04 Thread Scott D Phillips
Scott D Phillips writes: > The test pseudo-randomly makes allocations and deallocations with > the virtual memory allocator and checks that the results are > consistent. Specifically, we test that: > > * no result from the allocator overlaps an already allocated

Re: [Mesa-dev] [PATCH 1/2] mesa: add R10G10B10{A, X}2 to MESA <-> DRI format translations

2018-05-04 Thread Chad Versace
Thanks for the patches. The code looks good. All my suggestions are merely nitpicks to make the patches follow Mesa conventions. In general, if you have questions about commit message style, examine the git log for previous patches that touched the same files and directories as yours. Sometimes,

Re: [Mesa-dev] [PATCH 06/10] i965: Add virtual memory allocator infrastructure to brw_bufmgr.

2018-05-04 Thread Chris Wilson
Quoting Kenneth Graunke (2018-05-04 02:12:36) > + if (brw_using_softpin(bufmgr) && bo->gtt_offset == 0ull) { > + bo->gtt_offset = vma_alloc(bufmgr, memzone, bo->size, 1); > + > + if (bo->gtt_offset == 0ull) > + goto err_free; > + } > + > bo->name = name; >

[Mesa-dev] [Bug 106180] [bisected] radv vulkan smoke test black screen (Add support for DRI3 v1.2)

2018-05-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106180 --- Comment #13 from Bas Nieuwenhuizen --- To confirm, you are running radv while using intel for the X server? -- You are receiving this mail because: You are the assignee for the

Re: [Mesa-dev] [PATCH 3/5] ffvertex: Don't try to read output registers in fog calculation

2018-05-04 Thread Kenneth Graunke
On Thursday, April 26, 2018 2:28:41 PM PDT Ian Romanick wrote: > From: Ian Romanick > > This code was clearly never tested. It's a good thing that no driver > ever tried to enable this path. > > Signed-off-by: Ian Romanick > --- >

Re: [Mesa-dev] [PATCH v3] i965: Fix ETC2/EAC GetCompressed* functions on Gen7 GPUs

2018-05-04 Thread Eleni Maria Stea
Hi Eero, On Fri, 4 May 2018 18:29:55 +0300 Eero Tamminen wrote: > You mean returning CAVEAT_SUPPORT in params for compressed formats > which are transparently converted to uncompressed data? Well, that would be the best solution I think, if it's possible to modify an

Re: [Mesa-dev] [PATCH 01/10] i965: Set initial kflags on BO creation.

2018-05-04 Thread Chris Wilson
Quoting Kenneth Graunke (2018-05-04 02:12:31) > This simplifies kflag initialization, by creating a bufmgr-wide setting > for initial kflags, and just applying it whenever we create a new BO. > > This also properly allows 48-bit addresses for imported BOs (via prime > or flink), which I had

Re: [Mesa-dev] [PATCH 1/1] vulkan/wsi/x11: Fix properly check if the system has DRI_MODIFIERS

2018-05-04 Thread Bas Nieuwenhuizen
On Thu, May 3, 2018 at 8:10 PM, mercuriete wrote: > From: Abel Garcia Dorta > > Bug: https://bugs.freedesktop.org/show_bug.cgi?id=106180 > > Fixes: c80c08e226 "vulkan/wsi/x11: Add support for DRI3 v1.2" > > Cc: > ---

[Mesa-dev] [PATCH] mesa: fix error handling in get_framebuffer_parameteriv

2018-05-04 Thread Rhys Perry
CC: Signed-off-by: Rhys Perry --- src/mesa/main/fbobject.c | 72 +++- 1 file changed, 41 insertions(+), 31 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c

Re: [Mesa-dev] [RFC PATCH] mesa/st/cb_clear: in st_Clear also validate the render state (needed by virgl)

2018-05-04 Thread Gurchetan Singh
On Fri, May 4, 2018 at 1:11 PM, Ilia Mirkin wrote: > On Fri, May 4, 2018 at 2:50 PM, Gert Wollny wrote: >> For that reason I think that a render state validation within st_Clear >> makes sense, because it makes sure that the states like

Re: [Mesa-dev] radv: Support for control flow attributes (SPIR-V: Unroll, DontUnroll and maybe Flatten, DontFlatten)

2018-05-04 Thread Panagiotis Christopoulos Charitos
ping Panagiotis Christopoulos Charitos www.ancient-ritual.com www.anki3d.org On Mon, Apr 30, 2018 at 12:36 PM, Panagiotis Christopoulos Charitos < godl...@ancient-ritual.com> wrote: > Hi, > > I have multiple shaders that are part of my opensource engine and I see >

[Mesa-dev] [PATCH 1/1] vulkan/wsi/x11: Fix properly check if the system has DRI_MODIFIERS

2018-05-04 Thread mercuriete
From: Abel Garcia Dorta Bug: https://bugs.freedesktop.org/show_bug.cgi?id=106180 Fixes: c80c08e226 "vulkan/wsi/x11: Add support for DRI3 v1.2" Cc: --- src/vulkan/wsi/wsi_common_x11.c | 5 + 1 file changed, 1 insertion(+), 4

[Mesa-dev] [PATCH 0/1] vulkan/wsi/x11: Fix properly check if the system has DRI_MODIFIERS

2018-05-04 Thread mercuriete
Hi this is my first patch to mesa, im not sure how to contribute In some conditions the assertion is triggered because the code don't check properly if you have DRI_MODIFIERS. The comment says "If the image has a modifier, we must have DRI3 v1.2" but this is not true in my system. Happy review!

[Mesa-dev] [PATCH 0/1] vulkan/wsi/x11: Fix properly check if the system has DRI_MODIFIERS

2018-05-04 Thread mercuriete
Hi this is my first patch to mesa, im not sure how to contribute In some conditions the assertion is triggered because the code don't check properly if you have DRI_MODIFIERS. The comment says "If the image has a modifier, we must have DRI3 v1.2" but this is not true in my system. Happy review!

Re: [Mesa-dev] [PATCH 07/10] i965: Prepare batchbuffer module for softpin support.

2018-05-04 Thread Chris Wilson
Quoting Kenneth Graunke (2018-05-04 02:12:37) > @@ -933,6 +945,14 @@ emit_reloc(struct intel_batchbuffer *batch, > { > assert(target != NULL); > > + if (target->kflags & EXEC_OBJECT_PINNED) { > + brw_use_pinned_bo(batch, target, reloc_flags & RELOC_WRITE); > + return

Re: [Mesa-dev] [RFC PATCH] mesa/st/cb_clear: in st_Clear also validate the render state (needed by virgl)

2018-05-04 Thread Ilia Mirkin
On Fri, May 4, 2018 at 5:30 PM, Gert Wollny wrote: > Am Freitag, den 04.05.2018, 16:11 -0400 schrieb Ilia Mirkin: >> On Fri, May 4, 2018 at 2:50 PM, Gert Wollny > m> wrote: >> > For that reason I think that a render state validation within >>

[Mesa-dev] [Bug 106180] [bisected] radv vulkan smoke test black screen (Add support for DRI3 v1.2)

2018-05-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106180 Bas Nieuwenhuizen changed: What|Removed |Added QA Contact|mesa-dev@lists.freedesktop. |

[Mesa-dev] [Bug 106400] [CI][SNB] glsl-1.40 and 1.50 texturesize / geometry tests failing

2018-05-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106400 Timothy Arceri changed: What|Removed |Added Component|glsl-compiler

Re: [Mesa-dev] [RFC PATCH] mesa/st/cb_clear: in st_Clear also validate the render state (needed by virgl)

2018-05-04 Thread Ilia Mirkin
On Fri, May 4, 2018 at 2:50 PM, Gert Wollny wrote: > For that reason I think that a render state validation within st_Clear > makes sense, because it makes sure that the states like SCISSOR_TEST > or DISCARD_RASTERIZER are properly send to the driver, before clear() >

Re: [Mesa-dev] [PATCH 4/4] anv/device: expose shaderInt16 support in gen8+

2018-05-04 Thread Mark Janes
Patches 1-4 are Tested-by: Mark Janes Iago Toral Quiroga writes: > This rollbacks the revert of this patch introduced with > commit 7cf284f18e6774c810ed6db17b98e597bf96f8a5. > --- > src/intel/vulkan/anv_device.c | 2 +- > 1 file changed, 1

Re: [Mesa-dev] [PATCH 05/10] i965: Introduce a "memory zone" concept on BO allocation.

2018-05-04 Thread Chris Wilson
Quoting Kenneth Graunke (2018-05-04 02:12:35) > diff --git a/src/mesa/drivers/dri/i965/brw_bufmgr.c > b/src/mesa/drivers/dri/i965/brw_bufmgr.c > index 66f30a1637f..66828f319be 100644 > --- a/src/mesa/drivers/dri/i965/brw_bufmgr.c > +++ b/src/mesa/drivers/dri/i965/brw_bufmgr.c > @@ -268,6 +268,7

Re: [Mesa-dev] [RFC PATCH] mesa/st/cb_clear: in st_Clear also validate the render state (needed by virgl)

2018-05-04 Thread Gert Wollny
Am Freitag, den 04.05.2018, 16:11 -0400 schrieb Ilia Mirkin: > On Fri, May 4, 2018 at 2:50 PM, Gert Wollny m> wrote: > > For that reason I think that a render state validation within > > st_Clear makes sense, because it makes sure that the states > > like SCISSOR_TEST

Re: [Mesa-dev] [PATCH v2 05/14] etnaviv: take care of the number of layers

2018-05-04 Thread Lucas Stach
Am Dienstag, den 01.05.2018, 16:48 +0200 schrieb Christian Gmeiner: > With the help of the number of layers we can choose the correct > RS clear format - like the binary blob does. > > Signed-off-by: Christian Gmeiner > --- >  src/gallium/drivers/etnaviv/etnaviv_rs.c

Re: [Mesa-dev] [PATCH 10/10] i965: Require softpin support for Cannonlake and later.

2018-05-04 Thread Kenneth Graunke
On Friday, May 4, 2018 12:39:12 AM PDT Chris Wilson wrote: > Quoting Kenneth Graunke (2018-05-04 08:34:07) > > On Thursday, May 3, 2018 11:53:24 PM PDT Chris Wilson wrote: > > > Quoting Kenneth Graunke (2018-05-04 02:12:40) > > > > This isn't strictly necessary, but anyone running Cannonlake will

Re: [Mesa-dev] [PATCH 10/10] i965: Require softpin support for Cannonlake and later.

2018-05-04 Thread Daniel Vetter
On Fri, May 04, 2018 at 01:16:29AM -0700, Kenneth Graunke wrote: > On Friday, May 4, 2018 12:39:12 AM PDT Chris Wilson wrote: > > Quoting Kenneth Graunke (2018-05-04 08:34:07) > > > On Thursday, May 3, 2018 11:53:24 PM PDT Chris Wilson wrote: > > > > Quoting Kenneth Graunke (2018-05-04 02:12:40) >

Re: [Mesa-dev] [PATCH 10/10] i965: Require softpin support for Cannonlake and later.

2018-05-04 Thread Daniel Vetter
On Fri, May 04, 2018 at 01:28:02AM -0700, Kenneth Graunke wrote: > On Friday, May 4, 2018 1:16:29 AM PDT Kenneth Graunke wrote: > > On Friday, May 4, 2018 12:39:12 AM PDT Chris Wilson wrote: > > > Quoting Kenneth Graunke (2018-05-04 08:34:07) > > > > On Thursday, May 3, 2018 11:53:24 PM PDT Chris

Re: [Mesa-dev] [PATCH 10/10] i965: Require softpin support for Cannonlake and later.

2018-05-04 Thread Daniel Vetter
On Fri, May 04, 2018 at 11:07:45AM +0200, Daniel Vetter wrote: > On Fri, May 04, 2018 at 01:28:02AM -0700, Kenneth Graunke wrote: > > On Friday, May 4, 2018 1:16:29 AM PDT Kenneth Graunke wrote: > > > On Friday, May 4, 2018 12:39:12 AM PDT Chris Wilson wrote: > > > > Quoting Kenneth Graunke

Re: [Mesa-dev] [PATCH 06/10] i965: Add virtual memory allocator infrastructure to brw_bufmgr.

2018-05-04 Thread Chris Wilson
Quoting Kenneth Graunke (2018-05-04 08:59:43) > For full-PPGTT platforms, we definitely don't want to keep relocs. For > non-full-PPGTT platforms...yeah, we can assign addresses...but if we > conflict with some other process...the kernel will just move them > anyway. I guess we could choose

Re: [Mesa-dev] [PATCH 10/10] i965: Require softpin support for Cannonlake and later.

2018-05-04 Thread Kenneth Graunke
On Friday, May 4, 2018 1:16:29 AM PDT Kenneth Graunke wrote: > On Friday, May 4, 2018 12:39:12 AM PDT Chris Wilson wrote: > > Quoting Kenneth Graunke (2018-05-04 08:34:07) > > > On Thursday, May 3, 2018 11:53:24 PM PDT Chris Wilson wrote: > > > > Quoting Kenneth Graunke (2018-05-04 02:12:40) > > >

Re: [Mesa-dev] [PATCH 10/10] i965: Require softpin support for Cannonlake and later.

2018-05-04 Thread Chris Wilson
Quoting Daniel Vetter (2018-05-04 09:45:15) > On Fri, May 04, 2018 at 01:16:29AM -0700, Kenneth Graunke wrote: > > On Friday, May 4, 2018 12:39:12 AM PDT Chris Wilson wrote: > > > Quoting Kenneth Graunke (2018-05-04 08:34:07) > > > > On Thursday, May 3, 2018 11:53:24 PM PDT Chris Wilson wrote: > >

[Mesa-dev] [Bug 106377] eglWaitClient() doesn't work for surfaceless contexts

2018-05-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106377 --- Comment #2 from Tapani Pälli --- I've filed following bug for discussion: https://gitlab.khronos.org/egl/API/issues/12 -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for

Re: [Mesa-dev] [PATCH 10/10] i965: Require softpin support for Cannonlake and later.

2018-05-04 Thread Kenneth Graunke
On Thursday, May 3, 2018 11:53:24 PM PDT Chris Wilson wrote: > Quoting Kenneth Graunke (2018-05-04 02:12:40) > > This isn't strictly necessary, but anyone running Cannonlake will > > already have Kernel 4.5 or later, so there's no reason to support > > the relocation model on Gen10+. > > /o\ gvt.

Re: [Mesa-dev] [PATCH] egl: add EGL_BAD_MATCH error case for surfaceless and android

2018-05-04 Thread Juan A. Suarez Romero
Reviewed-by: Juan A. Suarez On Fri, 2018-05-04 at 08:28 +0300, Tapani Pälli wrote: > Just like is done for other backends when suitable config is not > found (added in fd4eba4929). > > Signed-off-by: Tapani Pälli > --- >

Re: [Mesa-dev] [PATCH 06/10] i965: Add virtual memory allocator infrastructure to brw_bufmgr.

2018-05-04 Thread Kenneth Graunke
On Friday, May 4, 2018 12:02:33 AM PDT Chris Wilson wrote: > Quoting Kenneth Graunke (2018-05-04 02:12:36) > > This introduces a new fast virtual memory allocator integrated with our > > BO cache bucketing. For larger objects, it falls back to the simple > > free-list allocator (util_vma). > > I

[Mesa-dev] [PATCH 2/4] i965/compiler: handle conversion to smaller type in the lowering pass for that

2018-05-04 Thread Iago Toral Quiroga
This rollbacks the revert of this same patch introduced in commit 7b9c15628aae8729118b648f5f473e6ac926b99b. --- src/intel/compiler/brw_fs_lower_conversions.cpp | 5 - src/intel/compiler/brw_fs_nir.cpp | 14 +++--- 2 files changed, 7 insertions(+), 12 deletions(-) diff

Re: [Mesa-dev] [PATCH v3] i965: Fix ETC2/EAC GetCompressed* functions on Gen7 GPUs

2018-05-04 Thread Eleni Maria Stea
Hi Eero, Thanks for your feedback, On Thu, 3 May 2018 13:30:38 +0300 Eero Tamminen wrote: > Hi, > > On 02.05.2018 20:19, Matt Turner wrote: > > On Wed, May 2, 2018 at 9:13 AM, Eleni Maria Stea > > wrote: > >> Gen 7 GPUs store the compressed

Re: [Mesa-dev] [RFC PATCH] mesa/st/cb_clear: in st_Clear also validate the render state (needed by virgl)

2018-05-04 Thread Gert Wollny
Am Donnerstag, den 03.05.2018, 19:52 +0200 schrieb Gert Wollny: > Am Donnerstag, den 03.05.2018, 13:24 -0400 schrieb Ilia Mirkin: > > > > The api call is "clear", not "glClear in the context of whatever > > random GL state there might be". When the gallium clear API is > > invoked, the bound

[Mesa-dev] [PATCH 3/5] st/mesa: add support for ARB_sample_locations

2018-05-04 Thread Rhys Perry
Signed-off-by: Rhys Perry --- src/mesa/state_tracker/st_atom_framebuffer.c | 64 src/mesa/state_tracker/st_cb_msaa.c | 22 ++ src/mesa/state_tracker/st_extensions.c | 1 + 3 files changed, 87 insertions(+) diff --git

[Mesa-dev] [PATCH 5/5] docs/features: mark GL_ARB_sample_locations as DONE for nvc0

2018-05-04 Thread Rhys Perry
Signed-off-by: Rhys Perry --- docs/features.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/features.txt b/docs/features.txt index b1eb9e91a2..cf15ac854f 100644 --- a/docs/features.txt +++ b/docs/features.txt @@ -305,7 +305,7 @@ Khronos,

[Mesa-dev] [PATCH 1/5] mesa: add support for ARB_sample_locations

2018-05-04 Thread Rhys Perry
Signed-off-by: Rhys Perry --- src/mapi/glapi/gen/gl_API.xml | 52 +++ src/mesa/main/config.h | 7 + src/mesa/main/dd.h | 7 + src/mesa/main/extensions_table.h| 1 + src/mesa/main/fbobject.c

[Mesa-dev] [PATCH 3/4] intel/compiler: Fix lower_conversions for 8-bit types.

2018-05-04 Thread Iago Toral Quiroga
From: Jose Maria Casanova Crespo For 8-bit types the execution type is word. A byte raw MOV has 16-bit execution type and 8-bit destination and it shouldn't be considered a conversion case. So there is no need to change alignment and enter in lower_conversions for these

[Mesa-dev] [PATCH 0/4] Intel: fixes to regressions caused by shaderInt16

2018-05-04 Thread Iago Toral Quiroga
This series fixes these two bug reports: https://bugs.freedesktop.org/show_bug.cgi?id=106393 https://bugs.freedesktop.org/show_bug.cgi?id=106389 Caused by the shaderInt16 series we landed yesterday. Details follow: Bug #106389 was triggered on BSW-like platforms, which apparently are not

[Mesa-dev] [PATCH 1/4] intel/compiler: handle 16-bit to 64-bit conversions in BSW platforms

2018-05-04 Thread Iago Toral Quiroga
These are subject to the general restriction that anything that is converted to 64-bit needs to be aligned to 64-bit. We had this already in place for 32-bit to 64-bit conversions, so this patch generalizes the implementation to take effect on any conversion to 64-bit from a source smaller than

[Mesa-dev] [PATCH 4/4] anv/device: expose shaderInt16 support in gen8+

2018-05-04 Thread Iago Toral Quiroga
This rollbacks the revert of this patch introduced with commit 7cf284f18e6774c810ed6db17b98e597bf96f8a5. --- src/intel/vulkan/anv_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index 0563eae5c1..fd516fb846

Re: [Mesa-dev] [PATCH v2 08/14] mesa: handle OES_texture_half_float formats in _mesa_base_tex_format()

2018-05-04 Thread Tapani Pälli
On 05/04/2018 02:12 PM, Tapani Pälli wrote: On 05/04/2018 10:15 AM, Christian Gmeiner wrote: Hi On 05/01/2018 05:48 PM, Christian Gmeiner wrote: Signed-off-by: Christian Gmeiner Reviewed-by: Wladimir J. van der Laan ---   

[Mesa-dev] [Bug 106400] [CI][SNB] glsl-1.40 and 1.50 texturesize / geometry tests failing

2018-05-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106400 --- Comment #2 from Tomi Sarvela --- Thanks, It seems that there is some issue with blacklisting. From runlog, it seems that these tests should be excluded (line beginning with Options)

Re: [Mesa-dev] [RFC PATCH] mesa/st/cb_clear: in st_Clear also validate the render state (needed by virgl)

2018-05-04 Thread Ilia Mirkin
On Fri, May 4, 2018 at 7:36 AM, Gert Wollny wrote: > Am Donnerstag, den 03.05.2018, 19:52 +0200 schrieb Gert Wollny: >> Am Donnerstag, den 03.05.2018, 13:24 -0400 schrieb Ilia Mirkin: >> > >> > The api call is "clear", not "glClear in the context of whatever >> > random

Re: [Mesa-dev] [PATCH v2] egl: check if colorspace/surface type is supported

2018-05-04 Thread Juan A. Suarez Romero
On Fri, 2018-05-04 at 08:29 +0300, Tapani Pälli wrote: > > On 05/03/2018 08:49 PM, Emil Velikov wrote: > > On 2 May 2018 at 17:23, Juan A. Suarez Romero wrote: > > > According to EGL 1.4 spec, section 3.5.1 ("Creating On-Screen Rendering > > > Surfaces"), if config does not

Re: [Mesa-dev] [PATCH v2 08/14] mesa: handle OES_texture_half_float formats in _mesa_base_tex_format()

2018-05-04 Thread Tapani Pälli
On 05/04/2018 10:15 AM, Christian Gmeiner wrote: Hi On 05/01/2018 05:48 PM, Christian Gmeiner wrote: Signed-off-by: Christian Gmeiner Reviewed-by: Wladimir J. van der Laan --- src/mesa/main/glformats.c | 19 +++ 1 file

[Mesa-dev] [Bug 106401] swr driver failing mesa build on 32 bit

2018-05-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106401 Bug ID: 106401 Summary: swr driver failing mesa build on 32 bit Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal

[Mesa-dev] [PATCH 0/5] Implement ARB_sample_locations for nvc0

2018-05-04 Thread Rhys Perry
This patch set adds support for GL_ARB_sample_locations in mesa core, gallium, the mesa OpenGL state tracker and the nvc0 driver. Rhys Perry (5): mesa: add support for ARB_sample_locations gallium: add support for programmable sample locations st/mesa: add support for ARB_sample_locations

[Mesa-dev] [PATCH 4/5] nvc0: add support for programmable sample locations

2018-05-04 Thread Rhys Perry
Signed-off-by: Rhys Perry --- .../drivers/nouveau/codegen/nv50_ir_driver.h | 2 + .../drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 7 + .../nouveau/codegen/nv50_ir_lowering_nvc0.cpp | 91 ++-- .../nouveau/codegen/nv50_ir_lowering_nvc0.h

[Mesa-dev] [PATCH 2/5] gallium: add support for programmable sample locations

2018-05-04 Thread Rhys Perry
Signed-off-by: Rhys Perry --- src/gallium/auxiliary/cso_cache/cso_context.c| 31 +++ src/gallium/auxiliary/cso_cache/cso_context.h| 5 src/gallium/auxiliary/util/u_framebuffer.c | 32

[Mesa-dev] [RFC] Fix attempt for Mesa + X-Server 1.20 + modesetting-ddx hangs on KDE5.

2018-05-04 Thread Mario Kleiner
Two patches, solving the same problem in two different ways, the 1st one ready to go, the 2nd one would need the debug statements removed. Only apply one of those for testing, the 2nd one will be useless with the 1st one applied, but demonstrates the problem. So X-Server 1.20 RC +

[Mesa-dev] [PATCH 1/2] loader_dri3: Wait for pending swaps to complete before drawable_fini.

2018-05-04 Thread Mario Kleiner
Before destroying the loader_dri3_drawable, make sure all pending swaps for it have completed. This guides against the following scenario, which happens, e.g., with KDE Plasma-5's plasmashell (which uses QT-5's QtGui/QtQuick for rendering), when it repaints multiple UI elements, each represented

[Mesa-dev] [PATCH 2/2] loader_dri3: Variant 2: Wait for pending swaps to complete before drawable_fini.

2018-05-04 Thread Mario Kleiner
See previous patch in series for explanation of the problem. This method avoids a blocking loader_dri3_swapbuffer_barrier() call whenever a GL contexts drawables are changed via glXMakeCurrent et al. Instead it filters out the "orphaned" PresentNotify events from previous incarnations of the

Re: [Mesa-dev] [PATCH] egl: add EGL_BAD_MATCH error case for surfaceless and android

2018-05-04 Thread Emil Velikov
On 4 May 2018 at 06:28, Tapani Pälli wrote: > Just like is done for other backends when suitable config is not > found (added in fd4eba4929). > > Signed-off-by: Tapani Pälli Thanks for fixing this up. Reviewed-by: Emil Velikov

  1   2   >