Ported from RadeonSI.
This might fix some synchronization issues.
I don't know if that will affect performance.
CC:
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_cmd_buffer.c | 6 ++
src/amd/vulkan/radv_private.h| 2 ++
src/amd/vulkan/si_cmd_buffer.c | 12 +++-
3
Reviewed-by: Bas Nieuwenhuizen
for the series.
On Thu, Jun 21, 2018 at 3:01 AM, Marek Olšák wrote:
> These were all discovered on Stoney except for the last patch, which is a
> precaution.
>
> Please review.
>
> Thanks,
> Marek
> ___
> mesa-dev
On Tuesday, June 12, 2018 12:44:44 PM PDT Kenneth Graunke wrote:
> On Thursday, May 31, 2018 10:01:43 PM PDT Jason Ekstrand wrote:
> > Ideally, I'd like the series to get some amount of real review before it
> > lands. Honestly, it's been baking long enough and tested by enough people
> > on
On Thursday, May 31, 2018 10:06:47 PM PDT Jason Ekstrand wrote:
[snip]
> @@ -529,57 +509,55 @@ static bool
> load_from_deref_entry_value(struct copy_prop_var_state *state,
> struct copy_entry *entry,
> nir_builder *b, nir_intrinsic_instr
On Wed, 2018-06-20 at 18:23 +0300, andrii.simiklit wrote:
> Hello,
>
> Thanks for your feedback.
>
>
>
> > We don't implement GS before gen6, and I don't think there are
> > plans
> > for it at this point, so I think we can just simplify the patch by
> > assuming that devinfo->gen is
HI all,
Sorry, just ignore this patch with incorrect subject.
I will send correct one shortly.
Regards,
Andrii.
On Thu, Jun 21, 2018 at 4:12 PM, Andrii Simiklit
wrote:
> We can not use the VUE Dereference flags combination for EOT
> message under ILK and SNB because the threads are not
On Thursday, 2018-06-21 11:42:29 +0200, Juan A. Suarez Romero wrote:
> On Tue, 2018-06-19 at 11:53 +0200, Juan A. Suarez Romero wrote:
> > On Mon, 2018-06-18 at 16:29 +0100, Eric Engestrom wrote:
> > > On Monday, 2018-06-18 16:23:41 +0200, Juan A. Suarez Romero wrote:
> > > > RADV now requires
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106986
Signed-off-by: Danylo Piliaiev
---
src/mesa/main/queryobj.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/main/queryobj.c b/src/mesa/main/queryobj.c
index 7ee820a..7547fa1 100644
--- a/src/mesa/main/queryobj.c
+++
We can not use the VUE Dereference flags combination for EOT
message under ILK and SNB because the threads are not initialized
there with initial VUE handle unlike Pre-IL.
So to avoid GPU hangs on SNB and ILK we need
to avoid usage of the VUE Dereference flags combination.
(Was tested only on SNB
On 20 June 2018 at 16:19, Dylan Baker wrote:
> Quoting Emil Velikov (2018-06-20 05:33:48)
>> From: Emil Velikov
>>
>> Earlier commit removed the column, instead of adjusting it's height.
>>
>> Cc: Dylan Baker
>> Fixes: 0d4f338a116 ("docs: Update release-notes and calendar")
>> Signed-off-by:
On 31 May 2018 at 00:25, Eric Anholt wrote:
> Tomeu Vizoso writes:
>
>> Virgl could save a lot of work converting buffers in the host side
>> between formats if Mesa supported a bunch of other formats when reading
>> pixels.
>>
>> This commit adds cases to handle specific formats so that the
https://bugs.freedesktop.org/show_bug.cgi?id=106986
Danylo changed:
What|Removed |Added
CC||danylo.pilia...@gmail.com
--- Comment #1 from
The extension is enabled for compat profile but there is currently
no display list support.
---
src/mesa/main/dlist.c | 87 +++
1 file changed, 87 insertions(+)
diff --git a/src/mesa/main/dlist.c b/src/mesa/main/dlist.c
index 8b1ddb05038..e5c8f22ac80
We can not use the VUE Dereference flags combination for EOT
message under ILK and SNB because the threads are not initialized
there with initial VUE handle unlike Pre-IL.
So to avoid GPU hangs on SNB and ILK we need
to avoid usage of the VUE Dereference flags combination.
(Was tested only on SNB
https://bugs.freedesktop.org/show_bug.cgi?id=106986
Bug ID: 106986
Summary: glGetQueryiv error when querying number of result bits
for GL_ANY_SAMPLES_PASSED_CONSERVATIVE
Product: Mesa
Version: git
Hardware: All
On Tue, 2018-06-19 at 11:53 +0200, Juan A. Suarez Romero wrote:
> On Mon, 2018-06-18 at 16:29 +0100, Eric Engestrom wrote:
> > On Monday, 2018-06-18 16:23:41 +0200, Juan A. Suarez Romero wrote:
> > > RADV now requires LLVM 5.0 or greater, and thus we can't build dist
> > > tarball because swr
On Wed, 2018-06-20 at 20:11 +, Cherniak, Bruce wrote:
> > On Jun 18, 2018, at 9:23 AM, Juan A. Suarez Romero
> > wrote:
> >
> > RADV now requires LLVM 5.0 or greater, and thus we can't build dist
> > tarball because swr requires LLVM 4.0.
> >
> > Let's bump required LLVM to 5.0 in swr too.
Until now we have assumed that we could skip emitting these barriers
in the general case based on empirical testing and a few assumptions
detailed in a comment in the driver code, however, recent CTS tests
have showed that we actually need them to produce correct behavior.
---
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_device.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index 681d8a12c7..b72b5d969d 100644
--- a/src/amd/vulkan/radv_device.c
+++
From my point of view, when we aren't able to submit a CS
something terribly wrong happens and we are most likely
going to lost the device.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_device.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_device.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index 3c63d8c86d..681d8a12c7 100644
--- a/src/amd/vulkan/radv_device.c
+++
On 19 June 2018 at 10:53, Juan A. Suarez Romero wrote:
> On Mon, 2018-06-18 at 16:29 +0100, Eric Engestrom wrote:
>> On Monday, 2018-06-18 16:23:41 +0200, Juan A. Suarez Romero wrote:
>> > RADV now requires LLVM 5.0 or greater, and thus we can't build dist
>> > tarball because swr requires LLVM
Hi Rob,
On Wed, Jun 20, 2018 at 10:26 PM Robert Foss wrote:
>
> This patch both adds support for probing & filtering DRM nodes
> and switches away from using the GRALLOC_MODULE_PERFORM_GET_DRM_FD
> gralloc call.
>
> Currently the filtering is based just on the driver name,
> and the desired name
Hello,
Thanks for your feedback.
I made changes which you requested.
I hope that I understood you right.
The solution which you suggested "VUE allocation unconditionally" fixes this bug
and we have avoided the endif in the program end.
Ok, then we are in agreement.
Section 1.6.5.4 VUE
Quoting Emil Velikov (2018-04-24 10:49:21)
> From: Emil Velikov
>
> Bring back the "detection" of the said variables, to allow
> standalone execution.
>
> Fixes: db8cd8e36771 ("glcpp/tests: Convert shell scripts to a python
> script")
> Cc: Dylan Baker
> Signed-off-by: Emil Velikov
> ---
>
Signed-off-by: Lionel Landwerlin
Acked-by: Rafael Antognolli
---
src/intel/Makefile.am |2 +
src/intel/tools/intel_dump_gpu.c | 1313 +
src/intel/tools/intel_dump_gpu.in | 107 +++
src/intel/tools/meson.build | 18 +
4 files changed, 1440
From: Jason Ekstrand
This is a simple, invasive, liberally licensed red-black tree
implementation. It's an invasive data structure similar to the
Linux kernel linked-list where the intention is that you embed a
rb_node struct the data structure you intend to put into the
tree.
The
Signed-off-by: Lionel Landwerlin
---
src/intel/dev/gen_device_info.c | 47 ++---
src/intel/dev/gen_device_info.h | 5
2 files changed, 48 insertions(+), 4 deletions(-)
diff --git a/src/intel/dev/gen_device_info.c b/src/intel/dev/gen_device_info.c
index
From: Scott D Phillips
v2: by Lionel
Fix memfd_create compilation issue
Fix pml4 address stored on 32 instead of 64bits
Return no buffer if first ppgtt page is not mapped
v3: Drop additional memfd_create() (Rafael)
Signed-off-by: Lionel Landwerlin
Reviewed-by: Rafael Antognolli
Now that we're softpinning the address of our BOs in anv & i965, the
addresses selected start at the top of the addressing space. This is a
problem for the current implementation of aubinator which uses only a
40bit mmapped address space.
This change keeps track of all the memory writes from the
Signed-off-by: Lionel Landwerlin
Reviewed-by: Rafael Antognolli
---
src/intel/common/gen_batch_decoder.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/intel/common/gen_batch_decoder.c
b/src/intel/common/gen_batch_decoder.c
index 81d8298c28b..fc0ff95a476 100644
---
Hi all,
Some fixes spotted by Rafael.
Thanks,
Jason Ekstrand (1):
util: rb-tree: A simple, invasive, red-black tree
Lionel Landwerlin (12):
intel: aubinator: remove unused variables
intel: aubinator: remove standard input processing option
intel: aubinator: rework register writes
On a follow up commit in this series, we stop copying the data from
the mmap'ed file into our big gtt mmap, and start referencing data in
it directly. So reallocating the read buffer and adding more data from
stdin wouldn't work. For that reason, let's stop supporting stdin
process.
With PPGTT mappings, our aubinator implementation can be quite slow if
we request a buffer that doesn't exist. Instead of doing a PPGTT walk
for invalid addresses (0 lengths), wait until we're sure we want to
decode the data.
Signed-off-by: Lionel Landwerlin
Reviewed-by: Rafael Antognolli
---
Scott added new stuff in IGT.
Signed-off-by: Lionel Landwerlin
Reviewed-by: Rafael Antognolli
---
src/intel/tools/intel_aub.h | 26 ++
1 file changed, 26 insertions(+)
diff --git a/src/intel/tools/intel_aub.h b/src/intel/tools/intel_aub.h
index 5f0aba8e68e..9ca548edaf3
Ping
Am Samstag, den 26.05.2018, 23:20 +0200 schrieb Gert Wollny:
> One must not assume that compiling swr on non-Windows platforms is
> always
> done for 64 bit archs. For instance in an Gentoo multiarch
> installation if
> swr is enabled, it will be build for all archs.
>
> Fixes:
On Thu, Jun 21, 2018 at 7:37 AM, Keith Packard wrote:
> Jason Ekstrand writes:
>
> >> + if (!ret)
> >> + return VK_SUCCESS;
> >> +
> >> + if (errno != ENOMEM) {
> >
> > This strikes me as a bit odd. What does ENOMEM mean if not "out of
> > memory"?
>
> ENOMEM means that the
https://bugs.freedesktop.org/show_bug.cgi?id=106283
--- Comment #11 from i...@yahoo.com ---
(In reply to iive from comment #10)
> Just a reminder about the shader replacement feature request.
>
> I hope that you haven't forgotten about it.
When I got my first reply I was so hopeful that this
Quoting Eric Engestrom (2018-06-21 08:43:56)
> On Thursday, 2018-06-21 08:38:05 -0700, Dylan Baker wrote:
> > Currently if vdpau is set to auto, it will be disabled only in cases
> > where gallium is disabled or the host OS is not supported (mac, haiku,
> > windows). However on (for example) Linux
Signed-off-by: Lionel Landwerlin
Reviewed-by: Rafael Antognolli
---
src/intel/tools/aubinator.c | 82 -
1 file changed, 54 insertions(+), 28 deletions(-)
diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c
index 92db1ed0b31..d0b26219eb4
These memory offsets are stored in the gen_batch_decode_ctx.
Signed-off-by: Lionel Landwerlin
Reviewed-by: Rafael Antognolli
---
src/intel/tools/aubinator.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c
index
Gently ping to get a review O:)
J.A.
On Wed, 2018-06-06 at 12:40 +0200, Juan A. Suarez Romero wrote:
> When creating a windows surface with eglCreateWindowSurface(), the
> width and height returned by eglQuerySurface(EGL_{WIDTH,HEIGHT}) is
> invalid until buffers are updated (like
This patch is
Reviewed-by: Rafael Antognolli
On Thu, Jun 21, 2018 at 05:29:05PM +0100, Lionel Landwerlin wrote:
> We use memfd to store physical pages as they get read/written to and
> the GGTT entries translating virtual address to physical pages.
>
> Based on a commit by Scott Phillips.
>
>
The same as the previous two patches, but for the libva state tracker.
Fixes: 724916c8a84b5bba8f880f17da936585d52c97b6
("meson: dedup gallium-xvmc logic")
Signed-off-by: Dylan Baker
---
meson.build | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git
Currently if vdpau is set to auto, it will be disabled only in cases
where gallium is disabled or the host OS is not supported (mac, haiku,
windows). However on (for example) Linux if libvdpau is not installed
then the build will error because of the unmet dependency. This corrects
auto to do the
This fixes the same problem as the previous patch did for vdpau, but for
xvmc.
Fixes: 724916c8a84b5bba8f880f17da936585d52c97b6
("meson: dedup gallium-xvmc logic")
Signed-off-by: Dylan Baker
---
meson.build | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git
From: Scott D Phillips
Reviewed-by: Lionel Landwerlin
---
src/intel/common/gen_batch_decoder.c | 18 ++
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/src/intel/common/gen_batch_decoder.c
b/src/intel/common/gen_batch_decoder.c
index 3852f32de36..2b6978da92d
We already embed the headers, no need to redefine defines/structs.
Signed-off-by: Lionel Landwerlin
---
src/intel/tools/intel_dump_gpu.c | 30 +-
1 file changed, 1 insertion(+), 29 deletions(-)
diff --git a/src/intel/tools/intel_dump_gpu.c
From: Scott D Phillips
For gen8+, write out PPGTT tables in aub files so that full 48-bit
addresses can be serialized.
v2: Fix handling of `end` index in map_ppgtt
v3: Correctly mark GGTT entry as present (Rafael)
Signed-off-by: Scott D Phillips
Signed-off-by: Lionel Landwerlin
Cc: Jordan
Signed-off-by: Lionel Landwerlin
---
src/intel/tools/intel_aub.h | 2 +-
src/intel/tools/intel_dump_gpu.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/intel/tools/intel_aub.h b/src/intel/tools/intel_aub.h
index 2888515048f..74ca26ab9bb 100644
---
We use memfd to store physical pages as they get read/written to and
the GGTT entries translating virtual address to physical pages.
Based on a commit by Scott Phillips.
Signed-off-by: Lionel Landwerlin
---
src/intel/tools/aubinator.c | 257 ++--
1 file changed,
Jason Ekstrand writes:
>> + if (!ret)
>> + return VK_SUCCESS;
>> +
>> + if (errno != ENOMEM) {
>
> This strikes me as a bit odd. What does ENOMEM mean if not "out of
> memory"?
ENOMEM means that the queue is full and that we should drain it and try
again; that's what the
On Thursday, 2018-06-21 08:38:05 -0700, Dylan Baker wrote:
> Currently if vdpau is set to auto, it will be disabled only in cases
> where gallium is disabled or the host OS is not supported (mac, haiku,
> windows). However on (for example) Linux if libvdpau is not installed
> then the build will
The offset field is 22 bit large.
11 bits are necessary because MaxVertexAttribRelativeOffset = 2047
Signed-off-by: Jonathan Marek
---
src/gallium/drivers/freedreno/a2xx/instr-a2xx.h | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git
the format of the CLEAR_COLOR register doesn't depend on the target format
this fixes clear color when rendering to 32-bit RGBA and 16-bit targets
Signed-off-by: Jonathan Marek
---
src/gallium/drivers/freedreno/a2xx/fd2_draw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Signed-off-by: Jonathan Marek
---
src/gallium/drivers/freedreno/a2xx/fd2_program.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/gallium/drivers/freedreno/a2xx/fd2_program.c
b/src/gallium/drivers/freedreno/a2xx/fd2_program.c
index 9a77457251..834a7c7fcd 100644
---
https://bugs.freedesktop.org/show_bug.cgi?id=106283
--- Comment #12 from Mark Janes ---
do you have an apitrace file of your workload, so I can test this functionality
in FrameRetrace?
--
You are receiving this mail because:
You are the assignee for the
On Monday, June 11, 2018 7:25:55 PM PDT Francisco Jerez wrote:
> This replaces brw_set_message_descriptor() with the composition of
> brw_set_desc() and a new inline helper function that packs the common
> message descriptor controls into an integer. The goal is to represent
> all message
On Thu, Jun 21, 2018 at 11:16 PM, Daniel Vetter wrote:
> Hi all,
>
> The X.org board is soliciting proposals to host XDC in 2019. By the usual
> rotation a location in (North) America is preferred, but the board will also
> consider other locations, especially if there's an interesting
blend can be NULL, so check for that
Signed-off-by: Jonathan Marek
---
src/gallium/drivers/freedreno/a2xx/fd2_emit.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/gallium/drivers/freedreno/a2xx/fd2_emit.c
b/src/gallium/drivers/freedreno/a2xx/fd2_emit.c
index
this patch adds support for a20x, which has some differences with a220:
-no VGT_MAX_VTX_INDX register
-no CLEAR_COLOR register
-set RB_BC_CONTROL in restore (hangs without)
-different CP_DRAW_INDX format
tested with kmscube and glmark2 scenes, on par with a220
Signed-off-by: Jonathan Marek
---
Jason Ekstrand writes:
>> Looks good. With that, patches 1-3 are
>
> Reviewed-by: Jason Ekstrand
Thanks.
> I'll let Dave or Bas review your fence hackery in radv.
Sounds fine. I'll prod them if I don't get any response in the next day
or so.
--
-keith
signature.asc
Description: PGP
Hi all,
The X.org board is soliciting proposals to host XDC in 2019. By the usual
rotation a location in (North) America is preferred, but the board will also
consider other locations, especially if there's an interesting co-location
with another conference.
If you consider hosting XDC, we have
Timothy Arceri writes:
> nir_compact_varyings() is meant to skip over varyings used by xfb:
>
> /* We can't repack xfb varyings. */
> if (var->data.always_active_io)
> continue;
>
> Any idea why that isn't working in this case?
Looks like GLSL IR has that flag
Add memory object support for nvc0 and nv50
Signed-off-by: Miguel A Vico Moya
---
.../drivers/nouveau/nv50/nv50_miptree.c | 49 +
.../drivers/nouveau/nv50/nv50_resource.c | 52 +++
.../drivers/nouveau/nv50/nv50_resource.h | 33
Enable EXT_external_objects for nvc0 and nv50
Signed-off-by: Miguel A Vico Moya
---
src/gallium/drivers/nouveau/nv50/nv50_screen.c | 2 +-
src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
Hi,
These patches have been sitting in my local tree for some time now. They
are kind of related to the Generic Allocator work, but not specific to it.
James Jones's original kmscube port
(https://gitlab.freedesktop.org/allocator/kmscube) relies on the
EXT_external_objects extension to import
Kenneth Graunke writes:
> On Monday, June 11, 2018 7:25:55 PM PDT Francisco Jerez wrote:
>> This replaces brw_set_message_descriptor() with the composition of
>> brw_set_desc() and a new inline helper function that packs the common
>> message descriptor controls into an integer. The goal is to
Kenneth Graunke writes:
> We were enabling undefined memory checking for genxml values based on
> Valgrind being installed at build time, even for release builds. This
> generates piles and piles of assembly whenever you touch genxml.
>
> With gcc 7.3.1 and -O3 and -march=native on a Kabylake
On Thursday, June 21, 2018 2:59:30 PM PDT Francisco Jerez wrote:
> Kenneth Graunke writes:
>
> > On Monday, June 11, 2018 7:25:55 PM PDT Francisco Jerez wrote:
> >> This replaces brw_set_message_descriptor() with the composition of
> >> brw_set_desc() and a new inline helper function that packs
Hi Miguel,
Preface: I know little about this ext, so feel free to educate me on
the wrongness of my thinking.
On Thu, Jun 21, 2018 at 10:01 PM, Miguel A. Vico wrote:
> Add memory object support for nvc0 and nv50
>
> Signed-off-by: Miguel A Vico Moya
> ---
>
On Monday, June 11, 2018 7:26:11 PM PDT Francisco Jerez wrote:
> diff --git a/src/intel/compiler/brw_eu.c b/src/intel/compiler/brw_eu.c
> index 6ef0a6a577c..80f05240b42 100644
> --- a/src/intel/compiler/brw_eu.c
> +++ b/src/intel/compiler/brw_eu.c
> @@ -356,14 +356,14 @@ brw_disassemble(const
On Monday, June 11, 2018 7:25:52 PM PDT Francisco Jerez wrote:
> This series contains a few code generation refactors and clean-ups
> that are starting to pile up in an internal branch. By itself this
> series shouldn't cause any functional changes, but there's no reason
> why it couldn't be
From: Karol Herbst
helps mainly feral ported games
shader-db changes:
total instructions in shared programs : 5751418 -> 5730139 (-0.37%)
total gprs used in shared programs: 664007 -> 663206 (-0.12%)
total shared used in shared programs : 548832 -> 548832 (0.00%)
total local used in shared
From: Karol Herbst
helps mainly feral ported games
changes in shader-db:
total instructions in shared programs : 5730139 -> 5726007 (-0.07%)
total gprs used in shared programs: 663206 -> 663147 (-0.01%)
total shared used in shared programs : 548832 -> 548832 (0.00%)
total local used in
Fixes a crash triggered by the next patch.
no changes in shader-db
Signed-off-by: Karol Herbst
---
src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp
Doesn't break on games I tested with and piglit was okay with that as well.
Plan to test this on my Kepler card later.
total changes in shader-db:
total instructions in shared programs : 5751418 -> 5726007 (-0.44%)
total gprs used in shared programs: 664007 -> 663147 (-0.13%)
total shared
77 matches
Mail list logo
