[Mesa-dev] [PATCH] nvc0,gm107/ir: add cycle count estimation

2018-07-08 Thread Rhys Perry
With branching, for simplicity and usefulness, this assumes both paths are taken. With loops, it assumes their basic blocks execute 10 times. The average latency for variable latency instructions in this patch is rather poor, with only something reasonably accurate for IMUL/IMAD. It should be

Re: [Mesa-dev] [PATCH 2/2] radv: add the trace BO to the list when starting a new cmdbuf

2018-07-08 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen for the series. On Tue, Jul 3, 2018 at 12:43 PM, Samuel Pitoiset wrote: > That might reduce CPU overhead a little bit when using > RADV_TRACE_FILE. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 11 +++ > 1 file changed, 7

Re: [Mesa-dev] [PATCH] loader_dri3: Handle mismatched depth 30 formats for Prime renderoffload.

2018-07-08 Thread Mario Kleiner
Ping. One more loose patch following the same logic/principle as the x11+egl patch for nouveau depth 30, that would benefit from a r-b and ideally make it into Mesa 18.2. to clear out nouveau depth 30 support. Obsessively tested by now by myself on intel, amd, nouveau and dri3/present with prime

Re: [Mesa-dev] [PATCH 1/2] radv: introduce radv_subpass_attachment data structure

2018-07-08 Thread Bas Nieuwenhuizen
On Sun, Jul 8, 2018 at 5:47 PM, Samuel Pitoiset wrote: > Needed for VK_KHR_create_renderpass2. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 4 ++-- > src/amd/vulkan/radv_meta_clear.c | 4 ++-- > src/amd/vulkan/radv_meta_resolve.c| 14

Re: [Mesa-dev] [PATCH 2/2] radv: add support for VK_KHR_create_renderpass2

2018-07-08 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen for the series. On Sun, Jul 8, 2018 at 5:47 PM, Samuel Pitoiset wrote: > VkCreateRenderPass2KHR() is quite similar to VkCreateRenderPass() > but refactoring the code is a bit painful. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c

Re: [Mesa-dev] [PATCH] radv: using tls to store llvm related info and speed up compiles (v8)

2018-07-08 Thread Bas Nieuwenhuizen
On Thu, Jul 5, 2018 at 2:03 AM, Dave Airlie wrote: > From: Dave Airlie > > This uses the common compiler passes abstraction to help radv > avoid fixed cost compiler overheads. This uses a linked list per > thread stored in thread local storage, with an entry in the list > for each target

[Mesa-dev] [Bug 107158] When compiling against musl libc, pthread.h is not included in radv_amdgpu_winsys

2018-07-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107158 Bug ID: 107158 Summary: When compiling against musl libc, pthread.h is not included in radv_amdgpu_winsys Product: Mesa Version: 18.0 Hardware: All OS:

[Mesa-dev] [Bug 107158] When compiling against musl libc, pthread.h is not included in radv_amdgpu_winsys

2018-07-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107158 Bas Nieuwenhuizen changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #1 from Bas

[Mesa-dev] [Bug 107156] earth tessellation bug

2018-07-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107156 Timothy Arceri changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #3 from Timothy

[Mesa-dev] [PATCH 3/9] i965: Support for 8-bit base types in helper functions

2018-07-08 Thread Jose Maria Casanova Crespo
Reviewed-by: Jason Ekstrand --- src/intel/compiler/brw_fs_nir.cpp | 11 ++- src/intel/compiler/brw_nir.c | 4 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/src/intel/compiler/brw_fs_nir.cpp b/src/intel/compiler/brw_fs_nir.cpp index 02ac92e62f1..83ed9575f80

[Mesa-dev] [PATCH 1/9] intel/compiler: grf127 can not be dest when src and dest overlap in send

2018-07-08 Thread Jose Maria Casanova Crespo
Implement at brw_eu_validate the restriction from Intel Broadwell PRM, vol 07, section "Instruction Set Reference", subsection "EUISA Instructions", Send Message (page 990): "r127 must not be used for return address when there is a src and dest overlap in send instruction." v2: Style fixes (Matt

[Mesa-dev] [PATCH 4/9] i965/fs: Enable conversions to 8-bit integers

2018-07-08 Thread Jose Maria Casanova Crespo
Reviewed-by: Jason Ekstrand --- src/intel/compiler/brw_fs_nir.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/intel/compiler/brw_fs_nir.cpp b/src/intel/compiler/brw_fs_nir.cpp index 83ed9575f80..4155b2ed996 100644 --- a/src/intel/compiler/brw_fs_nir.cpp +++

[Mesa-dev] [PATCH 2/9] i965/fs: Register allocator shoudn't use grf127 for sends dest

2018-07-08 Thread Jose Maria Casanova Crespo
Since Gen8+ Intel PRM states that "r127 must not be used for return address when there is a src and dest overlap in send instruction." This patch implements this restriction creating new grf127_send_hack_node at the register allocator. This node has a fixed assignation to grf127. For vgrf that

[Mesa-dev] [PATCH 0/9] anv: Enable VK_KHR_8bit_storage

2018-07-08 Thread Jose Maria Casanova Crespo
This series enables support to VK_KHR_8bit_storage vulkan extension for anv. It enables all capabilities available for this extension including StorageBuffer8BitAccess, UniformAndStorageBuffer8BitAccess and StoragePushConstant8. 8-bit read operations from UBO and SSBO and push constants are

[Mesa-dev] [PATCH 5/9] intel/compiler: relax brw_eu_validate for byte raw movs

2018-07-08 Thread Jose Maria Casanova Crespo
When the destination is a BYTE type allow raw movs even if the stride is not exact multiple of destination type and exec type, execution type is Word and its size is 2. This restriction was only allowing stride==2 destinations for 8-bit types. Reviewed-by: Jason Ekstrand ---

[Mesa-dev] [PATCH 7/9] spirv: Include headers and grammar for SPV_KHR_8bit_storage

2018-07-08 Thread Jose Maria Casanova Crespo
Update to headers and grammar to ff684ffc6a35d2a58f0f63108877d0064ea33feb --- src/compiler/spirv/spirv.core.grammar.json | 44 ++ src/compiler/spirv/spirv.h | 3 ++ 2 files changed, 40 insertions(+), 7 deletions(-) diff --git

[Mesa-dev] [PATCH 6/9] i965/fs: Enable store_ssbo for 8-bit types.

2018-07-08 Thread Jose Maria Casanova Crespo
v2: Update comment according to this patch. (Jason Ekstrand) Reviewed-by: Jason Ekstrand --- src/intel/compiler/brw_fs_nir.cpp | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/src/intel/compiler/brw_fs_nir.cpp b/src/intel/compiler/brw_fs_nir.cpp index

[Mesa-dev] [PATCH 8/9] spirv/nir: Add support for SPV_KHR_8bit_storage

2018-07-08 Thread Jose Maria Casanova Crespo
Reviewed-by: Jason Ekstrand --- src/compiler/shader_info.h| 1 + src/compiler/spirv/spirv_to_nir.c | 6 ++ 2 files changed, 7 insertions(+) diff --git a/src/compiler/shader_info.h b/src/compiler/shader_info.h index 8c58ee285ec..3b95d5962c0 100644 --- a/src/compiler/shader_info.h +++

[Mesa-dev] [PATCH 9/9] anv: Enable SPV_KHR_8bit_storage and VK_KHR_8bit_storage

2018-07-08 Thread Jose Maria Casanova Crespo
Enables SPV_KHR_8bit_storage and VK_KHR_8bit_storage on gen 8+ using the VK_KHR_get_physical_device_properties2 functionality to expose if the extension is supported or not. Reviewed-by: Jason Ekstrand --- src/intel/vulkan/anv_device.c | 11 +++ src/intel/vulkan/anv_extensions.py |

Re: [Mesa-dev] [PATCH 7/9] spirv: Include headers and grammar for SPV_KHR_8bit_storage

2018-07-08 Thread Jason Ekstrand
Acked-by: Jason Ekstrand On Sun, Jul 8, 2018 at 5:29 PM Jose Maria Casanova Crespo < jmcasan...@igalia.com> wrote: > Update to headers and grammar to ff684ffc6a35d2a58f0f63108877d0064ea33feb > --- > src/compiler/spirv/spirv.core.grammar.json | 44 ++ >

Re: [Mesa-dev] Nouveau depth 30 stuff again..

2018-07-08 Thread Mario Kleiner
Ping? I think this series should be ready for merging, had all review comments addressed and was obsessively tested by myself on intel, amd, nouveau and dri3/present with prime renderoffload for intel+nouveau, amd+nouveau and nouveau+amd, on both native x11 and wayland+weston. It makes many things

[Mesa-dev] [PATCH v2] egl: Fix missing clamping in eglSetDamageRegionKHR

2018-07-08 Thread Harish Krupo
Clamp the x and y co-ordinates of the rectangles. v2: Clamp width/height after converting to co-ordinates (Ilia Merkin) Signed-off-by: Harish Krupo --- src/egl/main/eglapi.c | 25 +++-- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git

[Mesa-dev] [Bug 107156] earth tessellation bug

2018-07-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107156 Bug ID: 107156 Summary: earth tessellation bug Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: normal

Re: [Mesa-dev] [PATCH 7/7] anv: Add support for VK_KHR_create_renderpass2

2018-07-08 Thread Lionel Landwerlin
On 07/07/18 17:29, Jason Ekstrand wrote: The implementation of CreateRenderPass2 uses the helpers we broke out in previous commits. The implementations of the new vkCmd functions just call the old versions. --- src/intel/vulkan/anv_extensions.py | 1 + src/intel/vulkan/anv_pass.c|

Re: [Mesa-dev] [PATCH 1/7] vulkan: Update the XML and headers to 1.1.80

2018-07-08 Thread Lionel Landwerlin
Acked-by: Lionel Landwerlin ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 107156] earth tessellation bug

2018-07-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107156 --- Comment #1 from ximik --- Created attachment 140506 --> https://bugs.freedesktop.org/attachment.cgi?id=140506=edit earth tessellation bug -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact

Re: [Mesa-dev] [PATCH 2/7] anv/pass: Use a designated initailizer for attachments

2018-07-08 Thread Lionel Landwerlin
With the version bumped in patch 7, patches 2-7 are : Reviewed-by: Lionel Landwerlin ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 107156] earth tessellation bug

2018-07-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107156 --- Comment #2 from ximik --- Created attachment 140507 --> https://bugs.freedesktop.org/attachment.cgi?id=140507=edit earth tessellation bug -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee

[Mesa-dev] [Bug 107022] [RADV] The Witcher 3: Trembling of trees

2018-07-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107022 --- Comment #1 from ximik --- on the video on the embedded link is visible. same problem. card r290x, the driver of the message 18-18.2 git link https://mega.nz/#!Pr5nmYTQ!uGrPyzSW32-Ln60x2jUxrvtW3VH9rG2b2uTgC1iwe18 -- You are receiving

Re: [Mesa-dev] [PATCH 1/3] nir: handle no variable in derefs in some places

2018-07-08 Thread Jason Ekstrand
On Tue, Jul 3, 2018 at 11:25 PM Dave Airlie wrote: > From: Dave Airlie > > --- > src/compiler/nir/nir_gather_info.c | 2 ++ > src/compiler/nir/nir_lower_indirect_derefs.c | 4 > src/compiler/nir/nir_lower_vars_to_ssa.c | 4 > 3 files changed, 10 insertions(+) > > diff

Re: [Mesa-dev] [PATCH 2/9] i965/fs: Register allocator shoudn't use grf127 for sends dest

2018-07-08 Thread Jason Ekstrand
This is a very clever solution to the problem. I like it. :-) Reviewed-by: Jason Ekstrand I think that's all of them. I've pushed the XML bump so you should be able to land at will. --Jason On Sun, Jul 8, 2018 at 5:29 PM Jose Maria Casanova Crespo < jmcasan...@igalia.com> wrote: > Since

[Mesa-dev] [PATCH] nir/vars_to_ssa: Don't build deref nodes for non-local variables

2018-07-08 Thread Jason Ekstrand
--- src/compiler/nir/nir_lower_vars_to_ssa.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/compiler/nir/nir_lower_vars_to_ssa.c b/src/compiler/nir/nir_lower_vars_to_ssa.c index 3f37acaed33..ef2019551c6 100644 --- a/src/compiler/nir/nir_lower_vars_to_ssa.c +++

[Mesa-dev] [PATCH] nv50/ir: fix use of getUniqueInsn() in loadProjTexCoords

2018-07-08 Thread Rhys Perry
Fixes "value not uniquely defined" messages during shader-db runs. Fixes: 57594065c30feec9376b "nv50/ir: import new shader backend code" Signed-off-by: Rhys Perry --- src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

[Mesa-dev] [PATCH 2/2] radv: add support for VK_KHR_create_renderpass2

2018-07-08 Thread Samuel Pitoiset
VkCreateRenderPass2KHR() is quite similar to VkCreateRenderPass() but refactoring the code is a bit painful. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 24 + src/amd/vulkan/radv_extensions.py | 1 + src/amd/vulkan/radv_pass.c| 169

[Mesa-dev] [PATCH 1/2] radv: introduce radv_subpass_attachment data structure

2018-07-08 Thread Samuel Pitoiset
Needed for VK_KHR_create_renderpass2. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 4 ++-- src/amd/vulkan/radv_meta_clear.c | 4 ++-- src/amd/vulkan/radv_meta_resolve.c| 14 +++--- src/amd/vulkan/radv_meta_resolve_cs.c | 4 ++--

[Mesa-dev] [Bug 106644] [llvmpipe] Mesa 18.1.2 fails lp_test_format, lp_test_arit, lp_test_blend, lp_test_printf, lp_test_conv tests

2018-07-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106644 --- Comment #28 from erhar...@mailbox.org --- (In reply to Ben Crocker from comment #26) I added the following exports % export GALLIVM_MATTRS="-vsx" % export GALLIVM_VSX=0 as you suggested, but the tests still segfault. Config was:

[Mesa-dev] [Bug 106644] [llvmpipe] Mesa 18.1.2 fails lp_test_format, lp_test_arit, lp_test_blend, lp_test_printf, lp_test_conv tests

2018-07-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106644 erhar...@mailbox.org changed: What|Removed |Added Attachment #140477|0 |1 is obsolete|