[Mesa-dev] [AppVeyor] mesa staging/18.1 #8356 failed

2018-07-19 Thread AppVeyor
Build mesa 8356 failed Commit 6561cc8f86 by Jason Ekstrand on 7/12/2018 9:05 PM: intel/blorp: Handle 3-component formats in clears\n\nThis fixes a nasty hang in Batman: Arkham City which apparently calls\nvkCmdClearColorImage on a linear RGB image.\n\ncc:

Re: [Mesa-dev] [PATCH 1/6] gallium: add new SAMP2HND and IMG2HND opcodes

2018-07-19 Thread Marek Olšák
On Wed, Jun 6, 2018 at 6:42 PM, Ilia Mirkin wrote: > On Wed, Jun 6, 2018 at 3:55 PM, Rhys Perry wrote: >> This commit does not add support for the opcodes in gallivm or tgsi_to_nir.c >> >> Signed-off-by: Rhys Perry >> --- >> src/gallium/auxiliary/tgsi/tgsi_info.c | 2 ++ >>

Re: [Mesa-dev] [PATCH 1/4] radv: make use of radv_subpass_barrier() when resolving subpasses

2018-07-19 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen for the series. On Wed, Jul 18, 2018 at 4:19 PM, Samuel Pitoiset wrote: > The goal is to use radv_barrier()/radv_subpass_barrier() as > much as possible for further optimizations. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c

[Mesa-dev] [PATCH] radeonsi: Add debug option to enable LLVM GlobalISel (v2)

2018-07-19 Thread Marek Olšák
From: Tom Stellard R600_DEBUG=gisel will tell LLVM to use GlobalISel rather than SelectionDAG for instruction selection. v2: mareko: move the helper to src/amd/common Signed-off-by: Marek Olšák --- src/amd/common/ac_llvm_helper.cpp | 7 +++ src/amd/common/ac_llvm_util.c |

Re: [Mesa-dev] [PATCH] virgl: remove unused stride-arguments

2018-07-19 Thread Gurchetan Singh
Reviewed-by: Gurchetan Singh On Wed, Jul 18, 2018 at 4:06 AM Erik Faye-Lund wrote: > > The IOCTLs doesn't pass this along, so computing them in the first > place is kinda pointless. > > Signed-off-by: Erik Faye-Lund > --- > > This is just a cleanup I noticed based on some discussion with Gert.

Re: [Mesa-dev] [PATCH 2/2] ac, radeonsi: reduce optimizations for complex compute shaders on older APUs

2018-07-19 Thread Dave Airlie
On 20 July 2018 at 13:12, Marek Olšák wrote: > From: Marek Olšák > > To make dEQP-GLES31.functional.ssbo.layout.random.all_shared_buffer.23 > finish sooner on the older CPUs. (otherwise it gets killed and we fail > the test) I think this is possibly a bad idea, since it's clear LLVM has some

Re: [Mesa-dev] [PATCH 1/2] nir: Teach src_is_type about nir_instr_type_load_const

2018-07-19 Thread Ilia Mirkin
On Thu, Jul 19, 2018 at 8:39 PM, Ian Romanick wrote: > From: Ian Romanick > > --- > After looking back at Tim's patches, I realized that I had done my > implementation slightly differntly. I didn't include these in my branch > because it caused a bunch of regressions on i965. I'm just sending

[Mesa-dev] [PATCH 2/2] ac, radeonsi: reduce optimizations for complex compute shaders on older APUs

2018-07-19 Thread Marek Olšák
From: Marek Olšák To make dEQP-GLES31.functional.ssbo.layout.random.all_shared_buffer.23 finish sooner on the older CPUs. (otherwise it gets killed and we fail the test) --- src/amd/common/ac_llvm_util.c | 18 ++-- src/amd/common/ac_llvm_util.h | 11

[Mesa-dev] [PATCH 1/2] radeonsi: handle SI_FORCE_FAMILY early

2018-07-19 Thread Marek Olšák
From: Marek Olšák before LLVM target machines are created --- src/gallium/drivers/radeonsi/si_pipe.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index d3d0c0ef075..22e333aec77 100644 ---

[Mesa-dev] [PATCH] i965/icl: Disable binding table prefetching

2018-07-19 Thread Anuj Phogat
From: Topi Pohjolainen Gen 11 workarounds table #2056 WABTPPrefetchDisable suggests to disable prefetching of binding tables for ICLLP A0 and B0 steppings. It fixes multiple gpu hangs in ext_framebuffer_multisample* tests on ICLLP B0 h/w. Anuj: Add comments and commit message. Add gen 11

Re: [Mesa-dev] [PATCH 6/6] glsl: fix function inlining with opaque parameters

2018-07-19 Thread Marek Olšák
For patches 3-6: Reviewed-by: Marek Olšák Marek On Wed, Jun 6, 2018 at 3:55 PM, Rhys Perry wrote: > Signed-off-by: Rhys Perry > --- > src/compiler/glsl/opt_function_inlining.cpp | 52 > - > 1 file changed, 44 insertions(+), 8 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 2/2] nir: Teach src_is_type about bcsel

2018-07-19 Thread Ilia Mirkin
On Thu, Jul 19, 2018 at 8:39 PM, Ian Romanick wrote: > From: Ian Romanick > > --- > src/compiler/nir/nir_search.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/src/compiler/nir/nir_search.c b/src/compiler/nir/nir_search.c > index c727e9c70b7..99b4ac6ddd2 100644 >

[Mesa-dev] [PATCH 2/2] nir: Teach src_is_type about bcsel

2018-07-19 Thread Ian Romanick
From: Ian Romanick --- src/compiler/nir/nir_search.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/compiler/nir/nir_search.c b/src/compiler/nir/nir_search.c index c727e9c70b7..99b4ac6ddd2 100644 --- a/src/compiler/nir/nir_search.c +++

[Mesa-dev] [PATCH 1/2] nir: Teach src_is_type about nir_instr_type_load_const

2018-07-19 Thread Ian Romanick
From: Ian Romanick --- After looking back at Tim's patches, I realized that I had done my implementation slightly differntly. I didn't include these in my branch because it caused a bunch of regressions on i965. I'm just sending these out in case we end up going this route...

Re: [Mesa-dev] [PATCH] radeonsi: Add debug option to enable LLVM GlobalISel (v2)

2018-07-19 Thread Tom Stellard
On 07/19/2018 08:18 PM, Marek Olšák wrote: > From: Tom Stellard > > R600_DEBUG=gisel will tell LLVM to use GlobalISel rather than > SelectionDAG for instruction selection. > > v2: mareko: move the helper to src/amd/common > Thanks for picking this up. Reviewed-by: Tom Stellard >

Re: [Mesa-dev] [PATCH 0/6] Fix Various Compilation Issues With Bindless

2018-07-19 Thread Marek Olšák
Hi, Do you plan to push this? Marek On Wed, Jun 6, 2018 at 3:55 PM, Rhys Perry wrote: > Previously, there were some errors in the compiler's implementation of > ARB_bindless_texture, mostly related to usage of bound image or sampler > handles allowed by ARB_bindless_texture, resulting in

Re: [Mesa-dev] [PATCH 0/6] Fix Various Compilation Issues With Bindless

2018-07-19 Thread Rhys Perry
I think it needs more review and for the feedback on the first and second patches to be addressed before being pushed? I'm not a member of mesa group on the Gitlab, so I can't anyway. On Thu, Jul 19, 2018 at 11:14 PM, Marek Olšák wrote: > Hi, > > Do you plan to push this? > > Marek > > On Wed,

Re: [Mesa-dev] [PATCH 1/2] intel/fs: New method for register_byte_use_pattern for fs_inst

2018-07-19 Thread Francisco Jerez
Chema Casanova writes: > El 14/07/18 a las 00:14, Francisco Jerez escribió: >> Jose Maria Casanova Crespo writes: >> >>> For a register source/destination of an instruction the function returns >>> the read/write byte pattern of a 32-byte registers as a unsigned int. >>> >>> The returned

Re: [Mesa-dev] [PATCH] i965/tex: ignore the diff between GL_TEXTURE_2D and GL_TEXTURE_RECTANGLE

2018-07-19 Thread andrey simiklit
Hi, > Ugh... not so good. According to Oliver on the bug, this just make the assert go away and doesn't actually fix anything. Likely this is needed but not sufficient. So as far as I understand Oliver found the bad commit in xorg glamor: https://bugs.freedesktop.org/show_bug.cgi?id=107287 So

[Mesa-dev] [PATCH] docs: update calendar to match the 18.2 plan with the one announced

2018-07-19 Thread Andres Gomez
Additionally, I've extended the 18.1 cycle by one more release, tentatively assigned to Dylan, due to the ~2 weeks delay for 18.2. Cc: Dylan Baker Cc: Juan A. Suarez Cc: Emil Velikov Signed-off-by: Andres Gomez --- docs/release-calendar.html | 16 +++- 1 file changed, 11

[Mesa-dev] [Bug 106893] Potential mem leak with radv

2018-07-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106893 --- Comment #4 from John --- I have just tried again and since I was within Alex' numbers in the menu, I tried the benchmark and was able to complete it with no issue for the 1st time! I'd say the game used about 4Gb of RAM during that time, so

[Mesa-dev] [Bug 106893] Potential mem leak with radv

2018-07-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106893 Bas Nieuwenhuizen changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 107290] Hang reading from GL_FRONT in fullscreen

2018-07-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107290 Bug ID: 107290 Summary: Hang reading from GL_FRONT in fullscreen Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW

[Mesa-dev] [PATCH 7/8] ac: add support for 16bit load_push_constant

2018-07-19 Thread Daniel Schürmann
Signed-off-by: Daniel Schürmann --- src/amd/common/ac_nir_to_llvm.c | 20 1 file changed, 20 insertions(+) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index babcb9de44..598e129aad 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++

[Mesa-dev] [PATCH 8/8] radv: enable VK_KHR_16bit_storage extension / 16bit storage features

2018-07-19 Thread Daniel Schürmann
Signed-off-by: Daniel Schürmann --- src/amd/vulkan/radv_device.c | 10 ++ src/amd/vulkan/radv_extensions.py | 1 + src/amd/vulkan/radv_shader.c | 1 + 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c

[Mesa-dev] [PATCH 6/8] radv: add support for 16bit input/output

2018-07-19 Thread Daniel Schürmann
Signed-off-by: Daniel Schürmann --- src/amd/common/ac_nir_to_llvm.c | 8 ++- src/amd/vulkan/radv_nir_to_llvm.c | 90 +-- 2 files changed, 80 insertions(+), 18 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index

[Mesa-dev] [PATCH 2/8] ac: add support for 16bit ssbo stores

2018-07-19 Thread Daniel Schürmann
Signed-off-by: Daniel Schürmann --- src/amd/common/ac_nir_to_llvm.c | 144 +++- 1 file changed, 84 insertions(+), 60 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index f46744e8ca..43a0b86420 100644 ---

[Mesa-dev] [PATCH 1/8] ac: add 16bit conversion operations

2018-07-19 Thread Daniel Schürmann
Signed-off-by: Daniel Schürmann --- src/amd/common/ac_llvm_build.c | 13 - src/amd/common/ac_nir_to_llvm.c | 27 +++ 2 files changed, 31 insertions(+), 9 deletions(-) diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c index

[Mesa-dev] [PATCH 3/8] ac: add support for 16bit UBO loads

2018-07-19 Thread Daniel Schürmann
Signed-off-by: Daniel Schürmann --- src/amd/common/ac_llvm_build.c | 25 + src/amd/common/ac_llvm_build.h | 8 src/amd/common/ac_nir_to_llvm.c | 21 ++--- 3 files changed, 51 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH 5/8] nir: add 16bit type information to glsl types

2018-07-19 Thread Daniel Schürmann
Signed-off-by: Daniel Schürmann --- src/compiler/glsl_types.h | 15 +++ src/compiler/nir_types.cpp | 12 src/compiler/nir_types.h | 1 + 3 files changed, 28 insertions(+) diff --git a/src/compiler/glsl_types.h b/src/compiler/glsl_types.h index efc6324865..8cc8177f2d

[Mesa-dev] [PATCH 4/8] ac: add support for 16bit buffer loads

2018-07-19 Thread Daniel Schürmann
Signed-off-by: Daniel Schürmann --- src/amd/common/ac_nir_to_llvm.c | 96 ++--- 1 file changed, 53 insertions(+), 43 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index d7a52a536c..770a025c82 100644 ---

Re: [Mesa-dev] [PATCH] libGLw: Use newly introduced GLAPIVAR for variables

2018-07-19 Thread Stefan Dirsch
On Wed, Jul 18, 2018 at 11:07:01AM -0600, Brian Paul wrote: > On 07/17/2018 06:47 PM, Stefan Dirsch wrote: > > On Tue, Jul 17, 2018 at 04:57:26PM -0600, Brian Paul wrote: > > > Reviewed-by: Brian Paul > > > > > > Do you need me to push this for you? > > > > I'm afraid the answer is yes. Tried

[Mesa-dev] [PATCH] travis: manually generate sys/syscall.h

2018-07-19 Thread Andres Gomez
Until now, the needed bits were wrongly included in linux/memfd.h Since Travis' sys/syscall.h doesn't provide the SYS_memfd_create, we generate that header manually, including the needed bits to avoid compilation problems, as the ones observed after: 3228335b55c ("intel: aubinator: handle GGTT

[Mesa-dev] VK_KHR_16bit_storage extension / 16bit storage features

2018-07-19 Thread Daniel Schürmann
This series implements and enables the VK_KHR_16bit_storage extension (respectively the VK 1.1 features) for VI+. LLVM >= 7 is required and it is unlikely that workarounds for LLVM-6 get implemented for this rarely used ext. This first implementation does not yet make use of packing 16bit values

[Mesa-dev] [PATCH] docs: correct typo in the submitting patches instructions

2018-07-19 Thread Andres Gomez
Cc: Emil Velikov Cc: Eric Engestrom Signed-off-by: Andres Gomez --- docs/submittingpatches.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/submittingpatches.html b/docs/submittingpatches.html index 178ec5f89ec..e5350bdb2cf 100644 --- a/docs/submittingpatches.html

[Mesa-dev] [PATCH] intel/tools: fix segfault with intel_dump_gpu

2018-07-19 Thread Jordan Justen
Cc: Jason Ekstrand Cc: Lionel Landwerlin Fixes: 0a457d987ee "intel/tools: Refactor aub dumping to remove singletons" Signed-off-by: Jordan Justen --- src/intel/tools/intel_dump_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/tools/intel_dump_gpu.c

Re: [Mesa-dev] [PATCH v2 4/4] intel: tools: dump: trace memory writes

2018-07-19 Thread Lionel Landwerlin
On 18/07/18 21:58, Rafael Antognolli wrote: On Wed, Jul 18, 2018 at 06:21:32PM +0100, Lionel Landwerlin wrote: Signed-off-by: Lionel Landwerlin --- src/intel/tools/aub_write.c | 45 ++--- 1 file changed, 32 insertions(+), 13 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 2/3] st: Sweep NIR after linking phase to free held memory

2018-07-19 Thread Danylo Piliaiev
On 19.07.18 12:30, Timothy Arceri wrote: On 19.07.18 11:47, Timothy Arceri wrote: On 19/07/18 08:31, Eric Anholt wrote: Danylo Piliaiev writes: After optimization passes and many trasfromations most of memory "transformations" NIR holds is a garbage which was being freed only after

[Mesa-dev] [Bug 107288] REGoth/bgfx: util_blitter_generate_mipmap: Assertion `!util_format_has_stencil(desc)' failed.

2018-07-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107288 Bug ID: 107288 Summary: REGoth/bgfx: util_blitter_generate_mipmap: Assertion `!util_format_has_stencil(desc)' failed. Product: Mesa Version: git Hardware: Other

[Mesa-dev] [PATCH] docs: move releases from Fridays to Wednesdays

2018-07-19 Thread Andres Gomez
As discussed at: https://lists.freedesktop.org/archives/mesa-dev/2018-March/188525.html Cc: Emil Velikov Cc: Juan A. Suarez Romero Cc: Dylan Baker Cc: Ian Romanick Cc: Carl Worth Cc: Mark Janes Signed-off-by: Andres Gomez --- docs/releasing.html | 4 ++-- 1 file changed, 2 insertions(+),

Re: [Mesa-dev] [PATCH 1/3] nir: allow nir search type check to see through bcsel

2018-07-19 Thread Ian Romanick
Oh man... I was also recently looking at that same compute shader, and I wrote nearly identical patches the early part of last week. The bcsel patches caused a bit of pain for i965. I came up with a different way to handle that particular problem... either way, I eventually abandoned the whole

[Mesa-dev] [PATCH v2 00/49] meson for windows

2018-07-19 Thread Liviu Prodea
Review for Meson windows support v2 1. osmesa Scons build doesn't use lib prefix on windows platform. I don't know much of cygwin though.Sent a merge request to ensure parity - https://gitlab.freedesktop.org/dbaker/mesa/merge_requests/2 2. Problem linking LLVM. a. The LLVM wrap example in the

Re: [Mesa-dev] [PATCH v2 1/4] intel: tools: dump: remove command execution feature

2018-07-19 Thread Lionel Landwerlin
Was that for the whole series, or just this patch? :) Thanks, - Lionel On 18/07/18 21:42, Jason Ekstrand wrote: Very sketchily Reviewed-by: Jason Ekstrand > On Wed, Jul 18, 2018 at 10:21 AM Lionel Landwerlin mailto:lionel.g.landwer...@intel.com>> wrote:

Re: [Mesa-dev] [PATCH 2/3] st: Sweep NIR after linking phase to free held memory

2018-07-19 Thread Danylo Piliaiev
On 19.07.18 11:47, Timothy Arceri wrote: On 19/07/18 08:31, Eric Anholt wrote: Danylo Piliaiev writes: After optimization passes and many trasfromations most of memory "transformations" NIR holds is a garbage which was being freed only after shader deletion. "is garbage" Freeing it

[Mesa-dev] [Bug 107224] Incorrect Rendering in Deus Ex: Mankind Divided in-game menu

2018-07-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107224 --- Comment #2 from network...@rkmail.ru --- (In reply to Timothy Arceri from comment #1) > Are you sure it used to work. I've tested all the way back to Mesa > 17.0-branchpoint (d1efa09d342bff) on Intels i965 driver and I still see the >

Re: [Mesa-dev] [PATCH v2 0/4] Android kms_swrast support

2018-07-19 Thread Tomasz Figa
On Thu, Jul 19, 2018 at 12:08 AM Robert Foss wrote: > > Hey Rob, > > On 2018-07-18 15:30, Rob Herring wrote: > > On Tue, Jul 17, 2018 at 4:33 AM Robert Foss > > wrote: > >> > >> This series implements kms_swrast support for the Android > >> platform. And since having to debug a null pointer

Re: [Mesa-dev] [PATCH 2/3] st: Sweep NIR after linking phase to free held memory

2018-07-19 Thread Timothy Arceri
On 19/07/18 08:31, Eric Anholt wrote: Danylo Piliaiev writes: After optimization passes and many trasfromations most of memory "transformations" NIR holds is a garbage which was being freed only after shader deletion. "is garbage" Freeing it at the end of linking will save memory

Re: [Mesa-dev] [PATCH] intel/tools: fix segfault with intel_dump_gpu

2018-07-19 Thread Lionel Landwerlin
Hey Jordan, I have patch that remove this for loop, reviewed by Jason. Landing it right now, that should fix this problem. Thanks, - Lionel On 19/07/18 09:52, Jordan Justen wrote: Cc: Jason Ekstrand Cc: Lionel Landwerlin Fixes: 0a457d987ee "intel/tools: Refactor aub dumping to remove

Re: [Mesa-dev] [PATCH 2/3] st: Sweep NIR after linking phase to free held memory

2018-07-19 Thread Timothy Arceri
On 19.07.18 11:47, Timothy Arceri wrote: On 19/07/18 08:31, Eric Anholt wrote: Danylo Piliaiev writes: After optimization passes and many trasfromations most of memory "transformations" NIR holds is a garbage which was being freed only after shader deletion. "is garbage" Freeing it

Re: [Mesa-dev] [PATCH] util/disk_cache: Fix disk_cache_get_function_timestamp with disabled cache.

2018-07-19 Thread Eric Engestrom
On Wednesday, 2018-07-18 14:01:49 +0200, Bas Nieuwenhuizen wrote: > radv always needs it, so just check the header instead. Also > do not declare the function if the variable is not set, so we > get a nice compile error instead of failing to open a device > at runtime. If that's the goal, why

Re: [Mesa-dev] [PATCH 2/2] intel/isl/gen4: Make depth/stencil buffers Y-Tiled

2018-07-19 Thread Kenneth Graunke
On Tuesday, July 17, 2018 10:45:28 AM PDT Nanley Chery wrote: > On Tue, Jul 17, 2018 at 08:19:30AM -0700, Kenneth Graunke wrote: > > Personally, I'd be inclined to simply make this > > > >*flags &= ISL_TILING_Y0_BIT; While I still think the above is simpler and perhaps safer, your patches

Re: [Mesa-dev] [PATCH 2/2] intel/isl/gen4: Make depth/stencil buffers Y-Tiled

2018-07-19 Thread Nanley Chery
On Thu, Jul 19, 2018 at 10:16:47AM -0700, Kenneth Graunke wrote: > On Tuesday, July 17, 2018 10:45:28 AM PDT Nanley Chery wrote: > > On Tue, Jul 17, 2018 at 08:19:30AM -0700, Kenneth Graunke wrote: > > > Personally, I'd be inclined to simply make this > > > > > >*flags &= ISL_TILING_Y0_BIT; >

Re: [Mesa-dev] [PATCH 1/3] egl/android: Delete set_damage_region from egl dri vtbl

2018-07-19 Thread Harish Krupo
Eric Anholt writes: > Harish Krupo writes: > >> Eric Anholt writes: >> >>> Harish Krupo writes: >>> Hi Eric, Eric Anholt writes: > Harish Krupo writes: > >> The intension of the KHR_partial_update was not to send the damage back >> to the platform but to

[Mesa-dev] [Bug 106893] Potential mem leak with radv

2018-07-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106893 John changed: What|Removed |Added Status|RESOLVED|CLOSED --- Comment #6 from John --- Of course!

Re: [Mesa-dev] [PATCH] gm107/ir: use CS2R for SV_CLOCK

2018-07-19 Thread Karol Herbst
playing a bout around with nvdisasm, there seems to be some complications with certain sched opcodes. I think we should figure out if this is simply nvdisasm crashing or if this is a real hardware thing. On Tue, Jul 17, 2018 at 9:26 PM, Rhys Perry wrote: > After some testing and looking at

Re: [Mesa-dev] [PATCH v2 4/4] intel: tools: dump: trace memory writes

2018-07-19 Thread Rafael Antognolli
On Thu, Jul 19, 2018 at 10:14:32AM +0100, Lionel Landwerlin wrote: > On 18/07/18 21:58, Rafael Antognolli wrote: > > On Wed, Jul 18, 2018 at 06:21:32PM +0100, Lionel Landwerlin wrote: > > > Signed-off-by: Lionel Landwerlin > > > --- > > > src/intel/tools/aub_write.c | 45

Re: [Mesa-dev] [PATCH v2 0/4] Android kms_swrast support

2018-07-19 Thread Robert Foss
Hey Rob, On 2018-07-19 09:26, Tomasz Figa wrote: On Thu, Jul 19, 2018 at 12:08 AM Robert Foss wrote: Hey Rob, On 2018-07-18 15:30, Rob Herring wrote: On Tue, Jul 17, 2018 at 4:33 AM Robert Foss wrote: This series implements kms_swrast support for the Android platform. And since having

[Mesa-dev] [PATCH] gles: report maximum vertex-attrib stride to guest

2018-07-19 Thread Erik Faye-Lund
Similar to e387116, we also need to report this for GLES hosts. Signed-off-by: Erik Faye-Lund --- Without this, there's no chance for GLES hosts to get GLES3.1 support. src/vrend_renderer.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/vrend_renderer.c b/src/vrend_renderer.c

[Mesa-dev] [Bug 107295] Access violation on glDrawArrays with count >= 2048

2018-07-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107295 --- Comment #1 from Roland Scheidegger --- To debug this we'd need some more information. Backtrace might be a good start but probably not sufficient. Sample code would be great, as would be an apitrace. -- You are receiving this mail

[Mesa-dev] [Bug 107283] Dispatch sanity tests broken

2018-07-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107283 Mark Janes changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [PATCH v2 2/2] intel/fs: Improve liveness range calculation for partial writes

2018-07-19 Thread Jose Maria Casanova Crespo
We use the information of the registers read/write patterns to improve variable liveness analysis avoiding extending the liveness range of a variable to the beginning of the block so it always reaches the beginning of the shader. This optimization analyses inside each block if a partial write

[Mesa-dev] [PATCH v2 1/2] intel/fs: New methods dst_write_pattern and src_read_pattern at fs_inst

2018-07-19 Thread Jose Maria Casanova Crespo
These new methods return for a instruction register source/destination the read/write byte pattern of the 32-byte GRF as an unsigned int. The returned pattern takes into account the exec_size of the instruction, the type bitsize, the register stride and a relative offset inside the register. The

[Mesa-dev] [PATCH 1/2] intel/fs: New method for register_byte_use_pattern for fs_inst

2018-07-19 Thread Chema Casanova
El 14/07/18 a las 00:14, Francisco Jerez escribió: > Jose Maria Casanova Crespo writes: > >> For a register source/destination of an instruction the function returns >> the read/write byte pattern of a 32-byte registers as a unsigned int. >> >> The returned pattern takes into account the

[Mesa-dev] [PATCH] nvc0: add missing increments to gpu_serialize_count

2018-07-19 Thread Rhys Perry
Signed-off-by: Rhys Perry --- src/gallium/drivers/nouveau/nvc0/nvc0_context.c | 4 src/gallium/drivers/nouveau/nvc0/nvc0_program.c | 2 ++ src/gallium/drivers/nouveau/nvc0/nvc0_query_hw_sm.c | 2 ++ src/gallium/drivers/nouveau/nvc0/nve4_compute.c | 2 ++ 4 files changed, 10

[Mesa-dev] [Bug 100916] Multiple definition of `glwMDrawingAreaWidgetClass'

2018-07-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100916 Stefan Dirsch changed: What|Removed |Added Resolution|--- |FIXED Status|REOPENED

[Mesa-dev] [Bug 107295] Access violation on glDrawArrays with count >= 2048

2018-07-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107295 Bug ID: 107295 Summary: Access violation on glDrawArrays with count >= 2048 Product: Mesa Version: 18.0 Hardware: x86 (IA32) OS: Windows (All) Status: NEW

Re: [Mesa-dev] [PATCH] gles: report maximum vertex-attrib stride to guest

2018-07-19 Thread Erik Faye-Lund
Sorry, send wrong. Please ignore. On 19. juli 2018 17:58, Erik Faye-Lund wrote: Similar to e387116, we also need to report this for GLES hosts. Signed-off-by: Erik Faye-Lund --- Without this, there's no chance for GLES hosts to get GLES3.1 support. src/vrend_renderer.c | 3 +++ 1 file

[Mesa-dev] [Bug 107290] Hang reading from GL_FRONT in fullscreen

2018-07-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107290 Michel Dänzer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 106404] Hang in draw function caused by interaction of glutInitWindowPosition, glutFullScreen , glDrawBuffer(GL_FRONT)

2018-07-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106404 Michel Dänzer changed: What|Removed |Added CC||jwy...@feralinteractive.com ---

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

2018-07-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77449 Bug 77449 depends on bug 98848, which changed state. Bug 98848 Summary: Master of Orion flickering / window destroy https://bugs.freedesktop.org/show_bug.cgi?id=98848 What|Removed |Added

Re: [Mesa-dev] [PATCH] gm107/ir: use CS2R for SV_CLOCK

2018-07-19 Thread Karol Herbst
so yeah, I am a bit blind today as this was already handled in the patch. Moving the SvSemantic check inside something like isCS2RSV(SvSemantic) might make it simplier for future system values to be used with cs2r, but not really required right now. In either case: Reviewed-by: Karol Herbst On

Re: [Mesa-dev] [PATCH v2 1/4] intel: tools: dump: remove command execution feature

2018-07-19 Thread Rafael Antognolli
I was thinking about the patch. I didn't look deeply into the one that removes the command execution stuff, but for the rest of the series, Acked-by: Rafael Antognolli Sorry for being ambiguous :P On Thu, Jul 19, 2018 at 10:12:57AM +0100, Lionel Landwerlin wrote: > Was that for the whole

Re: [Mesa-dev] [PATCH v2 3/4] intel: tools: aubwrite: fix invalid frees on finish

2018-07-19 Thread Jordan Justen
Reviewed-by: Jordan Justen On 2018-07-18 10:21:31, Lionel Landwerlin wrote: > Signed-off-by: Lionel Landwerlin > --- > src/intel/tools/aub_write.c | 13 + > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/src/intel/tools/aub_write.c b/src/intel/tools/aub_write.c >

Re: [Mesa-dev] [PATCH] util/disk_cache: Fix disk_cache_get_function_timestamp with disabled cache.

2018-07-19 Thread Bas Nieuwenhuizen
On Thu, Jul 19, 2018 at 6:48 PM, Eric Engestrom wrote: > On Wednesday, 2018-07-18 14:01:49 +0200, Bas Nieuwenhuizen wrote: >> radv always needs it, so just check the header instead. Also >> do not declare the function if the variable is not set, so we >> get a nice compile error instead of

Re: [Mesa-dev] [PATCH] glsl/ast: Fix loss of error_emitted value due to reassignment

2018-07-19 Thread Ian Romanick
On 07/18/2018 01:53 AM, Danylo Piliaiev wrote: > Signed-off-by: Danylo Piliaiev > --- > src/compiler/glsl/ast_to_hir.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/compiler/glsl/ast_to_hir.cpp > b/src/compiler/glsl/ast_to_hir.cpp > index dd60a2a87f..8a4cc56511

[Mesa-dev] [Bug 107276] radv: OpBitfieldUExtract returns incorrect result when count is zero

2018-07-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107276 Samuel Pitoiset changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

Re: [Mesa-dev] [PATCH 1/3] nir: allow nir search type check to see through bcsel

2018-07-19 Thread Ian Romanick
On 07/18/2018 11:17 PM, Ian Romanick wrote: > Oh man... I was also recently looking at that same compute shader, and I > wrote nearly identical patches the early part of last week. The bcsel > patches caused a bit of pain for i965. I came up with a different way > to handle that particular

Re: [Mesa-dev] [PATCH] glsl: Allow ES2 function parameters to be hidden by variable declarations.

2018-07-19 Thread Ian Romanick
On 07/18/2018 03:03 PM, Eric Anholt wrote: > Ian Romanick writes: > >> On 07/16/2018 02:46 PM, Eric Anholt wrote: >>> This fixes dEQP case: >>> >>> dEQP-GLES2.functional.shaders.scoping.valid.local_variable_hides_function_parameter_fragment >> >> Are we sure that test is correct? I'm sure I

Re: [Mesa-dev] [PATCH v2 0/4] Android kms_swrast support

2018-07-19 Thread Rob Herring
On Thu, Jul 19, 2018 at 9:52 AM Robert Foss wrote: > > Hey Rob, > > On 2018-07-19 09:26, Tomasz Figa wrote: > > On Thu, Jul 19, 2018 at 12:08 AM Robert Foss > > wrote: > >> > >> Hey Rob, > >> > >> On 2018-07-18 15:30, Rob Herring wrote: > >>> On Tue, Jul 17, 2018 at 4:33 AM Robert Foss > >>>

Re: [Mesa-dev] [PATCH 1/2] mesa: MESA_framebuffer_flip_y extension [v3]

2018-07-19 Thread Fritz Koenig
On Wed, Jul 11, 2018 at 3:54 PM Chad Versace wrote: > > +Ken, I had a question about GLboolean. I call you by name in the > comments below. > > On Fri 29 Jun 2018, Fritz Koenig wrote: > > Adds an extension to glFramebufferParameteri > > that will specify if the framebuffer is vertically > >

[Mesa-dev] [PATCH] virgl: add initial shader_storage_buffer_object support. (v2)

2018-07-19 Thread Dave Airlie
From: Dave Airlie This adds the guest side support for ARB_shader_storage_buffer_object. Co-authors: Gurchetan Singh v2: move to using separate maximums --- src/gallium/drivers/virgl/virgl_buffer.c | 2 ++ src/gallium/drivers/virgl/virgl_context.c | 44 ++