Re: [Mesa-dev] Lets talk about autotools

Hi all, I can see why people may opt to not use or maintain the autotools build. Although I would kindly ask that we do not remove it just yet. In Mesa, we have different parts not used by different teams. As such we tend to remove stuff when nobody is around to maintain it anymore. That said,

Re: [Mesa-dev] Lets talk about autotools

On Thu, Nov 29, 2018 at 9:47 AM Emil Velikov wrote: > In Mesa, we have different parts not used by different teams. As such > we tend to remove stuff when nobody is around to maintain it anymore. We drop things for that reason, but also when something is no longer needed. I don't think autotools

Re: [Mesa-dev] [PATCH] st/mesa: expose EXT_render_snorm on GLES

Reviewed-by: Ilia Mirkin On Thu, Nov 29, 2018 at 3:36 PM Marek Olšák wrote: > > From: Marek Olšák > > --- > docs/relnotes/19.0.0.html | 1 + > src/mesa/state_tracker/st_extensions.c | 8 > 2 files changed, 9 insertions(+) > > diff --git a/docs/relnotes/19.0.0.html

[Mesa-dev] [PATCH] st/mesa: expose EXT_render_snorm on GLES

From: Marek Olšák --- docs/relnotes/19.0.0.html | 1 + src/mesa/state_tracker/st_extensions.c | 8 2 files changed, 9 insertions(+) diff --git a/docs/relnotes/19.0.0.html b/docs/relnotes/19.0.0.html index f4522b654c6..04e06cdd758 100644 --- a/docs/relnotes/19.0.0.html +++

Re: [Mesa-dev] [PATCH] docs: Document optional GitLab code review process

On Wed, Nov 28, 2018 at 11:30 AM Jason Ekstrand wrote: > We have enough stubborn people on the list that MRs are going to constantly > get pulled back to the list just because someone doesn't want to use the web > interface. A couple of people in this thread have now made similar claims, but

Re: [Mesa-dev] [PATCH mesa 1/2] docs: add meson cross compilation instructions

On Thu, 29 Nov 2018 at 15:51, Eric Engestrom wrote: > > Signed-off-by: Eric Engestrom > --- > The 32-bit linux one is tested, but the other two are "I think this > should be right". There's a small nit about the 32 bit linux build. But regardless, the series is Reviewed-by: Emil Velikov If

Re: [Mesa-dev] [PATCH] docs: Document optional GitLab code review process

On Thu, Nov 29, 2018 at 11:37 AM Matt Turner wrote: > On Wed, Nov 28, 2018 at 11:30 AM Jason Ekstrand > wrote: > > We have enough stubborn people on the list that MRs are going to > constantly get pulled back to the list just because someone doesn't want to > use the web interface. > > A couple

Re: [Mesa-dev] Lets talk about autotools

On 29.11.2018 20.22, Matt Turner wrote: > On Thu, Nov 29, 2018 at 9:47 AM Emil Velikov wrote: >> In Mesa, we have different parts not used by different teams. As such >> we tend to remove stuff when nobody is around to maintain it anymore. > > We drop things for that reason, but also when

[Mesa-dev] [PATCH 1/2] nir/algebraic: Rewrite bit-size inference

Before this commit, there were two copies of the algorithm: one in C, that we would use to figure out what bit-size to give the replacement expression, and one in Python, that emulated the C one and tried to prove that the C algorithm would never fail to correctly assign bit-sizes. That seemed

[Mesa-dev] [PATCH 0/2] nir/algebraic: Rewrite bit-size handling

While nir_algebraic in general is great, the code to implement bit-size inference has always been pretty fragile. While I was trying to remember how everything worked in order to review Jason's patches touching this area, I realized that I could make the whole thing significantly simpler. This

[Mesa-dev] [PATCH 2/2] nir/algebraic: Add unit tests for bitsize validation

The non-failure path can be tested by just compiling mesa and then testing it, but the failure paths won't be hit unless you make a mistake, so it's best to test them with some unit tests. --- src/compiler/Makefile.nir.am | 4 +- src/compiler/nir/meson.build |

Re: [Mesa-dev] Lets talk about autotools

On Thu, Nov 29, 2018 at 8:26 PM Eric Anholt wrote: > > Emil Velikov writes: > > > Hi all, > > > > I can see why people may opt to not use or maintain the autotools build. > > Although I would kindly ask that we do not remove it just yet. > > > > In Mesa, we have different parts not used by

Re: [Mesa-dev] [PATCH 1/3] virgl: quadruple command buffer size

Thanks! Gentle ping for push from committers.. On Mon, Nov 26, 2018 at 11:52 AM Erik Faye-Lund wrote: > > On Mon, 2018-11-26 at 09:54 -0800, Gurchetan Singh wrote: > > Tested running WebGL aquarium on Nvidia host (10,000 fishes) > > > > This moves us from 7 fps to 9 fps. After quadrupling,

Re: [Mesa-dev] [PATCH 1/2] nir/algebraic: Rewrite bit-size inference

On Thu, Nov 29, 2018 at 12:32 PM Connor Abbott wrote: > Before this commit, there were two copies of the algorithm: one in C, > that we would use to figure out what bit-size to give the replacement > expression, and one in Python, that emulated the C one and tried to > prove that the C algorithm

Re: [Mesa-dev] [PATCH v2 1/5] mesa: Add core support for EXT_multisampled_render_to_texture2

On Tue, Nov 6, 2018 at 3:03 PM Ilia Mirkin wrote: > > On Tue, Nov 6, 2018 at 5:18 PM Kristian H. Kristensen > wrote: > > > > This also turns on EXT_multisampled_render_to_texture which is a > > subset of EXT_multisampled_render_to_texture2, allowing only > > COLOR_ATTACHMENT0. > > You also

Re: [Mesa-dev] Lets talk about autotools

Emil Velikov writes: > Hi all, > > I can see why people may opt to not use or maintain the autotools build. > Although I would kindly ask that we do not remove it just yet. > > In Mesa, we have different parts not used by different teams. As such > we tend to remove stuff when nobody is around

Re: [Mesa-dev] Lets talk about autotools

On Thu, Nov 29, 2018 at 9:19 PM Jason Ekstrand wrote: > > On November 29, 2018 19:49:33 Alex Deucher wrote: > > > On Thu, Nov 29, 2018 at 8:26 PM Eric Anholt wrote: > >> > >> Emil Velikov writes: > >> > >>> Hi all, > >>> > >>> I can see why people may opt to not use or maintain the autotools

Re: [Mesa-dev] [PATCH 1/2] nir: add a compiler option for disabling float comparison simplifications

On Thu, Nov 29, 2018, at 7:47 AM, Connor Abbott wrote: > On Thu, Nov 29, 2018 at 4:22 PM Jason Ekstrand wrote: > > > > Can you provide some context for this? Those rules are already flagged > > "inexact" (that's what the ~ means) so they won't apply to anything that's > > "precise" or

Re: [Mesa-dev] [PATCH] mesa: Revert INTEL_fragment_shader_ordering support

Matt Turner writes: > This extension is not properly tested (testing for > GL_ARB_fragment_shader_interlock is not sufficient), and since this was > noted in review on August 28th no tests have been sent. > > Revert "i965: Add INTEL_fragment_shader_ordering support." > Revert "mesa: Add GL/GLSL

Re: [Mesa-dev] Lets talk about autotools

On Thu, Nov 29, 2018 at 5:49 PM Alex Deucher wrote: > > On Thu, Nov 29, 2018 at 8:26 PM Eric Anholt wrote: > > > > Emil Velikov writes: > > > > > Hi all, > > > > > > I can see why people may opt to not use or maintain the autotools build. > > > Although I would kindly ask that we do not remove

Re: [Mesa-dev] Lets talk about autotools

On November 29, 2018 19:49:33 Alex Deucher wrote: On Thu, Nov 29, 2018 at 8:26 PM Eric Anholt wrote: Emil Velikov writes: Hi all, I can see why people may opt to not use or maintain the autotools build. Although I would kindly ask that we do not remove it just yet. In Mesa, we have

Re: [Mesa-dev] [PATCH] docs: Document optional GitLab code review process

On Tue, 2018-11-27 at 17:13 -0800, Jordan Justen wrote: > This documents a mechanism for using GitLab Merge Requests as an > optional, secondary way to get code reviews for patchsets. > > We still require all patches to be emailed. > > Aside from the potential usage for code review comments, it

[Mesa-dev] [Bug 107832] Gallium picking A16L16 formats when emulating INTENSITY16 conflicts with mesa

https://bugs.freedesktop.org/show_bug.cgi?id=107832 Tapani Pälli changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Mesa-dev] [PATCH 2/3] intel/blorp: Make KSP a blorp_address instead of an offset.

In i965, shader programs live in a single buffer, and every batch emits a STATE_BASE_ADDRESS packet pointing to that buffer. This takes care of pinning the buffer for the batch; from then on, we can use an offset. In the upcoming Iris driver, shader programs can live in multiple buffers, and

[Mesa-dev] [PATCH 3/3] intel/blorp: Add a simpler interface for softpin-only drivers.

Drivers using softpin do not need (or have) relocations. The old relocation interface is somewhat awkward and limiting. In particular, brw_surface_reloc assumes that all SURFACE_STATEs will exist in a single buffer, and only provides ss_offset. The driver is supposed to implicitly know about

[Mesa-dev] [PATCH 1/3] intel/blorp: Expand blorp_address::offset to be 64 bits.

In the softpin world, surface state base address may be a fixed 64-bit address (with no associated BO). It makes sense to store this in the offset field. But it needs to be the full size. We also update the clear color address to be consistently uint64_t everywhere so we can continue passing

Re: [Mesa-dev] [PATCH mesa 1/2] docs: add meson cross compilation instructions

Quoting Eric Engestrom (2018-11-29 07:50:58) > Signed-off-by: Eric Engestrom > --- > The 32-bit linux one is tested, but the other two are "I think this > should be right". > --- > docs/meson.html | 83 + > 1 file changed, 83 insertions(+) > >

Re: [Mesa-dev] [PATCH mesa] meson: skip asm check when asm is disabled

Quoting Eric Engestrom (2018-11-29 03:50:48) > Signed-off-by: Eric Engestrom > --- > meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meson.build b/meson.build > index 4ee40503d044a0985c89..2d300d0421980cba7866 100644 > --- a/meson.build > +++ b/meson.build >

Re: [Mesa-dev] [PATCH v2] anv: flush pipeline before query result copies

On 29/11/2018 16:58, Jason Ekstrand wrote: On Thu, Nov 29, 2018 at 10:45 AM Lionel Landwerlin mailto:lionel.g.landwer...@intel.com>> wrote: Pipeline barriers inserted through vkCmdPipelineBarrier() should be taken into account when copying results. In the particular bug below,

Re: [Mesa-dev] [PATCH] docs: Document optional GitLab code review process

Eric Engestrom writes: > On Wednesday, 2018-11-28 13:36:29 -0800, Eric Anholt wrote: >> Jordan Justen writes: >> >> > This documents a mechanism for using GitLab Merge Requests as an >> > optional, secondary way to get code reviews for patchsets. >> > >> > We still require all patches to be

[Mesa-dev] [PATCH] mesa: Revert INTEL_fragment_shader_ordering support

This extension is not properly tested (testing for GL_ARB_fragment_shader_interlock is not sufficient), and since this was noted in review on August 28th no tests have been sent. Revert "i965: Add INTEL_fragment_shader_ordering support." Revert "mesa: Add GL/GLSL plumbing for

Re: [Mesa-dev] [PATCH] mesa: Revert INTEL_fragment_shader_ordering support

Acked-by: Jason Ekstrand On Thu, Nov 29, 2018 at 5:54 PM Matt Turner wrote: > This extension is not properly tested (testing for > GL_ARB_fragment_shader_interlock is not sufficient), and since this was > noted in review on August 28th no tests have been sent. > > Revert "i965: Add

Re: [Mesa-dev] [PATCH] docs: Document and *require* usage of Signed-off-by

e<#secure method=pgpmime mode=sign> Erik Faye-Lund writes: > On Wed, 2018-11-28 at 13:43 -0800, Eric Anholt wrote: >> Jordan Justen writes: >> >> > This adds the "Developer's Certificate of Origin 1.1" from the >> > Linux >> > kernel. It indicates that by using Signed-off-by you are certifying

Re: [Mesa-dev] [PATCH 0/7] EGLDevice, take 2.1

Does this require libdrm 2.4.95 for virtio-gpu? With platform_surfaceless, I keep getting "DRI2: failed to find EGLDevice" and the failure is happening in "drmGetDevice2(fd, 0, )".On Sat, Oct 20, 2018 at 11:46 PM Mathias Fröhlich wrote: > > Hi Emil, > > On Wednesday, 3 October 2018 16:02:40 CEST

Re: [Mesa-dev] Lets talk about autotools

Quoting Timo Aaltonen (2018-11-29 10:33:30) > On 29.11.2018 20.22, Matt Turner wrote: > > On Thu, Nov 29, 2018 at 9:47 AM Emil Velikov > > wrote: > >> In Mesa, we have different parts not used by different teams. As such > >> we tend to remove stuff when nobody is around to maintain it anymore.

[Mesa-dev] [PATCH v2 03/11] nir/algebraic: Clean up some __str__ cruft

Both of these things are already handled in the Value base class so we don't need to handle them explicitly in Constant. --- src/compiler/nir/nir_algebraic.py | 4 1 file changed, 4 deletions(-) diff --git a/src/compiler/nir/nir_algebraic.py b/src/compiler/nir/nir_algebraic.py index

[Mesa-dev] [PATCH v2 07/11] nir/opt_algebraic: Drop bit-size suffixes from conversions

Suffixes are dropped from a bunch of conversion opcodes when it makes sense to do so. Others are kept if we really do want the bit-size restriction. --- src/compiler/nir/nir_opt_algebraic.py | 58 +-- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git

[Mesa-dev] [PATCH v2 04/11] nir/algebraic: Refactor codegen a bit

Instead of using an OrderedDict, just have a (necessarily sorted) array of transforms and a set of opcodes. --- src/compiler/nir/nir_algebraic.py | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/src/compiler/nir/nir_algebraic.py

[Mesa-dev] [PATCH v2 09/11] nir: Make boolean conversions sized just like the others

Instead of a single i2b and b2i, we now have i2b32 and b2iN where N is one if 8, 16, 32, or 64. This leads to having a few more opcodes but now everything is consistent and booleans aren't a weird special case anymore. --- src/compiler/nir/nir.h | 4 ++--

[Mesa-dev] [PATCH v2 01/11] nir/opcodes: Pull in the type helpers from constant_expressions

While we're at it, we rework them a bit to all use regular expressions and assert more. --- src/compiler/nir/nir_constant_expressions.py | 25 ++ src/compiler/nir/nir_opcodes.py | 34 +--- src/compiler/nir/nir_opcodes_c.py| 11 ++- 3 files

[Mesa-dev] [PATCH v2 08/11] nir/opt_algebraic: Add 32-bit specifiers to a bunch of booleans

--- src/compiler/nir/nir_opt_algebraic.py | 112 +- 1 file changed, 56 insertions(+), 56 deletions(-) diff --git a/src/compiler/nir/nir_opt_algebraic.py b/src/compiler/nir/nir_opt_algebraic.py index c482bde8b3b..aa1a7a94e6e 100644 ---

[Mesa-dev] [PATCH v2 06/11] nir/opt_algebraic: Simplify an optimization using the new search ops

--- src/compiler/nir/nir_opt_algebraic.py | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/compiler/nir/nir_opt_algebraic.py b/src/compiler/nir/nir_opt_algebraic.py index f2a7be0c403..27c90cebaee 100644 --- a/src/compiler/nir/nir_opt_algebraic.py +++

[Mesa-dev] [PATCH v2 02/11] nir/opcodes: Rename tbool to tbool32

--- src/compiler/nir/nir_opcodes.py | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/compiler/nir/nir_opcodes.py b/src/compiler/nir/nir_opcodes.py index d69d09d30ce..00720708305 100644 --- a/src/compiler/nir/nir_opcodes.py +++

[Mesa-dev] [PATCH v2 05/11] nir/algebraic: Add support for unsized conversion opcodes

All conversion opcodes require a destination size but this makes constructing certain algebraic expressions rather cumbersome. This commit adds support to nir_search and nir_algebraic for writing conversion opcodes without a size. These meta-opcodes match any conversion of that type regardless

[Mesa-dev] [PATCH v2 11/11] FIXUP: Fix NIR producers and consumers to use unsized conversions

--- src/amd/common/ac_nir_to_llvm.c | 12 src/broadcom/compiler/nir_to_vir.c| 8 src/compiler/glsl/glsl_to_nir.cpp | 2 +- src/compiler/nir/nir_builder.h| 12 src/compiler/spirv/vtn_glsl450.c | 4 ++--

[Mesa-dev] [PATCH v2 10/11] FIXUP: nir/opt_algebraic: Add suffixes to some x2b opcodes

Many of the x2b optimizations in nir_opt_algebraic can be handled by the generic untyped conversion opcodes we just added. However, there are a few that still need an explicit size for some reason. --- src/compiler/nir/nir_opt_algebraic.py | 14 +++--- 1 file changed, 7 insertions(+), 7

[Mesa-dev] [PATCH v2 00/11] nir: Rework boolean conversions

This is mostly a re-send of my earlier series to rework boolean conversions in NIR which can be found here: https://lists.freedesktop.org/archives/mesa-dev/2018-November/209089.html This version solidly chooses path B from the previous series and is rebased on top of Connor's nir_algebraic.py

Re: [Mesa-dev] [PATCH 04/11] st/mesa: Use Array._DrawVAO in st_atom_array.c.

Good Morning, On Tuesday, 27 November 2018 10:17:07 CET Erik Faye-Lund wrote: > On Tue, 2018-11-27 at 07:11 +0100, Mathias Fröhlich wrote: > > Hi Erik, > > > > > > On Monday, 26 November 2018 19:39:50 CET Erik Faye-Lund wrote: > > > > > I know this is *very* late notice, but this commit broke

Re: [Mesa-dev] [PATCH 4/4] nir: detect more induction variables

Den ons. 28. nov. 2018 kl. 10:23 skrev Timothy Arceri : > > On 28/11/18 6:52 pm, Thomas Helland wrote: > > Den ons. 28. nov. 2018 kl. 04:26 skrev Timothy Arceri > > : > >> > >> This adds allows loop analysis to detect inductions varibales that > >> are incremented in both branches of an if rather

Re: [Mesa-dev] [PATCH 2/3] mesa: expose EXT_texture_compression_bptc in GLES

On Wed, 2018-11-28 at 20:22 -0500, Marek Olšák wrote: > From: Marek Olšák > > tested by piglit. > --- > docs/relnotes/19.0.0.html| 1 + > src/mesa/main/extensions_table.h | 1 + > src/mesa/main/glformats.c| 13 +++-- > src/mesa/main/texcompress.c | 9 + >

Re: [Mesa-dev] Lets talk about autotools

On 27.11.2018 19.42, Eero Tamminen wrote: > Hi, > > On 27.11.2018 19.05, Matt Turner wrote: >> On Tue, Nov 27, 2018 at 1:13 AM Timo Aaltonen >> wrote: >>> On 17.11.2018 6.04, Dylan Baker wrote: Quoting Dylan Baker (2018-09-17 09:44:07) > I feel like for !windows meson is in good enough

[Mesa-dev] [Bug 108705] GLX with DRI2 doesn't work properly when xcb is owning the event queue

https://bugs.freedesktop.org/show_bug.cgi?id=108705 Yuxuan Shui changed: What|Removed |Added Blocks||108651 Referenced Bugs:

[Mesa-dev] [Bug 105132] glxSwapBuffers has no effect

https://bugs.freedesktop.org/show_bug.cgi?id=105132 Yuxuan Shui changed: What|Removed |Added Blocks||108651 Referenced Bugs:

[Mesa-dev] [ANNOUNCE] mesa 18.3.0-rc5

The fifth release candidate for Mesa 18.3.0 is now available. As per the issue tracker [1] we have one outstanding bug blocking the release. [1] https://bugs.freedesktop.org/show_bug.cgi?id=108530 Bas Nieuwenhuizen (3): radv: Fix opaque metadata descriptor last layer. radv: Clamp

Re: [Mesa-dev] [PATCH 1/3] mesa: expose EXT_texture_compression_rgtc on GLES

On Wed, 2018-11-28 at 20:22 -0500, Marek Olšák wrote: > From: Marek Olšák > > The spec was modified to support GLES. Tested by piglit. > --- > docs/relnotes/19.0.0.html| 1 + > src/mesa/main/extensions_table.h | 2 +- > src/mesa/main/glformats.c| 19 +-- >

Re: [Mesa-dev] [PATCH] docs: Document and *require* usage of Signed-off-by

On Wed, 2018-11-28 at 13:43 -0800, Eric Anholt wrote: > Jordan Justen writes: > > > This adds the "Developer's Certificate of Origin 1.1" from the > > Linux > > kernel. It indicates that by using Signed-off-by you are certifying > > that your patch meets the DCO 1.1 guidelines. > > > > It also

[Mesa-dev] [PATCH mesa] meson: skip asm check when asm is disabled

Signed-off-by: Eric Engestrom --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 4ee40503d044a0985c89..2d300d0421980cba7866 100644 --- a/meson.build +++ b/meson.build @@ -917,7 +917,7 @@ endif # case of cross compiling where we

[Mesa-dev] [Bug 108900] GPU hangs with GfxBench v5 Aztec Ruins Vulkan test

https://bugs.freedesktop.org/show_bug.cgi?id=108900 Bug ID: 108900 Summary: GPU hangs with GfxBench v5 Aztec Ruins Vulkan test Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity:

Re: [Mesa-dev] [PATCH] docs: Document optional GitLab code review process

On Thursday, 2018-11-29 10:11:22 +0100, Erik Faye-Lund wrote: > On Tue, 2018-11-27 at 17:13 -0800, Jordan Justen wrote: > > This documents a mechanism for using GitLab Merge Requests as an > > optional, secondary way to get code reviews for patchsets. > > > > We still require all patches to be

Re: [Mesa-dev] [PATCH] docs: Document optional GitLab code review process

On Wednesday, 2018-11-28 13:36:29 -0800, Eric Anholt wrote: > Jordan Justen writes: > > > This documents a mechanism for using GitLab Merge Requests as an > > optional, secondary way to get code reviews for patchsets. > > > > We still require all patches to be emailed. > > > > Aside from the

Re: [Mesa-dev] [PATCH] docs: Document optional GitLab code review process

On Thu, Nov 29, 2018 at 3:11 AM Erik Faye-Lund wrote: > On Tue, 2018-11-27 at 17:13 -0800, Jordan Justen wrote: > > This documents a mechanism for using GitLab Merge Requests as an > > optional, secondary way to get code reviews for patchsets. > > > > We still require all patches to be emailed.

Re: [Mesa-dev] [PATCH 1/2] nir: add a compiler option for disabling float comparison simplifications

On Thu, Nov 29, 2018 at 4:22 PM Jason Ekstrand wrote: > > Can you provide some context for this? Those rules are already flagged > "inexact" (that's what the ~ means) so they won't apply to anything that's > "precise" or "invariant". I think the concern is that this isn't allowed in SPIR-V,

Re: [Mesa-dev] [PATCH] anv: flush pipeline before query result copies

On Thu, Nov 29, 2018 at 4:43 PM Lionel Landwerlin wrote: > > Pipeline barriers inserted through vkCmdPipelineBarrier() should be > taken into account when copying results. > > In the particular bug below, the results of the > vkCmdCopyQueryPoolResults() command was being overwritten by the >

Re: [Mesa-dev] [PATCH] nir: Fix assert in print_intrinsic_instr().

On Mon, Nov 26, 2018 at 4:23 PM Lionel Landwerlin wrote: > > On 26/11/2018 15:04, Józef Kucia wrote: > > Signed-off-by: Józef Kucia > > > Reviewed-by: Lionel Landwerlin > > Please push the patch for me. I don't have commit access. ___ mesa-dev

[Mesa-dev] [PATCH 1/2] nir: add a compiler option for disabling float comparison simplifications

It's correct in GLSL because the behaviour is undefined in presence of NaNs. But this seems incorrect in Vulkan. Signed-off-by: Samuel Pitoiset --- src/compiler/nir/nir.h| 6 ++ src/compiler/nir/nir_opt_algebraic.py | 8 2 files changed, 10 insertions(+), 4

[Mesa-dev] [PATCH 2/2] radv: do not lower float comparisons because they have to be exact

This fixes two test failures in the VKD3D testsuite. (ie. in test_shader_instructions(). 26260 shaders in 13493 tests Totals: SGPRS: 1203796 -> 1203948 (0.01 %) VGPRS: 844968 -> 845052 (0.01 %) Spilled SGPRs: 21844 -> 21821 (-0.11 %) Spilled VGPRs: 122 -> 122 (0.00 %) Code Size: 44707992 ->

Re: [Mesa-dev] [PATCH 1/2] nir: add a compiler option for disabling float comparison simplifications

Can you provide some context for this? Those rules are already flagged "inexact" (that's what the ~ means) so they won't apply to anything that's "precise" or "invariant". On Thu, Nov 29, 2018 at 9:18 AM Samuel Pitoiset wrote: > It's correct in GLSL because the behaviour is undefined in >

[Mesa-dev] [PATCH] anv: flush pipeline before query result copies

Pipeline barriers inserted through vkCmdPipelineBarrier() should be taken into account when copying results. In the particular bug below, the results of the vkCmdCopyQueryPoolResults() command was being overwritten by the preceding vkCmdCopyBuffer() with a same destination buffer. This is because

[Mesa-dev] [PATCH mesa 1/2] docs: add meson cross compilation instructions

Signed-off-by: Eric Engestrom --- The 32-bit linux one is tested, but the other two are "I think this should be right". --- docs/meson.html | 83 + 1 file changed, 83 insertions(+) diff --git a/docs/meson.html b/docs/meson.html index

[Mesa-dev] [PATCH mesa 2/2] docs: format code blocks a bit nicely

Signed-off-by: Eric Engestrom --- docs/mesa.css | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/mesa.css b/docs/mesa.css index 7ab8152b040e6f469711..cfdcc94a06759befd568 100644 --- a/docs/mesa.css +++ b/docs/mesa.css @@ -29,6 +29,9 @@ pre { /*font-family: monospace;*/

Re: [Mesa-dev] [PATCH 1/2] nir: add a compiler option for disabling float comparison simplifications

On Thu, Nov 29, 2018 at 4:47 PM Connor Abbott wrote: > > On Thu, Nov 29, 2018 at 4:22 PM Jason Ekstrand wrote: > > > > Can you provide some context for this? Those rules are already flagged > > "inexact" (that's what the ~ means) so they won't apply to anything that's > > "precise" or

Re: [Mesa-dev] [PATCH] anv: flush pipeline before query result copies

On Thu, Nov 29, 2018 at 9:52 AM Józef Kucia wrote: > On Thu, Nov 29, 2018 at 4:43 PM Lionel Landwerlin > wrote: > > > > Pipeline barriers inserted through vkCmdPipelineBarrier() should be > > taken into account when copying results. > > > > In the particular bug below, the results of the > >

Re: [Mesa-dev] [PATCH 1/3] radeonsi: allow si_cp_dma_clear_buffer to clear GDS from any IB

Hi Marek, you stumbled over a pretty fundamental bug in the memory management here. Essentially we where leaking BOs when we ran into an OOM situation. Patch to fix this is on the mailing list. A second problem is that eviction doesn't seem to work when GDS BOs aren't idle. In other words

Re: [Mesa-dev] [PATCH] anv: flush pipeline before query result copies

On 29/11/2018 16:15, Jason Ekstrand wrote: On Thu, Nov 29, 2018 at 9:52 AM Józef Kucia > wrote: On Thu, Nov 29, 2018 at 4:43 PM Lionel Landwerlin mailto:lionel.g.landwer...@intel.com>> wrote: > > Pipeline barriers inserted through

Re: [Mesa-dev] [PATCH] anv: flush pipeline before query result copies

On Thu, Nov 29, 2018 at 9:43 AM Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > Pipeline barriers inserted through vkCmdPipelineBarrier() should be > taken into account when copying results. > > In the particular bug below, the results of the > vkCmdCopyQueryPoolResults() command was

Re: [Mesa-dev] [PATCH] anv: flush pipeline before query result copies

On Thu, Nov 29, 2018 at 5:25 PM Lionel Landwerlin wrote: > Pretty easy. > > Fetch http://source.winehq.org/git/vkd3d.git > > Usual autotool compilation. > > make tests/d3d12 > > I commented the tests I wasn't interested in for to make it easier and using > vktrace to understand what's going on.

[Mesa-dev] [PATCH v2] anv: flush pipeline before query result copies

Pipeline barriers inserted through vkCmdPipelineBarrier() should be taken into account when copying results. In the particular bug below, the results of the vkCmdCopyQueryPoolResults() command was being overwritten by the preceding vkCmdCopyBuffer() with a same destination buffer. This is because

Re: [Mesa-dev] [PATCH v2] anv: flush pipeline before query result copies

On Thu, Nov 29, 2018 at 10:45 AM Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > Pipeline barriers inserted through vkCmdPipelineBarrier() should be > taken into account when copying results. > > In the particular bug below, the results of the > vkCmdCopyQueryPoolResults() command was