[Mesa-dev] [Bug 108578] RADV reports wrong hardcoded Vulkan API Version

2018-12-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108578 --- Comment #5 from Shmerl --- (In reply to Samuel Pitoiset from comment #4) > This is not a bug. We should be able to bump the patch version but that > requires to look at the changelog since 1.1.70. Do you mean it's a review issue, i.e.

[Mesa-dev] [Bug 108996] Leaks buffer when closing wayland window

2018-12-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108996 Bug ID: 108996 Summary: Leaks buffer when closing wayland window Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal

[Mesa-dev] [PATCH v2 3/4] nir: rewrite varying component packing

2018-12-09 Thread Timothy Arceri
There are three reasons for the rewrite. 1. Adding support for packing tess patch varyings in a sane way. 2. Making use of qsort allowing the code to be much easier to follow. 3. Allowing us to add a crude live range analysis for deciding which components should be packed together. This

[Mesa-dev] [RFC v2 4/4] nir: add crude live range analysis to nir_compact_varyings()

2018-12-09 Thread Timothy Arceri
vkpipeline-db results RADV (VEGA): Totals from affected shaders: SGPRS: 27168 -> 27872 (2.59 %) VGPRS: 24180 -> 24056 (-0.51 %) Spilled SGPRs: 28 -> 24 (-14.29 %) Spilled VGPRs: 0 -> 0 (0.00 %) Private memory VGPRs: 0 -> 0 (0.00 %) Scratch size: 0 -> 0 (0.00 %) dwords per thread Code Size:

[Mesa-dev] [PATCH v2 1/4] nir: add support for marking used patches when packing varyings

2018-12-09 Thread Timothy Arceri
This adds support needed for marking the varyings as used but we don't actually support packing patches in this patch. --- src/compiler/nir/nir_linking_helpers.c | 73 ++ 1 file changed, 51 insertions(+), 22 deletions(-) diff --git a/src/compiler/nir/nir_linking_helpers.c

Re: [Mesa-dev] [PATCH 3/3] nir: fixed some missed varying compaction opportunities

2018-12-09 Thread Timothy Arceri
I'd much rather land the first 3 patches from this series if possible. https://patchwork.freedesktop.org/series/53800/ I've confirmed it packs the shaders you were looking at as expected once you patch 2 is applied. The series makes this code much more flexible (for future improvements) and

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

2018-12-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77449 Bug 77449 depends on bug 101978, which changed state. Bug 101978 Summary: [bisected] war thunder performance reduced by ~28% https://bugs.freedesktop.org/show_bug.cgi?id=101978 What|Removed |Added

[Mesa-dev] [PATCH v2 2/4] nir: add is_packing_supported_for_type() helper

2018-12-09 Thread Timothy Arceri
This will be used in the following patches to determine if we support packing the components of a varying. --- src/compiler/nir/nir_linking_helpers.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/src/compiler/nir/nir_linking_helpers.c

Re: [Mesa-dev] [PATCH 2/3] mesa/st/nir: fix missing nir_compact_varyings

2018-12-09 Thread Timothy Arceri
On 9/12/18 5:28 am, Rob Clark wrote: Not entirely sure when this changed, but it seem like LinkedTransformFeedback is (usually?) populated, Yeah it looks like this code was wrong when introduced. I also recall somebody complaining the performance dropped in Shadow of Mordor with Eric's fix,

Re: [Mesa-dev] [RFC v2 4/4] nir: add crude live range analysis to nir_compact_varyings()

2018-12-09 Thread Timothy Arceri
Using robs packing fix for the st I'm actually getting results for radeonsi now but they are pretty mixed for this patch: Totals from affected shaders: SGPRS: 35992 -> 35520 (-1.31 %) VGPRS: 20688 -> 20808 (0.58 %) Spilled SGPRs: 1926 -> 1996 (3.63 %) Spilled VGPRs: 0 -> 0 (0.00 %) Private

[Mesa-dev] [PATCH] travis: radeonsi and radv require LLVM 7.0

2018-12-09 Thread Rhys Kidd
Fixes: 3fbdcd942fe ("amd: remove support for LLVM 6.0") Cc: Samuel Pitoiset Cc: Marek Olšák Cc: Emil Velikov Cc: Jan Vesely Cc: Andres Gomez Cc: Dylan Baker Signed-off-by: Rhys Kidd --- .travis.yml | 29 - 1 file changed, 16 insertions(+), 13 deletions(-) diff

Re: [Mesa-dev] [PATCH v2 3/4] nir: rewrite varying component packing

2018-12-09 Thread Timothy Arceri
Sorry please ignore this for now. I've realised there is a bug here where we could end up packing components in only one of the shaders but not the other. For example if we have an array on one side but just a bunch of individual varyings on the other (which is legal I believe). I'll send a

[Mesa-dev] [Bug 100960] Special block from Minecraft mod rendered out of place

2018-12-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100960 --- Comment #20 from Tapani Pälli --- (In reply to Fabian Maurer from comment #19) > Hey there, sorry for the late answer. > > The mod has fixed the issue in its latest version, so for me this issue > isn't relevant anymore. Do we still want a

Re: [Mesa-dev] [PATCH 04/11] st/mesa: Use Array._DrawVAO in st_atom_array.c.

2018-12-09 Thread Mathias Fröhlich
Good Morning, On Tuesday, 4 December 2018 13:33:29 CET Gert Wollny wrote: > Am Dienstag, den 04.12.2018, 10:35 +0100 schrieb Erik Faye-Lund: > > > > But looking through both virgl and virglrenderer, I can't spot > > anything obviously wrong with the way inputs are being set up... > > > > > May

Re: [Mesa-dev] [PATCH 04/11] st/mesa: Use Array._DrawVAO in st_atom_array.c.

2018-12-09 Thread Mathias Fröhlich
Good Morning, Again sorry, but since I only work here in the spare time, I did not find enough to respond earlier. On Tuesday, 4 December 2018 10:35:58 CET Erik Faye-Lund wrote: > > Sounds to me like that, or even worse something with the > > supertuxkart. > > I have not yet understood what they

Re: [Mesa-dev] [PATCH 02/20] nir: clarify some nit_loop_info member names

2018-12-09 Thread Nils Wallménius
Den lör 8 dec. 2018 00:10 skrev Jason Ekstrand : > Replacing min with max without changing any real code always looks a biit > weird but it does make sense. :-) > > Reviewed-by: Jason Ekstrand > > On Thu, Dec 6, 2018 at 9:08 PM Timothy Arceri > wrote: > >> Following commits will introduce

[Mesa-dev] [Bug 108933] Unreal Tournament (UT99) segfault on opengl init

2018-12-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108933 --- Comment #13 from network...@rkmail.ru --- (In reply to Gustaw Smolarczyk from comment #12) > On a slightly unrelated topic, UT99 seems to work fine (at least for me) > while run on wine (or Steam's proton). You might want to try this path as