Re: [Mesa-dev] [PATCH 1/3] st/mesa: Make an enum for pipeline statistics query result indices.

2018-12-15 Thread Kenneth Graunke
On Saturday, December 15, 2018 9:10:46 AM PST Ilia Mirkin wrote: > On Sat, Dec 15, 2018 at 4:45 AM Kenneth Graunke wrote: > > Gallium handles pipeline statistics queries as a single query > > (PIPE_QUERY_PIPELINE_STATISTICS) which returns a struct with 11 values. > > Sometimes it's useful to

Re: [Mesa-dev] [PATCH 1/1] clover: Fix build after clang r348827

2018-12-15 Thread Aaron Watry
Thanks Jan. Reviewed-by: Aaron Watry On Thu, Dec 13, 2018 at 3:17 PM Jan Vesely wrote: > > CodeGenOptions were moved to Basic. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109039 > Signed-off-by: Jan Vesely > --- > src/gallium/state_trackers/clover/llvm/compat.hpp | 7 ++- >

[Mesa-dev] [PATCH] glsl: fix block member alignment validation for vec3

2018-12-15 Thread Niklas Haas
From: Niklas Haas Section 7.6.2.2 (Standard Uniform Block Layout) of the GL spec says: The base offset of the first member of a structure is taken from the aligned offset of the structure itself. The base offset of all other structure members is derived by taking the offset of the

[Mesa-dev] [PATCH] radv: Fix a stupid if in gather_intrinsic_info

2018-12-15 Thread Jason Ekstrand
--- src/amd/vulkan/radv_shader_info.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/amd/vulkan/radv_shader_info.c b/src/amd/vulkan/radv_shader_info.c index f7888ec6a6a..c2e005e63dd 100644 --- a/src/amd/vulkan/radv_shader_info.c +++

Re: [Mesa-dev] [PATCH] radv: don't set surf_index for stencil-only images

2018-12-15 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Fri, Dec 14, 2018 at 7:32 PM Rhys Perry wrote: > > Fixes: f8d5b377c8b ('radv: set cb base tile swizzles for MRT speedups (v4)') > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108116 > Signed-off-by: Rhys Perry > --- > Unfortunately I was not able to

[Mesa-dev] [Bug 108946] High memory usage in Black Mesa

2018-12-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108946 --- Comment #10 from MGG --- Created attachment 142819 --> https://bugs.freedesktop.org/attachment.cgi?id=142819=edit apitrace without crash Sorry for the delay in my answer. I'm attaching a new apitrace that shows a run where the game is

Re: [Mesa-dev] [PATCH 1/3] st/mesa: Make an enum for pipeline statistics query result indices.

2018-12-15 Thread Ilia Mirkin
On Sat, Dec 15, 2018 at 4:12 PM Kenneth Graunke wrote: > > On Saturday, December 15, 2018 9:10:46 AM PST Ilia Mirkin wrote: > > On Sat, Dec 15, 2018 at 4:45 AM Kenneth Graunke > > wrote: > > > Gallium handles pipeline statistics queries as a single query > > > (PIPE_QUERY_PIPELINE_STATISTICS)

Re: [Mesa-dev] last call for autotools

2018-12-15 Thread Matt Turner
On Fri, Dec 14, 2018 at 11:40 AM Ilia Mirkin wrote: > > On Fri, Dec 14, 2018 at 11:32 AM Matt Turner wrote: > > > > On Fri, Dec 14, 2018 at 4:12 AM Gert Wollny wrote: > > > I second that, I voiced my concerns in a former thread, especially that > > > so far this upcoming change has not been

Re: [Mesa-dev] [PATCH 1/3] st/mesa: Make an enum for pipeline statistics query result indices.

2018-12-15 Thread Roland Scheidegger
Am 15.12.18 um 22:39 schrieb Ilia Mirkin: > On Sat, Dec 15, 2018 at 4:12 PM Kenneth Graunke wrote: >> >> On Saturday, December 15, 2018 9:10:46 AM PST Ilia Mirkin wrote: >>> On Sat, Dec 15, 2018 at 4:45 AM Kenneth Graunke >>> wrote: Gallium handles pipeline statistics queries as a single

[Mesa-dev] [Bug 109064] temp_comp_access::get_required_live_range: enclosing_scope_first_write is NULL

2018-12-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109064 Alex Xu (Hello71) changed: What|Removed |Added OS|All |Linux (All)

Re: [Mesa-dev] [PATCH] clover: Fix include of CodeGenOptions.h, upstream moved it in r348827

2018-12-15 Thread Kai Wasserbäch
Hey, I'm just noticing, that there's also a bug report for this, so please add Bugzilla: https://bugs.freedesktop.org/109039 before commiting this, in case you accept it (I don't have commit access). Cheers, Kai Kai Wasserbäch wrote on 14.12.18 17:26: > Signed-off-by: Kai Wasserbäch > --- >

[Mesa-dev] [PATCH 3/3] st/mesa: Support an array for pipeline statistics query results.

2018-12-15 Thread Kenneth Graunke
We can now simply index into an array of uint64_t values to read or write the result, based on the query's index. The structure is still available and is interchangeable. Cc: Roland Scheidegger --- src/gallium/include/pipe/p_defines.h| 3 ++ src/mesa/state_tracker/st_cb_queryobj.c | 55

[Mesa-dev] [PATCH 1/3] st/mesa: Make an enum for pipeline statistics query result indices.

2018-12-15 Thread Kenneth Graunke
Gallium handles pipeline statistics queries as a single query (PIPE_QUERY_PIPELINE_STATISTICS) which returns a struct with 11 values. Sometimes it's useful to refer to each of those values individually, rather than as a group. To avoid hardcoding numbers, we define a new enum for each value.

[Mesa-dev] [PATCH 2/3] st/mesa: Pass index to pipe->create_query() for statistics queries.

2018-12-15 Thread Kenneth Graunke
GL exposes separate queries for each pipeline statistics counter, each of which return a single value. Gallium (and D3D) treats them as a single query, PIPE_QUERY_PIPELINE_STATISTICS, which returns 11 values. Radeon hardware appears to query them all as a group, and the CPU-side hook,

Re: [Mesa-dev] [PATCH] EGL/mesa: Initial write up fot MESA_query_driver

2018-12-15 Thread Veluri Mithun
Hi Everyone, we can obtain DRM device file from eglQueryDeviceStringEXT fun of EGL_EXT_device_query extension. But, how to retrieve name, configs from that? Can we get the name of the matched driver for a particular display from any of the EGLDriver->API ?? (EGL API dispatch table) And looking

[Mesa-dev] [PATCH] EGL/mesa: Initial write up fot MESA_query_driver

2018-12-15 Thread Veluri Mithun
Signed-off-by: Veluri Mithun --- docs/specs/EGL_MESA_query_driver.txt | 54 1 file changed, 54 insertions(+) create mode 100644 docs/specs/EGL_MESA_query_driver.txt diff --git a/docs/specs/EGL_MESA_query_driver.txt b/docs/specs/EGL_MESA_query_driver.txt new file

[Mesa-dev] [Bug 109039] [CLOVER][CLANG-SVN] build failure CodeGenOptions.h: No such file or directory

2018-12-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109039 --- Comment #3 from Kai --- I stumbled across this issue as well and didn't check the bug tracker but immediately prepared [0]. That patch should fix this problem without leaving older LLVM versions out in the cold. [0]

Re: [Mesa-dev] [PATCH 1/3] st/mesa: Make an enum for pipeline statistics query result indices.

2018-12-15 Thread Ilia Mirkin
On Sat, Dec 15, 2018 at 4:45 AM Kenneth Graunke wrote: > Gallium handles pipeline statistics queries as a single query > (PIPE_QUERY_PIPELINE_STATISTICS) which returns a struct with 11 values. > Sometimes it's useful to refer to each of those values individually, > rather than as a group. To

Re: [Mesa-dev] [PATCH] meson: make it possible to build etnaviv's cmdline compiler

2018-12-15 Thread Christian Gmeiner
Hi Dylan Am Fr., 14. Dez. 2018 um 20:13 Uhr schrieb Dylan Baker : > > Quoting Christian Gmeiner (2018-12-13 12:07:23) > > Signed-off-by: Christian Gmeiner > > --- > > meson.build | 2 +- > > meson_options.txt | 2 +- > >

Re: [Mesa-dev] [PATCH 2/3] nv50/ir: optimize slct(b, c, set(a, 0)) to slct(b, c, a)

2018-12-15 Thread Ilia Mirkin
On Fri, Dec 14, 2018 at 6:12 PM Karol Herbst wrote: > > From: Karol Herbst > > helps mainly feral ported games > > shader-db changes: > total instructions in shared programs : 7614782 -> 7565661 (-0.65%) > total gprs used in shared programs: 798045 -> 797213 (-0.10%) > total shared

Re: [Mesa-dev] [PATCH 3/3] nv50/ir: convert slct with boolean result to set

2018-12-15 Thread Ilia Mirkin
On Fri, Dec 14, 2018 at 6:12 PM Karol Herbst wrote: > > From: Karol Herbst > > helps mainly feral ported games > > changes in shader-db: > total instructions in shared programs : 7565661 -> 7545812 (-0.26%) > total gprs used in shared programs: 797213 -> 797088 (-0.02%) > total