Re: [Mesa-dev] [PATCH] st/mesa: don't leak pipe_surface if pipe_context is not current

On Wed, Jan 9, 2019 at 11:58 AM Roland Scheidegger wrote: > Am 08.01.19 um 21:03 schrieb Marek Olšák: > > On Tue, Jan 8, 2019 at 12:54 PM Roland Scheidegger > > wrote: > > > > Am 08.01.19 um 17:17 schrieb Marek Olšák: > > > From: Marek Olšák

Re: [Mesa-dev] [PATCH] llvmpipe: Always return some fence in flush (v2)

Hi Roland, On Thu, Jan 10, 2019 at 1:36 AM Roland Scheidegger wrote: > > Sorry but I had to revert this, as we've seen lots of assertion failures > (src/gallium/drivers/llvmpipe/lp_fence.c:120: lp_fence_wait: Assertion > `f->issued' failed.). For instance with libgl_xlib state tracker and

Re: [Mesa-dev] [PATCH 05/12] nir: rename global/local to private/function memory

On 1/8/19 9:57 PM, Kenneth Graunke wrote: > On Tuesday, December 4, 2018 10:26:43 AM PST Karol Herbst wrote: >> the naming is a bit confusing no matter how you look at it. Within SPIR-V >> "global" memory is memory accessible from all threads. glsl "global" memory >> normally refers to shader

[Mesa-dev] [MR] anv/pipeline: Constant fold after apply_pipeline_layout

Thanks to the new NIR load_descriptor intrinsic added by the UBO/SSBO lowering series, we weren't getting UBO pushing because the UBO range detection pass couldn't see the constants it needed. This fixes that problem with a quick round of constant folding. Because we're folding we no longer need

[Mesa-dev] [PATCH] ac/nir_to_llvm: fix interpolateAt* for arrays

This builds on the recent interpolate fix by Rhys ee8488ea3b99. This doesn't handle arrays of structs but I've got a feeling those might be broken even for radeonsi tgsi (we currently have no tests). This fixes the arb_gpu_shader5 interpolateAt* tests that contain arrays. Fixes: ee8488ea3b99

Re: [Mesa-dev] [PATCH 05/12] nir: rename global/local to private/function memory

On Wed, Jan 9, 2019 at 6:57 AM Kenneth Graunke wrote: > > On Tuesday, December 4, 2018 10:26:43 AM PST Karol Herbst wrote: > > the naming is a bit confusing no matter how you look at it. Within SPIR-V > > "global" memory is memory accessible from all threads. glsl "global" memory > > normally

[Mesa-dev] [Bug 109242] [RADV] The Witcher 3 system freeze

https://bugs.freedesktop.org/show_bug.cgi?id=109242 --- Comment #12 from Samuel Pitoiset --- I tried multiple times, no hangs so far. What graphics settings are you using? I tested on my RX480 with LLVM 7.0.1 and Mesa 18.3.1. -- You are receiving this mail because: You are the assignee for

Re: [Mesa-dev] [PATCH 05/12] nir: rename global/local to private/function memory

On Tue, Jan 8, 2019 at 11:57 PM Kenneth Graunke wrote: > On Tuesday, December 4, 2018 10:26:43 AM PST Karol Herbst wrote: > > the naming is a bit confusing no matter how you look at it. Within SPIR-V > > "global" memory is memory accessible from all threads. glsl "global" > memory > > normally

Re: [Mesa-dev] [PATCH v3 3/3] radv: add support for VK_EXT_memory_budget

Reviewed-by: Alex Smith for the series. On Wed, 9 Jan 2019 at 13:37, Samuel Pitoiset wrote: > A simple Vulkan extension that allows apps to query size and > usage of all exposed memory heaps. > > The different usage values are not really accurate because > they are per drm-fd, but they should

[Mesa-dev] [Bug 109242] [RADV] The Witcher 3 system freeze

https://bugs.freedesktop.org/show_bug.cgi?id=109242 --- Comment #20 from Samuel Pitoiset --- Created attachment 143035 --> https://bugs.freedesktop.org/attachment.cgi?id=143035=edit VGT param hack Can you try the attached patch? I really doubt it will fix the problem but it's worth trying.

Re: [Mesa-dev] [PATCH] ac/nir, radv, radeonsi/nir: use correct indices for interpolation intrinsics

On 1/9/19 3:22 PM, Rhys Perry wrote: Fixes artifacts in World of Warcraft when Multi-sample Alpha-Test is enabled. It also fixes various piglit interpolateAt*() tests with NIR. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106595 Signed-off-by: Rhys Perry ---

[Mesa-dev] [PATCH] ac/nir, radv, radeonsi/nir: use correct indices for interpolation intrinsics

Fixes artifacts in World of Warcraft when Multi-sample Alpha-Test is enabled. It also fixes various piglit interpolateAt*() tests with NIR. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106595 Signed-off-by: Rhys Perry --- src/amd/common/ac_nir_to_llvm.c | 2 +-

[Mesa-dev] [PATCH] radv: use dithered alpha-to-coverage

This matches the behaviour of AMDVLK and hides banding TODO: run tests --- src/amd/vulkan/radv_pipeline.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 3561d17aaba..26ee59f11dd 100644 ---

Re: [Mesa-dev] [PATCH 1/3] radv: remove unnecessary return in GetPhysicalDeviceMemoryProperties2()

Hello, Looks like the same fix could be done in the following functions: radv_GetPhysicalDeviceQueueFamilyProperties radv_GetPhysicalDeviceQueueFamilyProperties2 just for case if you want to fix all these issues:) Regards, Andrii. On Mon, Jan 7, 2019 at 6:35 PM Samuel Pitoiset wrote: > This

[Mesa-dev] [Bug 109242] [RADV] The Witcher 3 system freeze

https://bugs.freedesktop.org/show_bug.cgi?id=109242 --- Comment #18 from Samuel Pitoiset --- In your first comment you said "There is no such problem with AMDVLK."... So, it also hangs with AMDVLK but recovery happens while with RADV the whole machine freezes and you need a hard reboot? -- You

[Mesa-dev] [Bug 109259] Mesa compiled with LLVM/clang-7.0 segfaults

https://bugs.freedesktop.org/show_bug.cgi?id=109259 Bug ID: 109259 Summary: Mesa compiled with LLVM/clang-7.0 segfaults Product: Mesa Version: 18.3 Hardware: Other OS: All Status: NEW Severity: normal

[Mesa-dev] [Bug 109259] Mesa compiled with LLVM/clang-7.0 segfaults

https://bugs.freedesktop.org/show_bug.cgi?id=109259 --- Comment #1 from Tomasz Paweł Gajc --- Build logs for mesa compiled with LLVM/clang-7.0.1 can be found here https://abf.openmandriva.org/build_lists/351189 -- You are receiving this mail because: You are the assignee for the bug. You are

[Mesa-dev] [PATCH v2 1/3] radv: remove unnecessary returns in GetPhysicalDevice*Properties()

These functions return nothing. v2: - do it for GetPhysicalDeviceQueueFamilyProperties too Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_device.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c

[Mesa-dev] [Bug 109242] [RADV] The Witcher 3 system freeze

https://bugs.freedesktop.org/show_bug.cgi?id=109242 --- Comment #19 from Dmitry --- C AMDVLK hangs only the game client, and with RADV the whole system. But it is possible and the system hangs for seconds, have not checked Alt + Tab. -- You are receiving this mail because: You are the QA

[Mesa-dev] [Bug 109242] [RADV] The Witcher 3 system freeze

https://bugs.freedesktop.org/show_bug.cgi?id=109242 --- Comment #16 from Samuel Pitoiset --- Is the GPU hang 100% reproducible for you guys? Maybe, it only affects Polaris11 and Polaris12. (I only have Polaris10) -- You are receiving this mail because: You are the assignee for the bug. You are

[Mesa-dev] [Bug 109258] Weston drm-backend.so seems to fail with Mesa master and LIBGL_ALWAYS_SOFTWARE=1

https://bugs.freedesktop.org/show_bug.cgi?id=109258 Bug ID: 109258 Summary: Weston drm-backend.so seems to fail with Mesa master and LIBGL_ALWAYS_SOFTWARE=1 Product: Mesa Version: unspecified Hardware: Other

[Mesa-dev] [Bug 108878] OpenGL CTS KHR-GL31.transform_feedback.api_errors_test failed

https://bugs.freedesktop.org/show_bug.cgi?id=108878 --- Comment #5 from Ilia Mirkin --- (In reply to Hai from comment #4) > Since ARB_geometry_shader4 is from OpenGL 3.2, this issue is a test case bug > rather than mesa bug. Will close it. Note that ARB_geometry_shader4 is actually a separate

[Mesa-dev] [Bug 109242] [RADV] The Witcher 3 system freeze

https://bugs.freedesktop.org/show_bug.cgi?id=109242 --- Comment #17 from Dmitry --- Yes, always. On AMDVLK hangs too, but then returns to normal operation. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [Bug 109259] Mesa compiled with LLVM/clang-7.0 segfaults

https://bugs.freedesktop.org/show_bug.cgi?id=109259 --- Comment #2 from Tomasz Paweł Gajc --- When building mesa with clang these flags are used -pthread -mavx2 -mfma -mbmi2 -mf16c -DKNOB_ARCH=KNOB_ARCH_AVX2 with gcc [-pthread -mavx -DKNOB_ARCH=KNOB_ARCH_AVX -- You are receiving this mail

[Mesa-dev] [PATCH v3 3/3] radv: add support for VK_EXT_memory_budget

A simple Vulkan extension that allows apps to query size and usage of all exposed memory heaps. The different usage values are not really accurate because they are per drm-fd, but they should be close enough. v3: - use atomic operations in the winsys v2: - add software counters for the different

Re: [Mesa-dev] [PATCH v2] radv: skip draws with instance_count == 0

Reviewed-by: Bas Nieuwenhuizen On Wed, Jan 9, 2019 at 10:03 AM Samuel Pitoiset wrote: > > Loosely based on RadeonSI. > > v2: - do not check for indexed draws > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 13 + > 1 file changed, 13 insertions(+) > >

[Mesa-dev] [Bug 109242] [RADV] The Witcher 3 system freeze

https://bugs.freedesktop.org/show_bug.cgi?id=109242 --- Comment #10 from Samuel Pitoiset --- Just installed your savegame, when do you have a GPU hang? When fighting with that creature? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [Bug 109242] [RADV] The Witcher 3 system freeze

https://bugs.freedesktop.org/show_bug.cgi?id=109242 --- Comment #13 from Dmitry --- Medium preset, 1080p, HairWorks off -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev mailing

[Mesa-dev] [Bug 109242] [RADV] The Witcher 3 system freeze

https://bugs.freedesktop.org/show_bug.cgi?id=109242 --- Comment #15 from Dmitry --- Created attachment 143033 --> https://bugs.freedesktop.org/attachment.cgi?id=143033=edit r600_debug_info -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for

[Mesa-dev] [PATCH 1/5] ac/nir_to_llvm: fix type handling in image code

The current code only strips off arrays and cannot find the type for images that are struct members. Instead of trying to get the image type from the variable, we just get it directly from the deref instruction. --- src/amd/common/ac_nir_to_llvm.c | 27 --- 1 file

[Mesa-dev] [PATCH 3/5] ac/nir_to_llvm: fix regression in bindless support

This wasn't ported over when deref support was implemented. --- src/amd/common/ac_nir_to_llvm.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 633cc0aa06..4f7b2e4dc2 100644 ---

[Mesa-dev] [PATCH 5/5] radeonsi/nir: add missing pieces for bindless image/sampler support

--- src/gallium/drivers/radeonsi/si_shader_nir.c | 33 +++- 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c b/src/gallium/drivers/radeonsi/si_shader_nir.c index 2c95c62d99..256ef28bb1 100644 ---

[Mesa-dev] [Bug 109201] Deep Rock Galactic: GPU Hang (Steam Play) (DXVK)

https://bugs.freedesktop.org/show_bug.cgi?id=109201 --- Comment #7 from Samuel Pitoiset --- I have the game but I don't know to reproduce, can you give more explanations please? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [Bug 109242] [RADV] The Witcher 3 system freeze

https://bugs.freedesktop.org/show_bug.cgi?id=109242 --- Comment #11 from Roman Elshin --- Yes, usually hangs happens after just the first strike to it. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [PATCH 2/5] radeonsi/nir: get correct type for images inside structs

--- src/gallium/drivers/radeonsi/si_shader_nir.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c b/src/gallium/drivers/radeonsi/si_shader_nir.c index 64acf41679..2c95c62d99 100644 ---

[Mesa-dev] [PATCH 4/5] ac/nir_to_llvm: add support for structs to get_sampler_desc()

--- src/amd/common/ac_nir_to_llvm.c | 45 +++-- 1 file changed, 26 insertions(+), 19 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 4f7b2e4dc2..99eb6fb573 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++

[Mesa-dev] Partial bindless support for radeonsi NIR

We still need core NIR support for various features such as image/sampler in/outs etc. But this gets us a step closer. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH v2] radv: skip draws with instance_count == 0

Loosely based on RadeonSI. v2: - do not check for indexed draws Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 13 + 1 file changed, 13 insertions(+) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index

[Mesa-dev] [Bug 109242] [RADV] The Witcher 3 system freeze

https://bugs.freedesktop.org/show_bug.cgi?id=109242 --- Comment #14 from Samuel Pitoiset --- Can you attach the output of "R600_DEBUG=info glxgears" ? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [Bug 109242] [RADV] The Witcher 3 system freeze

https://bugs.freedesktop.org/show_bug.cgi?id=109242 --- Comment #22 from Dmitry --- I don't know how to use it. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev mailing list

[Mesa-dev] [Bug 109201] Deep Rock Galactic: GPU Hang (Steam Play) (DXVK)

https://bugs.freedesktop.org/show_bug.cgi?id=109201 --- Comment #11 from Alexander --- Created attachment 143041 --> https://bugs.freedesktop.org/attachment.cgi?id=143041=edit Comment 10 -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

[Mesa-dev] [Bug 109242] [RADV] The Witcher 3 system freeze

https://bugs.freedesktop.org/show_bug.cgi?id=109242 --- Comment #21 from Roman Elshin --- It looks like it fixes problem, thanks! -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___

[Mesa-dev] [Bug 109242] [RADV] The Witcher 3 system freeze

https://bugs.freedesktop.org/show_bug.cgi?id=109242 --- Comment #23 from Samuel Pitoiset --- (In reply to Dmitry from comment #22) > I don't know how to use it. You need to build mesa from git [1] https://www.mesa3d.org/install.html That said, it's actually unexpected that this hack fixes the

[Mesa-dev] [Bug 109201] Deep Rock Galactic: GPU Hang (Steam Play) (DXVK)

https://bugs.freedesktop.org/show_bug.cgi?id=109201 --- Comment #8 from Alexander --- (In reply to Alexander from comment #6) > Note 2: Does not happen if i set the texture quality to low. This is invalid -- You are receiving this mail because: You are the assignee for the bug. You are the QA

[Mesa-dev] [Bug 109201] Deep Rock Galactic: GPU Hang (Steam Play) (DXVK)

https://bugs.freedesktop.org/show_bug.cgi?id=109201 --- Comment #10 from Samuel Pitoiset --- Can you attach the output of "R600_DEBUG=info glxgears" please? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

Re: [Mesa-dev] [PATCH] llvmpipe: Always return some fence in flush (v2)

Sorry but I had to revert this, as we've seen lots of assertion failures (src/gallium/drivers/llvmpipe/lp_fence.c:120: lp_fence_wait: Assertion `f->issued' failed.). For instance with libgl_xlib state tracker and piglit. I'm not entirely sure if it's really safe to just remove the assert or if it

Re: [Mesa-dev] [PATCH] st/mesa: don't leak pipe_surface if pipe_context is not current

Am 08.01.19 um 21:03 schrieb Marek Olšák: > On Tue, Jan 8, 2019 at 12:54 PM Roland Scheidegger > wrote: > > Am 08.01.19 um 17:17 schrieb Marek Olšák: > > From: Marek Olšák mailto:marek.ol...@amd.com>> > > > > We have found some pipe_surface leaks

Re: [Mesa-dev] [PATCH] radv: use dithered alpha-to-coverage

Seems I sent the wrong commit message. It was meant to be: This matches the behaviour of AMDVLK and hides banding. It is also seems to be allowed by the Vulkan spec. Signed-off-by: Rhys Perry On Wed, 9 Jan 2019 at 14:40, Rhys Perry wrote: > > This matches the behaviour of AMDVLK

[Mesa-dev] [Bug 109201] Deep Rock Galactic: GPU Hang (Steam Play) (DXVK)

https://bugs.freedesktop.org/show_bug.cgi?id=109201 --- Comment #9 from Alexander --- (In reply to Samuel Pitoiset from comment #7) > I have the game but I don't know to reproduce, can you give more > explanations please? First you accept a mission with the crosshair symbol . Then you free a

[Mesa-dev] [Bug 109242] [RADV] The Witcher 3 system freeze

https://bugs.freedesktop.org/show_bug.cgi?id=109242 --- Comment #24 from Dmitry --- Mesa-git I can take from AUR. But I still don't understand how to use hook. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

[Mesa-dev] [Bug 109242] [RADV] The Witcher 3 system freeze

https://bugs.freedesktop.org/show_bug.cgi?id=109242 --- Comment #25 from Roman Elshin --- But it definitely works here (just tested several other places with fights - no hangs any more), are there any side effects expected? I think must be a way to add applying this patch in PKGBUILD (I am not

Re: [Mesa-dev] [PATCH v10 12/20] configure.ac, meson: Check for SPIRV-Tools and llvm-spirv

On 2019-01-08 — 15:18, Dylan Baker wrote: [snip] > >dep_clc = dependency('libclc') > > + dep_spirv_tools = dependency('SPIRV-Tools', required : false, version : > > '>= 2018.0') > > + # LLVMSPIRVLib is available at > > https://github.com/KhronosGroup/SPIRV-LLVM-Translator > > +

[Mesa-dev] [Bug 109259] Mesa compiled with LLVM/clang-7.0 segfaults

https://bugs.freedesktop.org/show_bug.cgi?id=109259 --- Comment #3 from Dylan Baker --- I'm confused, you're targeting generic x86_64, but compiling with -mavx and -mavx2? Additionally, there's a bug with SWR (I can't find it right now), due to global constructors that mean that if you build

Re: [Mesa-dev] [PATCH v10 12/20] configure.ac, meson: Check for SPIRV-Tools and llvm-spirv

Quoting Pierre Moreau (2019-01-09 11:24:12) > > thanks! Just FYI, our meson build uses - in option names, not _. And, I'd > > prefer > > just "opencl-spirv". > > Err right, I meant with '-' in the option name. I am fine with > "opencl-spirv"; > I was initially going with "gallium-opencl-spirv"

Re: [Mesa-dev] [PATCH v10 12/20] configure.ac, meson: Check for SPIRV-Tools and llvm-spirv

Quoting Pierre Moreau (2019-01-09 10:54:52) > On 2019-01-08 — 15:18, Dylan Baker wrote: > [snip] > > >dep_clc = dependency('libclc') > > > + dep_spirv_tools = dependency('SPIRV-Tools', required : false, version > > > : '>= 2018.0') > > > + # LLVMSPIRVLib is available at > > >

Re: [Mesa-dev] [PATCH v10 12/20] configure.ac, meson: Check for SPIRV-Tools and llvm-spirv

> thanks! Just FYI, our meson build uses - in option names, not _. And, I'd > prefer > just "opencl-spirv". Err right, I meant with '-' in the option name. I am fine with "opencl-spirv"; I was initially going with "gallium-opencl-spirv" since the other clover-related command was named

[Mesa-dev] [PATCH] meson: Fix with_gallium_icd to with_opencl_icd

`with_gallium_icd` is never used throughout the different Meson build files, whereas `with_opencl_icd` tracks whether or not `gallium-opencl` was set to "icd". Signed-off-by: Pierre Moreau --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build

[Mesa-dev] [Bug 106595] [RADV] Rendering distortions only when MSAA is enabled

https://bugs.freedesktop.org/show_bug.cgi?id=106595 Timothy Arceri changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

Re: [Mesa-dev] [PATCH] meson: Fix with_gallium_icd to with_opencl_icd

Quoting Pierre Moreau (2019-01-09 14:03:45) > `with_gallium_icd` is never used throughout the different Meson build > files, whereas `with_opencl_icd` tracks whether or not `gallium-opencl` > was set to "icd". > > Signed-off-by: Pierre Moreau > --- > meson.build | 2 +- > 1 file changed, 1