Re: [Mesa-dev] [radeonsi] meson vs autotools used disk space observations

2019-05-12 Thread Jason Ekstrand
Likely you're either getting slightly different build flags for some reason it else something extra is getting linked into the gallium driver that want before. Not all they concerning but I'll happily agree it is a bit odd and probably worth some investigation. If nothing else, your build setup

[Mesa-dev] [RFC PATCH 2/2] panfrost/midgard: Ignore imov/fmov distinction

2019-05-12 Thread Alyssa Rosenzweig
We use nir_gather_ssa_types, rather than the instruction name, to decide how moves should be compiled. This is important since the imov/fmov never mapped to what Midgard needed to begin with. This should allow Jason's imov/fmov merger to proceed without regressing Panfrost, since this is one less

[Mesa-dev] [RFC PATCH 1/2] nir: Silently bail on regs for gather_ssa_types

2019-05-12 Thread Alyssa Rosenzweig
In the future, we'll really need to implement register support for nir_gather_ssa_types, but at present, for some limited applications it can be ok to just bail on these and set neither int_types nor float_types, rather than assert'ing out and crashing. It's not correct, per se, but existing users

[Mesa-dev] [PATCH v2 0/6] Programmatic blending

2019-05-12 Thread Alyssa Rosenzweig
This series is take two at programmatic blending. The first few patches (setting up the overall structure) of v1 were merged and are omitted here. We start with the improved nir_lower_blend implementation, which has stylistic fixes and an implementation of glColorMask. Beyond that, the biggest

[Mesa-dev] [PATCH v2 2/6] nir: add a vectorization pass

2019-05-12 Thread Alyssa Rosenzweig
From: Connor Abbott This effectively does the opposite of nir_lower_alus_to_scalar, trying to combine per-component ALU operations with the same sources but different swizzles into one larger ALU operation. It uses a similar model as CSE, where we do a depth-first approach and keep around a hash

[Mesa-dev] [PATCH v2 3/6] panfrost/midgard: Route new blending intrinsics

2019-05-12 Thread Alyssa Rosenzweig
To prepare for the new nir_lower_blend pass, we wire up the intrinsics for tilebuffer reads and constant colour loading. Signed-off-by: Alyssa Rosenzweig --- .../panfrost/midgard/midgard_compile.c| 223 +- 1 file changed, 117 insertions(+), 106 deletions(-) diff --git

[Mesa-dev] [PATCH v2 5/6] panfrost: Wire up nir_lower_blend

2019-05-12 Thread Alyssa Rosenzweig
This implements blend shaders via nir_lower_blend, by creating dummy fragment shaders simply passing through the source color and using the new lowering pass to inject blendability. Signed-off-by: Alyssa Rosenzweig --- .../drivers/panfrost/pan_blend_shaders.c | 48 +-- 1

[Mesa-dev] [PATCH v2 6/6] panfrost: Improve fixed-function blending

2019-05-12 Thread Alyssa Rosenzweig
This fixes a few miscellaneous issues with the fixed-function blending programming, though it is far from complete. For cases known to be buggy, we force a fallback to blend shaders. Signed-off-by: Alyssa Rosenzweig --- .../drivers/panfrost/ci/expected-failures.txt | 942 --

[Mesa-dev] [PATCH v2 4/6] panfrost/midgard: Enable NIR vectorization pass

2019-05-12 Thread Alyssa Rosenzweig
This cleans up the blend shader code considerably, owing to a substantial improvement in these shaders. It's not clear how this affects overall driver performance; i965 had mixed results with this. Time will tell. Signed-off-by: Alyssa Rosenzweig ---

[Mesa-dev] [PATCH v2 1/6] nir: Add nir_lower_blend pass

2019-05-12 Thread Alyssa Rosenzweig
This new lowering pass implements the OpenGL ES blend pipeline in shaders, applicable to hardware lacking full-featured blending hardware (including Midgard/Bifrost and vc4). This pass is run on a fragment shader, rewriting the store to a blended version, loading in the framebuffer destination

Re: [Mesa-dev] [PATCH] [Panfrost] [Bifrost] Add a few missing ops to disassembler

2019-05-12 Thread Alyssa Rosenzweig
Did we ever decide what to do with this? ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [radeonsi] meson vs autotools used disk space observations

2019-05-12 Thread Dieter Nützel
Am 13.05.2019 00:03, schrieb Jason Ekstrand: Likely you're either getting slightly different build flags for some reason it else something extra is getting linked into the gallium driver that want before. Not all they concerning but I'll happily agree it is a bit odd and probably worth some

Re: [Mesa-dev] [PATCH] nv50/ir/nir: prefer to shift 1ull instead of 1ll

2019-05-12 Thread Pierre Moreau
Reviewed-by: Pierre Moreau On 2019-05-12 — 15:51, Karol Herbst wrote: > Signed-off-by: Karol Herbst > Suggested-by: Ilia Mirkin > --- > src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH] nv50/ir/nir: make use of SYSTEM_VALUE_MAX when iterating read sysvals

2019-05-12 Thread Pierre Moreau
Reviewed-by: Pierre Moreau On 2019-05-12 — 15:56, Karol Herbst wrote: > Signed-off-by: Karol Herbst > --- > src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[Mesa-dev] [radeonsi] meson vs autotools used disk space observations

2019-05-12 Thread Dieter Nützel
Hello to all of you, after long fiddling with fading away of autotools I have to present my observations about used disk space at least for the radeonsi driver. Same goes for radeon. autotools -rwxr-xr-x 4 root root 4903184 12. Mai 19:28 radeonsi_drv_video.so -rwxr-xr-x 4 root root

Re: [Mesa-dev] [PATCH] radv: remove sisched hack for talos

2019-05-12 Thread Dieter Nützel
Am 15.03.2019 23:47, schrieb Timothy Arceri: On 16/3/19 6:53 am, Dieter Nützel wrote: Am 15.03.2019 15:20, schrieb Samuel Pitoiset: Results of my benchmarks are: 3 runs at 1080p: GFX8: -1% GFX9: -1.12% 3 runs at 4k: GFX8: -2% GFX9: -1.85% I'm actually not sure if we want to remove it...

[Mesa-dev] [PATCH 1/6] mesa/vbo: Update Comment to what is actually happening.

2019-05-12 Thread Mathias . Froehlich
From: Mathias Fröhlich Signed-off-by: Mathias Fröhlich --- src/mesa/vbo/vbo_exec_draw.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/mesa/vbo/vbo_exec_draw.c b/src/mesa/vbo/vbo_exec_draw.c index 87652d659d0..fd55a5bbee6 100644 --- a/src/mesa/vbo/vbo_exec_draw.c

[Mesa-dev] [PATCH 5/6] mesa: Avoid setting _NEW_VARYING_VP_INPUTS in non fixed function mode.

2019-05-12 Thread Mathias . Froehlich
From: Mathias Fröhlich Instead of checking the API variant on entry of set_varying_vp_inputs to check if we can ever be interrested in fixed function processing or not, we can check if we are actually fixed function processing. To check this we can use the immediately updated

[Mesa-dev] [PATCH 3/6] mesa: Make _mesa_set_varying_vp_inputs static in state.c.

2019-05-12 Thread Mathias . Froehlich
From: Mathias Fröhlich Is no longer used outside that file. Signed-off-by: Mathias Fröhlich --- src/mesa/main/state.c | 7 +++ src/mesa/main/state.h | 4 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/src/mesa/main/state.c b/src/mesa/main/state.c index

[Mesa-dev] [PATCH 0/6] Update mesa state handling past VAO changes.

2019-05-12 Thread Mathias . Froehlich
From: Mathias Fröhlich Hi Brian, The series is a collection of comment updates and state handling cleanup past the VAO changes that went into mesa. There are two fixes for potential bugs in state handling included. There were no reports accoring that, and it does not change the outcome of

[Mesa-dev] [PATCH 4/6] mesa: Fix test for setting the _NEW_VARYING_VP_INPUTS flag.

2019-05-12 Thread Mathias . Froehlich
From: Mathias Fröhlich The precondition stated in the comment is not true. The values mentioned are only set from _mesa_update_state which in turn may not yet be called. For now set the _NEW_VARYING_VP_INPUTS flag a bit more often, we will narrow that down to a minimum again in a later patch.

[Mesa-dev] [PATCH] nv50/ir/nir: prefer to shift 1ull instead of 1ll

2019-05-12 Thread Karol Herbst
Signed-off-by: Karol Herbst Suggested-by: Ilia Mirkin --- src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp

[Mesa-dev] [PATCH 6/6] mesa: Set _NEW_VARYING_VP_INPUTS iff varying_vp_inputs are set.

2019-05-12 Thread Mathias . Froehlich
From: Mathias Fröhlich Signed-off-by: Mathias Fröhlich --- src/mesa/main/state.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/mesa/main/state.c b/src/mesa/main/state.c index 9d8964952cd..3e2eb28dcc5 100644 --- a/src/mesa/main/state.c +++

[Mesa-dev] [PATCH 2/6] mesa: Fix old outdated variable name in a comment.

2019-05-12 Thread Mathias . Froehlich
From: Mathias Fröhlich Signed-off-by: Mathias Fröhlich --- src/mesa/main/state.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/state.h b/src/mesa/main/state.h index 589c6650add..92c0661d4ee 100644 --- a/src/mesa/main/state.h +++ b/src/mesa/main/state.h @@

[Mesa-dev] [PATCH] nv50/ir/nir: make use of SYSTEM_VALUE_MAX when iterating read sysvals

2019-05-12 Thread Karol Herbst
Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp index