Re: [Mesa-dev] [PATCH v6] egl/dri2: implement platform_surfaceless

n is common throughout Mesa. So... ok. I was initially worried that dri2_terminate() might not properly tear down the display, but I convinced myself the code is correct. Reviewed-by: Chad Versace If no one objects, I'll commit this Monday afternoon. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] EGL: Add pbuffer support for drm platform

On Thu 11 Jun 2015, Ying Liu wrote: > Add pbuffer support for drm platform, because some customers are still using > this feature. > > Signed-off-by: Ying Liu > --- > src/egl/drivers/dri2/egl_dri2.c | 2 +- > src/egl/drivers/dri2/platform_drm.c | 18 ++ > 2 files changed, 1

Re: [Mesa-dev] [Mesa-stable] [PATCH] egl/x11: Remove duplicate call to dri2_x11_add_configs_for_visuals

e we've > missed something :-) > > Fwiw the patch is > Reviewed-by: Emil Velikov Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [Mesa-stable] [PATCH] bugzilla_mesa.sh: sort the bugs list by number

| uniq) > +urls=$(git log $* | grep 'bugs.freedesktop.org/show_bug' | sed -e > $trim_before -e $trim_after -e $use_https | sort-n | uniq) That can't be right! A space is needed between 'sort' and '-n'. Add the space, and this is Reviewed-by: Chad Versace __

Re: [Mesa-dev] [Mesa-stable] [PATCH] bugzilla_mesa.sh: sort the bugs list by number

On Tue 23 Jun 2015, Ilia Mirkin wrote: > On Tue, Jun 23, 2015 at 12:05 PM, Chad Versace wrote: > > On Fri 19 Jun 2015, Emil Velikov wrote: > >> Cc: "10.5 10.6" > >> Suggested-by: Ilia Mirkin > >> Signed-off-by: Emil Velikov > > > > >

Re: [Mesa-dev] [PATCH] mesa: Convert some asserts into STATIC_ASSERT.

On Mon 29 Jun 2015, Matt Turner wrote: > --- > src/mesa/main/context.c | 13 ++--- > 1 file changed, 6 insertions(+), 7 deletions(-) Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop

[Mesa-dev] [PATCH 0/2] egl, i965: Support importing R8 and GR88 dma_bufs as textures

te: Mon, 22 Jun 2015 06:40:14 -0700 Chad Versace (2): egl: Add support for DRM_FORMAT_R8, RG88, and GR88 i965: Support importing R8 and GR88 dma_bufs include/GL/internal/dri_interface.h | 9 +++-- src/egl/drivers/dri2/egl_dri2.c | 19 +++ src/mesa/d

[Mesa-dev] [PATCH 2/2] i965: Support importing R8 and GR88 dma_bufs

EGL_EXT_image_dma_buf_import now supports those formats. CC: Peter Frühberger Cc: Rainer Hochecker Signed-off-by: Chad Versace --- include/GL/internal/dri_interface.h | 9 +++-- src/mesa/drivers/dri/i965/intel_screen.c | 6 ++ 2 files changed, 13 insertions(+), 2 deletions

[Mesa-dev] [PATCH 1/2] egl: Add support for DRM_FORMAT_R8, RG88, and GR88

part of EGL about the new formats. Real driver support is left for follow-up patches. CC: Peter Frühberger Cc: Rainer Hochecker Signed-off-by: Chad Versace --- src/egl/drivers/dri2/egl_dri2.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/egl/drivers/dri2/egl_dri2.c

Re: [Mesa-dev] [PATCH 2/2] i965: Support importing R8 and GR88 dma_bufs

On Thu 09 Jul 2015, Emil Velikov wrote: > On 9 July 2015 at 09:39, Chad Versace wrote: > > EGL_EXT_image_dma_buf_import now supports those formats. > > > Do I have an old version of it (v6) or I simply cannot see those listed ? I should have been more

Re: [Mesa-dev] [PATCH 2/2] i965: Support importing R8 and GR88 dma_bufs

On Thu 09 Jul 2015, Emil Velikov wrote: > On 9 July 2015 at 21:21, Chad Versace wrote: > > On Thu 09 Jul 2015, Emil Velikov wrote: > >> On 9 July 2015 at 09:39, Chad Versace wrote: > >> > EGL_EXT_image_dma_buf_import now supports those formats. > >> > &

[Mesa-dev] [PATCH] mesa: Fix generation of git_sha1.h.tmp for gitlinks

Don't assume that $(top_srcdir)/.git is a directory. It may be a gitlink file [1] if $(top_srcdir) is a submodule checkout or a linked worktree [2]. [1] A "gitlink" is a text file that specifies the real location of the gitdir. [2] Linked worktrees are a new feature in Git 2.5. Cc: "10.6, 10.

Re: [Mesa-dev] [PATCH 1/5] i965: Push miptree tiling request into flags

anges > Fix non-msrt MCS allocation (was only happening in gen8 case before) > > Cc: Anuj Phogat > Cc: Chad Versace > Signed-off-by: Ben Widawsky I have one nitpick... > - /* 'requested' parameter of intel_miptree_create_layout() is relevant > -* only for no

Re: [Mesa-dev] [PATCH 2/5] i965/miptree: Cleanup some of the miptree map logic

On Wed 15 Jul 2015, Anuj Phogat wrote: > On Tue, Jul 14, 2015 at 9:56 AM, Ben Widawsky > wrote: > > At the crux of this change is moving whether or not we can even use the > > hardware > > blitter into the can_blit_slice check. Fundamentally this makes sense as > > blitting a slice is a subset in

Re: [Mesa-dev] [PATCH 5/5] i965/miptree: Rewrite the miptree map logic

On Tue 14 Jul 2015, Ben Widawsky wrote: > This patch rewrites the logic for determining which method we using for > mapping > a miptree. It is my intention that that this patch, the required patches > before > this do not change functionality, or if they do, it's in very obscure an > unobservable

Re: [Mesa-dev] [PATCH 1/5] utils: automake: remove uncommon $()

On Fri 17 Jul 2015, Emil Velikov wrote: > On 17 July 2015 at 19:11, Ilia Mirkin wrote: > > On Fri, Jul 17, 2015 at 2:11 PM, Eric Anholt wrote: > >> Matt Turner writes: > >> > >>> On Fri, Jul 17, 2015 at 10:17 AM, Emil Velikov > >>> wrote: > Cc: Eric Anholt > Signed-off-by: Emil Veli

Re: [Mesa-dev] [PATCH 04/10] i965/skl: skip fast clears for certain surface formats

On Tue 13 Oct 2015, Ben Widawsky wrote: > Initially I had this planned as a patch to be squashed in to the enabling > patch > because there is no point enabling fast clears without this. However, Chad > merged a patch which disables fast clears on gen9 explicitly, and so I can > hide > this behin

Re: [Mesa-dev] [PATCH 03/10] i965/skl: Enable fast color clears on SKL

But this patch doesn't enable fast clears! The reverts in pathches 6 and 7 need to be folded into this patch, otherwise the patch does not do what it claims. Also, you can't enable fast clears before patches 4 and 5 without introducing regressions. Patches 4 and 5 must precede this patch. On Tue

Re: [Mesa-dev] [PATCH 08/10] i965/meta: Assert fast clears and rep clears never overlap

sberg > Signed-off-by: Ben Widawsky > --- > src/mesa/drivers/dri/i965/brw_meta_fast_clear.c | 2 ++ > 1 file changed, 2 insertions(+) Patch 8 is Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://li

Re: [Mesa-dev] [PATCH 01/10] i965/gen8+: Remove redundant zeroing of surface state

ate.c | 12 > 1 file changed, 12 deletions(-) Patch 1 is Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 05/10] i965/meta/gen9: Individually fast clear color attachments

On Tue 13 Oct 2015, Ben Widawsky wrote: > The impetus for this patch comes from a seemingly benign statement within the > spec (quoted within the patch). For me, this patch was at some point critical > for getting stable piglit results (though this did not seem to be the case on > a > branch Chad

Re: [Mesa-dev] [RFC 05/21] mesa/extensions: Add extension::version

On Mon 19 Oct 2015, Nanley Chery wrote: > From: Nanley Chery > > Enable limiting advertised extension support by context version with > finer granularity. GLuint is chosen over smaller datatypes because, > when this field is eventually used, usage of this datatype provides > the smallest .text si

Re: [Mesa-dev] [RFC 06/21] mesa/extensions: Create _mesa_extension_supported()

On Thu 22 Oct 2015, Emil Velikov wrote: > On 19 October 2015 at 23:36, Nanley Chery wrote: > > From: Nanley Chery > > > > Create a function which determines if an extension is supported in the > > current context. > > > > Signed-off-by: Nanley Chery > > --- > > src/mesa/main/extensions.c | 17 +

Re: [Mesa-dev] [RFC 07/21] mesa/extensions: Use _mesa_extension_supported()

On Mon 19 Oct 2015, Nanley Chery wrote: > From: Nanley Chery > > Replace open-coded checks for extension support with > _mesa_extension_supported(). > > Signed-off-by: Nanley Chery > --- > src/mesa/main/extensions.c | 54 > > src/mesa/main/extens

Re: [Mesa-dev] [RFC 08/21] mesa/extensions: Replace extension::api_set with ::version

On Mon 19 Oct 2015, Nanley Chery wrote: > From: Nanley Chery > > The api_set field has no users outside of _mesa_extension_supported(). > Remove it and allow the version field to take its place. > > The brunt of the transformation was performed with the following vim commands: > s/\(GL [^,]\+\),

Re: [Mesa-dev] [RFC 09/21] mesa: Generate a helper function for each extension

nd enums > into generated helper functions was suggested by Kristian Høgsberg. > > For performance, the function body no longer uses > _mesa_extension_supported() and, as suggested by Chad Versace, the > functions are also declared static inline. > > Signed-off-by: Nanley Chery >

Re: [Mesa-dev] [RFC 10/21] mesa: Remove equality check in helper functions

On Thu 22 Oct 2015, Emil Velikov wrote: > On 22 October 2015 at 07:43, Erik Faye-Lund wrote: > > On Tue, Oct 20, 2015 at 12:44 AM, Nanley Chery > > wrote: > >> From: Nanley Chery > >> > >> Since the version numbers being compared are integral and we don't ever > >> expect gl_context::Version to

Re: [Mesa-dev] [RFC 08/21] mesa/extensions: Replace extension::api_set with ::version

On Thu 22 Oct 2015, Matt Turner wrote: > On Thu, Oct 22, 2015 at 11:24 AM, Chad Versace wrote: > > On Mon 19 Oct 2015, Nanley Chery wrote: > >> From: Nanley Chery > >> > >> The api_set field has no users outside of _mesa_extension_supported(). > >>

Re: [Mesa-dev] [RFC 15/21] mesa: Fix EXT_texture_sRGB functionality leaks

On Mon 19 Oct 2015, Nanley Chery wrote: > From: Nanley Chery > > Stop leaks into the following contexts: >* GLES in _mesa_base_tex_format() and lookup_view_class(). >* Pre-1.1 GL legacy contexts in all uses. > > Stop allowing compressed sRGB formats as valid formats in GLES3 > contexts.

Re: [Mesa-dev] [RFC 16/21] mesa: Fix ARB_texture_compression_bptc functionality leaks

On Tue 20 Oct 2015, Nanley Chery wrote: > On Tue, Oct 20, 2015 at 8:37 AM, Marek Olšák wrote: > > > NAK. I'd like this extension in compatibility contexts. The fact the > > spec requires OpenGL 3.1 was just authors' laziness. > > > > > I had thought it might be the case that some specs may uneces

Re: [Mesa-dev] [RFC 09/21] mesa: Generate a helper function for each extension

On Fri 23 Oct 2015, Nanley Chery wrote: > On Thu, Oct 22, 2015 at 11:30 AM, Chad Versace > wrote: > > > On Mon 19 Oct 2015, Nanley Chery wrote: > > > From: Nanley Chery > > > > > > Generate functions which determine if an extension is supported in t

Re: [Mesa-dev] [RFC 19/21] mesa: Replace gl_extensions::EXT_texture3D with ::dummy_true

| 1 - > 5 files changed, 3 insertions(+), 7 deletions(-) This patch is Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 04/10] i965/skl: skip fast clears for certain surface formats

On Tue 03 Nov 2015, Ben Widawsky wrote: > On Fri, Oct 16, 2015 at 04:05:22PM -0700, Chad Versace wrote: > > On Tue 13 Oct 2015, Ben Widawsky wrote: > > > Initially I had this planned as a patch to be squashed in to the enabling > > > patch > > > because th

Re: [Mesa-dev] [PATCH 03/10] i965/skl: Enable fast color clears on SKL

On Tue 03 Nov 2015, Ben Widawsky wrote: > On Fri, Oct 16, 2015 at 04:10:02PM -0700, Chad Versace wrote: > > But this patch doesn't enable fast clears! The reverts in pathches 6 and > > 7 need to be folded into this patch, otherwise the patch does not do > > what it claims

Re: [Mesa-dev] [PATCH 0/7] i965: Use native formats in fs_surface_builder

On Wed 04 Nov 2015, Jason Ekstrand wrote: > This little patch series converts fs_surface_builder to use native formats > for doing all of its image_load_store workaround tricks. If you're willing > to take as an axiom that we want to not link the backend compiler against > core mesa, this leaves u

Re: [Mesa-dev] [PATCH 1/7] i965/fs_surface_builder: Explicitly handle FORMAT_NONE in num_image_coordinates

that relied on _mesa_get_format_bytes(MESA_FORMAT_NONE) => 1, the patch is still looks like an improvement to me. Acked-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/7] i965: Add a variant of lower_mesa_image_format that takes native formats

came numb when reviewing the sed job. Everything looked correct, though, until I became bored. Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 3/7] i965: Add an image format metadata array

t struct brw_image_format_info brw_image_format_info[] = { > + IF( 8, 0, 0, 0, UNORM, R8_UNORM) > + IF( 8, 0, 0, 0, SNORM, R8_SNORM) > + IF( 8, 0, 0, 0, UINT, R8_UINT) > + IF( 8, 0, 0, 0, SINT, R8_SINT) > + IF( 8, 8, 0, 0, UNORM, R8G8_UNORM) Reviewed-by: Chad

Re: [Mesa-dev] [PATCH 4/7] i965/fs: Use image_format_info for doing image_load_store workarounds

On Wed 04 Nov 2015, Jason Ekstrand wrote: > --- > .../drivers/dri/i965/brw_fs_surface_builder.cpp| 157 > ++--- > 1 file changed, 106 insertions(+), 51 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs_surface_builder.cpp > b/src/mesa/drivers/dri/i965/brw_fs_sur

Re: [Mesa-dev] [PATCH 5/7] i965/image_load_store: Add a brw_image_format_for_gl_format helper

GL_RG32I: return BRW_SURFACEFORMAT_R32G32_SINT; > >> + case GL_RGBA32F:return BRW_SURFACEFORMAT_R32G32B32A32_FLOAT; > >> + case GL_RGBA32UI: return BRW_SURFACEFORMAT_R32G32B32A32_UINT; > >> + case GL_RGBA32I:return BRW_SURFACEFORMAT_R32G32B32A32_SINT; > >> + default: > >> + assert(!"Invalid image format"); > >> + return GL_NONE; > > > > Seems odd to be returning GL_NONE here where all the other returns are > > BRW_SURFACEFORMAT_*. With that fixed to BRW_SURFACEFORMAT_RAW, this patch is Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 6/7] i965/fs_surface_builder: Work in terms of native formats

, 12 insertions(+), 13 deletions(-) I applied patches 1-6 to master and closely searched for instances of brw_format misused as a mesa_format and vice-versa, and found none. So patch 6 LGTM. Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.

Re: [Mesa-dev] [PATCH 7/7] i965: Remove brw_lower_mesa_image_format

rw_surface_formats.c | 109 > --- > src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 11 +-- > 3 files changed, 3 insertions(+), 119 deletions(-) Patch 7 is Reviewed-by: Chad Versace If I missed any patches in the series, let me know. I beli

Re: [Mesa-dev] [PATCH 4/7] i965/fs: Use image_format_info for doing image_load_store workarounds

On Mon 09 Nov 2015, Jason Ekstrand wrote: > On Mon, Nov 9, 2015 at 2:24 PM, Chad Versace wrote: > > On Wed 04 Nov 2015, Jason Ekstrand wrote: > >> --- > >> .../drivers/dri/i965/brw_fs_surface_builder.cpp| 157 > >> ++--- > >> 1

Re: [Mesa-dev] [PATCH v2 01/18] mesa/extensions: Remove array sentinel

On Fri 30 Oct 2015, Nanley Chery wrote: > From: Nanley Chery > > Simplify future updates to the extension struct array by removing > the sentinel. > > Signed-off-by: Nanley Chery Patch 1 is Reviewed-by: Chad Versace Since your series is long and risks suffering from r

Re: [Mesa-dev] [PATCH v2 02/18] mesa/extensions: Wrap array entries in macros

_ES2_compatibility > , GL , 2009) > +EXT(ARB_ES3_compatibility , ARB_ES3_compatibility > , GL , 2012) [...] Each EXT line is an array entry. Please indent it as such, just like the old array entries that the patch r

Re: [Mesa-dev] [PATCH v2 03/18] mesa/extensions: Move entries entries to seperate file

/main/extensions_table.h Patch 3 is Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2 04/18] mesa/extensions: Add extension::version

in the commit message the preparatory nature of the patch. Namely, that (1) extension::version is nowhere used yet and (2) extension::version[*] is set to 0 everywhere. With that little extra in the commit message, patch 4 is Reviewed-by: Chad Versace _

Re: [Mesa-dev] [PATCH v2 06/18] mesa/extensions: Use _mesa_extension_supported()

-- > src/mesa/main/extensions_table.h | 6 ++--- > 2 files changed, 14 insertions(+), 46 deletions(-) I diffed the output of glxinfo between master@0260620 and nchery/ext_save-v2@69a93a0 (this patch), and saw no significant diff. So the series looks good so far. Patches 5 an

Re: [Mesa-dev] [PATCH v2 07/18] mesa/extensions: Replace extension::api_set with ::version

ed, 326 insertions(+), 331 deletions(-) Patch 7 is Reviewed-by: Chad Versace I again tested glxinfo output against master, and there was no difference. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2 08/18] mesa: Generate a helper function for each extension

nd enums > into generated helper functions was suggested by Kristian Høgsberg. > > For performance, the function body no longer uses > _mesa_extension_supported() and, as suggested by Chad Versace, the > functions are also declared static inline. > > v2. Place function qualifiers on

Re: [Mesa-dev] [PATCH v2 08/18] mesa: Generate a helper function for each extension

nd enums > into generated helper functions was suggested by Kristian Høgsberg. > > For performance, the function body no longer uses > _mesa_extension_supported() and, as suggested by Chad Versace, the > functions are also declared static inline. > > v2. Place function qualifiers on

Re: [Mesa-dev] [PATCH v2 09/18] mesa/extensions: Prefix global struct and extension type

_{enables,disables} structs. > > Suggested-by: Marek Olšák > Suggested-by: Chad Versace > Signed-off-by: Nanley Chery > --- > src/mesa/main/extensions.c | 40 > src/mesa/main/extensions.h | 6 +++--- > 2 files changed, 23 ins

Re: [Mesa-dev] [PATCH v2 10/18] mesa: In helpers, only check driver capability for meta

Hanging comma. Was that intentional? > +* while meta is in progress. > +*/ > + GLubyte Version; > }; I approve of this slick version hack for meta. With or without the hanging c

Re: [Mesa-dev] [PATCH 1/7] [v2] i965/skl: Add fast color clear infrastructure

races for the multiline (Matt + Chad) > Comment updates (requested by Chad) > Modified commit message > Commit message from Chad explaining the MCS height change (Chad) > > Cc: Chad Versace > Signed-off-by: Ben Widawsky > Reviewed-by: Neil Roberts > --- > src/mesa/

Re: [Mesa-dev] [PATCH 3/7] [v2] i965/skl: skip fast clears for certain surface formats

n "invalid" assert (Chad) > Fix assertion to check num_samples > 1, instead of num_samples (Chad) > > Cc: Chad Versace > Cc: Neil Roberts > Signed-off-by: Ben Widawsky > --- > src/mesa/drivers/dri/i965/brw_surface_formats.c | 52 > - &g

Re: [Mesa-dev] [PATCH 4/7] [v2] i965/meta/gen9: Individually fast clear color attachments

. Same for me. If you squash Neil's changes Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/7] i965: Add lossless compression to surface format table

; because of the fact that surface format support diminishes. You'd probably > want > another column to cleanly implement it. > > Requested-by: Chad Versace > Requested-by: Neil Roberts > Signed-off-by: Ben Widawsky > --- > src/mesa/drivers/dri/i965/brw_context.h

Re: [Mesa-dev] [PATCH 4/4] i965: Implemente a tiled fast-path for glReadPixels and glGetTexImage

On 01/20/2015 12:09 PM, Jason Ekstrand wrote: > > > On Tue, Jan 13, 2015 at 10:44 AM, Chad Versace > mailto:chad.vers...@intel.com>> wrote: > > On 01/12/2015 10:22 AM, Jason Ekstrand wrote: >> From: Sisinty Sasmita Patra > <mailto:si

Re: [Mesa-dev] [PATCH] i965: Do Sandybridge workaround flushes before each primitive.

On 01/21/2015 03:11 PM, Kenneth Graunke wrote: > On Wednesday, January 21, 2015 11:59:39 AM Chad Versace wrote: >> On 01/09/2015 11:07 PM, Kenneth Graunke wrote: >>> Sandybridge requires the post-sync non-zero workaround in a ton of >>> places, and if you ever miss

Re: [Mesa-dev] [PATCH] i965: Add a better PRM citation for the IMS dimension mangling.

16x. > > Signed-off-by: Kenneth Graunke Reviewed-by: Chad Versace signature.asc Description: OpenPGP digital signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/2] egl/dri: Defer display destruction until the display is not in use.

On 01/28/2015 01:45 PM, jim.br...@linux.intel.com wrote: > From: Jim Bride > > In situations where a DRI2 driver is in use and a call to eglTerminate() > is followed by a call to eglMakeCurrent() the mandatory call to glFlush() > inside of dri2_make_current() would cause a segmentation fault beca

Re: [Mesa-dev] [PATCH 1/2] egl: Add unbound_only parameter to _eglReleaseDisplayResources()

| 3 ++- > src/gallium/state_trackers/egl/common/egl_g3d.c | 9 - > 4 files changed, 29 insertions(+), 7 deletions(-) Reviewed-by: Chad Versace I'm waiting on fixes to patch 2 before committing patch 1, because t

Re: [Mesa-dev] [PATCH 1/2] i965/tiled_memcpy: Support a signed linear pitch

On 01/28/2015 03:36 AM, Jason Ekstrand wrote: > Cc: Chad Versace > --- > src/mesa/drivers/dri/i965/intel_tiled_memcpy.c | 30 > +- > src/mesa/drivers/dri/i965/intel_tiled_memcpy.h | 4 ++-- > 2 files changed, 17 insertions(+), 17 deletions(-) > &g

Re: [Mesa-dev] [PATCH 2/2] intel/pixel_read: Properly flip the results for window system buffers

postponed printing this message until having committed to executing > * the function. > */ > Reviewed-by: Chad Versace signature.asc Description: OpenPGP digital signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/2] egl: implement EGL_MESA_transparent_alpha for x11 and wayland

On 02/23/2015 06:32 AM, Jonny Lamb wrote: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=67676 > --- > include/EGL/eglmesaext.h| 5 + > src/egl/drivers/dri2/platform_wayland.c | 9 +++-- > src/egl/drivers/dri2/platform_x11.c | 22 +- > sr

Re: [Mesa-dev] [PATCH] i965: Fix uint64_t overflow in intel_client_wait_sync()

tely in that case. Thus, if an application passes > UINT64_MAX to wait forever, we overflow to -1LL and return immediately. > Work around this mess by clamping the wait timeout to INT64_MAX. > > Signed-off-by: Kristian Høgsberg Reviewed-by: Chad Versace signature.asc Descripti

Re: [Mesa-dev] [PATCH 1/2] egl: add EGL_MESA_transparent_alpha extension

On 02/23/2015 06:32 AM, Jonny Lamb wrote: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=67676 > Reviewed-by: Chad Versace > --- > docs/specs/EGL_MESA_transparent_alpha.txt | 120 > ++ > 1 file changed, 120 insertions(+) > create m

Re: [Mesa-dev] [PATCH] egl: Report correct GBM formats

On 03/02/2015 06:23 AM, Tom Stellard wrote: > From: Daniel Stone > > This fixes almost all piglit regressions when running with > PIGLIT_PLATFORM=gbm > > Tom Stellard: > - Fix ARGB2101010 format > > Cc: "10.4 10.5" Reviewed-by: Chad Versace signa

Re: [Mesa-dev] [PATCH] [RFC] egl: propose simple EGL_MESA_image_dma_buf_export v2.2

On 03/03/2015 12:13 AM, Daniel Stone wrote: > Hi, > > On Tuesday, March 3, 2015, Dave Airlie > wrote: > > +EGLBoolean eglExportDMABUFImageQueryMESA(EGLDisplay dpy, > + EGLImageKHR image, > +

Re: [Mesa-dev] egl dma-buf export extension again

On 03/02/2015 09:36 PM, Dave Airlie wrote: > On 3 March 2015 at 13:57, Dave Airlie wrote: >> >> Okay I've revised this to add some more info to the interface, >> essentially I need to get the fourcc back so I can later pass >> it across the "wire" to the EGL_EXT_image_dma_buf_import, also >> the n

Re: [Mesa-dev] [PATCH] intel: fix EGLImage renderbuffer _BaseFormat

rc/mesa/drivers/dri/i965/intel_fbo.c | 2 +- > 2 files changed, 2 insertions(+), 3 deletions(-) > > Otherwise, when using gles, _BaseFormat is set to 0 and a glReadPixels > from the buffer hits an assert. > Tested on i965. Compiled for i915. R

Re: [Mesa-dev] [PATCH] [RFC] egl: propose simple EGL_MESA_image_dma_buf_export v2.2

On 03/03/2015 11:01 AM, Daniel Stone wrote: > Hi, > > On 3 March 2015 at 18:40, Chad Versace wrote: >> On 03/03/2015 12:13 AM, Daniel Stone wrote: >>> On Tuesday, March 3, 2015, Dave Airlie >> <mailto:airl...@gmail.com>> wrote: >>> +EGLBool

Re: [Mesa-dev] [PATCH] [RFC] egl: propose simple EGL_MESA_image_dma_buf_export v2.2

On 03/03/2015 11:13 AM, Dave Airlie wrote: > On 4 March 2015 at 05:06, Chad Versace wrote: >> On 03/03/2015 11:01 AM, Daniel Stone wrote: >>> Hi, >>> >>> On 3 March 2015 at 18:40, Chad Versace wrote: >>>> On 03/03/2015 12:13 AM, Daniel Stone wro

Re: [Mesa-dev] [PATCH] i965: Throttle rendering to an fbo

On 02/26/2015 05:24 AM, Chris Wilson wrote: > When rendering to an fbo, even though it may be acting as a winsys > frontbuffer or just generally, we never throttle. However, when rendering > to an fbo, there is no natural frame boundary. Conventionally we use > SwapBuffers and glFinish, but potenti

Re: [Mesa-dev] [PATCH] i965: Throttle rendering to an fbo

On 03/04/2015 09:52 AM, Chris Wilson wrote: > On Wed, Mar 04, 2015 at 09:41:56AM -0800, Chad Versace wrote: >> On 02/26/2015 05:24 AM, Chris Wilson wrote: >>> When rendering to an fbo, even though it may be acting as a winsys >>> frontbuffer or just generally, we ne

Re: [Mesa-dev] [PATCH 1/2] i965: Throttle rendering to an fbo

g that need_front_throttle is being hijacked for fbo, back, and front buffer rendering. With that little comment, patch 1 is Reviewed-by: Chad Versace I'm still looking at patch 2. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/2] i965: Throttle to the previous frame

This doubles the maximum possible latency at the > benefit of improving throughput and reducing jitter. > > Signed-off-by: Chris Wilson > Cc: Daniel Vetter > Cc: Kenneth Graunke > Cc: Ben Widawsky > Cc: Kristian Høgsberg > Cc: Chad Versace --- > src/mesa/dr

Re: [Mesa-dev] [PATCH 2/2] i965: Throttle to the previous frame

p > batch. Not least of which was that not all throttle points are SwapBuffers. > > Signed-off-by: Chris Wilson > Cc: Daniel Vetter > Cc: Kenneth Graunke > Cc: Ben Widawsky > Cc: Kristian Høgsberg > Cc: Chad Versace Both patches Reviewed-by: Chad Versace

Re: [Mesa-dev] [PATCH] configure: Only require libdrm 2.4.75 for intel.

On Thu 02 Feb 2017, Dave Airlie wrote: > On 2 February 2017 at 13:09, Emil Velikov wrote: > > On 2 February 2017 at 02:58, Michel Dänzer wrote: > >> On 02/02/17 09:10 AM, Emil Velikov wrote: > >>> On 1 February 2017 at 23:28, Vinson Lee wrote: > Fixes: b8acb6b17981 ("configure: Require libd

Re: [Mesa-dev] [PATCH] configure.ac: explicitly require libdrm for dri classic drivers.

On Thu 02 Feb 2017, Dave Airlie wrote: > From: Dave Airlie > > Although this might come from somewhere else require it explicitly. > > Signed-off-by: Dave Airlie > --- > configure.ac | 5 + > 1 file changed, 5 insertions(+) R

Re: [Mesa-dev] [PATCH 1/2] configure: libdrm is a single package, no split different versions

ecific bit and not the generic bit of libdrm as well. Fix > this. > > Signed-off-by: Ilia Mirkin Sorry for all the mess I made by bumping LIBDRM_REQUIRED. At least something good (autoconf fixes) is resulting from the mess. This patch handles the requirements the way I think they should w

Re: [Mesa-dev] [PATCH] configure.ac: explicitly require libdrm for dri classic drivers.

On Thu 02 Feb 2017, Chad Versace wrote: > On Thu 02 Feb 2017, Dave Airlie wrote: > > From: Dave Airlie > > > > Although this might come from somewhere else require it explicitly. > > > > Signed-off-by: Dave Airlie > > --- > > configure.a

Re: [Mesa-dev] [PATCH] configure.ac: describe what all the LIBDRM_*REQUIRED macros mean

On Thu 02 Feb 2017, Emil Velikov wrote: > From: Emil Velikov > > They are versions of the respective libdrm package. They are _not_ the > version of libdrm[.so] required for driver X. > > Doing the latter will lead to combinatoric explosion and in all fairness > things will likely be broken most

Re: [Mesa-dev] [PATCH] configure: Only require libdrm 2.4.75 for intel.

On Thu 02 Feb 2017, Kenneth Graunke wrote: > On Thursday, February 2, 2017 7:35:20 AM PST Chad Versace wrote: > > On Thu 02 Feb 2017, Dave Airlie wrote: > > > On 2 February 2017 at 13:09, Emil Velikov > > > wrote: > > > > On 2 February 2017 at 02:58, Michel

Re: [Mesa-dev] [PATCH 2/5] intel/isl: Add a supports_ccs_d helper

On Thu 02 Feb 2017, Anuj Phogat wrote: > On Thu, Feb 2, 2017 at 9:03 AM, Jason Ekstrand wrote: > > On Wed, Feb 1, 2017 at 4:07 PM, Anuj Phogat wrote: > >> > >> On Wed, Feb 1, 2017 at 2:40 PM, Jason Ekstrand > >> wrote: > >> > +/** > >> > + * Returns true if the given format can support single-s

Re: [Mesa-dev] [PATCH 1/5] intel/isl: Rename supports_lossless_compression to supports_ccs_e

2 +- > src/intel/vulkan/genX_cmd_buffer.c | 3 +-- > src/mesa/drivers/dri/i965/brw_context.c | 3 +-- > src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 3 +-- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c| 3 +-- > 7 files changed, 11 insertions(

Re: [Mesa-dev] [PATCH 3/5] intel/isl: Add a formats_are_ccs_e_compatible helper

format_layout *fmtl2 = isl_format_get_layout(format2); > + > + /* The compression used by CCS is not dependent on the actual data > encoding > +* of the format but only depends on the bit-layout of the channels. > +*/ I would rephrase the comment to say &qu

Re: [Mesa-dev] [PATCH 4/5] intel/isl: Assert that we don't use CCS for storage images

> 1 file changed, 6 insertions(+) Patch is Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 5/5] anv: Remove the finishme for CCS_E with storage images

On Wed 01 Feb 2017, Jason Ekstrand wrote: > The data port can't handle CCS at all so replace the finishme with > better comments. > --- > src/intel/vulkan/anv_image.c | 21 +++-- > 1 file changed, 7 insertions(+), 14 deletions(-) Patch is Revie

Re: [Mesa-dev] [PATCH 2/5] intel/isl: Add a supports_ccs_d helper

On Thu 02 Feb 2017, Jason Ekstrand wrote: > On Thu, Feb 2, 2017 at 10:13 AM, Chad Versace > wrote: > > > On Thu 02 Feb 2017, Anuj Phogat wrote: > > > On Thu, Feb 2, 2017 at 9:03 AM, Jason Ekstrand > > wrote: > > > > On Wed, Feb 1, 2017 at 4:07 PM, An

Re: [Mesa-dev] [PATCH] intel/isl: Add a better comment for format_supports_ccs_e

bool > isl_format_supports_ccs_e(const struct gen_device_info *devinfo, >enum isl_format format) Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] mesa: Don't crash when destroying contexts created with no visual.

mediately destroys it.  The drawbuffer is > > never > > set up, so we can't dereference it asking if it's double buffered, or > > we'll crash on a null pointer dereference. > > > > Just bail early. Reviewed-by: Chad Versace Also, Mesa supports EGL_KHR_no

Re: [Mesa-dev] [PATCH 1/5] configure.ac: list all the dri-drivers in the help string

rly what's > Opening parenthesis? ^ > > Otherwise, LGTM. > > Reviewed-by: Andres Gomez Same here. Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 5/5] travis: use both cores for make/make check

On Thu 02 Feb 2017, Emil Velikov wrote: > On 2 February 2017 at 01:27, Eric Anholt wrote: > > Emil Velikov writes: > > > >> From: Emil Velikov > >> > >> The instance offers 2 cores, so use them to speed things up. > >> > >> Signed-off-by: Emil Velikov > > > > They don't just set MAKEFLAGS in th

Re: [Mesa-dev] [PATCH] configure: add blurb about what the LIBDRM_*_REQUIRED stuff means

On Tue 07 Feb 2017, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > Reviewed-by: Emil Velikov > --- > configure.ac | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) Reviewed-by: Chad Versace ___ mesa-dev mailin

Re: [Mesa-dev] [PATCH 1/2] util: Add utility build-id code.

On Tue 14 Feb 2017, Matt Turner wrote: > On Tue, Feb 14, 2017 at 11:21 AM, Matt Turner wrote: > > On Tue, Feb 14, 2017 at 11:18 AM, Matt Turner wrote: > >> On Tue, Feb 14, 2017 at 10:59 AM, Jason Ekstrand > >> wrote: > >>> I'm not sure how I feel about the silent fall-backs. At least in the >

Re: [Mesa-dev] [PATCH 1/2] util: Add utility build-id code.

On Tue 14 Feb 2017, Matt Turner wrote: > Provides the ability to read the .note.gnu.build-id section of ELF > binaries, which is inserted by the --build-id=... flag to ld. Heh. Sunday night I wrote a prototype of this myself. I'm strongly in favor of basing Vulkan unique id's on the ELF build-id i

Re: [Mesa-dev] [PATCH 1/2] util: Add utility build-id code.

On Tue 14 Feb 2017, Matt Turner wrote: > Provides the ability to read the .note.gnu.build-id section of ELF > binaries, which is inserted by the --build-id=... flag to ld. > --- > configure.ac | 2 + > src/util/Makefile.sources | 2 + > src/util/build_id.c | 109 > +

Re: [Mesa-dev] [PATCH 2/2] anv: Use build-id for pipeline cache UUID.

On Tue 14 Feb 2017, Matt Turner wrote: > static bool > -anv_get_function_timestamp(void *ptr, uint32_t* timestamp) > +anv_device_get_cache_uuid(void *uuid) > { > - Dl_info info; > - struct stat st; > - if (!dladdr(ptr, &info) || !info.dli_fname) > + const struct note *note = build_id_fi

Re: [Mesa-dev] [PATCH 2/2] anv: Use build-id for pipeline cache UUID.

On Tue 14 Feb 2017, Kenneth Graunke wrote: > On Tuesday, February 14, 2017 12:38:45 PM PST Chad Versace wrote: > > On Tue 14 Feb 2017, Matt Turner wrote: > > > > > > > static bool > > > -anv_get_function_timestamp(void *ptr, uint32_t* timestamp) >

  1   2   3   4   5   6   7   8   9   10   >