[Mesa-dev] [PATCH] nir: delete magic number

2017-02-08 Thread Elie Tournier
Explaining what is the "26" for. PS: I don't have git rights. Can you push this patch for me? Signed-off-by: Elie Tournier --- src/compiler/nir/nir_opt_loop_unroll.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/compiler/nir/nir_opt_loop_unroll.c

[Mesa-dev] [PATCH v2] nir: delete magic number

2017-02-08 Thread Elie Tournier
Signed-off-by: Elie Tournier --- src/compiler/nir/nir_opt_loop_unroll.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/compiler/nir/nir_opt_loop_unroll.c b/src/compiler/nir/nir_opt_loop_unroll.c index 37cbced43d..035a030239 100644 --- a/src/compiler/nir

Re: [Mesa-dev] [PATCH] glsl/tests: Add UINT64 and INT64 types

2017-02-13 Thread Elie Tournier
Seems good to me. Reviewed-by: Elie Tournier On Sat, Feb 11, 2017 at 05:31:09PM -0500, Rhys Kidd wrote: > glsl/tests/uniform_initializer_utils.cpp:83:14: warning: enumeration value > ‘GLSL_TYPE_UINT64’ not handled in switch [-Wswitch] >switch (type-&

[Mesa-dev] [PATCH] nir: Delete unused arg in get_iteration

2017-02-21 Thread Elie Tournier
nir_const_value is not needed in get_iteration Signed-off-by: Elie Tournier --- I don't have the git access. Please push it for me. BR, Elie --- src/compiler/nir/nir_loop_analyze.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/compiler/nir/nir_loop_analyze.c

[Mesa-dev] [RFC] nir: Improve induction variables detection

2017-02-24 Thread Elie Tournier
r_loop_variable *def_outside_loop" by "nir_basic_indiction_var"? Comments are welcome. The goal is to implement a strength reduction algo. Signed-off-by: Elie Tournier --- src/compiler/nir/nir_loop_analyze.c | 46 - 1 file changed, 45 insertions(+), 1

Re: [Mesa-dev] [PATCH] nir: Delete unused arg in get_iteration

2017-02-27 Thread Elie Tournier
Some1 to review this patch? On 21/02/17 16:15, Elie Tournier wrote: nir_const_value is not needed in get_iteration Oops typo: nir_alu_instr is not needed in get_iteration Signed-off-by: Elie Tournier --- I don't have the git access. Please push it for me. BR, Elie --- src/compile

Re: [Mesa-dev] Thoughts on fp64 for GLES?

2019-01-29 Thread Elie Tournier
On Fri, Jan 25, 2019 at 02:15:25PM -0600, Jason Ekstrand wrote: > On Fri, Jan 25, 2019 at 1:53 PM Stéphane Marchesin < > stephane.marche...@gmail.com> wrote: > > > On Fri, Jan 25, 2019 at 2:25 AM Gert Wollny wrote: > > > > > > Am Donnerstag, den 24.01.2019, 22:25 -0800 schrieb Stéphane Marchesin:

Re: [Mesa-dev] Thoughts on fp64 for GLES?

2019-02-13 Thread Elie Tournier
On Fri, Jan 25, 2019 at 11:52:56AM -0800, Stéphane Marchesin wrote: > On Fri, Jan 25, 2019 at 2:25 AM Gert Wollny wrote: > > > > Am Donnerstag, den 24.01.2019, 22:25 -0800 schrieb Stéphane Marchesin: > > > > > > Yes, it's for running virgl on top of GLES. To emulate fp64 in GL on > > > the guest s

Re: [Mesa-dev] Thoughts on fp64 for GLES?

2019-02-13 Thread Elie Tournier
On Wednesday, 13 February 2019, Ilia Mirkin wrote: > On Wed, Feb 13, 2019 at 12:47 PM Elie Tournier > wrote: > > > > On Fri, Jan 25, 2019 at 11:52:56AM -0800, Stéphane Marchesin wrote: > > > On Fri, Jan 25, 2019 at 2:25 AM Gert Wollny > wrote: > > > >

Re: [Mesa-dev] Thoughts on fp64 for GLES?

2019-02-13 Thread Elie Tournier
On Wednesday, 13 February 2019, Ilia Mirkin wrote: > On Wed, Feb 13, 2019 at 1:29 PM Elie Tournier > wrote: > > > > > > > > On Wednesday, 13 February 2019, Ilia Mirkin > wrote: > >> > >> On Wed, Feb 13, 2019 at 12:47 PM Elie Tournier > w

Re: [Mesa-dev] Thoughts on fp64 for GLES?

2019-02-13 Thread Elie Tournier
On Wednesday, 13 February 2019, Stéphane Marchesin < stephane.marche...@gmail.com> wrote: > On Wed, Feb 13, 2019 at 10:29 AM Elie Tournier > wrote: > > > > > > > > On Wednesday, 13 February 2019, Ilia Mirkin > wrote: > >> > >>

Re: [Mesa-dev] [PATCH] nir/algebraic: Replace a-fract(a) with floor(a)

2019-02-23 Thread Elie Tournier
That make me think that I have some algebraic patches too. Reviewed-by: Elie Tournier On Saturday, 23 February 2019, Ian Romanick wrote: > From: Ian Romanick > > I noticed this while looking at a shader that was affected by Tim's > "more loop unrolling" series.

[Mesa-dev] [PATCH] doxygen: update glsl link

2016-04-04 Thread Elie TOURNIER
--- doxygen/glsl.doxy | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/doxygen/glsl.doxy b/doxygen/glsl.doxy index 9915ba2..0f4c822 100644 --- a/doxygen/glsl.doxy +++ b/doxygen/glsl.doxy @@ -9,11 +9,10 @@ PROJECT_NAME = "Mesa GLSL module" #-

[Mesa-dev] [PATCH v2] doxygen: update glsl link

2016-04-07 Thread Elie TOURNIER
Signed-off-by: Elie TOURNIER --- doxygen/glsl.doxy | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/doxygen/glsl.doxy b/doxygen/glsl.doxy index 9915ba2..ef71a4a 100644 --- a/doxygen/glsl.doxy +++ b/doxygen/glsl.doxy @@ -9,11 +9,12 @@ PROJECT_NAME = "

[Mesa-dev] [PATCH] doxygen: Generate Doxygen for NIR

2016-04-09 Thread Elie TOURNIER
Now, one can do the following to generate and read the nir Doxygen: cd $MESA_TOP/doxygen make firefox nir/index.html Signed-off-by: Elie TOURNIER --- doxygen/.gitignore | 1 + doxygen/Makefile| 3 ++- doxygen/header.html | 1 + doxygen/nir.doxy| 50

[Mesa-dev] [PATH v2] doxygen: Generate Doxygen for NIR

2016-04-09 Thread Elie TOURNIER
Now, one can do the following to generate and read the nir Doxygen: cd $MESA_TOP/doxygen make firefox nir/index.html Update v2: Correct TAGFILES in nir.doxy Signed-off-by: Elie TOURNIER --- doxygen/.gitignore | 1 + doxygen/Makefile| 3 ++- doxygen/header.html | 1 + doxygen/nir.doxy

[Mesa-dev] [PATCH] Update Doxygen for Windows users

2016-04-19 Thread Elie TOURNIER
Now Windows users have the same doxygen files than *nix users Not tested (I don't have a windows) Signed-off-by: Elie TOURNIER --- doxygen/doxy.bat | 7 +++ 1 file changed, 7 insertions(+) diff --git a/doxygen/doxy.bat b/doxygen/doxy.bat index e566ca3..408964e 100644 --- a/doxygen/dox

[Mesa-dev] [PATCH] egl: add gitignore

2017-04-21 Thread Elie Tournier
Since commit ce562f9e3fa, two new files are generated. We don't want to track them. Signed-off-by: Elie Tournier --- src/egl/.gitignore | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 src/egl/.gitignore diff --git a/src/egl/.gitignore b/src/egl/.gitignore new file mode 100644

Re: [Mesa-dev] [PATCH 3/8] nir: Undo possible damage caused by rearranging or-compounded float compares

2018-01-18 Thread Elie Tournier
On Tue, Jan 16, 2018 at 04:44:42PM -0800, Ian Romanick wrote: > From: Ian Romanick > > shader-db results: > > Skylake and Broadwell had similar results (Skylake shown) > total instructions in shared programs: 14526033 -> 14526021 (<.01%) > instructions in affected programs: 1450 -> 1438 (-0.83%)

Re: [Mesa-dev] [PATCH 0/8] Algebraic optimizations

2018-01-18 Thread Elie Tournier
comment on patch 3. Otherwise, the series is Reviewed-by: Elie Tournier > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev ___ m

[Mesa-dev] [PATCH] meson: fix typo in isl

2017-10-12 Thread Elie Tournier
Signed-off-by: Elie Tournier --- src/intel/isl/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/isl/meson.build b/src/intel/isl/meson.build index 789175e256..54024b4d11 100644 --- a/src/intel/isl/meson.build +++ b/src/intel/isl/meson.build @@ -101,5

[Mesa-dev] [PATCH] docs: Fix GLSL compiler link

2017-01-12 Thread Elie Tournier
The doc wasn't update since we moved the glsl compiler to src/compiler/glsl. I also updated the description of the standalone compiler. Signed-off-by: Elie Tournier --- docs/shading.html | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/docs/shading.html b

[Mesa-dev] [PATCH] shader-db: Update the README

2017-01-13 Thread Elie Tournier
Use the binary to run shader-db instead of run.py Signed-off-by: Elie Tournier --- README | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/README b/README index 5e9bb2d..6f6a7e2 100644 --- a/README +++ b/README @@ -1,6 +1,6 @@ === What === -A giant pile

[Mesa-dev] [PATCH] nir: add min/max optimisation

2017-01-18 Thread Elie Tournier
(-1.61%) helped: 4 HURT: 0 total cycles in shared programs: 252054838 -> 252054806 (-0.00%) cycles in affected programs: 504 -> 472 (-6.35%) helped: 2 HURT: 0 Signed-off-by: Elie Tournier --- src/compiler/nir/nir_opt_algebraic.py | 12 1 file changed, 12 insertions(+) diff

[Mesa-dev] [PATCH v2] docs: Fix GLSL compiler link

2017-01-18 Thread Elie Tournier
on to the command line exemple. Signed-off-by: Elie Tournier --- docs/shading.html | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/docs/shading.html b/docs/shading.html index cf989ce902..b0ed249e1d 100644 --- a/docs/shading.html +++ b/docs/shading.html @@ -172,7 +

[Mesa-dev] [RFC 00/10] WIP: NIR soft fp64 for ARB_gpu_shader_fp64 on gen6

2017-04-12 Thread Elie Tournier
m/Hopetech/mesa/tree/nir_arb_gpu_shader_fp64 Elie Tournier (10): nir/lower_double_ops: lower abs() nir/lower_double_ops: lower neg() nir/lower_double_ops: lower sign() nir/lower_double_ops: lower eq() nir/lower_double_ops: lower lt() nir/lower_double_ops: lower mul() nir/lower_double_op

[Mesa-dev] [RFC 05/10] nir/lower_double_ops: lower lt()

2017-04-12 Thread Elie Tournier
Signed-off-by: Elie Tournier --- src/compiler/nir/nir.h | 3 +- src/compiler/nir/nir_lower_double_ops.c | 68 + src/intel/compiler/brw_nir.c| 3 +- 3 files changed, 72 insertions(+), 2 deletions(-) diff --git a/src/compiler/nir

[Mesa-dev] [RFC 01/10] nir/lower_double_ops: lower abs()

2017-04-12 Thread Elie Tournier
Signed-off-by: Elie Tournier --- src/compiler/nir/nir.h | 3 ++- src/compiler/nir/nir_lower_double_ops.c | 20 src/intel/compiler/brw_nir.c| 3 ++- 3 files changed, 24 insertions(+), 2 deletions(-) diff --git a/src/compiler/nir/nir.h b/src

[Mesa-dev] [RFC 06/10] nir/lower_double_ops: lower mul()

2017-04-12 Thread Elie Tournier
Signed-off-by: Elie Tournier --- src/compiler/nir/nir.h | 3 +- src/compiler/nir/nir_lower_double_ops.c | 749 src/intel/compiler/brw_nir.c| 3 +- 3 files changed, 753 insertions(+), 2 deletions(-) diff --git a/src/compiler/nir

[Mesa-dev] [RFC 02/10] nir/lower_double_ops: lower neg()

2017-04-12 Thread Elie Tournier
Signed-off-by: Elie Tournier --- src/compiler/nir/nir.h | 3 ++- src/compiler/nir/nir_lower_double_ops.c | 45 + src/intel/compiler/brw_nir.c| 3 ++- 3 files changed, 49 insertions(+), 2 deletions(-) diff --git a/src/compiler/nir

[Mesa-dev] [RFC 04/10] nir/lower_double_ops: lower eq()

2017-04-12 Thread Elie Tournier
Signed-off-by: Elie Tournier --- src/compiler/nir/nir.h | 3 ++- src/compiler/nir/nir_lower_double_ops.c | 43 + src/intel/compiler/brw_nir.c| 3 ++- 3 files changed, 47 insertions(+), 2 deletions(-) diff --git a/src/compiler/nir

[Mesa-dev] [RFC 03/10] nir/lower_double_ops: lower sign()

2017-04-12 Thread Elie Tournier
Signed-off-by: Elie Tournier --- src/compiler/nir/nir.h | 3 ++- src/compiler/nir/nir_lower_double_ops.c | 33 + src/intel/compiler/brw_nir.c| 3 ++- 3 files changed, 37 insertions(+), 2 deletions(-) diff --git a/src/compiler/nir

[Mesa-dev] [RFC 07/10] nir/lower_double_ops: lower div()

2017-04-12 Thread Elie Tournier
Signed-off-by: Elie Tournier --- src/compiler/nir/nir.h | 3 +- src/compiler/nir/nir_lower_double_ops.c | 138 src/intel/compiler/brw_nir.c| 3 +- 3 files changed, 142 insertions(+), 2 deletions(-) diff --git a/src/compiler/nir

[Mesa-dev] [RFC 10/10] mesa: enable ARB_gpu_shader_fp64 on Gen6

2017-04-12 Thread Elie Tournier
Signed-off-by: Elie Tournier --- src/mesa/drivers/dri/i965/intel_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/dri/i965/intel_extensions.c index 30f2c37695..fce377eed0 100644 --- a/src/mesa/drivers/dri/i965

[Mesa-dev] [RFC 08/10] nir/lower_double_ops: lower add()

2017-04-12 Thread Elie Tournier
Signed-off-by: Elie Tournier --- src/compiler/nir/nir.h | 3 +- src/compiler/nir/nir_lower_double_ops.c | 593 src/intel/compiler/brw_nir.c| 3 +- 3 files changed, 597 insertions(+), 2 deletions(-) diff --git a/src/compiler/nir

[Mesa-dev] [RFC 09/10] nir/lower_double_ops: lower sub()

2017-04-12 Thread Elie Tournier
Signed-off-by: Elie Tournier --- src/compiler/nir/nir.h | 3 ++- src/compiler/nir/nir_lower_double_ops.c | 24 src/intel/compiler/brw_nir.c| 3 ++- 3 files changed, 28 insertions(+), 2 deletions(-) diff --git a/src/compiler/nir/nir.h b/src

Re: [Mesa-dev] [PATCH] virgl: add ARB_tessellation_shader support.

2018-06-12 Thread Elie Tournier
On Fri, Jun 08, 2018 at 03:15:36PM +1000, Dave Airlie wrote: > From: Dave Airlie > > This should add all the pieces to enable tess shaders on virgl. Hi I think that we also need to add the following code: --- a/src/gallium/drivers/virgl/virgl_winsys.h +++ b/src/gallium/drivers/virgl/virgl_wins

Re: [Mesa-dev] [PATCH] virgl: add ARB_tessellation_shader support. (v2)

2018-06-13 Thread Elie Tournier
gt; tess gets enabled from v1 caps but v2 caps aren't in place. (Elie) Reviewed-by: Elie Tournier > --- > src/gallium/auxiliary/tgsi/tgsi_transform.c | 4 -- > src/gallium/drivers/virgl/virgl_context.c | 69 > + > src/gallium/drivers/virgl/virgl_

Re: [Mesa-dev] [PATCH] Plumb invariant output attrib thru TGSI

2018-06-18 Thread Elie Tournier
added to the ops). But virgl can't express precise ops (only > invariant and precise declarations) only declarations. > > Going to do some testing on this patch soon. > > Cheers, Jakob. Supposing that it doesn't brake any gallium driver. Maybe Marek can confirm. I only test o

Re: [Mesa-dev] [virglrenderer-devel] [PATCH] virgl: set texture buffer offset alignment to disable ARB_texture_buffer_range.

2018-05-18 Thread Elie Tournier
t tests skip now. > > Fixes: fe0647df5a7 (virgl: add offset alignment values to to v2 caps struct) Acked-by: Elie Tournier > --- > src/gallium/drivers/virgl/virgl_winsys.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/vi

Re: [Mesa-dev] [PATCH 07/14] st/mesa: set ctx->Const.SubPixelBits

2018-08-28 Thread Elie Tournier
On Tue, Aug 28, 2018 at 12:40:25PM +0100, Jakob Bornecrantz wrote: > On Thu, Aug 9, 2018 at 12:57 AM Marek Olšák wrote: > > > > From: Marek Olšák > > This patch causes regressions in dEQP[1] on virgl running on a > radeonSI device. Not a lot of drivers set > PIPE_CAP_VIEWPORT_SUBPIXEL_BITS but S

[Mesa-dev] [PATCH] gallium: Correctly handle no config context creation

2018-09-05 Thread Elie Tournier
This patch fixes the following Piglit test: spec@egl_mesa_configless_context@basic It also fixes few test in a virgl guest. Suggested-by: Emil Velikov Signed-off-by: Elie Tournier --- I cc'ed some Gallium driver people. Can you check if this patch doesn't introduce any bug on your HW?

[Mesa-dev] [PATCH v2] gallium: Correctly handle no config context creation

2018-09-06 Thread Elie Tournier
This patch fixes the following Piglit test: spec@egl_mesa_configless_context@basic It also fixes few test in a virgl guest. v2: Evaluate the value of no_config (Ilia) Suggested-by: Emil Velikov Signed-off-by: Elie Tournier --- src/gallium/include/state_tracker/st_api.h | 2 ++ src/gallium

Re: [Mesa-dev] [PATCH v2] gallium: Correctly handle no config context creation

2018-09-08 Thread Elie Tournier
If you don't mind, can you please push this patch for me? I don't have git access. Thanks a lot, Elie On Fri, 7 Sep 2018 at 22:49, Marek Olšák wrote: > > Reviewed-by: Marek Olšák > > Marek > > On Thu, Sep 6, 2018 at 5:46 AM, Elie Tournier wrote: > > This pat

Re: [Mesa-dev] [PATCH] gallium: Fix uninitialized variable warning in compute test.

2018-11-27 Thread Elie Tournier
On Mon, Nov 26, 2018 at 01:13:16PM -0800, Eric Anholt wrote: > The compiler doesn't know that ny != 0, so x might be uninitialized for > the printf at the end. Reviewed-by: Elie Tournier > --- > src/gallium/tests/trivial/compute.c | 2 +- > 1 file changed, 1 inse

Re: [Mesa-dev] [PATCH 04/28] nir: add support for flushing to zero denorm constants

2018-12-05 Thread Elie Tournier
On Wed, Dec 05, 2018 at 04:55:19PM +0100, Samuel Iglesias Gonsálvez wrote: > Signed-off-by: Samuel Iglesias Gonsálvez > --- > src/compiler/nir/nir_opt_constant_folding.c | 74 +++-- > 1 file changed, 68 insertions(+), 6 deletions(-) > > diff --git a/src/compiler/nir/nir_opt_const

Re: [Mesa-dev] [PATCH 10/12] virgl: modify how we handle GL_MAP_FLUSH_EXPLICIT_BIT

2018-12-10 Thread Elie Tournier
On Thu, Dec 06, 2018 at 05:20:42PM -0800, Gurchetan Singh wrote: > Previously, we ignored the the glUnmap(..) operation and > flushed before we flush the cbuf. Now, let's just flush > the data when we unmap. > > Neither method is optimal, for example: > > glMapBufferRange(.., 0, 100, GL_MAP_FLUS

Re: [Mesa-dev] [PATCH 10/12] virgl: modify how we handle GL_MAP_FLUSH_EXPLICIT_BIT

2018-12-11 Thread Elie Tournier
ressions tests. They are a bit slow on my system. So for now, the series is: Acked-by: Elie Tournier > --- > src/gallium/drivers/virgl/virgl_buffer.c | 46 +++--- > src/gallium/drivers/virgl/virgl_context.c | 34 +--- > src/gallium/drivers/virgl/virgl_cont

Re: [Mesa-dev] PSA: Please send MRs to the mailing list

2018-12-18 Thread Elie Tournier
On Tuesday, 18 December 2018, Erik Faye-Lund wrote: > On Mon, 2018-12-17 at 16:13 -0600, Jason Ekstrand wrote: > > On Mon, Dec 17, 2018 at 2:13 PM Jason Ekstrand > > wrote: > > > On Mon, Dec 17, 2018 at 1:53 PM Eric Anholt > > > wrote: > > > > Jason Ekstrand writes: > > > > > > > > > I don't k

Re: [Mesa-dev] [PATCH] r600: implement callstack workaround for evergreen.

2018-03-09 Thread Elie Tournier
375] skip: 4, pass: 1368, fail: 3 So thanks a lot. > > This fixes all the glitches and inconsistencies I've seen with them > > Signed-off-by: Dave Airlie Tested-by: Elie Tournier > --- > src/gallium/drivers/r600/r600_shader.c | 39 > +++---

Re: [Mesa-dev] soft fp64 support - main body (glsl/gallium)

2018-03-13 Thread Elie Tournier
On Tue, Mar 13, 2018 at 02:28:04PM +1000, Dave Airlie wrote: > On 13 March 2018 at 14:24, Dave Airlie wrote: > > This is the main code for the soft fp64 work. It's mostly Elie's > > code with a bunch of changes by me. > > > > All the patches are in my tree here, along with some other bits: > http

Re: [Mesa-dev] soft fp64 support - main body (glsl/gallium)

2018-03-14 Thread Elie Tournier
On Tue, Mar 13, 2018 at 04:54:27PM -0700, Matt Turner wrote: > On Mon, Mar 12, 2018 at 9:24 PM, Dave Airlie wrote: > > This is the main code for the soft fp64 work. It's mostly Elie's > > code with a bunch of changes by me. > > > > This patchset has all the glsl lowering code. (using float64.glsl,

[Mesa-dev] [PATCH] mesa: Correctly print glTexImage dimensions

2018-01-25 Thread Elie Tournier
texture_format_error_check_gles() displays error like "glTexImage%dD". This patch just replace the %d by the correct dimension. Signed-off-by: Elie Tournier --- src/mesa/main/teximage.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/mesa/main/te

Re: [Mesa-dev] [PATCH] mesa: Correctly print glTexImage dimensions

2018-01-29 Thread Elie Tournier
On Fri, Jan 26, 2018 at 02:34:03PM +0200, Tapani Pälli wrote: > Hi; > > On 01/25/2018 05:18 PM, Elie Tournier wrote: > > texture_format_error_check_gles() displays error like "glTexImage%dD". > > This patch just replace the %d by the correct dimension. > &

Re: [Mesa-dev] [PATCH] mesa: Correctly print glTexImage dimensions

2018-01-29 Thread Elie Tournier
On Mon, Jan 29, 2018 at 01:24:42PM +0200, Tapani Pälli wrote: > > > On 01/29/2018 12:05 PM, Elie Tournier wrote: > > On Fri, Jan 26, 2018 at 02:34:03PM +0200, Tapani Pälli wrote: > > > Hi; > > > > > > On 01/25/2018 05:18 PM, Elie Tournier wrot

Re: [Mesa-dev] [PATCH 2/9] glsl: add u64->fp64 and i64->fp64 builtins.

2018-02-01 Thread Elie Tournier
uld make this project even bigger. At least for me. ;) > > Dylan > > Quoting Dave Airlie (2018-01-31 19:33:51) > > From: Elie Tournier > > > > This adds the first two fp64 builtins. > > They are for int/uint to fp64 conversions. > > > >

Re: [Mesa-dev] [PATCH] i965: remove unused brw_nir_lower_cs_shared()

2018-02-05 Thread Elie Tournier
On Mon, Feb 05, 2018 at 09:22:15AM +1100, Timothy Arceri wrote: > This has been unused since 8761a04d0d93. Reviewed-by: Elie Tournier > --- > src/intel/compiler/brw_nir.c | 8 > src/intel/compiler/brw_nir.h | 1 - > 2 files changed, 9 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH mesa] r200: remove left over dead code

2018-02-09 Thread Elie Tournier
::LogicOpcode" > Signed-off-by: Eric Engestrom Reviewed-by: Elie Tournier > --- > src/mesa/drivers/dri/r200/r200_state.c | 20 > 1 file changed, 20 deletions(-) > > diff --git a/src/mesa/drivers/dri/r200/r200_state.c > b/src/mesa/drivers/d

Re: [Mesa-dev] [PATCH 01/17] r200: Remove dead rop table

2018-02-11 Thread Elie Tournier
Eric Engestrom was faster. ;) https://patchwork.freedesktop.org/patch/203691/ On 10 February 2018 at 16:32, Eric Anholt wrote: > Fixes: 0aaa27f29187 ("mesa: Pass the translated color logic op > dd_function_table::LogicOpcode") > Cc: Ian Romanick > --- > src/mesa/drivers/dri/r200/r200_state.c |

[Mesa-dev] [RFC 01/11] glsl: Add "built-in" function to do abs(fp64)

2017-03-03 Thread Elie Tournier
Signed-off-by: Elie Tournier --- src/compiler/Makefile.sources | 1 + src/compiler/glsl/builtin_float64.h | 19 +++ src/compiler/glsl/builtin_functions.cpp | 4 src/compiler/glsl/builtin_functions.h | 3 +++ src/compiler/glsl/float64.glsl | 28

[Mesa-dev] [RFC 05/11] glsl: Add "built-in" functions to do lt(fp64, fp64)

2017-03-03 Thread Elie Tournier
Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 161 src/compiler/glsl/builtin_functions.cpp | 4 + src/compiler/glsl/builtin_functions.h | 3 + src/compiler/glsl/float64.glsl | 45 + 4 files changed, 213

[Mesa-dev] [RFC 00/11] GL_ARB_gpu_shader_fp64

2017-03-03 Thread Elie Tournier
From: Elie Tournier This series is based on Ian's work about GL_ARB_gpu_shader_int64 [1]. The goal is to expose GL_ARB_shader_fp64 to OpenGL 3.0 GPUs. Each function can be independently tested using shader_runner from piglit. The piglit files are stored on github [2]. [1]

[Mesa-dev] [RFC 09/11] glsl: Add "built-in" functions to do fp32_to_fp64(fp32)

2017-03-03 Thread Elie Tournier
Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 490 src/compiler/glsl/builtin_functions.cpp | 4 + src/compiler/glsl/builtin_functions.h | 3 + src/compiler/glsl/float64.glsl | 77 + 4 files changed, 574 insertions

[Mesa-dev] [RFC 02/11] glsl: Add "built-in" function to do neg(fp64)

2017-03-03 Thread Elie Tournier
Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 19 +++ src/compiler/glsl/builtin_functions.cpp | 4 src/compiler/glsl/builtin_functions.h | 3 +++ src/compiler/glsl/float64.glsl | 10 ++ 4 files changed, 36 insertions(+) diff

[Mesa-dev] [RFC 04/11] glsl: Add "built-in" functions to do le(fp64, fp64)

2017-03-03 Thread Elie Tournier
Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 179 src/compiler/glsl/builtin_functions.cpp | 4 + src/compiler/glsl/builtin_functions.h | 3 + src/compiler/glsl/float64.glsl | 52 ++ 4 files changed, 238

[Mesa-dev] [RFC 03/11] glsl: Add "built-in" functions to do eq(fp64, fp64)

2017-03-03 Thread Elie Tournier
Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 119 src/compiler/glsl/builtin_functions.cpp | 4 ++ src/compiler/glsl/builtin_functions.h | 3 + src/compiler/glsl/float64.glsl | 41 +++ 4 files changed, 167

[Mesa-dev] [RFC 10/11] glsl: Add "built-in" functions to do fp64_to_fp32(fp64)

2017-03-03 Thread Elie Tournier
Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 589 src/compiler/glsl/builtin_functions.cpp | 4 + src/compiler/glsl/builtin_functions.h | 3 + src/compiler/glsl/float64.glsl | 133 4 files changed, 729

[Mesa-dev] [RFC 11/11] glsl: Add fp64 functions to the parser.

2017-03-03 Thread Elie Tournier
Like we use two integers to store our fp64, the functions are available with MESA_shader_integer_functions. Signed-off-by: Elie Tournier --- src/compiler/glsl/glcpp/glcpp-parse.y | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/compiler/glsl/glcpp/glcpp-parse.y b/src

[Mesa-dev] [PATCH] glsl: Fix indent in dump code

2017-03-06 Thread Elie Tournier
From: Elie Tournier Signed-off-by: Elie Tournier --- On an other thread [1], we discovered than the GLSL compiler have some trouble to indent correctly the dump IR. I don't have git access, please push it for me. [1] https://lists.freedesktop.org/archives/mesa-dev/2017-March/146518

[Mesa-dev] [PATCH] glsl: remove unused file

2017-03-09 Thread Elie Tournier
udivmod64 appears in src/compiler/glsl/builtin_int64.h and src/compiler/glsl/udivmod.h The second file seems unused. Fix commit 6b03b345eb64e15e577bc8b2cf04b314a4c70537 This change doesn't affect shader-db. Signed-off-by: Elie Tournier --- src/compiler/glsl/udivmod64.h

[Mesa-dev] [PATCH 04/47] glsl: Add "built-in" functions to do eq(fp64, fp64)

2017-08-23 Thread Elie Tournier
Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 128 src/compiler/glsl/builtin_functions.cpp | 4 + src/compiler/glsl/builtin_functions.h | 3 + src/compiler/glsl/float64.glsl | 46 src/compiler/glsl/glcpp

[Mesa-dev] [PATCH 02/47] glsl: Add "built-in" functions to do neg(fp64)

2017-08-23 Thread Elie Tournier
Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 72 + src/compiler/glsl/builtin_functions.cpp | 4 ++ src/compiler/glsl/builtin_functions.h | 3 ++ src/compiler/glsl/float64.glsl | 23 +++ src/compiler/glsl/glcpp

[Mesa-dev] [PATCH 03/47] glsl: Add "built-in" function to do sign(fp64)

2017-08-23 Thread Elie Tournier
Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 49 + src/compiler/glsl/builtin_functions.cpp | 4 +++ src/compiler/glsl/builtin_functions.h | 3 ++ src/compiler/glsl/float64.glsl | 12 src/compiler/glsl/glcpp/glcpp

[Mesa-dev] [PATCH 00/47] WIP: fp64 support for r600g

2017-08-23 Thread Elie Tournier
From: Elie Tournier TL;DR This series is a "status update" of my work done for adding fp64 support on r600g. One of the biggest issue is due to a lake of accuracy on the rcp implementation. Divide relay on rcp. A branch is available on https://github.com/Hopetech

[Mesa-dev] [PATCH 06/47] glsl: Add "built-in" functions to do lt(fp64, fp64)

2017-08-23 Thread Elie Tournier
Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 155 src/compiler/glsl/builtin_functions.cpp | 4 + src/compiler/glsl/builtin_functions.h | 3 + src/compiler/glsl/float64.glsl | 43 + src/compiler/glsl/glcpp

[Mesa-dev] [PATCH 01/47] glsl: Add "built-in" function to do abs(fp64)

2017-08-23 Thread Elie Tournier
Signed-off-by: Elie Tournier --- src/compiler/Makefile.sources | 1 + src/compiler/glsl/builtin_float64.h | 19 +++ src/compiler/glsl/builtin_functions.cpp | 4 src/compiler/glsl/builtin_functions.h | 3 +++ src/compiler/glsl/float64.glsl | 29

[Mesa-dev] [PATCH 05/47] glsl: Add "built-in" functions to do le(fp64, fp64)

2017-08-23 Thread Elie Tournier
Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 173 src/compiler/glsl/builtin_functions.cpp | 4 + src/compiler/glsl/builtin_functions.h | 3 + src/compiler/glsl/float64.glsl | 50 + src/compiler/glsl/glcpp

[Mesa-dev] [PATCH 14/47] glsl: Add "built-in" functions to do fp32_to_fp64(fp32)

2017-08-23 Thread Elie Tournier
Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 311 src/compiler/glsl/builtin_functions.cpp | 4 + src/compiler/glsl/builtin_functions.h | 3 + src/compiler/glsl/float64.glsl | 38 src/compiler/glsl/glcpp/glcpp

[Mesa-dev] [PATCH 09/47] glsl: Add "built-in" functions to do fp64_to_uint(fp64)

2017-08-23 Thread Elie Tournier
Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 446 src/compiler/glsl/builtin_functions.cpp | 4 + src/compiler/glsl/builtin_functions.h | 3 + src/compiler/glsl/float64.glsl | 68 + src/compiler/glsl/glcpp/glcpp

[Mesa-dev] [PATCH 18/47] glsl: Add "built-in" functions to do rcp(fp64)

2017-08-23 Thread Elie Tournier
This algorithm is not accurate. Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 1829 +++ src/compiler/glsl/builtin_functions.cpp |4 + src/compiler/glsl/builtin_functions.h |3 + src/compiler/glsl/float64.glsl | 10

[Mesa-dev] [PATCH 10/47] glsl: Add "built-in" functions to do uint_to_fp64(uint)

2017-08-23 Thread Elie Tournier
Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 259 src/compiler/glsl/builtin_functions.cpp | 4 + src/compiler/glsl/builtin_functions.h | 3 + src/compiler/glsl/float64.glsl | 26 src/compiler/glsl/glcpp/glcpp

[Mesa-dev] [PATCH 12/47] glsl: Add "built-in" functions to do int_to_fp64(int)

2017-08-23 Thread Elie Tournier
Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 334 src/compiler/glsl/builtin_functions.cpp | 4 + src/compiler/glsl/builtin_functions.h | 3 + src/compiler/glsl/float64.glsl | 23 +++ src/compiler/glsl/glcpp/glcpp

[Mesa-dev] [PATCH 16/47] glsl: Add "built-in" functions to do trunc(fp64)

2017-08-23 Thread Elie Tournier
Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 121 src/compiler/glsl/builtin_functions.cpp | 4 ++ src/compiler/glsl/builtin_functions.h | 3 + src/compiler/glsl/float64.glsl | 23 ++ src/compiler/glsl/glcpp/glcpp

[Mesa-dev] [PATCH 19/47] glsl: Add a lowering pass for 64-bit float abs()

2017-08-23 Thread Elie Tournier
Squashed with: glsl/lower_64bit: fix return type conversion (airlied) Only do conversion for the 64-bit types, add a path to do result merging without conversion. Signed-off-by: Elie Tournier --- src/compiler/Makefile.sources | 2 +- src/compiler/glsl/ir_optimization.h

[Mesa-dev] [PATCH 11/47] glsl: Add "built-in" functions to do fp64_to_int(fp64)

2017-08-23 Thread Elie Tournier
Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 284 src/compiler/glsl/builtin_functions.cpp | 4 + src/compiler/glsl/builtin_functions.h | 3 + src/compiler/glsl/float64.glsl | 45 + src/compiler/glsl/glcpp/glcpp

[Mesa-dev] [PATCH 17/47] glsl: Add "built-in" functions to do round(fp64)

2017-08-23 Thread Elie Tournier
Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 225 src/compiler/glsl/builtin_functions.cpp | 4 + src/compiler/glsl/builtin_functions.h | 3 + src/compiler/glsl/float64.glsl | 41 ++ src/compiler/glsl/glcpp/glcpp

[Mesa-dev] [PATCH 13/47] glsl: Add "built-in" functions to do fp64_to_fp32(fp64)

2017-08-23 Thread Elie Tournier
This algorithm seems to be ok on softpipe but fail the piglit test on r600g when we convert the fp64 representing the smallest fp32 into a fp32. However, the IR is the same in both case. Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 494

[Mesa-dev] [PATCH 21/47] glsl: Add a lowering pass for 64-bit float sign()

2017-08-23 Thread Elie Tournier
Signed-off-by: Elie Tournier --- src/compiler/glsl/lower_64bit.cpp | 5 - src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 3 ++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/lower_64bit.cpp b/src/compiler/glsl/lower_64bit.cpp index 91b972fe82

[Mesa-dev] [PATCH 30/47] glsl: Add a lowering pass for 64-bit float i2d()

2017-08-23 Thread Elie Tournier
Signed-off-by: Elie Tournier --- src/compiler/glsl/ir_optimization.h| 1 + src/compiler/glsl/lower_64bit.cpp | 7 +++ src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 3 ++- 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/ir_optimization.h b/src

[Mesa-dev] [PATCH 20/47] glsl: Add a lowering pass for 64-bit float neg()

2017-08-23 Thread Elie Tournier
Signed-off-by: Elie Tournier --- src/compiler/glsl/ir_optimization.h| 1 + src/compiler/glsl/lower_64bit.cpp | 7 +++ src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 3 ++- 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/ir_optimization.h b/src

[Mesa-dev] [PATCH 23/47] glsl: Add a lowering pass for 64-bit float lequal()

2017-08-23 Thread Elie Tournier
Signed-off-by: Elie Tournier --- src/compiler/glsl/ir_optimization.h| 1 + src/compiler/glsl/lower_64bit.cpp | 7 +++ src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 3 ++- 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/ir_optimization.h b/src

[Mesa-dev] [PATCH 25/47] glsl: Add a lowering pass for 64-bit float add()

2017-08-23 Thread Elie Tournier
Signed-off-by: Elie Tournier --- src/compiler/glsl/ir_optimization.h| 1 + src/compiler/glsl/lower_64bit.cpp | 7 +++ src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 3 ++- 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/ir_optimization.h b/src

[Mesa-dev] [PATCH 22/47] glsl: Add a lowering pass for 64-bit float equal()

2017-08-23 Thread Elie Tournier
Signed-off-by: Elie Tournier --- src/compiler/glsl/ir_optimization.h| 1 + src/compiler/glsl/lower_64bit.cpp | 7 +++ src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 3 ++- 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/ir_optimization.h b/src

[Mesa-dev] [PATCH 29/47] glsl: Add a lowering pass for 64-bit float d2i()

2017-08-23 Thread Elie Tournier
Signed-off-by: Elie Tournier --- src/compiler/glsl/ir_optimization.h| 1 + src/compiler/glsl/lower_64bit.cpp | 7 +++ src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 3 ++- 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/ir_optimization.h b/src

[Mesa-dev] [PATCH 28/47] glsl: Add a lowering pass for 64-bit float u2d()

2017-08-23 Thread Elie Tournier
Handle non 64bit sources (airlied) Signed-off-by: Elie Tournier --- src/compiler/glsl/ir_optimization.h| 1 + src/compiler/glsl/lower_64bit.cpp | 49 -- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 3 +- 3 files changed, 43 insertions(+), 10

[Mesa-dev] [PATCH 33/47] glsl: Add a lowering pass for 64-bit float sqrt()

2017-08-23 Thread Elie Tournier
Signed-off-by: Elie Tournier --- src/compiler/glsl/ir_optimization.h| 1 + src/compiler/glsl/lower_64bit.cpp | 7 +++ src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 3 ++- 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/ir_optimization.h b/src

[Mesa-dev] [PATCH 24/47] glsl: Add a lowering pass for 64-bit float less()

2017-08-23 Thread Elie Tournier
Signed-off-by: Elie Tournier --- src/compiler/glsl/ir_optimization.h| 1 + src/compiler/glsl/lower_64bit.cpp | 7 +++ src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 3 ++- 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/ir_optimization.h b/src

[Mesa-dev] [PATCH 37/47] glsl/lower_64bit: handle any/all operations

2017-08-23 Thread Elie Tournier
From: Dave Airlie This just splits them out and combines the results. Signed-off-by: Dave Airlie --- src/compiler/glsl/lower_64bit.cpp | 61 ++- 1 file changed, 60 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/lower_64bit.cpp b/src/compiler/g

[Mesa-dev] [PATCH 39/47] glsl: Add a lowering pass for 64-bit float gequal()

2017-08-23 Thread Elie Tournier
Signed-off-by: Elie Tournier --- src/compiler/glsl/lower_64bit.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/lower_64bit.cpp b/src/compiler/glsl/lower_64bit.cpp index 4978759eb9..07d39de79d 100644 --- a/src/compiler/glsl/lower_64bit.cpp +++ b/src

[Mesa-dev] [PATCH 38/47] glsl/lower_64bit: lower d2b using comparison

2017-08-23 Thread Elie Tournier
From: Dave Airlie This just does a compare to 0 and inverts the result to lower d2b. Not 100% sure this is always correct, but it passes piglit --- src/compiler/glsl/lower_64bit.cpp | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/lower

  1   2   >