Hi,
Please find attached two patches. The first allows mesa-demos to build against
EGL implementations that don't support EGL_MESA_screen_surface. The second
patch brings some of the code that uses the EGL_MESA_screen_surface extension
into line with similar code.
Thanks
Frank
Hi,
Please find attached a patch that allows xeglgears to link against EGL
implementations that don't export extension functions (this is implementation
dependent).
Thanks
Frank
0001-xeglgears-Make-EGL_KHR_image-usage-portable.patch
Description:
-by: Frank Binns frank.bi...@imgtec.com
---
src/glx/dri3_glx.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/glx/dri3_glx.c b/src/glx/dri3_glx.c
index b7dac8e..e385723 100644
--- a/src/glx/dri3_glx.c
+++ b/src/glx/dri3_glx.c
@@ -1321,6 +1321,7 @@ dri3_swap_buffers
On 24/04/14 13:19, Frank Binns wrote:
Typically we want swaps to occur during vertical blank to avoid
tearing. However, when the swap interval is 0 we want to go
as quickly as possible even if this results in tearing.
Indicate to the X server that it should attempt to do an
asynchronise swap
Hi,
I sent exactly the same patch back in April. Despite getting a review-by
it was never merged. See:
http://lists.freedesktop.org/archives/mesa-dev/2014-April/058347.html
http://lists.freedesktop.org/archives/mesa-dev/2014-May/060432.html
Thanks
Frank
On 25/11/14 03:00, Mario Kleiner wrote:
On 30/11/14 11:51, Mario Kleiner wrote:
On 11/25/2014 09:31 AM, Frank Binns wrote:
Hi,
I sent exactly the same patch back in April. Despite getting a review-by
it was never merged. See:
http://lists.freedesktop.org/archives/mesa-dev/2014-April/058347.html
http://lists.freedesktop.org
On 23/01/15 01:11, Rob Clark wrote:
On Thu, Jan 22, 2015 at 4:36 PM, Emil Velikov emil.l.veli...@gmail.com
wrote:
+static const char* node_path_fmt_card = /dev/dri/card%d;
You can reuse the DRM_DIR_NAME + DRM_DEV_NAME macros (from xf86drm.h)
for this.
+static const char*
of eglCreateContext.
Signed-off-by: Frank Binns frank.bi...@imgtec.com
---
src/egl/main/eglcontext.c | 30 +-
1 file changed, 29 insertions(+), 1 deletion(-)
diff --git a/src/egl/main/eglcontext.c b/src/egl/main/eglcontext.c
index e767f4b..01781a9 100644
--- a/src/egl/main
-EGL.functional.query_config.get_configs.get_configs_bounds
Signed-off-by: Frank Binns frank.bi...@imgtec.com
---
src/egl/main/eglarray.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/egl/main/eglarray.c b/src/egl/main/eglarray.c
index 3ccc8a6..d2f39af 100644
--- a/src/egl/main
On 31/07/15 12:53, Emil Velikov wrote:
On 31 July 2015 at 11:02, Frank Binns frank.bi...@imgtec.com wrote:
Commit 4ed23fd590 introduced some calls to _eglError inappropriately
passing it EGL_BAD_NATIVE_WINDOW. This was actually harmless in two of the
cases as _eglError gets called later
On 03/08/15 13:05, Emil Velikov wrote:
On 31 July 2015 at 13:34, Frank Binns frank.bi...@imgtec.com wrote:
On 31/07/15 12:53, Emil Velikov wrote:
On 31 July 2015 at 11:02, Frank Binns frank.bi...@imgtec.com wrote:
Commit 4ed23fd590 introduced some calls to _eglError inappropriately
passing
On 03/08/15 13:28, Emil Velikov wrote:
On 31 July 2015 at 11:02, Frank Binns frank.bi...@imgtec.com wrote:
Both eglCreatePixmapSurface and eglCreateWindowSurface were incorrectly
setting the EGL error to be EGL_BAD_ALLOC when an invalid native drawable
handle was being passed in. The EGL spec
handle
Signed-off-by: Frank Binns frank.bi...@imgtec.com
---
src/egl/drivers/dri2/platform_x11.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/src/egl/drivers/dri2/platform_x11.c
b/src/egl/drivers/dri2/platform_x11.c
index fecd36b..edb3d5e 100644
--- a/src/egl
the case where an error has been set on the connection
Cc: mesa-sta...@lists.freedesktop.org
Signed-off-by: Frank Binns frank.bi...@imgtec.com
---
src/egl/drivers/dri2/platform_x11.c | 20 +++-
1 file changed, 19 insertions(+), 1 deletion(-)
diff --git a/src/egl/drivers/dri2
to reflect this
Signed-off-by: Frank Binns frank.bi...@imgtec.com
---
src/egl/drivers/dri2/platform_x11.c | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/src/egl/drivers/dri2/platform_x11.c
b/src/egl/drivers/dri2/platform_x11.c
index edb3d5e..da4d69b 100644
On 03/08/15 13:33, Emil Velikov wrote:
On 31 July 2015 at 11:02, Frank Binns frank.bi...@imgtec.com wrote:
When calling either eglCreateWindowSurface or eglCreatePixmapSurface it
was possible for an application to be aborted as a result of it failing
to create a DRI2 drawable on the server
On 30/07/15 17:16, Emil Velikov wrote:
On 30 July 2015 at 10:27, Frank Binns frank.bi...@imgtec.com wrote:
This matches similar behaviour for the __DRI_API_OPENGL_CORE bit.
Signed-off-by: Frank Binns frank.bi...@imgtec.com
---
src/mesa/drivers/dri/common/dri_util.c | 4 +++-
1 file changed
: mesa-sta...@lists.freedesktop.org
Signed-off-by: Frank Binns frank.bi...@imgtec.com
Reviewed-by: Emil Velikov emil.l.veli...@gmail.com
---
src/egl/main/eglsurface.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/egl/main/eglsurface.c b/src/egl/main/eglsurface.c
index
. Hook
the new error code up in EGL to return EGL_BAD_ACCESS.
Cc: mesa-sta...@lists.freedesktop.org
Signed-off-by: Frank Binns frank.bi...@imgtec.com
Reviewed-by: Emil Velikov emil.l.veli...@gmail.com
---
include/GL/internal/dri_interface.h | 8 ++--
src/egl/drivers/dri2/egl_dri2.c | 4
2
This matches similar behaviour for the __DRI_API_OPENGL_CORE bit.
Signed-off-by: Frank Binns frank.bi...@imgtec.com
Reviewed-by: Emil Velikov emil.l.veli...@gmail.com
---
src/mesa/drivers/dri/common/dri_util.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/mesa
-by: Frank Binns frank.bi...@imgtec.com
---
src/egl/drivers/dri2/platform_x11.c | 18 +-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/src/egl/drivers/dri2/platform_x11.c
b/src/egl/drivers/dri2/platform_x11.c
index d35e9e2..830e643 100644
--- a/src/egl/drivers/dri2
case, change the error to EGL_BAD_ALLOC instead as this seems
more appropriate.
Signed-off-by: Frank Binns frank.bi...@imgtec.com
---
src/egl/drivers/dri2/platform_x11.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/egl/drivers/dri2/platform_x11.c
b/src/egl/drivers
. Hook
the new error code up in EGL to return EGL_BAD_ACCESS.
Signed-off-by: Frank Binns frank.bi...@imgtec.com
---
include/GL/internal/dri_interface.h | 8 ++--
src/egl/drivers/dri2/egl_dri2.c | 4
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/include/GL/internal
This matches similar behaviour for the __DRI_API_OPENGL_CORE bit.
Signed-off-by: Frank Binns frank.bi...@imgtec.com
---
src/mesa/drivers/dri/common/dri_util.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/common/dri_util.c
b/src/mesa/drivers/dri
.
Signed-off-by: Frank Binns frank.bi...@imgtec.com
---
src/egl/main/eglsurface.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/egl/main/eglsurface.c b/src/egl/main/eglsurface.c
index 541353f..4fa43f3 100644
--- a/src/egl/main/eglsurface.c
+++ b/src/egl/main/eglsurface.c
t :
> NULL,
> dri2_sync->fence, wait_flags,
> timeout))
>dri2_sync->base.SyncStatus = EGL_SIGNALED_KHR;
Either way:
Reviewed-by: Frank Binns <frank.bi...@imgtec.com>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
In order to support the WL_bind_wayland_display extension it's necessary to
make use of render nodes as DRI3 doesn't provide a mechanism for authenticating
client opened fds. However, this does not apply when Wayland support isn't
enabled.
Signed-off-by: Frank Binns <frank.bi...@imgtec.
.
Changes since v1:
- Make HAVE_WAYLAND_PLATFORM less inclusive (Martin Peres)
- Enhance DRI3 disabled warning (Martin Peres)
- Update commit message
Signed-off-by: Frank Binns <frank.bi...@imgtec.com>
---
src/egl/drivers/dri2/platform_x11_dri3.c | 3 +++
1 file changed, 3 insertions(+)
diff --git
On 10/06/16 14:32, Emil Velikov wrote:
On 10 June 2016 at 12:25, Martin Peres <martin.pe...@linux.intel.com> wrote:
On 10/06/16 13:30, Frank Binns wrote:
In order to support the WL_bind_wayland_display extension it's necessary
to
make use of render nodes as DRI3 doesn't provide a mec
On 10/06/16 12:25, Martin Peres wrote:
On 10/06/16 13:30, Frank Binns wrote:
In order to support the WL_bind_wayland_display extension it's
necessary to
make use of render nodes as DRI3 doesn't provide a mechanism for
authenticating
client opened fds. However, this does not apply when Wayland
On 21/06/16 07:39, Michel Dänzer wrote:
On 21.06.2016 15:24, Axel Davy wrote:
On 21/06/2016 01:26, Michel Dänzer wrote:
On 20.06.2016 20:06, Frank Binns wrote:
On 20/06/16 10:48, Michel Dänzer wrote:
On 18.06.2016 02:41, Frank Binns wrote:
Up until now, DRI3 was only used for devices
by disabling DRI3 support via the LIBGL_DRI3_DISABLE
environment variable.
Signed-off-by: Frank Binns <frank.bi...@imgtec.com>
---
src/egl/drivers/dri2/platform_x11.c | 3 ++-
src/egl/drivers/dri2/platform_x11_dri3.c | 33 +---
2 files changed, 7 insertions(+), 29 del
The device name is only needed for WL_bind_wayland_display so make this clear
by only storing the device name when Wayland support is built.
Signed-off-by: Frank Binns <frank.bi...@imgtec.com>
---
src/egl/drivers/dri2/egl_dri2.c | 5 -
src/egl/drivers/dri2/egl_dri2.h
. Protect
against this by providing a function that prints an error.
Signed-off-by: Frank Binns <frank.bi...@imgtec.com>
---
src/egl/drivers/dri2/platform_x11_dri3.c | 19 ++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/src/egl/drivers/dri2/platform_x11_dri3.c
Although malloc is unlikely to fail check its return value nevertheless.
Signed-off-by: Frank Binns <frank.bi...@imgtec.com>
---
src/egl/wayland/wayland-drm/wayland-drm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/egl/wayland/wayland-drm/wayland-drm.c
b/src/egl/wayland/w
When trying to get a device name for an fd using sysfs, it would always fail
as it was expecting key/value pairs to be delimited by '\0', which is not the
case.
Signed-off-by: Frank Binns <frank.bi...@imgtec.com>
---
src/loader/loader.c | 6 --
1 file changed, 4 insertions(+), 2 del
This field is only ever set and read by the X11 platform.
Signed-off-by: Frank Binns <frank.bi...@imgtec.com>
---
src/egl/drivers/dri2/egl_dri2.h | 2 +-
src/egl/drivers/dri2/platform_wayland.c | 2 --
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/egl/driver
On 20/06/16 10:48, Michel Dänzer wrote:
On 18.06.2016 02:41, Frank Binns wrote:
Up until now, DRI3 was only used for devices that have render nodes, unless
overridden via an environment variable, with it falling back to DRI2 otherwise.
This limitation was there in order to support
On 20/06/16 12:05, Axel Davy wrote:
Hi,
The three patches make sense to me.
Reviewed-by: Axel Davy <axel.d...@ens.fr>
Can someone push these patches for me?
Thanks
Frank
On 17/06/2016 19:41, Frank Binns wrote :
Up until now, DRI3 was only used for devices that have render nodes,
When trying to get a device name for an fd using sysfs, it would always fail
as it was expecting key/value pairs to be delimited by '\0', which is not the
case.
Signed-off-by: Frank Binns <frank.bi...@imgtec.com>
Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com>
---
src/loader/
Although malloc is unlikely to fail check its return value nevertheless.
Signed-off-by: Frank Binns <frank.bi...@imgtec.com>
Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com>
---
src/egl/wayland/wayland-drm/wayland-drm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src
On 18/06/16 01:34, Guillaume Charifi wrote:
Fixes a regression induced by commit a0674ce5:
You should put the full hash as this shortened version won't necessarily be
unique in the future.
Also, one minor comment below.
With the hash fixed this is:
Reviewed-by: Frank Binns <frank
el Dänzer <michel.daen...@amd.com>
Reviewed-by: Frank Binns <frank.bi...@imgtec.com>
---
src/loader/loader_dri3_helper.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/src/loader/loader_dri3_helper.c b/src/loader/loader_dri3_helper.c
index e9fb97
On 04/08/16 15:02, Frank Binns wrote:
On 20/06/16 12:05, Axel Davy wrote:
Hi,
The three patches make sense to me.
Reviewed-by: Axel Davy <axel.d...@ens.fr>
Can someone push these patches for me?
Thanks
Frank
Ping
On 17/06/2016 19:41, Frank Binns wrote :
Up until now, DRI3 wa
of the
'build' scanner. It seems to me that it should actually try finding
the scanner via PATH before falling back to pkgconfig. This is what
Weston does, for example.
Anyway, this doesn't make anything worse in that regard (afaics) so:
Reviewed-by: Frank Binns <frank.bi...@imgtec.com>
Thanks
On 07/03/17 19:22, Frank Binns wrote:
On 07/03/17 17:57, Emil Velikov wrote:
On 7 March 2017 at 17:29, Frank Binns <frank.bi...@imgtec.com> wrote:
Hi,
On 06/03/17 19:06, Matt Turner wrote:
Available since pkg-config-0.28 and pkgconf-0.8.10.
The removal of the AC_PATH_PROG is inten
On 07/03/17 17:57, Emil Velikov wrote:
On 7 March 2017 at 17:29, Frank Binns <frank.bi...@imgtec.com> wrote:
Hi,
On 06/03/17 19:06, Matt Turner wrote:
Available since pkg-config-0.28 and pkgconf-0.8.10.
The removal of the AC_PATH_PROG is intentional. Use pkg-config.
It doesn'
Reviewed-by: Frank Binns <frank.bi...@imgtec.com>
From: mesa-dev [mesa-dev-boun...@lists.freedesktop.org] on behalf of Eric
Engestrom [eric.engest...@imgtec.com]
Sent: 16 November 2017 10:16
To: mesa-dev@lists.freedesktop.org
Subject: [Mesa-dev]
t;)
Signed-off-by: Frank Binns <francisbi...@gmail.com>
---
src/egl/drivers/dri2/egl_dri2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c
index 17b646e..c06a0ca 100644
--- a/src/egl/drivers/dri2/egl_dri2
Reviewed-by: Frank Binns
Eric Engestrom writes:
> Signed-off-by: Eric Engestrom
> ---
> egl platforms are full of randomly-indented lines, so I won't bother
> to avoid rebase conflicts and blurring the history.
> ---
> src/egl/main/eglconfig.c | 2 +-
> src/egl/main/egl
Reviewed-by: Frank Binns
Eric Engestrom writes:
> Signed-off-by: Eric Engestrom
> ---
> src/loader/loader.c | 4 ++--
> src/loader/loader_dri3_helper.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/loader/loader.c b/src/lo
Hi Emil,
Emil Velikov writes:
> From: Emil Velikov
>
> Replace the manual handling of /dev/dri in famour of the drmDevice API.
s/famour/favour/
> The latter provides a consistent way of enumerating the devices,
> providing device details as needed.
>
> Cc: Robert Foss
> Cc: Tomasz Figa
>
Hi Qiang,
Qiang Yu writes:
> Hi Harish,
>
> I want to implement EGL_KHR_partial_update for lima mesa driver and find you
> worked on Android/Wayland support for it:
> https://patchwork.freedesktop.org/patch/160944/
> https://patchwork.freedesktop.org/patch/188695/
>
> So I have some question
> + /* We cannot restore the same state as it was before calling
> + * eglMakeCurrent(), but we can keep EGL in a consistent state with
> + * the DRI driver by unbinding the old EGL context and surfaces.
> */
> - return _eglError(EGL_BAD_MATCH, "eglMakeCurr
Emil Velikov writes:
> From: Emil Velikov
>
> The difference between the tree functions is the list of mandatory
s/tree/three/
With that fixed:
Reviewed-by: Frank Binns
> driver extensions. Pass that as an argument to the common helper.
>
> Signed-off-by: Emil Velikov
Hi Emma,
Emma Anholt writes:
>
> Welcome! I'm really excited to see this happening, and your early
> upstreaming work.
Thanks!
> On Fri, Mar 4, 2022 at 7:44 AM wrote:
>>
>> Hi All,
>>
>> I'm excited to share that over the last year we've been working on a new
>> Vulkan driver, compiler and
56 matches
Mail list logo
