Re: [Mesa-dev] Move wayland-drm protocol from Mesa to wayland-core

2013-11-27 Thread Jason Ekstrand
hard to move everyone over from wl_drm to mesa_drm. Hope that's sensible/helpful. --Jason Ekstrand ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] What use do swap interval 1 and OML_sync_control divisor and remainder have?

2014-01-26 Thread Jason Ekstrand
is the only right way, let me know and I can start another email thread about that detail after preparing my material. Thanks, pq I hope that's helpful, --Jason Ekstrand ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org

[Mesa-dev] Texture object locking

2014-06-06 Thread Jason Ekstrand
, --Jason Ekstrand ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] meta_blit: properly compute texture width for the CopyTexSubImage fallback

2014-06-13 Thread Jason Ekstrand
--- src/mesa/drivers/common/meta_blit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/common/meta_blit.c b/src/mesa/drivers/common/meta_blit.c index aa12e04..2b99b99 100644 --- a/src/mesa/drivers/common/meta_blit.c +++ b/src/mesa/drivers/common/meta_blit.c

Re: [Mesa-dev] [PATCH] meta_blit: properly compute texture width for the CopyTexSubImage fallback

2014-06-13 Thread Jason Ekstrand
On Fri, Jun 13, 2014 at 12:20 PM, Brian Paul bri...@vmware.com wrote: On 06/13/2014 01:17 PM, Jason Ekstrand wrote: --- src/mesa/drivers/common/meta_blit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/common/meta_blit.c b/src/mesa/drivers/common

Re: [Mesa-dev] [PATCH 3/5] Add a place to enable extensions that are common to all DRI drivers

2014-06-13 Thread Jason Ekstrand
Neil, I've been thinking about this same thing. My one comment is that it might be good to call that function after the driver has installed its extensions. That way you can make meta extensions dependant on driver extensions. Not sure how useful that is though. --Jason Ekstrand On Jun 13, 2014

[Mesa-dev] ATI_envmap_bumpmap

2014-06-26 Thread Jason Ekstrand
Right now, the Intel driver is the only driver in mesa that implements this extension. Is anyone using this? Is it ok if we purge it? I'm doing some work on the texture format code and DUDV8 is an ugly special case. Thanks, --Jason Ekstrand ___ mesa

Re: [Mesa-dev] ATI_envmap_bumpmap

2014-06-27 Thread Jason Ekstrand
Thanks, Connor. On that note... On Fri, Jun 27, 2014 at 8:48 AM, Connor Abbott cwabbo...@gmail.com wrote: On Jun 26, 2014 5:30 PM, Jason Ekstrand ja...@jlekstrand.net wrote: Right now, the Intel driver is the only driver in mesa that implements this extension. Is anyone using

Re: [Mesa-dev] [PATCH] Remove the ATI_envmap_bumpmap extension

2014-06-27 Thread Jason Ekstrand
On Fri, Jun 27, 2014 at 5:41 PM, Chris Forbes chr...@ijw.co.nz wrote: On Sat, Jun 28, 2014 at 10:19 AM, Jason Ekstrand ja...@jlekstrand.net wrote: @@ -653,135 +613,6 @@ _swrast_texture_span( struct gl_context *ctx, SWspan *span ) [snip] - - /* -* Must do all texture sampling

[Mesa-dev] [PATCH 2/2] i965: Add initial support for ARB_copy_image

2014-06-27 Thread Jason Ekstrand
This adds very basic support of ARB_copy_image but does not quite handle all of the cases. It works as long as neither target is multisampled and the texture pitch is less than INT16_MAX. Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/drivers/dri/i965/Makefile.sources

[Mesa-dev] [PATCH 1/2] Add GL API support for ARB_copy_image

2014-06-27 Thread Jason Ekstrand
This adds the API entrypoint, error checking logic, and a driver hook for the ARB_copy_image extension. Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mapi/glapi/gen/ARB_copy_image.xml | 28 +++ src/mapi/glapi/gen/gl_API.xml | 2 +- src/mapi/glapi/gen/gl_genexec.py

[Mesa-dev] [PATCH 0/2] Add initial support for GL_ARB_copy_image

2014-06-27 Thread Jason Ekstrand
they don't bitrot in my personal repo. Jason Ekstrand (2): Add GL API support for ARB_copy_image i965: Add initial support for ARB_copy_image src/mapi/glapi/gen/ARB_copy_image.xml| 28 +++ src/mapi/glapi/gen/gl_API.xml| 2 +- src/mapi/glapi/gen/gl_genexec.py

Re: [Mesa-dev] [PATCH 0/6] Enable Pixman for Mesa

2014-06-30 Thread Jason Ekstrand
be stepping on each other too badly. Also, what was your set-up for doing power comparisons? As I dive into this, I'd like to see how my results compare. Thanks, --Jason Ekstrand ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http

Re: [Mesa-dev] [PATCH 2/5] mesa/main: Add generic bits of ARB_clear_texture implementation

2014-06-30 Thread Jason Ekstrand
; + } + } + + return MAX_FACES; + } + + texImages[0] = _mesa_select_tex_image(ctx, texObj, texObj-Target, level); Do you want this inside an else block? Other than that, looks good to me. --Jason Ekstrand + + if (texImages[0] == NULL) { + _mesa_error(ctx, GL_INVALID_OPERATION

Re: [Mesa-dev] [PATCH 4/5] texstore: Add a generic implementation of GL_ARB_clear_texture

2014-06-30 Thread Jason Ekstrand
to me. (I'll second Ilia's MS comment though.) --Jason Ekstrand + +static void +clear_image_to_value(GLubyte *dstMap, GLint dstRowStride, + GLsizei width, GLsizei height, + const GLvoid *clearValue, + GLsizei clearValueSize

Re: [Mesa-dev] [PATCH 2/5] mesa/main: Add generic bits of ARB_clear_texture implementation

2014-07-01 Thread Jason Ekstrand
On Tue, Jul 1, 2014 at 10:09 AM, Neil Roberts n...@linux.intel.com wrote: Jason Ekstrand ja...@jlekstrand.net writes: + texImages[0] = _mesa_select_tex_image(ctx, texObj, texObj-Target, level); Do you want this inside an else block? I think it's quite a common idiom in Mesa

Re: [Mesa-dev] [PATCH 4/5] texstore: Add a generic implementation of GL_ARB_clear_texture

2014-07-01 Thread Jason Ekstrand
On Tue, Jul 1, 2014 at 11:06 AM, Neil Roberts n...@linux.intel.com wrote: Jason Ekstrand ja...@jlekstrand.net writes: +static void +clear_image_to_zero(GLubyte *dstMap, GLint dstRowStride, +GLsizei width, GLsizei height, +GLsizei clearValueSize

[Mesa-dev] [PATCH 03/12] main/formats: Remove IndexBits

2014-07-17 Thread Jason Ekstrand
Mesa hasn't supported color-indexed textures for some time. This is 0 for all texture formats, so we don't need to store it. Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/main/format_info.py | 2 +- src/mesa/main/formats.c | 3 +-- 2 files changed, 2 insertions(+), 3

[Mesa-dev] [PATCH 01/12] main: Add a format description CSV file

2014-07-17 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/main/formats.csv | 282 ++ 1 file changed, 282 insertions(+) create mode 100644 src/mesa/main/formats.csv diff --git a/src/mesa/main/formats.csv b/src/mesa/main/formats.csv new file

[Mesa-dev] [PATCH 04/12] main/formats: Add layout and swizzle information

2014-07-17 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/main/format_info.py | 11 +++ src/mesa/main/formats.c | 46 src/mesa/main/formats.h | 29 3 files changed, 86 insertions(+) diff --git

[Mesa-dev] [PATCH 00/12] Rework texture upload code

2014-07-17 Thread Jason Ekstrand
a chance to look into it too much yet. 2) Do similar refactors for GetTexImage, ReadPixels, and DrawPixels. Happy Reviewing! --Jason Ekstrand Jason Ekstrand (12): main: Add a format description CSV file main/formats: Autogenerate the format_info structure from a CSV file main/formats: Remove

[Mesa-dev] [PATCH 10/12] main/format_pack: Fix a wrong datatype in pack_ubyte_R8G8_UNORM

2014-07-17 Thread Jason Ekstrand
Before it was only storing one of the color components due to truncation. With this patch it now properly stores all of them. Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/main/format_pack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main

[Mesa-dev] [PATCH 06/12] main/format_utils: Add a general format conversion function

2014-07-17 Thread Jason Ekstrand
Most format conversion operations required by GL can be performed by converting one channel at a time, shuffling the channels around, and optionally filling missing channels with zeros and ones. This adds a function to do just that in a general, yet efficient, way. Signed-off-by: Jason Ekstrand

[Mesa-dev] [PATCH 08/12] main/texstore: Split texture storage into three functions: texstore_depth_stencil, texstore_compressed, and texstore_rgba

2014-07-17 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/main/texstore.c | 171 +++ 1 file changed, 100 insertions(+), 71 deletions(-) diff --git a/src/mesa/main/texstore.c b/src/mesa/main/texstore.c index d363f9f..e1f2284 100644 --- a/src

[Mesa-dev] [PATCH 07/12] main/format_utils: Add a function for determining if a format is actually an array format and computing the array format parameters

2014-07-17 Thread Jason Ekstrand
This is a direct helper function for using _mesa_swizzle_and_convert Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/main/format_utils.c | 93 src/mesa/main/format_utils.h | 4 ++ 2 files changed, 97 insertions(+) diff --git

[Mesa-dev] [PATCH 05/12] main: Gather some common format conversion functions into a single format_utils file

2014-07-17 Thread Jason Ekstrand
This initial commit puts all of the RGB - sRGB conversion functions in one place. Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/Makefile.sources| 1 + src/mesa/main/format_pack.c | 102 ++- src/mesa/main/format_unpack.c

[Mesa-dev] [PATCH 12/12] mesa/texstore: Add a generic rgba integer texture upload path

2014-07-17 Thread Jason Ekstrand
Again, we delete a lot of functions that aren't really doing anything interesting anymore. Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/main/texstore.c | 545 ++- 1 file changed, 66 insertions(+), 479 deletions(-) diff --git

[Mesa-dev] [PATCH 09/12] main/texstore: Use _mesa_swizzle_and_convert when possible

2014-07-17 Thread Jason Ekstrand
This should be both faster and more accurate than our general slow-path of converting everything to float. Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/main/texstore.c | 179 +++ 1 file changed, 164 insertions(+), 15 deletions

[Mesa-dev] [PATCH 2/2] Add support for RGBA8 and RGBX8 textures in intel_texsubimage_tiled_memcpy

2014-07-17 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/drivers/dri/i965/intel_tex_subimage.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_tex_subimage.c b/src/mesa/drivers/dri/i965/intel_tex_subimage.c index 04cbc4c..4043eb7 100644

[Mesa-dev] [PATCH 1/2] i965: Improve debug output in intelTexImage and intelTexSubimage

2014-07-17 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/drivers/dri/i965/intel_tex_image.c| 4 +++- src/mesa/drivers/dri/i965/intel_tex_subimage.c | 6 ++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_tex_image.c b/src/mesa

Re: [Mesa-dev] [PATCH 0/6] Enable Pixman for Mesa

2014-07-17 Thread Jason Ekstrand
. It would be interesting to note what that does to power consumption. --Jason Ekstrand On Wed, Jun 25, 2014 at 5:38 AM, Juha-Pekka Heikkila juhapekka.heikk...@gmail.com wrote: This is my old set which enable using Pixman on Mesa for some texture conversion fast paths. As is this passes Piglit quick

Re: [Mesa-dev] [PATCH 10/12] main/format_pack: Fix a wrong datatype in pack_ubyte_R8G8_UNORM

2014-07-18 Thread Jason Ekstrand
On Fri, Jul 18, 2014 at 7:59 AM, Brian Paul bri...@vmware.com wrote: On 07/17/2014 12:04 PM, Jason Ekstrand wrote: Before it was only storing one of the color components due to truncation. With this patch it now properly stores all of them. Signed-off-by: Jason Ekstrand jason.ekstr

Re: [Mesa-dev] [PATCH 00/12] Rework texture upload code

2014-07-18 Thread Jason Ekstrand
On Fri, Jul 18, 2014 at 8:32 AM, Brian Paul bri...@vmware.com wrote: On 07/17/2014 12:04 PM, Jason Ekstrand wrote: This is the first installment of some work I've been doing over the past couple of weeks to refactor mesa's texture conversion/storage code. There is more to be done and more

Re: [Mesa-dev] [PATCH 04/12] main/formats: Add layout and swizzle information

2014-07-18 Thread Jason Ekstrand
On Fri, Jul 18, 2014 at 2:10 PM, Marek Olšák mar...@gmail.com wrote: On Thu, Jul 17, 2014 at 8:04 PM, Jason Ekstrand ja...@jlekstrand.net wrote: Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/main/format_info.py | 11 +++ src/mesa/main/formats.c | 46

[Mesa-dev] [PATCH] i965: Accelerate uploads of RGBA and BGRA GL_UNSIGNED_INT_8_8_8_8_REV textures

2014-07-18 Thread Jason Ekstrand
Since intel is always going to be little-endian, GL_UNSIGNED_INT_8_8_8_8_REV is the same as GL_BYTE for RGBA and BGRA textures, so the same acceleration code will work. We might as well use it. --- src/mesa/drivers/dri/i965/intel_tex_subimage.c | 6 +- 1 file changed, 5 insertions(+), 1

[Mesa-dev] [PATCH] Add an accelerated version of F_TO_I for x86_64

2014-07-21 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/main/imports.h | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/main/imports.h b/src/mesa/main/imports.h index af780b2..5d6486b 100644 --- a/src/mesa/main/imports.h +++ b/src/mesa/main/imports.h @@ -285,6 +285,10

Re: [Mesa-dev] [PATCH] Add an accelerated version of F_TO_I for x86_64

2014-07-22 Thread Jason Ekstrand
On Mon, Jul 21, 2014 at 5:29 PM, Matt Turner matts...@gmail.com wrote: On Mon, Jul 21, 2014 at 5:16 PM, Jason Ekstrand ja...@jlekstrand.net wrote: Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/main/imports.h | 4 1 file changed, 4 insertions(+) diff --git

[Mesa-dev] [PATCH] Add an accelerated version of F_TO_I for x86_64

2014-07-22 Thread Jason Ekstrand
According to a quick micro-benchmark, this new version is 20% faster on my Haswell laptop. v2: Removed the XXX note about x86_64 from the comment Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/main/imports.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff

Re: [Mesa-dev] [PATCH 00/12] Rework texture upload code

2014-07-23 Thread Jason Ekstrand
On Wed, Jul 23, 2014 at 10:31 AM, Marek Olšák mar...@gmail.com wrote: On Fri, Jul 18, 2014 at 5:32 PM, Brian Paul bri...@vmware.com wrote: On 07/17/2014 12:04 PM, Jason Ekstrand wrote: This is the first installment of some work I've been doing over the past couple of weeks to refactor

[Mesa-dev] [PATCH] Add an accelerated version of F_TO_I for x86_64

2014-07-23 Thread Jason Ekstrand
According to a quick micro-benchmark, this new version is 20% faster on my Haswell laptop. v2: Removed the XXX note about x86_64 from the comment v3: Use an intrinsic instead of an __asm__ block. This should give us MSVC support for free. Signed-off-by: Jason Ekstrand jason.ekstr

[Mesa-dev] [PATCH 3/6] util: Move the open-addressing linear-probing hash_table to src/util.

2014-07-24 Thread Jason Ekstrand
a comment saying Gallium should probably consider switching to a linear probing hash table at some point. So this seems like the best candidate for a shared data structure. Signed-off-by: Kenneth Graunke kenn...@whitecape.org v2 (Jason Ekstrand): Pick up another hash_table use and patch up scons

[Mesa-dev] [PATCH 4/6] util: Gather some common macros

2014-07-24 Thread Jason Ekstrand
This gathers macros that have been included across components into util so that the include chain can be more vertical. In particular, this makes util stand on its own without any dependence whatsoever on the rest of mesa. Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/gallium

[Mesa-dev] [PATCH 1/6] mesa/SConscript: Use Makefile.sources instead of duplicating the file lists

2014-07-24 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/Makefile.sources | 3 + src/mesa/SConscript | 341 ++ 2 files changed, 11 insertions(+), 333 deletions(-) diff --git a/src/mesa/Makefile.sources b/src/mesa/Makefile.sources

[Mesa-dev] [PATCH 6/6] mesa/main: Use the RGB - sRGB conversion functions in libmesautil

2014-07-24 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/main/format_pack.c | 102 ++- src/mesa/main/format_unpack.c| 69 -- src/mesa/main/format_unpack.h| 3 -- src/mesa/main/texcompress_etc.c | 19

[Mesa-dev] [PATCH 2/6] util: Move ralloc to a new src/util directory.

2014-07-24 Thread Jason Ekstrand
a good first candidate. These days, it's directly used by mesa/main, i965, i915, and r300g, so keeping it in src/glsl didn't make much sense. Signed-off-by: Kenneth Graunke kenn...@whitecape.org v2 (Jason Ekstrand): More realloc uses and some scons fixes Signed-off-by: Jason Ekstrand jason.ekstr

[Mesa-dev] [PATCH 5/6] gallium: Move sRGB - RGB handling to libmesautil

2014-07-24 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/gallium/Automake.inc | 2 + src/gallium/auxiliary/Makefile.am | 4 - src/gallium/auxiliary/Makefile.sources| 1 - src/gallium/auxiliary/SConscript | 8 +- src/gallium

[Mesa-dev] [PATCH 0/6] Add a libmesautil library for sharing code between

2014-07-24 Thread Jason Ekstrand
the ball rolling. Right now, we just gather ralloc, hash_table, some macros, and RGB - sRGB conversions. Jason Ekstrand (4): mesa/SConscript: Use Makefile.sources instead of duplicating the file lists util: Gather some common macros gallium: Move sRGB - RGB handling to libmesautil mesa/main

Re: [Mesa-dev] [PATCH] Add an accelerated version of F_TO_I for x86_64

2014-07-28 Thread Jason Ekstrand
to do it, I'll send a patch. Roland Am 23.07.2014 05:15, schrieb Jason Ekstrand: According to a quick micro-benchmark, this new version is 20% faster on my Haswell laptop. v2: Removed the XXX note about x86_64 from the comment Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com

[Mesa-dev] [PATCH] main/get_hash_params: Add GL_SAMPLE_SHADING_ARB

2014-07-28 Thread Jason Ekstrand
GL_SAMPLE_SHADING is specified as a valid pname for glGet in the GL_ARB_sample_shading extension. It seems as if we forgot to add it to the table of pnames. Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/main/get_hash_params.py | 1 + 1 file changed, 1 insertion(+) diff

Re: [Mesa-dev] [PATCH 07/15] mesa: Add error condition for using compressed internalformat in glTexStorage3D()

2014-07-29 Thread Jason Ekstrand
(internalformat)); + } It seems to me as if the mesa_target_can_be_compressed function completely disallows 3D texture formats, but the spec implies that they are allowed in some cases. What's going on here? --Jason Ekstrand + /* levels check */ if (levels 1

Re: [Mesa-dev] [PATCH 06/15] mesa: Turn target_can_be_compressed() in to a utility function

2014-07-29 Thread Jason Ekstrand
If we're going to make a utility function declared in glformats.h, let's move the function body to glformats.c. On Fri, Jun 6, 2014 at 4:57 PM, Anuj Phogat anuj.pho...@gmail.com wrote: Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Anuj Phogat anuj.pho...@gmail.com ---

Re: [Mesa-dev] [PATCH 14/15] mesa: Add utility function _mesa_is_enum_format_unorm()

2014-07-29 Thread Jason Ekstrand
I think you're missing the SRGB and SLUMINANCE formats. Other than that, I think that's all of them. On Fri, Jun 6, 2014 at 4:57 PM, Anuj Phogat anuj.pho...@gmail.com wrote: Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Anuj Phogat anuj.pho...@gmail.com ---

Re: [Mesa-dev] [PATCH 09/15] mesa: Add utility function mesa_is_enum_format_snorm()

2014-07-29 Thread Jason Ekstrand
You should fix the commit message to be _mesa_is_enum_format_snorm (you forgot the beginning underscore). Other than that, looks good. Reviewed-by: Jason Ekstrand jason.ekstr...@intel.com On Fri, Jun 6, 2014 at 4:57 PM, Anuj Phogat anuj.pho...@gmail.com wrote: Cc: mesa-sta

Re: [Mesa-dev] [PATCH 08/15] mesa: Fix condition for using compressed internalformat in glCompressedTexImage3D()

2014-07-29 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand jason.ekstr...@intel.com On Fri, Jun 6, 2014 at 4:57 PM, Anuj Phogat anuj.pho...@gmail.com wrote: Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- src/mesa/main/teximage.c | 9 - 1 file changed, 8 insertions

Re: [Mesa-dev] [PATCH 11/15] mesa: Add a helper function _mesa_is_enum_format_unsized()

2014-07-29 Thread Jason Ekstrand
On Fri, Jun 6, 2014 at 4:57 PM, Anuj Phogat anuj.pho...@gmail.com wrote: Function is utilized by next patch in the series. Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- src/mesa/main/glformats.c | 18 ++

Re: [Mesa-dev] [PATCH 15/15] mesa: Add gles3 condition for normalized internal formats in glCopyTexImage*()

2014-07-29 Thread Jason Ekstrand
Looks good to me. Reviewed-by: Jason Ekstrand jason.ekstr...@intel.com On Fri, Jun 6, 2014 at 4:57 PM, Anuj Phogat anuj.pho...@gmail.com wrote: Fixes many failures in gles3 Khronos CTS test: packed_pixels Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Anuj Phogat anuj.pho

Re: [Mesa-dev] [PATCH 10/15] mesa: Don't allow snorm internal formats in glCopyTexImage*() in GLES3

2014-07-29 Thread Jason Ekstrand
On Fri, Jun 6, 2014 at 4:57 PM, Anuj Phogat anuj.pho...@gmail.com wrote: Fixes few failures in gles3 Khronos CTS test: packed_pixels Cc: 10.2 mesa-sta...@lists.freedesktop.org Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- src/mesa/main/teximage.c | 11 +++ 1 file changed,

Re: [Mesa-dev] [PATCH 13/15] mesa: Add gles3 error condition for GL_RGBA10_A2 buffer format in glCopyTexImage*()

2014-07-29 Thread Jason Ekstrand
On Fri, Jun 6, 2014 at 4:57 PM, Anuj Phogat anuj.pho...@gmail.com wrote: Fixes many failures in gles3 Khronos CTS test: packed_pixels Khronos bug# 9807 Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Anuj Phogat anuj.pho...@gmail.com Signed-off-by: Anuj Phogat anuj.pho...@gmail.com

Re: [Mesa-dev] [PATCH 06/15] mesa: Turn target_can_be_compressed() in to a utility function

2014-07-30 Thread Jason Ekstrand
On Wed, Jul 30, 2014 at 2:04 PM, Anuj Phogat anuj.pho...@gmail.com wrote: On Tue, Jul 29, 2014 at 5:01 PM, Jason Ekstrand ja...@jlekstrand.net wrote: If we're going to make a utility function declared in glformats.h, let's move the function body to glformats.c. or just move the function

Re: [Mesa-dev] [PATCH V2] mesa: Turn target_can_be_compressed() in to a utility function

2014-07-31 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand jason.ekstr...@intel.com On Wed, Jul 30, 2014 at 6:28 PM, Anuj Phogat anuj.pho...@gmail.com wrote: V2: Declare the function in teximage.h Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- src/mesa/main/teximage.c | 12

[Mesa-dev] [PATCH 0/5] Implement ARB_copy_image on i965

2014-07-31 Thread Jason Ekstrand
by calling into the blitter hardware. Jason Ekstrand (5): Add GL API support for ARB_copy_image mesa/meta: Make _mesa_meta_bind_fbo_image also take a framebuffer target mesa/meta: Add support for storing the current read buffer mesa/meta: Add a partial implementation of CopyImageSubData

[Mesa-dev] [PATCH 2/5] mesa/meta: Make _mesa_meta_bind_fbo_image also take a framebuffer target

2014-07-31 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/drivers/common/meta.c | 38 +++--- src/mesa/drivers/common/meta.h | 2 +- src/mesa/drivers/common/meta_generate_mipmap.c | 4 +-- 3 files changed, 25 insertions(+), 19

[Mesa-dev] [PATCH 1/5] Add GL API support for ARB_copy_image

2014-07-31 Thread Jason Ekstrand
This adds the API entrypoint, error checking logic, and a driver hook for the ARB_copy_image extension. Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mapi/glapi/gen/ARB_copy_image.xml | 28 +++ src/mapi/glapi/gen/gl_API.xml | 2 +- src/mapi/glapi/gen/gl_genexec.py

[Mesa-dev] [PATCH 3/5] mesa/meta: Add support for storing the current read buffer

2014-07-31 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/drivers/common/meta.c | 13 + src/mesa/drivers/common/meta.h | 4 src/mesa/drivers/common/meta_blit.c | 3 ++- 3 files changed, 19 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/common

[Mesa-dev] [PATCH 4/5] mesa/meta: Add a partial implementation of CopyImageSubData

2014-07-31 Thread Jason Ekstrand
This provides an implementation of CopyImageSubData that works if both textures are uncompressed. This implementation works by using a combination of texture views and BlitFramebuffer. If one of the textures is compressed, it returns false and the driver is expected to provide a fallback. ---

[Mesa-dev] [PATCH 5/5] i965: Add support for ARB_copy_image

2014-07-31 Thread Jason Ekstrand
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, + * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR + * OTHER DEALINGS IN THE SOFTWARE. + * + * Authors: + *Jason Ekstrand jason.ekstr...@intel.com + */ + +#include intel_tex.h +#include intel_blit.h +#include

Re: [Mesa-dev] [PATCH 10/15] mesa: Don't allow snorm internal formats in glCopyTexImage*() in GLES3

2014-07-31 Thread Jason Ekstrand
On Wed, Jul 30, 2014 at 8:51 PM, Anuj Phogat anuj.pho...@gmail.com wrote: On Tue, Jul 29, 2014 at 5:04 PM, Jason Ekstrand ja...@jlekstrand.net wrote: On Fri, Jun 6, 2014 at 4:57 PM, Anuj Phogat anuj.pho...@gmail.com wrote: Fixes few failures in gles3 Khronos CTS test: packed_pixels

Re: [Mesa-dev] [PATCH V2] mesa: Add a helper function _mesa_is_enum_format_unsized()

2014-07-31 Thread Jason Ekstrand
Yeah, that looks better. Reviewed-by: Jason Ekstrand jason.ekstr...@intel.com On Thu, Jul 31, 2014 at 4:30 PM, Anuj Phogat anuj.pho...@gmail.com wrote: Function is utilized by next patch in the series. V2: Add missing formats. Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Anuj

Re: [Mesa-dev] [PATCH V2] mesa: Add utility function _mesa_is_enum_format_unorm()

2014-07-31 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand jason.ekstr...@intel.com On Thu, Jul 31, 2014 at 1:49 PM, Anuj Phogat anuj.pho...@gmail.com wrote: V2: Add missing formats. Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- src/mesa/main/glformats.c | 71

Re: [Mesa-dev] [PATCH 1/5] Add GL API support for ARB_copy_image

2014-07-31 Thread Jason Ekstrand
On Thu, Jul 31, 2014 at 11:38 AM, Ilia Mirkin imir...@alum.mit.edu wrote: On Thu, Jul 31, 2014 at 2:27 PM, Jason Ekstrand ja...@jlekstrand.net wrote: This adds the API entrypoint, error checking logic, and a driver hook for the ARB_copy_image extension. Signed-off-by: Jason Ekstrand

[Mesa-dev] [PATCH 1/5] Add GL API support for ARB_copy_image

2014-07-31 Thread Jason Ekstrand
This adds the API entrypoint, error checking logic, and a driver hook for the ARB_copy_image extension. v2: Fix a typo in ARB_copy_image.xml and add it to the makefile Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mapi/glapi/gen/ARB_copy_image.xml | 28 +++ src/mapi/glapi/gen

[Mesa-dev] [PATCH 1/5] Add GL API support for ARB_copy_image

2014-07-31 Thread Jason Ekstrand
FOR ANY CLAIM, DAMAGES OR + * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, + * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR + * OTHER DEALINGS IN THE SOFTWARE. + * + * Authors: + *Jason Ekstrand jason.ekstr...@intel.com + */ + +#include glheader.h

Re: [Mesa-dev] [PATCH 1/5] Add GL API support for ARB_copy_image

2014-08-01 Thread Jason Ekstrand
On Fri, Aug 1, 2014 at 2:56 AM, Juha-Pekka Heikkila juhapekka.heikk...@gmail.com wrote: On 01.08.2014 06:39, Jason Ekstrand wrote: This adds the API entrypoint, error checking logic, and a driver hook for the ARB_copy_image extension. v2: Fix a typo in ARB_copy_image.xml and add

Re: [Mesa-dev] [PATCH 5/5] i965: Add support for ARB_copy_image

2014-08-01 Thread Jason Ekstrand
On Fri, Aug 1, 2014 at 7:21 AM, Neil Roberts n...@linux.intel.com wrote: Jason Ekstrand ja...@jlekstrand.net writes: This, together with the meta path, provides a almost-complete implemetation of ARB_copy_image. The only case that won't work is if one of the textures is compressed and has

Re: [Mesa-dev] [PATCH 4/5] mesa/meta: Add a partial implementation of CopyImageSubData

2014-08-01 Thread Jason Ekstrand
On Fri, Aug 1, 2014 at 6:48 AM, Neil Roberts n...@linux.intel.com wrote: Jason Ekstrand ja...@jlekstrand.net writes: +bool +_mesa_meta_CopyImageSubData_uncompressed(struct gl_context *ctx, + struct gl_texture_image *src_tex_image

Re: [Mesa-dev] [PATCH 3/5] mesa/meta: Add support for storing the current read buffer

2014-08-01 Thread Jason Ekstrand
On Fri, Aug 1, 2014 at 6:44 AM, Neil Roberts n...@linux.intel.com wrote: Is this patch necessary? I think the read buffer is part of the framebuffer state so any meta function that binds its own framebuffer won't need to save the read buffer, right? This is the case for

[Mesa-dev] [PATCH 5/5 v2] i965: Add support for ARB_copy_image

2014-08-01 Thread Jason Ekstrand
path for when the texture is too big for the blitter Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/drivers/dri/i965/Makefile.sources | 1 + src/mesa/drivers/dri/i965/brw_context.c | 1 + src/mesa/drivers/dri/i965/intel_copy_image.c | 248

Re: [Mesa-dev] [PATCH 07/15] mesa: Add error condition for using compressed internalformat in glTexStorage3D()

2014-08-01 Thread Jason Ekstrand
On Wed, Jul 30, 2014 at 2:29 PM, Ian Romanick i...@freedesktop.org wrote: On 07/29/2014 05:02 PM, Jason Ekstrand wrote: On Fri, Jun 6, 2014 at 4:57 PM, Anuj Phogat anuj.pho...@gmail.com mailto:anuj.pho...@gmail.com wrote: Fixes gles3 Khronos CTS test

Re: [Mesa-dev] [PATCH 12/15] mesa: Add a gles3 error condition for sized internalformat in glCopyTexImage*()

2014-08-01 Thread Jason Ekstrand
On Wed, Jun 11, 2014 at 11:09 AM, Anuj Phogat anuj.pho...@gmail.com wrote: Adding mesa-dev to the conversation. On Wed, Jun 11, 2014 at 10:52 AM, Anuj Phogat anuj.pho...@gmail.com wrote: On Wed, Jun 11, 2014 at 10:28 AM, Courtney Goeltzenleuchter court...@lunarg.com wrote: On Fri,

[Mesa-dev] [PATCH v2 04/13] mesa/formats: Remove IndexBits

2014-08-02 Thread Jason Ekstrand
Mesa hasn't supported color-indexed textures for some time. This is 0 for all texture formats, so we don't need to store it. Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/main/format_info.py | 2 +- src/mesa/main/formats.c | 3 +-- 2 files changed, 2 insertions(+), 3

[Mesa-dev] [PATCH v2 07/13] mesa/imports: Add a _mesa_half_is_negative helper function

2014-08-02 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/main/imports.h | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/main/imports.h b/src/mesa/main/imports.h index 09e55eb..023ef2e 100644 --- a/src/mesa/main/imports.h +++ b/src/mesa/main/imports.h @@ -552,6 +552,11

[Mesa-dev] [PATCH v2 13/13] mesa/texstore: Add a generic rgba integer texture upload path

2014-08-02 Thread Jason Ekstrand
Again, we delete a lot of functions that aren't really doing anything interesting anymore. v2: Comment the texstore_rgba_integer function Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/main/texstore.c | 552 +++ 1 file changed, 73

[Mesa-dev] [PATCH v2 03/13] mesa/formats: Autogenerate the format_info structure from a CSV file

2014-08-02 Thread Jason Ekstrand
. The idea (and some of the implementation) for this was taken from the gallium driver. However, due to differences in the way the two systems handle formats, they are NOT the same; watch out for differences. Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/Makefile.am

[Mesa-dev] [PATCH v2 01/13] mesa: Add a format description CSV file

2014-08-02 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/main/formats.csv | 282 ++ 1 file changed, 282 insertions(+) create mode 100644 src/mesa/main/formats.csv diff --git a/src/mesa/main/formats.csv b/src/mesa/main/formats.csv new file

[Mesa-dev] [PATCH v2 05/13] mesa/formats: Add layout and swizzle information

2014-08-02 Thread Jason Ekstrand
v2: Move the MESA_FORMAT_SWIZZLE enum to the top of the file Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/main/format_info.py | 11 +++ src/mesa/main/formats.c | 46 src/mesa/main/formats.h | 29

[Mesa-dev] [PATCH v2 02/13] mesa: Add python to parse the formats CSV file

2014-08-02 Thread Jason Ekstrand
* An actual Swizzle class with methods for composition and inverses * Over-all cleaner (in my opinion) implementation and class interactions * A few bug fixes Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/main/format_parser.py | 521

[Mesa-dev] [PATCH v2 12/13] mesa/texstore: Add a generic float/normalized rgba texture upload path

2014-08-02 Thread Jason Ekstrand
This commit also removes a bunch of functions which aren't doing anything more interesting than the general path does. v2: Better comment the texstore_via_float function Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/main/texstore.c | 2046

[Mesa-dev] [PATCH v2 11/13] mesa/texstore: Use _mesa_swizzle_and_convert when possible

2014-08-02 Thread Jason Ekstrand
This should be both faster and more accurate than our general slow-path of converting everything to float. v2: Add a comment to top of the texstore_swizzle function Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/main/texstore.c | 186

[Mesa-dev] [PATCH v2 00/13] Rework the texture upload code

2014-08-02 Thread Jason Ekstrand
This is a direct rework of the patch series starting here: http://lists.freedesktop.org/archives/mesa-dev/2014-July/063483.html I've tried to address all of the direct comments given on those patches. This version is much better documented and even a little faster. Jason Ekstrand (13): mesa

[Mesa-dev] [PATCH v2 09/13] mesa/format_utils: Add a function to convert a mesa_format to an array format

2014-08-02 Thread Jason Ekstrand
-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/main/format_utils.c | 105 +++ src/mesa/main/format_utils.h | 4 ++ 2 files changed, 109 insertions(+) diff --git a/src/mesa/main/format_utils.c b/src/mesa/main/format_utils.c index d60aeb3..95b4612

[Mesa-dev] [PATCH v2 06/13] meas: Gather some common format conversion functions into a single file

2014-08-02 Thread Jason Ekstrand
This initial commit puts all of the RGB - sRGB conversion functions in format_utils.c. v2: Shorter commit subject and added format_utils.c to SConscript Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/Makefile.sources| 1 + src/mesa/SConscript | 1

[Mesa-dev] [PATCH v2 10/13] main/texstore: Split texture storage into three functions

2014-08-02 Thread Jason Ekstrand
makes it much easier to write a more general function upload path for one of these categories than the current function pointers. Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/main/texstore.c | 171 +++ 1 file changed, 100 insertions

[Mesa-dev] [PATCH v2 08/13] mesa/format_utils: Add a general format conversion function

2014-08-02 Thread Jason Ekstrand
including full docs for functions * Don't use __typeof__ * Use inline helpers instead of writing out conversions by hand, * Force full loop unrolling for better performance Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/main/format_utils.c | 844

Re: [Mesa-dev] [PATCH 5/5 v2] i965: Add support for ARB_copy_image

2014-08-04 Thread Jason Ekstrand
as the patch is no longer restricted to a pitch of at most INT16_MAX. Regards, - Neil Jason Ekstrand ja...@jlekstrand.net writes: This, together with the meta path, provides a almost-complete implemetation of ARB_copy_image. The only case that won't work is if one of the textures

Re: [Mesa-dev] [PATCH v2 09/13] mesa/format_utils: Add a function to convert a mesa_format to an array format

2014-08-04 Thread Jason Ekstrand
On Mon, Aug 4, 2014 at 7:55 AM, Brian Paul bri...@vmware.com wrote: On 08/02/2014 02:11 PM, Jason Ekstrand wrote: This commits adds the _mesa_format_to_arary function that determines if the array given format can be represented as an array format and computes the array format

Re: [Mesa-dev] [PATCH v2 08/13] mesa/format_utils: Add a general format conversion function

2014-08-04 Thread Jason Ekstrand
On Mon, Aug 4, 2014 at 7:55 AM, Brian Paul bri...@vmware.com wrote: On 08/02/2014 02:11 PM, Jason Ekstrand wrote: Most format conversion operations required by GL can be performed by converting one channel at a time, shuffling the channels around, and optionally filling missing channels

Re: [Mesa-dev] [PATCH 1/2] xlib: fix missing mesautil build breakage

2014-08-04 Thread Jason Ekstrand
Both patches: Reviewed-by: Jason Ekstrand jason.ekstr...@intel.com On Mon, Aug 4, 2014 at 12:09 PM, Brian Paul bri...@vmware.com wrote: Fixes the non-DRI build. --- src/mesa/drivers/x11/Makefile.am |1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/x11/Makefile.am b

[Mesa-dev] [PATCH] src/Makefile.am: Move gtest before util

2014-08-04 Thread Jason Ekstrand
Since the ralloc test in util/tests needs gtest, we need to make sure that the gtest subdir is loaded first. This fixes bug #82148. Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Makefile.am b

[Mesa-dev] [PATCH] gallium: Add libmesautil dependency to gdm and xa targets

2014-08-04 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/gallium/targets/gbm/Makefile.am | 1 + src/gallium/targets/xa/Makefile.am | 1 + 2 files changed, 2 insertions(+) diff --git a/src/gallium/targets/gbm/Makefile.am b/src/gallium/targets/gbm/Makefile.am index 2345ce3..a5f7070 100644

Re: [Mesa-dev] [PATCH] util: include c99_compat.h in hash_table.h to get 'inline' definition

2014-08-04 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand jason.ekstr...@intel.com On Mon, Aug 4, 2014 at 12:35 PM, Brian Paul bri...@vmware.com wrote: --- src/util/hash_table.h |1 + 1 file changed, 1 insertion(+) diff --git a/src/util/hash_table.h b/src/util/hash_table.h index 9b67f05..d6b6ebf 100644 --- a/src

  1   2   3   4   5   6   7   8   9   10   >