Hi all,
On Tue, Oct 11, 2016 at 01:47:37PM -0400, Robert Foss wrote:
>
>
> On 2016-10-11 01:37 PM, Chad Versace wrote:
> > On Tue 11 Oct 2016, Emil Velikov wrote:
> > > On 10 October 2016 at 20:41, Rob Clark wrote:
> > > > On Mon, Oct 10, 2016 at 1:43 PM, Chad Versace
> > > > wrote:
> >
> >
Hi Chad and Rob,
I took the liberty to run the piglit tests that I submitted against this
series, and it pointed out to a couple errors. Please disregard this if
you already have a newer version of these patches laying around with
those things fixed.
On Mon, Oct 10, 2016 at 10:43:50AM -0700, Chad
On Sat, Oct 29, 2016 at 01:15:44PM -0400, Rob Clark wrote:
> On Fri, Oct 28, 2016 at 7:44 PM, Rafael Antognolli
> wrote:
> > Hi Chad and Rob,
> >
> > I took the liberty to run the piglit tests that I submitted against this
> > series, and it pointed out to a couple
On Mon, Oct 31, 2016 at 08:58:26AM -0700, Rafael Antognolli wrote:
> On Sat, Oct 29, 2016 at 01:15:44PM -0400, Rob Clark wrote:
> > On Fri, Oct 28, 2016 at 7:44 PM, Rafael Antognolli
> > wrote:
...
> > Hey, thanks for this. I don't suppose you have a branch somewhe
On Mon, Nov 07, 2016 at 07:48:25PM -0500, Rob Clark wrote:
> On Mon, Nov 7, 2016 at 6:29 PM, Rafael Antognolli
> wrote:
> > On Mon, Oct 31, 2016 at 08:58:26AM -0700, Rafael Antognolli wrote:
> >> On Sat, Oct 29, 2016 at 01:15:44PM -0400, Rob Clark wrote:
> >> >
The first 4 patches of this series at least (including this one) work
well on i915 when combined with the pending i915 patches for mesa,
libdrm and kernel.
Tested-by: Rafael Antognolli
On Fri, Nov 18, 2016 at 08:39:33AM -0500, Rob Clark wrote:
> From: Rob Clark
>
> With fixes
Enable the use of a transform feedback overflow query with
glBeginConditionalRender. The render commands will only execute if the
query is true (i.e. if there was an overflow).
Use ARB_conditional_render_inverted to change this behavior.
Signed-off-by: Rafael Antognolli
---
src/mesa/drivers
Predication needs cmd parser only on gen7. For newer platforms, it
should be available without it.
Signed-off-by: Rafael Antognolli
---
src/mesa/drivers/dri/i965/intel_extensions.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c
b/src/mesa
Signed-off-by: Rafael Antognolli
---
src/mesa/drivers/dri/i965/intel_extensions.c | 1 +
src/mesa/main/extensions_table.h | 1 +
src/mesa/main/get.c | 1 +
3 files changed, 3 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c
b/src/mesa
piglit tests for it, so it's not very tested, but
the basic functionality seems to work fine. Any feedback is welcome.
Thanks,
Rafael
Rafael Antognolli (6):
mesa: Add types for ARB_transform_feedback_oveflow_query.
i965: add plumbing for ARB_transform_feedback_overflow_query.
i915
Add some basic types and storage for the queries of this extension.
Signed-off-by: Rafael Antognolli
---
src/mesa/main/mtypes.h | 5 +
src/mesa/main/queryobj.c| 21 +
src/mesa/state_tracker/st_cb_queryobj.c | 6 ++
3 files changed
Enable getting the results of a transform feedback overflow query with a
buffer object.
Signed-off-by: Rafael Antognolli
---
src/mesa/drivers/dri/i965/hsw_queryobj.c | 108 +++
1 file changed, 108 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/hsw_queryobj.c
When querying for transform feedback overflow on one or all of the
streams, store information about number of generated and written
primitives. Then check whether generated == written.
Signed-off-by: Rafael Antognolli
---
src/mesa/drivers/dri/i965/brw_queryobj.c | 2 ++
src/mesa/drivers/dri
On Mon, Dec 05, 2016 at 10:57:16AM -0800, Ian Romanick wrote:
> On 12/05/2016 10:16 AM, Rafael Antognolli wrote:
> > Signed-off-by: Rafael Antognolli
> > ---
> > src/mesa/drivers/dri/i965/intel_extensions.c | 1 +
> > src/mesa/main/extensions_table.h | 1
rflow_query&id=c17cf16caa18e44f9d53e05a7279066f8cc2f33c.
I did it on patch #4, but yes, it should have been merged with this
patch. Will do it on next iteration.
> On 12/05/2016 10:16 AM, Rafael Antognolli wrote:
> > Add some basic types and storage for the queries of this extension.
> >
> > Signed-off-by: R
Add some basic types and storage for the queries of this extension.
Signed-off-by: Rafael Antognolli
---
src/mesa/main/extensions_table.h | 1 +
src/mesa/main/mtypes.h | 5 +
2 files changed, 6 insertions(+)
diff --git a/src/mesa/main/extensions_table.h b/src/mesa/main
available for it here:
https://github.com/rantogno/piglit/tree/review/overflow_query-v01
Regards,
Rafael
Rafael Antognolli (7):
mesa: Add types for ARB_transform_feedback_oveflow_query.
mesa: Track transform feedback overflow query objects.
i965: add plumbing for
This extension adds new query types which can be used to detect overflow
of transform feedback buffers. The new query types are also accepted by
conditional rendering commands.
Signed-off-by: Rafael Antognolli
---
docs/features.txt| 2 +-
docs/relnotes/13.1.0.html
When querying for transform feedback overflow on one or all of the
streams, store information about number of generated and written
primitives. Then check whether generated == written.
Signed-off-by: Rafael Antognolli
---
src/mesa/drivers/dri/i965/brw_queryobj.c | 2 ++
src/mesa/drivers/dri
Enable getting the results of a transform feedback overflow query with a
buffer object.
Signed-off-by: Rafael Antognolli
---
src/mesa/drivers/dri/i965/hsw_queryobj.c | 108 +++
1 file changed, 108 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/hsw_queryobj.c
Predication needs cmd parser only on gen7. For newer platforms, it
should be available without it.
Signed-off-by: Rafael Antognolli
---
src/mesa/drivers/dri/i965/intel_extensions.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c
b/src/mesa
Also update checks on conditional rendering.
Signed-off-by: Rafael Antognolli
---
src/mesa/main/condrender.c | 4 +++-
src/mesa/main/queryobj.c| 21 +
src/mesa/state_tracker/st_cb_queryobj.c | 6 ++
3 files changed, 30 insertions(+), 1
Enable the use of a transform feedback overflow query with
glBeginConditionalRender. The render commands will only execute if the
query is true (i.e. if there was an overflow).
Use ARB_conditional_render_inverted to change this behavior.
Signed-off-by: Rafael Antognolli
---
src/mesa/drivers
Add some basic types and storage for the queries of this extension.
v2:
- update date of extension (Kenneth)
Signed-off-by: Rafael Antognolli
---
src/mesa/main/extensions_table.h | 1 +
src/mesa/main/mtypes.h | 5 +
2 files changed, 6 insertions(+)
diff --git a/src/mesa/main
Also update checks on conditional rendering.
Signed-off-by: Rafael Antognolli
---
src/mesa/main/condrender.c | 4 +++-
src/mesa/main/queryobj.c| 21 +
src/mesa/state_tracker/st_cb_queryobj.c | 6 ++
3 files changed, 30 insertions(+), 1
,
Rafael
Rafael Antognolli (7):
mesa: Add types for ARB_transform_feedback_oveflow_query.
mesa: Track transform feedback overflow query objects.
i965: add plumbing for ARB_transform_feedback_overflow_query.
i965: Add support for xfb overflow on query buffer objects.
i965: Add support for
Enable getting the results of a transform feedback overflow query with a
buffer object.
Signed-off-by: Rafael Antognolli
---
src/mesa/drivers/dri/i965/hsw_queryobj.c | 108 +++
1 file changed, 108 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/hsw_queryobj.c
Predication needs cmd parser only on gen7. For newer platforms, it
should be available without it.
Signed-off-by: Rafael Antognolli
---
src/mesa/drivers/dri/i965/intel_extensions.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c
b/src/mesa
-by: Rafael Antognolli
---
src/mesa/drivers/dri/i965/brw_queryobj.c | 2 +
src/mesa/drivers/dri/i965/gen6_queryobj.c | 73 +++
2 files changed, 75 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_queryobj.c
b/src/mesa/drivers/dri/i965/brw_queryobj.c
index
Enable the use of a transform feedback overflow query with
glBeginConditionalRender. The render commands will only execute if the
query is true (i.e. if there was an overflow).
Use ARB_conditional_render_inverted to change this behavior.
Signed-off-by: Rafael Antognolli
---
src/mesa/drivers
This extension adds new query types which can be used to detect overflow
of transform feedback buffers. The new query types are also accepted by
conditional rendering commands.
Signed-off-by: Rafael Antognolli
---
docs/features.txt| 2 +-
docs/relnotes/13.1.0.html
On Fri, Dec 09, 2016 at 10:35:58PM -0800, Jordan Justen wrote:
> On 2016-12-09 13:39:52, Rafael Antognolli wrote:
> > This extension adds new query types which can be used to detect overflow
> > of transform feedback buffers. The new query types are also accepted by
> >
On Mon, Dec 12, 2016 at 10:00:42AM -0800, Jordan Justen wrote:
> On 2016-12-12 07:06:50, Rafael Antognolli wrote:
> > On Fri, Dec 09, 2016 at 10:35:58PM -0800, Jordan Justen wrote:
> > > On 2016-12-09 13:39:52, Rafael Antognolli wrote:
> > > > This extension adds new
On Mon, Dec 12, 2016 at 01:51:01PM -0500, Ilia Mirkin wrote:
> On Mon, Dec 12, 2016 at 1:47 PM, Rafael Antognolli
> wrote:
> >> > It is possible to query for overflow on gen6, so in theory there's no
> >> > reason to not enable it.
> >>
> >>
On Mon, Dec 12, 2016 at 02:40:28PM -0500, Ilia Mirkin wrote:
> On Mon, Dec 12, 2016 at 1:56 PM, Rafael Antognolli
> wrote:
> > On Mon, Dec 12, 2016 at 01:51:01PM -0500, Ilia Mirkin wrote:
> >> On Mon, Dec 12, 2016 at 1:47 PM, Rafael Antognolli
> >> wrote:
> &g
/overflow_query-v03
Regards,
Rafael
Rafael Antognolli (7):
i965: Enable predicate support on gen >= 8.
mesa: Add types for ARB_transform_feedback_oveflow_query.
mesa: Track transform feedback overflow query objects.
i965: add plumbing for ARB_transform_feedback_overflow_query.
i965:
Add some basic types and storage for the queries of this extension.
v2:
- update date of extension (Kenneth)
Signed-off-by: Rafael Antognolli
---
src/mesa/main/extensions_table.h | 1 +
src/mesa/main/mtypes.h | 5 +
2 files changed, 6 insertions(+)
diff --git a/src/mesa/main
Also update checks on conditional rendering.
Signed-off-by: Rafael Antognolli
---
src/mesa/main/condrender.c | 4 +++-
src/mesa/main/queryobj.c| 21 +
src/mesa/state_tracker/st_cb_queryobj.c | 6 ++
3 files changed, 30 insertions(+), 1
Enable getting the results of a transform feedback overflow query with a
buffer object.
Signed-off-by: Rafael Antognolli
---
src/mesa/drivers/dri/i965/hsw_queryobj.c | 108 +++
1 file changed, 108 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/hsw_queryobj.c
This extension adds new query types which can be used to detect overflow
of transform feedback buffers. The new query types are also accepted by
conditional rendering commands.
v3:
- s/gen7+/gen6+/ in the relnotes (Jordan Justen)
Signed-off-by: Rafael Antognolli
---
docs/features.txt
-by: Rafael Antognolli
---
src/mesa/drivers/dri/i965/brw_queryobj.c | 2 +
src/mesa/drivers/dri/i965/gen6_queryobj.c | 73 +++
2 files changed, 75 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_queryobj.c
b/src/mesa/drivers/dri/i965/brw_queryobj.c
index
Enable the use of a transform feedback overflow query with
glBeginConditionalRender. The render commands will only execute if the
query is true (i.e. if there was an overflow).
Use ARB_conditional_render_inverted to change this behavior.
Signed-off-by: Rafael Antognolli
---
src/mesa/drivers
Predication needs cmd parser only on gen7. For newer platforms, it
should be available without it.
Signed-off-by: Rafael Antognolli
---
src/mesa/drivers/dri/i965/intel_extensions.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c
b/src/mesa
Bumping this thread on the list. Does anyone have some spare time to
review it, please? :D
It's still applying cleanly on master. And I believe all the suggestions
were incorporated already.
Thanks,
Rafael
On Tue, Dec 13, 2016 at 02:50:52PM -0800, Rafael Antognolli wrote:
> This patc
Reviewed-by: Rafael Antognolli
On Fri, Jan 18, 2019 at 05:01:58PM +, Lionel Landwerlin wrote:
> Doesn't save us a great deal of lines but at least they get decoded in
> aubinators.
>
> Signed-off-by: Lionel Landwerlin
> ---
> src/intel/genxml/gen10.xml | 2
Accessing bo->map and then pool->center_bo_offset without a lock is
racy. One way of avoiding such race condition is to store the bo->map +
center_bo_offset into pool->map at the time the block pool is growing,
which happens within a lock.
Cc: Jason Ekstrand
Reported-by: Ian Romanick
Bugzilla: h
Accessing bo->map and then pool->center_bo_offset without a lock is
racy. One way of avoiding such race condition is to store the bo->map +
center_bo_offset into pool->map at the time the block pool is growing,
which happens within a lock.
v2: Only set pool->map if not using softpin (Jason).
Cc:
On Wed, Jan 23, 2019 at 06:08:50PM -0600, Jason Ekstrand wrote:
> On Wed, Jan 23, 2019 at 5:26 PM Rafael Antognolli
>
> wrote:
>
> Accessing bo->map and then pool->center_bo_offset without a lock is
> racy. One way of avoiding such race condition
Accessing bo->map and then pool->center_bo_offset without a lock is
racy. One way of avoiding such race condition is to store the bo->map +
center_bo_offset into pool->map at the time the block pool is growing,
which happens within a lock.
v2: Only set pool->map if not using softpin (Jason).
v3: M
Move the pln emul code to the fs_visitor, so we get some optimizations
that don't happen at the fs_generator level, mainly better scheduling.
One big caveat of this change is that we don't use NF types and the
accumulator anymore, but apparently we don't need the extra precision.
https://gitlab.f
On Tue, Feb 05, 2019 at 12:09:45PM +, Emil Velikov wrote:
> From: Emil Velikov
>
> Cc: Rafael Antognolli
> Cc: Jason Ekstrand
> Cc: Dylan Baker
> Fixes: 927ba12b53c ("anv/tests: Adding test for the state_pool padding.")
> Signed-off-by: Emil Velikov
ves.
>
> Cc: Jari Tahvanainen ,
> Cc: Rafael Antognolli
> Cc: Kenneth Graunke
> ---
> Always double check before you hit send.
> ---
> src/mesa/drivers/dri/i965/brw_defines.h | 1 +
> src/mesa/drivers/dri/i965/brw_draw.c| 7 +++
> 2 files changed, 8 insert
On Tue, Mar 05, 2019 at 07:50:24PM +, Chris Wilson wrote:
> Quoting Rafael Antognolli (2019-03-05 19:33:03)
> > On Tue, Mar 05, 2019 at 09:40:20AM +, Chris Wilson wrote:
> > > Not all commands support being preempted as they execute, and for those
> > > make
It seems pretty useless nowadays.
---
src/mesa/drivers/dri/i965/brw_blorp.c | 36 +--
1 file changed, 12 insertions(+), 24 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c
b/src/mesa/drivers/dri/i965/brw_blorp.c
index 97a5f6a9937..e09a8cef762 100644
--- a/s
ss here is that the documentation is wrong and that this
field is actually 6 bits long, instead of 5.
Additionally, the same happens on Haswell, with these fields being 7
bits long instead of 6.
Signed-off-by: Rafael Antognolli
---
src/intel/genxml/gen7.xml | 20
src/intel/g
ction
anymore.
Signed-off-by: Rafael Antognolli
---
src/mesa/drivers/dri/i965/brw_context.h | 10 +-
src/mesa/drivers/dri/i965/brw_state.h | 2 -
src/mesa/drivers/dri/i965/gen6_urb.c | 152 -
src/mesa/drivers/dri/i965/gen7_urb.c | 92 -
The GENX_DECL() macro is used to declare prototypes of a given function
to each gen, so we don't have to manually add each of them to headers.
The second macro, genX_find(), is used to call the right function for
the running gen, but from code that is not gen specific.
Signed-off-by: R
just
ignored. This patch fixes that before we convert the urb state emission to
genxml.
Signed-off-by: Rafael Antognolli
---
src/mesa/drivers/dri/i965/gen6_urb.c| 4 ++--
src/mesa/drivers/dri/i965/genX_blorp_exec.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --g
lso consider it:
Reviewed-by: Rafael Antognolli
> > V2: Rebased.
> >
> > Signed-off-by: Anuj Phogat
> > ---
> > src/mesa/drivers/dri/i965/brw_blorp.c| 6 +++---
> > src/mesa/drivers/dri/i965/brw_state.h| 8
> > src/mesa/d
On Fri, May 12, 2017 at 04:38:10PM -0700, Anuj Phogat wrote:
> These declarations will help the code start compiling
> once we wire up the makefiles for gen10. Later patches
> will start using these functions for gen10.
>
> Signed-off-by: Anuj Phogat
> ---
> src/intel/isl/isl_priv.h
On Wed, May 24, 2017 at 10:12:12AM -0700, Anuj Phogat wrote:
> On Mon, May 22, 2017 at 11:23 AM, Anuj Phogat wrote:
> > On Mon, May 22, 2017 at 10:07 AM, Rafael Antognolli
> > wrote:
> >> On Fri, May 12, 2017 at 04:38:10PM -0700, Anuj Phogat wrote:
> >>> T
On Tue, May 30, 2017 at 08:59:06PM +0100, Lionel Landwerlin wrote:
> The current way of handling groups doesn't seem to be able to handle
> MI_LOAD_REGISTER_* with more than one register.
Hi Lionel, I don't think this is entirely true. I have added support to read
variable length structs on commit
We already have a function to dump sampler states, so do that for gen6
too.
Signed-off-by: Rafael Antognolli
---
src/intel/tools/aubinator.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c
index 53b2a27..b1f1ff0 100644
Also convert some auxiliary functions used by it, and copy
upload_default_color to genX_state_upload.c.
Signed-off-by: Rafael Antognolli
---
src/mesa/drivers/dri/i965/brw_sampler_state.c | 18 -
src/mesa/drivers/dri/i965/brw_state.h | 1 -
src/mesa/drivers/dri/i965
The sampler state code was all moved to genxml, so we can get rid of these
functions and delete the file.
Signed-off-by: Rafael Antognolli
---
src/mesa/drivers/dri/i965/Makefile.sources| 1 -
src/mesa/drivers/dri/i965/brw_sampler_state.c | 623 --
2 files changed
Based on the current code, gen5 and gen6 have the same sampler border color
state struct. So fix the gen5 one to match gen6.
Signed-off-by: Rafael Antognolli
---
src/intel/genxml/gen5.xml | 40
1 file changed, 20 insertions(+), 20 deletions(-)
diff
Since they just use the code that is already available in genX_state_upload.c,
convert them in one batch.
Signed-off-by: Rafael Antognolli
---
src/mesa/drivers/dri/i965/brw_sampler_state.c | 109 -
src/mesa/drivers/dri/i965/brw_state.h | 5 -
src/mesa/drivers/dri
This function was moved to genX_state_upload.c but was still not using genxml.
By converting it to genxml, we make some things simpler, like setting
haswell's border color state, but others are more complex, since the structs
used by each gen are different.
Signed-off-by: Rafael Antog
This series is
Reviewed-by: Rafael Antognolli
On Wed, May 31, 2017 at 01:17:45AM -0700, Kenneth Graunke wrote:
> We can just update the gl_transform_feedback_info fields at link time
> to make the VUE header fields have the right location and component.
> Then we don't need
Reviewed-by: Rafael Antognolli
On Wed, May 10, 2017 at 11:47:27AM -0700, Kenneth Graunke wrote:
> This effectively reverts Robert Ellison's 2009 commit
> cc8afbd3862fedfe42e51c3774960d1c7078ec53.
>
> I'm not seeing any GL spec text indicating that UPPER won't work.
&g
Reviewed-by: Rafael Antognolli
On Wed, May 10, 2017 at 11:47:28AM -0700, Kenneth Graunke wrote:
> It's a U3.1. It became a U3.7 on Sandybridge.
> ---
> src/intel/genxml/gen4.xml | 2 +-
> src/intel/genxml/gen45.xml | 2 +-
> src/intel/genxml/gen5.xml | 2 +-
> 3 file
Makes sense to me.
Reviewed-by: Rafael Antognolli
On Wed, May 10, 2017 at 11:47:29AM -0700, Kenneth Graunke wrote:
> This unifies the Gen4-5 and Gen6+ line width calculations.
>
> I believe it also fixes a bug - we weren't rounding the line width
> to the nearest integer. T
Reviewed-by: Rafael Antognolli
On Wed, May 10, 2017 at 11:47:30AM -0700, Kenneth Graunke wrote:
> This updates the Gen4-5 code to use a line end cap width of 0.5
> for non-smooth lines, and 1.0 for smooth lines - which is what we
> do on Gen6+.
> ---
> src/mesa/drivers/dri/i965
Reviewed-by: Rafael Antognolli
On Wed, May 10, 2017 at 11:47:25AM -0700, Kenneth Graunke wrote:
> Apparently, Nanhai made the Gen4-5 point size calculations round to the
> nearest integer in commit 8d5231a3582e4f2769ac0685cf0174e09750700e,
> "according to spec". When Er
Since we created the file, we should be able to reopen it for appending, but
some weird filesystem error could cause that to be false. So simply check
whether we could reopen it or not.
CID: 1177144
Signed-off-by: Rafael Antognolli
---
src/mesa/main/debug.c | 5 +
1 file changed, 5
**atts)
> +{
> + if (ctx->group->nfields == ctx->group->fields_size) {
> + ctx->group->fields_size = MAX(ctx->group->fields_size * 2, 2);
> +
> + if (!ctx->group->fields) {
> + ctx->group->fields =
> +(struct gen
Rename "Use Point Width State" to "Point Width Source". It accepts the same
values and has the same meaning as gen6+, so lets keep them with the same name
to simplify the code.
Signed-off-by: Rafael Antognolli
---
src/intel/genxml/gen4.xml | 6 +++---
src/intel/genxml/gen45
This series converts SF_STATE, COLOR_CALC_STATE adn BLEND_CONSTANT_COLOR state
to use genxml. It has to be applied on top of this series from Ken:
https://patchwork.freedesktop.org/series/24245/
Kenneth Graunke (1):
i965: Make a helper function for depth/stencil related state.
Rafael
It seems that it was never set correctly.
Signed-off-by: Rafael Antognolli
---
src/mesa/drivers/dri/i965/brw_structs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/brw_structs.h
b/src/mesa/drivers/dri/i965/brw_structs.h
index 35db2f5..73641da
This fixes code generation on gen45.
Signed-off-by: Rafael Antognolli
---
src/intel/genxml/gen45.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/intel/genxml/gen45.xml b/src/intel/genxml/gen45.xml
index 46d1949..59460fd 100644
--- a/src/intel/genxml/gen45.xml
+++ b
Use set_blend_entry_bits and set_depth_stencil_bits to fill most of the
color calc struct, and then manually update the rest.
Signed-off-by: Rafael Antognolli
---
src/mesa/drivers/dri/i965/brw_cc.c| 174 --
src/mesa/drivers/dri/i965/brw_state.h | 1
This patch finishes the work done by Ken of converting SF_STATE to genxml, and
merges it with gen6+ code for emitting that state.
Signed-off-by: Rafael Antognolli
---
src/mesa/drivers/dri/i965/Makefile.sources| 1 -
src/mesa/drivers/dri/i965/brw_sf_state.c | 200
to me, this change also seems to fix fbo-blending-formats piglit test on
gen4.
Signed-off-by: Rafael Antognolli
---
src/mesa/drivers/dri/i965/brw_cc.c | 21 -
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_cc.c
b/src/mesa/drivers/dr
It's a very simple conversion, and it allows us to delete brw_cc.c.
Signed-off-by: Rafael Antognolli
---
src/mesa/drivers/dri/i965/Makefile.sources| 1 -
src/mesa/drivers/dri/i965/brw_cc.c| 62 ---
src/mesa/drivers/dri/i965/genX_state_upload.c
From: Kenneth Graunke
Gen4-5 basically glue DEPTH_STENCIL_STATE, COLOR_CALC_STATE, and
BLEND_STATE together into a single COLOR_CALC_STATE structure.
By making a helper function, we'll be able to reuse it when filling
out Gen4-5 COLOR_CALC_STATE without replicating any actual logic.
We use gene
Add a helper function to reuse code that fills blend entry related
state, and make genX(upload_blend_state) use it. This function can later
be used by gen4-5 color calc state to set the blend related bits.
Signed-off-by: Rafael Antognolli
---
src/mesa/drivers/dri/i965/genX_state_upload.c | 155
"Anti-aliasing Enable" to "Anti-Aliasing Enable".
Signed-off-by: Rafael Antognolli
---
src/intel/genxml/gen4.xml | 2 +-
src/intel/genxml/gen45.xml | 2 +-
src/intel/genxml/gen5.xml | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/intel/genxml/
Reviewed-by: Rafael Antognolli
On Wed, May 10, 2017 at 11:47:26AM -0700, Kenneth Graunke wrote:
> Modern GL specifications say that the point size should be 1.0 when
> gl_PointSize is unwritten and the last enabled stage is a geometry
> or tessellation shader. If it's a vertex
Reviewed-by: Rafael Antognolli
On Tue, Jun 13, 2017 at 11:28:23AM -0700, Anuj Phogat wrote:
> Signed-off-by: Anuj Phogat
> ---
> src/intel/genxml/gen10.xml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/intel/genxml/gen10.xml b/src/intel/genxml
This looks weird since it is the only value in this instruction which
the name doesn't look like a macro (with all caps). But it's not the
first case in all the xml's, so it's probably fine:
Reviewed-by: Rafael Antognolli
>
>
>
> --
> 2.9.
Reviewed-by: Rafael Antognolli
On Tue, Jun 13, 2017 at 11:28:22AM -0700, Anuj Phogat wrote:
> Signed-off-by: Anuj Phogat
> ---
> src/intel/genxml/gen10.xml | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/src/intel/genxml/gen10.xml b/src/inte
On Thu, Oct 19, 2017 at 10:32:46AM -0700, Dylan Baker wrote:
> Otherwise -Dgallium-drivers= will cause libmesa_gallium to be built and
> the megadriver install script to attempt to install drivers without any
> actual drivers being built.
Tested-by: Rafael Antognolli
On Mon, Oct 23, 2017 at 08:46:26AM -0700, Anuj Phogat wrote:
> Ping. Patches 2-4 in this series are still waiting for review.
> Anyone interested?
> Thanks!
>
>
>
> On Fri, Oct 13, 2017 at 3:35 PM, Rafael Antognolli
> wrote:
> > Hi Anuj, sorry that I misse
gt; >> > optimization enable bit.
> >> >
> >> Right. After looking at all other fields, I don't think we want to set
> >> any of them except one. That field is "Slice Hashing Table Enable" which
> >> says:
> >> "For gen
/mesa/drivers/dri/i965/genX_state_upload.c
> @@ -3117,9 +3117,8 @@ genX(upload_push_constant_packets)(struct brw_context
> *brw)
>}
>
>stage_state->push_constants_dirty = false;
> + brw->ctx.NewDriverState |= GEN_GEN >= 9 ? BRW_NEW_SURFACES : 0;
> }
>
On Fri, Jul 14, 2017 at 09:13:49AM +0100, Chris Wilson wrote:
> Quoting Zhongmin Wu (2017-07-14 07:55:45)
> > Before we queued the buffer with a invalid fence (-1), it will
> > make some benchmarks failed to test such as flatland.
> >
> > Now we get the out fence during the flushing buffer and the
On Sat, Jul 15, 2017 at 01:52:43AM +0900, Tomasz Figa wrote:
> Hi Rafael,
>
> On Sat, Jul 15, 2017 at 1:45 AM, Rafael Antognolli
> wrote:
> > On Fri, Jul 14, 2017 at 09:13:49AM +0100, Chris Wilson wrote:
> >> Quoting Zhongmin Wu (2017-07-14 07:55:45)
> [snip]
>
On Sat, Jul 15, 2017 at 01:58:19AM +0900, Tomasz Figa wrote:
> > So, the right place to do so would be inside platform_android.c,
> > right? And since I don't see any private struct that could store such fence
> > there, one option would be to extend the struct dri2_egl_surface for
> > android,
>
Add the code into its own function and atom, since almost nothing is
shared with GEN >= 6.
v2: Split GEN <=5 and GEN >= 6 into separate functions (Ken).
Signed-off-by: Rafael Antognolli
Cc: Kenneth Graunke
---
src/mesa/drivers/dri/i965/Makefile.sources| 1 -
src/mesa/drivers
gen4 have commands which start with KernelStartPointer, which is a
struct, so if we initialize it struct = { 0 }, we get warnings on some
compilers.
This macro works around that and will silent such warnings.
Signed-off-by: Rafael Antognolli
Cc: Jason Ekstrand
---
src/mesa/drivers/dri/i965
1 - 100 of 597 matches
Mail list logo
