[Mesa-dev] [PATCH 3/3] vc4: Enable Neon on arm builds

2017-01-30 Thread Rob Herring
Signed-off-by: Rob Herring --- src/gallium/drivers/vc4/Android.mk | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/vc4/Android.mk b/src/gallium/drivers/vc4/Android.mk index de9d5e3f5b3c..fdc06744e5ab 100644 --- a/src/gallium/drivers/vc4/Android.mk +++ b/src/gallium

[Mesa-dev] [PATCH 1/3] vc4: Make Neon inline assembly clang compatible

2017-01-30 Thread Rob Herring
no need for trailing ";" either, so remove those, too. Signed-off-by: Rob Herring --- Eric, I *think* this is correct, but completely untested other than compiled on Android. Rob src/gallium/drivers/vc4/vc4_tiling_lt.c | 70 - 1 file changed, 35 ins

[Mesa-dev] [PATCH 2/3] vc4: fix arm64 build with Neon

2017-01-30 Thread Rob Herring
The addition of Neon assembly breaks on arm64 builds because the assembly syntax is different. For now, restrict Neon to ARMv7 builds. Signed-off-by: Rob Herring --- src/gallium/drivers/vc4/vc4_tiling.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/vc4

Re: [Mesa-dev] Mesa 12.1.0 release plan (Was Re: Next Mesa release, anyone?)

2016-10-04 Thread Rob Herring
On Tue, Oct 4, 2016 at 5:26 AM, Emil Velikov wrote: > On 4 October 2016 at 02:05, Rob Clark wrote: >> On Thu, Sep 29, 2016 at 10:56 AM, Emil Velikov >> wrote: >>> On 28 September 2016 at 19:53, Marek Olšák wrote: Hi, It's been almost 4 months since the 12.0 branch was created, a

[Mesa-dev] Fwd: errors for mesa master Android build 440

2016-10-10 Thread Rob Herring
New Android build error for gen6_xml.h... -- Forwarded message -- From: Date: Sat, Oct 8, 2016 at 3:56 AM Subject: errors for mesa master Android build 440 To: rob.herr...@linaro.org Build URL: https://ci.linaro.org/jenkins/job/robher-aosp/440/ Full log: https://ci.linaro.org/j

Re: [Mesa-dev] [PATCH v2 6/7] egl/android: Add support for YV12 pixel format (v2)

2016-08-08 Thread Rob Herring
On Mon, Aug 8, 2016 at 1:39 PM, Chad Versace wrote: > On 08/02/2016 04:07 AM, Tomasz Figa wrote: >> >> This patch adds support for YV12 pixel format to the Android platform >> backend. Only creating EGL images is supported, it is not added to the >> list of available visuals. >> >> v2: Use const a

Re: [Mesa-dev] [PATCH 1/8] intel: Add a new "common" library for more code sharing

2016-09-01 Thread Rob Herring
On Wed, Aug 31, 2016 at 3:56 PM, Jason Ekstrand wrote: > The first thing to go in this new library is brw_device_info. > > Signed-off-by: Jason Ekstrand > Cc: Rob Herring > --- > > The android build files I just copied-and-pasted from blorp but I don't > have an a

Re: [Mesa-dev] [PATCH 1/8] intel: Add a new "common" library for more code sharing

2016-09-01 Thread Rob Herring
On Thu, Sep 1, 2016 at 12:37 PM, Mauro Rossi wrote: > Thanks > > Doing a first attempt in building, there is currently some generated > code missing in android build for recent gsls changes, > due to commit ee3cdac7857a5c0f30108e1b1963d042f2a5e8e6 "glsl: Use the > generated constant expression cod

[Mesa-dev] [PATCH] Android: glsl: add rules to generate ir_expression*.h header files

2016-09-01 Thread Rob Herring
even if there's no linking dependency. That is the case here. Instead, we explicitly add the include path using $(MESA_GEN_GLSL_H) to libmesa_compiler. This in turn requires shuffling the order of make includes. It also uncovered missing dependency tracking of glsl_parser.h. Signed-off-by

[Mesa-dev] [PATCH] amd/addrlib: limit fastcall/regparm to i386

2016-10-20 Thread Rob Herring
The use of regparm causes an error on arm/arm64 builds with clang. fastcall is allowed, but still throws a warning. As both options only have effect on 32-bit x86 builds, limit them to that case. Signed-off-by: Rob Herring --- src/amd/addrlib/addrtypes.h | 10 +++--- 1 file changed, 7

[Mesa-dev] [PATCH] egl/android: implement minimal swap_buffers_with_damage

2016-10-21 Thread Rob Herring
rlying EGL implementation. As there doesn't seem to be a simple way conditionally make the EGL function ptr NULL, just implement a brain dead version for Android EGL. Cc: Rob Clark Cc: Eric Engestrom Cc: Emil Velikov Signed-off-by: Rob Herring --- src/egl/drivers/dri2/platform_android.c | 10 +++

Re: [Mesa-dev] [PATCH] egl/android: implement minimal swap_buffers_with_damage

2016-10-24 Thread Rob Herring
On Mon, Oct 24, 2016 at 3:34 AM, Eric Engestrom wrote: > On Friday, 2016-10-21 16:07:07 -0500, Rob Herring wrote: >> Since commit 0a606a400fe3 ("egl: add eglSwapBuffersWithDamageKHR"), >> Android has been broken because the function eglSwapBuffersWithDamageKHR >>

Re: [Mesa-dev] [PATCH] amd/addrlib: limit fastcall/regparm to i386

2016-10-24 Thread Rob Herring
On Sat, Oct 22, 2016 at 1:08 AM, Jason Ekstrand wrote: > On Fri, Oct 21, 2016 at 10:58 PM, Dave Airlie wrote: >> >> On 22 Oct. 2016 15:51, "Jason Ekstrand" wrote: >> > >> > Wait... Why are we building the AMD driver on ARM? I know AMD has been >> > talking about ARM-based servers, but are they

Re: [Mesa-dev] [PATCH mesa] egl/dri2: swap_buffers_with_damage falls back to swap_buffers

2016-10-24 Thread Rob Herring
On Mon, Oct 24, 2016 at 5:41 PM, Eric Engestrom wrote: > CC: Rob Herring > CC: Rob Clark > Suggested-by: Emil Velikov > Signed-off-by: Eric Engestrom Good, you beat me to it. Reviewed-by: Rob Herring > --- > src/egl/drivers/dri2/egl_dri2_fallbacks.h | 3 ++- &g

Re: [Mesa-dev] [RFC] mesa: drop current draw/read buffer when ctx is released

2016-10-28 Thread Rob Herring
+Mauro, Chih-Wei On Fri, Oct 28, 2016 at 7:22 AM, Rob Clark wrote: > On Fri, Oct 28, 2016 at 1:24 AM, Tapani Pälli wrote: >> On 10/27/2016 01:48 PM, Rob Clark wrote: >>> >>> On Thu, Oct 27, 2016 at 2:59 AM, Tapani Pälli >>> wrote: On 10/27/2016 12:16 AM, Rob Clark wrote: > > S

Re: [Mesa-dev] [RFC] mesa: drop current draw/read buffer when ctx is released

2016-10-28 Thread Rob Herring
On Fri, Oct 28, 2016 at 9:14 AM, Emil Velikov wrote: > On 28 October 2016 at 13:22, Rob Clark wrote: >> On Fri, Oct 28, 2016 at 1:24 AM, Tapani Pälli wrote: >>> On 10/27/2016 01:48 PM, Rob Clark wrote: On Thu, Oct 27, 2016 at 2:59 AM, Tapani Pälli wrote: > > On 10/27/2016

Re: [Mesa-dev] [PATCH] amd/addrlib: limit fastcall/regparm to GCC i386

2016-11-02 Thread Rob Herring
gt; > v2: keep the __i386__ within GCC (Nicolai) > > Cc: 13.0 > Cc: Rob Herring > Cc: Nicolai Hähnle > Signed-off-by: Emil Velikov Thanks for respinning this for me. Reviewed-by: Rob Herring Rob ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH] amd/addrlib: limit fastcall/regparm to GCC i386

2016-11-09 Thread Rob Herring
On Wed, Nov 2, 2016 at 10:42 PM, Rob Herring wrote: > On Wed, Nov 2, 2016 at 10:32 AM, Emil Velikov > wrote: >> From: Emil Velikov >> >> The use of regparm causes an error on arm/arm64 builds with clang. >> fastcall is allowed, but still throws a warning. As both

[Mesa-dev] Fwd: errors for mesa master Android build 554

2016-11-15 Thread Rob Herring
This commit breaks the build for Android. Looks like a prototype is missing and LLVM is stricter. Rob commit 1a21d21580965eff751414d140b3c1762eb3 Author: Christian Gmeiner Date: Thu Nov 3 15:25:21 2016 +0100 dri: make use of dri_get_extensions_name(..) helper Signed-off-by: Chris

Re: [Mesa-dev] EGL/android: pbuffer implementation.

2016-11-21 Thread Rob Herring
s/dri2/platform_android.c | 98 >>> + >>> 2 files changed, 78 insertions(+), 23 deletions(-) >>> >> >> Looks like this patch has already landed, but please let me try to >> confirm some things here anyway. Would you mind ke

Re: [Mesa-dev] [PATCH 07/10] egl/android: Make drm_gralloc headers optional

2016-07-16 Thread Rob Herring
On Fri, Jul 15, 2016 at 2:53 AM, Tomasz Figa wrote: > We can support render nodes alone without any private headers, so let's > make support for control nodes depend on presence of private drm_gralloc > headers. This is a complicated change for what amounts to just needing the flink name out of t

Re: [Mesa-dev] [PATCH 08/10] egl/android: Make get_fourcc() accept HAL formats

2016-07-16 Thread Rob Herring
On Fri, Jul 15, 2016 at 2:53 AM, Tomasz Figa wrote: > There are DRI_IMAGE_FOURCC macros, for which there are no corresponding > DRI_IMAGE_FORMAT macros. To support such formats we need to make the > lookup function take the native format directly. As a side effect, it > simplifies all existing cal

Re: [Mesa-dev] [PATCH] virgl: add exported dmabuf to BO hash table

2016-07-18 Thread Rob Herring
On Fri, Jun 17, 2016 at 5:25 PM, Rob Herring wrote: > Exported dmabufs can get imported by the same process, but the handle was > not getting added to the hash table on export. Add the handle to the hash > table on export. Ping. Dave, can you please apply. Rob > > Cc: Dave Airli

Re: [Mesa-dev] [PATCH 00/10] egl/android: Improve the Android EGL backend

2016-07-18 Thread Rob Herring
On Fri, Jul 15, 2016 at 2:53 AM, Tomasz Figa wrote: > Hi, > > This series is a collection of various fixes and extensions we came up > with during our attempt to use Mesa for Android. > > Fixes included in this series: > - added mandatory EGL_MAX_PBUFFER_WIDTH and _HEIGHT attributes to EGL >c

Re: [Mesa-dev] [PATCH 10/10] egl/android: Add fallback to kms_swrast driver

2016-07-19 Thread Rob Herring
On Fri, Jul 15, 2016 at 2:53 AM, Tomasz Figa wrote: > If no hardware driver is present, it is possible to fall back to > the kms_swrast driver with any DRI node that supports dumb GEM create > and mmap IOCTLs with softpipe/llvmpipe drivers. This patch makes the > Android EGL platform code retry pr

Re: [Mesa-dev] [PATCH 10/10] egl/android: Add fallback to kms_swrast driver

2016-07-20 Thread Rob Herring
On Wed, Jul 20, 2016 at 12:53 AM, Tomasz Figa wrote: > On Wed, Jul 20, 2016 at 7:40 AM, Rob Herring wrote: >> On Fri, Jul 15, 2016 at 2:53 AM, Tomasz Figa wrote: >>> If no hardware driver is present, it is possible to fall back to >>> the kms_swrast driver with any

Re: [Mesa-dev] [PATCH 00/10] egl/android: Improve the Android EGL backend

2016-07-20 Thread Rob Herring
On Mon, Jul 18, 2016 at 11:29 PM, Tomasz Figa wrote: > On Tue, Jul 19, 2016 at 12:35 PM, Rob Herring wrote: >> On Fri, Jul 15, 2016 at 2:53 AM, Tomasz Figa wrote: >>> Hi, >>> >>> This series is a collection of various fixes and extensions we came up >>

Re: [Mesa-dev] [PATCH 06/10] egl/android: Fix support for pbuffers

2016-07-20 Thread Rob Herring
On Fri, Jul 15, 2016 at 2:53 AM, Tomasz Figa wrote: > From: Nicolas Boichat > > Existing image loader code supports creating images only for window > surfaces. Moreover droid_create_surface() passes wrong surface type to > dri2_get_dri_config(), resulting in incorrect configs being returned for >

[Mesa-dev] [PATCH 00/11] *** S

2016-07-20 Thread Rob Herring
*** BLURB HERE *** Rob Herring (11): gallium: move pipe_screen destroy into pipe-loader pipe-loader-drm: protect create_screen() calls with a mutex gallium: add common pipe_screen reference counting functions pipe-loader-drm: use pipe_screen_unreference to destroy screen nouveau: use

[Mesa-dev] [PATCH 01/11] gallium: move pipe_screen destroy into pipe-loader

2016-07-20 Thread Rob Herring
In preparation to add reference counting of pipe_screen in the pipe-loader, pipe_loader_release needs to destroy the pipe_screen instead of state trackers. Signed-off-by: Rob Herring Cc: Emil Velikov --- src/gallium/auxiliary/pipe-loader/pipe_loader.h | 1 + src/gallium/auxiliary/pipe

[Mesa-dev] [PATCH 03/11] gallium: add common pipe_screen reference counting functions

2016-07-20 Thread Rob Herring
implementations. Signed-off-by: Rob Herring --- src/gallium/auxiliary/Makefile.sources | 2 + src/gallium/auxiliary/util/u_screen.c | 114 + src/gallium/auxiliary/util/u_screen.h | 32 + src/gallium/include/pipe/p_screen.h| 3 + 4 files changed, 151

[Mesa-dev] [PATCH 02/11] pipe-loader-drm: protect create_screen() calls with a mutex

2016-07-20 Thread Rob Herring
Creating a screen needs to be serialized in order to support reusing existing screen. With this, driver private mutexes in create_screen() functions can be removed. Signed-off-by: Rob Herring Cc: Emil Velikov --- src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c | 5 + 1 file changed, 5

[Mesa-dev] [PATCH v3 00/11] Common pipe screen ref counting

2016-07-20 Thread Rob Herring
table into u_screen.c Rob Rob Herring (11): gallium: move pipe_screen destroy into pipe-loader pipe-loader-drm: protect create_screen() calls with a mutex gallium: add common pipe_screen reference counting functions pipe-loader-drm: use pipe_screen_unreference to destroy screen nouveau

[Mesa-dev] [PATCH v3 08/11] radeon: use common screen ref counting

2016-07-20 Thread Rob Herring
Use the common pipe_screen ref counting and fd hashing functions. The mutex can be dropped as the pipe loader protects the create_screen() calls. Signed-off-by: Rob Herring Cc: "Marek Olšák" Cc: Ilia Mirkin --- src/gallium/drivers/r300/r300_screen.c| 3 - src/gallium/dr

[Mesa-dev] [PATCH v3 06/11] freedreno: use common screen ref counting

2016-07-20 Thread Rob Herring
Use the common pipe_screen ref counting and fd hashing functions. The mutex can be dropped as the pipe loader protects the create_screen() calls. Signed-off-by: Rob Herring Cc: Rob Clark --- src/gallium/drivers/freedreno/freedreno_screen.c | 1 - src/gallium/drivers/freedreno

[Mesa-dev] [PATCH v3 05/11] nouveau: use common screen ref counting

2016-07-20 Thread Rob Herring
Use the common pipe_screen ref counting and fd hashing functions. The mutex can be dropped as the pipe loader protects the create_screen() calls. Signed-off-by: Rob Herring Cc: Alexandre Courbot --- src/gallium/drivers/nouveau/nouveau_screen.c | 6 -- src/gallium/drivers/nouveau

[Mesa-dev] [PATCH v3 07/11] amdgpu: use common screen ref counting

2016-07-20 Thread Rob Herring
() calls. Signed-off-by: Rob Herring Cc: "Marek Olšák" Cc: Ilia Mirkin --- src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c | 45 --- src/gallium/winsys/amdgpu/drm/amdgpu_winsys.h | 1 - 2 files changed, 6 insertions(+), 40 deletions(-) diff --git a/src/gallium/winsys/

[Mesa-dev] [PATCH v3 02/11] pipe-loader-drm: protect create_screen() calls with a mutex

2016-07-20 Thread Rob Herring
Creating a screen needs to be serialized in order to support reusing existing screen. With this, driver private mutexes in create_screen() functions can be removed. Signed-off-by: Rob Herring Cc: Emil Velikov --- src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c | 5 + 1 file changed, 5

[Mesa-dev] [PATCH v3 09/11] vmwgfx: use common screen ref counting

2016-07-20 Thread Rob Herring
Use the common pipe_screen ref counting and fd hashing functions. The mutex can be dropped as the pipe loader protects the create_screen() calls. Signed-off-by: Rob Herring --- src/gallium/winsys/svga/drm/vmw_screen.c | 51 src/gallium/winsys/svga/drm

[Mesa-dev] [PATCH v3 01/11] gallium: move pipe_screen destroy into pipe-loader

2016-07-20 Thread Rob Herring
In preparation to add reference counting of pipe_screen in the pipe-loader, pipe_loader_release needs to destroy the pipe_screen instead of state trackers. Signed-off-by: Rob Herring Cc: Emil Velikov --- src/gallium/auxiliary/pipe-loader/pipe_loader.h | 1 + src/gallium/auxiliary/pipe

[Mesa-dev] [PATCH v3 04/11] pipe-loader-drm: use pipe_screen_unreference to destroy screen

2016-07-20 Thread Rob Herring
Use pipe_screen_unreference as it will call pipe_screen->destroy() when the pipe_screen is no longer referenced. The pipe_screen referencing is done within create_screen() functions as drivers (like amdgpu) may have special needs for ref counting. Signed-off-by: Rob Herring Cc: Emil Veli

[Mesa-dev] [PATCH v3 03/11] gallium: add common pipe_screen reference counting functions

2016-07-20 Thread Rob Herring
implementations. Signed-off-by: Rob Herring --- src/gallium/auxiliary/Makefile.sources | 2 + src/gallium/auxiliary/util/u_screen.c | 114 + src/gallium/auxiliary/util/u_screen.h | 32 + src/gallium/include/pipe/p_screen.h| 3 + 4 files changed, 151

[Mesa-dev] [PATCH v3 10/11] vc4: use common screen ref counting

2016-07-20 Thread Rob Herring
Use the common pipe_screen ref counting and fd hashing functions. The mutex can be dropped as the pipe loader protects the create_screen() calls. Cc: Eric Anholt Signed-off-by: Rob Herring --- src/gallium/winsys/vc4/drm/vc4_drm_winsys.c | 9 - 1 file changed, 8 insertions(+), 1

[Mesa-dev] [PATCH v3 11/11] virgl: use common screen ref counting

2016-07-20 Thread Rob Herring
Use the common pipe_screen ref counting and fd hashing functions. The mutex can be dropped as the pipe loader protects the create_screen() calls. The fd does not need to be dup'ed as the caller has already done that. Signed-off-by: Rob Herring Cc: Dave Airlie --- src/gallium/winsys/virg

Re: [Mesa-dev] [PATCH v3 05/11] nouveau: use common screen ref counting

2016-07-20 Thread Rob Herring
On Wed, Jul 20, 2016 at 5:32 PM, Ilia Mirkin wrote: > On Wed, Jul 20, 2016 at 6:29 PM, Ilia Mirkin wrote: >> On Wed, Jul 20, 2016 at 6:25 PM, Rob Herring wrote: >>> Use the common pipe_screen ref counting and fd hashing functions. The >>> mutex can be dropped as t

Re: [Mesa-dev] [PATCH 06/10] egl/android: Fix support for pbuffers

2016-07-21 Thread Rob Herring
On Thu, Jul 21, 2016 at 12:35 AM, Tomasz Figa wrote: > On Thu, Jul 21, 2016 at 6:19 AM, Rob Herring wrote: >> On Fri, Jul 15, 2016 at 2:53 AM, Tomasz Figa wrote: >>> From: Nicolas Boichat >>> >>> Existing image loader code supports creating images on

[Mesa-dev] [PATCH v4 00/11] Common pipe screen ref counting

2016-07-22 Thread Rob Herring
drm_device. Only the last one closed was getting freed. - Move mutex for fd hash table into u_screen.c Rob Rob Herring (11): gallium: move pipe_screen destroy into pipe-loader pipe-loader-drm: protect create_screen() calls with a mutex gallium: add common pipe_screen reference counting

[Mesa-dev] [PATCH v4 09/11] vmwgfx: use common screen ref counting

2016-07-22 Thread Rob Herring
Use the common pipe_screen ref counting and fd hashing functions. The mutex can be dropped as the pipe loader protects the create_screen() calls. Signed-off-by: Rob Herring --- src/gallium/auxiliary/target-helpers/drm_helper.h | 2 +- src/gallium/drivers/svga/svga_public.h| 2

[Mesa-dev] [PATCH v4 02/11] pipe-loader-drm: protect create_screen() calls with a mutex

2016-07-22 Thread Rob Herring
Creating a screen needs to be serialized in order to support reusing existing screen. With this, driver private mutexes in create_screen() functions can be removed. Signed-off-by: Rob Herring Cc: Emil Velikov --- src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c | 5 + 1 file changed, 5

[Mesa-dev] [PATCH v4 07/11] amdgpu: use common screen ref counting

2016-07-22 Thread Rob Herring
() calls. Signed-off-by: Rob Herring Cc: "Marek Olšák" Cc: Ilia Mirkin --- src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c | 45 --- src/gallium/winsys/amdgpu/drm/amdgpu_winsys.h | 1 - 2 files changed, 6 insertions(+), 40 deletions(-) diff --git a/src/gallium/winsys/

[Mesa-dev] [PATCH v4 01/11] gallium: move pipe_screen destroy into pipe-loader

2016-07-22 Thread Rob Herring
In preparation to add reference counting of pipe_screen in the pipe-loader, pipe_loader_release needs to destroy the pipe_screen instead of state trackers. Signed-off-by: Rob Herring Cc: Emil Velikov --- src/gallium/auxiliary/pipe-loader/pipe_loader.h | 1 + src/gallium/auxiliary/pipe

[Mesa-dev] [PATCH v4 06/11] freedreno: use common screen ref counting

2016-07-22 Thread Rob Herring
Use the common pipe_screen ref counting and fd hashing functions. The mutex can be dropped as the pipe loader protects the create_screen() calls. Signed-off-by: Rob Herring Cc: Rob Clark --- src/gallium/drivers/freedreno/freedreno_screen.c | 1 - src/gallium/drivers/freedreno

[Mesa-dev] [PATCH v4 03/11] gallium: add common pipe_screen reference counting functions

2016-07-22 Thread Rob Herring
implementations. Signed-off-by: Rob Herring --- src/gallium/auxiliary/Makefile.sources | 2 + src/gallium/auxiliary/util/u_screen.c | 114 + src/gallium/auxiliary/util/u_screen.h | 32 + src/gallium/include/pipe/p_screen.h| 3 + 4 files changed, 151

[Mesa-dev] [PATCH v4 10/11] virgl: use common screen ref counting

2016-07-22 Thread Rob Herring
Use the common pipe_screen ref counting and fd hashing functions. The mutex can be dropped as the pipe loader protects the create_screen() calls. Signed-off-by: Rob Herring Cc: Dave Airlie --- src/gallium/winsys/virgl/drm/virgl_drm_winsys.c | 88 +++-- 1 file changed, 10

[Mesa-dev] [PATCH v4 04/11] pipe-loader-drm: use pipe_screen_unreference to destroy screen

2016-07-22 Thread Rob Herring
Use pipe_screen_unreference as it will call pipe_screen->destroy() when the pipe_screen is no longer referenced. The pipe_screen referencing is done within create_screen() functions as drivers (like amdgpu) may have special needs for ref counting. Signed-off-by: Rob Herring Cc: Emil Veli

[Mesa-dev] [PATCH v4 11/11] vc4: use common screen ref counting

2016-07-22 Thread Rob Herring
Use the common pipe_screen ref counting and fd hashing functions for vc4. This is necessary to only create a single pipe_screen for a process and avoid multiple imports of same prime fd among other things (probably). Cc: Eric Anholt Signed-off-by: Rob Herring --- src/gallium/winsys/vc4/drm

[Mesa-dev] [PATCH v4 08/11] radeon: use common screen ref counting

2016-07-22 Thread Rob Herring
Use the common pipe_screen ref counting and fd hashing functions. The mutex can be dropped as the pipe loader protects the create_screen() calls. Signed-off-by: Rob Herring Cc: "Marek Olšák" Cc: Ilia Mirkin --- src/gallium/drivers/r300/r300_screen.c| 3 - src/gallium/dr

[Mesa-dev] [PATCH v4 05/11] nouveau: use common screen ref counting

2016-07-22 Thread Rob Herring
Use the common pipe_screen ref counting and fd hashing functions. The mutex can be dropped as the pipe loader protects the create_screen() calls. Signed-off-by: Rob Herring Cc: Alexandre Courbot --- src/gallium/drivers/nouveau/nouveau_screen.c | 6 -- src/gallium/drivers/nouveau

Re: [Mesa-dev] [PATCH v4 03/11] gallium: add common pipe_screen reference counting functions

2016-07-22 Thread Rob Herring
On Fri, Jul 22, 2016 at 11:46 AM, Ilia Mirkin wrote: > On Fri, Jul 22, 2016 at 12:22 PM, Rob Herring wrote: >> In order to prevent multiple pipe_screens being created in the same >> process, lookup of the DRM FD and reference counting of the pipe_screen >> are needed. Sever

[Mesa-dev] [PATCH v2] vc4: add hash table look-up for exported dmabufs

2016-07-22 Thread Rob Herring
: Eric Anholt Signed-off-by: Rob Herring --- v2: - Avoid taking mutex on unreference if private - Fix use after free with util_hash_table_remove src/gallium/drivers/vc4/vc4_bufmgr.c | 20 +++- src/gallium/drivers/vc4/vc4_bufmgr.h | 19 ++- src/gallium/drivers/vc4

Re: [Mesa-dev] [PATCH v4 01/11] gallium: move pipe_screen destroy into pipe-loader

2016-07-26 Thread Rob Herring
On Tue, Jul 26, 2016 at 4:15 AM, Emil Velikov wrote: > On 22 July 2016 at 17:22, Rob Herring wrote: >> In preparation to add reference counting of pipe_screen in the pipe-loader, >> pipe_loader_release needs to destroy the pipe_screen instead of state >> trackers. >

Re: [Mesa-dev] [PATCH 1/3] freedreno/a2xx: Fix sign compare warnings

2016-07-28 Thread Rob Herring
On Thu, Jun 30, 2016 at 12:16 PM, Francesco Ansanelli wrote: > --- > src/gallium/drivers/freedreno/a2xx/fd2_screen.c |8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/src/gallium/drivers/freedreno/a2xx/fd2_screen.c > b/src/gallium/drivers/freedreno/a2xx/fd2_scre

Re: [Mesa-dev] [PATCH 3/4] freedreno/ir3: Add missing braces in initializer

2016-07-28 Thread Rob Herring
On Thu, Jul 28, 2016 at 1:07 PM, Rob Clark wrote: > tbh, I haven't used anything as ancient as 4.6 in a while.. these days > I'm using 6.1 and even with 5.x I don't remember seeing that warning. FWIW, clang 3.8 throws the warning too. Rob ___ mesa-dev

Re: [Mesa-dev] [PATCH 1/3] freedreno/a2xx: Fix sign compare warnings

2016-07-28 Thread Rob Herring
On Thu, Jul 28, 2016 at 6:55 PM, Rob Clark wrote: > On Thu, Jul 28, 2016 at 6:36 PM, Rob Herring wrote: >> On Thu, Jun 30, 2016 at 12:16 PM, Francesco Ansanelli >> wrote: >>> --- >>> src/gallium/drivers/freedreno/a2xx/fd2_screen.c |8 >&g

Re: [Mesa-dev] [PATCH v4 07/11] amdgpu: use common screen ref counting

2016-07-29 Thread Rob Herring
On Fri, Jul 29, 2016 at 12:51 PM, Marek Olšák wrote: > The fd table and reference counting in the winsys is required by the > GL-VDPAU interop. > > radeon_drm_winsys_create and amdgpu_winsys_create are publicly > exported by both *_dri.so and libvdpau_*.so, and whichever is loaded > first will eff

Re: [Mesa-dev] [PATCH v2 3/7] egl/android: Fix support for pbuffers (v2)

2016-08-02 Thread Rob Herring
On Tue, Aug 2, 2016 at 6:07 AM, Tomasz Figa wrote: > From: Nicolas Boichat > > Existing image loader code supports creating images only for window > surfaces. Moreover droid_create_surface() passes wrong surface type to > dri2_get_dri_config(), resulting in incorrect configs being returned for >

Re: [Mesa-dev] [PATCH v2 2/7] egl/android: Respect buffer mask in droid_image_get_buffers (v2)

2016-08-02 Thread Rob Herring
r condition and ignore requests > of unavailable buffers. > > Signed-off-by: Tomasz Figa Tested-by: Rob Herring ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2 1/7] egl/android: Remove unused variables in droid_get_buffers_with_format()

2016-08-02 Thread Rob Herring
On Tue, Aug 2, 2016 at 6:07 AM, Tomasz Figa wrote: > Fix compilation warnings due to unused variables left after some earlier > code changes. > > Signed-off-by: Tomasz Figa Tested-by: Rob Herring ___ mesa-dev mailing l

Re: [Mesa-dev] [PATCH v2 5/7] egl/android: Make get_fourcc() accept HAL formats

2016-08-02 Thread Rob Herring
all existing calls to this function, because they all called > get_format() first to convert from native to DRI_IMAGE_FORMAT. > > Signed-off-by: Tomasz Figa Tested-by: Rob Herring ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://

Re: [Mesa-dev] [PATCH v2 4/7] egl/android: Refactor image creation to separate flink and prime paths (v2)

2016-08-02 Thread Rob Herring
. This makes the code cleaner and also prepares for disabling flink > path more easily in the future. > > v2: Split into separate patch. > Add error messages. > > Signed-off-by: Tomasz Figa Tested-by: Rob Herring ___

Re: [Mesa-dev] [PATCH v2 6/7] egl/android: Add support for YV12 pixel format (v2)

2016-08-02 Thread Rob Herring
of trying to be overly > generic. > > Signed-off-by: Tomasz Figa > Signed-off-by: Kalyan Kondapally I didn't exercise this path, but it didn't break anything, so: Tested-by: Rob Herring ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH v2 7/7] egl/android: Make drm_gralloc headers optional (v2)

2016-08-02 Thread Rob Herring
On Tue, Aug 2, 2016 at 6:07 AM, Tomasz Figa wrote: > Make the code at least compile when being built without drm_gralloc > headers. > > v2: Replaced #ifdefs with stubs for gralloc_drm_get_gem_handle() > and GRALLOC_MODULE_PERFORM_GET_DRM_FD. > Removed explicit render node probing code. > >

Re: [Mesa-dev] [PATCH v2 3/7] egl/android: Fix support for pbuffers (v2)

2016-08-03 Thread Rob Herring
On Tue, Aug 2, 2016 at 9:27 PM, Tomasz Figa wrote: > Hi Rob, > > On Wed, Aug 3, 2016 at 2:32 AM, Rob Herring wrote: >> On Tue, Aug 2, 2016 at 6:07 AM, Tomasz Figa wrote: >>> From: Nicolas Boichat >>> >>> Existing image loader code supports creating ima

Re: [Mesa-dev] [PATCH 1/2] pl111: Rename the pl111 driver to "kmsro".

2019-01-23 Thread Rob Herring
On Thu, Oct 25, 2018 at 11:39 AM Eric Anholt wrote: > > The vc4 driver can do prime sharing to many different KMS-only devices, > such as the various tinydrm drivers for SPI-attached displays. Rename the > driver away from "pl111" to represent what it will actually support: > various sorts of KMS

Re: [Mesa-dev] [PATCH 1/2] pl111: Rename the pl111 driver to "kmsro".

2019-01-24 Thread Rob Herring
On Thu, Jan 24, 2019 at 9:14 AM Emil Velikov wrote: > > Hi all, > > Fwiw I'm ok with the idea, as pointed out in 2/2 as-is this is a > partial solution. > Never the less is some solution for the problem we have. > > With that said the series is: > Acked-by: Emil Velikov > > On Wed, 23 Jan 2019 at

[Mesa-dev] [PATCH 4/4] Switch imx to kmsro and remove the imx winsys

2019-01-24 Thread Rob Herring
The kmsro winsys is equivalent to the imx winsys, so we can switch to it and remove the imx one. Signed-off-by: Rob Herring --- Android.mk| 5 +- Makefile.am | 2 +- configure.ac | 14

[Mesa-dev] [PATCH 1/4] pl111: Rename the pl111 driver to "kmsro".

2019-01-24 Thread Rob Herring
layer used to attach a GPU. Acked-by: Emil Velikov Signed-off-by: Rob Herring --- .travis.yml | 2 +- Android.mk | 4 ++-- Makefile.am | 2 +- co

[Mesa-dev] [PATCH 0/4] Common KMS renderonly support

2019-01-24 Thread Rob Herring
ranch is here[1]. Rob [1] https://github.com/robherring/mesa winsys-renderonly Eric Anholt (1): pl111: Rename the pl111 driver to "kmsro". Rob Herring (3): pipe-loader: Fallback to kmsro driver when no matching driver name found kmsro: Add etnaviv renderonly support Switch im

[Mesa-dev] [PATCH 3/4] kmsro: Add etnaviv renderonly support

2019-01-24 Thread Rob Herring
Enable using etnaviv for KMS renderonly. This still needs KMS driver name mapping to kmsro to be used automatically. Signed-off-by: Rob Herring --- meson.build | 4 +-- src/gallium/meson.build | 12 +++ src/gallium/winsys/kmsro/drm

[Mesa-dev] [PATCH 2/4] pipe-loader: Fallback to kmsro driver when no matching driver name found

2019-01-24 Thread Rob Herring
If we can't find a driver matching by name, then use the kmsro driver. This removes the need for needing a driver descriptor for every possible KMS driver. Signed-off-by: Rob Herring --- src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c | 13 - 1 file changed, 8 insertions(

Re: [Mesa-dev] [PATCH 3/4] kmsro: Add etnaviv renderonly support

2019-01-25 Thread Rob Herring
On Thu, Jan 24, 2019 at 7:21 PM Eric Anholt wrote: > > Rob Herring writes: > > > Enable using etnaviv for KMS renderonly. This still needs KMS driver > > name mapping to kmsro to be used automatically. > > > > Signed-off-by: Rob Herring > > >

Re: [Mesa-dev] [PATCH 0/4] Common KMS renderonly support

2019-01-26 Thread Rob Herring
On Fri, Jan 25, 2019 at 9:00 PM Qiang Yu wrote: > > Thanks Rob, I'm OK with this kmsro approach. > > But I have to point out that this will break XServer AIGLX: > 1. modesetting DDX will report the display drm driver name like meson > as DRI2 driver name > 2. libglx.so used by xserver will look

Re: [Mesa-dev] [PATCH 1/2] panfrost: Initial stub for Panfrost driver

2019-02-04 Thread Rob Herring
On Sun, Feb 3, 2019 at 9:33 PM Alyssa Rosenzweig wrote: > > > You should just land it and start doing in-tree development! > > I don't have push access, you know :P I can push it if you don't want to go the MR route. That goes for subsequent changes too. Rob _

Re: [Mesa-dev] [PATCH 2/8] panfrost: Detect GPU version at runtime

2019-03-04 Thread Rob Herring
On Mon, Mar 4, 2019 at 1:35 PM Alyssa Rosenzweig wrote: > > > /* If set, we'll require the use of single render-target framebuffer > > * descriptors (SFBD), for older hardware -- specifically, > If > > This require_sfbd field should also be set at the same time. In > particular, we'll want a (

Re: [Mesa-dev] [PATCH 8/8] panfrost: Add backend targeting the DRM driver

2019-03-04 Thread Rob Herring
t a/include/drm-uapi/panfrost_drm.h b/include/drm-uapi/panfrost_drm.h > new file mode 100644 > index ..d4d271e37206 > --- /dev/null > +++ b/include/drm-uapi/panfrost_drm.h > @@ -0,0 +1,128 @@ > +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ >

Re: [Mesa-dev] [PATCH 6/8] panfrost: Free context BOs

2019-03-04 Thread Rob Herring
On Mon, Mar 4, 2019 at 1:38 PM Alyssa Rosenzweig wrote: > > > unsigned transient_count = > > ctx->transient_pools[ctx->cmdstream_i].entry_index*ctx->transient_pools[0].entry_size > > + ctx->transient_pools[ctx->cmdstream_i].entry_offset; > > - printf("Uploaded transient %d bytes\n",

Re: [Mesa-dev] [PATCH 8/8] panfrost: Add backend targeting the DRM driver

2019-03-05 Thread Rob Herring
On Mon, Mar 4, 2019 at 6:43 PM Alyssa Rosenzweig wrote: > > Wooo!!! > > Seeing this patch in my inbox has been some of the best news all day! > > Without further ado, my (solicited?) comments: > > > +/* Copyright 2018, Linaro, Ltd., Rob Herring */ > > Pleas

Re: [Mesa-dev] [PATCH v2 2/8] panfrost: Detect GPU version at runtime

2019-03-08 Thread Rob Herring
On Fri, Mar 8, 2019 at 3:27 AM Tomeu Vizoso wrote: > > Also use the raw GPU ID value to decide whether to use SFD or MFD. > > Signed-off-by: Tomeu Vizoso > --- > src/gallium/drivers/panfrost/pan_context.c | 66 ++ > src/gallium/drivers/panfrost/pan_context.h | 10 > src/

Re: [Mesa-dev] [PATCH v2 8/8] panfrost: Add backend targeting the DRM driver

2019-03-11 Thread Rob Herring
On Fri, Mar 8, 2019 at 3:59 PM Alyssa Rosenzweig wrote: > > > +/** > > + * struct drm_panfrost_wait_bo - ioctl argument for waiting for > > + * completion of the last DRM_PANFROST_SUBMIT_CL on a BO. > > Nit: Should be plain DRM_PANFROST_SUBMIT, there is no CL for us. > > > + __s64 timeout_ns;

[Mesa-dev] [PATCH] android: enable building static version of libdrm

2016-01-13 Thread Rob Herring
From: Sumit Semwal Android needs libdrm built statically for recovery; enable that as well. Signed-off-by: Sumit Semwal Signed-off-by: Rob Herring Cc: Chih-Wei Huang Cc: Emil Velikov --- Android.mk | 19 +++ 1 file changed, 19 insertions(+) diff --git a/Android.mk b

Re: [Mesa-dev] [android-x86-devel] Re: need-help: how to change to newest mesa in android-x86?

2016-01-15 Thread Rob Herring
On Wed, Jan 13, 2016 at 12:17 PM, Rob Clark wrote: > On Wed, Jan 13, 2016 at 12:54 PM, Rob Herring wrote: >> On Tue, Jan 12, 2016 at 8:06 PM, Chih-Wei Huang >> wrote: >>> 2016-01-13 6:29 GMT+08:00 Rob Herring : >>>> On Tue, Jan 12, 2016 at 7:05 AM, Chih-Wei

Re: [Mesa-dev] [android-x86-devel] Re: need-help: how to change to newest mesa in android-x86?

2016-01-15 Thread Rob Herring
On Fri, Jan 15, 2016 at 3:10 PM, Dave Airlie wrote: >> >> well, nothing specific, but for example early on we had some confusion >> in drm_gralloc (when adding dmabuf fd support) about who close()d the >> fd's. Resulting in same fd getting closed twice (although some >> completely unrelated file

Re: [Mesa-dev] [android-x86-devel] Re: need-help: how to change to newest mesa in android-x86?

2016-01-16 Thread Rob Herring
On Fri, Jan 15, 2016 at 11:45 PM, 陈渝 wrote: > hi, Rob Herring: > I have downloaded the AOSP repos finally(spend 36+ hours). and followed your > Instructions try to know your current progress on x86_64. > > I finished virglrenderer, qemu, kernel, BUT... (BTW, I have tried AOSP-6,

Re: [Mesa-dev] [android-x86-devel] Re: need-help: how to change to newest mesa in android-x86?

2016-01-18 Thread Rob Herring
On Fri, Jan 15, 2016 at 3:10 PM, Dave Airlie wrote: >> >> well, nothing specific, but for example early on we had some confusion >> in drm_gralloc (when adding dmabuf fd support) about who close()d the >> fd's. Resulting in same fd getting closed twice (although some >> completely unrelated file

Re: [Mesa-dev] [android-x86-devel] Re: need-help: how to change to newest mesa in android-x86?

2016-01-22 Thread Rob Herring
On Mon, Jan 18, 2016 at 4:46 PM, Rob Clark wrote: > On Mon, Jan 18, 2016 at 5:18 PM, Rob Herring wrote: >> On Fri, Jan 15, 2016 at 3:10 PM, Dave Airlie wrote: >>>> >>>> well, nothing specific, but for example early on we had some confusion >>>>

Re: [Mesa-dev] [PATCH 2/2] virgl: enable building on Android

2016-01-22 Thread Rob Herring
On Fri, Dec 18, 2015 at 11:01 AM, Emil Velikov wrote: > Thank you Rob ! > > On 17 December 2015 at 15:45, Rob Herring wrote: >> This is just a copy-n-paste and rename of vc4 Android makefiles. >> > Looks great. > > Rob, I take it that you've at least compil

[Mesa-dev] [PATCH 6/6] virgl: also build vtest for Android

2016-01-29 Thread Rob Herring
Enabling swrast on Android causes a link error because vtest is missing. Signed-off-by: Rob Herring --- src/gallium/Android.mk| 2 +- src/gallium/targets/dri/Android.mk| 2 +- src/gallium/winsys/virgl/vtest/Android.mk | 33 +++ 3 files

[Mesa-dev] [PATCH 3/6] Android: Fix building secondary arch in mixed 32/64-bit builds

2016-01-29 Thread Rob Herring
At least in Android M, using LOCAL_CC does not work for secondary arch when doing dual arch builds. Use LOCAL_CLFAGS and LOCAL_CONLYFLAGS instead. Cc: Emil Velikov Cc: Chih-Wei Huang Signed-off-by: Rob Herring --- Android.common.mk | 9 - 1 file changed, 4 insertions(+), 5 deletions

[Mesa-dev] [PATCH 4/6] Android: enable building on arm64

2016-01-29 Thread Rob Herring
Define the DEFAULT_DRIVER_DIR for arm64 builds. Cc: Emil Velikov Cc: Chih-Wei Huang Signed-off-by: Rob Herring --- src/egl/Android.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/src/egl/Android.mk b/src/egl/Android.mk index ebd67af..ad902a0 100644 --- a/src/egl/Android.mk +++ b/src

[Mesa-dev] [PATCH 1/6] Android: fix build break from nir/glsl move to compiler/

2016-01-29 Thread Rob Herring
Commits a39a8fbbaa12 ("nir: move to compiler/") and eb63640c1d38 ("glsl: move to compiler/") broke Android builds. Fix them. Built with i915, i965, freedreno, r300g, r600g, and virgl enabled. Cc: Emil Velikov Signed-off-by: Rob Herring --- Android.mk

  1   2   3   4   5   6   7   >