[Mesa-dev] [PATCH v2 1/3] aubinator: Simplify print_dword_val() method

2016-09-13 Thread Sirisha Gandikota
From: Sirisha Gandikota Remove the float/dword union and use the iter->p[f->start / 32] directly as printf formatter %08x expects uint32_t (Ken) v2: Make the cleanup much more crispier (Ken) Signed-off-by: Sirisha Gandikota --- src/intel/tools/aubinator.c | 12 1 file chan

[Mesa-dev] [PATCH v2 2/3] aubinator: Make gen_disasm_disassemble handle split sends

2016-09-13 Thread Sirisha Gandikota
From: Sirisha Gandikota Skylake adds new SENDS and SENDSC opcodes, which should be handled in the send-with-EOT check. Make an is_send() helper that checks if the opcode is SEND/SENDC/SENDS/SENDSC (Ken) v2: Make is_send() much more crispier, Mix declaration and code to make the code compact

[Mesa-dev] [PATCH v2 3/3] aubinator: Remove bogus "end" parameter in gen_disasm_disassemble()

2016-09-13 Thread Sirisha Gandikota
From: Sirisha Gandikota Earlier, the loop pretends to loop over instructions from "start" to "end", but the callers always pass 8192 for end, which is some huge bogus value. The real loop termination condition is send-with-EOT or 0. (Ken) v2: no change Signed-off-b

[Mesa-dev] [PATCH v2 0/3] *** Aubinator code simplification ***

2016-09-13 Thread Sirisha Gandikota
From: Sirisha Gandikota This patch set simplifies parts of code in the aubinator tool as per review comments from Ken (Wed Aug 24 04:51:47 UTC 2016) v2 of the earlier patches simplifying code further as per Ken's comments Sirisha Gandikota (3): aubinator: Simplify print_dword_val() m

[Mesa-dev] [PATCH] aubinator: Fix the decoding of values that span two Dwords

2016-09-20 Thread Sirisha Gandikota
From: Sirisha Gandikota Fixed the way the values that span two Dwords are decoded. Based on the start and end indices of the field, the Dwords are fetched and decoded accordingly. Earlier, 64-bit fields (such as most pointers on Gen8+) weren't decoded correctly. gen_field_iterator_next s

[Mesa-dev] [PATCH] *** Decode fields spanning to two DWords correctly ***

2016-09-20 Thread Sirisha Gandikota
From: Sirisha Gandikota The first version of aubinator did not take into account the fields spanning to 2 DWords. Hence fields like 64bit address/offset and int were not decoded correctly. This patch should fix that issue. Sirisha Gandikota (1): aubinator: Fix the decoding of values that span

[Mesa-dev] [PATCH v2] aubinator: Fix the decoding of values that span two Dwords

2016-09-20 Thread Sirisha Gandikota
From: Sirisha Gandikota Fixed the way the values that span two Dwords are decoded. Based on the start and end indices of the field, the Dwords are fetched and decoded accordingly. v2: rename dw to qw in gen_field_iterator_next() and remove extra white space in the same method (Anuj) Earlier

[Mesa-dev] [PATCH v2] *** Decode fields spanning to two DWords correctly ***

2016-09-20 Thread Sirisha Gandikota
From: Sirisha Gandikota The first version of aubinator did not take into account the fields spanning to 2 DWords. Hence fields like 64bit address/offset and int were not decoded correctly. This patch should fix that issue. v2: Aptly renamed dw to qw in the method gen_field_iterator_next() and

[Mesa-dev] [PATCH v3] *** Decode fields spanning across two DWords correctly ***

2016-09-20 Thread Sirisha Gandikota
From: Sirisha Gandikota The first version of aubinator did not take into account the fields spanning across 2 DWords. Hence fields like 64bit address/offset and int were not decoded correctly. This patch should fix that issue. v2: Aptly renamed dw to qw in the method gen_field_iterator_next

[Mesa-dev] [PATCH v3] aubinator: Fix the decoding of values that span two Dwords

2016-09-20 Thread Sirisha Gandikota
From: Sirisha Gandikota Fixed the way the values that span two Dwords are decoded. Based on the start and end indices of the field, the Dwords are fetched and decoded accordingly. v2: rename dw to qw in gen_field_iterator_next and remove extra white space (Anuj) v3: change all instances of dw

[Mesa-dev] [PATCH 1/2] aubinator: Add a new tool called Aubinator to the src/intel/tools folder.

2016-08-09 Thread Sirisha Gandikota
From: Kristian Høgsberg Kristensen The Aubinator tool is designed to help the driver developers in debugging the driver functionality by decoding the data in the .aub files. Primary Authors of this tool are Damien Lespiau and Kristian Høgsberg Kristensen . Signed-off-by: Sirisha Gandikota

[Mesa-dev] [PATCH 2/2] aubinator: Fix the tool to correctly decode the DWords

2016-08-09 Thread Sirisha Gandikota
From: Sirisha Gandikota Several fixes have been added as part of this as listed below: 1) Fix the mask and add disassembler handling for STATE_DS, STATE_HS as the mask returned wrong values of the fields. 2) Fix the GEN_TYPE_ADDRESS/GEN_TYPE_OFFSET decoding - the address/ offset were handled

[Mesa-dev] [PATCH 0/2] *** Aubinator tool for Intel Gen platforms ***

2016-08-09 Thread Sirisha Gandikota
From: Sirisha Gandikota This is a patch series for adding the aubinator tool to the codebase. The aubinator tool is designed to help the driver developers to debug the driver functionality by decoding the data in the .aub files. This tool is for Intel Gen platforms and has been tested for

[Mesa-dev] [PATCH v2 1/2] aubinator: Add a new tool called Aubinator to the src/intel/tools folder.

2016-08-19 Thread Sirisha Gandikota
by Sirisha Gandikota as below: 1) Make Makefile.am more crisp, reuse intel_aub.h from libdrm (per Emil) 2) Aubinator will use platform name instead of GEN number (per Matt) 3) Disassmebler gets created based on pciid rather then GEN number (per Matt) 4) Other formatting comments (per Ken, Matt and

[Mesa-dev] [PATCH v2 0/2] *** Aubinator tool for Intel Gen platforms ***

2016-08-19 Thread Sirisha Gandikota
From: Sirisha Gandikota This is a patch series for adding the aubinator tool to the codebase. The aubinator tool is designed to help the driver developers to debug the driver functionality by decoding the data in the .aub files. This tool is for Intel Gen platforms and has been tested for

[Mesa-dev] [PATCH v2 2/2] aubinator: Fix the tool to correctly decode the DWords

2016-08-19 Thread Sirisha Gandikota
From: Sirisha Gandikota Several fixes have been added as part of this as listed below: 1) Fix the mask and add disassembler handling for STATE_DS, STATE_HS as the mask returned wrong values of the fields. 2) Fix the GEN_TYPE_ADDRESS/GEN_TYPE_OFFSET decoding - the address/ offset were handled

[Mesa-dev] [PATCH 5/5] aubinator: Remove bogus "end" parameter in gen_disasm_disassemble()

2016-09-08 Thread Sirisha Gandikota
From: Sirisha Gandikota Earlier, the loop pretends to loop over instructions from "start" to "end", but the callers always pass 8192 for end, which is some huge bogus value. The real loop termination condition is send-with-EOT or 0. (Ken) Signed-off-by: Sirisha Gandikota

[Mesa-dev] [PATCH 1/5] aubinator: Fix compiler warning

2016-09-08 Thread Sirisha Gandikota
From: Sirisha Gandikota Add 'const' qualifier to gen_field_iterator::p pointer (Ken) Signed-off-by: Sirisha Gandikota --- src/intel/tools/decoder.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/tools/decoder.h b/src/intel/tools/decoder.h index b46e45

[Mesa-dev] [PATCH 3/5] aubinator: Simplify print_dword_val() method

2016-09-08 Thread Sirisha Gandikota
From: Sirisha Gandikota Remove the float/dword union and use the iter->p[f->start / 32] directly as printf formatter %08x expects uint32_t (Ken) Signed-off-by: Sirisha Gandikota --- src/intel/tools/aubinator.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git

[Mesa-dev] [PATCH 2/5] aubinator: Simplify gen_disasm_create()'s devinfo handling

2016-09-08 Thread Sirisha Gandikota
From: Sirisha Gandikota Copy the whole devinfo structure instead of just few fields (Ken) Earlier, copied only couple of fields which added more code. So, simplify code by copying the whole structure. Signed-off-by: Sirisha Gandikota --- src/intel/tools/disasm.c | 8 +--- 1 file changed

[Mesa-dev] [PATCH 4/5] aubinator: Make gen_disasm_disassemble handle split sends

2016-09-08 Thread Sirisha Gandikota
From: Sirisha Gandikota Skylake adds new SENDS and SENDSC opcodes, which should be handled in the send-with-EOT check. Make an is_send() helper that checks if the opcode is SEND/SENDC/SENDS/SENDSC (Ken) Signed-off-by: Sirisha Gandikota --- src/intel/tools/disasm.c | 22

[Mesa-dev] [PATCH 0/5] *** Aubinator code simplification ***

2016-09-08 Thread Sirisha Gandikota
From: Sirisha Gandikota This patch set simplifies parts of code in the aubinator tool as per review comments from Ken (Wed Aug 24 04:51:47 UTC 2016) Sirisha Gandikota (5): aubinator: Fix compiler warning aubinator: Simplify gen_disasm_create()'s devinfo handling aubinator: Sim