[Mesa-dev] [Bug 106058] Fix version requirements for GL_ARB_gpu_shader5
https://bugs.freedesktop.org/show_bug.cgi?id=106058 --- Comment #6 from Timothy Arceri --- (In reply to Timothy Arceri from comment #5) > (In reply to b...@besd.de from comment #4) > > Timothy, > > do you want to push the corresponding mesa patch as well? I might not get to > > it until the weekend. > > hmmm, I though you were fixing the piglit tests to match mesa. I that cause > I'm not sure this was right. > > I believe we don't always follow these version requirements and treat them > more as a guideline. You should start sending your patches to the list > rather than attaching them to bugs so that other developers can > discuss/comment. I guess it's ok, to have piglit follow the version requirements so that the test are guaranteed to work on other implementations, but I'm not sure we need to change Mesa. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 106058] Fix version requirements for GL_ARB_gpu_shader5
https://bugs.freedesktop.org/show_bug.cgi?id=106058 --- Comment #5 from Timothy Arceri --- (In reply to b...@besd.de from comment #4) > Timothy, > do you want to push the corresponding mesa patch as well? I might not get to > it until the weekend. hmmm, I though you were fixing the piglit tests to match mesa. I that cause I'm not sure this was right. I believe we don't always follow these version requirements and treat them more as a guideline. You should start sending your patches to the list rather than attaching them to bugs so that other developers can discuss/comment. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 106058] Fix version requirements for GL_ARB_gpu_shader5
https://bugs.freedesktop.org/show_bug.cgi?id=106058 --- Comment #4 from b...@besd.de --- Timothy, do you want to push the corresponding mesa patch as well? I might not get to it until the weekend. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 106058] Fix version requirements for GL_ARB_gpu_shader5
https://bugs.freedesktop.org/show_bug.cgi?id=106058 Timothy Arceri changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Timothy Arceri --- I'm not sure how you created the patch but please setup your name and email in git and use 'git format-patch'. Or even better use 'git send-email' and send the patch directly to the piglit mailing list. Anyway I've fixed things up and pushed the patch. Thanks! -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 106058] Fix version requirements for GL_ARB_gpu_shader5
https://bugs.freedesktop.org/show_bug.cgi?id=106058 --- Comment #2 from b...@besd.de --- Just to be clear: this doesnt fix a failing test in piglit. shader-db shows an error when the affected piglit shaders are run. and the version requirements are really wrong ;) -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 106058] Fix version requirements for GL_ARB_gpu_shader5
https://bugs.freedesktop.org/show_bug.cgi?id=106058 --- Comment #1 from b...@besd.de --- Created attachment 138853 --> https://bugs.freedesktop.org/attachment.cgi?id=138853&action=edit patch for Mesa -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 106058] Fix version requirements for GL_ARB_gpu_shader5
https://bugs.freedesktop.org/show_bug.cgi?id=106058 Bug ID: 106058 Summary: Fix version requirements for GL_ARB_gpu_shader5 Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: Mesa core Assignee: mesa-dev@lists.freedesktop.org Reporter: b...@besd.de QA Contact: mesa-dev@lists.freedesktop.org Created attachment 138852 --> https://bugs.freedesktop.org/attachment.cgi?id=138852&action=edit Fix for piglit The version requirements for GL_ARB_gpu_shader5 are incorrect. I have already fixed this locally, just dont have time for a proper patch right now. Affects two piglit tests, for one I already have a patch the other one seems trickier. Requirements for GL_ARB_gpu_shader5 >From https://www.khronos.org/registry/OpenGL/extensions/ARB/ARB_gpu_shader5.txt This extension interacts with ARB_gpu_shader_fp64. This extension interacts with NV_gpu_shader5. This extension interacts with ARB_sample_shading. This extension interacts with ARB_texture_gather. OpenGL 3.2 and GLSL 1.50 are required. >From https://www.khronos.org/registry/OpenGL/extensions/NV/NV_gpu_shader5.txt If implemented in OpenGL ES, OpenGL ES 3.1 and GLSL ES 3.10 are required. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
