[Mesa-dev] [Bug 44928] i965 build error on recent git

2012-01-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=44928

Eric Anholt e...@anholt.net changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #11 from Caleb Callaway enlightened.des...@gmail.com 2012-01-24 
22:39:26 PST ---
First patch works for me...the second patch doesn't :/

--- Comment #12 from Eric Anholt e...@anholt.net 2012-01-26 16:18:29 PST ---
commit c88503944234421ecb617001aad305ff3b1b83d2
Author: Eric Anholt e...@anholt.net
Date:   Thu Jan 26 16:11:12 2012 -0800

i965: Drop the missing symbols link test.

This was horribly broken and has cost everyone more time than we were
ever going to save using it.  It might have been fixable, but the
problem it was originally trying to solve can be better solved with
-Werror=missing-prototypes and -Werror=implicit-function-declaration.

Also, it was always producing a big scary warning about how the link
test was non-portable.

Reviewed-by: Matt Turner matts...@gmail.com
Reviewed-by: Kenneth Graunke kenn...@whitecape.org
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=44928

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [Bug 44928] i965 build error on recent git

2012-01-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=44928

--- Comment #9 from Matt Turner matts...@gmail.com 2012-01-24 12:48:04 PST ---
Created attachment 56111
  -- https://bugs.freedesktop.org/attachment.cgi?id=56111
patch

The attached patch fixes the problem (I've gotten confirmation from 2 people)
but I didn't really understand why. In writing this, I think I see why now --

Linking with i965_dri.la (which contains a list of libraries i965_dri.so is
linked against) should have i965_symbols_test linked with those libraries too.
In i965_dri.la we have

# Linker flags that can not go in dependency_libs.
inherited_linker_flags=''

# Libraries that this one depends upon.
dependency_libs=' -L../../../../../lib -ldricore -lexpat -lpthread -ldl -lglsl
-ldrm_intel -ldrm -lxcb-dri2'

Since it's trying to link with -ldricore -lglsl but not being able to find
them, I have to think that -L../../../../../lib shouldn't be in dependency_libs
but rather in inherited_linker_flags.

If someone wants to `make i965_dri.la`, move the -L flag to
inherited_linker_flags and then run `make i965_symbols_test` to confirm my
theory, I'd appreciate it.

All this is probably moot thought. Eric suggested killing the symbols test.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [Bug 44928] i965 build error on recent git

2012-01-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=44928

--- Comment #10 from Matt Turner matts...@gmail.com 2012-01-24 14:01:46 UTC 
---
Created attachment 56112
  -- https://bugs.freedesktop.org/attachment.cgi?id=56112
patch2

maybe a better fix... if it works.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [Bug 44928] i965 build error on recent git

2012-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=44928

Fabio Pedretti fabio@libero.it changed:

   What|Removed |Added

 CC||mesa-dev@lists.freedesktop.
   ||org

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [Bug 44928] i965 build error on recent git

2012-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=44928

--- Comment #1 from José Fonseca jfons...@vmware.com 2012-01-23 03:59:10 PST 
---
FWIW, our build bots are failing to build i965:

$ ./autogen.sh --prefix=/usr --enable-gles1 --enable-gles2 --enable-openvg
--enable-xorg --enable-xa --disable-glut --enable-gallium-egl
--enable-gallium-llvm --with-gallium-drivers=i915,nouveau,r300,r600,svga,swrast
$ make -j2
[...]
  CCLD   i965_symbols_test

*** Warning: Linking the executable i965_symbols_test against the loadable
module
*** i965_dri.so is not portable!
./.libs/i965_dri.so: undefined reference to
`ir_print_visitor::ir_print_visitor()'
./.libs/i965_dri.so: undefined reference to
`ir_variable::determine_interpolation_mode(bool)'
./.libs/i965_dri.so: undefined reference to `_mesa_meta_glsl_Clear'
./.libs/i965_dri.so: undefined reference to `_mesa_get_srgb_format_linear'
./.libs/i965_dri.so: undefined reference to `count_tessellated_primitives'
./.libs/i965_dri.so: undefined reference to `_mesa_reference_renderbuffer_'
./.libs/i965_dri.so: undefined reference to `_mesa_accum'
./.libs/i965_dri.so: undefined reference to `_mesa_override_glsl_version'
./.libs/i965_dri.so: undefined reference to `_mesa_associate_uniform_storage'
./.libs/i965_dri.so: undefined reference to `_swrast_add_soft_renderbuffers'
./.libs/i965_dri.so: undefined reference to
`_mesa_generate_parameters_list_for_uniforms'
./.libs/i965_dri.so: undefined reference to `hash_table_call_foreach'
./.libs/i965_dri.so: undefined reference to `do_set_program_inouts(exec_list*,
gl_program*, bool)'
./.libs/i965_dri.so: undefined reference to `ra_add_transitive_reg_conflict'
./.libs/i965_dri.so: undefined reference to `_mesa_meta_begin'
./.libs/i965_dri.so: undefined reference to `do_common_optimization(exec_list*,
bool, bool, unsigned int)'
./.libs/i965_dri.so: undefined reference to `glsl_type::get_scalar_type()
const'
./.libs/i965_dri.so: undefined reference to `vbo_get_minmax_indices'
./.libs/i965_dri.so: undefined reference to
`_swrast_set_renderbuffer_accessors'
/usr/lib/dri/libdricore.so: undefined reference to `_glapi_tls_Context'
./.libs/i965_dri.so: undefined reference to `_swrast_render_texture'
./.libs/i965_dri.so: undefined reference to `vbo_bind_arrays'
./.libs/i965_dri.so: undefined reference to `_mesa_meta_in_progress'
./.libs/i965_dri.so: undefined reference to `_mesa_image_offset'
./.libs/i965_dri.so: undefined reference to `_mesa_reference_framebuffer_'
./.libs/i965_dri.so: undefined reference to `_mesa_readpixels'
./.libs/i965_dri.so: undefined reference to `_mesa_reference_program_'
./.libs/i965_dri.so: undefined reference to `_mesa_meta_end'
./.libs/i965_dri.so: undefined reference to
`visit_list_elements(ir_hierarchical_visitor*, exec_list*, bool)'
/usr/lib/dri/libdricore.so: undefined reference to `_glapi_tls_Dispatch'
collect2: ld returned 1 exit status
make[5]: *** [i965_symbols_test] Error 1
make[5]: Leaving directory
`/var/lib/hudson/jobs/mesa-ubuntu64-make/workspace/src/mesa/drivers/dri/i965'
make[4]: *** [all-recursive] Error 1
make[4]: Leaving directory
`/var/lib/hudson/jobs/mesa-ubuntu64-make/workspace/src/mesa/drivers/dri'
make[3]: *** [default] Error 1
make[3]: Leaving directory
`/var/lib/hudson/jobs/mesa-ubuntu64-make/workspace/src/mesa/drivers'
make[2]: *** [driver_subdirs] Error 2
make[2]: Leaving directory
`/var/lib/hudson/jobs/mesa-ubuntu64-make/workspace/src/mesa'
make[1]: *** [subdirs] Error 1
make[1]: Leaving directory
`/var/lib/hudson/jobs/mesa-ubuntu64-make/workspace/src'
make: *** [default] Error 1

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [Bug 44928] i965 build error on recent git

2012-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=44928

Matt Turner matts...@gmail.com changed:

   What|Removed |Added

 CC||dan...@ffwll.ch,
   ||k...@debian.org

--- Comment #2 from Matt Turner matts...@gmail.com 2012-01-23 09:54:52 UTC ---
A couple of people on IRC mentioned this problem, and Cyril Brulebois and I
tried to get to the bottom of it with Daniel Vetter (who has the problem).

It looked to me like DRICORE_LIB_DEPS and DRI_LIB_DEPS weren't being set
properly, since danvet's log was missing -L../../../../../../ (or whatever)
before -ldricore.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [Bug 44928] i965 build error on recent git

2012-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=44928

--- Comment #5 from Matt Turner matts...@gmail.com 2012-01-23 19:25:22 UTC ---
I'm curious, do you get this build failure after
e326480e4ebe8687948041c2dc5f5b7595559a2e (the i965/automake patch) or after one
of the later patches which cause dricore and glapi to always be shared, ie
adefee50d or 2b3a8cbc?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [Bug 44928] i965 build error on recent git

2012-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=44928

--- Comment #6 from Caleb Callaway enlightened.des...@gmail.com 2012-01-23 
22:11:08 PST ---
On my development system (Ubuntu 11.10 64-bit), this issue appears in commit
2b3a8cbc

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [Bug 44928] i965 build error on recent git

2012-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=44928

--- Comment #7 from Matt Turner matts...@gmail.com 2012-01-23 22:21:38 PST ---
(In reply to comment #6)
 On my development system (Ubuntu 11.10 64-bit), this issue appears in commit
 2b3a8cbc

Thanks. Does building commit e326480e with --enable-shared-dricore result in
the same failure?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [Bug 44928] i965 build error on recent git

2012-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=44928

--- Comment #8 from Caleb Callaway enlightened.des...@gmail.com 2012-01-23 
23:03:26 UTC ---
(In reply to comment #7)
 (In reply to comment #6)
  On my development system (Ubuntu 11.10 64-bit), this issue appears in commit
  2b3a8cbc
 
 Thanks. Does building commit e326480e with --enable-shared-dricore result in
 the same failure?

Yes, same failure commit e326480e with --enable-shared-dricore. In case it
helps, here's how I'm calling autogen.sh:

./autogen.sh --prefix=$WLD --enable-gles2 --disable-gallium-egl
--with-egl-platforms=x11,wayland,drm --enable-gbm --enable-64-bit
--enable-shared-glapi --enable-shared-dricore

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev