[Mesa-dev] [Bug 92183] linker.cpp:3187:46: error: ‘strtok_r’ was not declared in this scope
https://bugs.freedesktop.org/show_bug.cgi?id=92183 Timothy Arceri changed: What|Removed |Added Resolution|--- |WONTFIX Status|REOPENED|RESOLVED --- Comment #12 from Timothy Arceri --- It's be 3 years I think its safe to say the solution is: Use a newer version of MinGW :) -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 92183] linker.cpp:3187:46: error: ‘strtok_r’ was not declared in this scope
https://bugs.freedesktop.org/show_bug.cgi?id=92183 Tapani Pälli changed: What|Removed |Added Assignee|lem...@gmail.com|mesa-dev@lists.freedesktop. ||org -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 92183] linker.cpp:3187:46: error: ‘strtok_r’ was not declared in this scope
https://bugs.freedesktop.org/show_bug.cgi?id=92183 --- Comment #11 from Brian Paul --- (In reply to Jose Fonseca from comment #10) > (In reply to Brian Paul from comment #7) > > I routinely use MinGW 4.6.3: > > > > $ i686-w64-mingw32-g++ --version > > i686-w64-mingw32-g++ (GCC) 4.6.3 > > If this version is still widely used, then it would be nice to keep it > building. Yeah, I'd rather not have to update my MinGW tool chain right now. > That said, I'm afraid I can't help. > > I used 4.6 for a long time (as for a period of time, certain mingw versions > introduced a dependency of winpthreads-1.dll) but newer versions (e.g., > Ubtuntu 15.04's) no longer depend on it, so I stopped using it. That's certainly good news. The winpthreads-1.dll dependency was a huge PITA. -- You are receiving this mail because: You are the QA Contact for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 92183] linker.cpp:3187:46: error: ‘strtok_r’ was not declared in this scope
https://bugs.freedesktop.org/show_bug.cgi?id=92183 --- Comment #10 from Jose Fonseca --- (In reply to Brian Paul from comment #7) > I routinely use MinGW 4.6.3: > > $ i686-w64-mingw32-g++ --version > i686-w64-mingw32-g++ (GCC) 4.6.3 If this version is still widely used, then it would be nice to keep it building. That said, I'm afraid I can't help. I used 4.6 for a long time (as for a period of time, certain mingw versions introduced a dependency of winpthreads-1.dll) but newer versions (e.g., Ubtuntu 15.04's) no longer depend on it, so I stopped using it. (In reply to Emil Velikov from comment #8) > Iirc the mingw + autoconf build was dropped. So we might want to 'sync' with > the autoconf build. The latter currently requires gcc 4.2, whist 4.6 is > recommended. > > Although as Brian said, I'm not sure if we have that explicitly documented. It's not just the GCC version that matter for mingw. More than that, it's the MinGW runtime headers themselves. -- You are receiving this mail because: You are the QA Contact for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 92183] linker.cpp:3187:46: error: ‘strtok_r’ was not declared in this scope
https://bugs.freedesktop.org/show_bug.cgi?id=92183 --- Comment #9 from Tapani Pälli --- (In reply to Emil Velikov from comment #8) > Iirc the mingw + autoconf build was dropped. So we might want to 'sync' with > the autoconf build. The latter currently requires gcc 4.2, whist 4.6 is > recommended. > > Although as Brian said, I'm not sure if we have that explicitly documented. So do I understand correctly that adding such a requirement to documentation would fix this bug? I would prefer some mingw user to do this so that I won't mess this up. -- You are receiving this mail because: You are the QA Contact for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 92183] linker.cpp:3187:46: error: ‘strtok_r’ was not declared in this scope
https://bugs.freedesktop.org/show_bug.cgi?id=92183 --- Comment #8 from Emil Velikov --- Iirc the mingw + autoconf build was dropped. So we might want to 'sync' with the autoconf build. The latter currently requires gcc 4.2, whist 4.6 is recommended. Although as Brian said, I'm not sure if we have that explicitly documented. -- You are receiving this mail because: You are the QA Contact for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 92183] linker.cpp:3187:46: error: ‘strtok_r’ was not declared in this scope
https://bugs.freedesktop.org/show_bug.cgi?id=92183 --- Comment #7 from Brian Paul --- (In reply to Tapani Pälli from comment #6) > (In reply to Vinson Lee from comment #5) > > mesa: ca2e16d26ec46e604c76ab72d3ec14a7a8643cc8 (master 11.1.0-devel) > > > > Build is still failing on older versions on MinGW. This error occurs with > > mingw-w64 2.0.1-1 on Ubuntu 12.04. > > > > Compiling src/glsl/linker.cpp ... > > src/glsl/linker.cpp: In function ‘bool > > included_in_packed_varying(ir_variable*, const char*)’: > > src/glsl/linker.cpp:3241:46: error: ‘strtok_s’ was not declared in this > > scope > > > > > > Mesa might decide instead to raise the minimum required version of > > mingw-w64. > > Where is the minimum required version documented? Off-hand I don't think the min version is documented. I routinely use MinGW 4.6.3: $ i686-w64-mingw32-g++ --version i686-w64-mingw32-g++ (GCC) 4.6.3 -- You are receiving this mail because: You are the QA Contact for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 92183] linker.cpp:3187:46: error: ‘strtok_r’ was not declared in this scope
https://bugs.freedesktop.org/show_bug.cgi?id=92183 --- Comment #6 from Tapani Pälli --- (In reply to Vinson Lee from comment #5) > mesa: ca2e16d26ec46e604c76ab72d3ec14a7a8643cc8 (master 11.1.0-devel) > > Build is still failing on older versions on MinGW. This error occurs with > mingw-w64 2.0.1-1 on Ubuntu 12.04. > > Compiling src/glsl/linker.cpp ... > src/glsl/linker.cpp: In function ‘bool > included_in_packed_varying(ir_variable*, const char*)’: > src/glsl/linker.cpp:3241:46: error: ‘strtok_s’ was not declared in this scope > > > Mesa might decide instead to raise the minimum required version of mingw-w64. Where is the minimum required version documented? -- You are receiving this mail because: You are the QA Contact for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 92183] linker.cpp:3187:46: error: ‘strtok_r’ was not declared in this scope
https://bugs.freedesktop.org/show_bug.cgi?id=92183 Vinson Lee changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #5 from Vinson Lee --- mesa: ca2e16d26ec46e604c76ab72d3ec14a7a8643cc8 (master 11.1.0-devel) Build is still failing on older versions on MinGW. This error occurs with mingw-w64 2.0.1-1 on Ubuntu 12.04. Compiling src/glsl/linker.cpp ... src/glsl/linker.cpp: In function ‘bool included_in_packed_varying(ir_variable*, const char*)’: src/glsl/linker.cpp:3241:46: error: ‘strtok_s’ was not declared in this scope Mesa might decide instead to raise the minimum required version of mingw-w64. -- You are receiving this mail because: You are the QA Contact for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 92183] linker.cpp:3187:46: error: ‘strtok_r’ was not declared in this scope
https://bugs.freedesktop.org/show_bug.cgi?id=92183 Tapani Pälli changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED Assignee|mesa-dev@lists.freedesktop. |lem...@gmail.com |org | --- Comment #4 from Tapani Pälli --- fix pushed to master -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 92183] linker.cpp:3187:46: error: ‘strtok_r’ was not declared in this scope
https://bugs.freedesktop.org/show_bug.cgi?id=92183 --- Comment #3 from Tapani Pälli --- (In reply to Ilia Mirkin from comment #2) > strtok isn't threadsafe right I'll go for strtok_s, I was just wondering if the occurences of strtok should be converted to mesa_strtok which would then be strtok_r/s or is it worth the trouble? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 92183] linker.cpp:3187:46: error: ‘strtok_r’ was not declared in this scope
https://bugs.freedesktop.org/show_bug.cgi?id=92183 --- Comment #2 from Ilia Mirkin --- strtok isn't threadsafe -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 92183] linker.cpp:3187:46: error: ‘strtok_r’ was not declared in this scope
https://bugs.freedesktop.org/show_bug.cgi?id=92183 --- Comment #1 from Tapani Pälli --- it seems strtok_s would be the windows equivalent: https://msdn.microsoft.com/en-us/library/ftsafwz3.aspx I can make a patch that uses strtok_s when on windows or maybe just go for regular strtok() ? I can see there's some usage of regular strtok() in Mesa. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 92183] linker.cpp:3187:46: error: ‘strtok_r’ was not declared in this scope
https://bugs.freedesktop.org/show_bug.cgi?id=92183 Bug ID: 92183 Summary: linker.cpp:3187:46: error: ‘strtok_r’ was not declared in this scope Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Keywords: bisected, regression Severity: normal Priority: medium Component: Mesa core Assignee: mesa-dev@lists.freedesktop.org Reporter: v...@freedesktop.org QA Contact: mesa-dev@lists.freedesktop.org CC: lem...@gmail.com, marta.lofst...@intel.com mesa: cb758b892a7e62ff1f6187f2ca9ac543ff70a096 (master 11.1.0-devel) MinGW and MSVC build error Compiling src/glsl/linker.cpp ... src/glsl/linker.cpp: In function ‘bool included_in_packed_varying(ir_variable*, const char*)’: src/glsl/linker.cpp:3187:46: error: ‘strtok_r’ was not declared in this scope char *token = strtok_r(list, ",", &saveptr); ^ commit 4639cea2921669527eb43dcb49724c05afb27e8e Author: Tapani Pälli Date: Fri Sep 4 11:30:34 2015 +0300 glsl: add packed varyings to program resource list This makes sure that user is still able to query properties about variables that have gotten packed by lower_packed_varyings pass. Fixes following OpenGL ES 3.1 test: ES31-CTS.program_interface_query.separate-programs-vertex v2: fix 'name included in packed list' check (Ilia Mirkin) v3: iterate over instances of name using strtok_r (Ilia Mirkin) Signed-off-by: Tapani Pälli Reviewed-by: Marta Lofstedt -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
