Re: [Mesa-dev] [PATCH] bin/get-pick-list.sh: fix the oneline printing

2019-01-14 Thread Andres Gomez 
On Fri, 2019-01-11 at 14:56 +, Eric Engestrom wrote:
> On Friday, 2019-01-11 16:42:25 +0200, Andres Gomez wrote:
> > "--summary" will also print extended header information such as
> > creations, renames and mode changes.
> > 
> > Let's just use "-s", which suppresses the diff output.
> > 
> > Fixes: 559c32d2412 ("bin/get-pick-list.sh: simplify git oneline printing")
> > Cc: Juan A. Suarez 
> > Cc: Eric Engestrom 
> > Cc: Dylan Baker 
> > Cc: Emil Velikov 
> > Signed-off-by: Andres Gomez 
> > ---
> >  bin/get-pick-list.sh | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/bin/get-pick-list.sh b/bin/get-pick-list.sh
> > index 3099fc69413..d71ff4a708a 100755
> > --- a/bin/get-pick-list.sh
> > +++ b/bin/get-pick-list.sh
> > @@ -143,7 +143,7 @@ do
> > esac
> >  
> > printf "[ %8s ] " "$tag"
> > -   git --no-pager show --summary --oneline $sha
> > +   git --no-pager show -s --oneline $sha
> 
> Small preference for the explicit `--no-patch` instead of `-s`, but:
> Reviewed-by: Eric Engestrom 

Changed locally and pushed.

Thanks for the review!

> 
> >  done
> >  
> >  rm -f already_picked
> > -- 
> > 2.18.0
> > 
> > ___
> > mesa-dev mailing list
> > mesa-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> 
> 
-- 
Br,

Andres
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] bin/get-pick-list.sh: fix the oneline printing

2019-01-14 Thread Juan A. Suarez Romero 
On Fri, 2019-01-11 at 16:42 +0200, Andres Gomez wrote:
> "--summary" will also print extended header information such as
> creations, renames and mode changes.
> 
> Let's just use "-s", which suppresses the diff output.

Reviewed-by: Juan A. Suarez 


J.A.
> 
> Fixes: 559c32d2412 ("bin/get-pick-list.sh: simplify git oneline printing")
> Cc: Juan A. Suarez 
> Cc: Eric Engestrom 
> Cc: Dylan Baker 
> Cc: Emil Velikov 
> Signed-off-by: Andres Gomez 
> ---
>  bin/get-pick-list.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/bin/get-pick-list.sh b/bin/get-pick-list.sh
> index 3099fc69413..d71ff4a708a 100755
> --- a/bin/get-pick-list.sh
> +++ b/bin/get-pick-list.sh
> @@ -143,7 +143,7 @@ do
>   esac
>  
>   printf "[ %8s ] " "$tag"
> - git --no-pager show --summary --oneline $sha
> + git --no-pager show -s --oneline $sha
>  done
>  
>  rm -f already_picked

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] bin/get-pick-list.sh: fix the oneline printing

2019-01-11 Thread Emil Velikov 
On 2019/01/11, Andres Gomez wrote:
> "--summary" will also print extended header information such as
> creations, renames and mode changes.
> 
I might be missing some settings - cannot see any of those here.

Regardless, I have slight inclination towards --no-patch (as Eric
suggested) but either way the patch is

Reviewed-by: Emil Velikov 

-Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] bin/get-pick-list.sh: fix the oneline printing

2019-01-11 Thread Eric Engestrom 
On Friday, 2019-01-11 16:42:25 +0200, Andres Gomez wrote:
> "--summary" will also print extended header information such as
> creations, renames and mode changes.
> 
> Let's just use "-s", which suppresses the diff output.
> 
> Fixes: 559c32d2412 ("bin/get-pick-list.sh: simplify git oneline printing")
> Cc: Juan A. Suarez 
> Cc: Eric Engestrom 
> Cc: Dylan Baker 
> Cc: Emil Velikov 
> Signed-off-by: Andres Gomez 
> ---
>  bin/get-pick-list.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/bin/get-pick-list.sh b/bin/get-pick-list.sh
> index 3099fc69413..d71ff4a708a 100755
> --- a/bin/get-pick-list.sh
> +++ b/bin/get-pick-list.sh
> @@ -143,7 +143,7 @@ do
>   esac
>  
>   printf "[ %8s ] " "$tag"
> - git --no-pager show --summary --oneline $sha
> + git --no-pager show -s --oneline $sha

Small preference for the explicit `--no-patch` instead of `-s`, but:
Reviewed-by: Eric Engestrom 

>  done
>  
>  rm -f already_picked
> -- 
> 2.18.0
> 
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] bin/get-pick-list.sh: fix the oneline printing

2019-01-11 Thread Andres Gomez 
"--summary" will also print extended header information such as
creations, renames and mode changes.

Let's just use "-s", which suppresses the diff output.

Fixes: 559c32d2412 ("bin/get-pick-list.sh: simplify git oneline printing")
Cc: Juan A. Suarez 
Cc: Eric Engestrom 
Cc: Dylan Baker 
Cc: Emil Velikov 
Signed-off-by: Andres Gomez 
---
 bin/get-pick-list.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bin/get-pick-list.sh b/bin/get-pick-list.sh
index 3099fc69413..d71ff4a708a 100755
--- a/bin/get-pick-list.sh
+++ b/bin/get-pick-list.sh
@@ -143,7 +143,7 @@ do
esac
 
printf "[ %8s ] " "$tag"
-   git --no-pager show --summary --oneline $sha
+   git --no-pager show -s --oneline $sha
 done
 
 rm -f already_picked
-- 
2.18.0

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev