Re: [Mesa-dev] [PATCH] egl: remove redundant initialization
On 2 March 2018 at 11:51, Eric Engestrom wrote: > On Friday, 2018-03-02 13:28:28 +0200, Andres Gomez wrote: >> Found by inspection. >> >> Cc: Ian Romanick >> Cc: Emil Velikov >> Cc: Eric Engestrom >> Signed-off-by: Andres Gomez >> --- >> src/egl/main/eglcontext.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/src/egl/main/eglcontext.c b/src/egl/main/eglcontext.c >> index 18c1bc59acc..3e5d8ad97bf 100644 >> --- a/src/egl/main/eglcontext.c >> +++ b/src/egl/main/eglcontext.c >> @@ -594,7 +594,6 @@ _eglInitContext(_EGLContext *ctx, _EGLDisplay *dpy, >> _EGLConfig *conf, > > For reviewers: the line removed is a duplicate of the line literally > just above the context being printed here. > Thanks Eric - change did raise an eyebrow on quick skim. I'd suggest "s/redundant/duplicate/" or picking your note for the commit message. Either way Reviewed-by: Emil Velikov -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] egl: remove redundant initialization
On Friday, 2018-03-02 13:28:28 +0200, Andres Gomez wrote: > Found by inspection. > > Cc: Ian Romanick > Cc: Emil Velikov > Cc: Eric Engestrom > Signed-off-by: Andres Gomez > --- > src/egl/main/eglcontext.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/egl/main/eglcontext.c b/src/egl/main/eglcontext.c > index 18c1bc59acc..3e5d8ad97bf 100644 > --- a/src/egl/main/eglcontext.c > +++ b/src/egl/main/eglcontext.c > @@ -594,7 +594,6 @@ _eglInitContext(_EGLContext *ctx, _EGLDisplay *dpy, > _EGLConfig *conf, For reviewers: the line removed is a duplicate of the line literally just above the context being printed here. Reviewed-by: Eric Engestrom > ctx->ClientMajorVersion = 1; /* the default, per EGL spec */ > ctx->ClientMinorVersion = 0; > ctx->Flags = 0; > - ctx->Profile = EGL_CONTEXT_OPENGL_CORE_PROFILE_BIT_KHR; > ctx->ResetNotificationStrategy = EGL_NO_RESET_NOTIFICATION_KHR; > ctx->ContextPriority = EGL_CONTEXT_PRIORITY_MEDIUM_IMG; > ctx->ReleaseBehavior = EGL_CONTEXT_RELEASE_BEHAVIOR_FLUSH_KHR; > -- > 2.15.1 > ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] egl: remove redundant initialization
Reviewed-by: Tapani Pälli On 03/02/2018 01:28 PM, Andres Gomez wrote: Found by inspection. Cc: Ian Romanick Cc: Emil Velikov Cc: Eric Engestrom Signed-off-by: Andres Gomez --- src/egl/main/eglcontext.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/egl/main/eglcontext.c b/src/egl/main/eglcontext.c index 18c1bc59acc..3e5d8ad97bf 100644 --- a/src/egl/main/eglcontext.c +++ b/src/egl/main/eglcontext.c @@ -594,7 +594,6 @@ _eglInitContext(_EGLContext *ctx, _EGLDisplay *dpy, _EGLConfig *conf, ctx->ClientMajorVersion = 1; /* the default, per EGL spec */ ctx->ClientMinorVersion = 0; ctx->Flags = 0; - ctx->Profile = EGL_CONTEXT_OPENGL_CORE_PROFILE_BIT_KHR; ctx->ResetNotificationStrategy = EGL_NO_RESET_NOTIFICATION_KHR; ctx->ContextPriority = EGL_CONTEXT_PRIORITY_MEDIUM_IMG; ctx->ReleaseBehavior = EGL_CONTEXT_RELEASE_BEHAVIOR_FLUSH_KHR; ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH] egl: remove redundant initialization
Found by inspection. Cc: Ian Romanick Cc: Emil Velikov Cc: Eric Engestrom Signed-off-by: Andres Gomez --- src/egl/main/eglcontext.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/egl/main/eglcontext.c b/src/egl/main/eglcontext.c index 18c1bc59acc..3e5d8ad97bf 100644 --- a/src/egl/main/eglcontext.c +++ b/src/egl/main/eglcontext.c @@ -594,7 +594,6 @@ _eglInitContext(_EGLContext *ctx, _EGLDisplay *dpy, _EGLConfig *conf, ctx->ClientMajorVersion = 1; /* the default, per EGL spec */ ctx->ClientMinorVersion = 0; ctx->Flags = 0; - ctx->Profile = EGL_CONTEXT_OPENGL_CORE_PROFILE_BIT_KHR; ctx->ResetNotificationStrategy = EGL_NO_RESET_NOTIFICATION_KHR; ctx->ContextPriority = EGL_CONTEXT_PRIORITY_MEDIUM_IMG; ctx->ReleaseBehavior = EGL_CONTEXT_RELEASE_BEHAVIOR_FLUSH_KHR; -- 2.15.1 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
