Re: [Mesa-dev] [PATCH] meson: Set .so version for xa like autotools does

2018-04-05 Thread Emil Velikov
On 4 April 2018 at 18:58, Dylan Baker  wrote:
> Fixes: 0ba909f0f111824223bc38563d1a6bc73e69c2cc
>("meson: build gallium xa state tracker")
> Signed-off-by: Dylan Baker 

Reviewed-by: Emil Velikov 

Please land this as-is, and take a look at the other bits mentioned below.

Thanks
Emil

Skimming through the other version tags:
 - nine - polish
nine_version = '1.0.0' + remove the .join
 - opencl - bug
the meson icd file has ...so.1.0 whereas the autotools one has ...so.1
 - osmesa - bug
the meson pkg file has 8.0.0 whereas the autotools one has 8
 - xvmc,vdpau - bug
missing the version all together
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH] meson: Set .so version for xa like autotools does

2018-04-05 Thread Eric Engestrom
On Wednesday, 2018-04-04 10:58:29 -0700, Dylan Baker wrote:
> Fixes: 0ba909f0f111824223bc38563d1a6bc73e69c2cc
>("meson: build gallium xa state tracker")
> Signed-off-by: Dylan Baker 

Reviewed-by: Eric Engestrom 

> ---
>  src/gallium/targets/xa/meson.build | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/src/gallium/targets/xa/meson.build 
> b/src/gallium/targets/xa/meson.build
> index ea6e1296dae..733ef54ff85 100644
> --- a/src/gallium/targets/xa/meson.build
> +++ b/src/gallium/targets/xa/meson.build
> @@ -30,6 +30,7 @@ if with_ld_version_script
>xa_link_depends += files('xa.sym')
>  endif
>  
> +_xa_version = '.'.join(xa_version)
>  
>  libxatracker = shared_library(
>'xatracker',
> @@ -49,12 +50,13 @@ libxatracker = shared_library(
>dependencies : [
>  dep_thread, driver_nouveau, driver_i915, driver_svga, driver_freedreno,
>],
> +  version : _xa_version,
>install : true,
>  )
>  
>  pkg.generate(
>name : 'xatracker',
>description : 'Xorg gallium3D acceleration library',
> -  version : '.'.join(xa_version),
> +  version : _xa_version,
>libraries : libxatracker,
>  )
> -- 
> 2.16.3
> 
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [PATCH] meson: Set .so version for xa like autotools does

2018-04-04 Thread Dylan Baker
Fixes: 0ba909f0f111824223bc38563d1a6bc73e69c2cc
   ("meson: build gallium xa state tracker")
Signed-off-by: Dylan Baker 
---
 src/gallium/targets/xa/meson.build | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/gallium/targets/xa/meson.build 
b/src/gallium/targets/xa/meson.build
index ea6e1296dae..733ef54ff85 100644
--- a/src/gallium/targets/xa/meson.build
+++ b/src/gallium/targets/xa/meson.build
@@ -30,6 +30,7 @@ if with_ld_version_script
   xa_link_depends += files('xa.sym')
 endif
 
+_xa_version = '.'.join(xa_version)
 
 libxatracker = shared_library(
   'xatracker',
@@ -49,12 +50,13 @@ libxatracker = shared_library(
   dependencies : [
 dep_thread, driver_nouveau, driver_i915, driver_svga, driver_freedreno,
   ],
+  version : _xa_version,
   install : true,
 )
 
 pkg.generate(
   name : 'xatracker',
   description : 'Xorg gallium3D acceleration library',
-  version : '.'.join(xa_version),
+  version : _xa_version,
   libraries : libxatracker,
 )
-- 
2.16.3

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev