Re: [Mesa-dev] [PATCH] nvc0/ir: fix textureGather with a single offset

2016-10-12 Thread Samuel Pitoiset
You fixed the recent regressions, thanks! Reviewed-by: Samuel Pitoiset On 10/12/2016 04:26 PM, Ilia Mirkin wrote: Recent fix for non-const offsets broke the case of a single offset (vs 4 offsets). The later code relies on the offs array to contain null values to

[Mesa-dev] [PATCH] nvc0/ir: fix textureGather with a single offset

2016-10-12 Thread Ilia Mirkin
Recent fix for non-const offsets broke the case of a single offset (vs 4 offsets). The later code relies on the offs array to contain null values to tell whether they should be added onto the srcs list. Fixes: 5239bd592 ("nvc0/ir: fix overwriting of value backing non-constant gather offset")