Re: [Mesa-dev] [PATCH] radv: Really use correct HTILE expanded words.

2018-02-23 Thread Bas Nieuwenhuizen
On Fri, Feb 23, 2018 at 11:52 AM, James Legg wrote: > On Thu, 2018-02-22 at 22:48 +0100, Bas Nieuwenhuizen wrote: >> since IIRC the last change was also done due to Feral noticing and we >> are clearly lacking testcases in this area, can you check that that >> case

Re: [Mesa-dev] [PATCH] radv: Really use correct HTILE expanded words.

2018-02-23 Thread James Legg
On Thu, 2018-02-22 at 22:48 +0100, Bas Nieuwenhuizen wrote: > since IIRC the last change was also done due to Feral noticing and we > are clearly lacking testcases in this area, can you check that that > case still works for you? Thanks a lot! I looked at an issue that was fixed with

Re: [Mesa-dev] [PATCH] radv: Really use correct HTILE expanded words.

2018-02-22 Thread Grazvydas Ignotas
Seems to fix dxvk, nice! Also tested DOOM which still works. Tested-by: Grazvydas Ignotas On Thu, Feb 22, 2018 at 6:57 PM, James Legg wrote: > When transitioning to an htile compressed depth format, Set the full > depth range, so later

Re: [Mesa-dev] [PATCH] radv: Really use correct HTILE expanded words.

2018-02-22 Thread Bas Nieuwenhuizen
yeah, looks like I may have lifted the values from a driver which set the ZRANGE_PRECISION to 0, but this at least mirrors PAL and fixes one of the remaining transition issues there that I was aware of. Reviewed-by: Bas Nieuwenhuizen since IIRC the last change was also

[Mesa-dev] [PATCH] radv: Really use correct HTILE expanded words.

2018-02-22 Thread James Legg
When transitioning to an htile compressed depth format, Set the full depth range, so later rasterization can pass HiZ. Previously, for depth only formats, the depth range was set to 0 to 0. This caused unwanted HiZ rejections with a VK_FORMAT_D16_UNORM depth buffer (VK_FORMAT_D32_SFLOAT was not