Re: [Mesa-dev] [PATCH] radv: enable the Polaris small primitive filter control

[Bas Nieuwenhuizen]

Reviewed-by: Bas Nieuwenhuizen 

On Thu, Apr 5, 2018 at 10:27 AM, Samuel Pitoiset
 wrote:
> Enable it directly in the preamble, but do not enable line
> on Polaris10/11/12 because there is a hw bug.
>
> There is possibly an issue when MSAA is off, but this doesn't
> regress any CTS and AMDVLK doesn't have a workaround as well.
>
> Signed-off-by: Samuel Pitoiset 
> ---
>  src/amd/vulkan/si_cmd_buffer.c | 15 +++
>  1 file changed, 15 insertions(+)
>
> diff --git a/src/amd/vulkan/si_cmd_buffer.c b/src/amd/vulkan/si_cmd_buffer.c
> index 0970eff103..aed291be35 100644
> --- a/src/amd/vulkan/si_cmd_buffer.c
> +++ b/src/amd/vulkan/si_cmd_buffer.c
> @@ -539,6 +539,21 @@ si_emit_config(struct radv_physical_device 
> *physical_device,
>S_028004_ZPASS_INCREMENT_DISABLE(1));
> }
>
> +   /* Enable the Polaris small primitive filter control.
> +* XXX: There is possibly an issue when MSAA is off (see RadeonSI
> +* has_msaa_sample_loc_bug). But this doesn't seem to regress 
> anything,
> +* and AMDVLK doesn't have a workaround as well.
> +*/
> +   if (physical_device->rad_info.family >= CHIP_POLARIS10) {
> +   unsigned small_prim_filter_cntl =
> +   S_028830_SMALL_PRIM_FILTER_ENABLE(1) |
> +   /* Workaround for a hw line bug. */
> +   
> S_028830_LINE_FILTER_DISABLE(physical_device->rad_info.family <= 
> CHIP_POLARIS12);
> +
> +   radeon_set_context_reg(cs, 
> R_028830_PA_SU_SMALL_PRIM_FILTER_CNTL,
> +  small_prim_filter_cntl);
> +   }
> +
> si_emit_compute(physical_device, cs);
>  }
>
> --
> 2.16.3
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] radv: enable the Polaris small primitive filter control

[Samuel Pitoiset]

Enable it directly in the preamble, but do not enable line
on Polaris10/11/12 because there is a hw bug.

There is possibly an issue when MSAA is off, but this doesn't
regress any CTS and AMDVLK doesn't have a workaround as well.

Signed-off-by: Samuel Pitoiset 
---
 src/amd/vulkan/si_cmd_buffer.c | 15 +++
 1 file changed, 15 insertions(+)

diff --git a/src/amd/vulkan/si_cmd_buffer.c b/src/amd/vulkan/si_cmd_buffer.c
index 0970eff103..aed291be35 100644
--- a/src/amd/vulkan/si_cmd_buffer.c
+++ b/src/amd/vulkan/si_cmd_buffer.c
@@ -539,6 +539,21 @@ si_emit_config(struct radv_physical_device 
*physical_device,
   S_028004_ZPASS_INCREMENT_DISABLE(1));
}
 
+   /* Enable the Polaris small primitive filter control.
+* XXX: There is possibly an issue when MSAA is off (see RadeonSI
+* has_msaa_sample_loc_bug). But this doesn't seem to regress anything,
+* and AMDVLK doesn't have a workaround as well.
+*/
+   if (physical_device->rad_info.family >= CHIP_POLARIS10) {
+   unsigned small_prim_filter_cntl =
+   S_028830_SMALL_PRIM_FILTER_ENABLE(1) |
+   /* Workaround for a hw line bug. */
+   
S_028830_LINE_FILTER_DISABLE(physical_device->rad_info.family <= 
CHIP_POLARIS12);
+
+   radeon_set_context_reg(cs, 
R_028830_PA_SU_SMALL_PRIM_FILTER_CNTL,
+  small_prim_filter_cntl);
+   }
+
si_emit_compute(physical_device, cs);
 }
 
-- 
2.16.3

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev