Re: [Mesa-dev] [PATCH] spirv: Emit switch conditions on-the-fly

2019-01-12 Thread Lionel Landwerlin
On 12/01/2019 15:29, Jason Ekstrand wrote: On January 12, 2019 03:06:07 Lionel Landwerlin wrote: On 12/01/2019 03:45, Jason Ekstrand wrote: Instead of emitting all of the conditions for the cases of a switch statement up-front, emit them on-the-fly as we emit the code for each case.  The

Re: [Mesa-dev] [PATCH] spirv: Emit switch conditions on-the-fly

2019-01-12 Thread Jason Ekstrand
On January 12, 2019 03:06:07 Lionel Landwerlin wrote: On 12/01/2019 03:45, Jason Ekstrand wrote: Instead of emitting all of the conditions for the cases of a switch statement up-front, emit them on-the-fly as we emit the code for each case. The original justification for this was that we

Re: [Mesa-dev] [PATCH] spirv: Emit switch conditions on-the-fly

2019-01-12 Thread Lionel Landwerlin
On 12/01/2019 03:45, Jason Ekstrand wrote: Instead of emitting all of the conditions for the cases of a switch statement up-front, emit them on-the-fly as we emit the code for each case. The original justification for this was that we were going to have to build a default case anyway which

[Mesa-dev] [PATCH] spirv: Emit switch conditions on-the-fly

2019-01-11 Thread Jason Ekstrand
Instead of emitting all of the conditions for the cases of a switch statement up-front, emit them on-the-fly as we emit the code for each case. The original justification for this was that we were going to have to build a default case anyway which would need them all. However, we can just trust