Re: [Mesa-dev] [PATCH] st/mesa: tex offsets can't be in a const or 2d-indexed

2018-04-07 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Apr 3, 2018 at 12:06 AM, Ilia Mirkin wrote: > All consts are now implicitly 2d (they set .Dimension), so trigger > asserts. Also, the texture offset can't handle any sort of 2d indexing. > While this could be

Re: [Mesa-dev] [PATCH] st/mesa: tex offsets can't be in a const or 2d-indexed

2018-04-07 Thread Ilia Mirkin
ping? On Tue, Apr 3, 2018 at 12:06 AM, Ilia Mirkin wrote: > All consts are now implicitly 2d (they set .Dimension), so trigger > asserts. Also, the texture offset can't handle any sort of 2d indexing. > While this could be tacked on, this seems unnecessary, just move it off

[Mesa-dev] [PATCH] st/mesa: tex offsets can't be in a const or 2d-indexed

2018-04-02 Thread Ilia Mirkin
All consts are now implicitly 2d (they set .Dimension), so trigger asserts. Also, the texture offset can't handle any sort of 2d indexing. While this could be tacked on, this seems unnecessary, just move it off into a separate temp. Fixes assertion failure in