Re: [Mesa-dev] [PATCH] virgl: add shader offset alignment to to v2 caps struct

2018-06-04 Thread Dave Airlie
On 5 June 2018 at 03:27, Gurchetan Singh wrote: > I sent out a patch that adds capability bits to this struct, and the > first bit is the tgsi invariant capability. It's dependent on this > patch to apply correctly to master. Oops I dropped the ball there,I saw the renderer patches had landed an

Re: [Mesa-dev] [PATCH] virgl: add shader offset alignment to to v2 caps struct

2018-06-04 Thread Gurchetan Singh
I sent out a patch that adds capability bits to this struct, and the first bit is the tgsi invariant capability. It's dependent on this patch to apply correctly to master. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop

Re: [Mesa-dev] [PATCH] virgl: add shader offset alignment to to v2 caps struct

2018-06-04 Thread Gurchetan Singh
Got it, thanks. Let me send a patch to virglrenderer to change tgsi_invariant to some sort of bitset, since when it lands it'll just need one bit. On Mon, Jun 4, 2018 at 9:39 AM Gert Wollny wrote: > > Am Montag, den 04.06.2018, 09:07 -0700 schrieb Gurchetan Singh: > > The tgsi_invariant code neve

Re: [Mesa-dev] [PATCH] virgl: add shader offset alignment to to v2 caps struct

2018-06-04 Thread Gert Wollny
Am Montag, den 04.06.2018, 09:07 -0700 schrieb Gurchetan Singh: > The tgsi_invariant code never landed in the Mesa side. Is the caps > code is resilient enough to handle this case? From my understanding > the guest caps and host caps don't have to match exactly, and the > "right thing" will be do

Re: [Mesa-dev] [PATCH] virgl: add shader offset alignment to to v2 caps struct

2018-06-04 Thread Gurchetan Singh
The tgsi_invariant code never landed in the Mesa side. Is the caps code is resilient enough to handle this case? From my understanding the guest caps and host caps don't have to match exactly, and the "right thing" will be done. On Mon, Jun 4, 2018 at 6:03 AM Gert Wollny wrote: > > Am Donnerstag

[Mesa-dev] [PATCH] virgl: add shader offset alignment to to v2 caps struct

2018-06-04 Thread gurchetansi...@chromium.org
This is the SSBO analogue to fe0647. User supplied data must be a multiple of GL_SHADER_STORAGE_BUFFER_OFFSET_ALIGNMENT. This fixes 44 GLES31 tests on airlied@'s GLES31 sketch branches with Nvidia hardware, but this patch standalone can applied to master. The alignment restriction on Nvidia is 32,

Re: [Mesa-dev] [PATCH] virgl: add shader offset alignment to to v2 caps struct

2018-06-04 Thread Gert Wollny
Am Donnerstag, den 12.04.2018, 18:11 -0700 schrieb gurchetansi...@chromium.org: > This is the SSBO analogue to fe0647. User supplied data must > be a multiple of GL_SHADER_STORAGE_BUFFER_OFFSET_ALIGNMENT. > > This fixes 44 GLES31 tests on airlied@'s GLES31 sketch branches with > Nvidia hardware, b

[Mesa-dev] [PATCH] virgl: add shader offset alignment to to v2 caps struct

2018-04-12 Thread gurchetansi...@chromium.org
This is the SSBO analogue to fe0647. User supplied data must be a multiple of GL_SHADER_STORAGE_BUFFER_OFFSET_ALIGNMENT. This fixes 44 GLES31 tests on airlied@'s GLES31 sketch branches with Nvidia hardware, but this patch standalone can applied to master. The alignment restriction on Nvidia is 32,

Re: [Mesa-dev] [PATCH] virgl: add shader offset alignment to to v2 caps struct

2018-04-12 Thread Ilia Mirkin
On Thu, Apr 12, 2018 at 8:33 PM, Gurchetan Singh wrote: > From: "gurchetansi...@chromium.org" > > This is the SSBO analogue to fe0647. User supplied data must > be a multiple of GL_SHADER_STORAGE_BUFFER_OFFSET_ALIGNMENT. > > This fixes 44 GLES31 tests on airlied@'s GLES31 sketch branches with > N

[Mesa-dev] [PATCH] virgl: add shader offset alignment to to v2 caps struct

2018-04-12 Thread Gurchetan Singh
From: "gurchetansi...@chromium.org" This is the SSBO analogue to fe0647. User supplied data must be a multiple of GL_SHADER_STORAGE_BUFFER_OFFSET_ALIGNMENT. This fixes 44 GLES31 tests on airlied@'s GLES31 sketch branches with Nvidia hardware, but this patch standalone can applied to master. The