On Tuesday, October 18, 2016 8:28:02 AM PDT Jason Ekstrand wrote:
> On Tue, Oct 18, 2016 at 8:14 AM, Jason Ekstrand
> wrote:
>
> > I want to make a few comments on how this series is structured. This is
> > not the way I would have done it and I think the way you structured it
> > makes it subst
On Tue, Oct 18, 2016 at 8:28 AM, Jason Ekstrand
wrote:
> On Tue, Oct 18, 2016 at 8:14 AM, Jason Ekstrand
> wrote:
>
>> I want to make a few comments on how this series is structured. This is
>> not the way I would have done it and I think the way you structured it
>> makes it substantially less
On Tue, Oct 18, 2016 at 8:14 AM, Jason Ekstrand
wrote:
> I want to make a few comments on how this series is structured. This is
> not the way I would have done it and I think the way you structured it
> makes it substantially less rebasable than it could be and a bit harder to
> review. The wa
On Mon, Oct 17, 2016 at 11:12 PM, Timothy Arceri <
timothy.arc...@collabora.com> wrote:
> ---
> src/mesa/drivers/dri/i965/brw_context.h | 6 ++---
> src/mesa/drivers/dri/i965/brw_draw.c | 2 +-
> src/mesa/drivers/dri/i965/brw_program.c | 2 +-
> src/mesa/driver
I want to make a few comments on how this series is structured. This is
not the way I would have done it and I think the way you structured it
makes it substantially less rebasable than it could be and a bit harder to
review. The way *I* would have done this would be something like the
following:
---
src/mesa/drivers/dri/i965/brw_context.h | 6 ++---
src/mesa/drivers/dri/i965/brw_draw.c | 2 +-
src/mesa/drivers/dri/i965/brw_program.c | 2 +-
src/mesa/drivers/dri/i965/brw_tcs.c | 32 ++-
src/mesa/drivers/dri/i965/brw_tcs_
