Re: [Mesa-dev] [PATCH 1/2] gbm: Introduce a helper function for printing GBM format names.

2018-11-06 Thread Daniel Stone
Hi, On Tue, 6 Nov 2018 at 13:11, Eric Engestrom wrote: > On Friday, 2018-11-02 14:40:49 -0700, Eric Anholt wrote: > > +GBM_EXPORT char * > > +gbm_format_get_name(uint32_t gbm_format, struct gbm_format_name_desc *desc) > > +{ > > Actually, This won't work with the two GBM_BO_FORMAT_{X,A}RGB;

Re: [Mesa-dev] [PATCH 1/2] gbm: Introduce a helper function for printing GBM format names.

2018-11-06 Thread Eric Engestrom
On Friday, 2018-11-02 14:40:49 -0700, Eric Anholt wrote: > This requires that the caller make a little (stack) allocation to store > the string. > --- > src/gbm/main/gbm.c | 18 ++ > src/gbm/main/gbm.h | 6 ++ > 2 files changed, 24 insertions(+) > > diff --git

[Mesa-dev] [PATCH 1/2] gbm: Introduce a helper function for printing GBM format names.

2018-11-02 Thread Eric Anholt
This requires that the caller make a little (stack) allocation to store the string. --- src/gbm/main/gbm.c | 18 ++ src/gbm/main/gbm.h | 6 ++ 2 files changed, 24 insertions(+) diff --git a/src/gbm/main/gbm.c b/src/gbm/main/gbm.c index 0bf2922bacdd..174f62ad797f 100644 ---