Re: [Mesa-dev] [PATCH 1/2] glsl: always enable OES_standard_derivatives features if supported

2018-05-21 Thread Timothy Arceri
On 22/05/18 03:13, Ian Romanick wrote: On 05/16/2018 12:04 AM, Timothy Arceri wrote: The GLSL ES 1.0 spec made these features optional. With OES_standard_derivatives they are guaranteed to be available but currently the extension must be enabled to use them. Instead this changes the code to

Re: [Mesa-dev] [PATCH 1/2] glsl: always enable OES_standard_derivatives features if supported

2018-05-21 Thread Ian Romanick
On 05/16/2018 12:04 AM, Timothy Arceri wrote: > The GLSL ES 1.0 spec made these features optional. With > OES_standard_derivatives they are guaranteed to be available > but currently the extension must be enabled to use them. > > Instead this changes the code to check if the driver supports > the

Re: [Mesa-dev] [PATCH 1/2] glsl: always enable OES_standard_derivatives features if supported

2018-05-16 Thread Timothy Arceri
On 16/05/18 22:29, Ilia Mirkin wrote: On Wed, May 16, 2018 at 8:26 AM, Timothy Arceri wrote: On 16/05/18 22:09, Ilia Mirkin wrote: On Wed, May 16, 2018 at 8:04 AM, Timothy Arceri wrote: On 16/05/18 21:12, Ilia Mirkin wrote: From

Re: [Mesa-dev] [PATCH 1/2] glsl: always enable OES_standard_derivatives features if supported

2018-05-16 Thread Ilia Mirkin
On Wed, May 16, 2018 at 8:26 AM, Timothy Arceri wrote: > > > On 16/05/18 22:09, Ilia Mirkin wrote: >> >> On Wed, May 16, 2018 at 8:04 AM, Timothy Arceri >> wrote: >>> >>> >>> >>> On 16/05/18 21:12, Ilia Mirkin wrote: From the spec,

Re: [Mesa-dev] [PATCH 1/2] glsl: always enable OES_standard_derivatives features if supported

2018-05-16 Thread Timothy Arceri
On 16/05/18 22:09, Ilia Mirkin wrote: On Wed, May 16, 2018 at 8:04 AM, Timothy Arceri wrote: On 16/05/18 21:12, Ilia Mirkin wrote: From the spec, """ The built-in derivative functions dFdx, dFdy, and fwidth are optional, and must be enabled by

Re: [Mesa-dev] [PATCH 1/2] glsl: always enable OES_standard_derivatives features if supported

2018-05-16 Thread Timothy Arceri
On 16/05/18 22:09, Ilia Mirkin wrote: On Wed, May 16, 2018 at 8:04 AM, Timothy Arceri wrote: On 16/05/18 21:12, Ilia Mirkin wrote: From the spec, """ The built-in derivative functions dFdx, dFdy, and fwidth are optional, and must be enabled by

Re: [Mesa-dev] [PATCH 1/2] glsl: always enable OES_standard_derivatives features if supported

2018-05-16 Thread Ilia Mirkin
On Wed, May 16, 2018 at 8:04 AM, Timothy Arceri wrote: > > > On 16/05/18 21:12, Ilia Mirkin wrote: >> >> From the spec, >> >> """ >> The built-in derivative functions dFdx, dFdy, and fwidth are >> optional, and >> must be enabled by >> >> #extension

Re: [Mesa-dev] [PATCH 1/2] glsl: always enable OES_standard_derivatives features if supported

2018-05-16 Thread Timothy Arceri
On 16/05/18 21:12, Ilia Mirkin wrote: From the spec, """ The built-in derivative functions dFdx, dFdy, and fwidth are optional, and must be enabled by #extension GL_OES_standard_derivatives : enable before being used. """ Sounds like you need an application override?

Re: [Mesa-dev] [PATCH 1/2] glsl: always enable OES_standard_derivatives features if supported

2018-05-16 Thread Ilia Mirkin
From the spec, """ The built-in derivative functions dFdx, dFdy, and fwidth are optional, and must be enabled by #extension GL_OES_standard_derivatives : enable before being used. """ Sounds like you need an application override? On Wed, May 16, 2018 at 3:04 AM, Timothy Arceri

[Mesa-dev] [PATCH 1/2] glsl: always enable OES_standard_derivatives features if supported

2018-05-16 Thread Timothy Arceri
The GLSL ES 1.0 spec made these features optional. With OES_standard_derivatives they are guaranteed to be available but currently the extension must be enabled to use them. Instead this changes the code to check if the driver supports the extension and if so always enables them. This fixes