Re: [Mesa-dev] [PATCH 10/10] i965: use nir unrolling for scalar backend Gen7+

2016-09-15 Thread Timothy Arceri
On Fri, 2016-09-16 at 12:17 +1000, Timothy Arceri wrote: > On Thu, 2016-09-15 at 21:22 -0400, Connor Abbott wrote: > > > > On Thu, Sep 15, 2016 at 9:06 PM, Timothy Arceri > > wrote: > > > > > > > > > On Thu, 2016-09-15 at 19:49 -0400, Connor Abbott wrote: > > > > > > > > > > > > This seems a

Re: [Mesa-dev] [PATCH 10/10] i965: use nir unrolling for scalar backend Gen7+

2016-09-15 Thread Timothy Arceri
On Thu, 2016-09-15 at 21:22 -0400, Connor Abbott wrote: > On Thu, Sep 15, 2016 at 9:06 PM, Timothy Arceri > wrote: > > > > On Thu, 2016-09-15 at 19:49 -0400, Connor Abbott wrote: > > > > > > This seems a little dubious... why restrict it to gen7+? > > > > Because if we don't switch to using nir

Re: [Mesa-dev] [PATCH 10/10] i965: use nir unrolling for scalar backend Gen7+

2016-09-15 Thread Connor Abbott
On Thu, Sep 15, 2016 at 9:06 PM, Timothy Arceri wrote: > On Thu, 2016-09-15 at 19:49 -0400, Connor Abbott wrote: >> This seems a little dubious... why restrict it to gen7+? > > Because if we don't switch to using nir_lower_indirect_derefs() then > lower_variable_index_to_cond_assign() makes a big

Re: [Mesa-dev] [PATCH 10/10] i965: use nir unrolling for scalar backend Gen7+

2016-09-15 Thread Timothy Arceri
On Thu, 2016-09-15 at 19:49 -0400, Connor Abbott wrote: > This seems a little dubious... why restrict it to gen7+? Because if we don't switch to using nir_lower_indirect_derefs() then lower_variable_index_to_cond_assign() makes a big mess before we get to unrolling. I was getting piglit regression

Re: [Mesa-dev] [PATCH 10/10] i965: use nir unrolling for scalar backend Gen7+

2016-09-15 Thread Connor Abbott
This seems a little dubious... why restrict it to gen7+? And why only scalar? This pass assumes SSA, but so do many other passes in core NIR that we also run in nir_optimize(), so that shouldn't be a problem. On Thu, Sep 15, 2016 at 3:03 AM, Timothy Arceri wrote: > --- > src/compiler/glsl/glsl_p

[Mesa-dev] [PATCH 10/10] i965: use nir unrolling for scalar backend Gen7+

2016-09-15 Thread Timothy Arceri
--- src/compiler/glsl/glsl_parser_extras.cpp | 12 + src/mesa/drivers/dri/i965/brw_compiler.c | 42 +++- src/mesa/drivers/dri/i965/brw_nir.c | 23 + 3 files changed, 55 insertions(+), 22 deletions(-) diff --git a/src/compiler/glsl/glsl_pars