Re: [Mesa-dev] [PATCH 14/14] mesa: remove gl_shader_compiler_options::EmitNoNoise

2016-10-18 Thread Nicolai Hähnle
Patches 5-12, 14 are Reviewed-by: Nicolai Hähnle Those inline-explosion tests have been bugging me as well, but realistically speaking, the compiler needs to be at least robust enough to just not blow up and instead refuse compilation before any work on proper

Re: [Mesa-dev] [PATCH 14/14] mesa: remove gl_shader_compiler_options::EmitNoNoise

2016-10-17 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick If we ever want to support the noise built-in functions, we'll have to implement them as functions... that will get inlined. :) On 10/17/2016 06:39 AM, Marek Olšák wrote: > From: Marek Olšák > > it's

[Mesa-dev] [PATCH 14/14] mesa: remove gl_shader_compiler_options::EmitNoNoise

2016-10-17 Thread Marek Olšák
From: Marek Olšák it's always true --- src/mesa/drivers/dri/i915/i915_context.c | 1 - src/mesa/drivers/dri/i965/brw_compiler.c | 1 - src/mesa/main/mtypes.h | 1 - src/mesa/program/ir_to_mesa.cpp | 3 +-- src/mesa/state_tracker/st_extensions.c